GNU bug report logs - #52518
Log only vc-command-messages

Previous Next

Full log

Message #16 received at 52518 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Juri Linkov <juri <at> linkov.net>
Cc: 52518 <at> debbugs.gnu.org
Subject: Re: bug#52518: Log only vc-command-messages
Date: Thu, 16 Dec 2021 10:01:22 -0800

Juri Linkov <juri <at> linkov.net> writes:

> I agree these should be refactored.  I was unsure if selected-window
> changes during function execution, but this would be better:

Thanks.  Some documentation comments:

> diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el
> index 346974bdba..4adc01fbfc 100644
> --- a/lisp/vc/vc-dispatcher.el
> +++ b/lisp/vc/vc-dispatcher.el
> @@ -127,8 +127,12 @@ vc-delete-logbuf-window
>    :group 'vc)
>
>  (defcustom vc-command-messages nil
> -  "If non-nil, display run messages from back-end commands."
> -  :type 'boolean
> +  "If non-nil, log run messages from back-end commands.
> +If `log', messages are logged to the *Messages* buffer, but not displayed.
> +Other non-nil values also display run messages in the echo area."

Would this be simpler?

    If non-nil, display and log run messages from back-end commands.
    If `log', messages are logged to the *Messages* buffer but not
    displayed.

> +  :type '(choice (const :tag "No display and no log" nil)
> +                 (const :tag "Display and log messages" t)
> +                 (const :tag "Only log messages without displaying" log))

Perhaps the first one could be:

    No messages

Perhaps the last one could be:

    Log messages

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.