From unknown Sat Sep 13 19:06:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52518 <52518@debbugs.gnu.org> To: bug#52518 <52518@debbugs.gnu.org> Subject: Status: Log only vc-command-messages Reply-To: bug#52518 <52518@debbugs.gnu.org> Date: Sun, 14 Sep 2025 02:06:19 +0000 retitle 52518 Log only vc-command-messages reassign 52518 emacs submitter 52518 Juri Linkov severity 52518 wishlist tag 52518 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 12:32:23 2021 Received: (at submit) by debbugs.gnu.org; 15 Dec 2021 17:32:23 +0000 Received: from localhost ([127.0.0.1]:33593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxY8d-00045A-J5 for submit@debbugs.gnu.org; Wed, 15 Dec 2021 12:32:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:45544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxY8c-000453-C0 for submit@debbugs.gnu.org; Wed, 15 Dec 2021 12:32:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxY8b-00024a-Bh for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 12:32:22 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:59491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxY8Y-0006pi-W0 for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 12:32:20 -0500 Received: (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 594D8200007 for ; Wed, 15 Dec 2021 17:32:15 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Log only vc-command-messages Organization: LINKOV.NET Date: Wed, 15 Dec 2021 19:31:07 +0200 Message-ID: <86zgp1zsf8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Tags: patch It's useful to customize vc-command-messages to t to be able to inspect the performed vc commands in the *Messages* buffer. When something goes wrong, it's clearly visible what command caused the problem. But displaying such all vc commands in the echo area causes too much noise. Here is an option to not display such messages, only log in the *Messages* buffer: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-command-messages-log.patch diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el index 346974bdba..894ca060eb 100644 --- a/lisp/vc/vc-dispatcher.el +++ b/lisp/vc/vc-dispatcher.el @@ -127,8 +127,12 @@ vc-delete-logbuf-window :group 'vc) (defcustom vc-command-messages nil - "If non-nil, display run messages from back-end commands." - :type 'boolean + "If non-nil, log run messages from back-end commands. +If `log', messages are logged to the *Messages* buffer, but not displayed. +Other non-nil values also display run messages in the echo area." + :type '(choice (const :tag "No display and no log" nil) + (const :tag "Display and log messages" t) + (const :tag "Only log messages without displaying" log)) :group 'vc) (defcustom vc-suppress-confirm nil @@ -335,7 +339,9 @@ vc-do-command (apply #'start-file-process command (current-buffer) command squeezed)))) (when vc-command-messages - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (let ((inhibit-message + (or (eq vc-command-messages 'log) + (eq (selected-window) (active-minibuffer-window))))) (message "Running in background: %s" full-command))) ;; Get rid of the default message insertion, in case we don't ;; set a sentinel explicitly. @@ -345,11 +351,15 @@ vc-do-command (when vc-command-messages (vc-run-delayed (let ((message-truncate-lines t) - (inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (inhibit-message + (or (eq vc-command-messages 'log) + (eq (selected-window) (active-minibuffer-window))))) (message "Done in background: %s" full-command))))) ;; Run synchronously (when vc-command-messages - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (let ((inhibit-message + (or (eq vc-command-messages 'log) + (eq (selected-window) (active-minibuffer-window))))) (message "Running in foreground: %s" full-command))) (let ((buffer-undo-list t)) (setq status (apply #'process-file command nil t nil squeezed))) @@ -364,7 +374,9 @@ vc-do-command (if (integerp status) (format "status %d" status) status) full-command)) (when vc-command-messages - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (let ((inhibit-message + (or (eq vc-command-messages 'log) + (eq (selected-window) (active-minibuffer-window))))) (message "Done (status=%d): %s" status full-command))))) (vc-run-delayed (run-hook-with-args 'vc-post-command-functions --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 17:02:40 2021 Received: (at 52518) by debbugs.gnu.org; 15 Dec 2021 22:02:41 +0000 Received: from localhost ([127.0.0.1]:33887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxcMC-00077y-Kw for submit@debbugs.gnu.org; Wed, 15 Dec 2021 17:02:40 -0500 Received: from mail-pf1-f176.google.com ([209.85.210.176]:47073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxcMB-00077Y-5a for 52518@debbugs.gnu.org; Wed, 15 Dec 2021 17:02:39 -0500 Received: by mail-pf1-f176.google.com with SMTP id o4so21836929pfp.13 for <52518@debbugs.gnu.org>; Wed, 15 Dec 2021 14:02:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=9KTMDkr4ptT4A/Lgbj435U2573THcRW2E6aJBw1kQtM=; b=VZPWPRfuSN84g3as9G9mhYz99KYNdngyBCaUicw0E2wvZQ5PBoafBV0LxN3rewfTFf S9MZewTNbzunWgC6qLQQpzeYkIFvg6aUf9ob8P5q0eFcjuEy8UoEWT8oJkkkw07qimjM F1Yd+nqj/iRCUPvj2z5xPNgz4hMdFevQNjDQeo/FEtMZ7reGjP9W0A/rCbUrHn0wf3Wb 8aDPO+kCtQvLoNVEx7bG+QgreatRI2vwghb3K7I9qjnNKQvAZ83enAFMmMB3Aa2IJqYp 3v0UwTtlpzCtOVMOb54FvWGDmFrQrfKu4K85bpk36ijVgi8Kzk8EJDF4+YkghmO+x3xa 2RwA== X-Gm-Message-State: AOAM532O446K06MXKubX7P8jK1D2hdo8lt/NxFFWq6K7pIFuNPaagYE7 Wnnpm4XeHaZXCBvf5pR44jMzt/LIgVjczltIFivx7ZL+ X-Google-Smtp-Source: ABdhPJwJOE0e7IckbIeOpnywx+UdzKgfcjYHVL7PcFCmYwUg4xsYPPMy0cMXVzpMbjgNyPnmqIhlyRY6DrhQw4In0QQ= X-Received: by 2002:a62:1a03:0:b0:494:64b5:3e01 with SMTP id a3-20020a621a03000000b0049464b53e01mr10918514pfa.35.1639605753265; Wed, 15 Dec 2021 14:02:33 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 15 Dec 2021 14:02:32 -0800 From: Stefan Kangas In-Reply-To: <86zgp1zsf8.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 15 Dec 2021 19:31:07 +0200") References: <86zgp1zsf8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Wed, 15 Dec 2021 14:02:32 -0800 Message-ID: Subject: Re: bug#52518: Log only vc-command-messages To: Juri Linkov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 52518 Cc: 52518@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Juri Linkov writes: > It's useful to customize vc-command-messages to t > to be able to inspect the performed vc commands > in the *Messages* buffer. When something goes wrong, > it's clearly visible what command caused the problem. > > But displaying such all vc commands in the echo area > causes too much noise. Here is an option to not > display such messages, only log in the *Messages* buffer: Good idea. > (when vc-command-messages > - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) > + (let ((inhibit-message > + (or (eq vc-command-messages 'log) > + (eq (selected-window) (active-minibuffer-window))))) > (message "Running in background: %s" full-command))) > ;; Get rid of the default message insertion, in case we don't > ;; set a sentinel explicitly. > @@ -345,11 +351,15 @@ vc-do-command > (when vc-command-messages > (vc-run-delayed > (let ((message-truncate-lines t) > - (inhibit-message (eq (selected-window) (active-minibuffer-window)))) > + (inhibit-message > + (or (eq vc-command-messages 'log) > + (eq (selected-window) (active-minibuffer-window))))) > (message "Done in background: %s" full-command))))) > ;; Run synchronously > (when vc-command-messages > - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) > + (let ((inhibit-message > + (or (eq vc-command-messages 'log) > + (eq (selected-window) (active-minibuffer-window))))) > (message "Running in foreground: %s" full-command))) > (let ((buffer-undo-list t)) > (setq status (apply #'process-file command nil t nil squeezed))) > @@ -364,7 +374,9 @@ vc-do-command > (if (integerp status) (format "status %d" status) status) > full-command)) > (when vc-command-messages > - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) > + (let ((inhibit-message > + (or (eq vc-command-messages 'log) > + (eq (selected-window) (active-minibuffer-window))))) Should these be refactored into a function of their own? It seems a tad repetitive as is. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 17:02:37 2021 Received: (at control) by debbugs.gnu.org; 15 Dec 2021 22:02:37 +0000 Received: from localhost ([127.0.0.1]:33884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxcM9-00077j-FW for submit@debbugs.gnu.org; Wed, 15 Dec 2021 17:02:37 -0500 Received: from mail-pl1-f173.google.com ([209.85.214.173]:43727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxcM7-00077Q-N7 for control@debbugs.gnu.org; Wed, 15 Dec 2021 17:02:36 -0500 Received: by mail-pl1-f173.google.com with SMTP id m24so17688875pls.10 for ; Wed, 15 Dec 2021 14:02:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=pNEJ+LJc3KCjDjlU2DUrgxBn3tRQQR0d0YYBC6uwi3Q=; b=6Ue/dPqJgKfAKSZXmH8+wL6Na7n8QKyPLB7B9LVy7+p5++ieNLgNhM78TjfDmfNv3h uJLI9SmKU39xr9f4r9L6voofBVxHdAn5758fIIqucNY+YLw1qChEa1FUCpTn59az0Kx1 VnXZC2zX0Ige5dxmCXSL43cmtEzasM1Bn+Hfg7tTswHXvr7Ru0TuPUATlKuB2kyIx0q6 mgD2xeig/fTnoVtBnX8LiM5xGJST7bu5ghWtCYfDBBACs/a/Yuo9Fgfa4R7PqVyB8yLw boFVRtGGp18bZSGBbaCoqMe//1mbm/ZjgPKaEUiJ18NY3pCdxOAX4PWVDFzs0QL5z0rr gqMg== X-Gm-Message-State: AOAM533oDN7wb9gKgaTtQBHmcB2YkXfb0zH7Tr7N2xmpwtcagSlQsKQz cbFW5GV5kU8J2NEIwDvc21Ic8X1W9Snr2xnlYNvVvTxf X-Google-Smtp-Source: ABdhPJxTm+c2BGL4Wv/e2vPyVtUZfhGkb3uzoxnQXY16TDkOMqTLzgRwmOB7JI32+hjs2/hRpFmvil9ERZM1JSZ1GRI= X-Received: by 2002:a17:902:8e87:b0:148:a2e8:2c5f with SMTP id bg7-20020a1709028e8700b00148a2e82c5fmr6476517plb.174.1639605749764; Wed, 15 Dec 2021 14:02:29 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 15 Dec 2021 14:02:29 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 15 Dec 2021 14:02:29 -0800 Message-ID: Subject: control message for bug #52518 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) severity 52518 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 16 12:35:23 2021 Received: (at 52518) by debbugs.gnu.org; 16 Dec 2021 17:35:23 +0000 Received: from localhost ([127.0.0.1]:36576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxuf5-0005zZ-Eq for submit@debbugs.gnu.org; Thu, 16 Dec 2021 12:35:23 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:57587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxuf3-0005z4-6s for 52518@debbugs.gnu.org; Thu, 16 Dec 2021 12:35:21 -0500 Received: (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id DF2BB20002; Thu, 16 Dec 2021 17:35:13 +0000 (UTC) From: Juri Linkov To: Stefan Kangas Subject: Re: bug#52518: Log only vc-command-messages Organization: LINKOV.NET References: <86zgp1zsf8.fsf@mail.linkov.net> Date: Thu, 16 Dec 2021 19:15:38 +0200 In-Reply-To: (Stefan Kangas's message of "Wed, 15 Dec 2021 14:02:32 -0800") Message-ID: <8635ms8ryd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52518 Cc: 52518@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >> (when vc-command-messages >> - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) >> + (let ((inhibit-message >> + (or (eq vc-command-messages 'log) >> + (eq (selected-window) (active-minibuffer-window))))) > > Should these be refactored into a function of their own? It seems > a tad repetitive as is. I agree these should be refactored. I was unsure if selected-window changes during function execution, but this would be better: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-inhibit-message.patch diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el index 346974bdba..4adc01fbfc 100644 --- a/lisp/vc/vc-dispatcher.el +++ b/lisp/vc/vc-dispatcher.el @@ -127,8 +127,12 @@ vc-delete-logbuf-window :group 'vc) (defcustom vc-command-messages nil - "If non-nil, display run messages from back-end commands." - :type 'boolean + "If non-nil, log run messages from back-end commands. +If `log', messages are logged to the *Messages* buffer, but not displayed. +Other non-nil values also display run messages in the echo area." + :type '(choice (const :tag "No display and no log" nil) + (const :tag "Display and log messages" t) + (const :tag "Only log messages without displaying" log)) :group 'vc) (defcustom vc-suppress-confirm nil @@ -311,7 +315,10 @@ vc-do-command (substring command 0 -1) command) " " (vc-delistify flags) - " " (vc-delistify files)))) + " " (vc-delistify files))) + (vc-inhibit-message + (or (eq vc-command-messages 'log) + (eq (selected-window) (active-minibuffer-window))))) (save-current-buffer (unless (or (eq buffer t) (and (stringp buffer) @@ -335,7 +342,7 @@ vc-do-command (apply #'start-file-process command (current-buffer) command squeezed)))) (when vc-command-messages - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (let ((inhibit-message vc-inhibit-message)) (message "Running in background: %s" full-command))) ;; Get rid of the default message insertion, in case we don't ;; set a sentinel explicitly. @@ -345,11 +352,11 @@ vc-do-command (when vc-command-messages (vc-run-delayed (let ((message-truncate-lines t) - (inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (inhibit-message vc-inhibit-message)) (message "Done in background: %s" full-command))))) ;; Run synchronously (when vc-command-messages - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (let ((inhibit-message vc-inhibit-message)) (message "Running in foreground: %s" full-command))) (let ((buffer-undo-list t)) (setq status (apply #'process-file command nil t nil squeezed))) @@ -364,7 +371,7 @@ vc-do-command (if (integerp status) (format "status %d" status) status) full-command)) (when vc-command-messages - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (let ((inhibit-message vc-inhibit-message)) (message "Done (status=%d): %s" status full-command))))) (vc-run-delayed (run-hook-with-args 'vc-post-command-functions --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 16 13:01:31 2021 Received: (at 52518) by debbugs.gnu.org; 16 Dec 2021 18:01:31 +0000 Received: from localhost ([127.0.0.1]:36738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxv4M-0006sy-W2 for submit@debbugs.gnu.org; Thu, 16 Dec 2021 13:01:31 -0500 Received: from mail-pg1-f176.google.com ([209.85.215.176]:42924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxv4K-0006sj-Ns for 52518@debbugs.gnu.org; Thu, 16 Dec 2021 13:01:29 -0500 Received: by mail-pg1-f176.google.com with SMTP id l18so19002887pgj.9 for <52518@debbugs.gnu.org>; Thu, 16 Dec 2021 10:01:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=NdLHL7DOZ81UKhbCwzzxJMSYk5iNFgmRDKmlL0WLgt4=; b=AEKA9dpYxdX5sqllSj25/k4ElJexvr9KLN9EjLq5Lx3YEPD3yLF32WYU70hvzfndCQ mYgD4Vpaug7rqq7FhjSZLRDbxWrbB/kEXfKnGHxWXLaaO7jXAnkLGWijqlgx113VzXIj WzrLp/f0auPerb16PX7seFQkGB8BMSSgADS78vFyIAgC3pkI/bw48TlmigmACd9toQw7 VdCXsyjTPnDvk/pFJf+mhwrSjSSfgt1cphngImmcmigP0ycJK3RsS0A/ixKtaFsSMJ0N EGUggbLDfOJOlrW7FjUewOErII1RJt3Jhs2szvMQhA4oi1nGTx/zeIkVIc09Lu1TUyQg prmg== X-Gm-Message-State: AOAM533kH6q2O/jCBi2SH0+IORYvkNjQAfhyMrZajzoghDdP4WmKZRn+ u7OGZZL5AUQsp684cOoheTgEljT8pvTqGaUs0t03TP8/ X-Google-Smtp-Source: ABdhPJyU/t6q4VQ2koO4vYdCZVUOratj1ZGVwdyZwti9NRzcrCpZ5Y2TTBl09mV+r9t4EGFseRyJSRd7ZWv3Pg9c1eM= X-Received: by 2002:aa7:8283:0:b0:49f:a0d0:abcf with SMTP id s3-20020aa78283000000b0049fa0d0abcfmr14946947pfm.70.1639677682916; Thu, 16 Dec 2021 10:01:22 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 16 Dec 2021 10:01:22 -0800 From: Stefan Kangas In-Reply-To: <8635ms8ryd.fsf@mail.linkov.net> References: <86zgp1zsf8.fsf@mail.linkov.net> <8635ms8ryd.fsf@mail.linkov.net> MIME-Version: 1.0 Date: Thu, 16 Dec 2021 10:01:22 -0800 Message-ID: Subject: Re: bug#52518: Log only vc-command-messages To: Juri Linkov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 52518 Cc: 52518@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Juri Linkov writes: > I agree these should be refactored. I was unsure if selected-window > changes during function execution, but this would be better: Thanks. Some documentation comments: > diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el > index 346974bdba..4adc01fbfc 100644 > --- a/lisp/vc/vc-dispatcher.el > +++ b/lisp/vc/vc-dispatcher.el > @@ -127,8 +127,12 @@ vc-delete-logbuf-window > :group 'vc) > > (defcustom vc-command-messages nil > - "If non-nil, display run messages from back-end commands." > - :type 'boolean > + "If non-nil, log run messages from back-end commands. > +If `log', messages are logged to the *Messages* buffer, but not displayed. > +Other non-nil values also display run messages in the echo area." Would this be simpler? If non-nil, display and log run messages from back-end commands. If `log', messages are logged to the *Messages* buffer but not displayed. > + :type '(choice (const :tag "No display and no log" nil) > + (const :tag "Display and log messages" t) > + (const :tag "Only log messages without displaying" log)) Perhaps the first one could be: No messages Perhaps the last one could be: Log messages From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 16 14:17:45 2021 Received: (at 52518) by debbugs.gnu.org; 16 Dec 2021 19:17:45 +0000 Received: from localhost ([127.0.0.1]:36836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxwG9-0000U4-Az for submit@debbugs.gnu.org; Thu, 16 Dec 2021 14:17:45 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:48417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxwG4-0000Te-Lx; Thu, 16 Dec 2021 14:17:44 -0500 Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id CAA0E240003; Thu, 16 Dec 2021 19:17:32 +0000 (UTC) From: Juri Linkov To: Stefan Kangas Subject: Re: bug#52518: Log only vc-command-messages Organization: LINKOV.NET References: <86zgp1zsf8.fsf@mail.linkov.net> <8635ms8ryd.fsf@mail.linkov.net> Date: Thu, 16 Dec 2021 21:17:14 +0200 In-Reply-To: (Stefan Kangas's message of "Thu, 16 Dec 2021 10:01:22 -0800") Message-ID: <867dc44ax1.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52518 Cc: 52518@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 52518 29.0.50 thanks > Would this be simpler? > > If non-nil, display and log run messages from back-end commands. > If `log', messages are logged to the *Messages* buffer but not > displayed. > >> + :type '(choice (const :tag "No display and no log" nil) >> + (const :tag "Display and log messages" t) >> + (const :tag "Only log messages without displaying" log)) > > Perhaps the first one could be: > > No messages > > Perhaps the last one could be: > > Log messages Thanks for the suggestions. Now pushed to master with all corrections. I'm not sure if a NEWS entry is needed, since this option is useful mostly for debugging. From unknown Sat Sep 13 19:06:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 Jan 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator