From unknown Sat Sep 20 08:45:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52498] [PATCH] linux-modules: Ignore EINVAL in =?UTF-8?Q?=E2=80=98modprobe=E2=80=99?= mode. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 Dec 2021 00:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52498 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52498@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163952924526199 (code B ref -1); Wed, 15 Dec 2021 00:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Dec 2021 00:47:25 +0000 Received: from localhost ([127.0.0.1]:59911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxIS4-0006oV-RL for submit@debbugs.gnu.org; Tue, 14 Dec 2021 19:47:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:44176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxIS3-0006oO-Ct for submit@debbugs.gnu.org; Tue, 14 Dec 2021 19:47:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxIS2-0002Ha-8R for guix-patches@gnu.org; Tue, 14 Dec 2021 19:47:23 -0500 Received: from [2a02:c205:2020:6054::1] (port=34696 helo=tobias.gr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxIRu-0001Jm-VQ for guix-patches@gnu.org; Tue, 14 Dec 2021 19:47:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=mAq6ZmKp1Is3W NJCD10dFnMTJcaltNKYkX+D9a+iiP0=; h=date:subject:to:from; d=tobias.gr; b=b223cPYgHGbg6KysfrWrFLSKNj20Bf9ZTHk3p+HE23Oa+iqap4Klsz2c/hxCfEfSKWjL Jm+GQdX+XxcRzI+LyD0JYyKazSo60L4+NIZNTVMjFRuby9bnJX/glgRl2fiYwyhY1O+3T7 uvVW4ZL7XXy8I3Sf1NxEoduF3ublHYII8wPx0rmXbs4fNgMvwCg6V7qUSoUzlTRSNFj37T YF/3I4OcCdVwnjcI1WNuOfaH20/id5t4FaUPSbpBrGWjljEgtH5YzLVuL0p1VgvDy/Sjmp 3DPTP5qEn4C10N4sk82utLAMm+TKnzTJ0n5w3eL2r9vZVvRPkV0R3ZJkkJy1B3pA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id d537da01 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Wed, 15 Dec 2021 00:47:07 +0000 (UTC) From: Tobias Geerinckx-Rice Date: Wed, 15 Dec 2021 01:47:04 +0100 Message-Id: <20211215004704.25215-1-me@tobias.gr> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:c205:2020:6054::1 (failed) Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Loading the framebuffer-coreboot module simply fails with EINVAL on a non-Corebooted system. Crashing the system with a kernel panic is not a reasonable reaction to loading valid modules on unsupported hardware. The kernel should log an error, which the user is expected to see. Bogus module names will still be fatally reported by linux-modules.drv. * gnu/build/linux-modules.scm (load-linux-module*): Ignore EINVAL errors when operating recursively. --- gnu/build/linux-modules.scm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm index 3a47322065..053720574b 100644 --- a/gnu/build/linux-modules.scm +++ b/gnu/build/linux-modules.scm @@ -354,11 +354,13 @@ (define (load-dependencies file) (close-fdes fd) #t) (lambda args - ;; If this module was already loaded and we're in modprobe style, ignore - ;; the error. (when fd (close-fdes fd)) - (or (and recursive? (= EEXIST (system-error-errno args))) - (apply throw args))))))) + (let ((errno (system-error-errno args))) + (or (and recursive? ; we're operating in ‘modprobe’ style + (member errno + (list EEXIST ; already loaded + EINVAL))) ; unsupported by hardware + (apply throw args)))))))) (define (load-linux-modules-from-directory modules directory) "Load MODULES and their dependencies from DIRECTORY, a directory containing -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 14 20:41:41 2021 Received: (at control) by debbugs.gnu.org; 15 Dec 2021 01:41:41 +0000 Received: from localhost ([127.0.0.1]:59923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxJIb-00084D-Ba for submit@debbugs.gnu.org; Tue, 14 Dec 2021 20:41:41 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:37433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxJIY-00083u-I1 for control@debbugs.gnu.org; Tue, 14 Dec 2021 20:41:40 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 4B1D93200E1A; Tue, 14 Dec 2021 20:41:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 14 Dec 2021 20:41:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:message-id:mime-version:content-type; s=mesmtp; bh=Gp1T6mfgQ6OpJx2lOK7q9+uUsMap1/wTU4ZkTcvcTkc=; b=aFJyr6TsJ3lL UtzS1ajLVXCGUiGW9hNOKDvp/ORqvAqf148fknQ0dy83VHCExqGHxQc5L7uxOlgt 2wftzc16vTdkLvhojNM5xMPYSiR5xNG2GPy7jDDAdtE6N7Yr0Xgk4DMChL3cmdDs Ipae+iBYkA+tsly7GNOgP5Mte65qpiM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Gp1T6mfgQ6OpJx2lOK7q9+uUsMap1/wTU4ZkTcvcT kc=; b=B51g/JwEuGTx955fytc0+DT5MuJab2WTJyiSs+gWc1vFVujvezvhjhicB 22d0aMEa9lIetFCcKBxe0l24Ikl8E68tXuRop1HI2hOUDE+yTEpATxo6biprmxki b7HIqMNcedDU+kYb40hlsvIPJcSsmjNeFNvjLZN0fWFGeioMndSL/ZgrzJGnoV24 4+7CtyZ0NRVF27Gtxsf2UTy4aEj4zrcE1xMlHhYAC5mX48FPWMy8OHvbrn29o2/u ne6aLil6dTHfzQXQ7+5hWahJbC7BKxq3WRMC2DqxatrV/Aok241Doreni5WqMCFZ 8yukDTeZZxxezchiE+anTSY06a2fQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrledugdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecugfhmphhthicushhusghjvggtthculddutddmnecujf gurhepfffhvffkgggtugesthdtredttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgr rhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhephf ejiefgfeevvdefteehgeeltdekvedutdegtdduieetheetgedvfeffudfffeffnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmh hulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 14 Dec 2021 20:41:31 -0500 (EST) Date: Tue, 14 Dec 2021 20:41:29 -0500 From: Leo Famulari To: control@debbugs.gnu.org Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: block 51619 with 52498 Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [64.147.123.25 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [64.147.123.25 listed in list.dnswl.org] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) block 51619 with 52498 From unknown Sat Sep 20 08:45:02 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tobias Geerinckx-Rice Subject: bug#52498: closed (Re: [bug#52498] [PATCH] linux-modules: Ignore EINVAL in =?UTF-8?Q?=E2=80=98modprobe=E2=80=99?= mode.) Message-ID: References: <20211215004704.25215-1-me@tobias.gr> X-Gnu-PR-Message: they-closed 52498 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 52498@debbugs.gnu.org Date: Thu, 16 Dec 2021 18:00:06 +0000 Content-Type: multipart/mixed; boundary="----------=_1639677606-26236-1" This is a multi-part message in MIME format... ------------=_1639677606-26236-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #52498: [PATCH] linux-modules: Ignore EINVAL in =E2=80=98modprobe=E2=80=99 = mode. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 52498@debbugs.gnu.org. --=20 52498: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D52498 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1639677606-26236-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 52498-done) by debbugs.gnu.org; 16 Dec 2021 17:59:32 +0000 Received: from localhost ([127.0.0.1]:36718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxv2R-0006mW-Mt for submit@debbugs.gnu.org; Thu, 16 Dec 2021 12:59:32 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:57161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxv26-0006l0-Lg for 52498-done@debbugs.gnu.org; Thu, 16 Dec 2021 12:59:11 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5D6413200C17; Thu, 16 Dec 2021 12:59:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 16 Dec 2021 12:59:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=Sn63jItzm3HBPhDaHP9bLLSw Hh7kgnLADFFNts2gplk=; b=qx2wOb3p4KIaA9BbJKxr1CwzgNbTj2BBJw7B4H8x mjtLLx3a2Crb7EyJtFPNEbe2enCuzr6lhCDDbUyTOhz9+znTTPWN/Gguf0Sc6TXp psSaDkKvILRxR7VMRcfLVJOM6liLEOYnPxRd+xhDiVsRYxILaa0HacsLU6Uw2mCW g3Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Sn63jI tzm3HBPhDaHP9bLLSwHh7kgnLADFFNts2gplk=; b=CXBneRk2Ip4T9o0VIrN5ou CYTAMcFWuwqZxfpyiOAt4vXIHiCzOlYFG3wc0fWE8ccvxZPL/Lj1tNS92wLTobrn VSOSB8xTxax0MmgBcO7WeO8tMkeRZPCDTSV0tKf+pYBPKnFJrBA1XjpDnMaoSJbn I4GbUXoZj6QgAVD9ruuth6SsWhzvn9s+zFb170oTt34gnEB7qN/JJ5ZYehMfqoRL iYj0MI1rraqjY+3tBgyHcS1zmpsZCMDzz/edNE0wBTSTyq5cPPiMicSbKf21fCza RIeLkO79SxgZf5bpGZx/DVxXsXmZOy7jRPddJQZQV8ugm4z4Xpf0QTGc+46eVKrQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrleeggddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepueekkedtffdvtddugeejgedtvefhue efiedvjeeitdeigedtveejvdejheffvefgnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Dec 2021 12:59:03 -0500 (EST) Date: Thu, 16 Dec 2021 12:59:01 -0500 From: Leo Famulari To: Tobias Geerinckx-Rice Subject: Re: [bug#52498] [PATCH] =?utf-8?Q?linux-mo?= =?utf-8?Q?dules=3A_Ignore_EINVAL_in_=E2=80=98modprobe=E2=80=99?= mode. Message-ID: References: <20211215004704.25215-1-me@tobias.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211215004704.25215-1-me@tobias.gr> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52498-done Cc: 52498-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, Dec 15, 2021 at 01:47:04AM +0100, Tobias Geerinckx-Rice via Guix-patches via wrote: > Loading the framebuffer-coreboot module simply fails with EINVAL on a > non-Corebooted system. Crashing the system with a kernel panic is not > a reasonable reaction to loading valid modules on unsupported hardware. > The kernel should log an error, which the user is expected to see. > > Bogus module names will still be fatally reported by linux-modules.drv. > > * gnu/build/linux-modules.scm (load-linux-module*): > Ignore EINVAL errors when operating recursively. Thanks, pushed as 13f13554433c9dd47503131107dfbdd8a8031832 ------------=_1639677606-26236-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Dec 2021 00:47:25 +0000 Received: from localhost ([127.0.0.1]:59911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxIS4-0006oV-RL for submit@debbugs.gnu.org; Tue, 14 Dec 2021 19:47:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:44176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxIS3-0006oO-Ct for submit@debbugs.gnu.org; Tue, 14 Dec 2021 19:47:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxIS2-0002Ha-8R for guix-patches@gnu.org; Tue, 14 Dec 2021 19:47:23 -0500 Received: from [2a02:c205:2020:6054::1] (port=34696 helo=tobias.gr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxIRu-0001Jm-VQ for guix-patches@gnu.org; Tue, 14 Dec 2021 19:47:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=mAq6ZmKp1Is3W NJCD10dFnMTJcaltNKYkX+D9a+iiP0=; h=date:subject:to:from; d=tobias.gr; b=b223cPYgHGbg6KysfrWrFLSKNj20Bf9ZTHk3p+HE23Oa+iqap4Klsz2c/hxCfEfSKWjL Jm+GQdX+XxcRzI+LyD0JYyKazSo60L4+NIZNTVMjFRuby9bnJX/glgRl2fiYwyhY1O+3T7 uvVW4ZL7XXy8I3Sf1NxEoduF3ublHYII8wPx0rmXbs4fNgMvwCg6V7qUSoUzlTRSNFj37T YF/3I4OcCdVwnjcI1WNuOfaH20/id5t4FaUPSbpBrGWjljEgtH5YzLVuL0p1VgvDy/Sjmp 3DPTP5qEn4C10N4sk82utLAMm+TKnzTJ0n5w3eL2r9vZVvRPkV0R3ZJkkJy1B3pA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id d537da01 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Wed, 15 Dec 2021 00:47:07 +0000 (UTC) From: Tobias Geerinckx-Rice To: guix-patches@gnu.org Subject: [PATCH] =?UTF-8?q?linux-modules:=20Ignore=20EINVAL=20in=20?= =?UTF-8?q?=E2=80=98modprobe=E2=80=99=20mode.?= Date: Wed, 15 Dec 2021 01:47:04 +0100 Message-Id: <20211215004704.25215-1-me@tobias.gr> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:c205:2020:6054::1 (failed) Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Loading the framebuffer-coreboot module simply fails with EINVAL on a non-Corebooted system. Crashing the system with a kernel panic is not a reasonable reaction to loading valid modules on unsupported hardware. The kernel should log an error, which the user is expected to see. Bogus module names will still be fatally reported by linux-modules.drv. * gnu/build/linux-modules.scm (load-linux-module*): Ignore EINVAL errors when operating recursively. --- gnu/build/linux-modules.scm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm index 3a47322065..053720574b 100644 --- a/gnu/build/linux-modules.scm +++ b/gnu/build/linux-modules.scm @@ -354,11 +354,13 @@ (define (load-dependencies file) (close-fdes fd) #t) (lambda args - ;; If this module was already loaded and we're in modprobe style, ignore - ;; the error. (when fd (close-fdes fd)) - (or (and recursive? (= EEXIST (system-error-errno args))) - (apply throw args))))))) + (let ((errno (system-error-errno args))) + (or (and recursive? ; we're operating in ‘modprobe’ style + (member errno + (list EEXIST ; already loaded + EINVAL))) ; unsupported by hardware + (apply throw args)))))))) (define (load-linux-modules-from-directory modules directory) "Load MODULES and their dependencies from DIRECTORY, a directory containing -- 2.34.0 ------------=_1639677606-26236-1--