GNU bug report logs - #52486
[PATCH] gnu: deluge: Move librsvg to native inputs.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#52486: closed ([PATCH] gnu: deluge: Move librsvg to native
 inputs.)
Date: Sun, 16 Jan 2022 10:53:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 16 Jan 2022 11:52:34 +0100
with message-id <87k0f0t0jx.fsf_-_ <at> waegenei.re>
and subject line Re: bug#52486: [PATCH] gnu: deluge: Move librsvg to native inputs.
has caused the debbugs.gnu.org bug report #52486,
regarding [PATCH] gnu: deluge: Move librsvg to native inputs.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
52486: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52486
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: guix-patches <at> gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH] gnu: deluge: Move librsvg to native inputs.
Date: Tue, 14 Dec 2021 18:21:51 +0100

Grepping the source code shows that librsvg is run by the
builder, and not by deluge itself.  This fixes propagation conflicting
with gtk+'s librsvg.  For now, use the C variant to build on all archs.
-- >8 --

* gnu/packages/bittorrent.scm (deluge): Do it.
---
 gnu/packages/bittorrent.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index 0dcb1ee991..5513878fc0 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -528,7 +528,6 @@ (define-public deluge
     (build-system python-build-system)
     (propagated-inputs
      `(("gtk+" ,gtk+)
-       ("librsvg" ,librsvg)
        ("libtorrent" ,libtorrent-rasterbar)
        ("python-pycairo" ,python-pycairo)
        ("python-chardet" ,python-chardet)
@@ -545,7 +544,7 @@ (define-public deluge
        ("python-twisted" ,python-twisted)
        ("python-zope-interface" ,python-zope-interface)))
     (native-inputs
-     (list intltool python-wheel))
+     (list intltool python-wheel librsvg-2.40))
     ;; TODO: Enable tests.
     ;; After "pytest-twisted" is packaged, HOME is set, and an X server is
     ;; started, some of the tests still fail.  There are likely some tests
-- 
2.34.0

[Message part 3 (message/rfc822, inline)]

From: Brice Waegeneire <brice <at> waegenei.re>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 52486-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#52486: [PATCH] gnu: deluge: Move librsvg to native inputs.
Date: Sun, 16 Jan 2022 11:52:34 +0100

Hello Josselin

Josselin Poiret <dev <at> jpoiret.xyz> writes:

> Josselin Poiret (2):
>   gnu: deluge: Move librsvg to native inputs
>   gnu: deluge: Remove reference of build-time librsvg

Thanks for the patch, it fixes the issue with librsvg as expected. Pushed as
1471219a8aabd2d8ad1f6bf1216c734ce73ae175, I've added your copyright to it.

Cheers,
- Brice

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.