From unknown Sat Jun 21 03:24:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52486] [PATCH] gnu: deluge: Move librsvg to native inputs. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Dec 2021 17:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52486 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52486@debbugs.gnu.org Cc: Josselin Poiret X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163950251732506 (code B ref -1); Tue, 14 Dec 2021 17:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Dec 2021 17:21:57 +0000 Received: from localhost ([127.0.0.1]:59437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxBUz-0008SD-Ee for submit@debbugs.gnu.org; Tue, 14 Dec 2021 12:21:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:34046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxBUy-0008S7-O1 for submit@debbugs.gnu.org; Tue, 14 Dec 2021 12:21:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxBUy-000153-Jf for guix-patches@gnu.org; Tue, 14 Dec 2021 12:21:56 -0500 Received: from jpoiret.xyz ([206.189.101.64]:55164) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxBUx-0004nD-7T for guix-patches@gnu.org; Tue, 14 Dec 2021 12:21:56 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 2FE94184F2C; Tue, 14 Dec 2021 17:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1639502513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=S1XT8Z8VAWTMLv4KGdavR/t9gR0Lt9tQSJOjVOT5Hc4=; b=nEg9Zmu9ypu8yD0+IwP4vLaweJ5ibcJOyTR4KbB4KyS6sgJ2HLzJEPSg4LdKsKsjua+urj gVUX4V/x9WAS7co+A0HzvKD8HJjIi8PXgqinMWPWZy/GjdjGSemguKlGxLHdxTUznRWC2b R/iwscXszny78famR19sp2FZlXA4OZ0N2Z7JDuKwXMOIfukfgi07jSu7W9F9M3k94tvGdh mtge63BD5vux4dLzSPC7Y7WTzsLtKkrI/5xGgyZ6fwganWDvTSN3gJ1lby0PeNUab/6kO5 WksXwSJig6VNZzffFYWU6rk2Z6FJ2vucvpMJKL+U3Y4fghXs3+i2B4WFJ/kXOA== From: Josselin Poiret Date: Tue, 14 Dec 2021 18:21:51 +0100 Message-Id: <20211214172151.28831-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: ++++ Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Level: **** Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, FROM_SUSPICIOUS_NTLD_FP=0.292, PDS_OTHER_BAD_TLD=1.997, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Grepping the source code shows that librsvg is run by the builder, and not by deluge itself. This fixes propagation conflicting with gtk+'s librsvg. For now, use the C variant to build on all archs. - [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=dev%40jpoiret.xyz; ip=209.51.188.17; r=debbugs.gnu.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] 0.5 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Grepping the source code shows that librsvg is run by the builder, and not by deluge itself. This fixes propagation conflicting with gtk+'s librsvg. For now, use the C variant to build on all archs. -- >8 -- * gnu/packages/bittorrent.scm (deluge): Do it. --- gnu/packages/bittorrent.scm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 0dcb1ee991..5513878fc0 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -528,7 +528,6 @@ (define-public deluge (build-system python-build-system) (propagated-inputs `(("gtk+" ,gtk+) - ("librsvg" ,librsvg) ("libtorrent" ,libtorrent-rasterbar) ("python-pycairo" ,python-pycairo) ("python-chardet" ,python-chardet) @@ -545,7 +544,7 @@ (define-public deluge ("python-twisted" ,python-twisted) ("python-zope-interface" ,python-zope-interface))) (native-inputs - (list intltool python-wheel)) + (list intltool python-wheel librsvg-2.40)) ;; TODO: Enable tests. ;; After "pytest-twisted" is packaged, HOME is set, and an X server is ;; started, some of the tests still fail. There are likely some tests -- 2.34.0 From unknown Sat Jun 21 03:24:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52486] [PATCH] gnu: deluge: Move librsvg to native inputs. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Dec 2021 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52486 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52486@debbugs.gnu.org Cc: dev@jpoiret.xyz X-Debbugs-Original-To: Josselin Poiret via Guix-patches via X-Debbugs-Original-Cc: 52486@debbugs.gnu.org, Josselin Poiret Received: via spool by submit@debbugs.gnu.org id=B.16395045883482 (code B ref -1); Tue, 14 Dec 2021 17:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Dec 2021 17:56:28 +0000 Received: from localhost ([127.0.0.1]:59489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxC2O-0000u3-0w for submit@debbugs.gnu.org; Tue, 14 Dec 2021 12:56:28 -0500 Received: from lists.gnu.org ([209.51.188.17]:33978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxC2M-0000tt-FV for submit@debbugs.gnu.org; Tue, 14 Dec 2021 12:56:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxC2M-0005Dy-8i for guix-patches@gnu.org; Tue, 14 Dec 2021 12:56:26 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:36799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxC2K-00019h-FQ for guix-patches@gnu.org; Tue, 14 Dec 2021 12:56:26 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 73B225C01EA; Tue, 14 Dec 2021 12:56:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 14 Dec 2021 12:56:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=XYFTnODxk3ghIpol9XKKPya5 AK4+PGGj3QcRcEgOT/w=; b=NFry5miPvUJEYhBpbiphcB8MZYoraz2tt2ecILGd yHVkFfKPRrQuobXIIz7lOnNVnucuk3EIxQPfjQcY32nXSLa5n1sWWsGltMXmh9V7 hBsRY32pvD6P8QJIvjaV2LysZYzmLVBb/BVsLLMp9gOd+jwLvRR02g/+aO/PCRJy s0k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XYFTnO Dxk3ghIpol9XKKPya5AK4+PGGj3QcRcEgOT/w=; b=LLwY2+H74P+bhwXIP3WzKs fEXwy8gCAfOd4hWqdrG7kNfhO2LHjBxQHZGppaeEyQ0iwYgIvvQnfaqgaAUu4k09 laFmX0Vam6m0sPKYsWHTiTDC8H1G0o0Nnw/csjLyvucgVVnLES5sxF3UwSTlE2bD EgqUPyG6uq3dKq7K5GMnuI1LOmK5OYr8k1UZ2rlFoA5k0R/RZyFxUXt4PMK3gltm xl+/VRswhu5dIXnKs20jUvaxEUxJMI8yGBUneYAfxm+qJl4aVBLY32SRZjvoLKkM lLKtqtRemxy+USvUqYeB5jS/EQU73i8Ov5tuQhJo2Gz5DAnfQT+AB6EKao36NlaA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrledtgddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Dec 2021 12:56:22 -0500 (EST) Date: Tue, 14 Dec 2021 12:56:20 -0500 From: Leo Famulari Message-ID: References: <20211214172151.28831-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211214172151.28831-1-dev@jpoiret.xyz> Received-SPF: pass client-ip=66.111.4.26; envelope-from=leo@famulari.name; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On Tue, Dec 14, 2021 at 06:21:51PM +0100, Josselin Poiret via Guix-patches via wrote: > Grepping the source code shows that librsvg is run by the > builder, and not by deluge itself. This fixes propagation conflicting > with gtk+'s librsvg. For now, use the C variant to build on all archs. > -- >8 -- I applied your patch and built Deluge. Then, I checked what packages it keeps a reference to: ------ $ guix gc --references $(./pre-inst-env guix build deluge) | grep librsvg /gnu/store/2dza2psfbrrbvsni8jjqzzqx3hmm8kw8-librsvg-2.50.7 /gnu/store/zxpbc78z40x7dr3ls4dgclkq7i4agx7a-librsvg-2.40.21 ------ So, Guix already records a run-time dependency on the Rust variant of librsvg (likely via GTK+), as well as the C variant if we apply your patch. I agree that, if Deluge does not use librsvg at run-time, we should make it a non-propagated-input. But, we should use the Rust variant on platforms where it is supported. Check the package definition of GTK+ for an example. And we should also make it a 'regular' input, because the package does keep a run-time reference to it. We are phasing out the C variant because it is abandoned upstream and no longer receiving security updates. From unknown Sat Jun 21 03:24:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52486] [PATCH v2 1/2] gnu: deluge: Move librsvg to native inputs Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Dec 2021 19:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52486 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 52486@debbugs.gnu.org, Josselin Poiret Received: via spool by 52486-submit@debbugs.gnu.org id=B52486.163950943819660 (code B ref 52486); Tue, 14 Dec 2021 19:18:02 +0000 Received: (at 52486) by debbugs.gnu.org; 14 Dec 2021 19:17:18 +0000 Received: from localhost ([127.0.0.1]:59625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxDIc-000571-Ks for submit@debbugs.gnu.org; Tue, 14 Dec 2021 14:17:18 -0500 Received: from jpoiret.xyz ([206.189.101.64]:34574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxDIb-00056h-5L for 52486@debbugs.gnu.org; Tue, 14 Dec 2021 14:17:17 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 28185184F6E; Tue, 14 Dec 2021 19:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1639509436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cgJ6Rof07VndZikG2ZfR0zMg1WboGFudN3AIGcjINyk=; b=s8zA4AboJg5gAQhfpC+IuFLm+cw2i8BgzD4LzYsfWYDVzC47leGjEys4vjJyfeVS8OZdw4 SC0DL4Ze6SEXJA35z4MftAk038GVQ89di0I/1s2N6mq0BmS699iJDGZYdADZrEStb65yRt tuVuLtdcLko09JK1A7G8WuE8B59XrE2BqQYmt12F6mFb90nl+qETFeRT/z8ONTK3Wqezgw +xl5I/IM7uEs6eaflzyU0e/MdszWfbCUMH6IsT5o0IUEFUMs8s8v1OgFz71wIQAx8+B/Z0 v0OTvd7im7fRf4Er57V+m285NjeZzbZ2oMppCUNAmzK8mytulNWMWKoDDyTKPA== From: Josselin Poiret Date: Tue, 14 Dec 2021 20:17:12 +0100 Message-Id: <20211214191713.18665-2-dev@jpoiret.xyz> In-Reply-To: <20211214191713.18665-1-dev@jpoiret.xyz> References: <20211214191713.18665-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/bittorrent.scm (deluge): Do it. --- gnu/packages/bittorrent.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 0dcb1ee991..6c6d01991a 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -528,7 +528,6 @@ (defi [...] Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/bittorrent.scm (deluge): Do it. --- gnu/packages/bittorrent.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 0dcb1ee991..6c6d01991a 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -528,7 +528,6 @@ (defi [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * gnu/packages/bittorrent.scm (deluge): Do it. --- gnu/packages/bittorrent.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 0dcb1ee991..6c6d01991a 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -528,7 +528,6 @@ (define-public deluge (build-system python-build-system) (propagated-inputs `(("gtk+" ,gtk+) - ("librsvg" ,librsvg) ("libtorrent" ,libtorrent-rasterbar) ("python-pycairo" ,python-pycairo) ("python-chardet" ,python-chardet) @@ -545,7 +544,10 @@ (define-public deluge ("python-twisted" ,python-twisted) ("python-zope-interface" ,python-zope-interface))) (native-inputs - (list intltool python-wheel)) + (list intltool python-wheel + (if (string-prefix? "x86_64-" (%current-system)) + librsvg-bootstrap + librsvg-2.40))) ;; TODO: Enable tests. ;; After "pytest-twisted" is packaged, HOME is set, and an X server is ;; started, some of the tests still fail. There are likely some tests -- 2.34.0 From unknown Sat Jun 21 03:24:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52486] [PATCH v2 0/2] Fix deluge propagating a librsvg incompatible with that of gtk+ Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Dec 2021 19:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52486 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 52486@debbugs.gnu.org, Josselin Poiret Received: via spool by 52486-submit@debbugs.gnu.org id=B52486.163950943919668 (code B ref 52486); Tue, 14 Dec 2021 19:18:02 +0000 Received: (at 52486) by debbugs.gnu.org; 14 Dec 2021 19:17:19 +0000 Received: from localhost ([127.0.0.1]:59627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxDIc-000573-RK for submit@debbugs.gnu.org; Tue, 14 Dec 2021 14:17:19 -0500 Received: from jpoiret.xyz ([206.189.101.64]:34542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxDIb-00056g-ME for 52486@debbugs.gnu.org; Tue, 14 Dec 2021 14:17:17 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 0A8F0184F6D; Tue, 14 Dec 2021 19:17:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1639509435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F+MXTCFIl6ywuDj2cGjbpSyVKEOAjFbLFpyj2EQKBuo=; b=W5Mvbb+b9ml1uc/ZCcBRvFUlqEIZVzmdj5hS0v5YIfhGy4LvbzBBNL5VT3eRbVmAabHeZh doDfTNku/EAF+62BmdrMfy9FkR8BTFgRmU7Q975dFfpIyH4/58JlDwxZKKqzx4WMgKzHnQ 3pH0cqipvc5Y5Ddre8XLGeNPYzh+aefrsVLttUEYF76p6Es+eJAYIw+YEjXKQVL0H2RVGv QICIa6VBvW/jQkaUBOWC21h04mZvdiWc3jC0/edAyhEWmo+qXLetnM3vGlH8o4YILRvxKZ np4kIEYoVi5wzLE4A46i8KgIQekUVqwRNMSXiI/sl5oKZWbHz3sqHtA8C8odLw== From: Josselin Poiret Date: Tue, 14 Dec 2021 20:17:11 +0100 Message-Id: <20211214191713.18665-1-dev@jpoiret.xyz> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: ++++ Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Level: **** X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello again, This time, a modified patch that selects the proper librsvg as is done in the gtk definition, but adapted for native-inputs, as well as another that removes the reference to the librsvg needed at buil [...] Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello again, This time, a modified patch that selects the proper librsvg as is done in the gtk definition, but adapted for native-inputs, as well as another that removes the reference to the librsvg needed at buil [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hello again, This time, a modified patch that selects the proper librsvg as is done in the gtk definition, but adapted for native-inputs, as well as another that removes the reference to the librsvg needed at build time. `guix size /gnu/store/azyp0avyr91jzwwdb3q82al44r3a8g1h-deluge-2.0.3` reports only one librsvg, that of GTK. I've tested this by adding a torrent, checking that it does in fact download. The UI looks ok, so I guess it should work. Best, Josselin Josselin Poiret (2): gnu: deluge: Move librsvg to native inputs gnu: deluge: Remove reference of build-time librsvg gnu/packages/bittorrent.scm | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) -- 2.34.0 From unknown Sat Jun 21 03:24:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52486] [PATCH v2 2/2] gnu: deluge: Remove reference of build-time librsvg Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Dec 2021 19:18:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52486 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 52486@debbugs.gnu.org, Josselin Poiret Received: via spool by 52486-submit@debbugs.gnu.org id=B52486.163950943919674 (code B ref 52486); Tue, 14 Dec 2021 19:18:03 +0000 Received: (at 52486) by debbugs.gnu.org; 14 Dec 2021 19:17:19 +0000 Received: from localhost ([127.0.0.1]:59629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxDId-00057A-2I for submit@debbugs.gnu.org; Tue, 14 Dec 2021 14:17:19 -0500 Received: from jpoiret.xyz ([206.189.101.64]:34662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxDIb-00056l-QJ for 52486@debbugs.gnu.org; Tue, 14 Dec 2021 14:17:18 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id EAC1C184F6F; Tue, 14 Dec 2021 19:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1639509437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=70xBMrJqKL6nPr3mubE4xQxUgpqI1YeIjNCqPyoctvo=; b=NwlWppbHIixjp14M3WoCBaoG0CvhHGuCxGzdTBNJwN/YRTnv856R2nH0Un8+AlvV2tVx8Z gtYpsfTTec//WZYc7aLwI2NpwNppOL0+Avnkj2AvZ0IN22BgJr8nwR07fQZrl/YX3gyCPO 1FLtBCqXMb/qpbT8zJ21/uC0Z/G0P8050vQpx/vg1t/Ek41d06OsQ8sgIuti+EFwRMScrG 3BsB6qhZa7SD2FQvFKSN5JaE7DpqRg3mWGP4vD+VcNPmBb9H7JosDw44JXiAAeQcZ8MZnC m/Y2VtlUHjx21O0ihpd74/MjirOcUkPFjAUxdToyIQ9y+epUm9soRMe48DpWHw== From: Josselin Poiret Date: Tue, 14 Dec 2021 20:17:13 +0100 Message-Id: <20211214191713.18665-3-dev@jpoiret.xyz> In-Reply-To: <20211214191713.18665-1-dev@jpoiret.xyz> References: <20211214191713.18665-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/bittorrent.scm (deluge): Do it. --- gnu/packages/bittorrent.scm | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 6c6d01991a..2a59b94f92 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -564,9 +564,19 @@ (def [...] Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/bittorrent.scm (deluge): Do it. --- gnu/packages/bittorrent.scm | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 6c6d01991a..2a59b94f92 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -564,9 +564,19 @@ (def [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * gnu/packages/bittorrent.scm (deluge): Do it. --- gnu/packages/bittorrent.scm | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 6c6d01991a..2a59b94f92 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -564,9 +564,19 @@ (define-public deluge (("names='ngettext'") "names=['ngettext']")) #t)) (add-after 'install 'wrap - (lambda* (#:key outputs #:allow-other-keys) + (lambda* (#:key native-inputs inputs outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out")) - (gi-typelib-path (getenv "GI_TYPELIB_PATH"))) + (gi-typelib-path + (string-join (filter + (lambda (x) (not (string-prefix? + (assoc-ref + (or native-inputs inputs) + "librsvg") + x))) + (string-split + (getenv "GI_TYPELIB_PATH") + #\:)) + ":"))) (for-each (lambda (program) (wrap-program program -- 2.34.0 From unknown Sat Jun 21 03:24:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Josselin Poiret Subject: bug#52486: closed (Re: bug#52486: [PATCH] gnu: deluge: Move librsvg to native inputs.) Message-ID: References: <87k0f0t0jx.fsf_-_@waegenei.re> <20211214172151.28831-1-dev@jpoiret.xyz> X-Gnu-PR-Message: they-closed 52486 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 52486@debbugs.gnu.org Date: Sun, 16 Jan 2022 10:53:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1642330382-20572-1" This is a multi-part message in MIME format... ------------=_1642330382-20572-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #52486: [PATCH] gnu: deluge: Move librsvg to native inputs. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 52486@debbugs.gnu.org. --=20 52486: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D52486 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1642330382-20572-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 52486-done) by debbugs.gnu.org; 16 Jan 2022 10:52:48 +0000 Received: from localhost ([127.0.0.1]:42576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n939T-0005LH-WA for submit@debbugs.gnu.org; Sun, 16 Jan 2022 05:52:48 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:56621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n939S-0005L2-5v for 52486-done@debbugs.gnu.org; Sun, 16 Jan 2022 05:52:46 -0500 Received: (Authenticated sender: brice@waegenei.re) by mail.gandi.net (Postfix) with ESMTPSA id 57532C0006; Sun, 16 Jan 2022 10:52:38 +0000 (UTC) From: Brice Waegeneire To: Josselin Poiret Subject: Re: bug#52486: [PATCH] gnu: deluge: Move librsvg to native inputs. References: <20211214191713.18665-1-dev@jpoiret.xyz> Date: Sun, 16 Jan 2022 11:52:34 +0100 In-Reply-To: <20211214191713.18665-1-dev@jpoiret.xyz> (Josselin Poiret's message of "Tue, 14 Dec 2021 20:17:11 +0100") Message-ID: <87k0f0t0jx.fsf_-_@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Josselin Josselin Poiret writes: > Josselin Poiret (2): > gnu: deluge: Move librsvg to native inputs > gnu: deluge: Remove reference of build-time librsvg Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.198 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.198 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 52486-done Cc: 52486-done@debbugs.gnu.org, Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Hello Josselin Josselin Poiret writes: > Josselin Poiret (2): > gnu: deluge: Move librsvg to native inputs > gnu: deluge: Remove reference of build-time librsvg Thanks for the patch, it fixes the issue with librsvg as expected. Pushed as 1471219a8aabd2d8ad1f6bf1216c734ce73ae175, I've added your copyright to it. Cheers, - Brice ------------=_1642330382-20572-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Dec 2021 17:21:57 +0000 Received: from localhost ([127.0.0.1]:59437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxBUz-0008SD-Ee for submit@debbugs.gnu.org; Tue, 14 Dec 2021 12:21:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:34046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxBUy-0008S7-O1 for submit@debbugs.gnu.org; Tue, 14 Dec 2021 12:21:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxBUy-000153-Jf for guix-patches@gnu.org; Tue, 14 Dec 2021 12:21:56 -0500 Received: from jpoiret.xyz ([206.189.101.64]:55164) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxBUx-0004nD-7T for guix-patches@gnu.org; Tue, 14 Dec 2021 12:21:56 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 2FE94184F2C; Tue, 14 Dec 2021 17:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1639502513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=S1XT8Z8VAWTMLv4KGdavR/t9gR0Lt9tQSJOjVOT5Hc4=; b=nEg9Zmu9ypu8yD0+IwP4vLaweJ5ibcJOyTR4KbB4KyS6sgJ2HLzJEPSg4LdKsKsjua+urj gVUX4V/x9WAS7co+A0HzvKD8HJjIi8PXgqinMWPWZy/GjdjGSemguKlGxLHdxTUznRWC2b R/iwscXszny78famR19sp2FZlXA4OZ0N2Z7JDuKwXMOIfukfgi07jSu7W9F9M3k94tvGdh mtge63BD5vux4dLzSPC7Y7WTzsLtKkrI/5xGgyZ6fwganWDvTSN3gJ1lby0PeNUab/6kO5 WksXwSJig6VNZzffFYWU6rk2Z6FJ2vucvpMJKL+U3Y4fghXs3+i2B4WFJ/kXOA== From: Josselin Poiret To: guix-patches@gnu.org Subject: [PATCH] gnu: deluge: Move librsvg to native inputs. Date: Tue, 14 Dec 2021 18:21:51 +0100 Message-Id: <20211214172151.28831-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: ++++ Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Level: **** Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, FROM_SUSPICIOUS_NTLD_FP=0.292, PDS_OTHER_BAD_TLD=1.997, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Grepping the source code shows that librsvg is run by the builder, and not by deluge itself. This fixes propagation conflicting with gtk+'s librsvg. For now, use the C variant to build on all archs. - [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=dev%40jpoiret.xyz; ip=209.51.188.17; r=debbugs.gnu.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] 0.5 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: submit Cc: Josselin Poiret X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Grepping the source code shows that librsvg is run by the builder, and not by deluge itself. This fixes propagation conflicting with gtk+'s librsvg. For now, use the C variant to build on all archs. -- >8 -- * gnu/packages/bittorrent.scm (deluge): Do it. --- gnu/packages/bittorrent.scm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 0dcb1ee991..5513878fc0 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -528,7 +528,6 @@ (define-public deluge (build-system python-build-system) (propagated-inputs `(("gtk+" ,gtk+) - ("librsvg" ,librsvg) ("libtorrent" ,libtorrent-rasterbar) ("python-pycairo" ,python-pycairo) ("python-chardet" ,python-chardet) @@ -545,7 +544,7 @@ (define-public deluge ("python-twisted" ,python-twisted) ("python-zope-interface" ,python-zope-interface))) (native-inputs - (list intltool python-wheel)) + (list intltool python-wheel librsvg-2.40)) ;; TODO: Enable tests. ;; After "pytest-twisted" is packaged, HOME is set, and an X server is ;; started, some of the tests still fail. There are likely some tests -- 2.34.0 ------------=_1642330382-20572-1-- From unknown Sat Jun 21 03:24:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52486] [PATCH] gnu: deluge: Move librsvg to native inputs. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 Jan 2022 10:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52486 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 52486-done@debbugs.gnu.org, Leo Famulari Received: via spool by 52486-done@debbugs.gnu.org id=D52486.164233038420623 (code D ref 52486); Sun, 16 Jan 2022 10:54:01 +0000 Received: (at 52486-done) by debbugs.gnu.org; 16 Jan 2022 10:53:04 +0000 Received: from localhost ([127.0.0.1]:42584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n939k-0005MY-6B for submit@debbugs.gnu.org; Sun, 16 Jan 2022 05:53:04 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:40687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n939i-0005LV-AM for 52486-done@debbugs.gnu.org; Sun, 16 Jan 2022 05:53:02 -0500 Received: (Authenticated sender: brice@waegenei.re) by mail.gandi.net (Postfix) with ESMTPSA id 2C13960004; Sun, 16 Jan 2022 10:52:54 +0000 (UTC) From: Brice Waegeneire In-Reply-To: <20211214191713.18665-1-dev@jpoiret.xyz> (Josselin Poiret's message of "Tue, 14 Dec 2021 20:17:11 +0100") References: <20211214191713.18665-1-dev@jpoiret.xyz> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.90 (gnu/linux) Date: Sun, 16 Jan 2022 11:52:54 +0100 Message-ID: <87ilukt0jd.fsf_-_@waegenei.re> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Josselin Josselin Poiret writes: > Josselin Poiret (2): > gnu: deluge: Move librsvg to native inputs > gnu: deluge: Remove reference of build-time librsvg Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.195 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.195 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Hello Josselin Josselin Poiret writes: > Josselin Poiret (2): > gnu: deluge: Move librsvg to native inputs > gnu: deluge: Remove reference of build-time librsvg Thanks for the patch, it fixes the issue with librsvg as expected. Pushed as 1471219a8aabd2d8ad1f6bf1216c734ce73ae175, I've added your copyright to it. Cheers, - Brice From unknown Sat Jun 21 03:24:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52486] [PATCH v2 2/2] gnu: deluge: Remove reference of build-time librsvg Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 Jan 2022 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52486 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 52486@debbugs.gnu.org Received: via spool by 52486-submit@debbugs.gnu.org id=B52486.164235593023483 (code B ref 52486); Sun, 16 Jan 2022 17:59:02 +0000 Received: (at 52486) by debbugs.gnu.org; 16 Jan 2022 17:58:50 +0000 Received: from localhost ([127.0.0.1]:44194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n99nm-00066h-45 for submit@debbugs.gnu.org; Sun, 16 Jan 2022 12:58:50 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:37219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n99nk-00066T-OD for 52486@debbugs.gnu.org; Sun, 16 Jan 2022 12:58:49 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 44CC65C0060; Sun, 16 Jan 2022 12:58:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 16 Jan 2022 12:58:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=WAE/sZ4bjg2bJbBA54tjn0Q/ AlsYhveHmNNt9UcWEsk=; b=JOlu7UA+jWRwT47puEGigfKVb8gl5FlNqyx9Brz0 xvNeLICAjaai0iU8jCiohsNaCFe39YXkEn+yn5rx/nUpm3wX1+5eFhXS87x5/K3c /6YGnuc6SU6neMOibiVNs2tiiMqZQHpfDM0zC4g4pM+NCPv0Qx8DEh6Efa9yJnGK GXw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=WAE/sZ 4bjg2bJbBA54tjn0Q/AlsYhveHmNNt9UcWEsk=; b=DGOQsbNHWQU0Q6rMejwvL3 MFmpnubgAttiYam7eB5Sy+Ga+ZrIGPgm/rh16/7AyCPJI8wBeUg5bJBII89EFCzF x6Ao0UwmBRFa0P4QYFJs4erj1ORNVaCHelqyVqBD/dMSMU1PuZVei0Rs5cjS6Mqj t7yzUKRsPLhr/bzuXveihF4tBVLqFHShVvbm+vslHRkBz04Pef5+qSO1hrubMWbM DYsZiXixnUEczaJhpjd86h9DbJ/PuA0vAoo6fVbDZ481OwT7A+T6ZBxujv7L8fE0 CZSCaK0Sc8wgUtwB7BZBts5L11SOc50ixpYcmnrgiXgBMMhJXDd0499x+Ukmh6PA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrtdelgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepueekkedtffdvtddugeejgedtvefhue efiedvjeeitdeigedtveejvdejheffvefgnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 16 Jan 2022 12:58:43 -0500 (EST) Date: Sun, 16 Jan 2022 12:58:41 -0500 From: Leo Famulari Message-ID: References: <20211214191713.18665-1-dev@jpoiret.xyz> <20211214191713.18665-3-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211214191713.18665-3-dev@jpoiret.xyz> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, Dec 14, 2021 at 08:17:13PM +0100, Josselin Poiret wrote: > * gnu/packages/bittorrent.scm (deluge): Do it. Thanks for working on this! Can you send a followup patch adding a code comment that explains the change? It's good practice to explain code that does strange things, especially in packages. Otherwise later package maintainers may feel free to remove it. From unknown Sat Jun 21 03:24:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52486] [PATCH] gnu: deluge: Move librsvg to native inputs. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 Jan 2022 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52486 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: Josselin Poiret , 52486@debbugs.gnu.org Received: via spool by 52486-submit@debbugs.gnu.org id=B52486.16423693185900 (code B ref 52486); Sun, 16 Jan 2022 21:42:02 +0000 Received: (at 52486) by debbugs.gnu.org; 16 Jan 2022 21:41:58 +0000 Received: from localhost ([127.0.0.1]:44368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9DHi-0001X6-K8 for submit@debbugs.gnu.org; Sun, 16 Jan 2022 16:41:58 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:48157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9DHe-0001Wc-43 for 52486@debbugs.gnu.org; Sun, 16 Jan 2022 16:41:54 -0500 Received: (Authenticated sender: brice@waegenei.re) by mail.gandi.net (Postfix) with ESMTPSA id 759C9FF802; Sun, 16 Jan 2022 21:41:47 +0000 (UTC) From: Brice Waegeneire References: <20211214191713.18665-1-dev@jpoiret.xyz> <20211214191713.18665-3-dev@jpoiret.xyz> Date: Sun, 16 Jan 2022 22:41:43 +0100 In-Reply-To: (Leo Famulari's message of "Sun, 16 Jan 2022 12:58:41 -0500") Message-ID: <87fspntl2g.fsf_-_@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Leo, It didn't came into my mind to ask for such explanation to be added as a commentary, even tho I asked Josselin about it on IRC. I have subbmited a patch adding such comment in . Cheers, - Brice