GNU bug report logs - #52472
[PATCH] gnu: Add libtree

Previous Next

Package: guix-patches;

Reported by: poptsov.artyom <at> gmail.com (Artyom V. Poptsov)

Date: Mon, 13 Dec 2021 20:43:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #41 received at 52472 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: othacehe <at> gnu.org, Julien Lepiller <julien <at> lepiller.eu>,
 52472 <at> debbugs.gnu.org
Subject: Re: [bug#52472] [PATCH] gnu: Add libtree
Date: Mon, 17 Jan 2022 20:02:13 +0100

[Message part 1 (text/plain, inline)]
Hi,

Artyom V. Poptsov schreef op ma 17-01-2022 om 21:09 [+0300]:
> +     (list #:tests? #t

Tests can almost never be run when cross-compiling,
so this needs to be #false when cross-compiling.  This should
be detected by the 'tests-true' linter.  I suggest removing '#:tests?
#t’.

> +           #~(list (string-append "CC=" #$(cc-for-target))
> +                   "PREFIX=/"
> +                   (string-append "DESTDIR=" #$output))

Guix doesn't do staged installation
(https://www.gnu.org/software/automake/manual/html_node/DESTDIR.html).
Doing (string-append "PREFIX=" $output) and dropping DESTDIR=... should
suffice.

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 153 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.