Subject: Re: [bug#52472] [PATCH] gnu: Add libtree

From: Maxime Devos <[email-masked]>
Date: Mon, 17 Jan 2022 20:02:13 +0100

Hi,

Artyom V. Poptsov schreef op ma 17-01-2022 om 21:09 [+0300]:
> +     (list #:tests? #t

Tests can almost never be run when cross-compiling,
so this needs to be #false when cross-compiling.  This should
be detected by the 'tests-true' linter.  I suggest removing '#:tests?
#t’.

> +           #~(list (string-append "CC=" #$(cc-for-target))
> +                   "PREFIX=/"
> +                   (string-append "DESTDIR=" #$output))

Guix doesn't do staged installation
(https://www.gnu.org/software/automake/manual/html_node/DESTDIR.html).
Doing (string-append "PREFIX=" $output) and dropping DESTDIR=... should
suffice.

Greetings,
Maxime