GNU bug report logs - #52469
[PATCH] gnu: Add opustags.

Previous Next

Full log

Message #8 received at 52469 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 52469 <at> debbugs.gnu.org
Subject: Re: bug#52469: [PATCH] gnu: Add opustags.
Date: Sun, 19 Dec 2021 17:09:18 +0100

Hey Leo,

> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let* ((perl-list-moreutils-lib
> +                      (string-append (assoc-ref inputs "perl-list-moreutils")
> +                                     "/lib/perl5/site_perl/"
> +                                     ,(package-version perl)))
> +                    (perl-exporter-tiny-lib
> +                      (string-append (assoc-ref inputs "perl-exporter-tiny")
> +                                     "/lib/perl5/site_perl/"
> +                                     ,(package-version perl))))

I guess you can use gexps and this-package-input to avoid relying on
input labels explicitly.

> +    (inputs
> +     `(("libogg" ,libogg)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ;; For the test suite
> +       ("ffmpeg" ,ffmpeg)
> +       ("perl-exporter-tiny" ,perl-exporter-tiny)
> +       ("perl-list-moreutils" ,perl-list-moreutils)
> +       ("perl-test-harness" ,perl-test-harness)))

And adapt those lists to the new style.

Otherwise looks fine,

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.