GNU bug report logs - #52469
[PATCH] gnu: Add opustags.

Previous Next

Full log

Message #13 received at 52469-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 52469-done <at> debbugs.gnu.org
Subject: Re: bug#52469: [PATCH] gnu: Add opustags.
Date: Sun, 19 Dec 2021 12:12:18 -0500

On Sun, Dec 19, 2021 at 05:09:18PM +0100, Mathieu Othacehe wrote:
> > +           (lambda* (#:key inputs #:allow-other-keys)
> > +             (let* ((perl-list-moreutils-lib
> > +                      (string-append (assoc-ref inputs "perl-list-moreutils")
> > +                                     "/lib/perl5/site_perl/"
> > +                                     ,(package-version perl)))
> > +                    (perl-exporter-tiny-lib
> > +                      (string-append (assoc-ref inputs "perl-exporter-tiny")
> > +                                     "/lib/perl5/site_perl/"
> > +                                     ,(package-version perl))))
> 
> I guess you can use gexps and this-package-input to avoid relying on
> input labels explicitly.

I'd like to do this but I can't yet find any examples of using the new
style with modify-phases.

> > +    (inputs
> > +     `(("libogg" ,libogg)))
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)
> > +       ;; For the test suite
> > +       ("ffmpeg" ,ffmpeg)
> > +       ("perl-exporter-tiny" ,perl-exporter-tiny)
> > +       ("perl-list-moreutils" ,perl-list-moreutils)
> > +       ("perl-test-harness" ,perl-test-harness)))
> 
> And adapt those lists to the new style.

I did make this change and pushed as
ee2e02333485e54dd3024e982ae1a2f9b10cfb6c

Thanks for the review!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.