From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 13 12:40:21 2021 Received: (at submit) by debbugs.gnu.org; 13 Dec 2021 17:40:21 +0000 Received: from localhost ([127.0.0.1]:56709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwpJ9-0008Tl-2S for submit@debbugs.gnu.org; Mon, 13 Dec 2021 12:40:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:44206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwpJ6-0008Td-TE for submit@debbugs.gnu.org; Mon, 13 Dec 2021 12:40:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwpJ5-0000md-FK for guix-patches@gnu.org; Mon, 13 Dec 2021 12:40:12 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:40569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwpJ0-0005fm-6i for guix-patches@gnu.org; Mon, 13 Dec 2021 12:40:11 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 926005C0251; Mon, 13 Dec 2021 12:40:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 13 Dec 2021 12:40:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=mesmtp; bh=8zEYV4OeUNVn1EZ6KFEJ/zX nwAvj9HIjTQL8ZitGDTw=; b=dV2ziS8MD1DsC3q4M4I7VYDFmSxuRCGuAsjMOny DPcV6uJ11k1H3tOEOB1SO2iNOoDh6QhOgh4oaSldccy5+xXf4RDt3SM3hLa2UZS8 NQB2yhYjS/RuyK0WFGEIVPS7irAKIh2OA16r6PY0nshcago0+o2Kb+YFA2mCp0y6 WjLU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8zEYV4 OeUNVn1EZ6KFEJ/zXnwAvj9HIjTQL8ZitGDTw=; b=YfhyMAAwGzwMJTu4i4JlWz WqEKOgtSLjitUaarND4LAEW/y+0hGHpCOdOh0LyqNdlt/sIbiZrO5GHpfprtwJup Jjy9Vd7mCaet3+LfxoenPsHzAdgEtqSARjhSaHpQZ28t0mbc/cHr31ri3NmX/T1q 8YUxERUnllYTidE/uyCV+W9MCseZzuBRbliEmDPmNhKHE1xwK+4KojkPfw0AhhR2 UwoD/qYqMPWDPiIZTArcW/T0Ktx7MOY3K4fxe+mm9bB5NlA2+Liz+r3YD9A9jiAM HuICt1fTbT4ynuW64S2rQclQhyM8Z9pXRkFVJXv4RiGWy4Kb0t5B+TJO9L0+asyw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrkeekgddutdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofggtgfgsehtkeertd ertdejnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghr ihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeefleefhfduteehteetueeuteehfffghf eiiefhvdfgieduueejgeevudekgfffheenucffohhmrghinhepghhithhhuhgsrdgtohhm necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvoh esfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 13 Dec 2021 12:40:04 -0500 (EST) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] gnu: Add opustags. Date: Mon, 13 Dec 2021 12:40:00 -0500 Message-Id: X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=66.111.4.27; envelope-from=leo@famulari.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/music.scm (opustags): New variable. --- gnu/packages/music.scm | 51 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 9d2fad853e..89306dd764 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4,7 +4,7 @@ ;;; Copyright © 2015 Paul van der Walt ;;; Copyright © 2016 Al McElrath ;;; Copyright © 2016, 2017, 2019, 2021 Efraim Flashner -;;; Copyright © 2016, 2018 Leo Famulari +;;; Copyright © 2016, 2018, 2021 Leo Famulari ;;; Copyright © 2016, 2017, 2019 Kei Kebreau ;;; Copyright © 2016 John J. Foerch ;;; Copyright © 2016 Alex Griffin @@ -144,6 +144,7 @@ (define-module (gnu packages music) #:use-module (gnu packages pcre) #:use-module (gnu packages pdf) #:use-module (gnu packages perl) + #:use-module (gnu packages perl-check) #:use-module (gnu packages perl-web) #:use-module (gnu packages pkg-config) #:use-module (gnu packages protobuf) @@ -6952,3 +6953,51 @@ (define-public a2jmidid midi devices to JACK midi devices.") (home-page "https://github.com/jackaudio/a2jmidid") (license license:gpl2))) + +(define-public opustags + (package + (name "opustags") + (version "1.6.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/fmang/opustags") + (commit version))) + (sha256 + (base32 "1wsfw713rhi2gg5xc04cx5i31hlw0l3wdflj3r1y8w45bdk6ag1z")) + (file-name (git-file-name name version)))) + (arguments + `(#:test-target "check" + #:phases + (modify-phases %standard-phases + ;; This package does not use the perl-build-system, so we have to + ;; manually set up the Perl environment used by the test suite. + (add-before 'check 'setup-perl-environment + (lambda* (#:key inputs #:allow-other-keys) + (let* ((perl-list-moreutils-lib + (string-append (assoc-ref inputs "perl-list-moreutils") + "/lib/perl5/site_perl/" + ,(package-version perl))) + (perl-exporter-tiny-lib + (string-append (assoc-ref inputs "perl-exporter-tiny") + "/lib/perl5/site_perl/" + ,(package-version perl)))) + (setenv "PERL5LIB" (string-append perl-list-moreutils-lib ":" + perl-exporter-tiny-lib)))))))) + (build-system cmake-build-system) + (inputs + `(("libogg" ,libogg))) + (native-inputs + `(("pkg-config" ,pkg-config) + ;; For the test suite + ("ffmpeg" ,ffmpeg) + ("perl-exporter-tiny" ,perl-exporter-tiny) + ("perl-list-moreutils" ,perl-list-moreutils) + ("perl-test-harness" ,perl-test-harness))) + (synopsis "Ogg Opus tags editor") + (description "@code{opustags} is an Ogg Opus tag editor. It reads and edits +the comment header of an Ogg Opus audio file, offering both read-only and +editing modes. Tags can be edited interactively with an editor of your +choice.") + (home-page "https://github.com/fmang/opustags") + (license license:bsd-3))) -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 11:09:27 2021 Received: (at 52469) by debbugs.gnu.org; 19 Dec 2021 16:09:27 +0000 Received: from localhost ([127.0.0.1]:47795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myykZ-0000sz-Gl for submit@debbugs.gnu.org; Sun, 19 Dec 2021 11:09:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myykX-0000sl-WC for 52469@debbugs.gnu.org; Sun, 19 Dec 2021 11:09:26 -0500 Received: from [2001:470:142:3::e] (port=37908 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myykS-0006Br-FS; Sun, 19 Dec 2021 11:09:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=5ShZr+cH7m0tSM38YLIbrKUbUuBGUHmQaZ4NULJvr7I=; b=VNI5B4VnKJTpMK45fuSD uYhxmWm+udrsG/r7QMCfsrS8x5R7IJ3qY0S16ADMTcxqnlgavk/1Xg/tC5wYHDwsjWqI6JNi5q+1L +TFV1cxqvTBIG3LjdMMr5qKNAf5F38D+bMLSof1eixaM/UpLWvOid5qhSSC8qcZ+YftdQNMVJxiSL /SioXXOhih8/hOngm+EszATCVvRU13lVuhldX7hAn1ybaU7YwGCbysU4PbFcl+5JH9hvhpTcfy/Y+ jRR0FtvuLPEdsgcueae02WYHEtPaASa9LlRkGlkxGtJ914AGyKoJwWV4tNt0fVRWbNtbKqsPcACsp x9NRd1RC3fhhNg==; Received: from [2a01:e0a:19b:d9a0:45b5:a14a:5c75:5737] (port=54164 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myykS-0003rb-FG; Sun, 19 Dec 2021 11:09:20 -0500 From: Mathieu Othacehe To: Leo Famulari Subject: Re: bug#52469: [PATCH] gnu: Add opustags. References: Date: Sun, 19 Dec 2021 17:09:18 +0100 In-Reply-To: (Leo Famulari's message of "Mon, 13 Dec 2021 12:40:00 -0500") Message-ID: <87v8zkd1ap.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52469 Cc: 52469@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Leo, > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((perl-list-moreutils-lib > + (string-append (assoc-ref inputs "perl-list-moreutils") > + "/lib/perl5/site_perl/" > + ,(package-version perl))) > + (perl-exporter-tiny-lib > + (string-append (assoc-ref inputs "perl-exporter-tiny") > + "/lib/perl5/site_perl/" > + ,(package-version perl)))) I guess you can use gexps and this-package-input to avoid relying on input labels explicitly. > + (inputs > + `(("libogg" ,libogg))) > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ;; For the test suite > + ("ffmpeg" ,ffmpeg) > + ("perl-exporter-tiny" ,perl-exporter-tiny) > + ("perl-list-moreutils" ,perl-list-moreutils) > + ("perl-test-harness" ,perl-test-harness))) And adapt those lists to the new style. Otherwise looks fine, Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 12:12:29 2021 Received: (at 52469-done) by debbugs.gnu.org; 19 Dec 2021 17:12:29 +0000 Received: from localhost ([127.0.0.1]:47923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myzjZ-0004kL-9h for submit@debbugs.gnu.org; Sun, 19 Dec 2021 12:12:29 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:53515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myzjX-0004k8-Hd for 52469-done@debbugs.gnu.org; Sun, 19 Dec 2021 12:12:28 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 0229032008C0; Sun, 19 Dec 2021 12:12:20 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 19 Dec 2021 12:12:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=hCCbjAOLrHvjZR8cG+F4v61L vkENLSZtXodvsqqfPF8=; b=fb7tyFpK6rIIsQlPt9lF5dRJtjtk6IcsFPwfGSOy TspFieNRh4/82OnknLIIfwkBcBEI3ApQJuRTdV1aQ6egrf9SfHAk32w4Q3jji1YF GfCaiElfbFXM+XghTHg5jVBLPlL2Ybjrf6tDC4gZdf4qENAias8coUtnQHNBGfl2 Xfc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=hCCbjA OLrHvjZR8cG+F4v61LvkENLSZtXodvsqqfPF8=; b=lspNpzqi/RcEFmDOgrfy2b badckpQ7omdcTA9FBR16fyDA6/iLpgRL+m5GBoazgbqmbL5/5MpnJkibIce+tXLU ZomTvSp7FCDl8kr47oOoSiWYoKCJOTymn5TsphaPFCkhS7WpcsmG6bwu/HQR9qsX 3PsCvxmYao0e4J4aiswqwOWrCF1voNzbh8ZiPhBNPmdyt9m9YnZxlY594xnnpbU4 xJxEnJ+x60zNQMR0O2/DDE6m8zK13pPWPVXPce2LpHAd/HKjcN2uX41lrc8L8EbM dTclUTaDiQxmcPO7rn2yp0RZt82t9hcc6TzhmPNm4hzA0LqnaqN6as1yN1irQF1w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddttddgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Dec 2021 12:12:20 -0500 (EST) Date: Sun, 19 Dec 2021 12:12:18 -0500 From: Leo Famulari To: Mathieu Othacehe Subject: Re: bug#52469: [PATCH] gnu: Add opustags. Message-ID: References: <87v8zkd1ap.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v8zkd1ap.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52469-done Cc: 52469-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Dec 19, 2021 at 05:09:18PM +0100, Mathieu Othacehe wrote: > > + (lambda* (#:key inputs #:allow-other-keys) > > + (let* ((perl-list-moreutils-lib > > + (string-append (assoc-ref inputs "perl-list-moreutils") > > + "/lib/perl5/site_perl/" > > + ,(package-version perl))) > > + (perl-exporter-tiny-lib > > + (string-append (assoc-ref inputs "perl-exporter-tiny") > > + "/lib/perl5/site_perl/" > > + ,(package-version perl)))) > > I guess you can use gexps and this-package-input to avoid relying on > input labels explicitly. I'd like to do this but I can't yet find any examples of using the new style with modify-phases. > > + (inputs > > + `(("libogg" ,libogg))) > > + (native-inputs > > + `(("pkg-config" ,pkg-config) > > + ;; For the test suite > > + ("ffmpeg" ,ffmpeg) > > + ("perl-exporter-tiny" ,perl-exporter-tiny) > > + ("perl-list-moreutils" ,perl-list-moreutils) > > + ("perl-test-harness" ,perl-test-harness))) > > And adapt those lists to the new style. I did make this change and pushed as ee2e02333485e54dd3024e982ae1a2f9b10cfb6c Thanks for the review! From unknown Sun Sep 07 01:28:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 17 Jan 2022 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator