GNU bug report logs - #52448
key-valid-p vs "C-M-x" and "ESC C-x"

Previous Next

Full log

Message #8 received at 52448 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52448 <at> debbugs.gnu.org
Subject: Re: bug#52448: key-valid-p vs "C-M-x" and "ESC C-x"
Date: Sun, 12 Dec 2021 09:27:03 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> AFAIU, we want exactly one valid way to write keybindings with
> `key-valid-p'.  Should both of these be `key-valid-p'?
>
> 1.  (key-description (kbd "ESC C-x"))
>     => "C-M-x"
>
>     (key-valid-p "ESC C-x")
>     => t

That's what happens today, but Stefan M had a cunning plan to make
round-tripping these keystrokes (EST/TAB/RET) work better.

In that case

"ESC C-x"

and

"C-M-x"

would still both be valid, but refer to different things (that get
resolved to the same thing).

But we're not there today, so when writing keymaps one should use the
intended mnemonics.  For instance, it's

  "C-c C-i" #'gnus-info-find-node

and not

  "C-c TAB" #'gnus-info-find-node

because the "i" is for "info".

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.