From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: dick.r.chiang@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Dec 2021 21:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 52440@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs Received: via spool by submit@debbugs.gnu.org id=B.16392583389651 (code B ref -1); Sat, 11 Dec 2021 21:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Dec 2021 21:32:18 +0000 Received: from localhost ([127.0.0.1]:50163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw9yX-0002VW-Al for submit@debbugs.gnu.org; Sat, 11 Dec 2021 16:32:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:49872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw9yT-0002VM-3V for submit@debbugs.gnu.org; Sat, 11 Dec 2021 16:32:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mw9yS-0000Sn-TH for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 16:32:08 -0500 Received: from [2607:f8b0:4864:20::f34] (port=42953 helo=mail-qv1-xf34.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mw9yO-0007ky-FL for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 16:32:08 -0500 Received: by mail-qv1-xf34.google.com with SMTP id p3so11104921qvj.9 for ; Sat, 11 Dec 2021 13:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=mJz9xtZCz3WNvom6pGSbdfGBlV3vjJtyMyWhy8uLizc=; b=ZRY7e/dOPR3mrlFWJHR6yq16R1QA0n3/RNM3FdwZ59AdtRr35bHAtslVXG/slVmM5z k6fEh9OYe8MZbhzY6RcAdMpkzElOwkWsfKDUe3Q/8z0OXexUVGtGGasBeqs9rkJ7MTTA XXq4FRYMXbhmpuQRBvaxV/uSL4RTHy6ri+jdia5U3BAohYA4st0yb7VP2QStYBVxG67a iSpzhFd6sUZ2VnI/iZITQxTqQu6D4hhvA4GqMfToRnlf+LE2M8ZW6ahgaPbcnAg/0nzZ QWpMaKzsSk2BYzTeVTk+fz5S1EXhpWkqhtJiE7JdSKqPcWb9N/kbOL0Jd58mFAcLo7nG p0yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=mJz9xtZCz3WNvom6pGSbdfGBlV3vjJtyMyWhy8uLizc=; b=wHT/EAlqYLRmQe40ywdRRsMXPiadRRzfpfm8Z0WIZ8qqa/wVF/v1nLZkUCxYd9FWbz iUy7cns7qhxOKMRRbDtE/LUDbJfAcx1+kQXsIdLz+//Yt9QyJQS5VsWU/rD/UHbI1+sw QncVwuaUgl7Uqj/cU+onZKlac+YAVnL8Vq81/oroP9Srab+5UdKDxijyD+lL427ABmmR VB0YJKMUtAEtWT7xpu53uYXK0hKISSHh1R6nXGhWXWSGGCw455kdC0rYOOj48CUo/FJp WmuqlUH8cU9KA/Qi2f7ZJrJlYn8fpfB8RzOzA133UFtEcj4y49yECiMShywBDOPEGbv4 fyfA== X-Gm-Message-State: AOAM5327fcoPAypprsGuv73d5JjiTVoYxjBUF+blpNCT0rcLqapQrO5Q Iv7BT7ocb/O3XKQjaAFyKktXYh+FJ/I= X-Google-Smtp-Source: ABdhPJxwlA19/PBwl5H+wjvj9V4p2ED3jMf17/LTSgfOzDsMOlw8+TAHcOaIQy5ZYa5t4qONGmQFew== X-Received: by 2002:ad4:5b8f:: with SMTP id 15mr33660008qvp.60.1639258322831; Sat, 11 Dec 2021 13:32:02 -0800 (PST) Received: from localhost ([68.237.93.126]) by smtp.gmail.com with ESMTPSA id k8sm3520056qko.130.2021.12.11.13.32.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Dec 2021 13:32:02 -0800 (PST) From: dick.r.chiang@gmail.com Date: Sat, 11 Dec 2021 16:32:01 -0500 Message-ID: <87wnkazv3i.fsf@dick> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f34 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::f34; envelope-from=dick.r.chiang@gmail.com; helo=mail-qv1-xf34.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain More cleanly separate the new module from standard builds, aka, slow thy roll. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-sqlite3-Quis-custodiet-ipsos-custodes.patch >From c7b20a867b795d0ebfa6d5572c31a72f3caa926a Mon Sep 17 00:00:00 2001 From: dickmao Date: Sat, 11 Dec 2021 16:21:30 -0500 Subject: [PATCH] [sqlite3] Quis custodiet ipsos custodes * configure.ac (WIDE_EMACS_INT): Default off `--with-sqlite3`. (HAVE_SQLITE3): Opt out of sqlite.o. (SQLITE3_LIBS): Hew to autotools sop. * lisp/sqlite-mode.el (sqlite-execute, sqlite-more-p, sqlite-next, sqlite-columns, sqlite-finalize, sqlite-select, sqlite-open): Forward declare. * src/Makefile.in (SQLITE3_CFLAGS): Hew to autotools sop. * src/alloc.c (union emacs_align_type): Give a hoot, don't pollute. (cleanup_vector): Give a hoot, don't pollute. * src/data.c (syms_of_data): Fence. * src/emacs.c (main): Give a hoot, don't pollute. * src/lisp.h (GCALIGNED_STRUCT): Give a hoot, don't pollute. * src/print.c (print_vectorlike): Fence. * src/sqlite.c (Fsqlitep): What is SQLITE without the P? (Fsqlite_available_p): Unfence. (syms_of_sqlite): Unfence. * test/src/sqlite-tests.el (sqlite-mode, sqlite-execute, sqlite-close, sqlitep, sqlite-available-p, sqlite-finalize, sqlite-next, sqlite-more-p, sqlite-select, sqlite-open): Forward declare. --- configure.ac | 21 ++++++++------ lisp/sqlite-mode.el | 8 ++++++ src/Makefile.in | 12 ++++++-- src/alloc.c | 11 +++++++- src/data.c | 1 + src/emacs.c | 8 +++++- src/lisp.h | 36 ------------------------ src/print.c | 7 ++++- src/sqlite.c | 18 ++---------- src/sqlite.h | 59 ++++++++++++++++++++++++++++++++++++++++ test/Makefile.in | 1 - test/src/sqlite-tests.el | 11 ++++++++ 12 files changed, 127 insertions(+), 66 deletions(-) create mode 100644 src/sqlite.h diff --git a/configure.ac b/configure.ac index 0debc852141..a602e45cefe 100644 --- a/configure.ac +++ b/configure.ac @@ -448,7 +448,7 @@ AC_DEFUN OPTION_DEFAULT_ON([png],[don't compile with PNG image support]) OPTION_DEFAULT_ON([rsvg],[don't compile with SVG image support]) OPTION_DEFAULT_ON([webp],[don't compile with WebP image support]) -OPTION_DEFAULT_ON([sqlite3],[don't compile with sqlite3 support]) +OPTION_DEFAULT_OFF([sqlite3],[don't compile with sqlite3 support]) OPTION_DEFAULT_ON([lcms2],[don't compile with Little CMS support]) OPTION_DEFAULT_ON([libsystemd],[don't compile with libsystemd support]) OPTION_DEFAULT_ON([cairo],[don't compile with Cairo drawing]) @@ -2682,27 +2682,32 @@ AC_DEFUN fi fi -### Use -lsqlite3 if available, unless '--with-sqlite3=no' HAVE_SQLITE3=no +SQLITE3_OBJ= +### Use -lsqlite3 if available, unless '--with-sqlite3=no' if test "${with_sqlite3}" != "no"; then AC_CHECK_LIB(sqlite3, sqlite3_open_v2, HAVE_SQLITE3=yes, HAVE_SQLITE3=no) if test "$HAVE_SQLITE3" = "yes"; then SQLITE3_LIBS=-lsqlite3 - AC_SUBST(SQLITE3_LIBS) - LIBS="$SQLITE3_LIBS $LIBS" + SQLITE3_OBJ=sqlite.o AC_DEFINE(HAVE_SQLITE3, 1, [Define to 1 if you have the libsqlite3 library (-lsqlite).]) - # Windows loads libsqlite dynamically - if test "${opsys}" = "mingw32"; then - SQLITE3_LIBS= - fi AC_CHECK_LIB(sqlite3, sqlite3_load_extension, HAVE_SQLITE3_LOAD_EXTENSION=yes, HAVE_SQLITE3_LOAD_EXTENSION=no) if test "$HAVE_SQLITE3_LOAD_EXTENSION" = "yes"; then AC_DEFINE(HAVE_SQLITE3_LOAD_EXTENSION, 1, [Define to 1 if sqlite3 supports loading extensions.]) fi + # Windows loads libsqlite dynamically + if test "${opsys}" = "mingw32"; then + SQLITE3_LIBS= + fi fi fi +AC_SUBST(HAVE_SQLITE3) +AC_SUBST(SQLITE3_LIBS) +AC_SUBST(SQLITE3_CFLAGS) +AC_SUBST(SQLITE3_OBJ) + HAVE_IMAGEMAGICK=no if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" || test "${HAVE_W32}" = "yes" || \ test "${HAVE_BE_APP}" = "yes"; then diff --git a/lisp/sqlite-mode.el b/lisp/sqlite-mode.el index 9306bd85dcd..823dfeb07d6 100644 --- a/lisp/sqlite-mode.el +++ b/lisp/sqlite-mode.el @@ -25,6 +25,14 @@ (require 'cl-lib) +(declare-function sqlite-execute "sqlite.c") +(declare-function sqlite-more-p "sqlite.c") +(declare-function sqlite-next "sqlite.c") +(declare-function sqlite-columns "sqlite.c") +(declare-function sqlite-finalize "sqlite.c") +(declare-function sqlite-select "sqlite.c") +(declare-function sqlite-open "sqlite.c") + (defvar-keymap sqlite-mode-map "g" #'sqlite-mode-list-tables "c" #'sqlite-mode-list-columns diff --git a/src/Makefile.in b/src/Makefile.in index 3a8445db2d4..85c10103c4e 100644 --- a/src/Makefile.in +++ b/src/Makefile.in @@ -238,6 +238,8 @@ IMAGEMAGICK_CFLAGS= LIBXML2_LIBS = @LIBXML2_LIBS@ LIBXML2_CFLAGS = @LIBXML2_CFLAGS@ +SQLITE3_CFLAGS = @SQLITE3_CFLAGS@ +SQLITE3_OBJ = @SQLITE3_OBJ@ SQLITE3_LIBS = @SQLITE3_LIBS@ GETADDRINFO_A_LIBS = @GETADDRINFO_A_LIBS@ @@ -330,6 +332,10 @@ JSON_LIBS = JSON_CFLAGS = @JSON_CFLAGS@ JSON_OBJ = @JSON_OBJ@ +SQLITE3_LIBS = @SQLITE3_LIBS@ +SQLITE3_CFLAGS = @SQLITE3_CFLAGS@ +SQLITE3_OBJ = @SQLITE3_OBJ@ + INTERVALS_H = dispextern.h intervals.h composite.h GETLOADAVG_LIBS = @GETLOADAVG_LIBS@ @@ -395,7 +401,7 @@ EMACS_CFLAGS= $(HARFBUZZ_CFLAGS) $(LIBOTF_CFLAGS) $(M17N_FLT_CFLAGS) $(DEPFLAGS) \ $(LIBSYSTEMD_CFLAGS) $(JSON_CFLAGS) \ $(LIBGNUTLS_CFLAGS) $(NOTIFY_CFLAGS) $(CAIRO_CFLAGS) \ - $(WERROR_CFLAGS) $(HAIKU_CFLAGS) + $(WERROR_CFLAGS) $(HAIKU_CFLAGS) $(SQLITE3_CFLAGS) ALL_CFLAGS = $(EMACS_CFLAGS) $(WARN_CFLAGS) $(CFLAGS) ALL_OBJC_CFLAGS = $(EMACS_CFLAGS) \ $(filter-out $(NON_OBJC_CFLAGS),$(WARN_CFLAGS)) $(CFLAGS) \ @@ -428,11 +434,11 @@ base_obj = doprnt.o intervals.o textprop.o composite.o xml.o lcms.o $(NOTIFY_OBJ) \ $(XWIDGETS_OBJ) \ profiler.o decompress.o \ - thread.o systhread.o sqlite.o \ + thread.o systhread.o \ $(if $(HYBRID_MALLOC),sheap.o) \ $(MSDOS_OBJ) $(MSDOS_X_OBJ) $(NS_OBJ) $(CYGWIN_OBJ) $(FONT_OBJ) \ $(W32_OBJ) $(WINDOW_SYSTEM_OBJ) $(XGSELOBJ) $(JSON_OBJ) \ - $(HAIKU_OBJ) + $(HAIKU_OBJ) $(SQLITE3_OBJ) doc_obj = $(base_obj) $(NS_OBJC_OBJ) obj = $(doc_obj) $(HAIKU_CXX_OBJ) diff --git a/src/alloc.c b/src/alloc.c index 9f52a414d68..a9ba9885fd8 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -50,6 +50,10 @@ Copyright (C) 1985-1986, 1988, 1993-1995, 1997-2021 Free Software #include TERM_HEADER #endif /* HAVE_WINDOW_SYSTEM */ +#ifdef HAVE_SQLITE3 +#include "sqlite.h" +#endif + #include #include #include /* For backtrace. */ @@ -125,7 +129,6 @@ Copyright (C) 1985-1986, 1988, 1993-1995, 1997-2021 Free Software struct Lisp_Overlay Lisp_Overlay; struct Lisp_Sub_Char_Table Lisp_Sub_Char_Table; struct Lisp_Subr Lisp_Subr; - struct Lisp_Sqlite Lisp_Sqlite; struct Lisp_User_Ptr Lisp_User_Ptr; struct Lisp_Vector Lisp_Vector; struct terminal terminal; @@ -3181,6 +3184,12 @@ cleanup_vector (struct Lisp_Vector *vector) } } #endif +#ifdef HAVE_SQLITE3 + else if (PSEUDOVECTOR_TYPEP (&vector->header, PVEC_SQLITE)) + { + /* clean s___ up. To be implemented. */ + } +#endif } /* Reclaim space used by unmarked vectors. */ diff --git a/src/data.c b/src/data.c index f07667b0003..81ae2f412ad 100644 --- a/src/data.c +++ b/src/data.c @@ -4069,6 +4069,7 @@ #define PUT_ERROR(sym, tail, msg) \ DEFSYM (Qterminal, "terminal"); DEFSYM (Qxwidget, "xwidget"); DEFSYM (Qxwidget_view, "xwidget-view"); + DEFSYM (Qsqlite, "sqlite"); DEFSYM (Qdefun, "defun"); diff --git a/src/emacs.c b/src/emacs.c index 3fc055aed92..05441b06825 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -81,6 +81,10 @@ #define MAIN_PROGRAM #include TERM_HEADER #endif /* HAVE_WINDOW_SYSTEM */ +#ifdef HAVE_SQLITE3 +#include "sqlite.h" +#endif /* HAVE_SQLITE3 */ + #include "bignum.h" #include "intervals.h" #include "character.h" @@ -2183,8 +2187,10 @@ main (int argc, char **argv) #endif syms_of_window (); syms_of_xdisp (); - syms_of_sqlite (); syms_of_font (); +#ifdef HAVE_SQLITE3 + syms_of_sqlite (); +#endif #ifdef HAVE_WINDOW_SYSTEM syms_of_fringe (); syms_of_image (); diff --git a/src/lisp.h b/src/lisp.h index 92ab05b4228..aa48b218d36 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -2571,17 +2571,6 @@ xmint_pointer (Lisp_Object a) return XUNTAG (a, Lisp_Vectorlike, struct Lisp_Misc_Ptr)->pointer; } -struct Lisp_Sqlite -{ - union vectorlike_header header; - void *db; - void *stmt; - char *name; - void (*finalizer) (void *); - bool eof; - bool is_statement; -} GCALIGNED_STRUCT; - struct Lisp_User_Ptr { union vectorlike_header header; @@ -2659,31 +2648,6 @@ XUSER_PTR (Lisp_Object a) return XUNTAG (a, Lisp_Vectorlike, struct Lisp_User_Ptr); } -INLINE bool -SQLITEP (Lisp_Object x) -{ - return PSEUDOVECTORP (x, PVEC_SQLITE); -} - -INLINE bool -SQLITE (Lisp_Object a) -{ - return PSEUDOVECTORP (a, PVEC_SQLITE); -} - -INLINE void -CHECK_SQLITE (Lisp_Object x) -{ - CHECK_TYPE (SQLITE (x), Qsqlitep, x); -} - -INLINE struct Lisp_Sqlite * -XSQLITE (Lisp_Object a) -{ - eassert (SQLITEP (a)); - return XUNTAG (a, Lisp_Vectorlike, struct Lisp_Sqlite); -} - INLINE bool BIGNUMP (Lisp_Object x) { diff --git a/src/print.c b/src/print.c index 214f1d12c11..f06ceb308a6 100644 --- a/src/print.c +++ b/src/print.c @@ -40,6 +40,10 @@ Copyright (C) 1985-1986, 1988, 1993-1995, 1997-2021 Free Software #include #include +#ifdef HAVE_SQLITE3 +#include +#endif + #if IEEE_FLOATING_POINT # include #endif @@ -1875,6 +1879,7 @@ print_vectorlike (Lisp_Object obj, Lisp_Object printcharfun, bool escapeflag, } break; #endif +#ifdef HAVE_SQLITE3 case PVEC_SQLITE: { print_c_string ("#', printcharfun); } break; - +#endif default: emacs_abort (); } diff --git a/src/sqlite.c b/src/sqlite.c index d92dcf723c9..f9b57c8d387 100644 --- a/src/sqlite.c +++ b/src/sqlite.c @@ -25,8 +25,7 @@ Copyright (C) 2021 Free Software Foundation, Inc. #include #include "lisp.h" #include "coding.h" - -#ifdef HAVE_SQLITE3 +#include "sqlite.h" #include @@ -644,24 +643,17 @@ DEFUN ("sqlite-finalize", Fsqlite_finalize, Ssqlite_finalize, 1, 1, 0, return Qt; } -#endif /* HAVE_SQLITE3 */ - DEFUN ("sqlitep", Fsqlitep, Ssqlitep, 1, 1, 0, doc: /* Say whether OBJECT is an SQlite object. */) (Lisp_Object object) { -#ifdef HAVE_SQLITE3 - return SQLITE (object)? Qt: Qnil; -#else - return Qnil; -#endif + return SQLITEP (object) ? Qt: Qnil; } DEFUN ("sqlite-available-p", Fsqlite_available_p, Ssqlite_available_p, 0, 0, 0, doc: /* Return t if sqlite3 support is available in this instance of Emacs.*/) (void) { -#ifdef HAVE_SQLITE3 # ifdef WINDOWSNT Lisp_Object found = Fassq (Qsqlite3, Vlibrary_cache); if (CONSP (found)) @@ -671,15 +663,11 @@ DEFUN ("sqlite-available-p", Fsqlite_available_p, Ssqlite_available_p, 0, 0, 0, # else return Qt; #endif -#else - return Qnil; -#endif } void syms_of_sqlite (void) { -#ifdef HAVE_SQLITE3 defsubr (&Ssqlite_open); defsubr (&Ssqlite_close); defsubr (&Ssqlite_execute); @@ -696,7 +684,7 @@ syms_of_sqlite (void) defsubr (&Ssqlite_finalize); DEFSYM (Qset, "set"); DEFSYM (Qfull, "full"); -#endif + defsubr (&Ssqlitep); DEFSYM (Qsqlitep, "sqlitep"); defsubr (&Ssqlite_available_p); diff --git a/src/sqlite.h b/src/sqlite.h new file mode 100644 index 00000000000..0d26f0b7b8f --- /dev/null +++ b/src/sqlite.h @@ -0,0 +1,59 @@ +/* Header file for the sqlite3 integration. + +Copyright (C) 2021 Free Software Foundation, Inc. + +This file is NOT part of GNU Emacs. + +GNU Emacs is free software: you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation, either version 3 of the License, or (at +your option) any later version. + +GNU Emacs is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with GNU Emacs. If not, see . */ + +#ifndef EMACS_SQLITE_H +#define EMACS_SQLITE_H + +#include "lisp.h" + +INLINE_HEADER_BEGIN + +struct Lisp_Sqlite +{ + union vectorlike_header header; + void *db; + void *stmt; + char *name; + void (*finalizer) (void *); + bool eof; + bool is_statement; +}; + +INLINE bool +SQLITEP (Lisp_Object x) +{ + return PSEUDOVECTORP (x, PVEC_SQLITE); +} + +INLINE struct Lisp_Sqlite * +XSQLITE (Lisp_Object a) +{ + eassert (SQLITEP (a)); + return XUNTAG (a, Lisp_Vectorlike, struct Lisp_Sqlite); +} + +INLINE void +CHECK_SQLITE (Lisp_Object sql) +{ + CHECK_TYPE (SQLITEP (sql), Qsqlitep, sql); +} + +INLINE_HEADER_END + +#endif /* EMACS_SQLITE_H */ diff --git a/test/Makefile.in b/test/Makefile.in index f2c49584e7f..f3f7855b439 100644 --- a/test/Makefile.in +++ b/test/Makefile.in @@ -48,7 +48,6 @@ SO = SEPCHAR = @SEPCHAR@ HAVE_NATIVE_COMP = @HAVE_NATIVE_COMP@ - REPLACE_FREE = @REPLACE_FREE@ -include ${top_builddir}/src/verbose.mk diff --git a/test/src/sqlite-tests.el b/test/src/sqlite-tests.el index 7ccea1c2a54..58949b2ebc6 100644 --- a/test/src/sqlite-tests.el +++ b/test/src/sqlite-tests.el @@ -25,6 +25,17 @@ (require 'ert) (require 'ert-x) +(require 'sqlite-mode) + +(declare-function sqlite-execute "sqlite.c") +(declare-function sqlite-close "sqlite.c") +(declare-function sqlitep "sqlite.c") +(declare-function sqlite-available-p "sqlite.c") +(declare-function sqlite-finalize "sqlite.c") +(declare-function sqlite-next "sqlite.c") +(declare-function sqlite-more-p "sqlite.c") +(declare-function sqlite-select "sqlite.c") +(declare-function sqlite-open "sqlite.c") (ert-deftest sqlite-select () (skip-unless (sqlite-available-p)) -- 2.26.2 --=-=-= Content-Type: text/plain In Commercial Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2021-12-11 built on dick Repository revision: 783c1910c3bdc9fc47fee3b305fa3e4c17d42b7b Repository branch: longlines Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 18.04.4 LTS Configured using: 'configure --prefix=/home/dick/.local --enable-checking --with-tree-sitter --enable-dumping-overwrite CC=gcc-10 'CFLAGS=-g3 -Og -I/home/dick/.local/include/' LDFLAGS=-L/home/dick/.local/lib PKG_CONFIG_PATH=/home/dick/.local/lib/pkgconfig CXX=gcc-10' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON TREE-SITTER LCMS2 LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Magit Minor modes in effect: async-bytecomp-package-mode: t global-git-commit-mode: t shell-dirtrack-mode: t projectile-mode: t flx-ido-mode: t override-global-mode: t global-hl-line-mode: t winner-mode: t tooltip-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/dick/gomacro-mode/gomacro-mode hides /home/dick/.emacs.d/elpa/gomacro-mode-20200326.1103/gomacro-mode /home/dick/.emacs.d/elpa/hydra-20170924.2259/lv hides /home/dick/.emacs.d/elpa/lv-20191106.1238/lv /home/dick/.emacs.d/elpa/magit-3.3.0/magit-section-pkg hides /home/dick/.emacs.d/elpa/magit-section-3.3.0/magit-section-pkg /home/dick/org-gcal.el/org-gcal hides /home/dick/.emacs.d/elpa/org-gcal-0.3/org-gcal /home/dick/.emacs.d/lisp/json hides /home/dick/emacs/lisp/json /home/dick/.emacs.d/elpa/transient-0.3.6/transient hides /home/dick/emacs/lisp/transient /home/dick/.emacs.d/elpa/hierarchy-20171221.1151/hierarchy hides /home/dick/emacs/lisp/emacs-lisp/hierarchy Features: (shadow sort footnote mail-extr gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr pixel-fill kinsoku svg dom gnus-group mm-url gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win emacsbug sendmail benchmark pulse help-fns radix-tree find-func vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-cvs vc-rcs tramp-archive tramp-gvfs tramp-cache zeroconf dbus xml tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat parse-time iso8601 ls-lisp vc bug-reference cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs magit-extras sh-script executable rect face-remap magit-patch-changelog magit-patch magit-submodule magit-obsolete magit-popup async-bytecomp async magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff git-commit log-edit message yank-media rmc puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader pcvs-util add-log magit-core magit-margin magit-transient magit-process with-editor shell pcomplete server magit-mode transient format-spec make-mode ag vc-svn find-dired s dired-x dired dired-loaddefs misearch multi-isearch vc-git diff-mode vc-dispatcher autoconf autoconf-mode paredit-ext paredit subed subed-vtt subed-srt subed-common subed-mpv subed-debug subed-config inf-ruby ruby-mode smie company pcase haskell-interactive-mode haskell-presentation-mode haskell-process haskell-session haskell-compile haskell-mode haskell-cabal haskell-utils haskell-font-lock haskell-indentation haskell-string haskell-sort-imports haskell-lexeme haskell-align-imports haskell-complete-module haskell-ghc-support noutline outline flymake-proc flymake warnings etags fileloop generator xref project dabbrev haskell-customize hydra lv use-package-ensure solarized-theme solarized-definitions projectile lisp-mnt mail-parse rfc2231 ibuf-ext ibuffer ibuffer-loaddefs thingatpt magit-autorevert autorevert filenotify magit-git magit-section magit-utils crm dash rx grep compile comint ansi-color gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils text-property-search time-date flx-ido flx google-translate-default-ui google-translate-core-ui facemenu color ido google-translate-core google-translate-tk google-translate-backend use-package-bind-key bind-key auto-complete easy-mmode advice edmacro kmacro popup cus-edit pp cus-load wid-edit emms-player-mplayer emms-player-simple emms emms-compat cl-extra help-mode use-package-core derived hl-line winner ring finder-inf json-reformat-autoloads json-snatcher-autoloads sml-mode-autoloads tornado-template-mode-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tree-sitter tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 974965 153625) (symbols 48 35753 1) (strings 32 136426 20527) (string-bytes 1 4530479) (vectors 16 98269) (vector-slots 8 2745491 89364) (floats 8 464 1477) (intervals 56 71313 6420) (buffers 992 32)) --=-=-=-- From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 06:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: dick.r.chiang@gmail.com Cc: 52440@debbugs.gnu.org, Eli Zaretskii Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163928956119300 (code B ref 52440); Sun, 12 Dec 2021 06:13:02 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 06:12:41 +0000 Received: from localhost ([127.0.0.1]:50514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwI6C-00051D-SG for submit@debbugs.gnu.org; Sun, 12 Dec 2021 01:12:41 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwI5x-00050i-SR for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 01:12:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ks1q0mG7xuuhgXNYG9OC8FqoVrmwfvzamSkZt6ADTfw=; b=I4G/a6e6Hyd4LcJPL9zC6QaOX6 iSPIf68FDKyFe7+ZTzAjsweBckfWuMoxzk73b0bt4WyxAofGKP2NZDbHSgUKh3hcXBzZRfBgD34S9 +Pbk+NUNdH9BGPVpXdOt2PEyoCZphRTL1/njk41poyHDDazsfMM9uju56ejdQT8JgI38=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwI5o-0002c0-TA; Sun, 12 Dec 2021 07:12:19 +0100 From: Lars Ingebrigtsen References: <87wnkazv3i.fsf@dick> X-Now-Playing: Xeno & Oaklander's _Vi-deo_: "Infinite Sadness" Date: Sun, 12 Dec 2021 07:12:16 +0100 In-Reply-To: <87wnkazv3i.fsf@dick> (dick r. chiang's message of "Sat, 11 Dec 2021 16:32:01 -0500") Message-ID: <87r1aie4hr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: dick.r.chiang@gmail.com writes: > -OPTION_DEFAULT_ON([sqlite3], [don't compile with sqlite3 support]) > +OPTION_DEFAULT_OFF([sqlite3], [don't compile with sqlite3 support]) No, we're defaulting it to on. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) dick.r.chiang@gmail.com writes: > -OPTION_DEFAULT_ON([sqlite3],[don't compile with sqlite3 support]) > +OPTION_DEFAULT_OFF([sqlite3],[don't compile with sqlite3 support]) No, we're defaulting it to on. > - AC_SUBST(SQLITE3_LIBS) > - LIBS="$SQLITE3_LIBS $LIBS" > + SQLITE3_OBJ=sqlite.o No, we're always building the sqlite.o file. We've tried out different variants of this over the years, but always compiling the files (and if-deffing out almost everything in it) is the least work in the long run. > diff --git a/lisp/sqlite-mode.el b/lisp/sqlite-mode.el > index 9306bd85dcd..823dfeb07d6 100644 > --- a/lisp/sqlite-mode.el > +++ b/lisp/sqlite-mode.el > @@ -25,6 +25,14 @@ > > (require 'cl-lib) > > +(declare-function sqlite-execute "sqlite.c") > +(declare-function sqlite-more-p "sqlite.c") > +(declare-function sqlite-next "sqlite.c") > +(declare-function sqlite-columns "sqlite.c") > +(declare-function sqlite-finalize "sqlite.c") > +(declare-function sqlite-select "sqlite.c") > +(declare-function sqlite-open "sqlite.c") Thanks; applied. > --- a/src/lisp.h > +++ b/src/lisp.h > @@ -2571,17 +2571,6 @@ xmint_pointer (Lisp_Object a) > return XUNTAG (a, Lisp_Vectorlike, struct Lisp_Misc_Ptr)->pointer; > } > > -struct Lisp_Sqlite > -{ > - union vectorlike_header header; > - void *db; > - void *stmt; > - char *name; > - void (*finalizer) (void *); > - bool eof; > - bool is_statement; > -} GCALIGNED_STRUCT; I thought including this in lisp.h instead of adding a separate .h and #ifdeffing all over the place was the most readable, but I have no strong opinion on that. Eli, what do you think? > --- a/test/src/sqlite-tests.el > +++ b/test/src/sqlite-tests.el > @@ -25,6 +25,17 @@ > > (require 'ert) > (require 'ert-x) > +(require 'sqlite-mode) I don't think this file is testing anything in sqlite-mode? > +(declare-function sqlite-execute "sqlite.c") > +(declare-function sqlite-close "sqlite.c") > +(declare-function sqlitep "sqlite.c") > +(declare-function sqlite-available-p "sqlite.c") > +(declare-function sqlite-finalize "sqlite.c") > +(declare-function sqlite-next "sqlite.c") > +(declare-function sqlite-more-p "sqlite.c") > +(declare-function sqlite-select "sqlite.c") > +(declare-function sqlite-open "sqlite.c") Thanks; applied. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 01:14:07 2021 Received: (at control) by debbugs.gnu.org; 12 Dec 2021 06:14:07 +0000 Received: from localhost ([127.0.0.1]:50518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwI7b-00053n-G1 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 01:14:07 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwI7Z-00053B-FJ for control@debbugs.gnu.org; Sun, 12 Dec 2021 01:14:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T15Y/SmZrrCSEkOPdWodcdiQlc69NuGnD9loHjTtS14=; b=aLSN2VFQHI5EfnH73gIp9eZtIG 7hXJb6NdZ/BPJa6Pfo/EfGyQVVsX53V2jBc18kcK743bcfwYHGwCcpm5s4Ry4J8ZPG5lO8FFmMavT KNgGoDhOrIfYQwevgpwpiSFETwspFJdO3Y0JSoHibriwjtXIovfByLDomwX8C5p/KeVw=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwI7R-0002ef-D2 for control@debbugs.gnu.org; Sun, 12 Dec 2021 07:13:59 +0100 Date: Sun, 12 Dec 2021 07:13:56 +0100 Message-Id: <87pmq2e4ez.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #52440 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 52440 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 52440 + moreinfo quit From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 07:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Lars Ingebrigtsen Cc: 52440@debbugs.gnu.org, dick.r.chiang@gmail.com Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163929555514293 (code B ref 52440); Sun, 12 Dec 2021 07:53:02 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 07:52:35 +0000 Received: from localhost ([127.0.0.1]:50600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwJet-0003iT-IU for submit@debbugs.gnu.org; Sun, 12 Dec 2021 02:52:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwJes-0003iG-Kd for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 02:52:34 -0500 Received: from [2001:470:142:3::e] (port=53500 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwJen-00005P-BV; Sun, 12 Dec 2021 02:52:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yaoBis1lk09MnGbvvnbms6fRyCUUuoqCTulm/V8LskU=; b=TAqUaCk81WwW w295S0mwIN+fL3DK5rsCph8Y7e+j8MyFTs+s1TF3dSkbXUz4ofhmUhmqGT1t0LFGIgwSssWxuFfMm yAsM8tBH6aUh4KFdkyz9NhZvPw7ZYLYuEd+maVcg3kLHPYG4vXld/j8QConrrhMPA8J0ZDzIr9SL6 8qa5Dkkm7DQkjEfpUO+eted4xUYzLZs6kWWakWkc9NDZOdQpf/7Re8DT4Tsl3lUwBH56VFn/CgZ0y JLvPAuEvTe+sx8rBdn0J0Qij4HPvGW8Wewre0VKaGrwkLcAL7jg6lNcHFtujuUYPSI5aWayJsUQQ6 fg7QrIKjl/fezCu2i0QKNA==; Received: from [87.69.77.57] (port=2612 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwJen-0007Mf-62; Sun, 12 Dec 2021 02:52:29 -0500 Date: Sun, 12 Dec 2021 09:52:20 +0200 Message-Id: <83ee6ip8ej.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87r1aie4hr.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 12 Dec 2021 07:12:16 +0100) References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: 52440@debbugs.gnu.org, Eli Zaretskii > Date: Sun, 12 Dec 2021 07:12:16 +0100 > > > --- a/src/lisp.h > > +++ b/src/lisp.h > > @@ -2571,17 +2571,6 @@ xmint_pointer (Lisp_Object a) > > return XUNTAG (a, Lisp_Vectorlike, struct Lisp_Misc_Ptr)->pointer; > > } > > > > -struct Lisp_Sqlite > > -{ > > - union vectorlike_header header; > > - void *db; > > - void *stmt; > > - char *name; > > - void (*finalizer) (void *); > > - bool eof; > > - bool is_statement; > > -} GCALIGNED_STRUCT; > > I thought including this in lisp.h instead of adding a separate .h and > #ifdeffing all over the place was the most readable, but I have no > strong opinion on that. Eli, what do you think? I don't like including other headers in lisp.h if those headers define stuff important for the Lisp interpreter. We did that with thread.h, and I have a lot of bad memories from that experiment. The main problem is recursive dependencies between lisp.h and the included header (which bite you if you move the place of the inclusion). The need to recompile everything when the included header changes (because lisp.h is included by every source file) is also a nuisance. However, the proof of the pudding is in eating: we do something like the above with comp.h, for example (but also have HAVE_NATIVE_COMP conditionals in lisp.h all over the place), so eventually it depends on how many hoops we have to jump through to make the separation happen. If it's feasible to keep sqlite.h to a bare minimum, like comp.h did, but without leaving a lot of sqlite stuff in lisp.h, perhaps it's worthwhile? OTOH, sqlite has (or should have) a relatively small impact on lisp.h, as it basically defines a single data type. The amount of sqlite stuff in lisp.h is quite small, for that reason. So I tend to think a separate header is overkill. From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: dick Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 11:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Eli Zaretskii Cc: 52440@debbugs.gnu.org, Lars Ingebrigtsen Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163930875520914 (code B ref 52440); Sun, 12 Dec 2021 11:33:02 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 11:32:35 +0000 Received: from localhost ([127.0.0.1]:50802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwN5n-0005RG-Mz for submit@debbugs.gnu.org; Sun, 12 Dec 2021 06:32:35 -0500 Received: from mail-qk1-f180.google.com ([209.85.222.180]:38868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwN5l-0005R3-Vq for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 06:32:34 -0500 Received: by mail-qk1-f180.google.com with SMTP id l25so2479969qkl.5 for <52440@debbugs.gnu.org>; Sun, 12 Dec 2021 03:32:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8QtrGvjIp/2I7YZewUcVyst4uFyURuLPNagFvx4dHe8=; b=mu4FetlpwMnArgha4m7Dj5ot51IgqBWdbx39EEp00tMJkLcOVXUJDOURmI+lFZr/5m bcZUnQGPLOwv7+foF9i6fbfLtwuTzhf5mlcdy4MNZJTIcVQ2nE7u66x349G3hcQqZzDO ThNL/kS4YAZPhtVz123mK3yQ30xzvFbMVUjdHz6VGMTgU4yJAnNsGOYMuayaVPgNRr84 sn9No1j/LOPGrs+7poTJpOtvjDM/XJTD5A5FgzAjLA0dJB/u9hB2+WXLWDUpa5MjgiKU kZFG027t/CjpneeXXxQwrVUw+swWnF4mYPSNnwTEa16A7wn9xhPbe/XMS4pNB65ujt1r v7Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8QtrGvjIp/2I7YZewUcVyst4uFyURuLPNagFvx4dHe8=; b=HBERQmmclxZh9tGfkkwWzr1sLM5uNfG75G2Z7x7DujcUoLL2xIa0+ODDqI+QkCuAeD wgLLOknnMNUUpUylhFE0NRSz/DrK8wJN2GD43R1oZ6C4zCF4sbZ1dsYCp3nMXm/SlOhg OqWwf8J0Iili77l3n61nRKXJLkXtUqJ9xmlJ0oywViMqHDIJN2dQ2UFRfuRt0/vFXV9M zhhZhyUS6ftdEDnUoIDZhbFN/5mN2AcZbEv0Gd1dAZU/afmx2zTZ/You25yemMWZrUtk QjMOsJQ+zSC1vnw6YpxdaAekNeXDar6Pu4b8lgdS6B6RlJohCo05bhF4tbsVOQ/RA2pY OEsg== X-Gm-Message-State: AOAM531zK+fTRUYKbbTxFNMiG5NTc72D4QyTmfsjjHGvDrIMIcn9+B/V l8udgJF44V0B58Gr8iIdnl0= X-Google-Smtp-Source: ABdhPJxgnPDTNVm9wJvoOirhSbvnXgN9Fd5F4+J6ybNlmS7y5U/zZxjTFaNrKkqL9ripmvidEl5ctg== X-Received: by 2002:a05:620a:22f5:: with SMTP id p21mr28417319qki.498.1639308748225; Sun, 12 Dec 2021 03:32:28 -0800 (PST) Received: from localhost ([68.237.93.126]) by smtp.gmail.com with ESMTPSA id b9sm6641229qtb.53.2021.12.12.03.32.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Dec 2021 03:32:27 -0800 (PST) From: dick References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> Date: Sun, 12 Dec 2021 06:32:27 -0500 In-Reply-To: <83ee6ip8ej.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Dec 2021 09:52:20 +0200") Message-ID: <87lf0q6otw.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) EZ> The amount of sqlite stuff in lisp.h is quite small... So I tend EZ> to think a separate header is overkill. Thinking about this in terms of number of bytes added to lisp.h is the wrong way to think about it. I agree that Lisp_Process, while important, doesn't belong in lisp.h. That something as ancillary, third-party, and controversial as Lisp_Sqlite does get into lisp.h is a testimony about its author. From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 11:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Eli Zaretskii Cc: 52440@debbugs.gnu.org, dick.r.chiang@gmail.com Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163930979922559 (code B ref 52440); Sun, 12 Dec 2021 11:50:01 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 11:49:59 +0000 Received: from localhost ([127.0.0.1]:50806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNMd-0005rn-5e for submit@debbugs.gnu.org; Sun, 12 Dec 2021 06:49:59 -0500 Received: from quimby.gnus.org ([95.216.78.240]:47740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNMc-0005rY-36 for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 06:49:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NUFBcRajlOQEDai/YPVHmbgMUDfrOIQbi/yV3oWnGP4=; b=qP+S+zu//h2rWTzy4jqmITD/XB szZqIdtJIJkVVlZEQHEKuWylIjNGN+RF1nKGWQs7y+LozUvN+aFbCS77Sn+LoHOSCAzxe2+bXR8wo SmwcF5UL3x1TqXMBhGlpnM4EF+PvWfvsEbTlJdetztGP1Zst8flV5TSuVyXsq05e0Amk=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwNMR-0004sQ-Rm; Sun, 12 Dec 2021 12:49:51 +0100 From: Lars Ingebrigtsen References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUJCAkqKiofHx8e HiBISEdAPz7///+cw1o9AAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UMDAsvJVA2ceMAAAGQSURBVDjL 5VNBchwhDBRSHjDA+g5DHiBoPyAb+wOpyv/fkgbW5XXKe3BVbpma2Rm6JTUttCL/z3U8Isr6xSM6 PabGF+TDj0/AzMf8n1mEtA/rXbnH+FvqtW65N7Mae6zTOp6j3zmsV3S2yhqxGN/x+Ep05H7Cq0v4 +U4sCfAmAbm84dfpLTZC1tKLtfC0t/OddTClucwNXE29uSE+PZV6AlRezNIPBys8abE20BQjdfGV Qrb0FN0KnVUchmxG0EoIlHDC2kTTITXBLy7P5cxgLGSYFjkPRwS+sb7NqNkwhXRHFrtk2z5sNqk3 ldFHzJGE79A5OOOkzuCIxAPhxdgzM8GpSBJSGVH6xavksRtssFFo99Qs4VV6hsP3QRnHIBzdprJr R18ixgDKaFGPg5/BkdZhoTKncW8YOTvT3TN0ZdxGs2gePrhGVL0bh2KagxMZ9VRanC7txsHmOwA3 67LfmQfi41fC/ifMIF/xaaqdMZW/Js50RnpYiN8RzKVPn2XbjZC7zZVJoPmHYuvLppGMP6M+Mp5c oDFnAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTEyLTEyVDExOjQ3OjM3KzAwOjAwU9W4wAAAACV0 RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMi0xMlQxMTo0NzozNyswMDowMCKIAHwAAAAASUVORK5CYII= X-Now-Playing: Alasdair Roberts og =?UTF-8?Q?V=C3=B6lvur's?= _The Old Fabled River_: "Sweet William's Ghost" Date: Sun, 12 Dec 2021 12:49:42 +0100 In-Reply-To: <83ee6ip8ej.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Dec 2021 09:52:20 +0200") Message-ID: <8735my11rd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > OTOH, sqlite has (or should have) a relatively small impact on lisp.h, > as it basically defines a single data type. The amount of sqlite > stuff in lisp.h is quite small, for that reason. So I tend [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > OTOH, sqlite has (or should have) a relatively small impact on lisp.h, > as it basically defines a single data type. The amount of sqlite > stuff in lisp.h is quite small, for that reason. So I tend to think a > separate header is overkill. Yeah, me too. Separating it out doesn't seem like a clear win here, so I'm closing this bug report. (But if you do decide to rearrange this (and put it in a separate .h file), I won't protest -- I didn't really give the organisation much thought at all.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 06:50:10 2021 Received: (at control) by debbugs.gnu.org; 12 Dec 2021 11:50:10 +0000 Received: from localhost ([127.0.0.1]:50810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNMo-0005sk-Ct for submit@debbugs.gnu.org; Sun, 12 Dec 2021 06:50:10 -0500 Received: from quimby.gnus.org ([95.216.78.240]:47762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNMm-0005sR-Mb for control@debbugs.gnu.org; Sun, 12 Dec 2021 06:50:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rP1yYAblKhm66iWv+Vu3c+qDb+MjV/hs5w2oHpRQvkc=; b=RQxZLNbt0juNgSwPXORqEVVSr8 fBn1hh6/GwF/fL3s+SZUklpJzmMJsLBSQXS2VCnJDBq/hFGfOwubOzCYrzhk3ZFECXFXlnhh5KAtI PQBgohzMQ40qaEIfpoO++zK+HQJmciDc/HTuiraYXJzxGXqGMrfBv6ZuS1YyLDlEKPCw=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwNMe-0004sa-8J for control@debbugs.gnu.org; Sun, 12 Dec 2021 12:50:02 +0100 Date: Sun, 12 Dec 2021 12:49:57 +0100 Message-Id: <871r2i11qy.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #52440 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 52440 wontfix close 52440 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 52440 wontfix close 52440 quit From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 12:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch wontfix To: dick Cc: 52440@debbugs.gnu.org, larsi@gnus.org Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163931050029038 (code B ref 52440); Sun, 12 Dec 2021 12:02:01 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 12:01:40 +0000 Received: from localhost ([127.0.0.1]:50817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNXv-0007Xu-G9 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 07:01:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNXu-0007TH-9s for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 07:01:38 -0500 Received: from [2001:470:142:3::e] (port=57870 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNXo-0004Um-VL; Sun, 12 Dec 2021 07:01:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Bi32lkXXWX5aOMfMGy/sEgGyiOKr27tu0Yt0iNQiDDs=; b=kExMrekwucuV +hgpBkKsH3+aJy1Ey+oADkkMFSLQkvqMBWWjXHwHPI6yvzl//dKx7tgTtmHqDdwjn+OkispkMZRoT i4KDcHs+SRdwIf3RHo4bFTHePwm5S8OMJWmDWfSgN68Z3aI30u75RgkZ5mggQa+E26ua1nbpgP+XH gRneO1aJLtz3o61rr6tPQw6MnoHALe+ip0WOAPmofAB4j6pFWcn1LsMqf+kg6QKQEUw2s93jVHsfh lTR7tXUD6rQ8ilodkNqfa+UJQu11eNPreVU7Q3TD10NUUJ1onZcV46pZMl/FtqP2ySMusAr7hGESm ILf1ArrOIyyxdEFcrzcQ0Q==; Received: from [87.69.77.57] (port=2410 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNXo-00048x-OX; Sun, 12 Dec 2021 07:01:33 -0500 Date: Sun, 12 Dec 2021 14:01:23 +0200 Message-Id: <83wnkanib0.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87lf0q6otw.fsf@dick> (message from dick on Sun, 12 Dec 2021 06:32:27 -0500) References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> <87lf0q6otw.fsf@dick> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: dick > Cc: Lars Ingebrigtsen , 52440@debbugs.gnu.org > Date: Sun, 12 Dec 2021 06:32:27 -0500 > > EZ> The amount of sqlite stuff in lisp.h is quite small... So I tend > EZ> to think a separate header is overkill. > > Thinking about this in terms of number of bytes added to lisp.h is the > wrong way to think about it. If that's the only aspect, perhaps. But it isn't the only aspect: there are others, which I mentioned, and you elided. Together with them, the size is relevant to decide between the alternatives. > I agree that Lisp_Process, while important, doesn't belong in lisp.h. > That something as ancillary, third-party, and controversial as > Lisp_Sqlite does get into lisp.h is a testimony about its author. We are not dogmatic about this stuff. This is C, not C++, so what goes into what header is not subject to dogma. And this isn't the case that just files dealing with sqlite will include this header: every source file that deals with Lisp objects will need it, so at least conceptually it belongs to lisp.h. Triggering unnecessary rebuilds is an annoyance during development, so it's no less important than purity of the headers. From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 12:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch wontfix To: Lars Ingebrigtsen Cc: 52440@debbugs.gnu.org, dick.r.chiang@gmail.com Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163931071032560 (code B ref 52440); Sun, 12 Dec 2021 12:06:01 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 12:05:10 +0000 Received: from localhost ([127.0.0.1]:50822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNbK-0008T6-79 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 07:05:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNbH-0008Sk-Ls for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 07:05:08 -0500 Received: from [2001:470:142:3::e] (port=57930 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNbC-00052V-Gs; Sun, 12 Dec 2021 07:05:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LmvMWhL+lWXMBDWJUlzdOoJqB85umrehrn3bc5r4YnY=; b=HaeYYHqa1Dbg i31O1RQHmPpCc7VGQSP+q53bpLpSKxeQD31/+ml5rLHy9Gw4M5sSvTx1yzYpKDRTE0tkB5k5Qv+I5 jHANGZ3jdYovDjE4yWFinTjxMzGj3PDM6YjkWGyM/UOqVPxNRzTYKvzOeuqZBH9EKMmB2fec/f1Xa fxbQw3n+fmllOL2+Adk5zGfC/Y/UXTgal5Q8sPzccb8GzwgfuJ/ap3rYKwyVRVFJyXJYXpNhot1Zx v4BdftFxCCIgNxArRs7rgrK1juun+a1XcwY/9lN8ALl/n9sD2uzXhhOY5IHcP+CpEGl/GqQyZ1D6X XSM04lWL4cay2Sie809PFg==; Received: from [87.69.77.57] (port=2622 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNbA-0006Fh-BJ; Sun, 12 Dec 2021 07:05:01 -0500 Date: Sun, 12 Dec 2021 14:04:52 +0200 Message-Id: <83v8zuni57.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <8735my11rd.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 12 Dec 2021 12:49:42 +0100) References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> <8735my11rd.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: dick.r.chiang@gmail.com, 52440@debbugs.gnu.org > Date: Sun, 12 Dec 2021 12:49:42 +0100 > > (But if you do decide to rearrange this (and put it in a separate .h > file), I won't protest -- I didn't really give the organisation much > thought at all.) Time will tell. For now it's just one struct and a small number of inline functions, not very different from, say, Lisp_Float. From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: dick Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 12:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch wontfix To: Eli Zaretskii Cc: 52440@debbugs.gnu.org, larsi@gnus.org Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163931319812385 (code B ref 52440); Sun, 12 Dec 2021 12:47:01 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 12:46:38 +0000 Received: from localhost ([127.0.0.1]:50858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwOFR-0003Dh-Mt for submit@debbugs.gnu.org; Sun, 12 Dec 2021 07:46:37 -0500 Received: from mail-qv1-f49.google.com ([209.85.219.49]:35649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwOFO-0003DT-UQ for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 07:46:35 -0500 Received: by mail-qv1-f49.google.com with SMTP id g9so12195403qvd.2 for <52440@debbugs.gnu.org>; Sun, 12 Dec 2021 04:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=glGybhe/O1P3Gw1njNCJBQ/HZFyuuI7QbhqE0VOuSgM=; b=Z1rt0goPEbxORvX4tvjOChogiEp7TCvrwz1NM90xbZRcPU/aeA3DS/g+e3ABwTO0jf HOpy/phP81HTcyGIdUHbt2ZGuAySQycj0PGlTDcSJMov6zes9PJ7zzSaVaay+e20D1rG JVohfoK7xYWw3CIHCcDb2HSundXvLQRbIWKZw0OSIBq+DzzA/92mzkh2QmdGoHd2FN/L Waim0+LGZMwETagD2Oo07rDPMd+JjW4N2DXYBcf745Rf9Gxiwvu4bsN/QBI2GWw2cbh6 I0/J09BZmq7jyqT5GjUBcrznr0HC7MA0DR+LhHppeNNTi9fKLkJN1eHCEaBuptQ/ZDPc ze9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=glGybhe/O1P3Gw1njNCJBQ/HZFyuuI7QbhqE0VOuSgM=; b=AvWZ1uue0CSTWnkyhRc2freb42awfBdDOcxx5O6YV6iFw3YfzGZmLZPhaLj8LQgxor EZF89JJnfdGqvsKDDBwGVIvucdmnh5QQ6ETzxLNGhQ7SaNo/jFjjdN/61O6BmEyoXBMk Lx/rk1tWktEoh3DsjCSc2TCXYAjtIDIDdJFBc+knwC5aWddmyuphSHEGio8wF9NXTwd8 cEo2NVBx8CzILUHEdzScXlEPgHPG8SCHMQmSVw2pn7yUI/DtB/NjlVWoDE0mTABcnbvd pHSxY2oJs2xtocId1GSCDDv55DH3zDxbz+Nyi5H0tU3kYO/Yi/lI2eN+wXNwMEO8vDDP IirQ== X-Gm-Message-State: AOAM532wouXoLVqgGWfJS/1XtxEW7BX6zfdSIBpQAP4D08qX9NE2Aqbj rN9KyLSDRvchVFMSmxIz6jM= X-Google-Smtp-Source: ABdhPJz4Ep13Ft5TOw3eUGWRXzT7xP/UGhJ0NkkSBoZIweMTH3j9ijSVCIhnBalTnwey4Ot8wdaPhA== X-Received: by 2002:ad4:4d05:: with SMTP id l5mr37303191qvl.54.1639313189422; Sun, 12 Dec 2021 04:46:29 -0800 (PST) Received: from localhost ([68.237.93.126]) by smtp.gmail.com with ESMTPSA id t6sm4590672qkj.33.2021.12.12.04.46.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Dec 2021 04:46:29 -0800 (PST) From: dick References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> <87lf0q6otw.fsf@dick> <83wnkanib0.fsf@gnu.org> Date: Sun, 12 Dec 2021 07:46:28 -0500 In-Reply-To: <83wnkanib0.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Dec 2021 14:01:23 +0200") Message-ID: <87h7be6lej.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Triggering unnecessary rebuilds is an annoyance during development I don't see how keeping the three functions in lisp.h versus sqlite.h makes triggering the world any less frequent. And besides, I find myself *constantly* having to `git clean -dfX` and remake the world on account of: Error: Recursive load: "...international/uni-special-lowercase.el" Your marshalling of the recompilation nuisance is formulaic straw-grasping to get one's way. I know because I often use the same rhetorical device. From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 13:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch wontfix To: dick Cc: 52440@debbugs.gnu.org, larsi@gnus.org Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163931570916407 (code B ref 52440); Sun, 12 Dec 2021 13:29:02 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 13:28:29 +0000 Received: from localhost ([127.0.0.1]:50941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwOtx-0004GY-2D for submit@debbugs.gnu.org; Sun, 12 Dec 2021 08:28:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwOtv-0004GM-MD for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 08:28:28 -0500 Received: from [2001:470:142:3::e] (port=59776 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwOtq-0004fn-Cw; Sun, 12 Dec 2021 08:28:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tAm1y4tn07zsd1C6Kc9glo+LNYjl1fouXPLyQENoRSk=; b=SdCff9luiGbh LFedcgYoxIM39J8TgvOwjXCJQW2lt6wQJUz/0wmmvHTcFjovWbved0yRJhFLFbDGHG8sn1xJwKSjn bXWljERvYFLCV5OaTT6POwD5lKps1qSMtyEnUmSL35nmw8NZ4lCsqg6ryTSsFrdXsZqiCF9tfeguu vCXfpZWMcIspQL9Sn06UEuAwFWOOjvwKlydp83ePKlfc/hh69P5QwASWBOiDY/PB/KdYLRMEn3uRG zGKOYHht774mZXDVfD7Y5pmSgm/WJHQ40sUW4qoxTrGHtO4QvufhiA/paPzF0+bPmgLhztA9nvtks FI4FV79F5aN2wzOvbtPmXg==; Received: from [87.69.77.57] (port=3946 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwOto-0002jS-Ha; Sun, 12 Dec 2021 08:28:20 -0500 Date: Sun, 12 Dec 2021 15:28:12 +0200 Message-Id: <83pmq2neab.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87h7be6lej.fsf@dick> (message from dick on Sun, 12 Dec 2021 07:46:28 -0500) References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> <87lf0q6otw.fsf@dick> <83wnkanib0.fsf@gnu.org> <87h7be6lej.fsf@dick> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: dick > Cc: larsi@gnus.org, 52440@debbugs.gnu.org > Date: Sun, 12 Dec 2021 07:46:28 -0500 > > > Triggering unnecessary rebuilds is an annoyance during development > > I don't see how keeping the three functions in lisp.h versus sqlite.h > makes triggering the world any less frequent. It's the other way around: separating them will NOT make rebuilds less frequent. So it's kinda fruitless, as separations go. > And besides, I find myself *constantly* having to `git clean -dfX` and > remake the world on account of: > > Error: Recursive load: "...international/uni-special-lowercase.el" Doesn't happen here, never did. > Your marshalling of the recompilation nuisance is formulaic > straw-grasping to get one's way. I know because I often use the same > rhetorical device. You are evidently talking about yourself, so don't expect me to assign any significance to that. Doesn't help your prestige around here, which is already pretty low. From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: dick Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch wontfix To: Eli Zaretskii Cc: 52440@debbugs.gnu.org, larsi@gnus.org Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163931912121752 (code B ref 52440); Sun, 12 Dec 2021 14:26:01 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 14:25:21 +0000 Received: from localhost ([127.0.0.1]:50986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwPmz-0005el-9W for submit@debbugs.gnu.org; Sun, 12 Dec 2021 09:25:21 -0500 Received: from mail-qv1-f47.google.com ([209.85.219.47]:39850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwPmx-0005eY-Uv for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 09:25:20 -0500 Received: by mail-qv1-f47.google.com with SMTP id gu12so12310908qvb.6 for <52440@debbugs.gnu.org>; Sun, 12 Dec 2021 06:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uLGpnExQokjTjK6B67eITJvtaDxQ6LJh5HH4pLL+ov4=; b=XeNAFoOw9hqfraOQtuFo4XU9DLxcUdJPs3pSRoTRE7JXfZFRItJXZKsWdC7eG1j0/p dq0CHZQMJy2+77sMWVbwKpYmJhBOVrivW2q9g+r7zRCI+qz/Y+veYVdGen84a4ZK+QpI +gLFOVGkYYBmeRSOZXLMQqwubPSwrHPmG17jn4WRKDoDS9sp6VESlyhrAn1s91laHTs6 cWkfyTdx4Wu6nt28ggHMGsrZLqyHmSqsQQZCxxnvI5ahC4a6LkBoo4l0PuWiEzpx22VP sIvkZaVueo1mkNiuhiufdgbRsXpmMRGgw7Yp30lkkm8IFZ4MX3pR9XP9tNH60Lj+CGNV R9ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uLGpnExQokjTjK6B67eITJvtaDxQ6LJh5HH4pLL+ov4=; b=WZrNFWIvScsCX+cO7fX7rn8qPhECzv59CLdcSmnTe+Z7H1QqhmCgit6C/6K4Sy0Sf8 07Zcqq13VBwzhRx8a7ixbZkGO6I6vs1YdxNWxRaTW8Sz1hNj+U3bwF4iq6ijx0FRaQ41 q1LAGWSqDsRLWTPMtdPjv/IJqkhw5oIwsxX/aVhnk27MrOJY1AzWxC8oHO4bVFapJh6u B35uwjLpZpwztk1vsAmcTuktOIOAoEkk1JfC00fpznfbFjUQ/bSak6pHIjb52CWUUixn XlVyqU+23Np3VSqL+D2BNzHdL8GoVWIj9tzSoxW4tMIbeA7OY6y2CsorbsN6l33qxG3W obyQ== X-Gm-Message-State: AOAM530sr9HZm02RuVlfFiNueW62NsIHnscnIkjfuxpBoK3L8eBzLBGN NLwiLrO2zWHaudLiUXGMBeoO5lGGbSM= X-Google-Smtp-Source: ABdhPJwhcAEaR9ydJvb8n1ClGbDRYNmI3jM8jpYQ/wyWlWeqkZEPPAbbgPEAEgqOYpsvRCaklWuX2A== X-Received: by 2002:a05:6214:1c06:: with SMTP id u6mr36737577qvc.35.1639319114435; Sun, 12 Dec 2021 06:25:14 -0800 (PST) Received: from localhost ([68.237.93.126]) by smtp.gmail.com with ESMTPSA id s2sm7045090qtw.22.2021.12.12.06.25.13 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Dec 2021 06:25:14 -0800 (PST) From: dick References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> <87lf0q6otw.fsf@dick> <83wnkanib0.fsf@gnu.org> <87h7be6lej.fsf@dick> <83pmq2neab.fsf@gnu.org> Date: Sun, 12 Dec 2021 09:25:13 -0500 In-Reply-To: <83pmq2neab.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Dec 2021 15:28:12 +0200") Message-ID: <87tufd529i.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > It's the other way around: separating them will NOT make rebuilds less > frequent. So it's kinda fruitless, as separations go. Interesting. I just edited sqlite.h in my fork, and it didn't recompile the world. So thanks for suggesting another reason why disaggregating the sqlite junk from lisp.h is superior. Why thread.h is included in lisp.h is a decision that predates me. > Doesn't help your prestige around here, which is already pretty low. Prestige? The path we've chosen -- slavishly obsessing over a last-century text editor fast becoming extinct -- is quite possibly the least prestigious endeavor I can think of. Affability is probably the word you're looking for. From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 14:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch wontfix To: dick Cc: 52440@debbugs.gnu.org, larsi@gnus.org Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163931994122960 (code B ref 52440); Sun, 12 Dec 2021 14:40:01 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 14:39:01 +0000 Received: from localhost ([127.0.0.1]:51009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwQ0D-0005yD-Ag for submit@debbugs.gnu.org; Sun, 12 Dec 2021 09:39:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwQ0A-0005xv-RD for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 09:38:59 -0500 Received: from [2001:470:142:3::e] (port=60916 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwQ05-0007Sm-EE; Sun, 12 Dec 2021 09:38:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dwzStryoo0fiUmAPNGCt8yh+xYnRuzov9RIgZP/nbcY=; b=Aoo2GJxSj433 ndEaktSP+YUyTpWKDORTN/fKymvdK720xaVDJjkYV3Qv0sFNv18ahDpKZ2sAf76MrwjHBtC4qfKZq S7PUJ5HVHwYZfry1KAOGTHmZvqN+nuF1+QHslb61a1v2n35SWE3ACLyTa6FYTmA2kCjyM90I7jtrR mJHVNrvwb6va6jLsCxQsKokfqjaNgqtqq0ZDMBS/uWGaZWsW3JmR06LElTbYC/MUlpyacWVvGztE1 O7ckpdFIY9Us4mIhnsrE9Piq05mZDEWm8vOkqrM888HauuTQWCILzMf/4crn/sLQQiHD0zWForSgC SqecfsgxTEwjGI4GqIkTsg==; Received: from [87.69.77.57] (port=4343 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwQ05-0006l3-8w; Sun, 12 Dec 2021 09:38:53 -0500 Date: Sun, 12 Dec 2021 16:38:46 +0200 Message-Id: <83fsqxopl5.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87tufd529i.fsf@dick> (message from dick on Sun, 12 Dec 2021 09:25:13 -0500) References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> <87lf0q6otw.fsf@dick> <83wnkanib0.fsf@gnu.org> <87h7be6lej.fsf@dick> <83pmq2neab.fsf@gnu.org> <87tufd529i.fsf@dick> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: dick > Cc: larsi@gnus.org, 52440@debbugs.gnu.org > Date: Sun, 12 Dec 2021 09:25:13 -0500 > > > It's the other way around: separating them will NOT make rebuilds less > > frequent. So it's kinda fruitless, as separations go. > > Interesting. I just edited sqlite.h in my fork, and it didn't recompile > the world. I guess sqlite.h in your fork includes only some of the sqlite stuff, then. Which then begs the question why have it in more than one place? Or maybe your sqlite.h includes lisp.h, which is also not a very good idea. You cannot usefully separate into different files parts of the Lisp interpreter, they are too intertwined. Might as well stop trying. Anyway, this seems to be about personal stylistic preferences, so any further argument is futile. From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: dick Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch wontfix To: Eli Zaretskii Cc: 52440@debbugs.gnu.org Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163932148727239 (code B ref 52440); Sun, 12 Dec 2021 15:05:01 +0000 Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 15:04:47 +0000 Received: from localhost ([127.0.0.1]:52889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwQP9-00075H-ND for submit@debbugs.gnu.org; Sun, 12 Dec 2021 10:04:47 -0500 Received: from mail-qk1-f182.google.com ([209.85.222.182]:36654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwQP8-000751-43 for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 10:04:47 -0500 Received: by mail-qk1-f182.google.com with SMTP id d21so4713998qkl.3 for <52440@debbugs.gnu.org>; Sun, 12 Dec 2021 07:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FClMBM2znEJ6Hss5l/PgpM6hfj4t1XTfU2pXpb3w9PY=; b=iDQUGoqS5hcJQqRe96T3OHIqJpFPXDT/Nz/ryZVCej16RsI5g8AB0y17Z/OC52KeWY oXr3S2h8aVVP8n/JxqHd3RX/px7n18dsXhur8VbugPzgAmQ4g7hUVYw7+6Tqw6Ll5RB9 0lCM7Tv79TWKCAKmDg4CUcQFfvUrW5SeIT6HXORyWO115xbd25twbFowGqZOvtsDt9Vt jUbV6LM6YELjzbrXahjLEUiGSDZKAiR3jhrlcztm3ejaJqRtU0oEIGQzn43cuuj0hBJT w0I+aENWyonT+hmEDJsovaB+llToELEJngrv4Xflr+ByTOAc6c0g65PXFI4FFvEFHMPm ltJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FClMBM2znEJ6Hss5l/PgpM6hfj4t1XTfU2pXpb3w9PY=; b=iF4NfuhyrKavKGpaZnk8NKdx+kGKLNR1W2bfrbFxJCYr+D5Eu+irkWAuBkHj4cOR+D FMlIq45N375sWN2nBINGt5NNUUHxgzUrPmjirw+bJIVyPAcgO7o7cmD8/TBrSykPMlWm BaFB0GE9QqW59ueO17wvB7Vy32E9eK0cpi8N6LzBk7rO765vzCYneM5eBbK9xEFXq6d1 BJPEua2BngumPZGnqF0xbV4f+ldEgcCNoi6Q1CROOVAxf4FBKD3Q+jn72OM8y39KAEhH Tp6GnrrCEOdooGpMF/4H9h3V3d6aP8h9hEw2rp4O126A8nZgkQ3kRAzGwZl2Aqc9KOYX J0+Q== X-Gm-Message-State: AOAM532xEq6Lpblzj3f8qzsmhQnVqCBwmW/6ei2qVKnM8sE1T3wMElZ4 ALcodV0/aRLx7860Pd7lG2U= X-Google-Smtp-Source: ABdhPJwUE+gzN9gdCXZDM4Qr53gl+G1KoEQHueylJU5k9Dlg0WUM8BSo4Ru5mXSSBuUq7nRCIxIGWw== X-Received: by 2002:a05:620a:2943:: with SMTP id n3mr28640851qkp.650.1639321480624; Sun, 12 Dec 2021 07:04:40 -0800 (PST) Received: from localhost ([68.237.93.126]) by smtp.gmail.com with ESMTPSA id h16sm7165044qtx.20.2021.12.12.07.04.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Dec 2021 07:04:40 -0800 (PST) From: dick References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> <87lf0q6otw.fsf@dick> <83wnkanib0.fsf@gnu.org> <87h7be6lej.fsf@dick> <83pmq2neab.fsf@gnu.org> <87tufd529i.fsf@dick> <83fsqxopl5.fsf@gnu.org> Date: Sun, 12 Dec 2021 10:04:39 -0500 In-Reply-To: <83fsqxopl5.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Dec 2021 16:38:46 +0200") Message-ID: <87pmq150fs.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > You cannot usefully separate into different files parts of the Lisp > interpreter, they are too intertwined. Might as well stop trying. Pretty egregious straw-grasping here. > Anyway, this seems to be about personal stylistic preferences, so any > further argument is futile. No, it's C programming 101. You'll get the hang of it. I was an even worse programmer than you when I graduated university. By the time you get to my age and experience, you'll be the Vader to my Kenobi. Not that I fancy myself a jedi in programming, far from it. But you get the idea. From unknown Fri Sep 05 18:47:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Dec 2021 01:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch wontfix To: dick Cc: 52440@debbugs.gnu.org, Eli Zaretskii Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.16393605338131 (code B ref 52440); Mon, 13 Dec 2021 01:56:01 +0000 Received: (at 52440) by debbugs.gnu.org; 13 Dec 2021 01:55:33 +0000 Received: from localhost ([127.0.0.1]:53498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwaYv-000275-Hm for submit@debbugs.gnu.org; Sun, 12 Dec 2021 20:55:33 -0500 Received: from smtp-1.orcon.net.nz ([60.234.4.34]:34633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwaYu-00026x-Cy for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 20:55:32 -0500 Received: from [10.253.37.70] (port=36638 helo=webmail.orcon.net.nz) by smtp-1.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1mwaYq-00007q-4q; Mon, 13 Dec 2021 14:55:28 +1300 Received: from ip-14-137-22-223.kinect.net.nz ([14.137.22.223]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Mon, 13 Dec 2021 14:55:28 +1300 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 13 Dec 2021 14:55:28 +1300 From: Phil Sainty In-Reply-To: <87pmq150fs.fsf@dick> References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> <87lf0q6otw.fsf@dick> <83wnkanib0.fsf@gnu.org> <87h7be6lej.fsf@dick> <83pmq2neab.fsf@gnu.org> <87tufd529i.fsf@dick> <83fsqxopl5.fsf@gnu.org> <87pmq150fs.fsf@dick> Message-ID: <025f2ba32d443fdb75cc122ee1e85a4e@webmail.orcon.net.nz> X-Sender: psainty@orcon.net.nz User-Agent: Orcon Webmail X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2021-12-13 04:04, dick wrote: > No, it's C programming 101. You'll get the hang of it. I was an even > worse programmer than you when I graduated university. By the time you > get to my age and experience, you'll be the Vader to my Kenobi. In my personal opinion... This is not (ever) the way to collaborate on a project. In the years I've been subscribed to these lists I can't recall anyone remotely as obnoxious as you choose to be on a regular basis. My *impression* is that you could be a valuable contributor (and you even seem to be working on some things which I personally would like to see in Emacs); but if this was my project you would not be welcome with the attitude that I've seen from you thus far, regardless of your skills as a programmer. -Phil