From unknown Wed Jun 18 23:17:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52438 <52438@debbugs.gnu.org> To: bug#52438 <52438@debbugs.gnu.org> Subject: Status: 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support Reply-To: bug#52438 <52438@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:17:05 +0000 retitle 52438 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support reassign 52438 emacs submitter 52438 David Fussner severity 52438 normal tag 52438 patch moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 11 13:57:31 2021 Received: (at submit) by debbugs.gnu.org; 11 Dec 2021 18:57:31 +0000 Received: from localhost ([127.0.0.1]:49993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw7Yp-00078d-4s for submit@debbugs.gnu.org; Sat, 11 Dec 2021 13:57:31 -0500 Received: from lists.gnu.org ([209.51.188.17]:53070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw7Yn-00078V-1w for submit@debbugs.gnu.org; Sat, 11 Dec 2021 13:57:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mw7Ym-0003Tn-QS for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 13:57:28 -0500 Received: from [2607:f8b0:4864:20::733] (port=34323 helo=mail-qk1-x733.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mw7Yl-0001Gb-0R for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 13:57:28 -0500 Received: by mail-qk1-x733.google.com with SMTP id t6so10776965qkg.1 for ; Sat, 11 Dec 2021 10:57:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=Sjq2izSkovJF/gYw3ywdmDGhZWHtR/6tEttPScd7wKQ=; b=aGFoGrKSpBV5fpjNr1i2SJOjrPAsuaSxDzmFOd/HmzYOPM7U7vQr40oYRsk6M8s3Zm FXII6KNGN0sI8k/nQGpcf+zGvyNgyAsQrnddA9QPG+Nb7wxdrRFW/OFgIjiqDENYACSb jvirsxhRP4hxWuTibVwWXReACvVjmJK+jL8dEVxrZ/B82MBLOaDuO3YKLKk4jaTQ9/cx ubXdH76I3TwPkn5LwTiqJ6okEA8rQ3I3w9CZ+MZbPVce9EckyjtwQhA45j5QxkRstBS+ Ari+TaZiva0b6OGVgoCV1VTxbkw+8VRBAAcU64QdwonJcnt9zHjw+JdsChGXSACkwrfD efqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Sjq2izSkovJF/gYw3ywdmDGhZWHtR/6tEttPScd7wKQ=; b=QEiwBsuofBNaMm5G57uDQF15PIhpqQUOCUJMnmHnu5kw7tTnc6qyZiDcD3RRisSaSp RrrMU06IbEVVARMsIvDDjf2UuMkDNtsIvjsvjk/Xem2f7b9sNvnbNupndAqjafF9Hnvt xOaQHo7op2V+b+/kq7J6erormwFbaj3Q5gmySn+Lkua13z2UY3aI0BxB3PfsBIpAglXf bDMajo73c7/cWjgGcdgD2iRUt6yJh8BliKtsJi5MaSeTL7heuWW1wlM0eFepg0w/TlrN VABeflIQWvxRvnl/rqQ6Aq2jGRU1PDo3HzRFcB3vjjgbXpAbLY0gPQgUeqBe1beC3ZKM 9Oig== X-Gm-Message-State: AOAM533h2iHfeh0OgFiF3ePUcMtJSFaslgx/YzslqdF+wZ6JK5uK1ivd pCzwRq6jdSFl9OJ0Q/DtjiCf2k2Iej8oTKh3PHDkdzyyw8XcpA== X-Google-Smtp-Source: ABdhPJz674cu95ecHB3luq+JWGOyBksXaa3cGFC8Z2ewFvrk7vNWuHGGiarxRfW3QfNRXZP11KAWGE1jTvZEzjdv2Bo= X-Received: by 2002:a05:622a:1483:: with SMTP id t3mr35126115qtx.518.1639248652508; Sat, 11 Dec 2021 10:50:52 -0800 (PST) MIME-Version: 1.0 From: David Fussner Date: Sat, 11 Dec 2021 18:50:24 +0000 Message-ID: Subject: 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000a213aa05d2e35139" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::733 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::733; envelope-from=dfussner@googlemail.com; helo=mail-qk1-x733.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000a213aa05d2e35139 Content-Type: text/plain; charset="UTF-8" The etags program reliably crashes for me when running the test suite in test/manual/etags, but you need to have a long-enough TEXTAGS environment variable to make it happen. On my 32-bit GNU/Linux machine, going to that directory and running: TEXTAGS="A:B:C:D:E:F:G:H:I:J:K:L:M:N:O:P:Q:R:S:T:U:V:W:X" make check crashes the program before it finishes the first run, that is, before it stops because the test suite itself fails. Removing one member of TEXTAGS allows it to complete, whereupon the test suite (correctly) fails in the normal way. Adding members gives me different crash messages. (The crash may well be machine and compiler dependent, so if it fails to crash then adding things to TEXTAGS may work.) Whether the program completes or no, and so long as you have something in TEXTAGS, running etags under valgrind always gives the following messages: ==14977== Invalid write of size 4 ==14977== at 0x804EF32: TEX_decode_env (etags.c:5808) ==14977== Invalid write of size 4 ==14977== at 0x804EF39: TEX_decode_env (etags.c:5809) Lines 5808-9 add NULL to end TEX_toktab, and the latter therefore needs to have one more slot allotted than there are actual members of the string made from the default defenv (defined in etags.c) and the TEXTAGS environment variable. When allocating storage, the code counts colons, and since the default defenv begins with a colon, it always gets the extra slot by default when there is no TEXTAGS environment variable (and those messages no longer appear under valgrind). Define a TEXTAGS variable, which according to the documentation doesn't start with a colon, and there will be one slot too few. The patch tests for whether the final concatenated string starts with a colon or not, and increments the starting value of len in TEX_toktab if it doesn't. (Apologies for the long report -- I was sort of assuming that this might be difficult to reproduce.) Thanks, David. In GNU Emacs 29.0.50 (build 3, i686-pc-linux-gnu, GTK+ Version 3.18.9, cairo version 1.14.6) of 2021-12-11 built on newfont Repository revision: 8c50016b100ec2c548ec90131e0f5fb5f4ebb5c1 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11803000 System Description: Slackware 14.2 Configured using: 'configure PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_COLLATE: C value of $LANG: en_US.ISO8859-1 locale-coding-system: iso-latin-1-unix Major mode: C/*l Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t auto-revert-mode: t shell-dirtrack-mode: t bug-reference-prog-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t abbrev-mode: t Load-path shadows: /home/dfussner/.emacs.d/elpa/transient-20210426.2141/transient hides /home/dfussner/src/emacs/emacs/lisp/transient Features: (shadow sort mail-extr emacsbug sendmail magit-extras face-remap magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff git-commit rx log-edit message yank-media rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor magit-mode transient cl-extra help-mode format-spec magit-git magit-section magit-utils crm dash misearch multi-isearch shell pcomplete compile text-property-search comint ansi-color ring vc-git diff-mode easy-mmode vc vc-dispatcher bug-reference cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs doom-opera-theme doom-themes doom-themes-base time-date server preview-latex auto-loads tex-site finder-inf info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 373679 54043) (symbols 24 21995 1) (strings 16 103078 4463) (string-bytes 1 2950986) (vectors 8 45064) (vector-slots 4 1306902 95228) (floats 8 245 822) (intervals 28 7124 442) (buffers 564 20) (heap 1024 33446 1163)) --000000000000a213aa05d2e35139 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-off-by-one-error-in-etags.c-TeX-support.patch" Content-Disposition: attachment; filename="0001-Fix-off-by-one-error-in-etags.c-TeX-support.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kx2677wy0 RnJvbSBmYzNhMjA3MDc0NjY2NjUwZmVlNzUyMzU5YmE4N2M5NmExN2Y5NmI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBGdXNzbmVyIDxkZnVzc25lckBnb29nbGVtYWlsLmNv bT4KRGF0ZTogU2F0LCAxMSBEZWMgMjAyMSAxNzo0NzozOCArMDAwMApTdWJqZWN0OiBbUEFUQ0hd IEZpeCBvZmYtYnktb25lIGVycm9yIGluIGV0YWdzLmMgVGVYIHN1cHBvcnQKCiogbGliLXNyYy9l dGFncy5jIChURVhfZGVjb2RlX2Vudik6IEZpeCBvZmYtYnktb25lIGVycm9yLgotLS0KIGxpYi1z cmMvZXRhZ3MuYyB8IDcgKysrKysrLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpYi1zcmMvZXRhZ3MuYyBiL2xpYi1zcmMvZXRh Z3MuYwppbmRleCBiZDRkNGZjZjUzLi4zN2I0Y2RhODAxIDEwMDY0NAotLS0gYS9saWItc3JjL2V0 YWdzLmMKKysrIGIvbGliLXNyYy9ldGFncy5jCkBAIC01NzczLDYgKzU3NzMsNyBAQCBUZVhfY29t bWFuZHMgKEZJTEUgKmluZikKIFRFWF9kZWNvZGVfZW52IChjb25zdCBjaGFyICpldmFybmFtZSwg Y29uc3QgY2hhciAqZGVmZW52KQogewogICBjb25zdCBjaGFyICplbnYsICpwOworICBjaGFyIHEg PSAxOwogICBwdHJkaWZmX3QgbGVuOwogCiAgIC8qIEFwcGVuZCBkZWZhdWx0IHN0cmluZyB0byBl bnZpcm9ubWVudC4gKi8KQEAgLTU3ODIsOCArNTc4MywxMiBAQCBURVhfZGVjb2RlX2VudiAoY29u c3QgY2hhciAqZXZhcm5hbWUsIGNvbnN0IGNoYXIgKmRlZmVudikKICAgZWxzZQogICAgIGVudiA9 IGNvbmNhdCAoZW52LCBkZWZlbnYsICIiKTsKIAorICAvKiBGaXggb2ZmLWJ5LW9uZSBlcnJvci4g Ki8KKyAgaWYgKCFzdHJuZXEgKGVudiwgIjoiLCAxKSkKKyAgICBxKys7CisKICAgLyogQWxsb2Nh dGUgYSB0b2tlbiB0YWJsZSAqLwotICBmb3IgKGxlbiA9IDEsIHAgPSBlbnY7IChwID0gc3RyY2hy IChwLCAnOicpKTsgKQorICBmb3IgKGxlbiA9IHEsIHAgPSBlbnY7IChwID0gc3RyY2hyIChwLCAn OicpKTsgKQogICAgIGlmICgqKytwKQogICAgICAgbGVuKys7CiAgIFRFWF90b2t0YWIgPSB4bmV3 IChsZW4sIGxpbmVidWZmZXIpOwotLSAKMi4xNy42Cgo= --000000000000a213aa05d2e35139-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 00:42:00 2021 Received: (at 52438) by debbugs.gnu.org; 12 Dec 2021 05:42:00 +0000 Received: from localhost ([127.0.0.1]:50468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwHcV-00084G-O3 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 00:41:59 -0500 Received: from quimby.gnus.org ([95.216.78.240]:44962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwHcT-00083z-HN for 52438@debbugs.gnu.org; Sun, 12 Dec 2021 00:41:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FZ/H3D0UaSBbP8XTP6ZKAzSKVAgjWjDHcv4zq48QSMw=; b=PH/ce1pikud7cCncHOGAHjf1yS QaTa3UHdv05ETfqThhxbg7gAWoBI/BZ5vanjA36EaT7ViPXX1Ay+F4ULDV0uSDjH6ZCWwXiiz7Viy G3pY+YBGVVsQTOlIFQsRoHgtkMpkU4Qb7ylnfKKhBSUMQWC+r1jBcJmH8kNAASOO6WiY=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwHcJ-0002IZ-GI; Sun, 12 Dec 2021 06:41:51 +0100 From: Lars Ingebrigtsen To: David Fussner Subject: Re: bug#52438: 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support References: X-Now-Playing: The Lounge Lizards's _No Pain for Cakes_: "My Clown's On Fire" Date: Sun, 12 Dec 2021 06:41:43 +0100 In-Reply-To: (David Fussner's message of "Sat, 11 Dec 2021 18:50:24 +0000") Message-ID: <87lf0qfkh4.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: David Fussner writes: > The etags program reliably crashes for me when running the test suite in > test/manual/etags, but you need to have a long-enough TEXTAGS > environment variable to make it happen. On my 32-bit GNU/Li [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52438 Cc: 52438@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) David Fussner writes: > The etags program reliably crashes for me when running the test suite in > test/manual/etags, but you need to have a long-enough TEXTAGS > environment variable to make it happen. On my 32-bit GNU/Linux machine, > going to that directory and running: > > TEXTAGS="A:B:C:D:E:F:G:H:I:J:K:L:M:N:O:P:Q:R:S:T:U:V:W:X" make check > > crashes the program before it finishes the first run, that is, before it > stops because the test suite itself fails. I'm not able to reproduce the issue on my 64-bit Debian system, but reading the code, I think your analysis of the problem sounds correct. The patch seemed slightly confusing, though, so I rewrote it a bit. Could you check whether this version also fixes the problem? diff --git a/lib-src/etags.c b/lib-src/etags.c index bd4d4fcf53..ba66eeede4 100644 --- a/lib-src/etags.c +++ b/lib-src/etags.c @@ -5773,7 +5773,7 @@ TeX_commands (FILE *inf) TEX_decode_env (const char *evarname, const char *defenv) { const char *env, *p; - ptrdiff_t len; + ptrdiff_t len = 1; /* Append default string to environment. */ env = getenv (evarname); @@ -5782,8 +5782,13 @@ TEX_decode_env (const char *evarname, const char *defenv) else env = concat (env, defenv, ""); + /* If the environment variable starts with a colon, increase the + length of the token table. */ + if (!strneq (env, ":", 1)) + len++; + /* Allocate a token table */ - for (len = 1, p = env; (p = strchr (p, ':')); ) + for (p = env; (p = strchr (p, ':')); ) if (*++p) len++; TEX_toktab = xnew (len, linebuffer); -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 00:42:02 2021 Received: (at control) by debbugs.gnu.org; 12 Dec 2021 05:42:02 +0000 Received: from localhost ([127.0.0.1]:50471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwHcY-00084Y-0G for submit@debbugs.gnu.org; Sun, 12 Dec 2021 00:42:02 -0500 Received: from quimby.gnus.org ([95.216.78.240]:44976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwHcX-000846-Dd for control@debbugs.gnu.org; Sun, 12 Dec 2021 00:42:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nu2egm2mP/FXd1FO2eegTshxunIun6sERi59MpFnXKo=; b=djhewQZDj1E+yg7yUlRDqcj3pb EJhPuKWhpnIjqNIZWKStawq9gxh9iK0FuDDJJM4L0uZ81x0RcGZX/tZdJcyHXMytutCuMccsahGNF 8q8SFQv0nD3TmVksyt07As7wLI2I62HQDa1BbIf02xCUOOBLs9tPhvdRUB7g/i7bab9Q=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwHcP-0002Ih-9o for control@debbugs.gnu.org; Sun, 12 Dec 2021 06:41:55 +0100 Date: Sun, 12 Dec 2021 06:41:52 +0100 Message-Id: <87k0gafkgv.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #52438 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 52438 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 52438 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 03:49:05 2021 Received: (at 52438) by debbugs.gnu.org; 12 Dec 2021 08:49:05 +0000 Received: from localhost ([127.0.0.1]:50635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwKXZ-00056q-CE for submit@debbugs.gnu.org; Sun, 12 Dec 2021 03:49:05 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:41409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwKXX-00056i-I6 for 52438@debbugs.gnu.org; Sun, 12 Dec 2021 03:49:04 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JBdbf1W8vz1sBQy; Sun, 12 Dec 2021 09:49:01 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JBdbd6FD9z1qqkB; Sun, 12 Dec 2021 09:49:01 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id v1qkExcW83ph; Sun, 12 Dec 2021 09:49:01 +0100 (CET) X-Auth-Info: cLWGc+WEui9Ud4eHcsk5dNzGokcfW6z+ToZ+l5tL3dXZEWN4VUJteqL0B8vsuKUG Received: from tiger.home (ppp-46-244-189-9.dynamic.mnet-online.de [46.244.189.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 12 Dec 2021 09:49:01 +0100 (CET) Received: by tiger.home (Postfix, from userid 1000) id 744AF83A6B; Sun, 12 Dec 2021 09:49:00 +0100 (CET) From: Andreas Schwab To: Lars Ingebrigtsen Subject: Re: bug#52438: 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support References: <87lf0qfkh4.fsf@gnus.org> X-Yow: Uh-oh -- WHY am I suddenly thinking of a VENERABLE religious leader frolicking on a FORT LAUDERDALE weekend? Date: Sun, 12 Dec 2021 09:49:00 +0100 In-Reply-To: <87lf0qfkh4.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 12 Dec 2021 06:41:43 +0100") Message-ID: <87a6h65htv.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 52438 Cc: 52438@debbugs.gnu.org, David Fussner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) On Dez 12 2021, Lars Ingebrigtsen wrote: > + /* If the environment variable starts with a colon, increase the > + length of the token table. */ > + if (!strneq (env, ":", 1)) That's a pretty roundabout way to write *env == ':'. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 05:23:00 2021 Received: (at 52438) by debbugs.gnu.org; 12 Dec 2021 10:23:00 +0000 Received: from localhost ([127.0.0.1]:50720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwM0S-0007PL-86 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 05:23:00 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:35633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwM0Q-0007P7-Pd for 52438@debbugs.gnu.org; Sun, 12 Dec 2021 05:22:59 -0500 Received: by mail-qt1-f176.google.com with SMTP id j17so12672237qtx.2 for <52438@debbugs.gnu.org>; Sun, 12 Dec 2021 02:22:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B8u2SBXYb96sF+ZlMzYZajv7NeQTMTf6tUeNPLA0/nc=; b=E2c75VJKxIRXRPunvuBu1mvUZ+6TnDrmhedMntt4hx8kk/xJFIpZlECRiaItWOMDCS vAa09NPef1OQGI/oSw8aI1wLkoKYCSmEdoPxxgvBLJzlT8AjUck1fKb6SidUBVh4c18Z 3ISEPKenULOAiahQMVI2XSaX/46gjW3v+l9bNkIoFaaMYki7OHSOuk/6GDOIRKfV5KX5 o67hcwNLlRuU7ZAPgi7lvNywggp+BUrYN+aeObtQLqUrwFUEKB8zxSK23ZsXY9EXUL5M SDFmGBkutMfv/5sGtsW3idBWbhxDuh3RqcJ33ZWxsix7YBx1HVb8x6QKM4PtCob9e6Nz ytpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B8u2SBXYb96sF+ZlMzYZajv7NeQTMTf6tUeNPLA0/nc=; b=ZehekieeLIBNIwGFmDglqVgJUNlgdjntCjX4AfCz5wonZPmHGXHN7YPrLrDGqqQM9s RO54mvIPmxXqDQP6CecVKW1WhZvIKgAjGprGDbzi+ZGuSDtXY3/eOTMG1jVjd2k+qnuv Y6cm+hwHRJanZ7QrZQHvro37j/NOrd9bU2lmjtis8nOwrHdkMU6c0tBptzD9BUeiCjBS wyucNngCkGDSloIVyQpKrOL9jVBivaEJTRdlCiq+CsR9/z78UPOMS0Pu3Mo+T78D+D0n rM07ppHQB1Tf6xDvh5vzNQhqZYXGY9wTLejcfAZmhXZkKEeETkJmuvHzTMNg3SXj36BJ eFJA== X-Gm-Message-State: AOAM531WSEIgPJvl/wGahTjW00IX5WW9cLZyluDctbbot0wN4IRvPtAg WOWHfqoE7EsBfZ7XNv0gcKfD25bpBVYbVO3Rqkg= X-Google-Smtp-Source: ABdhPJxXTojPEl9PuD+/awpxN957AeB4IgIv0ZAHrSvTot30MdrDG34a8hcv75YLVpFVhw+t4bysj2XkzbSX2kJxtAo= X-Received: by 2002:a05:622a:1483:: with SMTP id t3mr38055346qtx.518.1639304573325; Sun, 12 Dec 2021 02:22:53 -0800 (PST) MIME-Version: 1.0 References: <87lf0qfkh4.fsf@gnus.org> In-Reply-To: <87lf0qfkh4.fsf@gnus.org> From: David Fussner Date: Sun, 12 Dec 2021 10:22:25 +0000 Message-ID: Subject: Re: bug#52438: 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52438 Cc: 52438@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Lars, > I'm not able to reproduce the issue on my 64-bit Debian system, but > reading the code, I think your analysis of the problem sounds correct. > The patch seemed slightly confusing, though, so I rewrote it a bit. > Could you check whether this version also fixes the problem? If my code was merely confusing and inelegant rather than flat-out incorrect then that's a triumph :-) > diff --git a/lib-src/etags.c b/lib-src/etags.c > index bd4d4fcf53..ba66eeede4 100644 > --- a/lib-src/etags.c > +++ b/lib-src/etags.c > @@ -5773,7 +5773,7 @@ TeX_commands (FILE *inf) > TEX_decode_env (const char *evarname, const char *defenv) > { > const char *env, *p; > - ptrdiff_t len; > + ptrdiff_t len = 1; > > /* Append default string to environment. */ > env = getenv (evarname); > @@ -5782,8 +5782,13 @@ TEX_decode_env (const char *evarname, const char *defenv) > else > env = concat (env, defenv, ""); > > + /* If the environment variable starts with a colon, increase the > + length of the token table. */ > + if (!strneq (env, ":", 1)) > + len++; > + > /* Allocate a token table */ > - for (len = 1, p = env; (p = strchr (p, ':')); ) > + for (p = env; (p = strchr (p, ':')); ) > if (*++p) > len++; > TEX_toktab = xnew (len, linebuffer); > That fixes the issue here, thank you very much! ( I guess Andreas' comment on my strneq test is well-founded, though?) Please close this bug if/when you apply your fix. David. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 05:27:14 2021 Received: (at 52438) by debbugs.gnu.org; 12 Dec 2021 10:27:14 +0000 Received: from localhost ([127.0.0.1]:50724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwM4X-0007WN-PL for submit@debbugs.gnu.org; Sun, 12 Dec 2021 05:27:14 -0500 Received: from quimby.gnus.org ([95.216.78.240]:47122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwM4U-0007W4-RS for 52438@debbugs.gnu.org; Sun, 12 Dec 2021 05:27:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dY5v7mF8APpwHx5vGZzvTjxcQdMaa7nsG6S9MKUeVG8=; b=IaIYJqiQ4g6aAccmq0iWwjI7oQ iZipnqXykORXdlwMdYWFzWbAkguMe7yTHpmuUqeqC/fsGwnKuK9uREamMZvgWDWM7fCeWCORD508N wkH/6Lug964geMspQWNBF30WahFsK/ySO26Xsw5oKgYK+F17ybFHMPlAFrygKzUiaLH4=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwM4M-0004HV-0s; Sun, 12 Dec 2021 11:27:04 +0100 From: Lars Ingebrigtsen To: David Fussner Subject: Re: bug#52438: 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support References: <87lf0qfkh4.fsf@gnus.org> X-Now-Playing: Leslie Winer's _When I Hit You, You'll Feel It_: "Battle Porn" Date: Sun, 12 Dec 2021 11:26:59 +0100 In-Reply-To: (David Fussner's message of "Sun, 12 Dec 2021 10:22:25 +0000") Message-ID: <87fsqyce4s.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: David Fussner writes: > That fixes the issue here, thank you very much! ( I guess Andreas' > comment on my strneq test is well-founded, though?) > > Please close this bug if/when you apply your fix. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52438 Cc: 52438@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) David Fussner writes: > That fixes the issue here, thank you very much! ( I guess Andreas' > comment on my strneq test is well-founded, though?) > > Please close this bug if/when you apply your fix. Thanks for testing; I've now pushed that version of the patch (with Andreas' change) to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 05:27:19 2021 Received: (at control) by debbugs.gnu.org; 12 Dec 2021 10:27:19 +0000 Received: from localhost ([127.0.0.1]:50727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwM4d-0007We-4h for submit@debbugs.gnu.org; Sun, 12 Dec 2021 05:27:19 -0500 Received: from quimby.gnus.org ([95.216.78.240]:47136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwM4b-0007WL-EX for control@debbugs.gnu.org; Sun, 12 Dec 2021 05:27:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sLI3jteW0o0yjO5iYK3LwPQBtea6uz7t3favcoQ08QA=; b=j5pD0+XmAAy/0020GHFW3sIqfv /Ws5VcLDTK4jGC0GQy0e5Cg5Ym92cNGluggkjbYn+QPg7IPgWIUywSnrdkuIHR1MiAln6rlshrZB/ T9lP+JqxXUR/EgDKqK5z8D4ZU47ZRNDBZnnVOBh7o+QBZ4z5bH+We65bt0QvST9gcsCw=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwM4T-0004Hi-Aw for control@debbugs.gnu.org; Sun, 12 Dec 2021 11:27:11 +0100 Date: Sun, 12 Dec 2021 11:27:08 +0100 Message-Id: <87ee6ice4j.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #52438 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 52438 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 52438 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 05:29:48 2021 Received: (at 52438) by debbugs.gnu.org; 12 Dec 2021 10:29:48 +0000 Received: from localhost ([127.0.0.1]:50734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwM72-0007aW-FX for submit@debbugs.gnu.org; Sun, 12 Dec 2021 05:29:48 -0500 Received: from mail-qk1-f173.google.com ([209.85.222.173]:37567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwM70-0007aI-PB for 52438@debbugs.gnu.org; Sun, 12 Dec 2021 05:29:47 -0500 Received: by mail-qk1-f173.google.com with SMTP id m186so11732883qkb.4 for <52438@debbugs.gnu.org>; Sun, 12 Dec 2021 02:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PzuAodlTl2NGWEvsQR4FxQT6eUoRiMHZwWtg+EHGg1k=; b=TncK56pD8H2/8/Fp5M2Gs1rzbI0PHhaTTVnMRNKpdYFD7qxbUCV8gpa5TpucXyO75i uUaCnIGdJNWQKkMGjRPiUVlYFbe6TRFk+CVPwU6esaBqMkhVonUC6ulJM7ez0re45B0Q tchAHCXAjndLFiYiGzoYnB2B+isLML7sXNunpg5GVcTVMiKZCOkiTy6XeUyq7qJe8SwZ auKutOSA6XCHQube7MTXKDQu4KTEwdZPGcw07MtIPHAI/CfVCaBPc+qix+sF9srbpc0K LhOi5c+YJL3urf1spgXuoLDd/NSFu9PdQKokP2s+n3jloA154vNEoJVPEe20ag8kmF1d RLHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PzuAodlTl2NGWEvsQR4FxQT6eUoRiMHZwWtg+EHGg1k=; b=r+Ov1B94Aq0kRo6eFINxVpgzfm6Somntt6UVxEZYM9xyhZd39uxL90KP5bhqL171GX Kn1kB1Mnd7s+MQ8Qf7BUJWcO2qIaLsI8pH+Fc2o3HNMM5wsXZz9rz4Z9N/NAcnqNk64G ngOp3THPzxRjsUzmT4ubvUepy0+AvR3wKc0jhKby08MdKIfIhZGGd3l1KfGfjGeGxk5b HsNgWbJEmtYav0Jf4GLN1YD5oc1FOYpFvArZYtRs1QtNnmEcZbuPG4bMjnvWKWuxRluC ZDYF5Z0yd7kbnrQ0SJa1pkD5snZpV4Ldu7uS9CnChkAQadGTzyGbpa92Qo4svNp+84l3 I6ww== X-Gm-Message-State: AOAM533vZGdS/vC22Eo8vNekmpN/mq3ZqCpvqpplUhjr/OrMjgC3f/Gi ahSYxlMT1bO2qghA5nJ2NcCFdXPuxam0k/jr7SHu1XKYz40= X-Google-Smtp-Source: ABdhPJzf3nFFQJ0htetnvZdQKKMH8qR/o7HcRjbp5oJHI8j3FBXnhTMx9X/TDq4ThQxN4jzaT0MZHh1z+ih9ZF19khs= X-Received: by 2002:a37:7c8:: with SMTP id 191mr28515747qkh.54.1639304981305; Sun, 12 Dec 2021 02:29:41 -0800 (PST) MIME-Version: 1.0 References: <87lf0qfkh4.fsf@gnus.org> <87fsqyce4s.fsf@gnus.org> In-Reply-To: <87fsqyce4s.fsf@gnus.org> From: David Fussner Date: Sun, 12 Dec 2021 10:29:13 +0000 Message-ID: Subject: Re: bug#52438: 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52438 Cc: 52438@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks again, Lars. > > Thanks for testing; I've now pushed that version of the patch (with > Andreas' change) to Emacs 29. > David. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 05:35:59 2021 Received: (at 52438) by debbugs.gnu.org; 12 Dec 2021 10:35:59 +0000 Received: from localhost ([127.0.0.1]:50743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwMD1-0001Wy-Ec for submit@debbugs.gnu.org; Sun, 12 Dec 2021 05:35:59 -0500 Received: from mail-qk1-f170.google.com ([209.85.222.170]:35490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwMCz-0001Wk-I9 for 52438@debbugs.gnu.org; Sun, 12 Dec 2021 05:35:57 -0500 Received: by mail-qk1-f170.google.com with SMTP id m192so11735834qke.2 for <52438@debbugs.gnu.org>; Sun, 12 Dec 2021 02:35:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/+3Qol1q2h6jCEr9Cgewyj7jxHLPyqgVWLx07GN8+cc=; b=qvsKe553wGYUivm5k4lGvvW/xVKZN7X48lpcrhnD0d28wZTM9dQeEnTGCWGQYHHubb tgnvF8m5/zM4BAFYipfJjXw+vLKHjybRU4Ymw0UKbsiZTrchWJNsjo8XAUjtsvhJf9dD T6Ub/9KJVkbRN6UhU7agOqxBss2OOYQepHQFNRinxra9uMea9VTUZ+71kZYOjQlpW5pZ lgnliElPLKsODy1gDVG3alNHxSJYPfRIRWGhQdokWJFE6EyKyh9tX9aFhcCT244yGwBo gGd4//99JuFKGTGeLO5lTDnJjivRm35Wa5B3O0yhftegysJ8MWfKPp6WaJLDGUlIQtAM JQ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/+3Qol1q2h6jCEr9Cgewyj7jxHLPyqgVWLx07GN8+cc=; b=TTxSsmTkx0yyiHB3tIm89Vb1KeBPISPCf+KMR1aM1gLAjTSO7GMF0zw2BSANgpHci7 RHVyNal12B4AF9lEvoQcM8hkWch3Ro3h2+AWoAUyCZKfU9vkquu7f9ve8Xwz+EHpE8Tu PcuCgr3ijjkRTC0zTGG/Ui5kVX2yuhcdtzsu9fTcSj7piGwLhZh70srsI/A9l/NEWE/I jzyONEmKl4NJlbOEBrTtFaLuHbx3DkcEXfRhoToqEk7gldDmuWBf4Lv2PBJ/ErglrFw1 /oSKOzxLMF8UMgj0xRw/xsqGmHTv5TxVAQXC9FLQge7E3o9qklAeYCN/atjp4dbeB3l2 oafQ== X-Gm-Message-State: AOAM530uTooj3m35I/gkrfJcjVgy4sTNHkbafTqL2hLBu041Oa7cTkk7 dwaCciSbl9f241v64leZwTsiVXmrDKHaoIWywZSpAlEXtnYXJQ== X-Google-Smtp-Source: ABdhPJwTbWR1AeiUePtRDHy7Xafc5UkRE6ZW8Is/9f5CVs3u3GxLZs6VXSOOxuMTuU9FC5nhbiKmdFFoGMlIruayXE0= X-Received: by 2002:ae9:edd3:: with SMTP id c202mr27685834qkg.274.1639305352125; Sun, 12 Dec 2021 02:35:52 -0800 (PST) MIME-Version: 1.0 References: <87lf0qfkh4.fsf@gnus.org> <87fsqyce4s.fsf@gnus.org> In-Reply-To: From: David Fussner Date: Sun, 12 Dec 2021 10:35:24 +0000 Message-ID: Subject: Re: bug#52438: 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52438 Cc: 52438@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sorry Lars -- I just looked at the diff and I think it should be: if (*env != ':') instead of: if (*env == ':') ? Or am I confused as usual? David. On Sun, 12 Dec 2021 at 10:29, David Fussner wrote: > > Thanks again, Lars. > > > > > Thanks for testing; I've now pushed that version of the patch (with > > Andreas' change) to Emacs 29. > > > > David. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 05:43:03 2021 Received: (at 52438) by debbugs.gnu.org; 12 Dec 2021 10:43:03 +0000 Received: from localhost ([127.0.0.1]:50748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwMJr-0001iB-50 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 05:43:03 -0500 Received: from mail-qv1-f43.google.com ([209.85.219.43]:38665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwMJl-0001hZ-A7 for 52438@debbugs.gnu.org; Sun, 12 Dec 2021 05:43:01 -0500 Received: by mail-qv1-f43.google.com with SMTP id a24so12029944qvb.5 for <52438@debbugs.gnu.org>; Sun, 12 Dec 2021 02:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ejTib6Tw3LeAGzWShE1e81GEcLSVwVqi6XDXpmzjAFA=; b=V39OEdznnzWhtNiABdgCeKG/iiI47ogp9TfyRSinq7r8C+mApciguVlhokTkD4XM6c 9+CJnAyM7afCsZ3xc9PLUOiHF3sEqDySdrhT4ZzK9l5qK51eRQ/Vwh/kwVBXIxFAWGSt GgsdRlFVbla7m5XLHoXQjGTeVKcSIQiAjxPwKYtYE7IFnWgxxhDmqA6gwvnERfDaahJD ozVFlq22XhagjOKuMnxmlyCNL+oxE9sRY9hpDxyiernyAuSao2yldsiFj9ZtTSFElUXP vuEheuxHZnx5ddDWwtxtOveS81NW8t0nw8WtTnK5H/bSuH4NeQolWJvkjE3aXOBsXaKT ylAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ejTib6Tw3LeAGzWShE1e81GEcLSVwVqi6XDXpmzjAFA=; b=Yhal7EUMcSYz1D04jFmraMkHg3oMKYx4fIuvg6yUtyisFDuGtPGAZyGsaBomLKeHXF YoII+2esUbLbIl5uWCPiACJjJK75WFyV+vFGvtumyEzgVfQYhsdOEELudM12ylyIMScl vuDphLsZ2WGZ453FS1Pt7qL5GieUXXdMatZFq25AgxNhJYuQyTxkjeiIv/RCeZZZxKk5 ZETIvwkVd/EnqaV2jWztad0d1DcmMO32LNgwIzudR6fWOULnbfkpwzH8qbKB7HRcjDJz 5yWZ6bNevUKIKeVbz0diFh/kb3do/8si6QSujY9HsyysQOeY3yyd0elIYIMpV5Dpm5z0 qi0Q== X-Gm-Message-State: AOAM531KlB3A8+BJHE12bxEovf2nZ2d/1EazpLg0IXtzd2zIuNfUwqOO d5yh4i89nQ9o3EpnoIJ4xRfWXCt9SUvLS4JK4BelqYyA9dBBJQ== X-Google-Smtp-Source: ABdhPJzBwKCOIGZLBQQKUxGlyJ8bfN/n59L/tMUAh1sASxMvR9W5Oy8VizJWoj2YAvRnDod0fb1WSm/exCAODfG0t8Q= X-Received: by 2002:a05:6214:c89:: with SMTP id r9mr36906453qvr.8.1639305771903; Sun, 12 Dec 2021 02:42:51 -0800 (PST) MIME-Version: 1.0 References: <87lf0qfkh4.fsf@gnus.org> <87fsqyce4s.fsf@gnus.org> In-Reply-To: From: David Fussner Date: Sun, 12 Dec 2021 10:42:24 +0000 Message-ID: Subject: Re: bug#52438: 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52438 Cc: 52438@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) And again -- /* If the environment variable doesn't start with a colon, increase the length of the token table. */ That was the logic of my patch, in any case, and of your previous one. David. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 05:45:52 2021 Received: (at 52438) by debbugs.gnu.org; 12 Dec 2021 10:45:52 +0000 Received: from localhost ([127.0.0.1]:50757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwMMZ-0001nq-Qi for submit@debbugs.gnu.org; Sun, 12 Dec 2021 05:45:51 -0500 Received: from quimby.gnus.org ([95.216.78.240]:47338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwMMX-0001nc-UA for 52438@debbugs.gnu.org; Sun, 12 Dec 2021 05:45:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9QV6dZkQF7zOGMeHZVpoIqMy0ro4o2MV1eQ4/KPSDBk=; b=iiQM0YTtniJguS2AnulggM+jN6 je9eRuIx6k1B6LSnWGj80S5suNE9ZPtfW0cfT9pd7dUAhqOWu7PKg3azDmf3i2JxYssLpE3rLj49S XHegr09v9k02P+EBukFr9lEqcuHNjnmOgzFAnABnh9gz+fOxG4DaEc92Nrrx541loMdE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwMMP-0004R3-18; Sun, 12 Dec 2021 11:45:43 +0100 From: Lars Ingebrigtsen To: David Fussner Subject: Re: bug#52438: 29.0.50; [PATCH] Fix off-by-one error in etags.c TeX support References: <87lf0qfkh4.fsf@gnus.org> <87fsqyce4s.fsf@gnus.org> X-Now-Playing: Xeno & Oaklander's _Vi-deo_: "Infinite Sadness" Date: Sun, 12 Dec 2021 11:45:39 +0100 In-Reply-To: (David Fussner's message of "Sun, 12 Dec 2021 10:35:24 +0000") Message-ID: <87a6h6cd9o.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: David Fussner writes: > Sorry Lars -- I just looked at the diff and I think it should be: > > if (*env != ':') > > instead of: > > if (*env == ':') ? Yes, indeed. :-/ Now re-fixed. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52438 Cc: 52438@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) David Fussner writes: > Sorry Lars -- I just looked at the diff and I think it should be: > > if (*env != ':') > > instead of: > > if (*env == ':') ? Yes, indeed. :-/ Now re-fixed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Wed Jun 18 23:17:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 09 Jan 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator