Subject: [bug#52437] Add lifeograph

From: Nicolas Goaziou <[email-masked]>
Date: Fri, 17 Dec 2021 09:25:07 +0100

Hello,

Pradana Adrinusa AUMARS via Guix-patches via <[email-masked]>
writes:

> From 324b8cd3c801ad7c106725aff59fa65d00b50341 Mon Sep 17 00:00:00 2001
> From: Pradana AUMARS <[email-masked]>
> Date: Sat, 11 Dec 2021 18:58:51 +0100
> Subject: [PATCH] gnu: Add lifeograph.

Thank you. Some comments follow.

> * gnu/packages/lifeograph.scm (lifeograph): New file.

If you create a new file (is in necessary?), you need to also register
it in local.mk file.

> +(define-public rednotebook
> +  (package
> +   (name "lifeograph")

There's a mismatch between the name of the variable and the package.

> +   (version "2.0.2")
> +   (source (origin

Could you move origin below source?

> +            (method url-fetch)
> +            (uri (string-append "https://launchpad.net/" name "/trunk/" version
> +                                "/+download/" name "-" version ".tar.xz"))

You can hard-code "name" above.

> +            (sha256
> +             (base32
> +              "1sfr3fd07x995makdp5wx3lxf7kl156hilliw77d0vnjp8ri49xl"))))

Hash string should go on the same line as base32.

> +   (build-system meson-build-system)
> +   (arguments `(#:build-type "release"))

Could you explain in a comment why "release" is needed?

> +   (inputs
> +    `(("gtkmm" ,gtkmm)
> +      ("gtk+", gtk+ "bin")
> +      ("enchant" ,enchant)
> +      ("libgcrypt" ,libgcrypt)
> +      ("libchamplain" ,libchamplain)))

Could you sort inputs alphabetically? Also could you use new inputs
style:

  (inputs
   (list enchant `(,gtk+ "bin") gtkmm ...))

> +   (native-inputs
> +    `(("pkg-config" ,pkg-config)))

Ditto:

  (native-inputs
   (list pkg-config))

> +   (synopsis "Off-line and private journal and note taking application")
> +   (description "Lifeograph is a diary program to take personal notes on life.
> +It has all the essential functionality expected in a diary program and strives
> +to have a clean and streamlined user interface.")
> +   (home-page "http://lifeograph.sourceforge.net/")
> +   (license license:gpl3+)))

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou