GNU bug report logs - #524
outdated (put ...) exceptions for evaled file-local variables

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Alex Shinn <alexshinn <at> gmail.com>
Subject: bug#524 closed by Chong Yidong <cyd <at> stupidchicken.com> (Re: 
 outdated (put ...) exceptions for evaled file-local variables)

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#524: outdated (put ...) exceptions for evaled file-local variables

It has been closed by Chong Yidong <cyd <at> stupidchicken.com>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Chong Yidong <cyd <at> stupidchicken.com> by
replying to this email.


-- 
524: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=524
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Alex Shinn <alexshinn <at> gmail.com>
Cc: 524-done <at> debbugs.gnu.org
Subject: Re: outdated (put ...) exceptions for evaled file-local variables
Date: Tue, 05 Aug 2008 16:47:51 -0400

Thanks.  I've checked your patch (with minor modifications) into the CVS
trunk.

[Message part 3 (message/rfc822, inline)]

From: Alex Shinn <alexshinn <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: outdated (put ...) exceptions for evaled file-local variables
Date: Thu, 03 Jul 2008 15:44:53 +0900

[Message part 4 (text/plain, inline)]

Currently `hack-one-local-variable-eval-safep' has a few
manually checked exceptions for the `eval' pseudo-variable,
so that the common cases of setting indent and edebug
properties for symbols is considered safe automatically.

However, the indent property checks for `lisp-indent-hook',
which as far as I can tell is deprecated.  It's not
mentioned anywhere in the docs, and lisp-mode.el only uses
it as a fallback in case the `lisp-indent-function' property
isn't set.  All the properties in lisp-mode.el are set as
`lisp-indent-function'.

A simple fix would be to allow either.  I've attached a
potential patch that does this, and also allows
scheme-indent-function, since this case is also common and I
don't think there are many other modes that make use of
symbol indent-function properties.  I'd understand if you
didn't want to support Scheme by default though, in which
case I'd just resort to using `safe-local-eval-function'.

A more general fix might be to implement a separate
customization for which properties are automatically
settable with which values, with perhaps more broad default
settings than Emacs currently has.

-- 
Alex

[files.el.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.