From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 09 07:52:10 2021 Received: (at submit) by debbugs.gnu.org; 9 Dec 2021 12:52:10 +0000 Received: from localhost ([127.0.0.1]:42781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvIuA-0001sz-HI for submit@debbugs.gnu.org; Thu, 09 Dec 2021 07:52:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:46116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvIu8-0001ss-Jt for submit@debbugs.gnu.org; Thu, 09 Dec 2021 07:52:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvIu8-0001Bo-9P for guix-patches@gnu.org; Thu, 09 Dec 2021 07:52:08 -0500 Received: from [2a00:1450:4864:20::52f] (port=45673 helo=mail-ed1-x52f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mvIu4-00041v-Kp for guix-patches@gnu.org; Thu, 09 Dec 2021 07:52:08 -0500 Received: by mail-ed1-x52f.google.com with SMTP id y12so18928330eda.12 for ; Thu, 09 Dec 2021 04:52:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version; bh=pUsC7QfwclDhZLf3TXL1Atq1MTPz4jSTxgW9TmPz/Bo=; b=qQg+7DnQozjubn6Wk1vEs29z0NvBiZon0Ty1kENZBOTQIft9/pAdTJZ7UnMgQViZZY XCC8+XbJvUikw3JNewW0J1t/GwaHSqINl7hjOH7N589nW1ai+ov0rl5y04uHxIc5OV8Q Bk3L6781rB8Nwd87f5FEiqr0iBTx4lKvpaB1yoo2lkAIZWeihq1Tb8TnpyGluPiq4Sxe T11t+9k0CdzaGbJohXL9VCHL0NJwhWoD0xb7AoBvNj5lr8Br0OFHV0sTg6bvw2xExWAd Kn6Asfn4Bqo12m2pSapu6+2H63/qpvP0NDQLvPmd6aiW46717FGbz/wplZ6sLQW+kfYB kuUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=pUsC7QfwclDhZLf3TXL1Atq1MTPz4jSTxgW9TmPz/Bo=; b=zbGkGcJjvLLIp9bx+JJ6fjyDUwssEgvdkZy1wuH95upyPKc9ipYl/gBjRwHXLVvl0i wuj0Cf+TswsKNDSjeQdtYtd+ibUzIkkr8KuX/T56DxmaidVtd6QqvwcmQ6RxRnabI3wm NOJ5FZ3qU091N4PWbZKVrWhBPQK18Ea7s110sub9X1o/PMfF0v+GhgNQi03Djg9nTwuh joKHEz+8iae81hiJG6LAyfhlf3pdMdUy/5aV8BoaA43/ICUzT1gwqcucHBNJNuZ67/5L PRKbCMb5//7LTHB5cBWodczzSEXtUGeLwIh2/Lpr25LZ18hNZsvZPDEGCv9fLH32pUY8 E3wQ== X-Gm-Message-State: AOAM531I2+lvH9LwjTgXMoWPRiofa9GcOfmlsTkzgI9K3zfHkUqmaRpM GHAJE4BdK7/exk/Fj80IrPZfyzh2vKIqCA== X-Google-Smtp-Source: ABdhPJz708RL5GjcJyO8/MXeeSgOIRrtc6Lk26E25EVQMrkiYnqq1cpMgcowzdK6XPdBJvGN1rDN7w== X-Received: by 2002:a50:cdc8:: with SMTP id h8mr29016138edj.87.1639054321119; Thu, 09 Dec 2021 04:52:01 -0800 (PST) Received: from localhost (109-252-167-227.dynamic.spd-mgts.ru. [109.252.167.227]) by smtp.gmail.com with ESMTPSA id og14sm2713496ejc.107.2021.12.09.04.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 04:52:00 -0800 (PST) From: Andrew Tropin To: guix-patches@gnu.org, Liliana Marie Prikler Subject: [PATCH] build-system: emacs: Add generation of -pkg.el files. Date: Thu, 9 Dec 2021 12:01:46 +0300 Message-ID: <871r2mrleb.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52f (failed) Received-SPF: none client-ip=2a00:1450:4864:20::52f; envelope-from=andrew@trop.in; helo=mail-ed1-x52f.google.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: submit Cc: Ivan Sokolov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * guix/build/emacs-build-system.scm (%default-exclude): Add generation of =2Dpkg.el files for packages, which do not provide them. =2D-- Implemented phase, which generates -pkg.el from comments in library file. = The solution for finding main el file of the package is a little hacky, because package name isn't available build time. I took a part of the elisp implementation from melpa source code. https://github.com/melpa/melpa/blob/master/package-build/package-build.el#L= 553 guix/build/emacs-build-system.scm | 71 ++++++++++++++++++++++++++++++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-sys= tem.scm index f13162d6c4..ee934f4bde 100644 =2D-- a/guix/build/emacs-build-system.scm +++ b/guix/build/emacs-build-system.scm @@ -154,6 +154,74 @@ (define (substitute-program-names) (substitute-program-names)))) #t)) =20 +(define* (find-root-library-file name) + (let lp ((subnames (string-split + (package-name-version->elpa-name-version name) #\-)) + (possible-name "")) + (cond + ((file-exists? (string-append possible-name ".el")) possible-name) + ((null? subnames) #f) + (#t (lp (cdr subnames) (string-append + possible-name + (if (string-null? possible-name) "" "-") + (car subnames))))))) + +(define (add-pkg-expr name) + `(progn + (require 'lisp-mnt) + (require 'package) + + (defun build-package-desc-from-library (name) + (package-desc-from-define + name + ;; Workaround for malformed version string (for example "24 (beta)"= in + ;; paredit.el), try to parse version obtained by lm-version, before + ;; trying to create package-desc. Otherwis the whole process of + ;; generation -pkg.el will fail. + (condition-case + nil + (version-to-list (lm-version)) + (lm-version) + (error "0.0.0")) + (or (save-excursion + (goto-char (point-min)) + (and (re-search-forward + "^;;; [^ ]*\\.el ---[ \t]*\\(.*?\\)[ \t]*\\(-\\*-.*-\\*-= [ \t]*\\)?$" + nil t) + (match-string-no-properties 1))) + "No description available.") + (when-let ((require-lines (lm-header-multiline "package-requires"))) + (package--prepare-dependencies + (package-read-from-string + (mapconcat 'identity require-lines " ")))) + :kind 'single + :url (lm-homepage) + :keywords (lm-keywords-list) + :maintainer (lm-maintainer) + :authors (lm-authors))) + + (defun generate-package-description-file (name) + (package-generate-description-file + (build-package-desc-from-library name) + (concat name "-pkg.el"))) + + (condition-case err + (generate-package-description-file ,name) + (message (concat ,name "-pkg.el file generated.")) + (error + (message "There are some errors during generation of -pkg.el file:") + (message "%s" (error-message-string err)))))) + +(define* (add-pkg-file #:key name outputs #:allow-other-keys) + (define source (getcwd)) + (chdir (elpa-directory (assoc-ref outputs "out"))) + (let ((el-lib (find-root-library-file name))) + (when (and el-lib (not (file-exists? (string-append el-lib "-pkg.el"))= )) + (emacs-batch-edit-file (string-append el-lib ".el") + (add-pkg-expr el-lib)))) + (chdir source) + #t) + (define* (check #:key tests? (test-command '("make" "check")) (parallel-tests? #t) #:allow-other-keys) "Run the tests by invoking TEST-COMMAND. @@ -294,7 +362,8 @@ (define %standard-phases enable-autoloads-compilation) (add-after 'enable-autoloads-compilation 'patch-el-files patch-el-file= s) ;; The .el files are byte compiled directly in the store. =2D (add-after 'patch-el-files 'build build) + (add-after 'patch-el-files 'add-pkg-file add-pkg-file) + (add-after 'add-pkg-file 'build build) (add-after 'build 'validate-compiled-autoloads validate-compiled-autol= oads) (add-after 'validate-compiled-autoloads 'move-doc move-doc))) =20 =2D-=20 2.34.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmGx++wPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wwywP/3cBay9sx2zxlAy8akx9sJXutBoLDdf7w2JN F35wzeBEJbmK7yLilD2PghRyf0WNQcjbdf216UGwbRH3VnoiAK1KKM+9l8WLAKRo 1FC6qYW1d/Yr0Old3+ax0C7IxkOLbOyU5M97bS9+POoEvBhx+V9Qk+SOBDtQ/Sjp +GdTlgxI9Zw+Mg4MFuzXjw00F3uQfLJWDpyBAo2Qu7d573jtQqyCvpmgDcjYP3/4 dcmtUmRlQvm0eEFHP8I9QiHu+0TIEkCYZk/xavwdStyUzjrbD0UPshQr3HHmgJHj 12bmHT4hbrkyLCdlpbyCunTeJtEZkvakZafqEKkmaDfaikXnapqzh/Vr/A1RGPWp tcPmPfIMtCylVTUU3vtC/Jz1rgy2KTdbyBfvz64BNLjdbdNAfNZ760tChcTCQMwr H3gFfMauZcs4VxPZ8HwLLgU52eyzwaSutkesfPM/qhesUCRzNSfWnlCNdInkiyki Lfb/KnfE92dFTsTXHDbcNUqsLplRNrmvrBGfDm4zv5N8E+z3Cgh+o/Nj+I+D4BX6 Yb5euokW18tj+yMbJqoMXRpRoWRqN31f1vPBDjXjq/DW1LJLvpnMuozEHR0ZxHWZ exJw+J0nK+9/rfPLE4+BtenTqEPgJTSqqhU42+pbaBusOY2UeksjDIK/Or459p02 M4VBH6fI =FiWO -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 14 15:57:08 2022 Received: (at 52388) by debbugs.gnu.org; 14 Jan 2022 20:57:08 +0000 Received: from localhost ([127.0.0.1]:38348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8TdE-0005Ac-Cf for submit@debbugs.gnu.org; Fri, 14 Jan 2022 15:57:08 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8TdB-0005A3-Br for 52388@debbugs.gnu.org; Fri, 14 Jan 2022 15:57:08 -0500 Received: by mail-wm1-f68.google.com with SMTP id c66so8317524wma.5 for <52388@debbugs.gnu.org>; Fri, 14 Jan 2022 12:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version; bh=mdDEbEsAqcw2rqPR+H28ODuRAOzx9RRjLdndEMoW8LE=; b=nY48ZlUhVqX70FfiI4Ymjjl2f37CQi8AGZgFaOdEPzAFia0+CzaVJVY+S+O2KHeDBu 418hwfabqgtaJ2kyrCcydUV+HEWYiI5pXz61uqACnZ+qxWew5qaTe0Ey0/pV88YWXL2W xxWhNdI0TfYP+7z6iDkjZ3qq6dQVNsBUqtQ+4H3QWU2ptI+IPRNJ6pR/Bd9a8NpkR/dt 97C74gLmVZPmRvuNvLSCBZQcOWdKM6EJVXBCMmcUsTrX2GU+v0An/nFc6By55hWuCwMO h0Mg+FvYngMhDFYZDj5Qv0idRigipykok2znGx4p0AQVtNnkw8EGDe6fZsc3ej/iE9Kl EfBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version; bh=mdDEbEsAqcw2rqPR+H28ODuRAOzx9RRjLdndEMoW8LE=; b=wxM3MTUZFber7NDqDgTrtPrao8Y/Rdi9rgSC2C7wqhvOJrdoepfCP9uqNe9Ut2vRud uVo8/huXcqlWuTTorgr1RelyWNXIpQKl+6yuNplh7KliOKYSvcjiYU3u+sInBE/LkOf2 pJV88368Q0b39h4w/SeqdWcDSlttycENIcLsIBiA0UG5apw0PS3P5SaacneZ071F2i9A n+c+zfe+FGa5SjtJbNBAGUVjt+dUZ70l+4TkFYuHZfZPTSehdApVOQiNvyM7+FEfrBv1 x2GNQOPw2GZEetg2oUbJmcIlEfvm3XTNPDwzcsji+XH3KOwbi8gBCAvaln7QDdh9+CqM xe/w== X-Gm-Message-State: AOAM530TJxv2hd6NbyusVjT1kN2qfY8+eLi6Z/xWbV5ZqlqCHjp3OIjQ QPqcCN+tMhrsuV3RJcAFag0= X-Google-Smtp-Source: ABdhPJxeCKPTXEnx6IBapQI6K+cxutaogF2UivBa+6yJmv08GTn5tbM9u3HZjpxgh4Jfzg6TjcwuYw== X-Received: by 2002:a5d:64c3:: with SMTP id f3mr9679064wri.155.1642193819439; Fri, 14 Jan 2022 12:56:59 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id o15sm1846934wri.71.2022.01.14.12.56.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jan 2022 12:56:58 -0800 (PST) Message-ID: <80cfa468ef91649dce477779a70d3a8ce64fd0e4.camel@gmail.com> Subject: Re: [PATCH] build-system: emacs: Add generation of -pkg.el files. From: Liliana Marie Prikler To: Andrew Tropin , 52388@debbugs.gnu.org Date: Fri, 14 Jan 2022 21:56:56 +0100 In-Reply-To: <871r2mrleb.fsf@trop.in> References: <871r2mrleb.fsf@trop.in> Content-Type: multipart/mixed; boundary="=-UPXnQGlJJ3DknJtz9Byg" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52388 Cc: Ivan Sokolov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-UPXnQGlJJ3DknJtz9Byg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi Andrew, Am Donnerstag, dem 09.12.2021 um 12:01 +0300 schrieb Andrew Tropin: > > * guix/build/emacs-build-system.scm (%default-exclude): Add > generation of > -pkg.el files for packages, which do not provide them. > --- > Implemented phase, which generates -pkg.el from comments in library > file.  The solution for finding main el file of the package is a > little hacky, because package name isn't available build time. > > I took a part of the elisp implementation from melpa source code. > https://github.com/melpa/melpa/blob/master/package-build/package-build.el#L553 As promised, I took a deeper look at your patch. As already noted, there were some clean-up actions I had to perform, such as keeping to our line limit (it was not easy, I tell you) among other things. Also, confusingly, your condition-case code did not handle errors and wrong handling of the version field blew up everything for me. Did you test this code? In any case, attached is my revised patch. I so far only checked it with emacs-olivetti -- a package whose description is missing in current Guix Emacs. I'll give everyone some time to test things before pushing this however; I don't want to break a bunch of Emacs packages scattered around various files. Cheers --=-UPXnQGlJJ3DknJtz9Byg Content-Disposition: attachment; filename*0=0001-build-system-emacs-Ensure-that-package-descriptions-.pat; filename*1=ch Content-Type: text/x-patch; name="0001-build-system-emacs-Ensure-that-package-descriptions-.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA5ZmE2YTA5YTEzMWNmZTQzNmNhMDUzYzk2MGVkOTYyNTI2M2JjNjUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgVHJvcGluIDxhbmRyZXdAdHJvcC5pbj4KRGF0ZTog VGh1LCA5IERlYyAyMDIxIDEyOjAxOjQ2ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gYnVpbGQtc3lz dGVtOiBlbWFjczogRW5zdXJlIHRoYXQgcGFja2FnZSBkZXNjcmlwdGlvbnMgYXJlCiBnZW5lcmF0 ZWQuCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1V VEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpUaGlzIHBhdGNoIGFkZHJlc3Nl cyB0aGUgc2Vjb25kIHBhcnQgb2YgPGh0dHBzOi8vYnVncy5nbnUub3JnLzQ4MzMxPi4KV2hpbGUg ZXhpc3RpbmcgLXBrZy5lbCBmaWxlcyB3ZXJlIHByZXZpb3VzbHkgaW5zdGFsbGVkLCBubyBzdWNo IGZpbGVzCndlcmUgZ2VuZXJhdGVkIGZvciBwYWNrYWdlcyBsYWNraW5nIHRoZW0sIHJlc3VsdGlu ZyBpbiBwYWNrYWdlcyBub3QKYmVpbmcgbGlzdGVkIGFzIGluc3RhbGxlZCBhbmQgbm90IGJlaW5n IGF2YWlsYWJsZSB0b3dhcmRzCuKAnGRlc2NyaWJlLXBhY2thZ2XigJ0uCgoqIGd1aXgvYnVpbGQv ZW1hY3MtYnVpbGQtc3lzdGVtLnNjbSAoZmluZC1yb290LWxpYnJhcnktZmlsZSkKKGVuc3VyZS1w YWNrYWdlLWRlc2NyaXB0aW9uKTogTmV3IHZhcmlhYmxlcy4KKCVzdGFuZGFyZC1waGFzZXMpOiBB ZGQg4oCYZW5zdXJlLXBhY2thZ2UtZGVzY3JpcHRpb27igJkuCi0tLQogZ3VpeC9idWlsZC9lbWFj cy1idWlsZC1zeXN0ZW0uc2NtIHwgNzcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQog MSBmaWxlIGNoYW5nZWQsIDc2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9ndWl4L2J1aWxkL2VtYWNzLWJ1aWxkLXN5c3RlbS5zY20gYi9ndWl4L2J1aWxkL2VtYWNz LWJ1aWxkLXN5c3RlbS5zY20KaW5kZXggYWI3N2U1N2YzMy4uNThkMmE5YjlmNCAxMDA2NDQKLS0t IGEvZ3VpeC9idWlsZC9lbWFjcy1idWlsZC1zeXN0ZW0uc2NtCisrKyBiL2d1aXgvYnVpbGQvZW1h Y3MtYnVpbGQtc3lzdGVtLnNjbQpAQCAtMTQwLDYgKzE0MCw3OSBAQCAoZGVmaW5lIChzdWJzdGl0 dXRlLXByb2dyYW0tbmFtZXMpCiAgICAgICAgICAgKHN1YnN0aXR1dGUtcHJvZ3JhbS1uYW1lcykp KSkKICAgICAjdCkpCiAKKyhkZWZpbmUgKGZpbmQtcm9vdC1saWJyYXJ5LWZpbGUgbmFtZSkKKyAg KGxldCBsb29wICgocGFydHMgKHN0cmluZy1zcGxpdAorICAgICAgICAgICAgICAgICAgICAgKHBh Y2thZ2UtbmFtZS12ZXJzaW9uLT5lbHBhLW5hbWUtdmVyc2lvbiBuYW1lKSAjXC0pKQorICAgICAg ICAgICAgIChjYW5kaWRhdGUgIiIpKQorICAgIChjb25kCisgICAgIDs7IGF0IGxlYXN0IG9uZSB2 ZXJzaW9uIHBhcnQgaXMgZ2l2ZW4sIHNvIHdlIGRvbid0IHRlcm1pbmF0ZSAiZWFybHkiCisgICAg ICgobnVsbD8gcGFydHMpICNmKQorICAgICAoKHN0cmluZy1udWxsPyBjYW5kaWRhdGUpIChsb29w IChjZHIgcGFydHMpIChjYXIgcGFydHMpKSkKKyAgICAgKChmaWxlLWV4aXN0cz8gKHN0cmluZy1h cHBlbmQgY2FuZGlkYXRlICIuZWwiKSkgY2FuZGlkYXRlKQorICAgICAoZWxzZQorICAgICAgKGxv b3AgKGNkciBwYXJ0cykgKHN0cmluZy1hcHBlbmQgY2FuZGlkYXRlICItIiAoY2FyIHBhcnRzKSkp KSkpKQorCisoZGVmaW5lKiAoZW5zdXJlLXBhY2thZ2UtZGVzY3JpcHRpb24gIzprZXkgb3V0cHV0 cyAjOmFsbG93LW90aGVyLWtleXMpCisgIChkZWZpbmUgKHdyaXRlLXBrZy1maWxlIG5hbWUpCisg ICAgKGRlZmluZSBzdW1tYXJ5LXJlZ2V4cAorICAgICAgIl47OzsgW14gXSpcXC5lbCAtLS1bIFx0 XSpcXCguKj9cXClbIFx0XSpcXCgtXFwqLS4qLVxcKi1bIFx0XSpcXCk/JCIpCisgICAgKGRlZmlu ZSAld3JpdGUtcGtnLWZpbGUtZm9ybQorICAgICAgYChwcm9nbgorICAgICAgICAocmVxdWlyZSAn bGlzcC1tbnQpCisgICAgICAgIChyZXF1aXJlICdwYWNrYWdlKQorCisgICAgICAgIChkZWZ1biBi dWlsZC1wYWNrYWdlLWRlc2MtZnJvbS1saWJyYXJ5IChuYW1lKQorICAgICAgICAgIChwYWNrYWdl LWRlc2MtZnJvbS1kZWZpbmUKKyAgICAgICAgICAgbmFtZQorICAgICAgICAgICA7OyBXb3JrYXJv dW5kIGZvciBtYWxmb3JtZWQgdmVyc2lvbiBzdHJpbmcgKGZvciBleGFtcGxlICIyNCAoYmV0YSki CisgICAgICAgICAgIDs7IGluIHBhcmVkaXQuZWwpLCB0cnkgdG8gcGFyc2UgdmVyc2lvbiBvYnRh aW5lZCBieSBsbS12ZXJzaW9uLAorICAgICAgICAgICA7OyBiZWZvcmUgdHJ5aW5nIHRvIGNyZWF0 ZSBwYWNrYWdlLWRlc2MuICBPdGhlcndpcyB0aGUgd2hvbGUgcHJvY2VzcworICAgICAgICAgICA7 OyBvZiBnZW5lcmF0aW9uIC1wa2cuZWwgd2lsbCBmYWlsLgorICAgICAgICAgICAoY29uZGl0aW9u LWNhc2UKKyAgICAgICAgICAgIG5pbAorICAgICAgICAgICAgKGxldCAoKHZlcnNpb24gKGxtLXZl cnNpb24pKSkKKyAgICAgICAgICAgICAgOzsgcmFpc2VzIGFuIGVycm9yIGlmIHZlcnNpb24gaXMg aW52YWxpZAorICAgICAgICAgICAgICAoYW5kICh2ZXJzaW9uLXRvLWxpc3QgdmVyc2lvbikgdmVy c2lvbikpCisgICAgICAgICAgICAoZXJyb3IgIjAuMC4wIikpCisgICAgICAgICAgIChvciAoc2F2 ZS1leGN1cnNpb24KKyAgICAgICAgICAgICAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQorICAg ICAgICAgICAgICAgIChhbmQgKHJlLXNlYXJjaC1mb3J3YXJkICxzdW1tYXJ5LXJlZ2V4cCBuaWwg dCkKKyAgICAgICAgICAgICAgICAgICAgIChtYXRjaC1zdHJpbmctbm8tcHJvcGVydGllcyAxKSkp CisgICAgICAgICAgICAgICBwYWNrYWdlLS1kZWZhdWx0LXN1bW1hcnkpCisgICAgICAgICAgIChs ZXQgKChyZXF1aXJlLWxpbmVzIChsbS1oZWFkZXItbXVsdGlsaW5lICJwYWNrYWdlLXJlcXVpcmVz IikpKQorICAgICAgICAgICAgIChhbmQgcmVxdWlyZS1saW5lcworICAgICAgICAgICAgICAgICAg KHBhY2thZ2UtLXByZXBhcmUtZGVwZW5kZW5jaWVzCisgICAgICAgICAgICAgICAgICAgKHBhY2th Z2UtcmVhZC1mcm9tLXN0cmluZworICAgICAgICAgICAgICAgICAgICAobWFwY29uY2F0ICdpZGVu dGl0eSByZXF1aXJlLWxpbmVzICIgIikpKSkpCisgICAgICAgICAgIDpraW5kICAgICAgICdzaW5n bGUKKyAgICAgICAgICAgOnVybCAgICAgICAgKGxtLWhvbWVwYWdlKQorICAgICAgICAgICA6a2V5 d29yZHMgICAobG0ta2V5d29yZHMtbGlzdCkKKyAgICAgICAgICAgOm1haW50YWluZXIgKGxtLW1h aW50YWluZXIpCisgICAgICAgICAgIDphdXRob3JzICAgIChsbS1hdXRob3JzKSkpCisKKyAgICAg ICAgKGRlZnVuIGdlbmVyYXRlLXBhY2thZ2UtZGVzY3JpcHRpb24tZmlsZSAobmFtZSkKKyAgICAg ICAgICAocGFja2FnZS1nZW5lcmF0ZS1kZXNjcmlwdGlvbi1maWxlCisgICAgICAgICAgIChidWls ZC1wYWNrYWdlLWRlc2MtZnJvbS1saWJyYXJ5IG5hbWUpCisgICAgICAgICAgIChjb25jYXQgbmFt ZSAiLXBrZy5lbCIpKSkKKworICAgICAgICAoY29uZGl0aW9uLWNhc2UKKyAgICAgICAgIGVycgor ICAgICAgICAgKGxldCAoKG5hbWUgKGZpbGUtbmFtZS1iYXNlIChidWZmZXItZmlsZS1uYW1lKSkp KQorICAgICAgICAgICAoZ2VuZXJhdGUtcGFja2FnZS1kZXNjcmlwdGlvbi1maWxlIG5hbWUpCisg ICAgICAgICAgIChtZXNzYWdlIChjb25jYXQgbmFtZSAiLXBrZy5lbCBmaWxlIGdlbmVyYXRlZC4i KSkpCisgICAgICAgICAoZXJyb3IKKyAgICAgICAgICAobWVzc2FnZSAiVGhlcmUgYXJlIHNvbWUg ZXJyb3JzIGR1cmluZyBnZW5lcmF0aW9uIG9mIC1wa2cuZWwgZmlsZToiKQorICAgICAgICAgICht ZXNzYWdlICIlcyIgKGVycm9yLW1lc3NhZ2Utc3RyaW5nIGVycikpKSkpKQorCisgICAgKHVubGVz cyAoZmlsZS1leGlzdHM/IChzdHJpbmctYXBwZW5kIG5hbWUgIi1wa2cuZWwiKSkKKyAgICAgIChl bWFjcy1iYXRjaC1lZGl0LWZpbGUgKHN0cmluZy1hcHBlbmQgbmFtZSAiLmVsIikKKyAgICAgICAg JXdyaXRlLXBrZy1maWxlLWZvcm0pKSkKKworICAobGV0KiAoKG91dCAoYXNzb2MtcmVmIG91dHB1 dHMgIm91dCIpKQorICAgICAgICAgKGVscGEtbmFtZS12ZXIgKHN0b3JlLWRpcmVjdG9yeS0+ZWxw YS1uYW1lLXZlcnNpb24gb3V0KSkpCisgICAgKHdpdGgtZGlyZWN0b3J5LWV4Y3Vyc2lvbiAoZWxw YS1kaXJlY3Rvcnkgb3V0KQorICAgICAgKGFuZD0+IChmaW5kLXJvb3QtbGlicmFyeS1maWxlIGVs cGEtbmFtZS12ZXIpIHdyaXRlLXBrZy1maWxlKSkpKQorCiAoZGVmaW5lKiAoY2hlY2sgIzprZXkg dGVzdHM/ICh0ZXN0LWNvbW1hbmQgJygibWFrZSIgImNoZWNrIikpCiAgICAgICAgICAgICAgICAg KHBhcmFsbGVsLXRlc3RzPyAjdCkgIzphbGxvdy1vdGhlci1rZXlzKQogICAiUnVuIHRoZSB0ZXN0 cyBieSBpbnZva2luZyBURVNULUNPTU1BTkQuCkBAIC0yNzksOCArMzUyLDEwIEBAIChkZWZpbmUg JXN0YW5kYXJkLXBoYXNlcwogICAgIChhZGQtYWZ0ZXIgJ21ha2UtYXV0b2xvYWRzICdlbmFibGUt YXV0b2xvYWRzLWNvbXBpbGF0aW9uCiAgICAgICBlbmFibGUtYXV0b2xvYWRzLWNvbXBpbGF0aW9u KQogICAgIChhZGQtYWZ0ZXIgJ2VuYWJsZS1hdXRvbG9hZHMtY29tcGlsYXRpb24gJ3BhdGNoLWVs LWZpbGVzIHBhdGNoLWVsLWZpbGVzKQorICAgIChhZGQtYWZ0ZXIgJ3BhdGNoLWVsLWZpbGVzICdl bnN1cmUtcGFja2FnZS1kZXNjcmlwdGlvbgorICAgICAgZW5zdXJlLXBhY2thZ2UtZGVzY3JpcHRp b24pCiAgICAgOzsgVGhlIC5lbCBmaWxlcyBhcmUgYnl0ZSBjb21waWxlZCBkaXJlY3RseSBpbiB0 aGUgc3RvcmUuCi0gICAgKGFkZC1hZnRlciAncGF0Y2gtZWwtZmlsZXMgJ2J1aWxkIGJ1aWxkKQor ICAgIChhZGQtYWZ0ZXIgJ2Vuc3VyZS1wYWNrYWdlLWRlc2NyaXB0aW9uICdidWlsZCBidWlsZCkK ICAgICAoYWRkLWFmdGVyICdidWlsZCAndmFsaWRhdGUtY29tcGlsZWQtYXV0b2xvYWRzIHZhbGlk YXRlLWNvbXBpbGVkLWF1dG9sb2FkcykKICAgICAoYWRkLWFmdGVyICd2YWxpZGF0ZS1jb21waWxl ZC1hdXRvbG9hZHMgJ21vdmUtZG9jIG1vdmUtZG9jKSkpCiAKLS0gCjIuMzQuMAoK --=-UPXnQGlJJ3DknJtz9Byg-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 21 07:11:51 2022 Received: (at 52388) by debbugs.gnu.org; 21 Jan 2022 12:11:51 +0000 Received: from localhost ([127.0.0.1]:60513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAsli-0007AT-RY for submit@debbugs.gnu.org; Fri, 21 Jan 2022 07:11:51 -0500 Received: from mail-lf1-f41.google.com ([209.85.167.41]:34417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAslf-0007AD-GB for 52388@debbugs.gnu.org; Fri, 21 Jan 2022 07:11:49 -0500 Received: by mail-lf1-f41.google.com with SMTP id p27so33415082lfa.1 for <52388@debbugs.gnu.org>; Fri, 21 Jan 2022 04:11:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=Fmjf5u1sVtHPNmFYAcIoI9bcf0CJUCsdoIIpEWa2lB8=; b=fBQJ8FE9Doo66KInsVLWlJuW5J/sc6kCGxyBlc6XvbtRK0h/DXXnXzxfQD5srYxc1M vCxd+KcSdRPpewcaYe35zA8RTPE1r4BHCDi2xUXMth+udqwi+96A3LO0LVlO/oYLWXDM elb+JlgOKEDb1XQJoEdegsiQeccvuyBredLw9chT1J+jQAJAU1fHBZDI4vfhtKHtrPG/ rya6RZbP1uRk32k/zxGMx/2rLpq5XZGZNLt6FjmGgqp8KGM/WgrehgzxzisY0yQ7nlXY Vh/ZoXX8msVLjLjpOonlzwV9dVvjEpfF0d6tc+LZAqX/jXLfFmM1XdWq5iU0VH4bn1jT x1gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Fmjf5u1sVtHPNmFYAcIoI9bcf0CJUCsdoIIpEWa2lB8=; b=0HEZ3u4Z3Np9p0/oWHstyXeheb6TdL4NAWO9H6hLlIhF2d77anpeu8ts/Z/uGlA/eg BcOcuzc7lSYR7j2qlf6Odqw8Iepm98HN+wAnh+pXHlXZVC5fvyEikTeg8usjY2lsFNZi OHm+xtLSNZckiNX+LaXxTV17Iw3NChOvs+/qXLnk1VQ5901bk3hiu9iXkyQZijp3gN8p vNmogd8LLEq7TH5eWjcHR2eo+fVV0NProMdGDmysIVvvWCmvblljXcde9qt748IO0mnA f6n5m4uFOjS3DePBiV96Hzd1OHrZQIS5OpyIQ7DO4X/oE2UAC4Ru1oW9KOwZiM/mxBbZ TYAg== X-Gm-Message-State: AOAM533bS4+iZLp1JP2wiNzkXpBvAqkj2jvgUerJ6UxGfotC74Hnvv5H V2D+K6wLY/S8uzkSpV1K5QrkgA== X-Google-Smtp-Source: ABdhPJwvv9pq+d2aVj2wMt55YhBt0sPal6DMZsQGJ6kBQr4gC19of/p5aFhMJOrM+kTHKlfk3uOpgA== X-Received: by 2002:a05:6512:10cc:: with SMTP id k12mr3549649lfg.425.1642767101090; Fri, 21 Jan 2022 04:11:41 -0800 (PST) Received: from localhost (109-252-135-33.dynamic.spd-mgts.ru. [109.252.135.33]) by smtp.gmail.com with ESMTPSA id l22sm174809ljg.78.2022.01.21.04.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 04:11:40 -0800 (PST) From: Andrew Tropin To: Liliana Marie Prikler , 52388@debbugs.gnu.org Subject: Re: [PATCH] build-system: emacs: Add generation of -pkg.el files. In-Reply-To: <80cfa468ef91649dce477779a70d3a8ce64fd0e4.camel@gmail.com> References: <871r2mrleb.fsf@trop.in> <80cfa468ef91649dce477779a70d3a8ce64fd0e4.camel@gmail.com> Date: Fri, 21 Jan 2022 15:11:36 +0300 Message-ID: <87zgnp8f0n.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52388 Cc: Ivan Sokolov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-01-14 21:56, Liliana Marie Prikler wrote: > Hi Andrew, > > Am Donnerstag, dem 09.12.2021 um 12:01 +0300 schrieb Andrew Tropin: >>=20 >> * guix/build/emacs-build-system.scm (%default-exclude): Add >> generation of >> -pkg.el files for packages, which do not provide them. >> --- >> Implemented phase, which generates -pkg.el from comments in library >> file.=C2=A0 The solution for finding main el file of the package is a >> little hacky, because package name isn't available build time. >>=20 >> I took a part of the elisp implementation from melpa source code. >> https://github.com/melpa/melpa/blob/master/package-build/package-build.e= l#L553 > As promised, I took a deeper look at your patch. As already noted, > there were some clean-up actions I had to perform, such as keeping to > our line limit (it was not easy, I tell you) among other things. Also, > confusingly, your condition-case code did not handle errors and wrong > handling of the version field blew up everything for me. Did you test > this code? I thought it was the version I used for past a few weeks, however I could send a little outdated version, not the latest one by accident. Tested it with guix build emacs-paredit. See your fix which wraps both forms in one let, thank you, yep, it's very likely I sent an intermediate version of the patch accidentially. > > In any case, attached is my revised patch. I so far only checked it > with emacs-olivetti -- a package whose description is missing in > current Guix Emacs. I'll give everyone some time to test things before > pushing this however; I don't want to break a bunch of Emacs packages > scattered around various files. > > Cheers > From 9fa6a09a131cfe436ca053c960ed9625263bc650 Mon Sep 17 00:00:00 2001 > From: Andrew Tropin > Date: Thu, 9 Dec 2021 12:01:46 +0300 > Subject: [PATCH] build-system: emacs: Ensure that package descriptions are > generated. > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > This patch addresses the second part of . > While existing -pkg.el files were previously installed, no such files > were generated for packages lacking them, resulting in packages not > being listed as installed and not being available towards > =E2=80=9Cdescribe-package=E2=80=9D. > > * guix/build/emacs-build-system.scm (find-root-library-file) > (ensure-package-description): New variables. > (%standard-phases): Add =E2=80=98ensure-package-description=E2=80=99. > --- > guix/build/emacs-build-system.scm | 77 ++++++++++++++++++++++++++++++- > 1 file changed, 76 insertions(+), 1 deletion(-) > > diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-s= ystem.scm > index ab77e57f33..58d2a9b9f4 100644 > --- a/guix/build/emacs-build-system.scm > +++ b/guix/build/emacs-build-system.scm > @@ -140,6 +140,79 @@ (define (substitute-program-names) > (substitute-program-names)))) > #t)) >=20=20 > +(define (find-root-library-file name) > + (let loop ((parts (string-split > + (package-name-version->elpa-name-version name) #\-)) > + (candidate "")) > + (cond > + ;; at least one version part is given, so we don't terminate "early" > + ((null? parts) #f) > + ((string-null? candidate) (loop (cdr parts) (car parts))) > + ((file-exists? (string-append candidate ".el")) candidate) > + (else > + (loop (cdr parts) (string-append candidate "-" (car parts))))))) > + > +(define* (ensure-package-description #:key outputs #:allow-other-keys) > + (define (write-pkg-file name) > + (define summary-regexp > + "^;;; [^ ]*\\.el ---[ \t]*\\(.*?\\)[ \t]*\\(-\\*-.*-\\*-[ \t]*\\)?= $") > + (define %write-pkg-file-form > + `(progn > + (require 'lisp-mnt) > + (require 'package) > + > + (defun build-package-desc-from-library (name) > + (package-desc-from-define > + name > + ;; Workaround for malformed version string (for example "24 (= beta)" > + ;; in paredit.el), try to parse version obtained by lm-versio= n, > + ;; before trying to create package-desc. Otherwis the whole = process s/Otherwis/Otherwise, > + ;; of generation -pkg.el will fail. > + (condition-case > + nil > + (let ((version (lm-version))) > + ;; raises an error if version is invalid > + (and (version-to-list version) version)) > + (error "0.0.0")) > + (or (save-excursion > + (goto-char (point-min)) > + (and (re-search-forward ,summary-regexp nil t) > + (match-string-no-properties 1))) > + package--default-summary) > + (let ((require-lines (lm-header-multiline "package-requires")= )) > + (and require-lines > + (package--prepare-dependencies > + (package-read-from-string > + (mapconcat 'identity require-lines " "))))) > + :kind 'single > + :url (lm-homepage) > + :keywords (lm-keywords-list) > + :maintainer (lm-maintainer) > + :authors (lm-authors))) > + > + (defun generate-package-description-file (name) > + (package-generate-description-file > + (build-package-desc-from-library name) > + (concat name "-pkg.el"))) > + > + (condition-case > + err > + (let ((name (file-name-base (buffer-file-name)))) > + (generate-package-description-file name) > + (message (concat name "-pkg.el file generated."))) > + (error > + (message "There are some errors during generation of -pkg.el f= ile:") > + (message "%s" (error-message-string err)))))) > + > + (unless (file-exists? (string-append name "-pkg.el")) > + (emacs-batch-edit-file (string-append name ".el") > + %write-pkg-file-form))) > + > + (let* ((out (assoc-ref outputs "out")) > + (elpa-name-ver (store-directory->elpa-name-version out))) > + (with-directory-excursion (elpa-directory out) > + (and=3D> (find-root-library-file elpa-name-ver) write-pkg-file)))) > + > (define* (check #:key tests? (test-command '("make" "check")) > (parallel-tests? #t) #:allow-other-keys) > "Run the tests by invoking TEST-COMMAND. > @@ -279,8 +352,10 @@ (define %standard-phases > (add-after 'make-autoloads 'enable-autoloads-compilation > enable-autoloads-compilation) > (add-after 'enable-autoloads-compilation 'patch-el-files patch-el-fi= les) > + (add-after 'patch-el-files 'ensure-package-description > + ensure-package-description) > ;; The .el files are byte compiled directly in the store. > - (add-after 'patch-el-files 'build build) > + (add-after 'ensure-package-description 'build build) > (add-after 'build 'validate-compiled-autoloads validate-compiled-aut= oloads) > (add-after 'validate-compiled-autoloads 'move-doc move-doc))) Looks cleaner than original implementation, thank you!) Applied on my local checkout of guix channel, list-packages now shows 117 external packages =3D) Will keep it for a while and let you know if any problems will reveal themselves. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmHqovgPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wkMYP/0iXSEI7Ky+K5zLUtktYmUrmxSUS34LlnQyU Ld/0P0o9gE3KF4kEko3Yehvu1CHpaK46v/9xN1E34Q10Cxa4eA+l6N9c9IFRnzdZ QIbj+RFDKEyKqSluHcGFQY+JXCM7Q8579t/dxAQkiErFSbRHBO3D6bBZRmEJSRBp KHP3p2nHfTlr97BTBczJl5ZCP4aW6ijM3RtfVQiQntKws3liJbn0aDZGXslskmVA Q4Ct68DQLRjjnKAbh3IK8G1pbLjzi22MdtI1QgdZ51Q7U+IRROqlf5SUOE3uA0Ue DI9TWu1Yx5S+y/pwWjtZqsiYTIpcXq0P8uQkM1P8mSLQq571wPW+ZrWtgMXX2cjc 0gDvtL/P8TKzNpiAfBFdCtRi669d27Kerqy5frUE3BFAaqMk2SPxA44w7A3ZTWrr ZAp9H52GPafS9X3GQNeOw2KXitpy773jw3t1VVc/hYe+UuszJj55qkU3oD7gv4Mw meGq21dmZrQuv+MF6bXFM/9W1OIYZmcGJNbY+fQI3JEEduuVaUxHBuTBAqG6qHFY An6cqt95P3tsoj58jssJJiT8fyqlp0OYGUyKl22Ur78SQAevp6sy46F32XAbP81S a1/TrRqKCWYCvt5a5LCfHEu8cFjFh7WnF3t9cO/mm1lC5PzzQ1fIXETtzsp+bV+r ZbOPCW2E =5NYX -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 21 11:57:45 2022 Received: (at 52388) by debbugs.gnu.org; 21 Jan 2022 16:57:45 +0000 Received: from localhost ([127.0.0.1]:34968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAxEO-0003e4-TW for submit@debbugs.gnu.org; Fri, 21 Jan 2022 11:57:45 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:43532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAxEO-0003dn-7V for 52388@debbugs.gnu.org; Fri, 21 Jan 2022 11:57:44 -0500 Received: by mail-wm1-f65.google.com with SMTP id e9-20020a05600c4e4900b0034d23cae3f0so23146641wmq.2 for <52388@debbugs.gnu.org>; Fri, 21 Jan 2022 08:57:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=I3GUtbHiQba9dCZ/Hv+KJ1nozfbWK95oECQkDwdUwJc=; b=M3TvR39da/eJjDbEZURAoTPyoLHrUhP/bRHu2YVO30BjG6oww56h5MIRXwK93263xE +4XSEgVH30NOYWKYbV+CDzUvjbgjBuaLM3fGctN/tkrhe7C11DCeIEdf4Nyl7R0JtCHm /BVYDVH776pXoUHlB4pYgJjFVX5NzkSOVS6yV5dKeyJ88/8sY4ovRm+TGCuwlLg5Sr13 FQJA0Q2n0mTIqTLJTvTZYRLxzaP7DeQ70nQgZFSEsfBIm53TiUq9YznqX1WzK8tvcQmA JSt6ES+OXC0Q1k8Wj8soVNjUB+6AY2JQIG4ygLvuVvE/Rb28Zuwn5CA3CDGsCyXJWKN+ 7Ncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=I3GUtbHiQba9dCZ/Hv+KJ1nozfbWK95oECQkDwdUwJc=; b=gtvEkyVnqUMtAS4iNW/jnErk4Sf3J2cThPEPUYODbEFjqcL7e+FWUiv5jZ458uGRQJ 7i9rHLVYYWS51RC11/8CJyRoAYhEw+ajoDzdKFQK+iuUyRiGtcj0MtAE79/fmgDXpyPE kS0EF70RpsRNiPEUnUNaomLRQJigHz7KI0ITQ+B2HJBzBUdkViOuNZxIs+2GVFNNCZNW zXDZrQkugJHs1tJKUucIdyO9Bc09YHcOgZq/GMomiP53pbRithI81CR2GfOuA/Ad2nld aWAdhO4yPixbG/qT4/mrbWIAFoV318k7CZVdUHK7xxnGDy4VFMw729V8I2DZ8D+OpJno ifgA== X-Gm-Message-State: AOAM532o5iKMcWcSgnmS6TlYxjckjBE+Rfl7RacWbVcZJrdbaDDuGdAK 8YUANjTaI+ArZFojMR3Llg0= X-Google-Smtp-Source: ABdhPJxiveloZuXk1qohEfW3J3ppqeiRlU36toY43ZTDEcj/plXMDPF5/yKgQS4CTNbzolVvjinN8w== X-Received: by 2002:a7b:c0d4:: with SMTP id s20mr1501455wmh.113.1642784258121; Fri, 21 Jan 2022 08:57:38 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id z1sm10203388wma.20.2022.01.21.08.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:57:37 -0800 (PST) Message-ID: <6dc75712f3ea1cfe12594e45ae977f8f4e8543fb.camel@gmail.com> Subject: Re: [PATCH] build-system: emacs: Add generation of -pkg.el files. From: Liliana Marie Prikler To: Andrew Tropin , 52388@debbugs.gnu.org Date: Fri, 21 Jan 2022 17:57:35 +0100 In-Reply-To: <87zgnp8f0n.fsf@trop.in> References: <871r2mrleb.fsf@trop.in> <80cfa468ef91649dce477779a70d3a8ce64fd0e4.camel@gmail.com> <87zgnp8f0n.fsf@trop.in> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52388 Cc: Ivan Sokolov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Andrew, Am Freitag, dem 21.01.2022 um 15:11 +0300 schrieb Andrew Tropin: > > As promised, I took a deeper look at your patch.  As already noted, > > there were some clean-up actions I had to perform, such as keeping > > to our line limit (it was not easy, I tell you) among other > > things.  Also, confusingly, your condition-case code did not handle > > errors and wrong handling of the version field blew up everything > > for me.  Did you test this code? > > I thought it was the version I used for past a few weeks, however I > could send a little outdated version, not the latest one by accident. > Tested it with guix build emacs-paredit. > > See your fix which wraps both forms in one let, thank you, yep, it's > very likely I sent an intermediate version of the patch > accidentially. Git index not up to date, truly a classic :) > > +           ;; before trying to create package-desc.  Otherwis the > > whole process > > s/Otherwis/Otherwise, Thanks. > > Applied on my local checkout of guix channel, list-packages now shows > 117 external packages =)  Will keep it for a while and let you know > if any problems will reveal themselves. Fair enough, I'll reset my "14 days without review" clock then :) From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 28 10:29:19 2022 Received: (at 52388) by debbugs.gnu.org; 28 Jan 2022 15:29:19 +0000 Received: from localhost ([127.0.0.1]:60241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDTBf-0005HI-BR for submit@debbugs.gnu.org; Fri, 28 Jan 2022 10:29:19 -0500 Received: from mail-lf1-f54.google.com ([209.85.167.54]:35417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDTBc-0005H2-VR for 52388@debbugs.gnu.org; Fri, 28 Jan 2022 10:29:17 -0500 Received: by mail-lf1-f54.google.com with SMTP id x11so12532297lfa.2 for <52388@debbugs.gnu.org>; Fri, 28 Jan 2022 07:29:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=wILeWRu4b2dBFxX3KUIJqitIXWi0hKUhePMng1llYjY=; b=j9olKjnLMULkFZu989JAo1JYX338vYyzfzRhkEOaB3ruONrXc/z66vJPA9sbEwsH6P isKjKdr8T/pcuptuXnasVUvPVIbzxyeECi7v4Hg3EF5tkakbD8DVwIsaxWMxgVngiLYv /qiFp4QeHUyInqsej1oTywGG08SpP8Dh8kkCke5Tpd0crq/694HNUafsIoc18jqTdRvK zxPXmetpyN0iifDiXmNHQxLAF3F4bO/YxtupswkzdqZ/0dEwGVjcmmuwZPcp1B6tI01c +u64D8cfbk7gcIUYX0ZtV2OplU+1W/3XXu3IFfcY3AEs+1eBpDIk94LFwtUIBzK2YH7h wHxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=wILeWRu4b2dBFxX3KUIJqitIXWi0hKUhePMng1llYjY=; b=7o9FlzgoVVBoS1qCY6oWlgckAQziHSb/4baapSmsrhqF3xTsn4e7WF0qyfsojcOdWo gtCdmcmZ+ZQBDiRt4CzGIDTIBhF5TRAs6DZUf8XOwbSAwb/kE/Mmgi7cVFVKMD3AYA5q X7toBPOmf313Z92xYXKl9N2zMRG46jyTvDYHKgrK+mHSS6SDHrvbo6uV+eFR62763iP0 P7+nqKY+AX5k9rtY9vlHSLBKJ7OEo1At0tTQ2Vn3pYEjyvMG7eWEgvvx8Gdu/3YQR9gR 8g2+xhydXpKP/R/5RAdSkLt9JF6JcmiawU7xwN59qRBn0PwZaK2QmkZ9Pcr9m3GpaDoM 1eeQ== X-Gm-Message-State: AOAM531NiS1M84nxzL5/Hi3JL1tp17iHzNtcMvk1GZ023oAyoF3QzJfJ yrkmHKWaB9DNRwcC3qwZdFnrpg== X-Google-Smtp-Source: ABdhPJzUeFrPoC5ScRbgJpRoxGeiOQHTNp7FmL05iqm1F63nAM6GDgbPpc1Xj7ztHhT+hLlicVW8nQ== X-Received: by 2002:a05:6512:96a:: with SMTP id v10mr6275555lft.497.1643383750870; Fri, 28 Jan 2022 07:29:10 -0800 (PST) Received: from localhost (109-252-135-33.dynamic.spd-mgts.ru. [109.252.135.33]) by smtp.gmail.com with ESMTPSA id c27sm2565218lfp.103.2022.01.28.07.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 07:29:09 -0800 (PST) From: Andrew Tropin To: Liliana Marie Prikler , 52388@debbugs.gnu.org Subject: Re: [PATCH] build-system: emacs: Add generation of -pkg.el files. In-Reply-To: <6dc75712f3ea1cfe12594e45ae977f8f4e8543fb.camel@gmail.com> References: <871r2mrleb.fsf@trop.in> <80cfa468ef91649dce477779a70d3a8ce64fd0e4.camel@gmail.com> <87zgnp8f0n.fsf@trop.in> <6dc75712f3ea1cfe12594e45ae977f8f4e8543fb.camel@gmail.com> Date: Fri, 28 Jan 2022 18:29:06 +0300 Message-ID: <8735l73mm5.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52388 Cc: Ivan Sokolov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-01-21 17:57, Liliana Marie Prikler wrote: > Hi Andrew, > > Am Freitag, dem 21.01.2022 um 15:11 +0300 schrieb Andrew Tropin: >> > As promised, I took a deeper look at your patch.=C2=A0 As already note= d, >> > there were some clean-up actions I had to perform, such as keeping >> > to our line limit (it was not easy, I tell you) among other >> > things.=C2=A0 Also, confusingly, your condition-case code did not hand= le >> > errors and wrong handling of the version field blew up everything >> > for me.=C2=A0 Did you test this code? >>=20 >> I thought it was the version I used for past a few weeks, however I >> could send a little outdated version, not the latest one by accident. >> Tested it with guix build emacs-paredit. >>=20 >> See your fix which wraps both forms in one let, thank you, yep, it's >> very likely I sent an intermediate version of the patch >> accidentially. > Git index not up to date, truly a classic :) > >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; befor= e trying to create package-desc.=C2=A0 Otherwis the >> > whole process >>=20 >> s/Otherwis/Otherwise, > Thanks. >>=20 > >> Applied on my local checkout of guix channel, list-packages now shows >> 117 external packages =3D)=C2=A0 Will keep it for a while and let you kn= ow >> if any problems will reveal themselves. > Fair enough, I'll reset my "14 days without review" clock then :) Have been using your version of the patch for a week now, added a few more emacs packages to my config, nothing stopped to build or launch, so it seems to work good. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmH0C8IPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6whk4P/3bkGQk6CdSoSO97J35+h2GOqaSYdGg30GG0 s2wF3h/rAq4AA7J/p4b2GI9lMQwpaD1NQ33sSb87p+2nrX8BIdk7WOxhKsBJXpis VzC74AY3IVQHWptKylHGcQIKCw+lfnaNqlSV4uoAqw6OVb4TrEa2q8AThqEcDKtL 0M9bZ5AqqN9wWlso2MVDLjjVgq8sbkBPCT/urvdgXJUGEXSRinbVjBDG5BupnRna 4CHR9C0oCcp/4bIyDOSf/wGlt7oQDGyk6G/AP+4txKCUgNOWgg47/yp+xR9krlJi WIKs+c4wUU8n50c7i4Qffzv2IlBPgi7XWF2ng1To3MLEkdcwsunEPScTnppg+aYZ JiDhhLQIpTBexIwZ0sf4hAPnGvnh8FFrijBIr/L3R4FWSHdAWRCB9/Q7LedQgOWq FyRGYkdGRIt8g2m6mqK2WX8t9fFA8HkT/VhfOrY0zBpHtzXpBiqbTMAVAwrB+I1g +jKRagq4FLlrAb37wlRTwIwtdc5bk//PMRLgQEQ9rfNO2ryeTRTylUFh3OE6F+QW Ge612QsnDMU1Zzg+waNds5QcEiiPPsXq45zdIo/jQZhWe5VwZTSFpjN5ANoX6x+1 SH/DWiMW20fx8ekgkWE9wzv6h6paLrqXjhJTaGQqwWM5CJpZyHBBWbx8TgH19moD pxjxLJwy =N5/i -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 29 02:53:50 2022 Received: (at 52388-done) by debbugs.gnu.org; 29 Jan 2022 07:53:50 +0000 Received: from localhost ([127.0.0.1]:60941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDiYQ-0007eE-0m for submit@debbugs.gnu.org; Sat, 29 Jan 2022 02:53:50 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:39725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDiYO-0007dz-3Q for 52388-done@debbugs.gnu.org; Sat, 29 Jan 2022 02:53:49 -0500 Received: by mail-wm1-f67.google.com with SMTP id o1-20020a1c4d01000000b0034d95625e1fso9740562wmh.4 for <52388-done@debbugs.gnu.org>; Fri, 28 Jan 2022 23:53:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=xUMclN7XCmdRKMlkY8uLrM4myvnOkPR8Ymk0eSh4nkU=; b=hD6JcZ/WtWupg+1Pxm9EzOw1Fm7vAWUinHaUAl6A0dgj8e6IpPNeWylOWd6gEclRP7 n86z8wQbi4r252YbfHLLlYd8Yv2g0a/de7DmWdNVX9W37QNO87RUzmMhg2HpxzU5JQ+v YppR2TAcLYKdnnWjPn1yz8sVbiWX01V8qfJOBOotpWT/f1fg57waN6m1jlcc8GqPYz8e cZ+5GSJF5r0Cr7ACxInXsNV9Ntk2F6+w+p5zLayKnUy8TPSRIUdcVgW56cdkdXyM5KJ8 85KUuxlryGFa4jBBimkvmySOyAlgmfj+T5mnU/D7n7RsD5UFJ37fr4FsA+NJfalEQ4CC 8TGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=xUMclN7XCmdRKMlkY8uLrM4myvnOkPR8Ymk0eSh4nkU=; b=zrw6h9YH2WouLlFkpydAzubwidpuFFWWnryHZvbYIPtG3lVsgQNqCXKAOiMjDwFMLI uZDITbW66k4Dcre2EabmkukmSpbViv6Lte24QBL52FDc0ts4s1DXyWCx62hEgeEBnsbT Q7Wa0H/dCt2ztHJvLDXCvnNpM20zd3vmNTxvHClGhDiSkwEW9t4EYnkMMPVEgw5VlNFN 3RnqB1X2McyQfN8D9iInt+Ns8WlhBY/xF8HscmNocyPbEIVDdMk2A/1t+mUkB7Uf42Sb /2yFCExnLZ1ylc0b/ZsAAoBZ/4JNbLwNi6XeGKVSXg8cCTF3qekaWnqh8LK+/oAlh1CB +UEg== X-Gm-Message-State: AOAM532xu8uvsoHysj1P6gSKSmFqEFd3IkBCODGmTs522lMkD/KA2i9G y7qYqnhVET7GCByEzNsjVEc= X-Google-Smtp-Source: ABdhPJwxBoyASqff7fZOqPH7YXzVQHuJEIuqXHY7oeGaIi3mkFlVRhhJ1IHhi7bj5JpMeRoQNa64jA== X-Received: by 2002:a05:600c:5c1:: with SMTP id p1mr10213497wmd.31.1643442822206; Fri, 28 Jan 2022 23:53:42 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id w9sm4095889wmc.36.2022.01.28.23.53.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 23:53:41 -0800 (PST) Message-ID: <70ef92949b1b9bd6543add18c53634e005e5260c.camel@gmail.com> Subject: Re: [PATCH] build-system: emacs: Add generation of -pkg.el files. From: Liliana Marie Prikler To: Andrew Tropin , 52388-done@debbugs.gnu.org Date: Sat, 29 Jan 2022 08:53:40 +0100 In-Reply-To: <8735l73mm5.fsf@trop.in> References: <871r2mrleb.fsf@trop.in> <80cfa468ef91649dce477779a70d3a8ce64fd0e4.camel@gmail.com> <87zgnp8f0n.fsf@trop.in> <6dc75712f3ea1cfe12594e45ae977f8f4e8543fb.camel@gmail.com> <8735l73mm5.fsf@trop.in> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52388-done Cc: Ivan Sokolov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Freitag, dem 28.01.2022 um 18:29 +0300 schrieb Andrew Tropin: > Have been using your version of the patch for a week now, added a few > more emacs packages to my config, nothing stopped to build or launch, > so it seems to work good. "Seems to work good" sounds good enough to me. Let's mark this bug as done :) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 31 12:18:49 2022 Received: (at 52388-done) by debbugs.gnu.org; 31 Jan 2022 17:18:49 +0000 Received: from localhost ([127.0.0.1]:40606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEaKH-0006zK-Hu for submit@debbugs.gnu.org; Mon, 31 Jan 2022 12:18:49 -0500 Received: from mail-lf1-f45.google.com ([209.85.167.45]:46058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEaKG-0006z2-Fo for 52388-done@debbugs.gnu.org; Mon, 31 Jan 2022 12:18:49 -0500 Received: by mail-lf1-f45.google.com with SMTP id o12so28231039lfg.12 for <52388-done@debbugs.gnu.org>; Mon, 31 Jan 2022 09:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=WlbbuYa641586sxGg5+D/vouVaJe7YAoeiHHRfRjgUs=; b=516sc9fp/Pqv99J4513m8T6kwhkKxsGYZLZo2Gpb0P0eCsRidCK1UW1B8DRBRsYTG1 VhnubkvL9HTzGds328TB2YYhwKunBINd189wvK9rtL67QEaSH8ZLId5L7g59Rvr4aX7m y3GJlQrKG4iBizG9t3Ttr6L3SyqJ8ovcuu0nFsr47rrJoEzaqc/a7uWEhjkVG6orRjKb VVqjsfmRGew+mmuKZg+lIV29UK37j4bpNRv7pBnJr3JNQPIB4srQFdE4+po93EgX/tgF GtrY3caOuD7F+9g/8waxz1fvDoEjIMYw1motqRBG7/uyp8PvoTyItiZ0eL73VZ68Q2NL 0VUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=WlbbuYa641586sxGg5+D/vouVaJe7YAoeiHHRfRjgUs=; b=pW7z0UIyFiGBfeZd7FgDzREQVMQI4dDik4YXIpGOS/YhL4vhTlqHFDzlslxm4jCaof APUe91BOeOoR6VKk/5mVwieZFO0nw/WocfFZ6a7zalFEo2G7w0Hv2cQoMk1cB75JxIWy hlWqbmg5w4bj1psZd3SpxfN7M55m/SPqoEAaxeJJPvrLl93d8byH0Y/47ZbSg5H6ut40 rmcWCiy1UdbQXz4lNcwo1oPtLajSCcUaevKIY6ue7yeSY8TG2c9HPEnE7+E/G6SeZWaZ Ym6QApnmDGl+Z9xD69nfX6xhRt4XFvD4eP/mVh4pQV58nAxRnIAWB9nVAZn1B2nieyee xBHQ== X-Gm-Message-State: AOAM531w54SSxjNORie0hATcwFPsHfig4XdtWbaBLf5faS8afrBxpXpe fMmjhQI+Keh1ac8HwsiNJoqL7Q== X-Google-Smtp-Source: ABdhPJxd+4rUceq0zQJuQU4Mztp6ptmxSPmHwLV2KhYwTwklPlzZpNOEPrqfk/4w0mg5qAHDcGlsmA== X-Received: by 2002:a05:6512:1599:: with SMTP id bp25mr16263214lfb.678.1643649522357; Mon, 31 Jan 2022 09:18:42 -0800 (PST) Received: from localhost (109-252-135-33.dynamic.spd-mgts.ru. [109.252.135.33]) by smtp.gmail.com with ESMTPSA id b18sm2900603lff.109.2022.01.31.09.18.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 09:18:41 -0800 (PST) From: Andrew Tropin To: Liliana Marie Prikler , 52388-done@debbugs.gnu.org Subject: Re: [PATCH] build-system: emacs: Add generation of -pkg.el files. In-Reply-To: <70ef92949b1b9bd6543add18c53634e005e5260c.camel@gmail.com> References: <871r2mrleb.fsf@trop.in> <80cfa468ef91649dce477779a70d3a8ce64fd0e4.camel@gmail.com> <87zgnp8f0n.fsf@trop.in> <6dc75712f3ea1cfe12594e45ae977f8f4e8543fb.camel@gmail.com> <8735l73mm5.fsf@trop.in> <70ef92949b1b9bd6543add18c53634e005e5260c.camel@gmail.com> Date: Mon, 31 Jan 2022 20:18:38 +0300 Message-ID: <87y22vygb5.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52388-done Cc: Ivan Sokolov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2022-01-29 08:53, Liliana Marie Prikler wrote: > Am Freitag, dem 28.01.2022 um 18:29 +0300 schrieb Andrew Tropin: >> Have been using your version of the patch for a week now, added a few >> more emacs packages to my config, nothing stopped to build or launch, >> so it seems to work good. > "Seems to work good" sounds good enough to me. Let's mark this bug as > done :) Yay! Thank you for helping with it! :) =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmH4Ge4PHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wjrYP/3q3Ytfc7pNzOcH0/atMxVIcfFjRMJPr5DIo omhrZEQLkz8d9J7rfQ7Mykknme8xBhNYbRqF+fR7e7AddvRkfgYLvVTvodoyLEkP qeXFUBuydcC3SRN+OPeIvFRpUXqc7cfxAbgcSqqaa5GH+pOq8hbSlkvpD6HheqsU 7QlEz+gq7gl9PeQdCUYtMF0JmblvcXNIN3kSeJ+M99P5cec3BypwUEJb18FVHZAk UvRvRJ/9E3A3sGASdtx5t8mtV6IrzOGELyGe5BUdsupr+0pu173xl4uYbLqLIa3c 95qHVqwR28IsTaX5MtTJVtu71msYe8syQ3h2bskN8ZlWPPLEorBVOM2/wAb91S3p ErrMvcJZx2AH9ya9ymDWmcPXrVpwg7CTnTkbPzHiLpAzeD6X65RIm3GarWqW1fgv Yt/ATtoc7v16+e/344BvC5dCerJq5/Cxf1R7hFkorqEMxjpVEEHRxd2IwvgKLI0U N8rn01XxHKBWV6BxmXLT/wKz+vnv9IjrV5y/nGclfh5S8sGq7Lascl053/FPTPBq cJSJ2nSyKK66GNLESNa6X+DdsEJV3n6mNbzQ6b7/yb7T9LgEI3q7uRMMjqp3crxK gOyLwIn1hV2Y2ijMBRFfgPqNpP+CZophsymzApLaQwUWfDkJwe5rIZth6ewX5SuV U9JhfO4l =aSk4 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 04:36:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 01 Mar 2022 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator