GNU bug report logs - #52387
[PATCH] Add cl-april.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52387 in the body.
You can then email your comments to 52387 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add cl-april.
Date: Thu, 9 Dec 2021 00:44:43 -0600

April is a subset of APL embedded in Common Lisp. The following series
of patches adds its dependencies and April itself to the end of
lisp-xyz.

This is the least trivial set of packages I have submitted, so I have
a few things I want to ensure I get right.
1. Licensing:
 a. cl-decimals has no license file and is marked as CC0-licensed in
its system file.
 b. simple-date-time has no license file and is marked as BSD-licensed
in its system file. I marked it as BSD-4.
 c. MaxPC is licensed under the AGPL. This is an issue for the
Apache-licensed April
(https://github.com/phantomics/april/issues/185), and an Apache
version of MaxPC is now bundled with April's source. Does building
April with MaxPC from source violate the AGPL? If so, the dependency
can be swapped out for the bundled one.
2. Bundling: April depends on two systems vex and aplesque. These are
defined in the same repository. I broke them out into three packages
based on the same version of the source.
 a. I renamed vex as there is an existing vector math library with
that name. I threw the math library into the patchset as well; It
might not properly belong.
 b. I tried to use the #:asd-files and #:asd-systems options to
restrict what got built, but kept getting build failures. I added a
phase to each package to delete unused system files. This works, but
seems brittle. I don't think I understand the ASDF build system.
3. Versioning: The latest April tag is a couple years old, while many
of its dependencies lack tags altogether. There is also a discrepancy
between the Git tag and the version numbers recorded in each system
file. Whether I wait for a new tag to bump the package or not, what's
the best way to version the package(s)?

Thanks much,

Jacob.

Message #8 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 1/7] gnu: Add cl-vex.
Date: Thu, 9 Dec 2021 00:47:43 -0600

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-cl-vex.patch (text/x-patch, attachment)]

Message #11 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 2/7] gnu: Add cl-maxpc.
Date: Thu, 9 Dec 2021 00:48:01 -0600

[Message part 1 (text/plain, inline)]

[0002-gnu-Add-cl-maxpc.patch (text/x-patch, attachment)]

Message #14 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 3/7] gnu: Add cl-vex-templates.
Date: Thu, 9 Dec 2021 00:48:22 -0600

[Message part 1 (text/plain, inline)]

[0003-gnu-Add-cl-vex-templates.patch (text/x-patch, attachment)]

Message #17 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 4/7] gnu: Add cl-aplesque.
Date: Thu, 9 Dec 2021 00:48:36 -0600

[Message part 1 (text/plain, inline)]

[0004-gnu-Add-cl-aplesque.patch (text/x-patch, attachment)]

Message #20 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 5/7] gnu: Add cl-decimals.
Date: Thu, 9 Dec 2021 00:48:49 -0600

[Message part 1 (text/plain, inline)]

[0005-gnu-Add-cl-decimals.patch (text/x-patch, attachment)]

Message #23 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 6/7] gnu: Add cl-simple-date-time.
Date: Thu, 9 Dec 2021 00:49:03 -0600

[Message part 1 (text/plain, inline)]

[0006-gnu-Add-cl-simple-date-time.patch (text/x-patch, attachment)]

Message #26 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 7/7] gnu: Add cl-april.
Date: Thu, 9 Dec 2021 00:49:17 -0600

[Message part 1 (text/plain, inline)]

[0007-gnu-Add-cl-april.patch (text/x-patch, attachment)]

Message #29 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Jacob MacDonald <jaccarmac <at> gmail.com>
Cc: 52387 <at> debbugs.gnu.org
Subject: Re: [bug#52387] [PATCH] Add cl-april.
Date: Sat, 11 Dec 2021 12:38:07 +0000

[Message part 1 (text/plain, inline)]

Jacob MacDonald <jaccarmac <at> gmail.com> skribis:

> April is a subset of APL embedded in Common Lisp. The following series
> of patches adds its dependencies and April itself to the end of
> lisp-xyz.
>
> This is the least trivial set of packages I have submitted, so I have
> a few things I want to ensure I get right.
> 1. Licensing:
>  a. cl-decimals has no license file and is marked as CC0-licensed in
> its system file.

Ok.


>  b. simple-date-time has no license file and is marked as BSD-licensed
> in its system file. I marked it as BSD-4.

Ok.


>  c. MaxPC is licensed under the AGPL. This is an issue for the
> Apache-licensed April
> (https://github.com/phantomics/april/issues/185), and an Apache
> version of MaxPC is now bundled with April's source. Does building
> April with MaxPC from source violate the AGPL? If so, the dependency
> can be swapped out for the bundled one.

According to [1] and [2], combining code under AGPL and code under
Apache License is possible, and the result would be under AGPL.
As the Guix package for April will only contain the things under Apache
License, I think we just need to use 'license:asl2.0'.
Unless the bundled MaxPC has modifications required for April to work,
you can add a snippet to the 'source' field to remove the "maxpc-apache"
directory, and use upstream's MaxPC.

[1] https://www.apache.org/licenses/GPL-compatibility.html
[2] https://opensource.stackexchange.com/questions/8270/can-i-use-apache-2-0-licensed-libraries-with-agpl-licensed-libraries


> 2. Bundling: April depends on two systems vex and aplesque. These are
> defined in the same repository. I broke them out into three packages
> based on the same version of the source.
>  a. I renamed vex as there is an existing vector math library with
> that name. I threw the math library into the patchset as well; It
> might not properly belong.
>  b. I tried to use the #:asd-files and #:asd-systems options to
> restrict what got built, but kept getting build failures. I added a
> phase to each package to delete unused system files. This works, but
> seems brittle. I don't think I understand the ASDF build system.

I don't think we need to make three packages in this case. Making just
one regular package for April should also build the vex and aplesque
subsystems automatically (if all the required dependencies are listed in
the 'inputs' field).


> 3. Versioning: The latest April tag is a couple years old, while many
> of its dependencies lack tags altogether. There is also a discrepancy
> between the Git tag and the version numbers recorded in each system
> file. Whether I wait for a new tag to bump the package or not, what's
> the best way to version the package(s)?

It pretty common for Common Lisp libraries not to have tags (or only
very old tags), and we then use the commit hash and a revision number.
There are many examples of such packages in "lisp-xyz.scm".

Could you send an updated patch series?

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 52387 <at> debbugs.gnu.org
Subject: Re: [bug#52387] [PATCH] Add cl-april.
Date: Mon, 13 Dec 2021 12:40:34 -0600

On Sat, Dec 11, 2021 at 7:14 AM Guillaume Le Vaillant <glv <at> posteo.net> wrote:
> Could you send an updated patch series?

Incoming.

> It pretty common for Common Lisp libraries not to have tags (or only
> very old tags), and we then use the commit hash and a revision number.
> There are many examples of such packages in "lisp-xyz.scm".

I followed that example as I understand it. The linter doesn't love it
because the latest tag is higher than the system version.

Message #35 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 1/5] gnu: Add cl-maxpc.
Date: Mon, 13 Dec 2021 12:41:07 -0600

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-cl-maxpc.patch (text/x-patch, attachment)]

Message #38 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 2/5] gnu: Add cl-random-state.
Date: Mon, 13 Dec 2021 12:41:32 -0600

[Message part 1 (text/plain, inline)]

[0002-gnu-Add-cl-random-state.patch (text/x-patch, attachment)]

Message #41 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 3/5] gnu: Add cl-decimals.
Date: Mon, 13 Dec 2021 12:41:48 -0600

[Message part 1 (text/plain, inline)]

[0003-gnu-Add-cl-decimals.patch (text/x-patch, attachment)]

Message #44 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 4/5] gnu: Add cl-simple-date-time.
Date: Mon, 13 Dec 2021 12:41:59 -0600

Message #47 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 5/5] gnu: Add cl-april.
Date: Mon, 13 Dec 2021 12:42:17 -0600

[Message part 1 (text/plain, inline)]

[0005-gnu-Add-cl-april.patch (text/x-patch, attachment)]

Message #50 received at 52387 <at> debbugs.gnu.org (full text, mbox):

From: Jacob MacDonald <jaccarmac <at> gmail.com>
To: 52387 <at> debbugs.gnu.org
Subject: [PATCH 4/5] gnu: Add cl-simple-date-time.
Date: Mon, 13 Dec 2021 12:44:30 -0600

[Message part 1 (text/plain, inline)]

[0004-gnu-Add-cl-simple-date-time.patch (text/x-patch, attachment)]

Message #55 received at 52387-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Jacob MacDonald <jaccarmac <at> gmail.com>
Cc: 52387-done <at> debbugs.gnu.org
Subject: Re: [bug#52387] [PATCH 5/5] gnu: Add cl-april.
Date: Thu, 16 Dec 2021 10:24:27 +0000

[Message part 1 (text/plain, inline)]

Patches pushed as abd2aed92681594251f11cf65db813767c9552af and following
with a few modifications (added copyright line, changed 'inputs' fields
to use the new style).
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.