GNU bug report logs - #52383
29.0.50; [suggestion] Add seq-set-subset-p to seq.el

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Marco Wahl <marcowahlsoft <at> gmail.com>
Cc: 52383 <at> debbugs.gnu.org
Subject: bug#52383: 29.0.50; [suggestion] Add seq-set-subset-p to seq.el
Date: Thu, 09 Dec 2021 22:29:53 +0200

>>> BTW function `seq-set-equal-p' could be rewritten using
>>> `seq-set-subset-p'.
>>
>> Isn't the word "set" redundant in the name?
>> In `seq-set-equal-p' the word "set" is needed
>> to say "is set equal".  But in `seq-set-subset-p'
>> the word "set" doesn't add much meaning, so better
>> would be to name your new function just `seq-subset-p'.
>
> Agreed.
>
> The motivation for the suggested name `seq-set-subset-p' was to stay
> close to the name `seq-set-equal-p'.  A user could interpret the prefix
> "seq-set" as hint that the function implements a set operation.

I guess the only reason why `seq-set-equal-p' has the prefix `seq-set-'
is because it would be too ambiguous without the prefix: `seq-equal-p'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.