From unknown Sat Jun 21 03:26:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52371 <52371@debbugs.gnu.org> To: bug#52371 <52371@debbugs.gnu.org> Subject: Status: [PATCH 0/2] Update tdlib and emacs-telega. Reply-To: bug#52371 <52371@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:26:40 +0000 retitle 52371 [PATCH 0/2] Update tdlib and emacs-telega. reassign 52371 guix-patches submitter 52371 Andrew Tropin severity 52371 normal tag 52371 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 08 04:28:15 2021 Received: (at submit) by debbugs.gnu.org; 8 Dec 2021 09:28:15 +0000 Received: from localhost ([127.0.0.1]:39559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mutFD-0003Kd-VH for submit@debbugs.gnu.org; Wed, 08 Dec 2021 04:28:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:56636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mutFC-0003KV-0r for submit@debbugs.gnu.org; Wed, 08 Dec 2021 04:28:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mutFA-00045d-00 for guix-patches@gnu.org; Wed, 08 Dec 2021 04:28:08 -0500 Received: from [2a00:1450:4864:20::232] (port=41812 helo=mail-lj1-x232.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mutF6-0007RW-SO for guix-patches@gnu.org; Wed, 08 Dec 2021 04:28:07 -0500 Received: by mail-lj1-x232.google.com with SMTP id bn20so2859419ljb.8 for ; Wed, 08 Dec 2021 01:27:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version; bh=f81FdLcyBsrNk0NRpYhWld3xCv9XUdw4ZoRSKkFW0KI=; b=39+N0MPW+Voy2AtcDEM1ilcw83zMxk5qMW4D4kBqlVV44p1oOCZp3cg+n0RbRqd0+N +Tqorp6bjajlkW8551arUdStaRdXFdzfkhpIBNs8/2JQWK7TOUflBcHF6tIQrddDAqoN GU6dTm0zqSPxISpIHS8CfVHEVrUCfTLr71IOdG/VYPKOgCNEccgYwgY3vAyVcTb46KCs PrNwRlV3eH+uWLjcnAwybzVlZ+hLlq+3DBIthuGsnCYObtray5V0isgezCv9nLTk6M5Y NdshKHKZEnCUhrRqMNVHmDsQNyustVIIbzAWPoctrHFuHvP4KlCu2e66InG9OjqhG93t Tfwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=f81FdLcyBsrNk0NRpYhWld3xCv9XUdw4ZoRSKkFW0KI=; b=IAAW0oDSQuF2Eq6QGjNKz8+ESG2a/CgK6X75zUbiqfySAINyX2mrD7r6FD3ZaDYxSU W68WaXPpU66HiO/ojIu8XySUBbOdHD2g2nPJL3ywkL4HRoRm3KgPW08CzPUBhyFvanAq O6xHWEoJj2v3Lj+4MmOUUOTj/msCxhunQkkNn9AAJFzZyvq1guUZ+I9oAcusw3S0Yjak vHiwCSU6OZC08nGhbswFRyjDCHalcCJrPe5mL8s8EHCU/My06viznB396wlMjfkRugNs uglq+mc/zEfxUo6ar0l9VMAlm8iA/nP8MxsJyS35UJoy9k7UFXUSEwKUz8uceDauAHpA tdFQ== X-Gm-Message-State: AOAM533ay8GE2Pk9abIfOKasXPF8ZUArJynUt5rGLWMfy7WryBYG6or3 bEdo518dF1iOZBXVcRX4DWbKGxqKMEpEcw== X-Google-Smtp-Source: ABdhPJz+wzbYLyNB1beWYZW/SyWyjaT6PLh4fQaOQNPYsyi4DDzi/l1J1GLVugr7BLlnSGPVlotpag== X-Received: by 2002:a2e:95d6:: with SMTP id y22mr48104404ljh.5.1638955678472; Wed, 08 Dec 2021 01:27:58 -0800 (PST) Received: from localhost (109-252-187-66.dynamic.spd-mgts.ru. [109.252.187.66]) by smtp.gmail.com with ESMTPSA id bp36sm229309lfb.0.2021.12.08.01.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Dec 2021 01:27:57 -0800 (PST) From: Andrew Tropin To: guix-patches@gnu.org Subject: [PATCH 0/2] Update tdlib and emacs-telega. Date: Wed, 08 Dec 2021 12:27:53 +0300 Message-ID: <875yrzh2ee.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::232 (failed) Received-SPF: none client-ip=2a00:1450:4864:20::232; envelope-from=andrew@trop.in; helo=mail-lj1-x232.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: zevlg@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable tdlib version 1.7.0 is deprecated and doesn't work anymore, there is no 1.7.9 tag in upstream repo, but the version is present in source code. https://github.com/tdlib/td/blob/858078d89fcd2ad1d9860547e3f87c49d0f9abe9/C= MakeLists.txt#L9 emacs-telega 0.7.031 is inteded for tdlib 1.7.0, but because this tdlib version doesn't work anymore, Evgeny (author of telega.el) suggest to use telega version from master branch. I used 0.7.15 tag (closest tag to the version in master branch I found) + revision + commit hash. Without those updates tdlib and all clients based on it doesn't work, it's quite unfortunate behavior from Telegram developers, IMHO of course, but it's necessary to update to non-tagged versions to get it work again. Andrew Tropin (2): gnu: tdlib: Update to 1.7.9-1.858078d. gnu: emacs-telega: Update to 0.7.15-1.acf2d99. gnu/packages/emacs-xyz.scm | 100 +++++++++--------- gnu/packages/messaging.scm | 80 +++++++------- .../emacs-telega-path-placeholder.patch | 49 ++++----- .../patches/emacs-telega-test-env.patch | 30 ++++-- 4 files changed, 134 insertions(+), 125 deletions(-) =2D-=20 2.34.0 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-tdlib-Update-to-1.7.9-1.858078d.patch Content-Transfer-Encoding: quoted-printable From=209a302410c4cc5ea09e656afdbce50e67127ddd9a Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Tue, 7 Dec 2021 14:15:32 +0300 Subject: [PATCH 1/2] gnu: tdlib: Update to 1.7.9-1.858078d. * gnu/packages/messaging.scm (tdlib): Update to 1.7.9-1.858078d. =2D-- gnu/packages/messaging.scm | 80 +++++++++++++++++++------------------- 1 file changed, 41 insertions(+), 39 deletions(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 4856df732e..3151ab0b3f 100644 =2D-- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -2648,48 +2648,50 @@ (define-public telegram-purple (license license:gpl2+))) =20 (define-public tdlib =2D (package =2D (name "tdlib") =2D (version "1.7.0") =2D (source (origin =2D (method git-fetch) =2D (uri (git-reference =2D (url "https://github.com/tdlib/td") =2D (commit (string-append "v" version)))) =2D (sha256 =2D (base32 =2D "0dfir57ljcn98mkg061c5642qb93wh2lm1n4nngpl3na9vvfk75i")) =2D (file-name (git-file-name name version)))) =2D (build-system cmake-build-system) =2D (arguments =2D `(#:tests? #t =2D #:configure-flags =2D (list "-DCMAKE_BUILD_TYPE=3DRelease" =2D "-DTD_ENABLE_LTO=3DOFF") ; FIXME: Get LTO to work. =2D #:phases =2D (modify-phases %standard-phases =2D (add-after 'unpack 'remove-failing-tests =2D (lambda _ =2D (substitute* "test/CMakeLists.txt" =2D ;; The test cases are compiled into a distinct binary =2D ;; which uses mtproto.cpp to attempt to connect to =2D ;; a remote server. Removing this file from the sources =2D ;; list disables those specific test cases. =2D (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") "")) =2D #t))))) =2D (native-inputs =2D `(("gperf" ,gperf) =2D ("openssl" ,openssl) =2D ("zlib" ,zlib) =2D ("php" ,php) =2D ("doxygen" ,doxygen))) =2D (synopsis "Cross-platform library for building Telegram clients") =2D (description "Tdlib is a cross-platform library for creating custom + (let ((commit "858078d89fcd2ad1d9860547e3f87c49d0f9abe9") + (revision "1")) + (package + (name "tdlib") + (version (git-version "1.7.9" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/tdlib/td") + (commit commit))) + (sha256 + (base32 + "1xwb2nb2ijdnz9q2v2mdaf7fsd2xzycxb3wmmf6dv63wl1h3hcwq")) + (file-name (git-file-name name version)))) + (build-system cmake-build-system) + (arguments + `(#:tests? #t + #:configure-flags + (list "-DCMAKE_BUILD_TYPE=3DRelease" + "-DTD_ENABLE_LTO=3DOFF") ; FIXME: Get LTO to work. + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'remove-failing-tests + (lambda _ + (substitute* "test/CMakeLists.txt" + ;; The test cases are compiled into a distinct b= inary + ;; which uses mtproto.cpp to attempt to connect = to + ;; a remote server. Removing this file from the = sources + ;; list disables those specific test cases. + (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp= ") "")) + #t))))) + (native-inputs + `(("gperf" ,gperf) + ("openssl" ,openssl) + ("zlib" ,zlib) + ("php" ,php) + ("doxygen" ,doxygen))) + (synopsis "Cross-platform library for building Telegram clients") + (description "Tdlib is a cross-platform library for creating custom Telegram clients following the official Telegram API. It can be easily us= ed from almost any programming language with a C-FFI and features first-class support for high performance Telegram Bot creation.") =2D (home-page "https://core.telegram.org/tdlib") =2D (license license:boost1.0))) + (home-page "https://core.telegram.org/tdlib") + (license license:boost1.0)))) =20 (define-public purple-mm-sms (package =2D-=20 2.34.0 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-gnu-emacs-telega-Update-to-0.7.15-1.acf2d99.patch Content-Transfer-Encoding: quoted-printable From=201e9d59573f7c6c76fb4f2e524d70a043b185a682 Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Tue, 7 Dec 2021 16:05:22 +0300 Subject: [PATCH 2/2] gnu: emacs-telega: Update to 0.7.15-1.acf2d99. * gnu/packages/emacs-xyz.scm (emacs-telega-server): Update to 0.7.15-1.acf2d99. * gnu/packages/patches/emacs-telega-path-placeholder.patch: Match patch with newer source code. * gnu/packages/patches/emacs-telega-test-env.patch: Match patch with newer source code. =2D-- gnu/packages/emacs-xyz.scm | 100 +++++++++--------- .../emacs-telega-path-placeholder.patch | 49 ++++----- .../patches/emacs-telega-test-env.patch | 30 ++++-- 3 files changed, 93 insertions(+), 86 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index e542da0c26..599790bc6e 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -27144,55 +27144,57 @@ (define-public emacs-helm-switch-to-repl (license license:gpl3+))) =20 (define-public emacs-telega-server =2D (package =2D (name "emacs-telega-server") =2D (version "0.7.031") =2D (source =2D (origin =2D (method git-fetch) =2D (uri (git-reference =2D (url "https://github.com/zevlg/telega.el") =2D (commit (string-append "v" version)))) =2D (sha256 =2D (base32 "05j82796s4k3yr0igl6hir3p8qj0cw66vvhbpbcy28d6q9v9vjjz")) =2D (file-name (git-file-name "emacs-telega" version)) =2D (patches =2D (search-patches "emacs-telega-path-placeholder.patch" =2D "emacs-telega-test-env.patch")))) =2D (build-system gnu-build-system) =2D (arguments =2D `(#:make-flags =2D (list (string-append "CC=3D" ,(cc-for-target)) =2D (string-append "INSTALL_PREFIX=3D" =2D (assoc-ref %outputs "out") "/bin")) =2D #:phases =2D (modify-phases %standard-phases =2D (add-before 'configure 'enter-subdirectory =2D (lambda _ (chdir "server") #t)) =2D (replace 'configure =2D (lambda* (#:key outputs #:allow-other-keys) =2D (let ((out (assoc-ref outputs "out"))) =2D (substitute* "run_tests.py" =2D (("^(TELEGA_SERVER =3D ).*$" _all prefix) =2D (string-append prefix =2D "\"" out "/bin/telega-server\"\n")))))) =2D (delete 'check) =2D (add-after 'install 'check =2D (assoc-ref %standard-phases 'check)) =2D (add-before 'install-license-files 'leave-subdirectory =2D (lambda _ (chdir "..") #t))) =2D #:test-target "test")) =2D (inputs =2D `(("tdlib" ,tdlib) =2D ("libappindicator" ,libappindicator))) =2D (native-inputs =2D `(("python" ,python) =2D ("pkg-config" ,pkg-config))) =2D (home-page "https://zevlg.github.io/telega.el/") =2D (synopsis "Server process of Telega") =2D (description "Telega-server is helper program to interact with Teleg= ram + (let ((commit "acf2d99df25f15c104cd13d5bbdcb17078a353f9") + (revision "1")) + (package + (name "emacs-telega-server") + (version (git-version "0.7.15" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/zevlg/telega.el") + (commit commit))) + (sha256 + (base32 "1wxx77whwl5fw2fbq6k7082gqn6srvy8vckhdn0qd75xqm4axf93")) + (file-name (git-file-name "emacs-telega" version)) + (patches + (search-patches "emacs-telega-path-placeholder.patch" + "emacs-telega-test-env.patch")))) + (build-system gnu-build-system) + (arguments + `(#:make-flags + (list (string-append "CC=3D" ,(cc-for-target)) + (string-append "INSTALL_PREFIX=3D" + (assoc-ref %outputs "out") "/bin")) + #:phases + (modify-phases %standard-phases + (add-before 'configure 'enter-subdirectory + (lambda _ (chdir "server") #t)) + (replace 'configure + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (substitute* "run_tests.py" + (("^(TELEGA_SERVER =3D ).*$" _all prefix) + (string-append prefix + "\"" out "/bin/telega-server\"\n")))))) + (delete 'check) + (add-after 'install 'check + (assoc-ref %standard-phases 'check)) + (add-before 'install-license-files 'leave-subdirectory + (lambda _ (chdir "..") #t))) + #:test-target "test")) + (inputs + `(("tdlib" ,tdlib) + ("libappindicator" ,libappindicator))) + (native-inputs + `(("python" ,python) + ("pkg-config" ,pkg-config))) + (home-page "https://zevlg.github.io/telega.el/") + (synopsis "Server process of Telega") + (description "Telega-server is helper program to interact with Teleg= ram service, and connect it with Emacs via inter-process communication.") =2D (license license:gpl3+))) + (license license:gpl3+)))) =20 (define-public emacs-telega (package @@ -27226,7 +27228,7 @@ (define-public emacs-telega "\"" ffmpeg-bin "\")")))))) (add-after 'unpack 'configure (lambda* (#:key inputs outputs #:allow-other-keys) =2D (substitute* "telega-server.el" + (substitute* "telega-customize.el" (("@TELEGA_SERVER_BIN@") (string-append (assoc-ref inputs "emacs-telega-server") "/bin/telega-server"))) diff --git a/gnu/packages/patches/emacs-telega-path-placeholder.patch b/gnu= /packages/patches/emacs-telega-path-placeholder.patch index c20be36712..5829edd22a 100644 =2D-- a/gnu/packages/patches/emacs-telega-path-placeholder.patch +++ b/gnu/packages/patches/emacs-telega-path-placeholder.patch @@ -1,36 +1,31 @@ =2DFrom 865b8c553722a971c68742c2e849e41eb0e2360c Mon Sep 17 00:00:00 2001 =2DFrom: Zhu Zihao =2DDate: Thu, 24 Jun 2021 23:43:50 +0800 =2DSubject: [PATCH] Replace code that search path with placeholder for =2D configuration. +From bf95de21faa623e48bca00d6a2c9b33ab2c5d812 Mon Sep 17 00:00:00 2001 +From: Andrew Tropin +Date: Wed, 8 Dec 2021 11:01:31 +0300 +Subject: [PATCH] Use absolute path for telega-server-command. =20 --- =2D telega-server.el | 6 +----- =2D telega-util.el | 2 +- =2D 2 files changed, 2 insertions(+), 6 deletions(-) + telega-customize.el | 2 +- + telega-util.el | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) =20 =2Ddiff --git a/telega-server.el b/telega-server.el =2Dindex 999125d..0fa0817 100644 =2D--- a/telega-server.el =2D+++ b/telega-server.el =2D@@ -142,11 +142,7 @@ Otherwise query user about building flags." =2D (defun telega-server--find-bin () =2D "Find telega-server executable. =2D Raise error if not found." =2D- (let ((exec-path (cons telega-directory exec-path))) =2D- (or (executable-find "telega-server") =2D- (progn (telega-server-build) =2D- (executable-find "telega-server")) =2D- (error "`telega-server' not found in exec-path")))) =2D+ "@TELEGA_SERVER_BIN@") +diff --git a/telega-customize.el b/telega-customize.el +index 0af343f..cc2938c 100644 +--- a/telega-customize.el ++++ b/telega-customize.el +@@ -591,7 +591,7 @@ In range [1..3]. Use 1." + :prefix "telega-server-" + :group 'telega) =20=20 =2D (defun telega-server-version () =2D "Return telega-server version." +-(defcustom telega-server-command "telega-server" ++(defcustom telega-server-command "@TELEGA_SERVER_BIN@" + "Command to run as telega server. + It should be absolute path or binary file searchable in `exec-path'." + :type 'string diff --git a/telega-util.el b/telega-util.el =2Dindex 73a46b1..f53e20a 100644 +index 6340c27..01e3cb7 100644 --- a/telega-util.el +++ b/telega-util.el =2D@@ -464,7 +464,7 @@ N can't be 0." +@@ -587,7 +587,7 @@ N can't be 0." =20=20 (defun telega-etc-file (filename) "Return absolute path to FILENAME from etc/ directory in telega." @@ -40,5 +35,5 @@ index 73a46b1..f53e20a 100644 (defun telega-link-props (link-type link-to &optional face) "Generate props for link button openable with `telega-link--button-acti= on'." --=20 =2D2.32.0 +2.34.0 =20 diff --git a/gnu/packages/patches/emacs-telega-test-env.patch b/gnu/package= s/patches/emacs-telega-test-env.patch index 75fe2e12fc..c6b02be6ff 100644 =2D-- a/gnu/packages/patches/emacs-telega-test-env.patch +++ b/gnu/packages/patches/emacs-telega-test-env.patch @@ -1,14 +1,24 @@ =2DTest Emacs environment on startup. +From 237ea2471bb6521390bbac174ac2a8a5e9683e4d Mon Sep 17 00:00:00 2001 +From: Andrew Tropin +Date: Tue, 7 Dec 2021 16:20:38 +0300 +Subject: [PATCH] Test Emacs environment on startup. =20 =2DPatch by Diego N. Barbato +--- + telega.el | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) =20 =2D--- a/telega.el 2020-02-07 17:07:18.549970090 +0100 =2D+++ b/telega.el 2020-02-07 17:10:08.383499765 +0100 =2D@@ -82,6 +82,7 @@ =2D "Start telegramming. =2D If prefix ARG is given, then will not pop to telega root buffer." +diff --git a/telega.el b/telega.el +index d6b28b5..40854ec 100644 +--- a/telega.el ++++ b/telega.el +@@ -181,7 +181,7 @@ can't write to `telega-server-logfile'" logfile-dir))) + Pop to root buffer. + If `\\[universal-argument]' is specified, then do not pop to root buffer." (interactive "P") +- + (telega-test-env t) =2D (telega--create-hier) =2D=20 =2D (unless (telega-server-live-p) + ;; For multiple accounts setup possibly select (if there is no + ;; default account declared) an account to use + (if (and telega-accounts (not (telega-account-current))) +--=20 +2.34.0 =2D-=20 2.34.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmGwepkPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wjIMQAJah1k1Xgd3fwqzWmXKAwMvXHElkdtP83Oj+ 3Fs+u5aoZx32L3e56b6lbZ8KsmLybwAkUkHHe6fSA+4QL+uPm3rRsZbcILGVN5Ut IUKklDz5r+gllP4Fiha2xM5FyYAMFv+VfJf+Ua61AwItjqhe45ApiqFGeyWaiU9L 7GCAnK17zJyMwwCWD+IVR4r0FN/QqbV0vBOs1qwOnTORj84Pdu9sd6KG1WjGOrbZ TUU6LWLOc8xTVEXWpxdJ/h+luc2FGZtdT+Lt/aWRyu9kgLHU3qdsU8QhI8gEscX2 YSBokrCKSjdKhdRPVHeD/KyN5uGXUm2sHrLXj2fHA6erA4di2bwh50Yey+jjm6sn Qnd9JEPUKuHgMQ26VsgUQXjGB3l2QJB51IVISWPu/FQ4y2frDK8BZOFuYL9Xj9J3 Jrt/ZEZ5Kvs1V5YHhRpk01RtF8OxR4uJSl+U+f66FRacDtlws6+mdp22dWJ0BLTV 8nOdrK104E9p3TqdzbGJJi/+pEypT0q7qlMkOo+7+9aaei96J2QxNFsHZ3nBqDNb xdKdck/TgKkdOUNDizaJhYC8YvP955esEMo3ilcBwNKLu8mZBq6dyRy36WYgKNWd TviKFVYzgnEr2PN5Sv8CYCmrhCyWRHVvPMChWOklj2RHUJX3n4+SS5vhDFv/2Sww V7XKJzk0 =hjtw -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 09 03:27:23 2021 Received: (at 52371) by debbugs.gnu.org; 9 Dec 2021 08:27:23 +0000 Received: from localhost ([127.0.0.1]:42403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvElu-0007PC-VG for submit@debbugs.gnu.org; Thu, 09 Dec 2021 03:27:23 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:42951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvElt-0007Ox-3g for 52371@debbugs.gnu.org; Thu, 09 Dec 2021 03:27:21 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A11DEFF80C; Thu, 9 Dec 2021 08:27:14 +0000 (UTC) From: Nicolas Goaziou To: Andrew Tropin Subject: Re: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega. References: <875yrzh2ee.fsf@trop.in> Date: Thu, 09 Dec 2021 09:27:13 +0100 In-Reply-To: <875yrzh2ee.fsf@trop.in> (Andrew Tropin's message of "Wed, 08 Dec 2021 12:27:53 +0300") Message-ID: <87bl1qtc7y.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52371 Cc: zevlg@yandex.ru, 52371@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Andrew Tropin writes: > tdlib version 1.7.0 is deprecated and doesn't work anymore, there is no > 1.7.9 tag in upstream repo, but the version is present in source code. > https://github.com/tdlib/td/blob/858078d89fcd2ad1d9860547e3f87c49d0f9abe9/CMakeLists.txt#L9 > > emacs-telega 0.7.031 is inteded for tdlib 1.7.0, but because this tdlib > version doesn't work anymore, Evgeny (author of telega.el) suggest to > use telega version from master branch. I used 0.7.15 tag (closest tag > to the version in master branch I found) + revision + commit hash. > > Without those updates tdlib and all clients based on it doesn't work, > it's quite unfortunate behavior from Telegram developers, IMHO of > course, but it's necessary to update to non-tagged versions to get it > work again. Thank you. Could you use commit a53cb30e99f937cfd64e0266fa558785a184a553 for tdlib. It corresponds to release 0.7.10 so you don't have to use revision and commit binding. Also, could you send this in two separate patches, and provide a proper commit message, specifying new patch files and registering them in local.mk? Also, you can remove trailing #t from phases. Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 09 05:23:39 2021 Received: (at 52371) by debbugs.gnu.org; 9 Dec 2021 10:23:39 +0000 Received: from localhost ([127.0.0.1]:42509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvGaR-0001ue-2A for submit@debbugs.gnu.org; Thu, 09 Dec 2021 05:23:39 -0500 Received: from mail-lj1-f169.google.com ([209.85.208.169]:33429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvF2B-0007qK-Tj for 52371@debbugs.gnu.org; Thu, 09 Dec 2021 03:44:12 -0500 Received: by mail-lj1-f169.google.com with SMTP id v15so7920180ljc.0 for <52371@debbugs.gnu.org>; Thu, 09 Dec 2021 00:44:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qi0BvRSiKkIjwoqjgLLfeAOi8P0XzOOuP3ZQCY9THEk=; b=bfz0HvVXwAy/JnyRphXlCqZZllAfbg+UJ+7VYdQRPfub1lZKa56gnbxINsyHbFpIx4 ePC29NwuD1jyq84llTf/lPQ3du8rVgjOPEIrgcuIopJJ45JFjnmnuoYmmfhsrq/RqHdJ /uPyAqGY7W+IJ1xqQxxIMDSHHwZd8zon4s3OU4LSOlEIz7nLaDzaDjKAUcck2mOGfndG A/aUPAMJTKH534i4yNjMQwexODv2vq2xiqPopvRCx+bjEZ7TMdcBIg4wh/kA2/0r560Y DYhyofpghUYFnyEYbyapg3VBGVbN1G8KU4SCbwuerTsiKVwSumH3d0T0rZhK/5L8YuNM dfqw== X-Gm-Message-State: AOAM531ew0xmVIoQJZ/FjvGC8MFs0BbT/18eytyFZ5B9KByeztpjJn3G 3t1uCz+N4pLPoz5/o9C/aTTbd8eyLDRmHw7eG0k= X-Google-Smtp-Source: ABdhPJyRqOhlXNbiplHtX1Sdt+ekle8QFfWsOPUXNkwAr55LW+IN7I+K5czLEebk57ctXMnB0h+O2zVmD+8s5XaPZ3c= X-Received: by 2002:a05:651c:106b:: with SMTP id y11mr4820232ljm.504.1639039445904; Thu, 09 Dec 2021 00:44:05 -0800 (PST) MIME-Version: 1.0 References: <875yrzh2ee.fsf@trop.in> <87bl1qtc7y.fsf@nicolasgoaziou.fr> In-Reply-To: <87bl1qtc7y.fsf@nicolasgoaziou.fr> From: Evgeny Zajcev Date: Thu, 9 Dec 2021 11:43:53 +0300 Message-ID: Subject: Re: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega. To: mail@nicolasgoaziou.fr Content-Type: multipart/alternative; boundary="000000000000f25e5b05d2b29b95" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 52371 X-Mailman-Approved-At: Thu, 09 Dec 2021 05:23:35 -0500 Cc: 52371@debbugs.gnu.org, Andrew Tropin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --000000000000f25e5b05d2b29b95 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D1=87=D1=82, 9 =D0=B4=D0=B5=D0=BA. 2021 =D0=B3. =D0=B2 11:27, Nicolas Goaz= iou : > Hello, > > Andrew Tropin writes: > > > tdlib version 1.7.0 is deprecated and doesn't work anymore, there is no > > 1.7.9 tag in upstream repo, but the version is present in source code. > > > https://github.com/tdlib/td/blob/858078d89fcd2ad1d9860547e3f87c49d0f9abe9= /CMakeLists.txt#L9 > > > > emacs-telega 0.7.031 is inteded for tdlib 1.7.0, but because this tdlib > > version doesn't work anymore, Evgeny (author of telega.el) suggest to > > use telega version from master branch. I used 0.7.15 tag (closest tag > > to the version in master branch I found) + revision + commit hash. > > > > Without those updates tdlib and all clients based on it doesn't work, > > it's quite unfortunate behavior from Telegram developers, IMHO of > > course, but it's necessary to update to non-tagged versions to get it > > work again. > > Thank you. > > Could you use commit a53cb30e99f937cfd64e0266fa558785a184a553 for tdlib. > It corresponds to release 0.7.10 so you don't have to use revision and > commit binding. > If TDLib 1.7.10 will be used, then use 3dfa0f0 for telega.el, this commit adds initial support for TDLib 1.7.10 TDLib 1.7.10 is not compatible with TDLib 1.7.9, and it won't work with telega without TDLib 1.7.10 support. --=20 lg --000000000000f25e5b05d2b29b95 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=D1=87=D1=82, 9 =D0=B4=D0=B5=D0=BA. 2021 = =D0=B3. =D0=B2 11:27, Nicolas Goaziou <mail@nicolasgoaziou.fr>:
Hello,

Andrew Tropin <andre= w@trop.in> writes:

> tdlib version 1.7.0 is deprecated and doesn't work anymore, there = is no
> 1.7.9 tag in upstream repo, but the version is present in source code.=
> http= s://github.com/tdlib/td/blob/858078d89fcd2ad1d9860547e3f87c49d0f9abe9/CMake= Lists.txt#L9
>
> emacs-telega 0.7.031 is inteded for tdlib 1.7.0, but because this tdli= b
> version doesn't work anymore, Evgeny (author of telega.el) suggest= to
> use telega version from master branch.=C2=A0 I used 0.7.15 tag (closes= t tag
> to the version in master branch I found) + revision + commit hash.
>
> Without those updates tdlib and all clients based on it doesn't wo= rk,
> it's quite unfortunate behavior from Telegram developers, IMHO of<= br> > course, but it's necessary to update to non-tagged versions to get= it
> work again.

Thank you.

Could you use commit a53cb30e99f937cfd64e0266fa558785a184a553 for tdlib. It corresponds to release 0.7.10 so you don't have to use revision and<= br> commit binding.

If TDLib 1.7.10 will be= used, then use 3dfa0f0 for telega.el, this commit adds initial support for= TDLib 1.7.10

TDLib 1.7.10 is not compatible with = TDLib 1.7.9, and it won't work with telega without TDLib 1.7.10 support= .

--
lg
--000000000000f25e5b05d2b29b95-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 09 06:43:52 2021 Received: (at 52371) by debbugs.gnu.org; 9 Dec 2021 11:43:52 +0000 Received: from localhost ([127.0.0.1]:42603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvHq4-00043t-9v for submit@debbugs.gnu.org; Thu, 09 Dec 2021 06:43:52 -0500 Received: from mail-ed1-f47.google.com ([209.85.208.47]:45601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvHq2-00043f-6X for 52371@debbugs.gnu.org; Thu, 09 Dec 2021 06:43:51 -0500 Received: by mail-ed1-f47.google.com with SMTP id y12so18341555eda.12 for <52371@debbugs.gnu.org>; Thu, 09 Dec 2021 03:43:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:mime-version:date :message-id; bh=v09I2QiUndFz8mitiWtS1V72Ed0oWulYZyRm2/wsEzI=; b=3f3nC4v80bHubqvQ2mbuWtVtLuXMPkI2H4pmzwUZz+9I/0oHHJJfF93QOugBjNm+F7 7H/Ei/Z86YmQnDrFsWJZ/87aoHyWi+8BNGm6U8KJwd70UvidSsfY4a3xy2ls6cGG0Oqa 9CyFUMlt5TNbI7wIK9RrBZX8uL0/krtJ6viIi8CwAAP4oFgPqYG+2P/ZNqHWXLv7SdIm BYOvIcEx0bau330Qguc3/HFmzeVVbNJncX3oaQxhIQA4Zj3au2VTMz3odQJCmkUFLuLi EJ5iXoM1jzyrTtFfj4aqwBZQneTt5HsI77YNlEPVPGunzeEDsbsGn4sn2GjHlEfZq6EB bdWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :mime-version:date:message-id; bh=v09I2QiUndFz8mitiWtS1V72Ed0oWulYZyRm2/wsEzI=; b=YBO8zkHtw8xEKvGQWpvp4OXhVVDSqHMb6AfHyfzRdDCbfR52X6bKYMsXwiS73iebb8 2is2PZmlO45EJxdsj11SX3RCszU1aXu8A+uXPobC0Mj+CGGME5Jc03HNzWCqSHrE94ZB UbV28wV2+zWWaDPjQa5b4UH9nMwB4vlaarePN/kJJCFIHqz/V7v42D6r9Ap//VHrYdJQ zpA6GgrUQ23cq9Z9pmpjLeQTnn22pPQWIi6HmNlfhgn5xxkAS/FK35Iq0Z18fCP/7l6K anNCsbiHSlKqPZL110YtO5owZVGpcc5EK0ifdsSZyhkyP2RnqzcfDhVZWVfhYn0XDWcj bhRA== X-Gm-Message-State: AOAM530TnFfBCyDXn1ZvMFlK5B3N+HB1ibt+tQv9bPBEjKKzMdIe54jS KjCyPtd70NIumJY0kqNtEwY10A== X-Google-Smtp-Source: ABdhPJyQOi8dmngSXw6dsvu4GDxg2dInxn6hTEGZ+KKvP2FLRKgbpeC3V71mwdkdceYLVx+bomGmZA== X-Received: by 2002:a17:907:d0b:: with SMTP id gn11mr14718392ejc.355.1639050223630; Thu, 09 Dec 2021 03:43:43 -0800 (PST) Received: from localhost (109-252-167-227.dynamic.spd-mgts.ru. [109.252.167.227]) by smtp.gmail.com with ESMTPSA id e4sm3024880ejs.13.2021.12.09.03.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 03:43:42 -0800 (PST) From: Andrew Tropin To: Nicolas Goaziou Subject: Re: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega. In-Reply-To: <87bl1qtc7y.fsf@nicolasgoaziou.fr> References: <875yrzh2ee.fsf@trop.in> <87bl1qtc7y.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Thu, 09 Dec 2021 14:43:39 +0300 Message-ID: <87lf0udmvo.fsf@trop.in> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52371 Cc: zevlg@yandex.ru, 52371@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2021-12-09 09:27, Nicolas Goaziou wrote: > Hello, > > Andrew Tropin writes: > >> tdlib version 1.7.0 is deprecated and doesn't work anymore, there is no >> 1.7.9 tag in upstream repo, but the version is present in source code. >> https://github.com/tdlib/td/blob/858078d89fcd2ad1d9860547e3f87c49d0f9abe= 9/CMakeLists.txt#L9 >> >> emacs-telega 0.7.031 is inteded for tdlib 1.7.0, but because this tdlib >> version doesn't work anymore, Evgeny (author of telega.el) suggest to >> use telega version from master branch. I used 0.7.15 tag (closest tag >> to the version in master branch I found) + revision + commit hash. >> >> Without those updates tdlib and all clients based on it doesn't work, >> it's quite unfortunate behavior from Telegram developers, IMHO of >> course, but it's necessary to update to non-tagged versions to get it >> work again. > > Thank you. > > Could you use commit a53cb30e99f937cfd64e0266fa558785a184a553 for tdlib. > It corresponds to release 1.7.10 so you don't have to use revision and > commit binding. Will do. > > Also, could you send this in two separate patches, and provide a proper > commit message, specifying new patch files and registering them in > local.mk? Not sure what you mean, there are already two inline patches with proper commit messages (at least I hope it's proper :). The patches for telegram.el are not new, so they already registered in local.mk, I just updated the content to match current source code. > > Also, you can remove trailing #t from phases. > > Could you send an updated patch? > > Regards, Yep. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmGx6+sPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6w3DsP/0KgLsrPgytkW3exF5hSFQpGPXiFOpdDjbr0 fwI84WwZ2kRoFRJX2a61TZgbBoF13bvVgQ2Dv5KXqHbkC0jKFyWymPAMUe+KFAAa KKmMCh4eBFmhnPpKwA6gg5Z7yW9Joi+vknq2d7hm0/z4QJLP4Vbjc28aQocuGtbJ nsv1p09NXzIY6XvBb9QJTa29AqUTcB5jahVkuMjr8jnG1vO44WJQ3N1DUhpYzVv7 FwcGyYFj6Bxbu6DPiTKM0qGp5Q4C2z/axIgugzuu1J+BqYr1cDntvbO4b9kc8cex pGRHDg2uuKfT+aNAm5QxYYd+620G1yhUgEZI06oKKWvgbJ4uDnWIm9xrXLqYCnmM iW51BwENzRZ3s/E47ZzA2E2UEwDOLpUGe403sWeHR+xvRFezRJ7MXsWpppW5S4xX 2GO9E1wevIJJLA/ks+vmSfCoZUwWFAQfWcKI/8uxtSqB22xDEY4dFeZAZ5nYW7XN mVI+Qgw27o+N5KRG3V/tlQcGSJy+XFkcqichv4mCMFq4ek6odI35WFiU6TrpNlr+ S72eFqI35LVYdWkasJWYZRJLglsuGue5Ca/4+vAPOmgBGmIpNHlYuzAtGGKXs0Dp GAgocX7rlu7xmp/QmAawKXI8RezOCHc8cCKdG5m5bwx+fAe/bQkqLhLcq+7yk2CC Fx8lHlyc =lKfP -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 09 10:37:05 2021 Received: (at 52371) by debbugs.gnu.org; 9 Dec 2021 15:37:05 +0000 Received: from localhost ([127.0.0.1]:44583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvLTk-0006Wf-FK for submit@debbugs.gnu.org; Thu, 09 Dec 2021 10:37:05 -0500 Received: from mail-ed1-f44.google.com ([209.85.208.44]:34601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvLTi-0006W7-4r for 52371@debbugs.gnu.org; Thu, 09 Dec 2021 10:37:03 -0500 Received: by mail-ed1-f44.google.com with SMTP id x15so21162007edv.1 for <52371@debbugs.gnu.org>; Thu, 09 Dec 2021 07:37:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=qRNGkgAq8hmmnQUO6VVq0/6V7QSbvpFsvIOHU5K/Szs=; b=NfMIJoD4zsGy1FNYs28W1QbsvbJdlf2HJe5h5Kg/YIBcH+CrhZYrFqJsx/eHy3v6G5 6wfgUIVRYOPvkUh6mZZ7Cz4QZN0ZvA1wDDr7THXAlsUmk+96U00a8emp/qFteV/Yd3XT U0ckKi/KW/Z4CH5d5H7USK4V9tDz5Nj9Igx4A5ka/mag0NFDrtHOJw3Tk4UxKsL+/v9y RHpwAlLeCIXcsByCQUnCz9jw/kqG6XfDkWQsl/VuSFYNOHt9WJg99B/G24isrR50bUuz yvB5PFeGcJkDZIjYe+/lg7uM8EkJe/sN6w0GHD6pVImSK5UgCf1NfQ7QsCytW+KXiHOA Vjiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=qRNGkgAq8hmmnQUO6VVq0/6V7QSbvpFsvIOHU5K/Szs=; b=BpCTpyE9z5eA3WYq5rVndwp7iDJsgVvx+b6ylerfXSjkU/sKU3f+VQznOpFDsMK8jD h106mRY9ocBRz3ZX+1p7skVldor6N38jczgE3sFpkakaqwPngZjyUnSnLtd6dM3vP/pR HUZQkHD6s1cG0Bufrwi+zoDb0GLCzWEAS0rlFQqbHrtXKbibuJ+gelaVfV5fJHioczPm xT8wBsGOPiFWV25T9f+j1NQmK/7qe1ETeuey5Qg3UUpfDznu2okEnid49PvWNzTe9AAw CAHLhTtSCrqw3SbvQvJfveBDQLPI11pgXt6lS00/qsvuzgeD7eDgJNtPQHRAZo2vNzl8 r/Mg== X-Gm-Message-State: AOAM5311jTbEOhfhcNuJU/ab5S0+BmAyApO5HmcjbvhAeBaTa6sheUxq vL5IWcU4GiwSxt0Kb0ZUgDNPyQ== X-Google-Smtp-Source: ABdhPJw0ifdT0lfxKYfINzUbFWN1LuC1IhCpdstakKlLx6d6YdNaoLT1V1ioJHGzk9W5ZWSzxPBQmg== X-Received: by 2002:aa7:c313:: with SMTP id l19mr29682864edq.209.1639064095999; Thu, 09 Dec 2021 07:34:55 -0800 (PST) Received: from localhost (109-252-167-227.dynamic.spd-mgts.ru. [109.252.167.227]) by smtp.gmail.com with ESMTPSA id sa17sm96475ejc.123.2021.12.09.07.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 07:34:55 -0800 (PST) From: Andrew Tropin To: Nicolas Goaziou Subject: Re: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega. In-Reply-To: <87bl1qtc7y.fsf@nicolasgoaziou.fr> References: <875yrzh2ee.fsf@trop.in> <87bl1qtc7y.fsf@nicolasgoaziou.fr> Date: Thu, 09 Dec 2021 18:34:50 +0300 Message-ID: <87k0gdg5b9.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52371 Cc: zevlg@yandex.ru, 52371@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain On 2021-12-09 09:27, Nicolas Goaziou wrote: > Hello, > > Andrew Tropin writes: > >> tdlib version 1.7.0 is deprecated and doesn't work anymore, there is no >> 1.7.9 tag in upstream repo, but the version is present in source code. >> https://github.com/tdlib/td/blob/858078d89fcd2ad1d9860547e3f87c49d0f9abe9/CMakeLists.txt#L9 >> >> emacs-telega 0.7.031 is inteded for tdlib 1.7.0, but because this tdlib >> version doesn't work anymore, Evgeny (author of telega.el) suggest to >> use telega version from master branch. I used 0.7.15 tag (closest tag >> to the version in master branch I found) + revision + commit hash. >> >> Without those updates tdlib and all clients based on it doesn't work, >> it's quite unfortunate behavior from Telegram developers, IMHO of >> course, but it's necessary to update to non-tagged versions to get it >> work again. > > Thank you. > > Could you use commit a53cb30e99f937cfd64e0266fa558785a184a553 for tdlib. > It corresponds to release 0.7.10 so you don't have to use revision and > commit binding. Updated tdlib and telega. > > Also, could you send this in two separate patches, and provide a proper > commit message, specifying new patch files and registering them in > local.mk? > > Also, you can remove trailing #t from phases. Removed. > > Could you send an updated patch? > > Regards, Attaching two patches. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-tdlib-Update-to-1.7.10.patch Content-Transfer-Encoding: quoted-printable From=202fdb921a278558bab3076805951d8131c7a2e780 Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Tue, 7 Dec 2021 14:15:32 +0300 Subject: [PATCH 1/2] gnu: tdlib: Update to 1.7.10. * gnu/packages/messaging.scm (tdlib): Update to 1.7.10. =2D-- gnu/packages/messaging.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 4856df732e..9f90dc94d0 100644 =2D-- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -2650,15 +2650,15 @@ (define-public telegram-purple (define-public tdlib (package (name "tdlib") =2D (version "1.7.0") + (version "1.7.10") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/tdlib/td") =2D (commit (string-append "v" version)))) + (commit "34ba9b21f365b8d3bdc36808c2d665ca5cd128f6"))) (sha256 (base32 =2D "0dfir57ljcn98mkg061c5642qb93wh2lm1n4nngpl3na9vvfk75i")) + "06fbdh1jypz0p1rf6xbpias4kx7xplq9xjd9vz177vwj9icq3wki")) (file-name (git-file-name name version)))) (build-system cmake-build-system) (arguments =2D-=20 2.34.0 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-gnu-emacs-telega-Update-to-0.7.15-1.b4a5e20.patch Content-Transfer-Encoding: quoted-printable From=2083d78a5f70351eeef7b7deb1edb96ed5cf2458cc Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Tue, 7 Dec 2021 16:05:22 +0300 Subject: [PATCH 2/2] gnu: emacs-telega: Update to 0.7.15-1.b4a5e20. * gnu/packages/emacs-xyz.scm (emacs-telega-server): Update to 0.7.15-1.b4a5e20. * gnu/packages/patches/emacs-telega-path-placeholder.patch: Match patch with newer source code. * gnu/packages/patches/emacs-telega-test-env.patch: Match patch with newer source code. =2D-- gnu/packages/emacs-xyz.scm | 100 +++++++++--------- .../emacs-telega-path-placeholder.patch | 49 ++++----- .../patches/emacs-telega-test-env.patch | 30 ++++-- 3 files changed, 93 insertions(+), 86 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index e542da0c26..52537b754e 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -27144,55 +27144,57 @@ (define-public emacs-helm-switch-to-repl (license license:gpl3+))) =20 (define-public emacs-telega-server =2D (package =2D (name "emacs-telega-server") =2D (version "0.7.031") =2D (source =2D (origin =2D (method git-fetch) =2D (uri (git-reference =2D (url "https://github.com/zevlg/telega.el") =2D (commit (string-append "v" version)))) =2D (sha256 =2D (base32 "05j82796s4k3yr0igl6hir3p8qj0cw66vvhbpbcy28d6q9v9vjjz")) =2D (file-name (git-file-name "emacs-telega" version)) =2D (patches =2D (search-patches "emacs-telega-path-placeholder.patch" =2D "emacs-telega-test-env.patch")))) =2D (build-system gnu-build-system) =2D (arguments =2D `(#:make-flags =2D (list (string-append "CC=3D" ,(cc-for-target)) =2D (string-append "INSTALL_PREFIX=3D" =2D (assoc-ref %outputs "out") "/bin")) =2D #:phases =2D (modify-phases %standard-phases =2D (add-before 'configure 'enter-subdirectory =2D (lambda _ (chdir "server") #t)) =2D (replace 'configure =2D (lambda* (#:key outputs #:allow-other-keys) =2D (let ((out (assoc-ref outputs "out"))) =2D (substitute* "run_tests.py" =2D (("^(TELEGA_SERVER =3D ).*$" _all prefix) =2D (string-append prefix =2D "\"" out "/bin/telega-server\"\n")))))) =2D (delete 'check) =2D (add-after 'install 'check =2D (assoc-ref %standard-phases 'check)) =2D (add-before 'install-license-files 'leave-subdirectory =2D (lambda _ (chdir "..") #t))) =2D #:test-target "test")) =2D (inputs =2D `(("tdlib" ,tdlib) =2D ("libappindicator" ,libappindicator))) =2D (native-inputs =2D `(("python" ,python) =2D ("pkg-config" ,pkg-config))) =2D (home-page "https://zevlg.github.io/telega.el/") =2D (synopsis "Server process of Telega") =2D (description "Telega-server is helper program to interact with Teleg= ram + (let ((commit "b4a5e206bd259f3d7f7633a725b2990704d6a1e8") + (revision "1")) + (package + (name "emacs-telega-server") + (version (git-version "0.7.15" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/zevlg/telega.el") + (commit commit))) + (sha256 + (base32 "0gr4nmpk175hxmj357bpzaqywbjc6dmmvfxnyzkh884vyzbwdxlc")) + (file-name (git-file-name "emacs-telega" version)) + (patches + (search-patches "emacs-telega-path-placeholder.patch" + "emacs-telega-test-env.patch")))) + (build-system gnu-build-system) + (arguments + `(#:make-flags + (list (string-append "CC=3D" ,(cc-for-target)) + (string-append "INSTALL_PREFIX=3D" + (assoc-ref %outputs "out") "/bin")) + #:phases + (modify-phases %standard-phases + (add-before 'configure 'enter-subdirectory + (lambda _ (chdir "server"))) + (replace 'configure + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (substitute* "run_tests.py" + (("^(TELEGA_SERVER =3D ).*$" _all prefix) + (string-append prefix + "\"" out "/bin/telega-server\"\n")))))) + (delete 'check) + (add-after 'install 'check + (assoc-ref %standard-phases 'check)) + (add-before 'install-license-files 'leave-subdirectory + (lambda _ (chdir "..")))) + #:test-target "test")) + (inputs + `(("tdlib" ,tdlib) + ("libappindicator" ,libappindicator))) + (native-inputs + `(("python" ,python) + ("pkg-config" ,pkg-config))) + (home-page "https://zevlg.github.io/telega.el/") + (synopsis "Server process of Telega") + (description "Telega-server is helper program to interact with Teleg= ram service, and connect it with Emacs via inter-process communication.") =2D (license license:gpl3+))) + (license license:gpl3+)))) =20 (define-public emacs-telega (package @@ -27226,7 +27228,7 @@ (define-public emacs-telega "\"" ffmpeg-bin "\")")))))) (add-after 'unpack 'configure (lambda* (#:key inputs outputs #:allow-other-keys) =2D (substitute* "telega-server.el" + (substitute* "telega-customize.el" (("@TELEGA_SERVER_BIN@") (string-append (assoc-ref inputs "emacs-telega-server") "/bin/telega-server"))) diff --git a/gnu/packages/patches/emacs-telega-path-placeholder.patch b/gnu= /packages/patches/emacs-telega-path-placeholder.patch index c20be36712..5829edd22a 100644 =2D-- a/gnu/packages/patches/emacs-telega-path-placeholder.patch +++ b/gnu/packages/patches/emacs-telega-path-placeholder.patch @@ -1,36 +1,31 @@ =2DFrom 865b8c553722a971c68742c2e849e41eb0e2360c Mon Sep 17 00:00:00 2001 =2DFrom: Zhu Zihao =2DDate: Thu, 24 Jun 2021 23:43:50 +0800 =2DSubject: [PATCH] Replace code that search path with placeholder for =2D configuration. +From bf95de21faa623e48bca00d6a2c9b33ab2c5d812 Mon Sep 17 00:00:00 2001 +From: Andrew Tropin +Date: Wed, 8 Dec 2021 11:01:31 +0300 +Subject: [PATCH] Use absolute path for telega-server-command. =20 --- =2D telega-server.el | 6 +----- =2D telega-util.el | 2 +- =2D 2 files changed, 2 insertions(+), 6 deletions(-) + telega-customize.el | 2 +- + telega-util.el | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) =20 =2Ddiff --git a/telega-server.el b/telega-server.el =2Dindex 999125d..0fa0817 100644 =2D--- a/telega-server.el =2D+++ b/telega-server.el =2D@@ -142,11 +142,7 @@ Otherwise query user about building flags." =2D (defun telega-server--find-bin () =2D "Find telega-server executable. =2D Raise error if not found." =2D- (let ((exec-path (cons telega-directory exec-path))) =2D- (or (executable-find "telega-server") =2D- (progn (telega-server-build) =2D- (executable-find "telega-server")) =2D- (error "`telega-server' not found in exec-path")))) =2D+ "@TELEGA_SERVER_BIN@") +diff --git a/telega-customize.el b/telega-customize.el +index 0af343f..cc2938c 100644 +--- a/telega-customize.el ++++ b/telega-customize.el +@@ -591,7 +591,7 @@ In range [1..3]. Use 1." + :prefix "telega-server-" + :group 'telega) =20=20 =2D (defun telega-server-version () =2D "Return telega-server version." +-(defcustom telega-server-command "telega-server" ++(defcustom telega-server-command "@TELEGA_SERVER_BIN@" + "Command to run as telega server. + It should be absolute path or binary file searchable in `exec-path'." + :type 'string diff --git a/telega-util.el b/telega-util.el =2Dindex 73a46b1..f53e20a 100644 +index 6340c27..01e3cb7 100644 --- a/telega-util.el +++ b/telega-util.el =2D@@ -464,7 +464,7 @@ N can't be 0." +@@ -587,7 +587,7 @@ N can't be 0." =20=20 (defun telega-etc-file (filename) "Return absolute path to FILENAME from etc/ directory in telega." @@ -40,5 +35,5 @@ index 73a46b1..f53e20a 100644 (defun telega-link-props (link-type link-to &optional face) "Generate props for link button openable with `telega-link--button-acti= on'." --=20 =2D2.32.0 +2.34.0 =20 diff --git a/gnu/packages/patches/emacs-telega-test-env.patch b/gnu/package= s/patches/emacs-telega-test-env.patch index 75fe2e12fc..c6b02be6ff 100644 =2D-- a/gnu/packages/patches/emacs-telega-test-env.patch +++ b/gnu/packages/patches/emacs-telega-test-env.patch @@ -1,14 +1,24 @@ =2DTest Emacs environment on startup. +From 237ea2471bb6521390bbac174ac2a8a5e9683e4d Mon Sep 17 00:00:00 2001 +From: Andrew Tropin +Date: Tue, 7 Dec 2021 16:20:38 +0300 +Subject: [PATCH] Test Emacs environment on startup. =20 =2DPatch by Diego N. Barbato +--- + telega.el | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) =20 =2D--- a/telega.el 2020-02-07 17:07:18.549970090 +0100 =2D+++ b/telega.el 2020-02-07 17:10:08.383499765 +0100 =2D@@ -82,6 +82,7 @@ =2D "Start telegramming. =2D If prefix ARG is given, then will not pop to telega root buffer." +diff --git a/telega.el b/telega.el +index d6b28b5..40854ec 100644 +--- a/telega.el ++++ b/telega.el +@@ -181,7 +181,7 @@ can't write to `telega-server-logfile'" logfile-dir))) + Pop to root buffer. + If `\\[universal-argument]' is specified, then do not pop to root buffer." (interactive "P") +- + (telega-test-env t) =2D (telega--create-hier) =2D=20 =2D (unless (telega-server-live-p) + ;; For multiple accounts setup possibly select (if there is no + ;; default account declared) an account to use + (if (and telega-accounts (not (telega-account-current))) +--=20 +2.34.0 =2D-=20 2.34.0 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 Best regards, Andrew Tropin --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmGyIhsPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wzvQQAJN66vdX00smBxK9zsNc8zgVXvdnzqCghAoy GXzJaq+JO4HTFbQZW4PUPXTm//iUXvoxy+lt/xcDR287hgKBUkh0xYYePv3g47Ia 8eO7m2vXFfIvEsZ6JFCTd20tBJeeDrTI9tbY697SCdfzTv2/YbnTtFc83exjhgjF 7999uRdgKZBO1v5L3QpJOqnUPUPNqUAPx9mALdpXKsrME+ldSaUC8JEaC/67dthj uWmbZV0XNpKSMRVZdT9jGpBrlc2Y05cdnRwto2UPNtxM3ipiySC/whGnnrZE01kE YQ3h9U11jLvmUjkiHs4+5pQU2F1mEsNqUpZwduB4kYrJIVquXrCL2lr1CRPoBRZx 1M2Gxx69mqgJs6TkjQO8aPGiONT/36ktGHJiM/M6pJlIYYuWP3/NUhSqoJcnzQ7R iqWuIiZuN2+edJm/kWWTGqDycDoVPzDnrcMcda5BiD7O73fAVD+BmsouyouNjUGf TIWW2u0hexQPT5gvBjVP1G0w8nSYjG7z+mBir3c/uyxR7XK0XHVF6MTP/PVFpFgb JQ+fGmG+hT0C2CYghD5uGLw6dP6hnzM/DyKAWloN7qKo5URo+zjEQAPz2ft8N+6+ lYcRD7J3+TguOLhEcLFmCjxgVIeholP3iOZfK7ZN9D1/gBQygnUX2xIDmOmLKQio PFJz/M7M =cgd3 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 09 14:39:46 2021 Received: (at 52371) by debbugs.gnu.org; 9 Dec 2021 19:39:46 +0000 Received: from localhost ([127.0.0.1]:44817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvPGb-00008Y-TN for submit@debbugs.gnu.org; Thu, 09 Dec 2021 14:39:46 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvPGa-00008M-Dc for 52371@debbugs.gnu.org; Thu, 09 Dec 2021 14:39:44 -0500 Received: by mail-wm1-f67.google.com with SMTP id i8-20020a7bc948000000b0030db7b70b6bso7406731wml.1 for <52371@debbugs.gnu.org>; Thu, 09 Dec 2021 11:39:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=2cLsQe9v8jiVcCyzEJYvmT7AfPBLt1oQHubOGRI8XnE=; b=N6qoBAlVKUEr8o5OMc+H/Nr8Ap2ud+uPlqmmKrkuwQ9lwUMGRgZiqKlrO54mBlkWDO SsIrsyeBmuKXoIY+a093Xy7cjDdlgjxj46U82uVaf8VQKisMN918l6uB0RCmSR2Gmd1j waFhj5ZRGDyaJSHWPL1uSS0B3aOHFVHnXTlZ+np1rq77TYg24Nk0Nhcul2ULy0a6oTY7 f0EcBqBfx2xJy+Skl8E/gn35UKF2xcckdOJm3Vu1P12hVhmLu4jUsXNmPDSm85CfE9sy mUaQsOOaBgYvBg1Xdo1SgzjcAXyMtdHm7ADd5r1Lf1dw9KnMfA5mj81pEfIuFLnLGiCl HFcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=2cLsQe9v8jiVcCyzEJYvmT7AfPBLt1oQHubOGRI8XnE=; b=JAvEsyktnveRTej4vaaSeK3pPWCrnk3VhgA+nBcfS7p6Vac8jgi9qJk5RaVKAvt/Ho Dc5O59KmZzrc8N4WndCLzeU/0eODI2yu4x6gTLKMhr/mVcvhid8XCqUP82BwAjl6kCI+ G7kbRIOS+9SXRmhIi0UzviKHPBc2Ci1ZkiiD6x2DVL9pKxBFSv65WKdRf2i9HUAjOzu8 4QDH4ghc4yK02PUTpt+JSpMOjZ+GXO3CJIp5xyhqIYp70jPYxWnVhpdqUTK7LK8q2TS6 F7/gnpZGmMCka+x2Kh8p9QHV78YDPulZ6JRwqdyEkXs1M4ksmMLaqKmGRlVlbgSMwJvp 2ksA== X-Gm-Message-State: AOAM531i2H4BUfayme3LMuLX0cm3SC9qyhHzEBq+4fJPaGvo6IIHI6CP Fk/66Cz2B4MFeDeUUQh4pFw= X-Google-Smtp-Source: ABdhPJx2YUI0WebaRxO+VIC19c+PCpAVszPjA6JhRJFs1L6f3Naqp2st7Virplz+iqla/2jgJY0Kvg== X-Received: by 2002:a05:600c:19cc:: with SMTP id u12mr10076121wmq.24.1639078778503; Thu, 09 Dec 2021 11:39:38 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id m1sm660909wme.39.2021.12.09.11.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 11:39:38 -0800 (PST) Message-ID: <6dfdd2d52bf2b52aa5022c4a085015ac535fccd6.camel@gmail.com> Subject: Re: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega. From: Liliana Marie Prikler To: Andrew Tropin , Nicolas Goaziou Date: Thu, 09 Dec 2021 20:39:36 +0100 In-Reply-To: <87k0gdg5b9.fsf@trop.in> References: <875yrzh2ee.fsf@trop.in> <87bl1qtc7y.fsf@nicolasgoaziou.fr> <87k0gdg5b9.fsf@trop.in> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52371 Cc: zevlg@yandex.ru, 52371@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, note to self: I'm not trying to build tdlib again. Last build was not finished after almost a day and power went out so I don't even know whether it succeeded after I went to work or not. Anyway, > +-(defcustom telega-server-command "telega-server" > ++(defcustom telega-server-command "@TELEGA_SERVER_BIN@" [...] > - (substitute* "telega-server.el" > + (substitute* "telega-customize.el" > (("@TELEGA_SERVER_BIN@") > (string-append (assoc-ref inputs "emacs-telega- > server") > "/bin/telega-server"))) > I know this has existed before your patch, but I'm pretty sure we have emacs-based routines that could make this substitution in one go. If you're interested in further janitor work, you could do this either on master, or you could do something in terms of (search-input-file) on c- u-f. Other than that LGTM on a quick glance. Cheers From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 10 02:40:38 2021 Received: (at 52371) by debbugs.gnu.org; 10 Dec 2021 07:40:38 +0000 Received: from localhost ([127.0.0.1]:45435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvaWE-00021v-6u for submit@debbugs.gnu.org; Fri, 10 Dec 2021 02:40:38 -0500 Received: from mail-ed1-f48.google.com ([209.85.208.48]:47066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvaWB-00021f-9y for 52371@debbugs.gnu.org; Fri, 10 Dec 2021 02:40:36 -0500 Received: by mail-ed1-f48.google.com with SMTP id y13so26748152edd.13 for <52371@debbugs.gnu.org>; Thu, 09 Dec 2021 23:40:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=bQks9XnDszdTNGvhsnD6KJaljUl3PnDz2Oq4qXqD79Y=; b=G4nrYLeO5SIklNYMW9nysNO6uht+dkfy/n0gRcIuYqpEs7U3x3Z1IWREzk3pOvs4UQ 07qbKcunmQlngco3wyIWlE6nqdFUF/doL6XqSNi6lziwHjvVkKCd5sLWP6NIrj+l0mk3 xETfniYMDv/YeKXTm5xRaLZt2t+3Ax/adF4ZMZcxMg6Tsj5dPtvROpgVwxjSoSPOzj/5 L3HzcYBevJtdg1giERgThZ2hXOYTAfq0zm8VcEk3oaHk3+cbdQmHgkrSmw540bTvtlhb VLzAYyCMoE9oAxatJ1XAfIQB9SE2ahT9oV0DO99k6g3UlqDZO65BaclSYHL1M6Na9Jap tnIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=bQks9XnDszdTNGvhsnD6KJaljUl3PnDz2Oq4qXqD79Y=; b=D1dCactFIVq+BHaL9Drsj6RGfim9FYxogD34zcyGMlb966dlZlAPw3nqq9N5wS9ReM YKyZk5NqJts00fa5gZsC6aJ6NmeXIZEPp7PArBIbgDWHX5L5Vj0pQrQbw2qLZ4F/bMfF NzygJK1qiAXgWALhVelxBKSrbdfcHIWykcdtbmn0lNSz+lVj3YnKxxog52zok7a+bRmO d9vcQspOZOnEQEbA2qf2zc/+N3AJ1A+ATA2z0s1SKcclAe59thOOLnkgxRYY/8bg7LaJ FSvsobah575Tk/eV5BdH81ojYFPTf8j0arGD/3Jxmon83MnxeKjtettf2c3TIpzLiyOQ Z6EA== X-Gm-Message-State: AOAM533A1bGYtS6HQYlAojlc5k9k75Wuso+ggyi7BQKh/Q91aiRQyDBP WX8s0DMy9zmJCe5ccP75bz9x4Q== X-Google-Smtp-Source: ABdhPJzr4oLqa1tyOknTXqw3tx+eR9mmpo4xgnegIqGVry78flUiuOFBjI0xiTJ5IIHSGQPY6xnIjQ== X-Received: by 2002:a17:907:72c9:: with SMTP id du9mr21675374ejc.37.1639122029289; Thu, 09 Dec 2021 23:40:29 -0800 (PST) Received: from localhost (109-252-167-227.dynamic.spd-mgts.ru. [109.252.167.227]) by smtp.gmail.com with ESMTPSA id hv13sm1030163ejc.75.2021.12.09.23.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 23:40:28 -0800 (PST) From: Andrew Tropin To: Liliana Marie Prikler , Nicolas Goaziou Subject: Re: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega. In-Reply-To: <6dfdd2d52bf2b52aa5022c4a085015ac535fccd6.camel@gmail.com> References: <875yrzh2ee.fsf@trop.in> <87bl1qtc7y.fsf@nicolasgoaziou.fr> <87k0gdg5b9.fsf@trop.in> <6dfdd2d52bf2b52aa5022c4a085015ac535fccd6.camel@gmail.com> Date: Fri, 10 Dec 2021 10:40:24 +0300 Message-ID: <878rwsj4bb.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52371 Cc: zevlg@yandex.ru, 52371@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2021-12-09 20:39, Liliana Marie Prikler wrote: > Hi, > > note to self: I'm not trying to build tdlib again. Last build was not > finished after almost a day and power went out so I don't even know > whether it succeeded after I went to work or not. Ouch, IIRC it took a few dozens of minutes for my laptop. Do you use underpowered hardware or something was wrong with compilation process? > > Anyway, > >> +-(defcustom telega-server-command "telega-server" >> ++(defcustom telega-server-command "@TELEGA_SERVER_BIN@" > [...] >> - (substitute* "telega-server.el" >> + (substitute* "telega-customize.el" >> (("@TELEGA_SERVER_BIN@") >> (string-append (assoc-ref inputs "emacs-telega- >> server") >> "/bin/telega-server"))) >>=20 > I know this has existed before your patch, but I'm pretty sure we have > emacs-based routines that could make this substitution in one go. Do you mean emacs-substitute-sexps from (guix build emacs-utils) ? > If you're interested in further janitor work, you could do this either > on master, or you could do something in terms of (search-input-file) > on c- u-f. > > Other than that LGTM on a quick glance. > Cheers > Let's keep it as it is right now, probably I'll be updating this package later again and will refactor it. Also, I'll need to update emacs-telega package to include add-pkg-file phase if the patch will be merged, so I'll cleanup the other stuff around it. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmGzBGgPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wwBYQAIvxweNrhAOhSMhdvkPoFGdMrryNJ5+rxR0c ohebTfxFcZCdiEBvDjgGhbH5jtU9bAuPYdKHG7VO8ltwTrxVwP74Wwwa+U6G/my3 jmQqdgdqgRKmGwkkcfNR0MphkMj53URlzlLHmA869X+oVujicYyF/KcFnCrzM8b3 8vNXhInfJwm3rDupJo+cBC/e4Himzd7Y7Gfq41T5xqcDgGy+T8hwPyl2+5ncmAbJ DKY+7YxbYh4AVQl2jyP3JrYG6fDG4U+Pug8+vT2iWWdbgLj5ACOVcjDkGBAA5Miu b/PqwwLR0PYLGqLBu/buWFrdRNAZj2/RMEW+c92ssQkbxDlc+Z1XFEIf6kbWJ7oD iGziiPH9+PRWbyp6Tkpq6bafw0dY0GTetxGgtFEtJX7tGa+eAR7JDotoe0+pKmaE pJZKkIdRtUneLqzSDQg5PIPbgTB9v7jRWQx4SwJJZw0uvwlLPwKCYbW6xkciytov GCTSmt6pS2A/eC9wLAEjAKsmqYVnTbH1j/kNGZP1sSwu1fDtxKgA63xV6sRtZnyE ucmkNlVykwbPo+JsDpAyzTu5WjZzljyMYRFeGmwlIrctnLY1V0KEvM73DgbMH8pk cGjJ/LJNHqn4tl2tQ+8cjoazPgHb41CkVTPRHrdwy6GZFYxHqP7TgJPARFbLGun9 lIGtqZWT =mSpL -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 10 14:31:36 2021 Received: (at 52371) by debbugs.gnu.org; 10 Dec 2021 19:31:36 +0000 Received: from localhost ([127.0.0.1]:47932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvlcG-0001Qw-8k for submit@debbugs.gnu.org; Fri, 10 Dec 2021 14:31:36 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvlcD-0001Qi-Ax for 52371@debbugs.gnu.org; Fri, 10 Dec 2021 14:31:35 -0500 Received: by mail-wm1-f68.google.com with SMTP id j140-20020a1c2392000000b003399ae48f58so9748683wmj.5 for <52371@debbugs.gnu.org>; Fri, 10 Dec 2021 11:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=sq8NswjlcSGwTpa5zppMI3dAO11QZy7Jz9796cmbkHY=; b=j7eIXRSHpogH0//qswwG7fSnH9ivzAW6WbJxY4o2sm5OGZBsRvFv+vrzY9GNBbcgHs JuVTNsDxiihbVYpPbXls5ORj9ZCliqGqpE306QCybe/13R9AP5RZjJBtMqNGVtbgsAYl b7I5lK3aLTdEWLO85xH8gF4MqZIL/+629mhx9ABvlqa6tf0QkG5Ot8MYaS7vY933xZue oyEC3Qryv9o2wus7WodTbb8Z3Cjb5Rl+11wzulSpWf8CvgDrI2HwyqmpGeX/fgU4gtG6 IOaER8XOk0EidBkIRbEgSvjBcYXkYCpMbAasbIEs5OY0or9PrGWG9qRdXA4kRL/yBhtZ +dUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=sq8NswjlcSGwTpa5zppMI3dAO11QZy7Jz9796cmbkHY=; b=ZmCl2L/WXp0E8twVx2Q1yTf6WGQ4/evc3lZ0uz+4FPg7vj3KxlwP/3km1WIDs6TsDy IFzghGXCZpgn6z4CMjR/AUXbmZonOtTMKrMmRp14RSsBnvmECtrfoBo4CrlkRxXGzVAq X8dY5X+qogagBZlgtSUwu7Dk+dWxHo4d4g2nQAkNAlvSqaDxepv9GLGQ6bTF125vFGoi dltm6wpPebPJPMHTbLPkw0Q1TYmfwIZ0iTwxB04TRm88mXF9Dw1UiP6IcuRpnsd/mSJs 7z3lu5bkZIY0ejvnZcNIx3Fgz9SWG/zPrwM6HcXvkAEdJiq4tvU2N8yjslcd2sRmQmy3 fhyA== X-Gm-Message-State: AOAM531NpSb5P8kuUBy2AlruBXf1FHs/0VtGoSsD0i3CY+JDFA/yK6Xi rfq3NT++cd74pKXkm7++XzN10JV0UaQ= X-Google-Smtp-Source: ABdhPJzybq1ge9YZvcq5XEXVGblnVFSORhUixQbDREwh/kXaXAX4IXcuUcyIctLr3J4NcGqKvIVofQ== X-Received: by 2002:a05:600c:29a:: with SMTP id 26mr19134841wmk.86.1639164687635; Fri, 10 Dec 2021 11:31:27 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a198sm3616975wmd.42.2021.12.10.11.31.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Dec 2021 11:31:27 -0800 (PST) Message-ID: Subject: Re: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega. From: Liliana Marie Prikler To: Andrew Tropin , Nicolas Goaziou Date: Fri, 10 Dec 2021 20:31:25 +0100 In-Reply-To: <878rwsj4bb.fsf@trop.in> References: <875yrzh2ee.fsf@trop.in> <87bl1qtc7y.fsf@nicolasgoaziou.fr> <87k0gdg5b9.fsf@trop.in> <6dfdd2d52bf2b52aa5022c4a085015ac535fccd6.camel@gmail.com> <878rwsj4bb.fsf@trop.in> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52371 Cc: zevlg@yandex.ru, 52371@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Freitag, den 10.12.2021, 10:40 +0300 schrieb Andrew Tropin: > On 2021-12-09 20:39, Liliana Marie Prikler wrote: > > > Hi, > > > > note to self: I'm not trying to build tdlib again. Last build was > > not finished after almost a day and power went out so I don't even > > know whether it succeeded after I went to work or not. > > Ouch, IIRC it took a few dozens of minutes for my laptop. Do you use > underpowered hardware or something was wrong with compilation > process? It's the check phase that's killing me, but that doesn't really rule out weak hardware. I'm not touching staging or core-updates for that very reason. > > Anyway, > > > > > +-(defcustom telega-server-command "telega-server" > > > ++(defcustom telega-server-command "@TELEGA_SERVER_BIN@" > > [...] > > > - (substitute* "telega-server.el" > > > + (substitute* "telega-customize.el" > > > (("@TELEGA_SERVER_BIN@") > > > (string-append (assoc-ref inputs "emacs-telega- > > > server") > > > "/bin/telega-server"))) > > > > > I know this has existed before your patch, but I'm pretty sure we > > have > > emacs-based routines that could make this substitution in one go. > > Do you mean emacs-substitute-sexps from (guix build emacs-utils) ? I think emacs-substitute-variables is the "correcter" option here, but both are fine. > > If you're interested in further janitor work, you could do this > > either on master, or you could do something in terms of (search- > > input-file) on c-u-f. > > > > Other than that LGTM on a quick glance. > > Cheers > > > > Let's keep it as it is right now, probably I'll be updating this > package later again and will refactor it. > > Also, I'll need to update emacs-telega package to include add-pkg- > file phase if the patch will be merged, so I'll cleanup the other > stuff around it. Very well, you do you. I'll leave the final call to Nicolas then. Thanks for your work and happy hacking :) From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 11 10:13:21 2021 Received: (at 52371-done) by debbugs.gnu.org; 11 Dec 2021 15:13:21 +0000 Received: from localhost ([127.0.0.1]:49877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw43s-0007qn-5j for submit@debbugs.gnu.org; Sat, 11 Dec 2021 10:13:21 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:58323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw43n-0007qV-5i for 52371-done@debbugs.gnu.org; Sat, 11 Dec 2021 10:13:19 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 016321C0006; Sat, 11 Dec 2021 15:13:07 +0000 (UTC) From: Nicolas Goaziou To: Andrew Tropin Subject: Re: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega. References: <875yrzh2ee.fsf@trop.in> <87bl1qtc7y.fsf@nicolasgoaziou.fr> <87k0gdg5b9.fsf@trop.in> <6dfdd2d52bf2b52aa5022c4a085015ac535fccd6.camel@gmail.com> <878rwsj4bb.fsf@trop.in> Date: Sat, 11 Dec 2021 16:13:07 +0100 In-Reply-To: <878rwsj4bb.fsf@trop.in> (Andrew Tropin's message of "Fri, 10 Dec 2021 10:40:24 +0300") Message-ID: <878rwrqinw.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52371-done Cc: 52371-done@debbugs.gnu.org, zevlg@yandex.ru, Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Andrew Tropin writes: > Let's keep it as it is right now, probably I'll be updating this package > later again and will refactor it. > > Also, I'll need to update emacs-telega package to include add-pkg-file > phase if the patch will be merged, so I'll cleanup the other stuff > around it. OK. Applied. Thank you. Regards, -- Nicolas Goaziou From unknown Sat Jun 21 03:26:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 09 Jan 2022 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator