From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 07 06:27:41 2021 Received: (at submit) by debbugs.gnu.org; 7 Dec 2021 11:27:42 +0000 Received: from localhost ([127.0.0.1]:36481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muYdJ-00066y-JC for submit@debbugs.gnu.org; Tue, 07 Dec 2021 06:27:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:37732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muYdG-00066p-9k for submit@debbugs.gnu.org; Tue, 07 Dec 2021 06:27:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muYdG-0008Jy-3R for bug-guix@gnu.org; Tue, 07 Dec 2021 06:27:38 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muYdE-0006Vv-2B for bug-guix@gnu.org; Tue, 07 Dec 2021 06:27:37 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1638876450; cv=none; d=zohomail.com; s=zohoarc; b=au3gH9kesCZ+8cFtpp3GJ0lxm+0TL4OsJJep8k3Sh8rZ2CbQW+vfyhWOpTF5aBm07Fzg2DKW29gFPgkbdJHE2OJq4QpcQxs6VctKs/7skjU6DWh1hqzH47LTToLfVyPgc1Hp3ZgbZCzX8AdyICsvSZ4FdR2f42ob0btl/5gK1C8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638876450; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To; bh=Nw7ETmt+OPFJ8HzlBlNyw8gj5qFDhFXA94hsgkGDTJQ=; b=bwrvWT3P3dangrzMtMHMcxsIgg0LzygjqV1o1BUIoM39eVhN9neueT+CDvXGwazU+lh9fPsJptRzRSJOrhArvvE22ehBOCZLfAYbVLxlVkxZBt9r+QahV1g3bjcC9Y/eHSFvemLDrkOqKCk/zl7Uvlmzgdwm/R2AsKrvtIBDK3g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1638876450; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=Nw7ETmt+OPFJ8HzlBlNyw8gj5qFDhFXA94hsgkGDTJQ=; b=hhF6TaDfLPyUAaO7lgnZFMgHE+emGwnhUnjBYoko1ywbGgSEg1NVQ6YzcE9NAfNy p1ZkbasCHwvNdD54CIKJ4h/sC8n2zhET5Wk86blEaJwWCoSxJaeaFn1ph3rRwq0QMFB NYyfGHD4MSYlBsXDo2GMUIseximBECx5h0s1S3FU= Received: from localhost (p54ad4c9a.dip0.t-ipconnect.de [84.173.76.154]) by mx.zohomail.com with SMTPS id 1638876449205638.5215320842925; Tue, 7 Dec 2021 03:27:29 -0800 (PST) User-agent: mu4e 1.6.6; emacs 27.2 From: Ricardo Wurmus To: bug-guix@gnu.org Subject: pypi import: ungraceful exit when recursively importing unknown package Date: Tue, 07 Dec 2021 11:26:17 +0000 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87ee6oven6.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@elephly.net; helo=sender4-of-o51.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When using the pypi importer, a typo in the package name leads to an ugly backtrace: --8<---------------cut here---------------start------------->8--- ./pre-inst-env guix import pypi -r pytestrerunfailures following redirection to `https://pypi.org/pypi/pytestrerunfailures/json/'.= .. Backtrace: In ice-9/boot-9.scm: 1752:10 9 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) In unknown file: 8 (apply-smob/0 #) In ice-9/boot-9.scm: 724:2 7 (call-with-prompt _ _ #) In ice-9/eval.scm: 619:8 6 (_ #(#(#))) In guix/ui.scm: 2206:7 5 (run-guix . _) 2169:10 4 (run-guix-command _ . _) In guix/scripts/import.scm: 124:11 3 (guix-import . _) In guix/scripts/import/pypi.scm: 96:18 2 (guix-import-pypi . _) In guix/import/utils.scm: 498:27 1 (recursive-import "pytestrerunfailures" #:repo->guix-package _= #:guix-name _ =E2=80=A6) 488:33 0 (lookup-node "pytestrerunfailures" #f) guix/import/utils.scm:488:33: In procedure lookup-node: Wrong number of values returned to continuation (expected 2) --8<---------------cut here---------------end--------------->8--- --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 07 08:20:40 2021 Received: (at 52350) by debbugs.gnu.org; 7 Dec 2021 13:20:40 +0000 Received: from localhost ([127.0.0.1]:36625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muaOe-00051D-Bz for submit@debbugs.gnu.org; Tue, 07 Dec 2021 08:20:40 -0500 Received: from mail-io1-f41.google.com ([209.85.166.41]:40817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muaOc-00050i-Gy for 52350@debbugs.gnu.org; Tue, 07 Dec 2021 08:20:39 -0500 Received: by mail-io1-f41.google.com with SMTP id p23so17044305iod.7 for <52350@debbugs.gnu.org>; Tue, 07 Dec 2021 05:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s6drRtg33OmmazRnnGp2yoIci35dNojQuXXINAuLtvU=; b=MPOrFUAQ2ZI13KKJSBLdhcig0JdeuHkD1obJ/BZ2zcQFxbFYsu8ri2iZjJrQWx8b44 4bUJA2U7Ii1jEKkdTv48hKnFRybDb+DbMX3vWRzLfAiNUAV5eP0ma6QdXUsq2TK2vBcv 43P+Dq4205zxHZDAFynDtPaC4RxAlrfbo4EHKc2iZY/e7Gnw6OZ5QfYu120wpu+ihVDZ djGxzszA0/Jf2EDcmCQn6Zds+yUDUx7alajBuyzRJRkUb/UMN9Fiw/gCyzIhj+wrS8KU snfdq7r61KqqlR9WQjS918DuNPlrlkFDJTLY/QUXGD7SrbGaKzu+OR7YQf97a4hxaohy pDMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s6drRtg33OmmazRnnGp2yoIci35dNojQuXXINAuLtvU=; b=5TVHq+Zx9aQADNmwfwzF/60N9/3WpvVZDKXBlP0FqYCRNidiUFhYUz3sUeuggd4jgk DayskCA7dpSo9IbekMRnXNbSWon1Kx/keDa5qXfhRgs3M5qVhGveLJF1Nnwd/5wDHBaN IOMYsKFVlfRoukZ/O5xNuyKAJK1hGStQcu5oev+z5dQQa9QKHOjc15PLEITXtCdiMSAx DmVZDHgvx9+6P5I6rWAaNtMGjUInDFS4Ewjdj1BkKpOJ6RkMSD2jTErUgDy8bOSWR6J1 29l5hlTWo8IG/xw/aMey43/tbOn/bsFQyuJFFFPqNQ+3DuElbZdsf/+cPznt5GjZr3Te etCQ== X-Gm-Message-State: AOAM530NuIJKN3Gfn8713yMTxRTt8AnyM2KudWP1cQg6YPaHHhUp/e0H B2AL3Y+6ikhKYM+JyTtmZah151dquOldaMKRxi4= X-Google-Smtp-Source: ABdhPJzrSGJzZHxLa0h/HfB0pj1SWDzA9XuUY6AGSE/bWB5jdmRUNqI/AAiRRtA1F4pYs4mnv22cwO9WZKAksSPVb5s= X-Received: by 2002:a05:6638:2647:: with SMTP id n7mr52162421jat.10.1638883232834; Tue, 07 Dec 2021 05:20:32 -0800 (PST) MIME-Version: 1.0 References: <87ee6oven6.fsf@elephly.net> In-Reply-To: <87ee6oven6.fsf@elephly.net> From: zimoun Date: Tue, 7 Dec 2021 14:20:21 +0100 Message-ID: Subject: Re: bug#52350: pypi import: ungraceful exit when recursively importing unknown package To: Ricardo Wurmus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52350 Cc: 52350@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ricardo, On Tue, 7 Dec 2021 at 12:28, Ricardo Wurmus wrote: > When using the pypi importer, a typo in the package name leads to an > ugly backtrace: This is already tracker by patch#45984. Well, the patch fixes the issue of "pypi" and other ones too (although some had probably been fixed independently, I have not checked or rebased this old patch). The patch had not been merged because we (with jeko) tried a pair-programming hacking session to revamp all the error handling. Well, we were not very far (not easy pair programming, remotely neither :-)). I do not have much time these days to concretely make this revamp. Maybe, the initial patch could be applied as a stopgap waiting a clean revamp. 1: Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 05:22:30 2022 Received: (at 52350) by debbugs.gnu.org; 8 Mar 2022 10:22:30 +0000 Received: from localhost ([127.0.0.1]:55347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRWz8-0001KO-68 for submit@debbugs.gnu.org; Tue, 08 Mar 2022 05:22:30 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:45786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRWz5-0001JT-73 for 52350@debbugs.gnu.org; Tue, 08 Mar 2022 05:22:27 -0500 Received: by mail-wr1-f48.google.com with SMTP id p9so27667427wra.12 for <52350@debbugs.gnu.org>; Tue, 08 Mar 2022 02:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=bo0APLzJDZQz3flzrU+QdtBuM6GLbPV0ZU/5YP/eNGs=; b=GD1+iaAhTwy9139MDSvy+oi1ydKbVXkhGMbnQqyB/bhpU7HbiK0eIYs4FwWaG/JrJf VJjzAFbQ8QF7dwwqAgiL7fkBkNKCnPfD6Cplo+tK3HliDwtcAGvkmJVCawV56XudHalM g8nj/nAKJY3HYIwERluqMFiLiUXFwQpnmmDHdxW4cZ84Ykngrp+JQgA+rRJQhzX48qU7 JeLlpBzy8Y9o6DgeV1vS1gFhN0kvADQ1IuXX2g49a3G1zLRLQHPmeYqQrM18pmVi6OIv bwbiKrIxCcYi/Y4Kdon2rmRcDivb40epiYwpgLylXzvHF5SGOvINkxON7ifTx3pBbgBb svrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=bo0APLzJDZQz3flzrU+QdtBuM6GLbPV0ZU/5YP/eNGs=; b=LnlbgWqVgiPNsLavFJBD9Qs79Yv9kYmN6sSUiXgZBUlg+TqnDFJTYC8ZmUf4PmWDB7 oriUCIGMKOLxWdeWLmNkG7+XAGokt1XnNLIQ/B859PspX6gmsmVHbM5AVagDQGub67Ac EYWDAKg/QkkBeUSTFaCBTjC47Qp9X2TKG03+AJkf3RGoazLLkdoSBzUu8VXM+3P9sp1Y NnRsHBXaypgQvnnKxfX4EKbW6kV3W7s99Nf0JQfmK0gxVmShyMkItJwl4uFcfF1dOqYp bdmRF5wfUxmhWcqYAy+miA+De49y4f0GSIWIuCkcum7lu4rWbTgo7/EsU4X9i4MCfzHs 0RpQ== X-Gm-Message-State: AOAM532SNakCC8Z5pAinHesxkhw/fuKNvtscyEHs4tJ/womR7YYOBO13 yjDZBFydU+dcHJ389PLcDoT8wA+UFX8= X-Google-Smtp-Source: ABdhPJzdpBgeVyQHXYNQ0e3iLbx3hqQjG0q0SZfNODguLRc3RapIXk7ZKsOvXWHzU02iAvnU1Iev/g== X-Received: by 2002:adf:ed03:0:b0:1f0:2f5a:48c2 with SMTP id a3-20020adfed03000000b001f02f5a48c2mr11918329wro.230.1646734941583; Tue, 08 Mar 2022 02:22:21 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id n15-20020a05600c4f8f00b003842f011bc5sm1931747wmq.2.2022.03.08.02.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 02:22:21 -0800 (PST) From: zimoun To: Ricardo Wurmus Subject: Re: bug#52350: pypi import: ungraceful exit when recursively importing unknown package References: <87ee6oven6.fsf@elephly.net> Date: Tue, 08 Mar 2022 11:09:45 +0100 In-Reply-To: <87ee6oven6.fsf@elephly.net> (Ricardo Wurmus's message of "Tue, 07 Dec 2021 11:26:17 +0000") Message-ID: <87h7884uxi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 52350 Cc: 52350@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ricardo, On mar., 07 d=C3=A9c. 2021 at 11:26, Ricardo Wurmus wr= ote: > ./pre-inst-env guix import pypi -r pytestrerunfailures --8<---------------cut here---------------start------------->8--- $ guix import pypi pytestrerunfailures following redirection to `https://pypi.org/pypi/pytestrerunfailures/json/'.= .. guix import: error: failed to download meta-data for package 'pytestrerunfa= ilures' $ guix import pypi pytestrerunfailures -r following redirection to `https://pypi.org/pypi/pytestrerunfailures/json/'.= .. --8<---------------cut here---------------end--------------->8--- Fixed by f7bb161445903c51d299307610403cb3de0fcc56, at least the ugly backtrace. However, it is still unsatisfactory since the error is not correctly handled. I propose to close because the exit is now graceful -- at least less ungraceful. :-) Cheers, simon