From unknown Thu Jun 19 14:04:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52335 <52335@debbugs.gnu.org> To: bug#52335 <52335@debbugs.gnu.org> Subject: Status: [PATCH 2/2] gnu: add package notcurses.scm Reply-To: bug#52335 <52335@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:04:49 +0000 retitle 52335 [PATCH 2/2] gnu: add package notcurses.scm reassign 52335 guix-patches submitter 52335 Blake Shaw severity 52335 normal tag 52335 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 06 14:00:31 2021 Received: (at submit) by debbugs.gnu.org; 6 Dec 2021 19:00:31 +0000 Received: from localhost ([127.0.0.1]:35419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muJDy-0003hx-O6 for submit@debbugs.gnu.org; Mon, 06 Dec 2021 14:00:31 -0500 Received: from lists.gnu.org ([209.51.188.17]:54472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muJDx-0003hq-WD for submit@debbugs.gnu.org; Mon, 06 Dec 2021 14:00:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muJDx-0001qx-M0 for guix-patches@gnu.org; Mon, 06 Dec 2021 14:00:29 -0500 Received: from [2001:41d0:2:aacc::] (port=53227 helo=out2.migadu.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muJDt-0006IJ-4A for guix-patches@gnu.org; Mon, 06 Dec 2021 14:00:29 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nonconstructivism.com; s=key1; t=1638817221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LUL8OCocBoLQ+ED/3VuS/ML5lkA7NhD09etCBMEBKJ8=; b=gP1fPl7xr8kplF5F64x2HGfu/BdMHAevbkrYb8Wsz+LGb3I6JpL58ScHRjhBJdc264g+Of +aHxGSBq+1H8UQtdiNF93UVyBKBFKOqDvnGm1sNJXdxSzxceTt/ExgnEBnY8yg2lm6Y+zQ AIaBqnSYJq+P1vFj4OeXjtM+/KywmXo= From: Blake Shaw To: guix-patches@gnu.org Subject: [PATCH 2/2] gnu: add package notcurses.scm Date: Tue, 7 Dec 2021 02:00:02 +0700 Message-Id: <1aa737a8cdcbe9c0e95052fd3187b059355f86f9.1638817174.git.blake@nonconstructivism.com> In-Reply-To: <5ccbd4e534f4f6fcfb3f8c8814ad59e51377cb7a.1638817174.git.blake@nonconstructivism.com> References: <5ccbd4e534f4f6fcfb3f8c8814ad59e51377cb7a.1638817174.git.blake@nonconstructivism.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: nonconstructivism.com X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:41d0:2:aacc:: (failed) Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=blake@nonconstructivism.com; helo=out2.migadu.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Blake Shaw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Signed-off-by: Blake Shaw --- gnu/packages/notcurses.scm | 73 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 gnu/packages/notcurses.scm diff --git a/gnu/packages/notcurses.scm b/gnu/packages/notcurses.scm new file mode 100644 index 0000000000..00e2fd92db --- /dev/null +++ b/gnu/packages/notcurses.scm @@ -0,0 +1,73 @@ +;;; Copyright © 2021 Blake Shaw +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages notcurses) + #:use-module (guix utils) + #:use-module (gnu packages) + #:use-module (guix packages) + #:use-module (guix build utils) + #:use-module (guix git-download) + #:use-module (guix build-system cmake) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (gnu packages gcc) + #:use-module (gnu packages video) + #:use-module (gnu packages ncurses) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages compression) + #:use-module (gnu packages libunistring) + #:use-module (ice-9 match)) + +(define-public notcurses + (package + (name "notcurses") + (version "3.0.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/dankamongmen/notcurses") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1y9s77m1pp6syfml559d8dvif61y6zjldrdx1zri18q9sr0zqm9m")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f + #:make-flags + (list ,(string-append "CC=" (cc-for-target)) + (string-append "prefix=")) + #:configure-flags + (map (lambda (s) + (string-append "-D" s)) + '("USE_CPP=off" "USE_COVERAGE=off" ;;here we set the default cmake + "USE_DOXYGEN=off" "USE_DOCTEST=off" ;;configuration. FSG=FSF approved only + "USE_GPM=off" "USE_MULTIMEDIA=ffmpeg" ;;other choices based on + "USE_PANDOC=off" "FSG_BUILD=ON")))) ;;reducing package footprint + (native-inputs + `(("gcc-toolchain" ,gcc) + ("ncurses" ,ncurses) + ("pkg-config" ,pkg-config))) + (inputs + `(("ffmpeg" ,ffmpeg) + ("libdeflate" ,libdeflate) + ("libunistring" ,libunistring) + ("zlib" ,zlib))) + (synopsis "Library facilitating complex textual user interfaces on modern terminals") + (description "Notcurses is a library for building complex +textual user interfaces on modern terminals. It does not use ncurses, while it does make use of libtinfo from that package.") + (home-page "https://notcurses.com/html/") + (license license:asl2.0))) -- 2.33.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 18:23:09 2021 Received: (at control) by debbugs.gnu.org; 21 Dec 2021 23:23:09 +0000 Received: from localhost ([127.0.0.1]:56171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzoTN-0002nI-Bv for submit@debbugs.gnu.org; Tue, 21 Dec 2021 18:23:09 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:51059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzoTI-0002mZ-Rp for control@debbugs.gnu.org; Tue, 21 Dec 2021 18:23:07 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 474D45C011A; Tue, 21 Dec 2021 18:22:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 21 Dec 2021 18:22:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:message-id:mime-version:content-type; s=mesmtp; bh=hDQHSR83oCFU1AwbnpuW+nEdiTfDVHJDr8ACfWte5lU=; b=QyFAbM/uC0Tj zgEU16tWhe3z3OrJzm7vkMfaUQfSjL1cBPFktplarIx22an1EXW8b6vPn/J/dVIN dmXjAlOXneFkeJE4ZcKotv/mvswukDRRdYKD5sdYyx7ghrJ7OTER2uIiqMl+Ifw+ Z3y3C+YydAVWCysqnZAJ8M28uDH0DsI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=hDQHSR83oCFU1AwbnpuW+nEdiTfDVHJDr8ACfWte5 lU=; b=nUwA3jBZIZJqIiFeYtGikKzgjr4LmtNBIBxPGwfP4p0e3d4ELzBDXIiuc iFYLrG8AQBZyW1xM9/HjLGbukOHdRvJ8BIp5PkYPvlEg3bTfF08fEvkmj0I1g5Kl yI8L0h285TbuZAKrjPpd76NGclJhC80+LY2F/5RX2OR9T56PJeSMrtDazyOlVL/a Be+cDyu2jFUEpuL5I9isdj2vvbLTRJHbvEIQmXT1mFVwRQzEfaNQWuxrzZTIYRId FgiBinRAF0UShI0YGjaCnkvT6Vfx/daoVWqtpXZYw6lAdUBKnl/nJEOBGnc3rZjj HmDx3fwuvmCgiP4E3dq5ZY6/S2ckA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddthedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucfgmhhpthihuchsuhgsjhgvtghtucdluddtmdenuc fjughrpeffhffvkfggtggusehttdertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhl rghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpe fhjeeigfefvedvfeetheegledtkeevuddtgedtudeiteehteegvdefffduffefffenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrg hmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 21 Dec 2021 18:22:58 -0500 (EST) Date: Tue, 21 Dec 2021 18:22:57 -0500 From: Leo Famulari To: control@debbugs.gnu.org Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 52335 52336 Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.29 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [66.111.4.29 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) merge 52335 52336 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 22:57:58 2021 Received: (at submit) by debbugs.gnu.org; 22 Dec 2021 03:57:59 +0000 Received: from localhost ([127.0.0.1]:56387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzslE-0003PR-6E for submit@debbugs.gnu.org; Tue, 21 Dec 2021 22:57:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:58288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzslB-0003PJ-V7 for submit@debbugs.gnu.org; Tue, 21 Dec 2021 22:57:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzslB-0004rR-GX for guix-patches@gnu.org; Tue, 21 Dec 2021 22:57:49 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:51921) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzsl8-0001gi-TH for guix-patches@gnu.org; Tue, 21 Dec 2021 22:57:49 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B2A103200E31; Tue, 21 Dec 2021 22:57:44 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 21 Dec 2021 22:57:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=rXBWUxm45K1qvkQHdqgfBgLW6EnoeIYoqBEmAFoY1gA=; b=j1ydLNPCMSj4 MVaEkxPaBUwdgdHtox89M11c5Kh3Z9Uvsy1cGJ+/zrRLpKDwmia96jYPWtXVEO08 uF9NFydlOJEbVpfdWQrWWMB+kUw06AVoJU1dtOhziBnGqLIAty4bA/WRLm7zMsH6 q13TqoOhhSNr3/qv3oLc+odxtDnpklo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=rXBWUxm45K1qvkQHdqgfBgLW6EnoeIYoqBEmAFoY1 gA=; b=enblke+lXD4hIVw0/j69RtbvXgQzY+pVL+r7oPrlY9EPOCZIgSQqCzw/K zMMxwY57BqxDgu7NuQc8s5x/DhtzgDrsySRZUFqHDZZp5gzH3HLmz55eg4oU/NOK fIPHgrQ296ZO+RLK0781uYMdrccIohDDfwypsMjVg9U/edw8JbSJFVsJew/7QGal DZ8iaYm5TsggU1sF7G/+gVf/5aEfmSVX8FGUdlhwBTfJRppfqLYHg3Z2mKVcfjt9 NvGALHyalj5loHFLR+4Njwth2QzicjozFd25ADXdn5j1XRX91bIRnchjyVZQyonH XW3rbCeCY3lIs/3OOE/juvURihBVQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddthedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesmhekreertddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepueehveekkedtffelhfduiefgtdeiudfhvdeitdeffeegteegveekhfevheeg gfdvnecuffhomhgrihhnpehnohhttghurhhsvghsrdgtohhmpdhgnhhurdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgr mhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Dec 2021 22:57:43 -0500 (EST) Date: Tue, 21 Dec 2021 22:57:41 -0500 From: Leo Famulari To: Blake Shaw via Guix-patches via Subject: Re: [bug#52335] [PATCH 2/2] gnu: add package notcurses.scm Message-ID: References: <5ccbd4e534f4f6fcfb3f8c8814ad59e51377cb7a.1638817174.git.blake@nonconstructivism.com> <1aa737a8cdcbe9c0e95052fd3187b059355f86f9.1638817174.git.blake@nonconstructivism.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="7y+wn1UHeP/CTo9K" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1aa737a8cdcbe9c0e95052fd3187b059355f86f9.1638817174.git.blake@nonconstructivism.com> Received-SPF: pass client-ip=64.147.123.25; envelope-from=leo@famulari.name; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Blake Shaw , 52335@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --7y+wn1UHeP/CTo9K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 07, 2021 at 02:00:02AM +0700, Blake Shaw via Guix-patches via wrote: > +(define-module (gnu packages notcurses) Thank you for this patch! As part of the review process, I made some changes locally, as shown in the diff below. I've also attached the complete revised patch, which includes indentation changes that are not shown in the diff. I did not include the indentation changes in the diff, so that it would be easier to show what has changed. I think the attached patch is more or less ready to push. Let me know what you think. ------ diff --git a/gnu/packages/notcurses.scm b/gnu/packages/notcurses.scm index 00e2fd92db..1fc176c27c 100644 --- a/gnu/packages/notcurses.scm +++ b/gnu/packages/notcurses.scm @@ -23,13 +23,13 @@ (define-module (gnu packages notcurses) #:use-module (guix git-download) #:use-module (guix build-system cmake) #:use-module ((guix licenses) #:prefix license:) - #:use-module (gnu packages gcc) + #:use-module (gnu packages check) + #:use-module (gnu packages haskell-xyz) #:use-module (gnu packages video) #:use-module (gnu packages ncurses) #:use-module (gnu packages pkg-config) #:use-module (gnu packages compression) - #:use-module (gnu packages libunistring) - #:use-module (ice-9 match)) + #:use-module (gnu packages libunistring)) (define-public notcurses (package @@ -46,28 +46,33 @@ (define-public notcurses (base32 "1y9s77m1pp6syfml559d8dvif61y6zjldrdx1zri18q9sr0zqm9m")))) (build-system cmake-build-system) (arguments - `(#:tests? #f - #:make-flags - (list ,(string-append "CC=" (cc-for-target)) - (string-append "prefix=")) - #:configure-flags - (map (lambda (s) - (string-append "-D" s)) - '("USE_CPP=off" "USE_COVERAGE=off" ;;here we set the default cmake - "USE_DOXYGEN=off" "USE_DOCTEST=off" ;;configuration. FSG=FSF approved only - "USE_GPM=off" "USE_MULTIMEDIA=ffmpeg" ;;other choices based on - "USE_PANDOC=off" "FSG_BUILD=ON")))) ;;reducing package footprint + `(#:make-flags + (list (string-append "CC=" ,(cc-for-target))) + ;; These flags are documented in 'INSTALL.md' in the source distribution. + #:configure-flags + '(;; Do not build "coverage" + "-DUSE_COVERAGE=off" + ;; Do not build HTML documentation + "-DUSE_DOXYGEN=off" + ;; Don't include mouse support + "-DUSE_GPM=off" + ;; Use FFmpeg for multimedia support + "-DUSE_MULTIMEDIA=ffmpeg" + ;; Follow the Debian Free Software Guidelines + ;; Yes, 'INSTALL.md' says that "OFF" means to omit non-free code. + "-DFSG_BUILD=OFF"))) (native-inputs - `(("gcc-toolchain" ,gcc) - ("ncurses" ,ncurses) - ("pkg-config" ,pkg-config))) + `(("pkg-config" ,pkg-config) + ("pandoc" ,pandoc) + ("doctest" ,doctest))) (inputs `(("ffmpeg" ,ffmpeg) ("libdeflate" ,libdeflate) ("libunistring" ,libunistring) + ("ncurses" ,ncurses) ("zlib" ,zlib))) - (synopsis "Library facilitating complex textual user interfaces on modern terminals") - (description "Notcurses is a library for building complex -textual user interfaces on modern terminals. It does not use ncurses, while it does make use of libtinfo from that package.") - (home-page "https://notcurses.com/html/") + (synopsis "Textual user interfaces") + (description "Notcurses is a library for building complex textual user +interfaces on modern terminals.") + (home-page "https://notcurses.com") (license license:asl2.0))) ------ Concretely, here are the changes that I made: I enabled the tests. We always run upstream test suites in Guix packages, unless there is a reason not to. This helps us validate that the package works properly, which helps us and upstream. This also means that I added a dependency on doctest. I removed the "prefix=" make flag. The package was installed correctly without it, so this change seems okay. I enabled building with C++. According to README.md, this implementation is more fully-featured, and in Guix we aim to provide fully-featured packages. I build the man pages with Pandoc. Guix packages should include documentation when it is available. This makes the package depend on Pandoc. Regarding DFSG_BUILD, I set it to "OFF". The notcurses INSTALL.md says this: "DFSG_BUILD=off: leave out all content considered non-free under the Debian Free Software Guidelines". That means that we want this to be OFF in order to follow the Debian guidelines. [0] Or is that incorrect? I also removed GCC from native-inputs. GCC is available "by default" with cmake-build-system. I moved the ncurses dependency to "inputs", because the built package does keep a run-time reference to it. You can consider native-inputs as things that only need to be used while building [1]. Based on feedback from `guix lint notcurses`, I edited the synopsis and description. Maybe the description could be longer. Please let me know what you think about the revised patch, and thanks again for contributing! [0] By the way, the DFSG is not equivalent to the FSDG, which is from the FSF and which we follow. They are certainly similar, but they are not related. [1] https://guix.gnu.org/manual/en/html_node/package-Reference.html --7y+wn1UHeP/CTo9K Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-Add-notcurses.patch" Content-Transfer-Encoding: 8bit >From c080b1a8a18f9091a0aa90cfaf05d239cde77cde Mon Sep 17 00:00:00 2001 From: Blake Shaw Date: Tue, 7 Dec 2021 02:00:01 +0700 Subject: [PATCH] gnu: Add notcurses. * gnu/packages/notcurses.scm: New file. * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. Signed-off-by: Leo Famulari --- gnu/local.mk | 1 + gnu/packages/notcurses.scm | 78 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 79 insertions(+) create mode 100644 gnu/packages/notcurses.scm diff --git a/gnu/local.mk b/gnu/local.mk index 72fa405e17..675775d620 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -425,6 +425,7 @@ GNU_SYSTEM_MODULES = \ %D%/packages/ninja.scm \ %D%/packages/node.scm \ %D%/packages/node-xyz.scm \ + %D%/packages/notcurses.scm \ %D%/packages/noweb.scm \ %D%/packages/nss.scm \ %D%/packages/ntp.scm \ diff --git a/gnu/packages/notcurses.scm b/gnu/packages/notcurses.scm new file mode 100644 index 0000000000..1fc176c27c --- /dev/null +++ b/gnu/packages/notcurses.scm @@ -0,0 +1,78 @@ +;;; Copyright © 2021 Blake Shaw +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages notcurses) + #:use-module (guix utils) + #:use-module (gnu packages) + #:use-module (guix packages) + #:use-module (guix build utils) + #:use-module (guix git-download) + #:use-module (guix build-system cmake) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (gnu packages check) + #:use-module (gnu packages haskell-xyz) + #:use-module (gnu packages video) + #:use-module (gnu packages ncurses) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages compression) + #:use-module (gnu packages libunistring)) + +(define-public notcurses + (package + (name "notcurses") + (version "3.0.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/dankamongmen/notcurses") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1y9s77m1pp6syfml559d8dvif61y6zjldrdx1zri18q9sr0zqm9m")))) + (build-system cmake-build-system) + (arguments + `(#:make-flags + (list (string-append "CC=" ,(cc-for-target))) + ;; These flags are documented in 'INSTALL.md' in the source distribution. + #:configure-flags + '(;; Do not build "coverage" + "-DUSE_COVERAGE=off" + ;; Do not build HTML documentation + "-DUSE_DOXYGEN=off" + ;; Don't include mouse support + "-DUSE_GPM=off" + ;; Use FFmpeg for multimedia support + "-DUSE_MULTIMEDIA=ffmpeg" + ;; Follow the Debian Free Software Guidelines + ;; Yes, 'INSTALL.md' says that "OFF" means to omit non-free code. + "-DFSG_BUILD=OFF"))) + (native-inputs + `(("pkg-config" ,pkg-config) + ("pandoc" ,pandoc) + ("doctest" ,doctest))) + (inputs + `(("ffmpeg" ,ffmpeg) + ("libdeflate" ,libdeflate) + ("libunistring" ,libunistring) + ("ncurses" ,ncurses) + ("zlib" ,zlib))) + (synopsis "Textual user interfaces") + (description "Notcurses is a library for building complex textual user +interfaces on modern terminals.") + (home-page "https://notcurses.com") + (license license:asl2.0))) -- 2.34.0 --7y+wn1UHeP/CTo9K-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 12:48:52 2021 Received: (at 52335) by debbugs.gnu.org; 29 Dec 2021 17:48:52 +0000 Received: from localhost ([127.0.0.1]:50286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2d4G-000315-H2 for submit@debbugs.gnu.org; Wed, 29 Dec 2021 12:48:52 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:34755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2d4E-00030r-Ca for 52335@debbugs.gnu.org; Wed, 29 Dec 2021 12:48:51 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 2BA7F32019B4; Wed, 29 Dec 2021 12:48:44 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 29 Dec 2021 12:48:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=1E8wOJSwKtSRyW3zHFxpDrkh BOI5zeCdEHGnTMWMXeM=; b=JCxhtRm1MO9rcy8VW4jp1rpJ9AjutRieZqJGysov KU/Qw+qUMW5dckLoXMCSurOEWUZAsxso4JvUNqJ5q8gGMM/KSipxwl8TeSlG54s1 Tz8k4ac0p8U5v8ooDv5JadIxs6zxRHabojpX1SQx+KecRpntnrQ7CoH3tGyeL7Dk +Rw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1E8wOJ SwKtSRyW3zHFxpDrkhBOI5zeCdEHGnTMWMXeM=; b=ZNwuyN36pyyPbJjdRnZUHD X55M8XpMw9wNtshAJd7+7ldwq8sqWl4EaEP5g48GyQKnqB60sb/QtIG1ywhcmarO JvnVQWbr0F6sO94hCDQphqcS3km54eWyioOEJLplJB6Q/Lz3VI4nQlNeCzJ+0W4o i2r7VJFi2WK0Nc/Dftgvt+slsCuZBN8RdiQwfPFfXcVKjlWtA5uOSBsRNnhd/zgg E6wzmEj7NyRKZtybcX3cQJyLdAQ9delWDayuOZIOD1WpE25m/nSUI5MIm9WBCKKQ PgP/sj8VbJ0dlPQ9diiiHuKQ8gVuruDo4NL5Nh6z+A3f1WFQ995I9PACR3pFrMwQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddvuddguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhephefgleevhfdttdefheeitdfgheffffffledvlefhgfektdethefguefgheeg tefhnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Dec 2021 12:48:43 -0500 (EST) Date: Wed, 29 Dec 2021 12:48:38 -0500 From: Leo Famulari To: Blake Shaw Subject: Re: [bug#52335] [PATCH 2/2] gnu: add package notcurses.scm Message-ID: References: <87k0fnwu47.fsf@nonconstructivism.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k0fnwu47.fsf@nonconstructivism.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52335 Cc: 52335@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, Dec 29, 2021 at 06:03:36PM +0700, Blake Shaw wrote: > Hi Leo, > > Sorry, I had missed your response and just found it when visiting Mumi. > > This is great feedback, and very informative for a new contributor. I > agree to all points, I had originally tried to keep the file size down > quite a bit, because with pandoc, c++, et al it nearly triples the > install size, and I couldn't quite figure out how to make those optional > as inputs. But if its best to provide a fully-featured over package over > a slimmed-down version, lets definitely go with that. Okay, thanks for letting me know. I found the use of DFSG_BUILD to be confusing, so I asked upstream: https://github.com/dankamongmen/notcurses/issues/2508 We can push the patch pending clarification of that. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 13:21:11 2021 Received: (at 52335-done) by debbugs.gnu.org; 29 Dec 2021 18:21:11 +0000 Received: from localhost ([127.0.0.1]:50325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2dZX-0003yD-32 for submit@debbugs.gnu.org; Wed, 29 Dec 2021 13:21:11 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2dZV-0003xs-5p for 52335-done@debbugs.gnu.org; Wed, 29 Dec 2021 13:21:10 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 12FCD5C00CA; Wed, 29 Dec 2021 13:21:02 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 29 Dec 2021 13:21:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=vEudo0IpETd7wXdjFigHIIRe 3VyyhOprvY5juzmePps=; b=O0kK5fWMTFvCx1Ta7jhSRKzud+Xv14ZlEDzu903p qTEtWjB7FV5J2U2+h+vUU5xTzJetAHurUHfLycLdAOwnGl4PPS7laK8AF3bOKoge +wybvPDS3i/Rr0XeA2g+EXE+A6szbqcmNFdJjPVGN7Y5XztE7SaZn35Jpcynr9UL 95I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=vEudo0 IpETd7wXdjFigHIIRe3VyyhOprvY5juzmePps=; b=kx2BsOqcG90lyzJV8ijHcp 9lYDnjlh9edSgaQcIZDg3E20bL8nv159F4iwc88LO9fWMkwpTmiX+sW8CVYSj/oA Nerv0FumUcZTFypSEwNfBWXaV73uUEfHKkC00v/8QFIVXqlCP+pKhv1Pj+nOBlCY qwzHlf20MWzQd7XhAhdec/BGqBVUneMOLSvM/TaQZAQLdP9/fXyc4OCKjEPypqKH 2nT65frt9KHWoq/l6s8qXl6a83OXp+B9kSgA5wmul8M9C10SpaxTlD/GOq7QS7ia h7lTdYjenEF2+W0NmOZW9vi53W3DQJEMybgDbMmLV4pPZcrkiRomd6eG3hGJKXwQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddvuddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtrodttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepkedvhfeguedvlefhudeivefhkeeuudevudefjeegjefgtdetvdffgeehtdei leegnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpghhnuhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhl rghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Dec 2021 13:21:01 -0500 (EST) Date: Wed, 29 Dec 2021 13:20:59 -0500 From: Leo Famulari To: Blake Shaw Subject: Re: [bug#52335] [PATCH 2/2] gnu: add package notcurses.scm Message-ID: References: <87k0fnwu47.fsf@nonconstructivism.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52335-done Cc: 52335-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, Dec 29, 2021 at 12:48:38PM -0500, Leo Famulari wrote: > I found the use of DFSG_BUILD to be confusing, so I asked upstream: > > https://github.com/dankamongmen/notcurses/issues/2508 They helpfully clarified that we want this option to be ON. So, I've done that, partially migrated the package to the "new style" [0], and pushed as 7022eb6ea0f3be2f0eb58617c607ce34dfbff90a. Thanks a lot for the contribution! [0] I only changed the inputs to the new style. Changing the package's arguments field is future work. https://guix.gnu.org/en/blog/2021/the-big-change/ From unknown Thu Jun 19 14:04:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 27 Jan 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator