From unknown Fri Aug 15 16:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52315: [PATH] Improve documentation of info-menu-star Resent-From: Y. E. Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 19:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 52315@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: "Y. E." Received: via spool by submit@debbugs.gnu.org id=B.16387318799078 (code B ref -1); Sun, 05 Dec 2021 19:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Dec 2021 19:17:59 +0000 Received: from localhost ([127.0.0.1]:59476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtx1L-0002ML-5I for submit@debbugs.gnu.org; Sun, 05 Dec 2021 14:17:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:43588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtx1J-0002ME-Ps for submit@debbugs.gnu.org; Sun, 05 Dec 2021 14:17:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtx1I-0000nC-4G for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 14:17:57 -0500 Received: from out2.migadu.com ([188.165.223.204]:15348) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtx1D-00052P-EX for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 14:17:54 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ego.team; s=key1; t=1638731866; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type; bh=kS2al0RCRHmvaNSvygUwDwJmj8tWP+fhIDCEfHTcipw=; b=HFDDIobFMPGjFDf6PhUWtnFtpbylZlEDM4WRvG+Xcg7KWTRbyriXsxco4lq1j+eMr5sQaX uKR0gUKnP2myzPBKORWnuAwkNrTUlXhdAbr4YmwYzOmh6rijOR3wNkxQiNa6YQDD3ezpnP 77HsPdmSkySae6uK7S8hQ4XuXQ4PmFY= From: Y. E. Date: Sun, 05 Dec 2021 21:17:44 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: ego.team Received-SPF: pass client-ip=188.165.223.204; envelope-from=yet@ego.team; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch Hello, I'm sending two alternate patches to improve the docstring of info-menu-star. Either of them looks sufficiently fine to me. But one of them might better suit Emacs' style. The current docstring doesn't provide enough information on info-menu-star, leaving open the question: why "every third `*' in an Info menu" is so special? Also, "every third" isn't a correct description, since only 1..9 numbers/items are used for navigation (and highlighted accordingly). --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-lisp-info.el-info-menu-star-Improve-documentation.patch Content-Description: Alternate docstring update >From f3d6948f6287411f1a151b69bc19fbfc7f5384e8 Mon Sep 17 00:00:00 2001 From: YugaEgo Date: Sun, 5 Dec 2021 19:59:29 +0200 Subject: [PATCH] * lisp/info.el (info-menu-star): Improve documentation --- lisp/info.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/info.el b/lisp/info.el index 94537c2417..559460e8d2 100644 --- a/lisp/info.el +++ b/lisp/info.el @@ -115,7 +115,9 @@ info-menu-header (defface info-menu-star '((((class color)) :foreground "red1") (t :underline t)) - "Face for every third `*' in an Info menu.") + "Face used to emphasize `*' in an Info menu. +The face is assigned to the third, sixth, and ninth `*' for easier +orientation. See `Info-nth-menu-item'.") (defface info-xref '((t :inherit link)) -- 2.34.1 --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-info.el-info-menu-star-Improve-documentation.patch >From a68f253743a6d927a226595c925d5d0018e15d06 Mon Sep 17 00:00:00 2001 From: YugaEgo Date: Sun, 5 Dec 2021 19:59:29 +0200 Subject: [PATCH] * lisp/info.el (info-menu-star): Improve documentation --- lisp/info.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/info.el b/lisp/info.el index 94537c2417..bf30ff528f 100644 --- a/lisp/info.el +++ b/lisp/info.el @@ -115,7 +115,8 @@ info-menu-header (defface info-menu-star '((((class color)) :foreground "red1") (t :underline t)) - "Face for every third `*' in an Info menu.") + "Face for 3rd, 6th, 9th `*' in an Info menu. +This face eases orientation for `Info-nth-menu-item'.") (defface info-xref '((t :inherit link)) -- 2.34.1 --=-=-=-- From unknown Fri Aug 15 16:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52315: [PATH] Improve documentation of info-menu-star Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 21:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Y. E. Cc: 52315@debbugs.gnu.org Received: via spool by 52315-submit@debbugs.gnu.org id=B52315.163873837213836 (code B ref 52315); Sun, 05 Dec 2021 21:07:01 +0000 Received: (at 52315) by debbugs.gnu.org; 5 Dec 2021 21:06:12 +0000 Received: from localhost ([127.0.0.1]:59788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtyi4-0003b5-IS for submit@debbugs.gnu.org; Sun, 05 Dec 2021 16:06:12 -0500 Received: from quimby.gnus.org ([95.216.78.240]:56264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtyi2-0003ao-8k for 52315@debbugs.gnu.org; Sun, 05 Dec 2021 16:06:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=m7vK8Dm9G3fAqrPQW13wWT2iMan0ei9KJw2UvFAEUCA=; b=HnZA+I5huzdwEdHMcCz/jWRxc4 0MFgmMH5P6KC6IKbiT9LKAkTFLudDpGYrcqhEdB9ERgY0bGxXGL7WaDWwC0M4FTTCZoo0vUiuytsp Y6d0a8pWS9MFz9yl1/YH2fX3oYaLOJswveb5C4BtGP54Np53pSogQtIktsXbj/3Wz0Sg=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtyht-0002vN-As; Sun, 05 Dec 2021 22:06:03 +0100 From: Lars Ingebrigtsen References: X-Now-Playing: Genesis's _And Then There Were Three_: "Undertow" Date: Sun, 05 Dec 2021 22:06:00 +0100 In-Reply-To: (Y. E.'s message of "Sun, 05 Dec 2021 21:17:44 +0200") Message-ID: <87wnkin4nb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Y. E. writes: > I'm sending two alternate patches to improve the docstring of > info-menu-star. Either of them looks sufficiently fine to me. But one of > them might better suit Emacs' style. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Y. E. writes: > I'm sending two alternate patches to improve the docstring of > info-menu-star. Either of them looks sufficiently fine to me. But one of > them might better suit Emacs' style. Thanks; applied to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 05 16:06:14 2021 Received: (at control) by debbugs.gnu.org; 5 Dec 2021 21:06:15 +0000 Received: from localhost ([127.0.0.1]:59791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtyi6-0003bL-P4 for submit@debbugs.gnu.org; Sun, 05 Dec 2021 16:06:14 -0500 Received: from quimby.gnus.org ([95.216.78.240]:56278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtyi5-0003as-Sw for control@debbugs.gnu.org; Sun, 05 Dec 2021 16:06:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LEz+t0vcb6ET2QG+sG71xz4VvC1+faWXDpOgZxVQMLs=; b=Nt1ESpxkHE2dg7KKEzFOuXB5GQ Iyg49IQlVzXF1u6TWY6bw1KAOWTzObvolO/IfixbLzBRqS+V565wG7Dv/X0Cy/nQsYWgsmBuAM6+p RJSBmQuT+IlLtql3hRi6eJEsFOlhIXSXSXWNF5G3ypsnKLniEnIXUUWTgy3Nt31bBc4I=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtyhy-0002vX-DI for control@debbugs.gnu.org; Sun, 05 Dec 2021 22:06:08 +0100 Date: Sun, 05 Dec 2021 22:06:06 +0100 Message-Id: <87v902n4n5.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #52315 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 52315 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 52315 29.1 quit