GNU bug report logs - #52303
[PATCH] Remove not defined face info-menu-5 from manoj-dark theme

Previous Next

Full log

Message #25 received at 52303 <at> debbugs.gnu.org (full text, mbox):

From: Y. E. <yet <at> ego.team>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 52303 <at> debbugs.gnu.org, yet <at> ego.team
Subject: Re: bug#52303: [PATCH] Remove not defined face info-menu-5 from
 manoj-dark theme
Date: Thu, 09 Dec 2021 12:36:30 +0200

>> The mentioned commit messages seem to contain accidentally duplicated
>> content. For example, see the part of the `git show d3d8a6ccda7' output:
>>
>> Date:   Sun Dec 5 22:18:18 2021 +0100
>>
>>     ; * etc/themes/manoj-dark-theme.el: Remove not defined face info-menu-5
>>
>>     * etc/themes/manoj-dark-theme.el (manoj-dark): Remove reference to
>>     face removed in 2005 (bug#52303).
>>
>> diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el
>>
>>> Is there something that should be changed?
>>
>> My guess was I should have notified you, in case this indeed was a kind
>> of a typo or broken automation. (I didn't see/notice such commit
>> messages in Emacs commit history before.)
>
> Do you mean that the commit message here is wrong?  I still don't quite
> understand what you mean.

Yes, it seemed so to me: the two lines of the commit message saying
basically the same thing. If it's correct, then what purpose does it
serve?

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.