GNU bug report logs - #52293
29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Sun, 5 Dec 2021 05:59:01 UTC

Severity: normal

Tags: patch

Fixed in version 29.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 52293 <at> debbugs.gnu.org
Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus
Date: Sun, 05 Dec 2021 19:59:22 +0200

>  (defun help-mode-context-menu (menu click)
>    "Populate MENU with Help mode commands at CLICK."
> -  (define-key menu [help-mode-separator] menu-bar-separator)
> +  (define-key-after menu [help-mode-separator] menu-bar-separator
> +    'top-separator)

Now I realized that it's possible to do the same without 'top-separator':

  (define-key-after menu [help-mode-separator] menu-bar-separator
    "Context Menu")

Or when the title string is defined as a variable:

  (defvar context-menu-title "Context Menu")

  (define-key-after menu [help-mode-separator] menu-bar-separator
    context-menu-title)

But maybe 'top-separator' still could be used for clarity?
Or it increases complexity?
This bug report was last modified 3 years and 136 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.