From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 05:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 52293@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163868391021728 (code B ref -1); Sun, 05 Dec 2021 05:59:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Dec 2021 05:58:30 +0000 Received: from localhost ([127.0.0.1]:56094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtkXd-0005eO-Pt for submit@debbugs.gnu.org; Sun, 05 Dec 2021 00:58:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:57738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtkXc-0005eH-Ot for submit@debbugs.gnu.org; Sun, 05 Dec 2021 00:58:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtkXc-0006xC-Fx for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 00:58:28 -0500 Received: from [2607:f8b0:4864:20::429] (port=45945 helo=mail-pf1-x429.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtkXa-0003Mk-G2 for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 00:58:28 -0500 Received: by mail-pf1-x429.google.com with SMTP id x131so7004065pfc.12 for ; Sat, 04 Dec 2021 21:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:message-id:date:mime-version:content-language; bh=89D135Jqda7/zweIz1wZZVIQU7o5RUzj9U57JCPzjr4=; b=mbeTdrPHAX/ReVUts1FkoRworZ/vqhYLvh3IMTeQcd+7mG/id5wKMTwEeNXmlvRJEa 69eLSrJQ6mgZbkuhZzF3Z6uCc3mohNQI04qjxaWD8xsDvml+FpVkWmLhDHjW+M/p1iFK i9fcEgWhr9ptTYl68sa4LYGap7gOaNICY8QBaEcwzfJ9ZaAueXGDinC2+e6M4gfzE96m 49QV+LhHLja4w/KkIAIcSvmE2EqRTZ49lIJNYZPnTuawypy3ASmNhzUsqMpcexkN1ff8 DPSooave7LiOZE1JAMRv8Yy9Z6YCc7LI32h09Ej+ALHaE2W/r0vSm1VvdrCsunV4+Jhz p7aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language; bh=89D135Jqda7/zweIz1wZZVIQU7o5RUzj9U57JCPzjr4=; b=G56QT/3i5LD5wtXUPCCmuf59u1jf94xtxo7saCzsbydIy2dUkQUN6vgcGIiaz5r8kk 4fpRb/W01SnFqybm58NPEyjtLLCeo7338L/TfTeBu8oV+v/Fow1YtIQPKJRIziokAs3G BioHyNRQ8msDg5XzOsJIgk+O38ZYwnaOl8hn14uTu3h+H48oQZLsZRwFXDnCCHtLVnen VzH6pxz4UrbEhrAGZa86b+AYK4gN6y03KvF0xSjjj3fv3EPwZR8T3KohJEcP1zj9sBVz +Q9hoSixZSEAnbyPzZkDwRPCwMmJfEl4iQ/97kw6WkvPqJ013/LB84y7kTb9eCyPOGzv vBFw== X-Gm-Message-State: AOAM531vPYjWYwikAHV97z1W0XE3XnRPxR4rQUqOuhOtSPl++8mx8prL omQ6wGiLZDTDG/KrNea4WrVnSdOkDL0= X-Google-Smtp-Source: ABdhPJwcYRoMSLKqmyKTPG2qqE00QX4kmy6MJHwV9xPEqqEnF2WEYF52ebwUKgnFExIbt6z0ipa1yg== X-Received: by 2002:a05:6a00:cc4:b0:4a0:e97:fe97 with SMTP id b4-20020a056a000cc400b004a00e97fe97mr29568410pfv.74.1638683905085; Sat, 04 Dec 2021 21:58:25 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id h20sm982597pgh.13.2021.12.04.21.58.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Dec 2021 21:58:24 -0800 (PST) X-Mozilla-News-Host: news://news.gmane.org:119 From: Jim Porter Message-ID: Date: Sat, 4 Dec 2021 21:58:24 -0800 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------E952E559B6A2DBD64D31DDF8" Content-Language: en-US X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::429 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------E952E559B6A2DBD64D31DDF8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit This is a followup to bug#52237. I'll just quote my message describing the issue from there[1]: > I found another odd case, but I'm not 100% sure the best way to fix it: > > emacs -Q --eval '(context-menu-mode)' > C-h o identity RET > ;; Right-click somewhere in the Help buffer > > There's a doubled separator after "Next Topic". Looking at the code, this is because `help-mode-context-menu' inserts new items using `define-key', which has the effect of putting the new items *before* the (hidden) menu title. The resulting keymap ends up looking like this: > > (keymap > (Previous\ Topic ...) > (Next\ Topic ...) > (help-mode-separator "--") > #("Context Menu" 0 12 (hide t)) > (separator-undo "--") > ...) > > Since there's a hidden item (the keymap title) between the `help-mode-separator' and `separator-undo'[1], the de-duplication doesn't handle that. Attached is a patch to fix this based on the discussion in bug#52237. One slightly odd thing is that for context menu functions that put their items at the top, they place their separator *below* the items. Other functions place the separator *above* the items. It might be too late to fix this though, given that Emacs 28 is only open for fixing regressions, and changing it in 29 would be a (small) compatibility break. However, I can update the patch to put the separators in these functions at the top if people think that's best. [1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-12/msg00143.html --------------E952E559B6A2DBD64D31DDF8 Content-Type: text/plain; charset=UTF-8; name="0001-Add-a-top-separator-to-the-context-menu.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Add-a-top-separator-to-the-context-menu.patch" RnJvbSAyYjM5NWEyY2IxZWZjYTg1Y2RjYTk5MjgwNGI2MTRjZGYyNjQxNDEzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgNCBEZWMgMjAyMSAyMTo0Mjo1NyAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIEFkZCBhICd0b3Atc2VwYXJhdG9yJyB0byB0aGUgY29udGV4dCBtZW51CgpUaGlzIHBy b3ZpZGVzIGFuIGFuY2hvciBmb3IgY29udGV4dCBtZW51IGZ1bmN0aW9ucyB0byB1c2UgdG8g aW5zZXJ0CnRoZWlyIG1lbnUgaXRlbXMgYWZ0ZXIgaXQuIFVzaW5nICdkZWZpbmUta2V5JyBk b2Vzbid0IHdvcmsgcHJvcGVybHkgaW4KdGhpcyBjYXNlLCBzaW5jZSBpdCBpbnNlcnRzIHRo ZSBpdGVtcyBiZWZvcmUgdGhlIG1lbnUgdGl0bGUsIGNvbmZ1c2luZwp0aGUgc2VwYXJhdG9y IGRlLWR1cGxpY2F0aW9uIGluICdjb250ZXh0LW1lbnUtbWFwJy4KCiogbGlzcC9tb3VzZS5l bCAoY29udGV4dC1tZW51LXRvcC1zZXBhcmF0b3IpOiBOZXcgZnVuY3Rpb24uCihjb250ZXh0 LW1lbnUtZnVuY3Rpb25zKTogVXNlIGl0LgoqIGxpc3AvZGlyZWQuZWwgKGRpcmVkLWNvbnRl eHQtbWVudSk6CiogbGlzcC9oZWxwLW1vZGUuZWwgKGhlbHAtbW9kZS1jb250ZXh0LW1lbnUp OgoqIGxpc3AvaW5mby5lbCAoSW5mby1jb250ZXh0LW1lbnUpOgoqIGxpc3AvbmV0L2V3dy5l bCAoZXd3LWNvbnRleHQtbWVudSk6CiogbGlzcC9uZXQvZ290by1hZGRyLmVsIChnb3RvLWFk ZHJlc3MtY29udGV4dC1tZW51KToKVXNlICd0b3Atc2VwYXJhdG9yJy4KLS0tCiBsaXNwL2Rp cmVkLmVsICAgICAgICAgfCAgNSArKystLQogbGlzcC9oZWxwLW1vZGUuZWwgICAgIHwgMTAg KysrKysrLS0tLQogbGlzcC9pbmZvLmVsICAgICAgICAgIHwgIDkgKysrKystLS0tCiBsaXNw L21vdXNlLmVsICAgICAgICAgfCAxMiArKysrKysrKysrLS0KIGxpc3AvbmV0L2V3dy5lbCAg ICAgICB8IDE0ICsrKysrKysrLS0tLS0tCiBsaXNwL25ldC9nb3RvLWFkZHIuZWwgfCAgOCAr KysrKy0tLQogNiBmaWxlcyBjaGFuZ2VkLCAzNyBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2RpcmVkLmVsIGIvbGlzcC9kaXJlZC5lbAppbmRl eCBkMGU1NDdiYTBiLi5iMDA0ZDgxNDk1IDEwMDY0NAotLS0gYS9saXNwL2RpcmVkLmVsCisr KyBiL2xpc3AvZGlyZWQuZWwKQEAgLTIyODIsNyArMjI4Miw3IEBAIGRpcmVkLW1vZGUtb3Bl cmF0ZS1tZW51CiAoZGVmdW4gZGlyZWQtY29udGV4dC1tZW51IChtZW51IGNsaWNrKQogICAi UG9wdWxhdGUgTUVOVSB3aXRoIERpcmVkIG1vZGUgY29tbWFuZHMgYXQgQ0xJQ0suIgogICAo d2hlbiAobW91c2UtcG9zbi1wcm9wZXJ0eSAoZXZlbnQtc3RhcnQgY2xpY2spICdkaXJlZC1m aWxlbmFtZSkKLSAgICAoZGVmaW5lLWtleSBtZW51IFtkaXJlZC1zZXBhcmF0b3JdIG1lbnUt YmFyLXNlcGFyYXRvcikKKyAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtkaXJlZC1zZXBh cmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRvciAndG9wLXNlcGFyYXRvcikKICAgICAobGV0ICgo ZWFzeS1tZW51IChtYWtlLXNwYXJzZS1rZXltYXAgIkltbWVkaWF0ZSIpKSkKICAgICAgIChl YXN5LW1lbnUtZGVmaW5lIG5pbCBlYXN5LW1lbnUgbmlsCiAgICAgICAgICcoIkltbWVkaWF0 ZSIKQEAgLTIyOTIsNyArMjI5Miw4IEBAIGRpcmVkLWNvbnRleHQtbWVudQogICAgICAgICAg ICA6aGVscCAiRWRpdCBmaWxlIGF0IG1vdXNlIGNsaWNrIGluIG90aGVyIHdpbmRvdyJdKSkK ICAgICAgIChkb2xpc3QgKGl0ZW0gKHJldmVyc2UgKGxvb2t1cC1rZXkgZWFzeS1tZW51IFtt ZW51LWJhciBpbW1lZGlhdGVdKSkpCiAgICAgICAgICh3aGVuIChjb25zcCBpdGVtKQotICAg ICAgICAgIChkZWZpbmUta2V5IG1lbnUgKHZlY3RvciAoY2FyIGl0ZW0pKSAoY2RyIGl0ZW0p KSkpKSkKKyAgICAgICAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51ICh2ZWN0b3IgKGNhciBp dGVtKSkgKGNkciBpdGVtKQorICAgICAgICAgICAgJ3RvcC1zZXBhcmF0b3IpKSkpKQogICBt ZW51KQogCiAMCmRpZmYgLS1naXQgYS9saXNwL2hlbHAtbW9kZS5lbCBiL2xpc3AvaGVscC1t b2RlLmVsCmluZGV4IDc5MmYyZTVhZjMuLjJlZDIwNTc3ZjUgMTAwNjQ0Ci0tLSBhL2xpc3Av aGVscC1tb2RlLmVsCisrKyBiL2xpc3AvaGVscC1tb2RlLmVsCkBAIC03NCw3ICs3NCw4IEBA IGhlbHAtbW9kZS1tZW51CiAKIChkZWZ1biBoZWxwLW1vZGUtY29udGV4dC1tZW51IChtZW51 IGNsaWNrKQogICAiUG9wdWxhdGUgTUVOVSB3aXRoIEhlbHAgbW9kZSBjb21tYW5kcyBhdCBD TElDSy4iCi0gIChkZWZpbmUta2V5IG1lbnUgW2hlbHAtbW9kZS1zZXBhcmF0b3JdIG1lbnUt YmFyLXNlcGFyYXRvcikKKyAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbaGVscC1tb2RlLXNl cGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yCisgICAgJ3RvcC1zZXBhcmF0b3IpCiAgIChs ZXQgKChlYXN5LW1lbnUgKG1ha2Utc3BhcnNlLWtleW1hcCAiSGVscC1Nb2RlIikpKQogICAg IChlYXN5LW1lbnUtZGVmaW5lIG5pbCBlYXN5LW1lbnUgbmlsCiAgICAgICAnKCJIZWxwLU1v ZGUiCkBAIC04NiwxNCArODcsMTUgQEAgaGVscC1tb2RlLWNvbnRleHQtbWVudQogICAgICAg ICAgOmFjdGl2ZSBoZWxwLXhyZWYtZm9yd2FyZC1zdGFja10pKQogICAgIChkb2xpc3QgKGl0 ZW0gKHJldmVyc2UgKGxvb2t1cC1rZXkgZWFzeS1tZW51IFttZW51LWJhciBoZWxwLW1vZGVd KSkpCiAgICAgICAod2hlbiAoY29uc3AgaXRlbSkKLSAgICAgICAgKGRlZmluZS1rZXkgbWVu dSAodmVjdG9yIChjYXIgaXRlbSkpIChjZHIgaXRlbSkpKSkpCisgICAgICAgIChkZWZpbmUt a2V5LWFmdGVyIG1lbnUgKHZlY3RvciAoY2FyIGl0ZW0pKSAoY2RyIGl0ZW0pICd0b3Atc2Vw YXJhdG9yKSkpKQogCiAgICh3aGVuIChtb3VzZS1wb3NuLXByb3BlcnR5IChldmVudC1zdGFy dCBjbGljaykgJ21vdXNlLWZhY2UpCi0gICAgKGRlZmluZS1rZXkgbWVudSBbaGVscC1tb2Rl LXB1c2gtYnV0dG9uXQorICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW2hlbHAtbW9kZS1w dXNoLWJ1dHRvbl0KICAgICAgICcobWVudS1pdGVtICJGb2xsb3cgTGluayIgKGxhbWJkYSAo ZXZlbnQpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGludGVyYWN0aXZl ICJlIikKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocHVzaC1idXR0b24g ZXZlbnQpKQotICAgICAgICAgICAgICAgICAgOmhlbHAgIkZvbGxvdyB0aGUgbGluayBhdCBj bGljayIpKSkKKyAgICAgICAgICAgICAgICAgIDpoZWxwICJGb2xsb3cgdGhlIGxpbmsgYXQg Y2xpY2siKQorICAgICAgJ3RvcC1zZXBhcmF0b3IpKQogCiAgIG1lbnUpCiAKZGlmZiAtLWdp dCBhL2xpc3AvaW5mby5lbCBiL2xpc3AvaW5mby5lbAppbmRleCA5NDUzN2MyNDE3Li43Njk2 M2FmNDFjIDEwMDY0NAotLS0gYS9saXNwL2luZm8uZWwKKysrIGIvbGlzcC9pbmZvLmVsCkBA IC00MTkxLDcgKzQxOTEsNyBAQCBJbmZvLWNoZWNrLXBvaW50ZXIKIAogKGRlZnVuIEluZm8t Y29udGV4dC1tZW51IChtZW51IGNsaWNrKQogICAiUG9wdWxhdGUgTUVOVSB3aXRoIEluZm8g Y29tbWFuZHMgYXQgQ0xJQ0suIgotICAoZGVmaW5lLWtleSBtZW51IFtJbmZvLXNlcGFyYXRv cl0gbWVudS1iYXItc2VwYXJhdG9yKQorICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtJbmZv LXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yICd0b3Atc2VwYXJhdG9yKQogICAobGV0 ICgoZWFzeS1tZW51IChtYWtlLXNwYXJzZS1rZXltYXAgIkluZm8iKSkpCiAgICAgKGVhc3kt bWVudS1kZWZpbmUgbmlsIGVhc3ktbWVudSBuaWwKICAgICAgICcoIkluZm8iCkBAIC00MjAx LDEyICs0MjAxLDEzIEBAIEluZm8tY29udGV4dC1tZW51CiAgICAgICAgICA6aGVscCAiR28g Zm9yd2FyZCBpbiBoaXN0b3J5Il0pKQogICAgIChkb2xpc3QgKGl0ZW0gKHJldmVyc2UgKGxv b2t1cC1rZXkgZWFzeS1tZW51IFttZW51LWJhciBpbmZvXSkpKQogICAgICAgKHdoZW4gKGNv bnNwIGl0ZW0pCi0gICAgICAgIChkZWZpbmUta2V5IG1lbnUgKHZlY3RvciAoY2FyIGl0ZW0p KSAoY2RyIGl0ZW0pKSkpKQorICAgICAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51ICh2ZWN0 b3IgKGNhciBpdGVtKSkgKGNkciBpdGVtKSAndG9wLXNlcGFyYXRvcikpKSkKIAogICAod2hl biAobW91c2UtcG9zbi1wcm9wZXJ0eSAoZXZlbnQtc3RhcnQgY2xpY2spICdtb3VzZS1mYWNl KQotICAgIChkZWZpbmUta2V5IG1lbnUgW0luZm8tbW91c2UtZm9sbG93LW5lYXJlc3Qtbm9k ZV0KKyAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtJbmZvLW1vdXNlLWZvbGxvdy1uZWFy ZXN0LW5vZGVdCiAgICAgICAnKG1lbnUtaXRlbSAiRm9sbG93IExpbmsiIEluZm8tbW91c2Ut Zm9sbG93LW5lYXJlc3Qtbm9kZQotICAgICAgICAgICAgICAgICAgOmhlbHAgIkZvbGxvdyBh IGxpbmsgd2hlcmUgeW91IGNsaWNrIikpKQorICAgICAgICAgICAgICAgICAgOmhlbHAgIkZv bGxvdyBhIGxpbmsgd2hlcmUgeW91IGNsaWNrIikKKyAgICAgICd0b3Atc2VwYXJhdG9yKSkK IAogICBtZW51KQogCmRpZmYgLS1naXQgYS9saXNwL21vdXNlLmVsIGIvbGlzcC9tb3VzZS5l bAppbmRleCBiNWNhODBhNDQ2Li5hN2E3YmI2ZWFlIDEwMDY0NAotLS0gYS9saXNwL21vdXNl LmVsCisrKyBiL2xpc3AvbW91c2UuZWwKQEAgLTI3OSw3ICsyNzksOCBAQCBtb3VzZS1tZW51 LWJhci1tYXAKIAwKIDs7IENvbnRleHQgbWVudXMuCiAKLShkZWZjdXN0b20gY29udGV4dC1t ZW51LWZ1bmN0aW9ucyAnKGNvbnRleHQtbWVudS11bmRvCisoZGVmY3VzdG9tIGNvbnRleHQt bWVudS1mdW5jdGlvbnMgJyhjb250ZXh0LW1lbnUtdG9wLXNlcGFyYXRvcgorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29udGV4dC1tZW51LXVuZG8KICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRleHQtbWVudS1yZWdpb24KICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRleHQtbWVudS1taWRkbGUtc2Vw YXJhdG9yCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb250ZXh0LW1l bnUtbG9jYWwKQEAgLTI4OCw3ICsyODksOCBAQCBjb250ZXh0LW1lbnUtZnVuY3Rpb25zCiBF YWNoIGZ1bmN0aW9uIHJlY2VpdmVzIHRoZSBtZW51IGFuZCB0aGUgbW91c2UgY2xpY2sgZXZl bnQgYXMgaXRzIGFyZ3VtZW50cwogYW5kIHNob3VsZCByZXR1cm4gdGhlIHNhbWUgbWVudSB3 aXRoIGNoYW5nZXMgc3VjaCBhcyBhZGRlZCBuZXcgbWVudSBpdGVtcy4iCiAgIDp0eXBlICco cmVwZWF0Ci0gICAgICAgICAgKGNob2ljZSAoZnVuY3Rpb24taXRlbSBjb250ZXh0LW1lbnUt dW5kbykKKyAgICAgICAgICAoY2hvaWNlIChmdW5jdGlvbi1pdGVtIGNvbnRleHQtbWVudS10 b3Atc2VwYXJhdG9yKQorICAgICAgICAgICAgICAgICAgKGZ1bmN0aW9uLWl0ZW0gY29udGV4 dC1tZW51LXVuZG8pCiAgICAgICAgICAgICAgICAgICAoZnVuY3Rpb24taXRlbSBjb250ZXh0 LW1lbnUtcmVnaW9uKQogICAgICAgICAgICAgICAgICAgKGZ1bmN0aW9uLWl0ZW0gY29udGV4 dC1tZW51LW1pZGRsZS1zZXBhcmF0b3IpCiAgICAgICAgICAgICAgICAgICAoZnVuY3Rpb24t aXRlbSBjb250ZXh0LW1lbnUtdG9vbGJhcikKQEAgLTM0OCw2ICszNTAsMTIgQEAgY29udGV4 dC1tZW51LW1hcAogICAgICAgKHNldHEgbWVudSAoZnVuY2FsbCBjb250ZXh0LW1lbnUtZmls dGVyLWZ1bmN0aW9uIG1lbnUgY2xpY2spKSkKICAgICBtZW51KSkKIAorKGRlZnVuIGNvbnRl eHQtbWVudS10b3Atc2VwYXJhdG9yIChtZW51IF9jbGljaykKKyAgIkFkZCBzZXBhcmF0b3Ig dG8gdGhlIHRvcCBvZiB0aGUgY29udGV4dCBtZW51LgorU29tZSBjb250ZXh0IGZ1bmN0aW9u cyBhZGQgbWVudSBpdGVtcyBiZWxvdyB0aGUgc2VwYXJhdG9yLiIKKyAgKGRlZmluZS1rZXkt YWZ0ZXIgbWVudSBbdG9wLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yKQorICBtZW51 KQorCiAoZGVmdW4gY29udGV4dC1tZW51LW1pZGRsZS1zZXBhcmF0b3IgKG1lbnUgX2NsaWNr KQogICAiQWRkIHNlcGFyYXRvciB0byB0aGUgbWlkZGxlIG9mIHRoZSBjb250ZXh0IG1lbnUu CiBTb21lIGNvbnRleHQgZnVuY3Rpb25zIGFkZCBtZW51IGl0ZW1zIGJlbG93IHRoZSBzZXBh cmF0b3IuIgpkaWZmIC0tZ2l0IGEvbGlzcC9uZXQvZXd3LmVsIGIvbGlzcC9uZXQvZXd3LmVs CmluZGV4IGU4NmQyMWY4ODkuLjczMDNlMDFhMzcgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L2V3 dy5lbAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAgLTExMDYsNyArMTEwNiw3IEBAIGV3dy1t b2RlLW1hcAogCiAoZGVmdW4gZXd3LWNvbnRleHQtbWVudSAobWVudSBjbGljaykKICAgIlBv cHVsYXRlIE1FTlUgd2l0aCBld3cgY29tbWFuZHMgYXQgQ0xJQ0suIgotICAoZGVmaW5lLWtl eSBtZW51IFtld3ctc2VwYXJhdG9yXSBtZW51LWJhci1zZXBhcmF0b3IpCisgIChkZWZpbmUt a2V5LWFmdGVyIG1lbnUgW2V3dy1zZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRvciAndG9w LXNlcGFyYXRvcikKICAgKGxldCAoKGVhc3ktbWVudSAobWFrZS1zcGFyc2Uta2V5bWFwICJF d3ciKSkpCiAgICAgKGVhc3ktbWVudS1kZWZpbmUgbmlsIGVhc3ktbWVudSBuaWwKICAgICAg ICcoIkV3dyIKQEAgLTExMTcsMjAgKzExMTcsMjIgQEAgZXd3LWNvbnRleHQtbWVudQogCVsi UmVsb2FkIiBld3ctcmVsb2FkIHRdKSkKICAgICAoZG9saXN0IChpdGVtIChyZXZlcnNlIChs b29rdXAta2V5IGVhc3ktbWVudSBbbWVudS1iYXIgZXd3XSkpKQogICAgICAgKHdoZW4gKGNv bnNwIGl0ZW0pCi0gICAgICAgIChkZWZpbmUta2V5IG1lbnUgKHZlY3RvciAoY2FyIGl0ZW0p KSAoY2RyIGl0ZW0pKSkpKQorICAgICAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51ICh2ZWN0 b3IgKGNhciBpdGVtKSkgKGNkciBpdGVtKSAndG9wLXNlcGFyYXRvcikpKSkKIAogICAod2hl biAob3IgKG1vdXNlLXBvc24tcHJvcGVydHkgKGV2ZW50LXN0YXJ0IGNsaWNrKSAnc2hyLXVy bCkKICAgICAgICAgICAgIChtb3VzZS1wb3NuLXByb3BlcnR5IChldmVudC1zdGFydCBjbGlj aykgJ2ltYWdlLXVybCkpCi0gICAgKGRlZmluZS1rZXkgbWVudSBbc2hyLW1vdXNlLWJyb3dz ZS11cmwtbmV3LXdpbmRvd10KKyAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtzaHItbW91 c2UtYnJvd3NlLXVybC1uZXctd2luZG93XQogICAgICAgYChtZW51LWl0ZW0gIkZvbGxvdyBV UkwgaW4gbmV3IHdpbmRvdyIgLChpZiBicm93c2UtdXJsLW5ldy13aW5kb3ctZmxhZwogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnc2hyLW1v dXNlLWJyb3dzZS11cmwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICdzaHItbW91c2UtYnJvd3NlLXVybC1uZXctd2luZG93KQotICAgICAgICAg ICAgICAgICAgOmhlbHAgIkJyb3dzZSB0aGUgVVJMIHVuZGVyIHRoZSBtb3VzZSBjdXJzb3Ig aW4gYSBuZXcgd2luZG93IikpCi0gICAgKGRlZmluZS1rZXkgbWVudSBbc2hyLW1vdXNlLWJy b3dzZS11cmxdCisgICAgICAgICAgICAgICAgICA6aGVscCAiQnJvd3NlIHRoZSBVUkwgdW5k ZXIgdGhlIG1vdXNlIGN1cnNvciBpbiBhIG5ldyB3aW5kb3ciKQorICAgICAgJ3RvcC1zZXBh cmF0b3IpCisgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbc2hyLW1vdXNlLWJyb3dzZS11 cmxdCiAgICAgICBgKG1lbnUtaXRlbSAiRm9sbG93IFVSTCIgLChpZiBicm93c2UtdXJsLW5l dy13aW5kb3ctZmxhZwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3No ci1tb3VzZS1icm93c2UtdXJsLW5ldy13aW5kb3cKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAnc2hyLW1vdXNlLWJyb3dzZS11cmwpCi0gICAgICAgICAgICAgICAgICA6 aGVscCAiQnJvd3NlIHRoZSBVUkwgdW5kZXIgdGhlIG1vdXNlIGN1cnNvciIpKSkKKyAgICAg ICAgICAgICAgICAgIDpoZWxwICJCcm93c2UgdGhlIFVSTCB1bmRlciB0aGUgbW91c2UgY3Vy c29yIikKKyAgICAgICd0b3Atc2VwYXJhdG9yKSkKIAogICBtZW51KQogCmRpZmYgLS1naXQg YS9saXNwL25ldC9nb3RvLWFkZHIuZWwgYi9saXNwL25ldC9nb3RvLWFkZHIuZWwKaW5kZXgg ODQ4YmFkM2IwZC4uYmIwZjBiMDBlZSAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvZ290by1hZGRy LmVsCisrKyBiL2xpc3AvbmV0L2dvdG8tYWRkci5lbApAQCAtMTI3LDEwICsxMjcsMTIgQEAg Z290by1hZGRyZXNzLWhpZ2hsaWdodC1rZXltYXAKIChkZWZ1biBnb3RvLWFkZHJlc3MtY29u dGV4dC1tZW51IChtZW51IGNsaWNrKQogICAiUG9wdWxhdGUgTUVOVSB3aXRoIGBnb3RvLWFk ZHJlc3MnIGNvbW1hbmRzIGF0IENMSUNLLiIKICAgKHdoZW4gKG1vdXNlLXBvc24tcHJvcGVy dHkgKGV2ZW50LXN0YXJ0IGNsaWNrKSAnZ290by1hZGRyZXNzKQotICAgIChkZWZpbmUta2V5 IG1lbnUgW2dvdG8tYWRkcmVzcy1zZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRvcikKLSAg ICAoZGVmaW5lLWtleSBtZW51IFtnb3RvLWFkZHJlc3MtYXQtbW91c2VdCisgICAgKGRlZmlu ZS1rZXktYWZ0ZXIgbWVudSBbZ290by1hZGRyZXNzLXNlcGFyYXRvcl0gbWVudS1iYXItc2Vw YXJhdG9yCisgICAgICAndG9wLXNlcGFyYXRvcikKKyAgICAoZGVmaW5lLWtleS1hZnRlciBt ZW51IFtnb3RvLWFkZHJlc3MtYXQtbW91c2VdCiAgICAgICAnKG1lbnUtaXRlbSAiRm9sbG93 IExpbmsiIGdvdG8tYWRkcmVzcy1hdC1tb3VzZQotICAgICAgICAgICAgICAgICAgOmhlbHAg IkZvbGxvdyBhIGxpbmsgd2hlcmUgeW91IGNsaWNrIikpKQorICAgICAgICAgICAgICAgICAg OmhlbHAgIkZvbGxvdyBhIGxpbmsgd2hlcmUgeW91IGNsaWNrIikKKyAgICAgICd0b3Atc2Vw YXJhdG9yKSkKICAgbWVudSkKIAogKGRlZmN1c3RvbSBnb3RvLWFkZHJlc3MtdXJsLWZhY2Ug J2xpbmsKLS0gCjIuMjUuMQoK --------------E952E559B6A2DBD64D31DDF8-- From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 10:05:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163869869119056 (code B ref 52293); Sun, 05 Dec 2021 10:05:04 +0000 Received: (at 52293) by debbugs.gnu.org; 5 Dec 2021 10:04:51 +0000 Received: from localhost ([127.0.0.1]:56422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtoO2-0004xG-M0 for submit@debbugs.gnu.org; Sun, 05 Dec 2021 05:04:50 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:38047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtoO1-0004w0-3D for 52293@debbugs.gnu.org; Sun, 05 Dec 2021 05:04:49 -0500 Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 6BB97240006; Sun, 5 Dec 2021 10:04:40 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: Date: Sun, 05 Dec 2021 11:39:50 +0200 In-Reply-To: (Jim Porter's message of "Sat, 4 Dec 2021 21:58:24 -0800") Message-ID: <864k7n9xt5.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Attached is a patch to fix this based on the discussion in bug#52237. Thanks for the patch. > One slightly odd thing is that for context menu functions that put their items > at the top, they place their separator *below* the items. Other functions > place the separator *above* the items. There is some logic in this: when the menu doesn't contain a separator at the top, then it is necessary to add a separator below the added items, e.g. by modifying such a menu: - existing menu item 1 - existing menu item 2 to - new item 1 - new item 2 - new separator - existing menu item 1 - existing menu item 2 From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16387277552397 (code B ref 52293); Sun, 05 Dec 2021 18:10:02 +0000 Received: (at 52293) by debbugs.gnu.org; 5 Dec 2021 18:09:15 +0000 Received: from localhost ([127.0.0.1]:59362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtvwp-0000cS-HF for submit@debbugs.gnu.org; Sun, 05 Dec 2021 13:09:15 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:33965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtvwo-0000Zq-CH for 52293@debbugs.gnu.org; Sun, 05 Dec 2021 13:09:14 -0500 Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 533E060006; Sun, 5 Dec 2021 18:09:06 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: Date: Sun, 05 Dec 2021 19:59:22 +0200 In-Reply-To: (Jim Porter's message of "Sat, 4 Dec 2021 21:58:24 -0800") Message-ID: <86tufn5jn9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > (defun help-mode-context-menu (menu click) > "Populate MENU with Help mode commands at CLICK." > - (define-key menu [help-mode-separator] menu-bar-separator) > + (define-key-after menu [help-mode-separator] menu-bar-separator > + 'top-separator) Now I realized that it's possible to do the same without 'top-separator': (define-key-after menu [help-mode-separator] menu-bar-separator "Context Menu") Or when the title string is defined as a variable: (defvar context-menu-title "Context Menu") (define-key-after menu [help-mode-separator] menu-bar-separator context-menu-title) But maybe 'top-separator' still could be used for clarity? Or it increases complexity? From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2021 04:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163876368414265 (code B ref 52293); Mon, 06 Dec 2021 04:09:01 +0000 Received: (at 52293) by debbugs.gnu.org; 6 Dec 2021 04:08:04 +0000 Received: from localhost ([127.0.0.1]:60194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mu5IK-0003i0-L8 for submit@debbugs.gnu.org; Sun, 05 Dec 2021 23:08:04 -0500 Received: from mail-pg1-f179.google.com ([209.85.215.179]:37863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mu5II-0003hU-OB for 52293@debbugs.gnu.org; Sun, 05 Dec 2021 23:08:03 -0500 Received: by mail-pg1-f179.google.com with SMTP id 71so9250457pgb.4 for <52293@debbugs.gnu.org>; Sun, 05 Dec 2021 20:08:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Epp+y+b6yVQZu6Db7yNszF0aQxakdG0QizTv/yGB3qs=; b=oodpexATZg7eyQN+q3hfSeV2Ni9X6rCAfkOvdWdm/b4vvSdfgr9p0z0tIhdXoULn4c DrObY3cpVRmIzCgBpjairxMHmJ4/lWhZgKaJrnxZ3Jium+gyTlN/8cwEx9uBV6U/9Z96 VdLcSkc2hs7fXz3Rkb1mBaLQhEz93rp5RZxQUchEtAcqTFRNP2007BnjMBBwGopTrt7s ZG3XkQstaQZpWvxf6lOZr32lnrcHxmX8MRAn2mz3bufKWrGmdK5HqUP/Aj35qCfHbC+J CC/XZYHbuxMJWgHj1dzU2m1C7TLPhjGtG3QzskEQFGhDGBWrVo/NoyAkics1ND4wRBV0 +Ziw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Epp+y+b6yVQZu6Db7yNszF0aQxakdG0QizTv/yGB3qs=; b=2ms/rKRGL9cknDSjxqB9cIyAkhxAUjGlPtFUuzFRRDLrETt2oTDiM2buyO4vLxZSUk BG59RLWegJD6cF9abD8iSIqidW9KQRODtU9+jsj8uhVtCsKRRQb9gd0Lpt3MVfS3qZUs EyBh6zF0b0itgRoOJzSrHVUb4cv8Khu+VTquP7QpjUQ41kciAaLwzjAIyb4wqBWQTjDH 6s7oYXjfEfIi46sWmSOlUcYWTlraqhat59T+l8npslWUDi5BJep7tBJRqtWX+qZ0Lvp5 nbVkQGamVarFyiZbL3mtEVV/mHDop3gPpAIo7lly9yOOt+tzTIRZLJgJ1Sea2wNHD/nV sHLQ== X-Gm-Message-State: AOAM532BCuAtUggqyW+GpYBjFVhXyq2/Je5ph1hY9R83416yh8QNUEMz Qxgmkf1hlRx9FacpcQo5ptlUDKgk9PM= X-Google-Smtp-Source: ABdhPJxSnveMkN3FvRi9/QBiWBYXeCarl344AAVwfxNFp0Tz0tBYJcZlde4V+bu/Jc+lEVq33SoRhA== X-Received: by 2002:a05:6a00:9a3:b0:49f:bf9b:3192 with SMTP id u35-20020a056a0009a300b0049fbf9b3192mr34080418pfg.44.1638763676878; Sun, 05 Dec 2021 20:07:56 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id n16sm8430517pja.46.2021.12.05.20.07.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Dec 2021 20:07:56 -0800 (PST) References: <864k7n9xt5.fsf@mail.linkov.net> From: Jim Porter Message-ID: <7f710476-7531-f913-7c2f-65d617dcd498@gmail.com> Date: Sun, 5 Dec 2021 20:07:56 -0800 MIME-Version: 1.0 In-Reply-To: <864k7n9xt5.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/5/2021 1:39 AM, Juri Linkov wrote: >> Attached is a patch to fix this based on the discussion in bug#52237. > > Thanks for the patch. > >> One slightly odd thing is that for context menu functions that put their items >> at the top, they place their separator *below* the items. Other functions >> place the separator *above* the items. > > There is some logic in this: when the menu doesn't contain a separator > at the top, then it is necessary to add a separator below the added items, > e.g. by modifying such a menu: > > - existing menu item 1 > - existing menu item 2 > > to > > - new item 1 > - new item 2 > - new separator > - existing menu item 1 > - existing menu item 2 Right, makes sense. (I was originally thinking that we could put items above `top-separator', and that then there'd be a separator below the items. That's not right though, since we'd use `define-key-after', putting the items *below* `top-separator'. There's no `define-key-before', so I just had the logic backwards in my head.) From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2021 04:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163876624018893 (code B ref 52293); Mon, 06 Dec 2021 04:51:02 +0000 Received: (at 52293) by debbugs.gnu.org; 6 Dec 2021 04:50:40 +0000 Received: from localhost ([127.0.0.1]:60251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mu5xY-0004uf-J3 for submit@debbugs.gnu.org; Sun, 05 Dec 2021 23:50:40 -0500 Received: from mail-pg1-f176.google.com ([209.85.215.176]:44783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mu5xW-0004uT-FD for 52293@debbugs.gnu.org; Sun, 05 Dec 2021 23:50:39 -0500 Received: by mail-pg1-f176.google.com with SMTP id m15so9285709pgu.11 for <52293@debbugs.gnu.org>; Sun, 05 Dec 2021 20:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=MC9LWo7QzMOI9GWTwNeqvyPgN2yFHGxElGtkcebqWVc=; b=W7wd/Q/rBSrQ8lf/TgHX4nnNS7lAzK1KNVRzs+iLl5S0kcEAJVbMekGPEejYuWXC9C WlaLyvB4MPW4+CQqt269jfREGx8crIITxWX4cl4LUgjXzrUTuEt+3T0z215LpjkW+Lv2 6rBIcuQdPEqYFnpkzLH6IEpkyaabuCHYm24KsYTjWmGDiqq7qqdyYPwKALT19ZIwOZ8Y 2QzpqK7xDYtZj93yKNMVTXCFfmeSXIl1RO+Qs+nqhMH+PypGkKvaKQxJwfzCNl8XEoh1 jY3zhZgrFHV6KJe4ikMH9f3O2rbFfiE6NenaFEy8Sy4XBvrxvAQypYyWVOC56ZtyKa6l A5GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MC9LWo7QzMOI9GWTwNeqvyPgN2yFHGxElGtkcebqWVc=; b=JEbd1fDc8s8SK8W13rJz4X1WKt7TsSPpMlA1ggcqiNBvqontDXkgYuF4jHV7tuZ/rl +yl7foP2GFRvPWEcC86AYuAqi7g4nCcolKBErE+ucotPx2pr095opNOU3qMztokoD8ud N2SI52aqpINCywlvwt0V8zHfdThqh75R8AYAh0rC6fBRr3sIlmlPBaTYhGaBdo1BRY+f l2cr/+ZOlrWH2u3/JXCjms/7uDmA26mtcWIvpHiU75KZwA1VOgxDXXX2OSQYy+EfA540 Gy/2r/63uDx1uWPVlsfiUBrH0NX80xL+abipcmfQuADi1acnUyHOEmM/6b0Md5EfKCAd 3s9g== X-Gm-Message-State: AOAM533407bTVDVE3GXWHwbRYcLWd2GYwMvyymxWIFgJTcwYLjxUioJF Xa2REFzA87n5hq0PybzmO9l47plL6UM= X-Google-Smtp-Source: ABdhPJw8CqEIwTO7XmONaUiTvjJ/h+1UL3ageaWiB5QJUEhTaq9EadqG8FGFA1cOlTKGvwFswAm2kQ== X-Received: by 2002:a63:170b:: with SMTP id x11mr13907286pgl.71.1638766232648; Sun, 05 Dec 2021 20:50:32 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d1sm10678339pfv.194.2021.12.05.20.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Dec 2021 20:50:32 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> From: Jim Porter Message-ID: Date: Sun, 5 Dec 2021 20:50:32 -0800 MIME-Version: 1.0 In-Reply-To: <86tufn5jn9.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/5/2021 9:59 AM, Juri Linkov wrote: >> (defun help-mode-context-menu (menu click) >> "Populate MENU with Help mode commands at CLICK." >> - (define-key menu [help-mode-separator] menu-bar-separator) >> + (define-key-after menu [help-mode-separator] menu-bar-separator >> + 'top-separator) > > Now I realized that it's possible to do the same without 'top-separator': > > (define-key-after menu [help-mode-separator] menu-bar-separator > "Context Menu") > > Or when the title string is defined as a variable: > > (defvar context-menu-title "Context Menu") > > (define-key-after menu [help-mode-separator] menu-bar-separator > context-menu-title) > > But maybe 'top-separator' still could be used for clarity? > Or it increases complexity? Hmm, that might work. One downside is that I think it makes it harder for context menu functions to change the menu's title/prompt to something else. Of course, if we used `context-menu-title' as the anchor like your example above, it should still be possible to update the menu title via `context-menu-filter-function'. That would be trickier to use though, at least in the situations I have in mind. For example, I added a very limited context menu that uses the menu title in my config under Emacs 27 for org-mode links: I can right-click and it shows a context menu with the URL as the title and menu items for different ways to open the URL (in Firefox, Firefox Private Browsing, or EWW). It's nice to be able to see the URL since that can influence which item I choose. Updating this part of my config for Emacs 28 was actually what prompted me to start looking into `context-menu-mode' in more detail. It would be easier to implement this if context menu functions didn't rely on the context menu title having a particular value. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2021 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163878357923525 (code B ref 52293); Mon, 06 Dec 2021 09:40:02 +0000 Received: (at 52293) by debbugs.gnu.org; 6 Dec 2021 09:39:39 +0000 Received: from localhost ([127.0.0.1]:60548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muATC-00067N-Tr for submit@debbugs.gnu.org; Mon, 06 Dec 2021 04:39:39 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:35405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muATB-000674-Bs for 52293@debbugs.gnu.org; Mon, 06 Dec 2021 04:39:38 -0500 Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id B4AF810000B; Mon, 6 Dec 2021 09:39:29 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86tufn5jn9.fsf@mail.linkov.net> Date: Mon, 06 Dec 2021 11:23:59 +0200 In-Reply-To: (Jim Porter's message of "Sun, 5 Dec 2021 20:50:32 -0800") Message-ID: <86pmqa14fc.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 12/5/2021 9:59 AM, Juri Linkov wrote: >>> (defun help-mode-context-menu (menu click) >>> "Populate MENU with Help mode commands at CLICK." >>> - (define-key menu [help-mode-separator] menu-bar-separator) >>> + (define-key-after menu [help-mode-separator] menu-bar-separator >>> + 'top-separator) >> Now I realized that it's possible to do the same without 'top-separator': >> (define-key-after menu [help-mode-separator] menu-bar-separator >> "Context Menu") >> Or when the title string is defined as a variable: >> (defvar context-menu-title "Context Menu") >> (define-key-after menu [help-mode-separator] menu-bar-separator >> context-menu-title) >> But maybe 'top-separator' still could be used for clarity? >> Or it increases complexity? > > Hmm, that might work. One downside is that I think it makes it harder for > context menu functions to change the menu's title/prompt to something > else. Of course, if we used `context-menu-title' as the anchor like your > example above, it should still be possible to update the menu title via > `context-menu-filter-function'. That would be trickier to use though, at > least in the situations I have in mind. I agree that relying on the constant value of the menu title would be too unreliable. > For example, I added a very limited context menu that uses the menu title > in my config under Emacs 27 for org-mode links: I can right-click and it > shows a context menu with the URL as the title and menu items for different > ways to open the URL (in Firefox, Firefox Private Browsing, or EWW). It's > nice to be able to see the URL since that can influence which item > I choose. Good example. Another example is flyspell that shows a misspelled word in the menu title. > Updating this part of my config for Emacs 28 was actually what prompted me > to start looking into `context-menu-mode' in more detail. It would be > easier to implement this if context menu functions didn't rely on the > context menu title having a particular value. I think the remaining problem we have to solve is to try to prevent such a situation when the user accidentally removes `context-menu-top-separator' from `context-menu-functions'. To not break the menu in this case, maybe we need to ensure that the menu always contains `top-separator' as well as `middle-separator' even when `context-menu-functions' doesn't contain a function that adds them? I.e. just to check if these separators are missing, and add them at the top. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v2] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Dec 2021 03:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163884926110694 (code B ref 52293); Tue, 07 Dec 2021 03:55:01 +0000 Received: (at 52293) by debbugs.gnu.org; 7 Dec 2021 03:54:21 +0000 Received: from localhost ([127.0.0.1]:35853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muRYa-0002mP-LU for submit@debbugs.gnu.org; Mon, 06 Dec 2021 22:54:21 -0500 Received: from mail-pj1-f49.google.com ([209.85.216.49]:42658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muRYY-0002m3-Hs for 52293@debbugs.gnu.org; Mon, 06 Dec 2021 22:54:19 -0500 Received: by mail-pj1-f49.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so1546886pjb.1 for <52293@debbugs.gnu.org>; Mon, 06 Dec 2021 19:54:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=PM1uNnx70ODE8oJf/HihweN4oX2i33o4GQgCNo2DFFY=; b=UCWh9Pw/Qg41bDfeF1lV31AlzV0R/M2crL7sxFTKvh8weZkOcUd9wV1Nl/qP3AFPUq /xRSa+v06Psdgxv5p91aDek7A2vHT1u26eY51jh0jd1oWpiPCoGHExjvH4e9ZDlmfjSm qd4fXatWrCYhiMMQ1Vemv8yW6a/2OKAvAcVSBslgaCEjTkxs7JepJIYp+cMEW3G9AM3h 3vs9uvDbpcFrIa8Ug1WClgT4ommYI1VfNh16f7g0cfLgy+DZwZOA7cnhRD18vIMEN8ZW RYJC76mi9+7WzaCdhyBnmGzwuaHFPelgIEpP7o8rIdTCyxALKcH5ivk4mnJOZJeszRAK cj0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=PM1uNnx70ODE8oJf/HihweN4oX2i33o4GQgCNo2DFFY=; b=a4NjySPjJSXwTA8SOdmgsKqcNSrHUHmjIaiF5WpCZhIYTjDKQKbFfBBTDd1HbzfFUt P7rrlqQittIbXc91JPf2uhrB1DQ5f3NIJzIfWd+uUeArtfdlpSEoAXyXtQk5ysUWE983 UW4I+U/qxNWZ8pQsv6p7ETkUHDyHxfgbAs8wGJdjyrjRMYpToHDxR9cjoPOdm9Qh4/Q5 mLpFdr8aydfm5eph/qLev4TcoUcMbzzwb1Smw/WmXZ1rH/3/Bpk30qSCxI0j0mHx5m7P hj1+3zLGEi8Qs6s8gnpEV/1UfhmRC3q/0xWkYEBh8CiYYp6tXzgYWyFn/4m7Aq/1E/U0 f9bw== X-Gm-Message-State: AOAM530y9rWAlCO0F7Vkxj98GzQhe4dYmyqfCdjD2yx/JFKutQzGIg3S gFRqYfx57J1X13qjZ9ldEhtL9SVF4Ko= X-Google-Smtp-Source: ABdhPJzGv5QgLzYuJv36zDYzMsso4hkAT4R24GZ1tbkxA9+YXDsnDwRb3i/sahQkL1xzyMlfVn+QHQ== X-Received: by 2002:a17:902:dacc:b0:142:12bd:c5b9 with SMTP id q12-20020a170902dacc00b0014212bdc5b9mr49073750plx.74.1638849252528; Mon, 06 Dec 2021 19:54:12 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g20sm15745033pfj.12.2021.12.06.19.54.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Dec 2021 19:54:11 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> From: Jim Porter Message-ID: <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> Date: Mon, 6 Dec 2021 19:54:11 -0800 MIME-Version: 1.0 In-Reply-To: <86pmqa14fc.fsf@mail.linkov.net> Content-Type: multipart/mixed; boundary="------------3BFF642EC8504B50DEC78DF1" Content-Language: en-US X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------3BFF642EC8504B50DEC78DF1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/6/2021 1:23 AM, Juri Linkov wrote: >> Updating this part of my config for Emacs 28 was actually what prompted me >> to start looking into `context-menu-mode' in more detail. It would be >> easier to implement this if context menu functions didn't rely on the >> context menu title having a particular value. > > I think the remaining problem we have to solve is to try to > prevent such a situation when the user accidentally removes > `context-menu-top-separator' from `context-menu-functions'. > To not break the menu in this case, maybe we need to ensure > that the menu always contains `top-separator' as well as > `middle-separator' even when `context-menu-functions' > doesn't contain a function that adds them? I.e. just to check > if these separators are missing, and add them at the top. For the top separator, maybe instead of providing a function for users to put wherever they like in `context-menu-functions', we could just add it directly in `context-menu-map' immediately before calling the functions in `context-menu-functions'? Since it's supposed to be at the top, it doesn't make a lot of sense to be able to customize where it goes. It does makes sense to customize where `middle-separator' goes though; what the user considers the "middle" depends on what other menu items are normally present. However, if the user didn't include `context-menu-middle-separator', then (define-key-after menu [foo] '(menu-item ...) 'middle-separator) just adds `foo' to the end of the menu. That seems ok to me. Then, adding after `top-separator' puts your item at the beginning of the menu, and adding after `middle-separator' puts your item at the middle or the end, depending on the user's configuration. How does that sound to you? --------------3BFF642EC8504B50DEC78DF1 Content-Type: text/plain; charset=UTF-8; name="0001-Add-a-top-separator-to-the-context-menu.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Add-a-top-separator-to-the-context-menu.patch" RnJvbSA4MzFiYTU1ZGQyMDlmZTU1NTE3MzNiYmVhMWQzM2ZjMGU3MjAyMjdlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgNiBEZWMgMjAyMSAxOTo0MDo0MCAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIEFkZCBhICd0b3Atc2VwYXJhdG9yJyB0byB0aGUgY29udGV4dCBtZW51CgpUaGlzIHBy b3ZpZGVzIGFuIGFuY2hvciBmb3IgY29udGV4dCBtZW51IGZ1bmN0aW9ucyB0byB1c2UgdG8g aW5zZXJ0CnRoZWlyIG1lbnUgaXRlbXMgYWZ0ZXIgaXQuIFVzaW5nICdkZWZpbmUta2V5JyBk b2Vzbid0IHdvcmsgcHJvcGVybHkgaW4KdGhpcyBjYXNlLCBzaW5jZSBpdCBpbnNlcnRzIHRo ZSBpdGVtcyBiZWZvcmUgdGhlIG1lbnUgdGl0bGUsIGNvbmZ1c2luZwp0aGUgc2VwYXJhdG9y IGRlLWR1cGxpY2F0aW9uIGluICdjb250ZXh0LW1lbnUtbWFwJy4KCiogbGlzcC9tb3VzZS5l bCAoY29udGV4dC1tZW51LW1hcCk6IEFkZCAndG9wLXNlcGFyYXRvcicgdG8gdGhlIG1lbnUu CiogbGlzcC9kaXJlZC5lbCAoZGlyZWQtY29udGV4dC1tZW51KToKKiBsaXNwL2hlbHAtbW9k ZS5lbCAoaGVscC1tb2RlLWNvbnRleHQtbWVudSk6CiogbGlzcC9pbmZvLmVsIChJbmZvLWNv bnRleHQtbWVudSk6CiogbGlzcC9uZXQvZXd3LmVsIChld3ctY29udGV4dC1tZW51KToKKiBs aXNwL25ldC9nb3RvLWFkZHIuZWwgKGdvdG8tYWRkcmVzcy1jb250ZXh0LW1lbnUpOgpVc2Ug J3RvcC1zZXBhcmF0b3InLgotLS0KIGxpc3AvZGlyZWQuZWwgICAgICAgICB8ICA1ICsrKy0t CiBsaXNwL2hlbHAtbW9kZS5lbCAgICAgfCAxMCArKysrKystLS0tCiBsaXNwL2luZm8uZWwg ICAgICAgICAgfCAgOSArKysrKy0tLS0KIGxpc3AvbW91c2UuZWwgICAgICAgICB8ICAzICsr KwogbGlzcC9uZXQvZXd3LmVsICAgICAgIHwgMTQgKysrKysrKystLS0tLS0KIGxpc3AvbmV0 L2dvdG8tYWRkci5lbCB8ICA4ICsrKysrLS0tCiA2IGZpbGVzIGNoYW5nZWQsIDMwIGluc2Vy dGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZGlyZWQuZWwg Yi9saXNwL2RpcmVkLmVsCmluZGV4IGQwZTU0N2JhMGIuLmIwMDRkODE0OTUgMTAwNjQ0Ci0t LSBhL2xpc3AvZGlyZWQuZWwKKysrIGIvbGlzcC9kaXJlZC5lbApAQCAtMjI4Miw3ICsyMjgy LDcgQEAgZGlyZWQtbW9kZS1vcGVyYXRlLW1lbnUKIChkZWZ1biBkaXJlZC1jb250ZXh0LW1l bnUgKG1lbnUgY2xpY2spCiAgICJQb3B1bGF0ZSBNRU5VIHdpdGggRGlyZWQgbW9kZSBjb21t YW5kcyBhdCBDTElDSy4iCiAgICh3aGVuIChtb3VzZS1wb3NuLXByb3BlcnR5IChldmVudC1z dGFydCBjbGljaykgJ2RpcmVkLWZpbGVuYW1lKQotICAgIChkZWZpbmUta2V5IG1lbnUgW2Rp cmVkLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yKQorICAgIChkZWZpbmUta2V5LWFm dGVyIG1lbnUgW2RpcmVkLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yICd0b3Atc2Vw YXJhdG9yKQogICAgIChsZXQgKChlYXN5LW1lbnUgKG1ha2Utc3BhcnNlLWtleW1hcCAiSW1t ZWRpYXRlIikpKQogICAgICAgKGVhc3ktbWVudS1kZWZpbmUgbmlsIGVhc3ktbWVudSBuaWwK ICAgICAgICAgJygiSW1tZWRpYXRlIgpAQCAtMjI5Miw3ICsyMjkyLDggQEAgZGlyZWQtY29u dGV4dC1tZW51CiAgICAgICAgICAgIDpoZWxwICJFZGl0IGZpbGUgYXQgbW91c2UgY2xpY2sg aW4gb3RoZXIgd2luZG93Il0pKQogICAgICAgKGRvbGlzdCAoaXRlbSAocmV2ZXJzZSAobG9v a3VwLWtleSBlYXN5LW1lbnUgW21lbnUtYmFyIGltbWVkaWF0ZV0pKSkKICAgICAgICAgKHdo ZW4gKGNvbnNwIGl0ZW0pCi0gICAgICAgICAgKGRlZmluZS1rZXkgbWVudSAodmVjdG9yIChj YXIgaXRlbSkpIChjZHIgaXRlbSkpKSkpKQorICAgICAgICAgIChkZWZpbmUta2V5LWFmdGVy IG1lbnUgKHZlY3RvciAoY2FyIGl0ZW0pKSAoY2RyIGl0ZW0pCisgICAgICAgICAgICAndG9w LXNlcGFyYXRvcikpKSkpCiAgIG1lbnUpCiAKIAwKZGlmZiAtLWdpdCBhL2xpc3AvaGVscC1t b2RlLmVsIGIvbGlzcC9oZWxwLW1vZGUuZWwKaW5kZXggNzkyZjJlNWFmMy4uMmVkMjA1Nzdm NSAxMDA2NDQKLS0tIGEvbGlzcC9oZWxwLW1vZGUuZWwKKysrIGIvbGlzcC9oZWxwLW1vZGUu ZWwKQEAgLTc0LDcgKzc0LDggQEAgaGVscC1tb2RlLW1lbnUKIAogKGRlZnVuIGhlbHAtbW9k ZS1jb250ZXh0LW1lbnUgKG1lbnUgY2xpY2spCiAgICJQb3B1bGF0ZSBNRU5VIHdpdGggSGVs cCBtb2RlIGNvbW1hbmRzIGF0IENMSUNLLiIKLSAgKGRlZmluZS1rZXkgbWVudSBbaGVscC1t b2RlLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yKQorICAoZGVmaW5lLWtleS1hZnRl ciBtZW51IFtoZWxwLW1vZGUtc2VwYXJhdG9yXSBtZW51LWJhci1zZXBhcmF0b3IKKyAgICAn dG9wLXNlcGFyYXRvcikKICAgKGxldCAoKGVhc3ktbWVudSAobWFrZS1zcGFyc2Uta2V5bWFw ICJIZWxwLU1vZGUiKSkpCiAgICAgKGVhc3ktbWVudS1kZWZpbmUgbmlsIGVhc3ktbWVudSBu aWwKICAgICAgICcoIkhlbHAtTW9kZSIKQEAgLTg2LDE0ICs4NywxNSBAQCBoZWxwLW1vZGUt Y29udGV4dC1tZW51CiAgICAgICAgICA6YWN0aXZlIGhlbHAteHJlZi1mb3J3YXJkLXN0YWNr XSkpCiAgICAgKGRvbGlzdCAoaXRlbSAocmV2ZXJzZSAobG9va3VwLWtleSBlYXN5LW1lbnUg W21lbnUtYmFyIGhlbHAtbW9kZV0pKSkKICAgICAgICh3aGVuIChjb25zcCBpdGVtKQotICAg ICAgICAoZGVmaW5lLWtleSBtZW51ICh2ZWN0b3IgKGNhciBpdGVtKSkgKGNkciBpdGVtKSkp KSkKKyAgICAgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSAodmVjdG9yIChjYXIgaXRlbSkp IChjZHIgaXRlbSkgJ3RvcC1zZXBhcmF0b3IpKSkpCiAKICAgKHdoZW4gKG1vdXNlLXBvc24t cHJvcGVydHkgKGV2ZW50LXN0YXJ0IGNsaWNrKSAnbW91c2UtZmFjZSkKLSAgICAoZGVmaW5l LWtleSBtZW51IFtoZWxwLW1vZGUtcHVzaC1idXR0b25dCisgICAgKGRlZmluZS1rZXktYWZ0 ZXIgbWVudSBbaGVscC1tb2RlLXB1c2gtYnV0dG9uXQogICAgICAgJyhtZW51LWl0ZW0gIkZv bGxvdyBMaW5rIiAobGFtYmRhIChldmVudCkKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoaW50ZXJhY3RpdmUgImUiKQogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChwdXNoLWJ1dHRvbiBldmVudCkpCi0gICAgICAgICAgICAgICAgICA6aGVscCAi Rm9sbG93IHRoZSBsaW5rIGF0IGNsaWNrIikpKQorICAgICAgICAgICAgICAgICAgOmhlbHAg IkZvbGxvdyB0aGUgbGluayBhdCBjbGljayIpCisgICAgICAndG9wLXNlcGFyYXRvcikpCiAK ICAgbWVudSkKIApkaWZmIC0tZ2l0IGEvbGlzcC9pbmZvLmVsIGIvbGlzcC9pbmZvLmVsCmlu ZGV4IDU1OTQ2MGU4ZDIuLjA1ZTkyNzc2OTggMTAwNjQ0Ci0tLSBhL2xpc3AvaW5mby5lbAor KysgYi9saXNwL2luZm8uZWwKQEAgLTQxOTMsNyArNDE5Myw3IEBAIEluZm8tY2hlY2stcG9p bnRlcgogCiAoZGVmdW4gSW5mby1jb250ZXh0LW1lbnUgKG1lbnUgY2xpY2spCiAgICJQb3B1 bGF0ZSBNRU5VIHdpdGggSW5mbyBjb21tYW5kcyBhdCBDTElDSy4iCi0gIChkZWZpbmUta2V5 IG1lbnUgW0luZm8tc2VwYXJhdG9yXSBtZW51LWJhci1zZXBhcmF0b3IpCisgIChkZWZpbmUt a2V5LWFmdGVyIG1lbnUgW0luZm8tc2VwYXJhdG9yXSBtZW51LWJhci1zZXBhcmF0b3IgJ3Rv cC1zZXBhcmF0b3IpCiAgIChsZXQgKChlYXN5LW1lbnUgKG1ha2Utc3BhcnNlLWtleW1hcCAi SW5mbyIpKSkKICAgICAoZWFzeS1tZW51LWRlZmluZSBuaWwgZWFzeS1tZW51IG5pbAogICAg ICAgJygiSW5mbyIKQEAgLTQyMDMsMTIgKzQyMDMsMTMgQEAgSW5mby1jb250ZXh0LW1lbnUK ICAgICAgICAgIDpoZWxwICJHbyBmb3J3YXJkIGluIGhpc3RvcnkiXSkpCiAgICAgKGRvbGlz dCAoaXRlbSAocmV2ZXJzZSAobG9va3VwLWtleSBlYXN5LW1lbnUgW21lbnUtYmFyIGluZm9d KSkpCiAgICAgICAod2hlbiAoY29uc3AgaXRlbSkKLSAgICAgICAgKGRlZmluZS1rZXkgbWVu dSAodmVjdG9yIChjYXIgaXRlbSkpIChjZHIgaXRlbSkpKSkpCisgICAgICAgIChkZWZpbmUt a2V5LWFmdGVyIG1lbnUgKHZlY3RvciAoY2FyIGl0ZW0pKSAoY2RyIGl0ZW0pICd0b3Atc2Vw YXJhdG9yKSkpKQogCiAgICh3aGVuIChtb3VzZS1wb3NuLXByb3BlcnR5IChldmVudC1zdGFy dCBjbGljaykgJ21vdXNlLWZhY2UpCi0gICAgKGRlZmluZS1rZXkgbWVudSBbSW5mby1tb3Vz ZS1mb2xsb3ctbmVhcmVzdC1ub2RlXQorICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW0lu Zm8tbW91c2UtZm9sbG93LW5lYXJlc3Qtbm9kZV0KICAgICAgICcobWVudS1pdGVtICJGb2xs b3cgTGluayIgSW5mby1tb3VzZS1mb2xsb3ctbmVhcmVzdC1ub2RlCi0gICAgICAgICAgICAg ICAgICA6aGVscCAiRm9sbG93IGEgbGluayB3aGVyZSB5b3UgY2xpY2siKSkpCisgICAgICAg ICAgICAgICAgICA6aGVscCAiRm9sbG93IGEgbGluayB3aGVyZSB5b3UgY2xpY2siKQorICAg ICAgJ3RvcC1zZXBhcmF0b3IpKQogCiAgIG1lbnUpCiAKZGlmZiAtLWdpdCBhL2xpc3AvbW91 c2UuZWwgYi9saXNwL21vdXNlLmVsCmluZGV4IGFmMWVjYTEyZjQuLjM2MDAzYTFkYjggMTAw NjQ0Ci0tLSBhL2xpc3AvbW91c2UuZWwKKysrIGIvbGlzcC9tb3VzZS5lbApAQCAtMzE5LDYg KzMxOSw5IEBAIGNvbnRleHQtbWVudS1tYXAKICAgICAgICAgIChjbGljayAob3IgY2xpY2sg bGFzdC1pbnB1dC1ldmVudCkpCiAgICAgICAgICAoZnVuIChtb3VzZS1wb3NuLXByb3BlcnR5 IChldmVudC1zdGFydCBjbGljaykKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJ2NvbnRleHQtbWVudS1mdW5jdGlvbikpKQorICAgIDs7IEFkZCBhIHNlcGFyYXRvciB0 byB0aGUgdG9wIG9mIHRoZSBtZW51IHRvIHByb3ZpZGUgYW4gYW5jaG9yIGZvcgorICAgIDs7 IGNvbnRleHQgbWVudSBmdW5jdGlvbnMgdG8gdXNlLgorICAgIChkZWZpbmUta2V5LWFmdGVy IG1lbnUgW3RvcC1zZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRvcikKIAogICAgIChpZiAo ZnVuY3Rpb25wIGZ1bikKICAgICAgICAgKHNldHEgbWVudSAoZnVuY2FsbCBmdW4gbWVudSBj bGljaykpCmRpZmYgLS1naXQgYS9saXNwL25ldC9ld3cuZWwgYi9saXNwL25ldC9ld3cuZWwK aW5kZXggZTg2ZDIxZjg4OS4uNzMwM2UwMWEzNyAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvZXd3 LmVsCisrKyBiL2xpc3AvbmV0L2V3dy5lbApAQCAtMTEwNiw3ICsxMTA2LDcgQEAgZXd3LW1v ZGUtbWFwCiAKIChkZWZ1biBld3ctY29udGV4dC1tZW51IChtZW51IGNsaWNrKQogICAiUG9w dWxhdGUgTUVOVSB3aXRoIGV3dyBjb21tYW5kcyBhdCBDTElDSy4iCi0gIChkZWZpbmUta2V5 IG1lbnUgW2V3dy1zZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRvcikKKyAgKGRlZmluZS1r ZXktYWZ0ZXIgbWVudSBbZXd3LXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yICd0b3At c2VwYXJhdG9yKQogICAobGV0ICgoZWFzeS1tZW51IChtYWtlLXNwYXJzZS1rZXltYXAgIkV3 dyIpKSkKICAgICAoZWFzeS1tZW51LWRlZmluZSBuaWwgZWFzeS1tZW51IG5pbAogICAgICAg JygiRXd3IgpAQCAtMTExNywyMCArMTExNywyMiBAQCBld3ctY29udGV4dC1tZW51CiAJWyJS ZWxvYWQiIGV3dy1yZWxvYWQgdF0pKQogICAgIChkb2xpc3QgKGl0ZW0gKHJldmVyc2UgKGxv b2t1cC1rZXkgZWFzeS1tZW51IFttZW51LWJhciBld3ddKSkpCiAgICAgICAod2hlbiAoY29u c3AgaXRlbSkKLSAgICAgICAgKGRlZmluZS1rZXkgbWVudSAodmVjdG9yIChjYXIgaXRlbSkp IChjZHIgaXRlbSkpKSkpCisgICAgICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgKHZlY3Rv ciAoY2FyIGl0ZW0pKSAoY2RyIGl0ZW0pICd0b3Atc2VwYXJhdG9yKSkpKQogCiAgICh3aGVu IChvciAobW91c2UtcG9zbi1wcm9wZXJ0eSAoZXZlbnQtc3RhcnQgY2xpY2spICdzaHItdXJs KQogICAgICAgICAgICAgKG1vdXNlLXBvc24tcHJvcGVydHkgKGV2ZW50LXN0YXJ0IGNsaWNr KSAnaW1hZ2UtdXJsKSkKLSAgICAoZGVmaW5lLWtleSBtZW51IFtzaHItbW91c2UtYnJvd3Nl LXVybC1uZXctd2luZG93XQorICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW3Noci1tb3Vz ZS1icm93c2UtdXJsLW5ldy13aW5kb3ddCiAgICAgICBgKG1lbnUtaXRlbSAiRm9sbG93IFVS TCBpbiBuZXcgd2luZG93IiAsKGlmIGJyb3dzZS11cmwtbmV3LXdpbmRvdy1mbGFnCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdzaHItbW91 c2UtYnJvd3NlLXVybAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJ3Noci1tb3VzZS1icm93c2UtdXJsLW5ldy13aW5kb3cpCi0gICAgICAgICAg ICAgICAgICA6aGVscCAiQnJvd3NlIHRoZSBVUkwgdW5kZXIgdGhlIG1vdXNlIGN1cnNvciBp biBhIG5ldyB3aW5kb3ciKSkKLSAgICAoZGVmaW5lLWtleSBtZW51IFtzaHItbW91c2UtYnJv d3NlLXVybF0KKyAgICAgICAgICAgICAgICAgIDpoZWxwICJCcm93c2UgdGhlIFVSTCB1bmRl ciB0aGUgbW91c2UgY3Vyc29yIGluIGEgbmV3IHdpbmRvdyIpCisgICAgICAndG9wLXNlcGFy YXRvcikKKyAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtzaHItbW91c2UtYnJvd3NlLXVy bF0KICAgICAgIGAobWVudS1pdGVtICJGb2xsb3cgVVJMIiAsKGlmIGJyb3dzZS11cmwtbmV3 LXdpbmRvdy1mbGFnCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnc2hy LW1vdXNlLWJyb3dzZS11cmwtbmV3LXdpbmRvdwogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICdzaHItbW91c2UtYnJvd3NlLXVybCkKLSAgICAgICAgICAgICAgICAgIDpo ZWxwICJCcm93c2UgdGhlIFVSTCB1bmRlciB0aGUgbW91c2UgY3Vyc29yIikpKQorICAgICAg ICAgICAgICAgICAgOmhlbHAgIkJyb3dzZSB0aGUgVVJMIHVuZGVyIHRoZSBtb3VzZSBjdXJz b3IiKQorICAgICAgJ3RvcC1zZXBhcmF0b3IpKQogCiAgIG1lbnUpCiAKZGlmZiAtLWdpdCBh L2xpc3AvbmV0L2dvdG8tYWRkci5lbCBiL2xpc3AvbmV0L2dvdG8tYWRkci5lbAppbmRleCA4 NDhiYWQzYjBkLi5iYjBmMGIwMGVlIDEwMDY0NAotLS0gYS9saXNwL25ldC9nb3RvLWFkZHIu ZWwKKysrIGIvbGlzcC9uZXQvZ290by1hZGRyLmVsCkBAIC0xMjcsMTAgKzEyNywxMiBAQCBn b3RvLWFkZHJlc3MtaGlnaGxpZ2h0LWtleW1hcAogKGRlZnVuIGdvdG8tYWRkcmVzcy1jb250 ZXh0LW1lbnUgKG1lbnUgY2xpY2spCiAgICJQb3B1bGF0ZSBNRU5VIHdpdGggYGdvdG8tYWRk cmVzcycgY29tbWFuZHMgYXQgQ0xJQ0suIgogICAod2hlbiAobW91c2UtcG9zbi1wcm9wZXJ0 eSAoZXZlbnQtc3RhcnQgY2xpY2spICdnb3RvLWFkZHJlc3MpCi0gICAgKGRlZmluZS1rZXkg bWVudSBbZ290by1hZGRyZXNzLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yKQotICAg IChkZWZpbmUta2V5IG1lbnUgW2dvdG8tYWRkcmVzcy1hdC1tb3VzZV0KKyAgICAoZGVmaW5l LWtleS1hZnRlciBtZW51IFtnb3RvLWFkZHJlc3Mtc2VwYXJhdG9yXSBtZW51LWJhci1zZXBh cmF0b3IKKyAgICAgICd0b3Atc2VwYXJhdG9yKQorICAgIChkZWZpbmUta2V5LWFmdGVyIG1l bnUgW2dvdG8tYWRkcmVzcy1hdC1tb3VzZV0KICAgICAgICcobWVudS1pdGVtICJGb2xsb3cg TGluayIgZ290by1hZGRyZXNzLWF0LW1vdXNlCi0gICAgICAgICAgICAgICAgICA6aGVscCAi Rm9sbG93IGEgbGluayB3aGVyZSB5b3UgY2xpY2siKSkpCisgICAgICAgICAgICAgICAgICA6 aGVscCAiRm9sbG93IGEgbGluayB3aGVyZSB5b3UgY2xpY2siKQorICAgICAgJ3RvcC1zZXBh cmF0b3IpKQogICBtZW51KQogCiAoZGVmY3VzdG9tIGdvdG8tYWRkcmVzcy11cmwtZmFjZSAn bGluawotLSAKMi4yNS4xCgo= --------------3BFF642EC8504B50DEC78DF1-- From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v2] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Dec 2021 08:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16388660386332 (code B ref 52293); Tue, 07 Dec 2021 08:34:02 +0000 Received: (at 52293) by debbugs.gnu.org; 7 Dec 2021 08:33:58 +0000 Received: from localhost ([127.0.0.1]:36303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muVvC-0001e4-5B for submit@debbugs.gnu.org; Tue, 07 Dec 2021 03:33:58 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:45225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muVvA-0001dc-MM for 52293@debbugs.gnu.org; Tue, 07 Dec 2021 03:33:57 -0500 Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id BA6061C0002; Tue, 7 Dec 2021 08:33:48 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> Date: Tue, 07 Dec 2021 10:19:20 +0200 In-Reply-To: <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> (Jim Porter's message of "Mon, 6 Dec 2021 19:54:11 -0800") Message-ID: <86h7bkhlo7.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > For the top separator, maybe instead of providing a function for users to > put wherever they like in `context-menu-functions', we could just add it > directly in `context-menu-map' immediately before calling the functions in > `context-menu-functions'? Since it's supposed to be at the top, it doesn't > make a lot of sense to be able to customize where it goes. > > It does makes sense to customize where `middle-separator' goes though; what > the user considers the "middle" depends on what other menu items are > normally present. However, if the user didn't include > `context-menu-middle-separator', then > > (define-key-after menu [foo] '(menu-item ...) 'middle-separator) > > just adds `foo' to the end of the menu. That seems ok to me. Then, adding > after `top-separator' puts your item at the beginning of the menu, and > adding after `middle-separator' puts your item at the middle or the end, > depending on the user's configuration. How does that sound to you? Thanks, this makes perfect sense. I vote for pushing this to emacs-28, so the authors of packages could rely on this scheme. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Dec 2021 04:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163893826017728 (code B ref 52293); Wed, 08 Dec 2021 04:38:02 +0000 Received: (at 52293) by debbugs.gnu.org; 8 Dec 2021 04:37:40 +0000 Received: from localhost ([127.0.0.1]:39357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muoi2-0004br-Pn for submit@debbugs.gnu.org; Tue, 07 Dec 2021 23:37:39 -0500 Received: from mail-pg1-f177.google.com ([209.85.215.177]:37483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muohy-0004bZ-UR for 52293@debbugs.gnu.org; Tue, 07 Dec 2021 23:37:37 -0500 Received: by mail-pg1-f177.google.com with SMTP id 71so1022847pgb.4 for <52293@debbugs.gnu.org>; Tue, 07 Dec 2021 20:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=7QPrtw6eItrlabwz0GVNkOq5w/CF25uKFRmdEsvXLc8=; b=ZFLQukqEsB1lgvRCCWgmpobGUAmi9O6TzdSZUKoEOHOQ+Mjshp8ZUwulCLrSr+T5ik 6fpsjyp4xyfqDs83Hs5ToZnE1iWFWExWu+TCL3CRzEIlC2fQTwP0vBtQrHn3Mbx1QAqN DTscnqUSAOqnKnfeNFfUyMYIsfjua61XyNstVqWA3ckEpr+tuf3nN0gF9iM9nS1e+s74 VG37s4IVX8E4/4yeA3b2EyJbGL2fFd9ZCr1p1TSwrSOaz6qNbGUqbdXCBFbj9zyoHYS4 p1WKT5ZWgi/KJlJj0LL9SBKh4geTXt8Yu0gCvjH3YNOOevJQVsdQRYNSJptq9UjFqXtq W0Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=7QPrtw6eItrlabwz0GVNkOq5w/CF25uKFRmdEsvXLc8=; b=GcM5N2Bm0/vTHLroPDCGIZaPHlfF5G1X6TpzlntcCRlr6EJ0HyNGEIVO6a5I3kbbTZ kBjlTWTSG4qtqunZxtt+rQ47NPFpIvPipVPzc5c95RUrY8hANjwE87HeuMxEiCrMHDON M5LHkjSbS91moUsPq+AuXWfceUOG1rN+2A30W8BT9Qt4Kb1pOEqSU5SJkLCbTIeIsHq2 aDmXNM1ZLfo/LgIVvcfMp7CaLVhlkUJdStFO8d9sEJ5VPQDe/KuJPU3nKQ570bXYxOo9 l52/VUt75/hIk5A4hsN5Qy2PVc8cWc5Q+hoaYdV0TxcAhw3lvqHPunhSsiqqsvN3sZqC 8HUw== X-Gm-Message-State: AOAM531QYHzldsTk2bkkmH+scIiHlqmjUksirgxF2Y/IK4J72V/0IvEE nlVbSACkiFE+jivOa9hzoTua6A9is5I= X-Google-Smtp-Source: ABdhPJx0eDugKY9Cn09QzzbIzvYuc1N4hcTs8h+m37SAW3C85q0jceLoeM0ZSPeW93ys/0VBEnhtxQ== X-Received: by 2002:a05:6a00:1145:b0:4a2:6a03:c592 with SMTP id b5-20020a056a00114500b004a26a03c592mr3301995pfm.65.1638938249034; Tue, 07 Dec 2021 20:37:29 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b35sm953582pgb.83.2021.12.07.20.37.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Dec 2021 20:37:28 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> From: Jim Porter Message-ID: <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> Date: Tue, 7 Dec 2021 20:37:28 -0800 MIME-Version: 1.0 In-Reply-To: <86h7bkhlo7.fsf@mail.linkov.net> Content-Type: multipart/mixed; boundary="------------2E6081CC01A1698AE7EF2A8D" Content-Language: en-US X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------2E6081CC01A1698AE7EF2A8D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/7/2021 12:19 AM, Juri Linkov wrote: > Thanks, this makes perfect sense. I vote for pushing this to emacs-28, > so the authors of packages could rely on this scheme. Sounds good. Attached is an updated patch with an expanded docstring for `context-menu-functions' that mentions the existence of `top-separator' and `middle-separator' and how to use them. Everything else is the same as v2 though. --------------2E6081CC01A1698AE7EF2A8D Content-Type: text/plain; charset=UTF-8; name="0001-Add-a-top-separator-to-the-context-menu.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Add-a-top-separator-to-the-context-menu.patch" RnJvbSA4OWZlZjEyNDRlYmQ1NTA0MWViNDE1ZWY3YjlkNTllM2IxMDE0YWRjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgNyBEZWMgMjAyMSAyMDozNDowOCAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIEFkZCBhICd0b3Atc2VwYXJhdG9yJyB0byB0aGUgY29udGV4dCBtZW51CgpUaGlzIHBy b3ZpZGVzIGFuIGFuY2hvciBmb3IgY29udGV4dCBtZW51IGZ1bmN0aW9ucyB0byB1c2UgdG8g aW5zZXJ0CnRoZWlyIG1lbnUgaXRlbXMgYWZ0ZXIgaXQuIFVzaW5nICdkZWZpbmUta2V5JyBk b2Vzbid0IHdvcmsgcHJvcGVybHkgaW4KdGhpcyBjYXNlLCBzaW5jZSBpdCBpbnNlcnRzIHRo ZSBpdGVtcyBiZWZvcmUgdGhlIG1lbnUgdGl0bGUsIGNvbmZ1c2luZwp0aGUgc2VwYXJhdG9y IGRlLWR1cGxpY2F0aW9uIGluICdjb250ZXh0LW1lbnUtbWFwJy4KCiogbGlzcC9tb3VzZS5l bCAoY29udGV4dC1tZW51LWZ1bmN0aW9ucyk6IE1lbnRpb24gJ3RvcC1zZXBhcmF0b3InLAon bWlkZGxlLXNlcGFyYXRvcicsIGFuZCBob3cgdG8gdXNlIHRoZW0uCihjb250ZXh0LW1lbnUt bWFwKTogQWRkICd0b3Atc2VwYXJhdG9yJyB0byB0aGUgbWVudS4KKiBsaXNwL2RpcmVkLmVs IChkaXJlZC1jb250ZXh0LW1lbnUpOgoqIGxpc3AvaGVscC1tb2RlLmVsIChoZWxwLW1vZGUt Y29udGV4dC1tZW51KToKKiBsaXNwL2luZm8uZWwgKEluZm8tY29udGV4dC1tZW51KToKKiBs aXNwL25ldC9ld3cuZWwgKGV3dy1jb250ZXh0LW1lbnUpOgoqIGxpc3AvbmV0L2dvdG8tYWRk ci5lbCAoZ290by1hZGRyZXNzLWNvbnRleHQtbWVudSk6ClVzZSAndG9wLXNlcGFyYXRvcicu Ci0tLQogbGlzcC9kaXJlZC5lbCAgICAgICAgIHwgIDUgKysrLS0KIGxpc3AvaGVscC1tb2Rl LmVsICAgICB8IDEwICsrKysrKy0tLS0KIGxpc3AvaW5mby5lbCAgICAgICAgICB8ICA5ICsr KysrLS0tLQogbGlzcC9tb3VzZS5lbCAgICAgICAgIHwgMTEgKysrKysrKysrKy0KIGxpc3Av bmV0L2V3dy5lbCAgICAgICB8IDE0ICsrKysrKysrLS0tLS0tCiBsaXNwL25ldC9nb3RvLWFk ZHIuZWwgfCAgOCArKysrKy0tLQogNiBmaWxlcyBjaGFuZ2VkLCAzNyBpbnNlcnRpb25zKCsp LCAyMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2RpcmVkLmVsIGIvbGlzcC9k aXJlZC5lbAppbmRleCBkMGU1NDdiYTBiLi5iMDA0ZDgxNDk1IDEwMDY0NAotLS0gYS9saXNw L2RpcmVkLmVsCisrKyBiL2xpc3AvZGlyZWQuZWwKQEAgLTIyODIsNyArMjI4Miw3IEBAIGRp cmVkLW1vZGUtb3BlcmF0ZS1tZW51CiAoZGVmdW4gZGlyZWQtY29udGV4dC1tZW51IChtZW51 IGNsaWNrKQogICAiUG9wdWxhdGUgTUVOVSB3aXRoIERpcmVkIG1vZGUgY29tbWFuZHMgYXQg Q0xJQ0suIgogICAod2hlbiAobW91c2UtcG9zbi1wcm9wZXJ0eSAoZXZlbnQtc3RhcnQgY2xp Y2spICdkaXJlZC1maWxlbmFtZSkKLSAgICAoZGVmaW5lLWtleSBtZW51IFtkaXJlZC1zZXBh cmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRvcikKKyAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51 IFtkaXJlZC1zZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRvciAndG9wLXNlcGFyYXRvcikK ICAgICAobGV0ICgoZWFzeS1tZW51IChtYWtlLXNwYXJzZS1rZXltYXAgIkltbWVkaWF0ZSIp KSkKICAgICAgIChlYXN5LW1lbnUtZGVmaW5lIG5pbCBlYXN5LW1lbnUgbmlsCiAgICAgICAg ICcoIkltbWVkaWF0ZSIKQEAgLTIyOTIsNyArMjI5Miw4IEBAIGRpcmVkLWNvbnRleHQtbWVu dQogICAgICAgICAgICA6aGVscCAiRWRpdCBmaWxlIGF0IG1vdXNlIGNsaWNrIGluIG90aGVy IHdpbmRvdyJdKSkKICAgICAgIChkb2xpc3QgKGl0ZW0gKHJldmVyc2UgKGxvb2t1cC1rZXkg ZWFzeS1tZW51IFttZW51LWJhciBpbW1lZGlhdGVdKSkpCiAgICAgICAgICh3aGVuIChjb25z cCBpdGVtKQotICAgICAgICAgIChkZWZpbmUta2V5IG1lbnUgKHZlY3RvciAoY2FyIGl0ZW0p KSAoY2RyIGl0ZW0pKSkpKSkKKyAgICAgICAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51ICh2 ZWN0b3IgKGNhciBpdGVtKSkgKGNkciBpdGVtKQorICAgICAgICAgICAgJ3RvcC1zZXBhcmF0 b3IpKSkpKQogICBtZW51KQogCiAMCmRpZmYgLS1naXQgYS9saXNwL2hlbHAtbW9kZS5lbCBi L2xpc3AvaGVscC1tb2RlLmVsCmluZGV4IDc5MmYyZTVhZjMuLjJlZDIwNTc3ZjUgMTAwNjQ0 Ci0tLSBhL2xpc3AvaGVscC1tb2RlLmVsCisrKyBiL2xpc3AvaGVscC1tb2RlLmVsCkBAIC03 NCw3ICs3NCw4IEBAIGhlbHAtbW9kZS1tZW51CiAKIChkZWZ1biBoZWxwLW1vZGUtY29udGV4 dC1tZW51IChtZW51IGNsaWNrKQogICAiUG9wdWxhdGUgTUVOVSB3aXRoIEhlbHAgbW9kZSBj b21tYW5kcyBhdCBDTElDSy4iCi0gIChkZWZpbmUta2V5IG1lbnUgW2hlbHAtbW9kZS1zZXBh cmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRvcikKKyAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBb aGVscC1tb2RlLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yCisgICAgJ3RvcC1zZXBh cmF0b3IpCiAgIChsZXQgKChlYXN5LW1lbnUgKG1ha2Utc3BhcnNlLWtleW1hcCAiSGVscC1N b2RlIikpKQogICAgIChlYXN5LW1lbnUtZGVmaW5lIG5pbCBlYXN5LW1lbnUgbmlsCiAgICAg ICAnKCJIZWxwLU1vZGUiCkBAIC04NiwxNCArODcsMTUgQEAgaGVscC1tb2RlLWNvbnRleHQt bWVudQogICAgICAgICAgOmFjdGl2ZSBoZWxwLXhyZWYtZm9yd2FyZC1zdGFja10pKQogICAg IChkb2xpc3QgKGl0ZW0gKHJldmVyc2UgKGxvb2t1cC1rZXkgZWFzeS1tZW51IFttZW51LWJh ciBoZWxwLW1vZGVdKSkpCiAgICAgICAod2hlbiAoY29uc3AgaXRlbSkKLSAgICAgICAgKGRl ZmluZS1rZXkgbWVudSAodmVjdG9yIChjYXIgaXRlbSkpIChjZHIgaXRlbSkpKSkpCisgICAg ICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgKHZlY3RvciAoY2FyIGl0ZW0pKSAoY2RyIGl0 ZW0pICd0b3Atc2VwYXJhdG9yKSkpKQogCiAgICh3aGVuIChtb3VzZS1wb3NuLXByb3BlcnR5 IChldmVudC1zdGFydCBjbGljaykgJ21vdXNlLWZhY2UpCi0gICAgKGRlZmluZS1rZXkgbWVu dSBbaGVscC1tb2RlLXB1c2gtYnV0dG9uXQorICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUg W2hlbHAtbW9kZS1wdXNoLWJ1dHRvbl0KICAgICAgICcobWVudS1pdGVtICJGb2xsb3cgTGlu ayIgKGxhbWJkYSAoZXZlbnQpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGludGVyYWN0aXZlICJlIikKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo cHVzaC1idXR0b24gZXZlbnQpKQotICAgICAgICAgICAgICAgICAgOmhlbHAgIkZvbGxvdyB0 aGUgbGluayBhdCBjbGljayIpKSkKKyAgICAgICAgICAgICAgICAgIDpoZWxwICJGb2xsb3cg dGhlIGxpbmsgYXQgY2xpY2siKQorICAgICAgJ3RvcC1zZXBhcmF0b3IpKQogCiAgIG1lbnUp CiAKZGlmZiAtLWdpdCBhL2xpc3AvaW5mby5lbCBiL2xpc3AvaW5mby5lbAppbmRleCA1NTk0 NjBlOGQyLi4wNWU5Mjc3Njk4IDEwMDY0NAotLS0gYS9saXNwL2luZm8uZWwKKysrIGIvbGlz cC9pbmZvLmVsCkBAIC00MTkzLDcgKzQxOTMsNyBAQCBJbmZvLWNoZWNrLXBvaW50ZXIKIAog KGRlZnVuIEluZm8tY29udGV4dC1tZW51IChtZW51IGNsaWNrKQogICAiUG9wdWxhdGUgTUVO VSB3aXRoIEluZm8gY29tbWFuZHMgYXQgQ0xJQ0suIgotICAoZGVmaW5lLWtleSBtZW51IFtJ bmZvLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yKQorICAoZGVmaW5lLWtleS1hZnRl ciBtZW51IFtJbmZvLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yICd0b3Atc2VwYXJh dG9yKQogICAobGV0ICgoZWFzeS1tZW51IChtYWtlLXNwYXJzZS1rZXltYXAgIkluZm8iKSkp CiAgICAgKGVhc3ktbWVudS1kZWZpbmUgbmlsIGVhc3ktbWVudSBuaWwKICAgICAgICcoIklu Zm8iCkBAIC00MjAzLDEyICs0MjAzLDEzIEBAIEluZm8tY29udGV4dC1tZW51CiAgICAgICAg ICA6aGVscCAiR28gZm9yd2FyZCBpbiBoaXN0b3J5Il0pKQogICAgIChkb2xpc3QgKGl0ZW0g KHJldmVyc2UgKGxvb2t1cC1rZXkgZWFzeS1tZW51IFttZW51LWJhciBpbmZvXSkpKQogICAg ICAgKHdoZW4gKGNvbnNwIGl0ZW0pCi0gICAgICAgIChkZWZpbmUta2V5IG1lbnUgKHZlY3Rv ciAoY2FyIGl0ZW0pKSAoY2RyIGl0ZW0pKSkpKQorICAgICAgICAoZGVmaW5lLWtleS1hZnRl ciBtZW51ICh2ZWN0b3IgKGNhciBpdGVtKSkgKGNkciBpdGVtKSAndG9wLXNlcGFyYXRvcikp KSkKIAogICAod2hlbiAobW91c2UtcG9zbi1wcm9wZXJ0eSAoZXZlbnQtc3RhcnQgY2xpY2sp ICdtb3VzZS1mYWNlKQotICAgIChkZWZpbmUta2V5IG1lbnUgW0luZm8tbW91c2UtZm9sbG93 LW5lYXJlc3Qtbm9kZV0KKyAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtJbmZvLW1vdXNl LWZvbGxvdy1uZWFyZXN0LW5vZGVdCiAgICAgICAnKG1lbnUtaXRlbSAiRm9sbG93IExpbmsi IEluZm8tbW91c2UtZm9sbG93LW5lYXJlc3Qtbm9kZQotICAgICAgICAgICAgICAgICAgOmhl bHAgIkZvbGxvdyBhIGxpbmsgd2hlcmUgeW91IGNsaWNrIikpKQorICAgICAgICAgICAgICAg ICAgOmhlbHAgIkZvbGxvdyBhIGxpbmsgd2hlcmUgeW91IGNsaWNrIikKKyAgICAgICd0b3At c2VwYXJhdG9yKSkKIAogICBtZW51KQogCmRpZmYgLS1naXQgYS9saXNwL21vdXNlLmVsIGIv bGlzcC9tb3VzZS5lbAppbmRleCBhZjFlY2ExMmY0Li43NDRkZjVmOTE4IDEwMDY0NAotLS0g YS9saXNwL21vdXNlLmVsCisrKyBiL2xpc3AvbW91c2UuZWwKQEAgLTI4Niw3ICsyODYsMTMg QEAgY29udGV4dC1tZW51LWZ1bmN0aW9ucwogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgY29udGV4dC1tZW51LW1pbm9yKQogICAiTGlzdCBvZiBmdW5jdGlvbnMgdGhh dCBwcm9kdWNlIHRoZSBjb250ZW50cyBvZiB0aGUgY29udGV4dCBtZW51LgogRWFjaCBmdW5j dGlvbiByZWNlaXZlcyB0aGUgbWVudSBhbmQgdGhlIG1vdXNlIGNsaWNrIGV2ZW50IGFzIGl0 cyBhcmd1bWVudHMKLWFuZCBzaG91bGQgcmV0dXJuIHRoZSBzYW1lIG1lbnUgd2l0aCBjaGFu Z2VzIHN1Y2ggYXMgYWRkZWQgbmV3IG1lbnUgaXRlbXMuIgorYW5kIHNob3VsZCByZXR1cm4g dGhlIHNhbWUgbWVudSB3aXRoIGNoYW5nZXMgc3VjaCBhcyBhZGRlZCBuZXcgbWVudSBpdGVt cy4KKworRnVuY3Rpb25zIGNhbiBpbnNlcnQgbmV3IG1lbnUgaXRlbXMgaW4gd2hhdGV2ZXIg b3JkZXIgbWFrZXMgc2Vuc2UgdG8gdGhlbS4KK1RvIGhlbHAgc2ltcGxpZnkgdGhlIHBsYWNl bWVudCBvZiBuZXcgaXRlbXMsIHRoZSBtZW51IHByb3ZpZGVzIHRoZQorc2VwYXJhdG9ycyBg dG9wLXNlcGFyYXRvcicgYW5kIGBtaWRkbGUtc2VwYXJhdG9yJywgd2hpY2ggY2FuIGJlIHBh c3NlZCBhcwordGhlIGxhc3QgYXJndW1lbnQgdG8gYGRlZmluZS1rZXktYWZ0ZXInIGluIG9y ZGVyIHRvIHBvc2l0aW9uIHRoZSBuZXcgaXRlbQorYWNjb3JkaW5nbHkuIgogICA6dHlwZSAn KHJlcGVhdAogICAgICAgICAgIChjaG9pY2UgKGZ1bmN0aW9uLWl0ZW0gY29udGV4dC1tZW51 LXVuZG8pCiAgICAgICAgICAgICAgICAgICAoZnVuY3Rpb24taXRlbSBjb250ZXh0LW1lbnUt cmVnaW9uKQpAQCAtMzE5LDYgKzMyNSw5IEBAIGNvbnRleHQtbWVudS1tYXAKICAgICAgICAg IChjbGljayAob3IgY2xpY2sgbGFzdC1pbnB1dC1ldmVudCkpCiAgICAgICAgICAoZnVuICht b3VzZS1wb3NuLXByb3BlcnR5IChldmVudC1zdGFydCBjbGljaykKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJ2NvbnRleHQtbWVudS1mdW5jdGlvbikpKQorICAgIDs7 IEFkZCBhIHNlcGFyYXRvciB0byB0aGUgdG9wIG9mIHRoZSBtZW51IHRvIHByb3ZpZGUgYW4g YW5jaG9yIGZvcgorICAgIDs7IGNvbnRleHQgbWVudSBmdW5jdGlvbnMgdG8gdXNlLgorICAg IChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW3RvcC1zZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFy YXRvcikKIAogICAgIChpZiAoZnVuY3Rpb25wIGZ1bikKICAgICAgICAgKHNldHEgbWVudSAo ZnVuY2FsbCBmdW4gbWVudSBjbGljaykpCmRpZmYgLS1naXQgYS9saXNwL25ldC9ld3cuZWwg Yi9saXNwL25ldC9ld3cuZWwKaW5kZXggZTg2ZDIxZjg4OS4uNzMwM2UwMWEzNyAxMDA2NDQK LS0tIGEvbGlzcC9uZXQvZXd3LmVsCisrKyBiL2xpc3AvbmV0L2V3dy5lbApAQCAtMTEwNiw3 ICsxMTA2LDcgQEAgZXd3LW1vZGUtbWFwCiAKIChkZWZ1biBld3ctY29udGV4dC1tZW51ICht ZW51IGNsaWNrKQogICAiUG9wdWxhdGUgTUVOVSB3aXRoIGV3dyBjb21tYW5kcyBhdCBDTElD Sy4iCi0gIChkZWZpbmUta2V5IG1lbnUgW2V3dy1zZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFy YXRvcikKKyAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbZXd3LXNlcGFyYXRvcl0gbWVudS1i YXItc2VwYXJhdG9yICd0b3Atc2VwYXJhdG9yKQogICAobGV0ICgoZWFzeS1tZW51IChtYWtl LXNwYXJzZS1rZXltYXAgIkV3dyIpKSkKICAgICAoZWFzeS1tZW51LWRlZmluZSBuaWwgZWFz eS1tZW51IG5pbAogICAgICAgJygiRXd3IgpAQCAtMTExNywyMCArMTExNywyMiBAQCBld3ct Y29udGV4dC1tZW51CiAJWyJSZWxvYWQiIGV3dy1yZWxvYWQgdF0pKQogICAgIChkb2xpc3Qg KGl0ZW0gKHJldmVyc2UgKGxvb2t1cC1rZXkgZWFzeS1tZW51IFttZW51LWJhciBld3ddKSkp CiAgICAgICAod2hlbiAoY29uc3AgaXRlbSkKLSAgICAgICAgKGRlZmluZS1rZXkgbWVudSAo dmVjdG9yIChjYXIgaXRlbSkpIChjZHIgaXRlbSkpKSkpCisgICAgICAgIChkZWZpbmUta2V5 LWFmdGVyIG1lbnUgKHZlY3RvciAoY2FyIGl0ZW0pKSAoY2RyIGl0ZW0pICd0b3Atc2VwYXJh dG9yKSkpKQogCiAgICh3aGVuIChvciAobW91c2UtcG9zbi1wcm9wZXJ0eSAoZXZlbnQtc3Rh cnQgY2xpY2spICdzaHItdXJsKQogICAgICAgICAgICAgKG1vdXNlLXBvc24tcHJvcGVydHkg KGV2ZW50LXN0YXJ0IGNsaWNrKSAnaW1hZ2UtdXJsKSkKLSAgICAoZGVmaW5lLWtleSBtZW51 IFtzaHItbW91c2UtYnJvd3NlLXVybC1uZXctd2luZG93XQorICAgIChkZWZpbmUta2V5LWFm dGVyIG1lbnUgW3Noci1tb3VzZS1icm93c2UtdXJsLW5ldy13aW5kb3ddCiAgICAgICBgKG1l bnUtaXRlbSAiRm9sbG93IFVSTCBpbiBuZXcgd2luZG93IiAsKGlmIGJyb3dzZS11cmwtbmV3 LXdpbmRvdy1mbGFnCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICdzaHItbW91c2UtYnJvd3NlLXVybAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3Noci1tb3VzZS1icm93c2UtdXJsLW5ldy13 aW5kb3cpCi0gICAgICAgICAgICAgICAgICA6aGVscCAiQnJvd3NlIHRoZSBVUkwgdW5kZXIg dGhlIG1vdXNlIGN1cnNvciBpbiBhIG5ldyB3aW5kb3ciKSkKLSAgICAoZGVmaW5lLWtleSBt ZW51IFtzaHItbW91c2UtYnJvd3NlLXVybF0KKyAgICAgICAgICAgICAgICAgIDpoZWxwICJC cm93c2UgdGhlIFVSTCB1bmRlciB0aGUgbW91c2UgY3Vyc29yIGluIGEgbmV3IHdpbmRvdyIp CisgICAgICAndG9wLXNlcGFyYXRvcikKKyAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtz aHItbW91c2UtYnJvd3NlLXVybF0KICAgICAgIGAobWVudS1pdGVtICJGb2xsb3cgVVJMIiAs KGlmIGJyb3dzZS11cmwtbmV3LXdpbmRvdy1mbGFnCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAnc2hyLW1vdXNlLWJyb3dzZS11cmwtbmV3LXdpbmRvdwogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICdzaHItbW91c2UtYnJvd3NlLXVybCkKLSAg ICAgICAgICAgICAgICAgIDpoZWxwICJCcm93c2UgdGhlIFVSTCB1bmRlciB0aGUgbW91c2Ug Y3Vyc29yIikpKQorICAgICAgICAgICAgICAgICAgOmhlbHAgIkJyb3dzZSB0aGUgVVJMIHVu ZGVyIHRoZSBtb3VzZSBjdXJzb3IiKQorICAgICAgJ3RvcC1zZXBhcmF0b3IpKQogCiAgIG1l bnUpCiAKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2dvdG8tYWRkci5lbCBiL2xpc3AvbmV0L2dv dG8tYWRkci5lbAppbmRleCA4NDhiYWQzYjBkLi5iYjBmMGIwMGVlIDEwMDY0NAotLS0gYS9s aXNwL25ldC9nb3RvLWFkZHIuZWwKKysrIGIvbGlzcC9uZXQvZ290by1hZGRyLmVsCkBAIC0x MjcsMTAgKzEyNywxMiBAQCBnb3RvLWFkZHJlc3MtaGlnaGxpZ2h0LWtleW1hcAogKGRlZnVu IGdvdG8tYWRkcmVzcy1jb250ZXh0LW1lbnUgKG1lbnUgY2xpY2spCiAgICJQb3B1bGF0ZSBN RU5VIHdpdGggYGdvdG8tYWRkcmVzcycgY29tbWFuZHMgYXQgQ0xJQ0suIgogICAod2hlbiAo bW91c2UtcG9zbi1wcm9wZXJ0eSAoZXZlbnQtc3RhcnQgY2xpY2spICdnb3RvLWFkZHJlc3Mp Ci0gICAgKGRlZmluZS1rZXkgbWVudSBbZ290by1hZGRyZXNzLXNlcGFyYXRvcl0gbWVudS1i YXItc2VwYXJhdG9yKQotICAgIChkZWZpbmUta2V5IG1lbnUgW2dvdG8tYWRkcmVzcy1hdC1t b3VzZV0KKyAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtnb3RvLWFkZHJlc3Mtc2VwYXJh dG9yXSBtZW51LWJhci1zZXBhcmF0b3IKKyAgICAgICd0b3Atc2VwYXJhdG9yKQorICAgIChk ZWZpbmUta2V5LWFmdGVyIG1lbnUgW2dvdG8tYWRkcmVzcy1hdC1tb3VzZV0KICAgICAgICco bWVudS1pdGVtICJGb2xsb3cgTGluayIgZ290by1hZGRyZXNzLWF0LW1vdXNlCi0gICAgICAg ICAgICAgICAgICA6aGVscCAiRm9sbG93IGEgbGluayB3aGVyZSB5b3UgY2xpY2siKSkpCisg ICAgICAgICAgICAgICAgICA6aGVscCAiRm9sbG93IGEgbGluayB3aGVyZSB5b3UgY2xpY2si KQorICAgICAgJ3RvcC1zZXBhcmF0b3IpKQogICBtZW51KQogCiAoZGVmY3VzdG9tIGdvdG8t YWRkcmVzcy11cmwtZmFjZSAnbGluawotLSAKMi4yNS4xCgo= --------------2E6081CC01A1698AE7EF2A8D-- From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Dec 2021 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 52293@debbugs.gnu.org, juri@linkov.net Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163896840810170 (code B ref 52293); Wed, 08 Dec 2021 13:01:02 +0000 Received: (at 52293) by debbugs.gnu.org; 8 Dec 2021 13:00:08 +0000 Received: from localhost ([127.0.0.1]:39741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muwYK-0002dh-32 for submit@debbugs.gnu.org; Wed, 08 Dec 2021 08:00:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muwYE-0002WN-Vm for 52293@debbugs.gnu.org; Wed, 08 Dec 2021 08:00:06 -0500 Received: from [2001:470:142:3::e] (port=56342 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muwY9-0000SE-BD; Wed, 08 Dec 2021 07:59:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gOWh2YYCArm/JPmO/gkbve4wr5i0e5YX1bbj5FSpHWc=; b=bwPLdsoeGBi4 SYUSR3jbt1da6/iOU/f3FubfEGPRz+vImZ6QAVlD+/HmfXGiyB9kmNLCmhwituTQphWq7EZ0Bnjld NEcmjsX0Eq/U5QhVoOSZQ+svsJxevqffHNrO9YKre9B379RhPO4KnQJKme3ocuBe8/xQYuz0f+lJs FTMcalxa2A19dKgY6xVLg38VHmJos5kDGfM8ZavcFRHmVypUthLWllPUCvh1zm2OmujcWlKYfw9T0 UxFTikeUkDOkhOnhLyVOQfVwLgFtUPGlxXJEU4gxfD2wMcuGJbJAwTCF/iRxQIMdkbMbtCH1JyCOq FhaVMI1v1GcyAmexPM2oVw==; Received: from [87.69.77.57] (port=4980 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muwY9-0003Z8-4O; Wed, 08 Dec 2021 07:59:57 -0500 Date: Wed, 08 Dec 2021 14:59:38 +0200 Message-Id: <83wnkfw8ud.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> (message from Jim Porter on Tue, 7 Dec 2021 20:37:28 -0800) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jim Porter > Date: Tue, 7 Dec 2021 20:37:28 -0800 > Cc: 52293@debbugs.gnu.org > > On 12/7/2021 12:19 AM, Juri Linkov wrote: > > Thanks, this makes perfect sense. I vote for pushing this to emacs-28, > > so the authors of packages could rely on this scheme. Perhaps we should decide that Emacs 28.1 will be release some time after 2031, then. Because we are evidently unable to avoid temptations to add "one more feature". From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Dec 2021 17:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 52293@debbugs.gnu.org, juri@linkov.net Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163898542730783 (code B ref 52293); Wed, 08 Dec 2021 17:44:01 +0000 Received: (at 52293) by debbugs.gnu.org; 8 Dec 2021 17:43:47 +0000 Received: from localhost ([127.0.0.1]:41308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv0yp-00080R-8X for submit@debbugs.gnu.org; Wed, 08 Dec 2021 12:43:47 -0500 Received: from mail-pf1-f172.google.com ([209.85.210.172]:44741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv0yh-000807-Mj for 52293@debbugs.gnu.org; Wed, 08 Dec 2021 12:43:45 -0500 Received: by mail-pf1-f172.google.com with SMTP id k64so3047106pfd.11 for <52293@debbugs.gnu.org>; Wed, 08 Dec 2021 09:43:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=lLlG/q03lr2M2PhVjpM0L2J9zDwQUqrQ9z511DVaHNI=; b=aUtAnnRidBQncQ0j3njRW30wDMgK4yQ5YWFbHqvBXiM2HxfeGLNbiIpR+eIz9pdTq/ UVvf4N52vYTVp6iGAgH/7EtApJnjrlGGXSId096tK5ylWBu4xT9nlnQ+8JDCf0Ozyqon XIx762tBK5jD/SvUkTo0OhPJwBsjEWxz9ZTMgVgOloqa7QpzX22v+Ihbs9phWfWCdj/Z q+ocoy8wB7+P4KjpSSahZ3Bqi4n5WjMzQ3WR4aNy5Q/E2wt1ti713BMr+0klDk3c8fpZ kRWkqe7gNOxJ+sGMpcsi/e8y22PeC+1I2fRiwfdd5bpwwrzmNkwu0cmSTZL6mJvDzYKy g7HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lLlG/q03lr2M2PhVjpM0L2J9zDwQUqrQ9z511DVaHNI=; b=xUZFw+ygrnFWj2ARLPZDyA3C1kfbPhw2gyrg+6hZdYyxKrPPC3mnK86bfXH7U4FXJH j7K22vhpms/DzTVDEK1g1RTcKP1doRnXrfoQHXuLepTAYAiXmmDjTcckq+j59/E3zQ5I Alz9a0HhvoqD5hG1hKYmDt5qBhQHsutIqriKLkUBg3jiiNEe0PymJkwJBNX08ituuO8z 6Jwxd/Db1kFT5jR2+uFdd4r/uFlG73livAR1I/TxbQO9fdxq4HDloiJ8LJLQ3Ru3Sbus 51cjGDt9jUzP2N1CXtpgVy5AhYAqteujhXOTbk+FOT7csFPyJETC1WeZAAONTcd23o8p 3/gg== X-Gm-Message-State: AOAM531LqF+On2Pd/jO42MiGVM7a+VlcOlmNQmRlGQ/SE6exXwsGbIIw Zde9a9XmAavUB8jC+v0+eyA= X-Google-Smtp-Source: ABdhPJzDSh/GxlIqCIboFGphoH1xWYNr5s689UReHuiKPkJUHEtSXoOlI8uyxtU/mrlkmJ3TkWa3cw== X-Received: by 2002:a63:d142:: with SMTP id c2mr30087298pgj.215.1638985413817; Wed, 08 Dec 2021 09:43:33 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a26sm3816690pfh.161.2021.12.08.09.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Dec 2021 09:43:33 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> From: Jim Porter Message-ID: Date: Wed, 8 Dec 2021 09:43:34 -0800 MIME-Version: 1.0 In-Reply-To: <83wnkfw8ud.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/8/2021 4:59 AM, Eli Zaretskii wrote: >> From: Jim Porter >> Date: Tue, 7 Dec 2021 20:37:28 -0800 >> Cc: 52293@debbugs.gnu.org >> >> On 12/7/2021 12:19 AM, Juri Linkov wrote: >>> Thanks, this makes perfect sense. I vote for pushing this to emacs-28, >>> so the authors of packages could rely on this scheme. > > Perhaps we should decide that Emacs 28.1 will be release some time > after 2031, then. Because we are evidently unable to avoid > temptations to add "one more feature". I agree that since this isn't fixing a regression from Emacs 27, and since the real problem is just some visual ugliness, it's probably too late to put into 28.1. If possible, it'd be nice to get this for 28.2 though, since it's a fix for a new feature added in 28.1. We can worry about that post-28.1 though. I'll try to keep this on my radar until 28.1 is out the door, and then send a reminder message to try and get this merged for 28.2. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Dec 2021 19:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Jim Porter , 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163899177716684 (code B ref 52293); Wed, 08 Dec 2021 19:30:03 +0000 Received: (at 52293) by debbugs.gnu.org; 8 Dec 2021 19:29:37 +0000 Received: from localhost ([127.0.0.1]:41442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv2dF-0004L2-GE for submit@debbugs.gnu.org; Wed, 08 Dec 2021 14:29:37 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:45459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv2dD-0004KZ-NL for 52293@debbugs.gnu.org; Wed, 08 Dec 2021 14:29:36 -0500 Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 6EE8D240004; Wed, 8 Dec 2021 19:29:28 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> Date: Wed, 08 Dec 2021 21:07:28 +0200 In-Reply-To: <83wnkfw8ud.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 Dec 2021 14:59:38 +0200") Message-ID: <86ilvysyq3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > Thanks, this makes perfect sense. I vote for pushing this to emacs-28, >> > so the authors of packages could rely on this scheme. > > Perhaps we should decide that Emacs 28.1 will be release some time > after 2031, then. Because we are evidently unable to avoid > temptations to add "one more feature". With the naming scheme of using the year as the version number as in Windows 95/98, Emacs 28 should be released in 2028 :-) But before the release we need to decide whether the authors of packages should add new menu items at the top of the menu before its title, or help them by providing an anchor in the menu. Also please decide what to do bug#52286: should we unify such menu symbols as [separator-global] to [global-separator] before the release? From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Dec 2021 19:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: jporterbugs@gmail.com, 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163899289818569 (code B ref 52293); Wed, 08 Dec 2021 19:49:02 +0000 Received: (at 52293) by debbugs.gnu.org; 8 Dec 2021 19:48:18 +0000 Received: from localhost ([127.0.0.1]:41460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv2vK-0004pR-EA for submit@debbugs.gnu.org; Wed, 08 Dec 2021 14:48:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv2vF-0004pB-B5 for 52293@debbugs.gnu.org; Wed, 08 Dec 2021 14:48:16 -0500 Received: from [2001:470:142:3::e] (port=43442 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv2v8-0004vS-KS; Wed, 08 Dec 2021 14:48:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lRwm+xObvUqT/xh0rErVm9QapETZCESgGH5h53ICt20=; b=Kqdu9hTUd69I AKvQfmXavAkmTLjvGEh07uHxCTYFfg0tVACkv7k31A1PYX/McCrLYjrzawWaIorYtpvQBzRjWU1kg ARVJWinidHtWujYGnx3u2nFieZYfxwQX6zmwO7IzQeIqBsL3aUlGXjUlP7x0RL1tyj2J4ejjPFJbE DY26EgYy7iA5fZ5PqioQxrP9aaFwaOtl+5cwndhEfRdYQcDS+kv+19ORLodrUcj+72apkK/3qtSay n8hvunqQFrBfT/JrcDKNmC3qiv9FT+4TyehI/+bKaDNBXxdh8I77/6KAd2VCIac0wXVorbG0bHXQl I33T/N1tbzUVymoZjVwdfg==; Received: from [87.69.77.57] (port=2484 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv2v8-0003o0-Dd; Wed, 08 Dec 2021 14:48:06 -0500 Date: Wed, 08 Dec 2021 21:47:48 +0200 Message-Id: <834k7ix4ij.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86ilvysyq3.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 08 Dec 2021 21:07:28 +0200) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Jim Porter , 52293@debbugs.gnu.org > Date: Wed, 08 Dec 2021 21:07:28 +0200 > > But before the release we need to decide whether the authors of packages > should add new menu items at the top of the menu before its title, > or help them by providing an anchor in the menu. > > Also please decide what to do bug#52286: should we unify such > menu symbols as [separator-global] to [global-separator] > before the release? I'd prefer all of those to go to master. I'm quite sure this is not the last time we hear that something in those quarters needs to be fixed (I think the feature wasn't mature enough to go to Emacs 28 in the first place, but that's water under the bridge now). No catastrophe will happen if this will be fixed after 28.1, or even in 29.1. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Dec 2021 09:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: jporterbugs@gmail.com, 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163904084332464 (code B ref 52293); Thu, 09 Dec 2021 09:08:01 +0000 Received: (at 52293) by debbugs.gnu.org; 9 Dec 2021 09:07:23 +0000 Received: from localhost ([127.0.0.1]:42430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvFOd-0008RY-5W for submit@debbugs.gnu.org; Thu, 09 Dec 2021 04:07:23 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:60011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvFOb-0008RJ-Rk for 52293@debbugs.gnu.org; Thu, 09 Dec 2021 04:07:22 -0500 Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A8D0EFF80F; Thu, 9 Dec 2021 09:07:14 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> Date: Thu, 09 Dec 2021 11:06:36 +0200 In-Reply-To: <834k7ix4ij.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 Dec 2021 21:47:48 +0200") Message-ID: <86pmq6taeb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> But before the release we need to decide whether the authors of packages >> should add new menu items at the top of the menu before its title, >> or help them by providing an anchor in the menu. >> >> Also please decide what to do bug#52286: should we unify such >> menu symbols as [separator-global] to [global-separator] >> before the release? > > I'd prefer all of those to go to master. I'm quite sure this is not > the last time we hear that something in those quarters needs to be > fixed (I think the feature wasn't mature enough to go to Emacs 28 in > the first place, but that's water under the bridge now). No > catastrophe will happen if this will be fixed after 28.1, or even in > 29.1. Do you think that [separator-global] should be renamed to [global-separator] only in master? From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Dec 2021 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: jporterbugs@gmail.com, 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16390427993127 (code B ref 52293); Thu, 09 Dec 2021 09:40:02 +0000 Received: (at 52293) by debbugs.gnu.org; 9 Dec 2021 09:39:59 +0000 Received: from localhost ([127.0.0.1]:42464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvFuB-0000oN-KF for submit@debbugs.gnu.org; Thu, 09 Dec 2021 04:39:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvFuA-0000o8-Kk for 52293@debbugs.gnu.org; Thu, 09 Dec 2021 04:39:58 -0500 Received: from [2001:470:142:3::e] (port=36316 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvFu5-0008DR-9a; Thu, 09 Dec 2021 04:39:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=E4x++m6Y4eZfqfmCFEgx+gjWVTnl08MGA8f1wpnlrDg=; b=ifq5LkGM3Ico NDFh9+2kcNsBgG1cuDrH3BeKm6lI/QAQADh0uIKO+opOBjMq+Qk2Ns2wC3XtOe5tA8qzwX1AqgxQA XtQXRGvjxkjAsv5TKY7Rry89+//fmoXmhabjqJmNOCEHJZsopD0QKG+L4SLgd8YV7d+opiego7WQ6 5dkIn9K9b0WnHKDpHOdNSM0VcCFi8WiY3miDrIS4YrK4bVxzszzsS/SU+Q0En8L8/1lLW2Y8AbE2V 5hiJ2aDgV38vWCEbR6rBKKIH20aUTbcwyEj07I6HD5RsO1LAV1K3FM/IQ/F2lgNVDsK0exV4CdJKF A1o/RibEa9V2uDneZIu4HQ==; Received: from [87.69.77.57] (port=1501 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvFu5-0000FV-3o; Thu, 09 Dec 2021 04:39:53 -0500 Date: Thu, 09 Dec 2021 11:39:35 +0200 Message-Id: <83czm6unfs.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86pmq6taeb.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 09 Dec 2021 11:06:36 +0200) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: jporterbugs@gmail.com, 52293@debbugs.gnu.org > Date: Thu, 09 Dec 2021 11:06:36 +0200 > > > I'd prefer all of those to go to master. I'm quite sure this is not > > the last time we hear that something in those quarters needs to be > > fixed (I think the feature wasn't mature enough to go to Emacs 28 in > > the first place, but that's water under the bridge now). No > > catastrophe will happen if this will be fixed after 28.1, or even in > > 29.1. > > Do you think that [separator-global] should be renamed to [global-separator] > only in master? Yes. This way, we have quite some time before us to let people bump into any problems this could cause and report back to us. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 04:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Juri Linkov Cc: 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163928177413349 (code B ref 52293); Sun, 12 Dec 2021 04:03:01 +0000 Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 04:02:54 +0000 Received: from localhost ([127.0.0.1]:50414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwG4c-0003TF-03 for submit@debbugs.gnu.org; Sat, 11 Dec 2021 23:02:54 -0500 Received: from mail-pf1-f175.google.com ([209.85.210.175]:37796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwG4V-0003Sw-UD for 52293@debbugs.gnu.org; Sat, 11 Dec 2021 23:02:51 -0500 Received: by mail-pf1-f175.google.com with SMTP id 8so12034884pfo.4 for <52293@debbugs.gnu.org>; Sat, 11 Dec 2021 20:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=pv4hjqWf6MAovgbe6XwqJYRb1e/Zs9pN42Vq21HcO0c=; b=OBn7/nXyKZmDT0Ocoyg0mU0iXZJXEE1uruif3nscuqVlgZ/oAFzRBLBXOrs/caqwSm QA6utslA8fWPLhq7YUf2LpTA96+6XragbsxbfGtOBqg1PRGh4q+9jDqY1X/vK2eOMB9b JIgkDpQScVNAqhulWcRYNAIGfjuvRkOYSa70Nw7zFaAYC0mrfa9cSL/ik3FEMaz9ZfUx nh6bc5hEyBGN4HfefZdE/9QPfQ6I/4xJQG2GLO2gt/rOni+ae8dtmtXltnEO/nz/W4gV g6NE/dFswC+axJaNk6BfdBJooO36RJ/Swg9MmCev0cpu21ksNwXWLxOwzO+p4q1LWEYT lvqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pv4hjqWf6MAovgbe6XwqJYRb1e/Zs9pN42Vq21HcO0c=; b=nx5TcfiwCcsuH6688syuvq2yfkSAlZhUHGMWjXsSl4htsfi7Bfh2iJDvHra/s6BRtH i8lhHpFGUK9uL+gPH1MZCFjYQlJIsvxIuoz2QtsA5+0w6psJ08UUKUoLI3XreLgv6/HU f7Lp13EH/0KfVm+Ogsp+O7BO8ZtMNGxKag+bOfrpz3W5E5PWPerwpKJA4T3haIfYROGG 57aNQiMBttD8pif1oWKBYFA5P2FLU58dKzXuq2QQ3wClPzqVqpzHt1WcKbLiyN2Lk7Nd VyvRLXTp0cslF1x5cCWnayQbLbAmw+MvapiBFQHVwUA5tXwU2a9I/vqF48KgFalVxbl8 utmw== X-Gm-Message-State: AOAM530xF6BT6PErXEHKy2rH3KbWL5Y4DQGfpUzQp1sLzwSqoS1Nh58R S3RsHoTKFOZhI3QxURfuYnliriE7UMQ= X-Google-Smtp-Source: ABdhPJzrPuCz5jvX7W3SfSagK/4skGuCz6yqsXOAmpSv4SYbeKiUSTuwIsMOXZW6plLdX2KBYlFAyw== X-Received: by 2002:a63:2162:: with SMTP id s34mr4616437pgm.277.1639281761954; Sat, 11 Dec 2021 20:02:41 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id cv1sm3107674pjb.48.2021.12.11.20.02.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Dec 2021 20:02:41 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> From: Jim Porter Message-ID: <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> Date: Sat, 11 Dec 2021 20:02:41 -0800 MIME-Version: 1.0 In-Reply-To: <83czm6unfs.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/9/2021 1:39 AM, Eli Zaretskii wrote: >> From: Juri Linkov >> Cc: jporterbugs@gmail.com, 52293@debbugs.gnu.org >> Date: Thu, 09 Dec 2021 11:06:36 +0200 >> >>> I'd prefer all of those to go to master. I'm quite sure this is not >>> the last time we hear that something in those quarters needs to be >>> fixed (I think the feature wasn't mature enough to go to Emacs 28 in >>> the first place, but that's water under the bridge now). No >>> catastrophe will happen if this will be fixed after 28.1, or even in >>> 29.1. >> >> Do you think that [separator-global] should be renamed to [global-separator] >> only in master? > > Yes. This way, we have quite some time before us to let people bump > into any problems this could cause and report back to us. That's ok by me. Note that this[1] is a very mildly incompatible change, so as long as people are aware of that, I think it should be ok to merge into 29, and hopefully into 28.2. The only incompatibility would be people wanting to add context menu items after certain specific separators like `global-separator' or `undo-separator'. I think that's fairly unlikely though, since: a) `context-menu-mode' is new so there aren't many (any?) third-party packages that use it yet. b) `context-menu-mode' doesn't guarantee that any particular items are actually present in the menu. Users can customize the context menu, so it could have anything at all in it. Relying on the presence of `global-separator' (however it's named) would be somewhat risky. `middle-separator' and `top-separator' (the latter is from the patch in this bug) are/will be at least *likely* to be present though, so are more likely to be used in third-party code. If there are any other issues with the latest patch in this bug (or bug#52286), just let me know. [1] bug#52286, that is. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 07:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 52293@debbugs.gnu.org, juri@linkov.net Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16392925408790 (code B ref 52293); Sun, 12 Dec 2021 07:03:02 +0000 Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 07:02:20 +0000 Received: from localhost ([127.0.0.1]:50547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwIsF-0002HR-M4 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 02:02:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwIsE-0002Bo-4u for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 02:02:18 -0500 Received: from [2001:470:142:3::e] (port=52768 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwIs8-0003TH-P0; Sun, 12 Dec 2021 02:02:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZHOTU9YjHu2C1VHxr/9jbi9otwpG6LmVlGRVMt2Z5+4=; b=oFZFoCNP4Jef M/9H1r0ompaYPZvRxZkuxz9Rggp9IKD2+dKdHrhIeTQdjrw/hMs3zibKf7Cjy2+LDUzMMqjrEKkhW PPqN3wD+CGH9AzoXhFrOBsWD+K3sg7tpoqL9sZVUVy9sMQ3JyxNVuLwJb0RxZkkEhGmrj4b0pmy/f 0zx7xY+ChI3ZixqPIoVRCJ+fOQbjIVlQhqkcbnLzCvwg7AtqnL1+jCyotntogkXWWSoD0gi0kWVy0 94hiEcZsV9F6NTnxV+1k/3wtn+XBdZPYnx5g7o4+nfR5iNwMDkpN/AcCZ2ee9iqMCsPyA/GTf6YeT 1Mk6Gx1J8chbBtA8wYj2wg==; Received: from [87.69.77.57] (port=3527 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwIs8-0002Yz-JP; Sun, 12 Dec 2021 02:02:12 -0500 Date: Sun, 12 Dec 2021 09:02:04 +0200 Message-Id: <83o85mpaqb.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> (message from Jim Porter on Sat, 11 Dec 2021 20:02:41 -0800) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 52293@debbugs.gnu.org > From: Jim Porter > Date: Sat, 11 Dec 2021 20:02:41 -0800 > > > Yes. This way, we have quite some time before us to let people bump > > into any problems this could cause and report back to us. > > That's ok by me. Note that this[1] is a very mildly incompatible change, > so as long as people are aware of that, I think it should be ok to merge > into 29, and hopefully into 28.2. The only incompatibility would be > people wanting to add context menu items after certain specific > separators like `global-separator' or `undo-separator'. I think that's > fairly unlikely though, since: > > a) `context-menu-mode' is new so there aren't many (any?) third-party > packages that use it yet. > > b) `context-menu-mode' doesn't guarantee that any particular items are > actually present in the menu. Users can customize the context menu, so > it could have anything at all in it. Relying on the presence of > `global-separator' (however it's named) would be somewhat risky. > `middle-separator' and `top-separator' (the latter is from the patch in > this bug) are/will be at least *likely* to be present though, so are > more likely to be used in third-party code. Are you saying that we will be recommending a convention for separator names only for menus popped up in context-menu-mode? Does it make sense to have such a specialized convention? Isn't it possible to show context menus outside of the context-menu-mode? From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 52293@debbugs.gnu.org, juri@linkov.net Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16393408639900 (code B ref 52293); Sun, 12 Dec 2021 20:28:01 +0000 Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 20:27:43 +0000 Received: from localhost ([127.0.0.1]:53256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwVRf-0002Zc-DU for submit@debbugs.gnu.org; Sun, 12 Dec 2021 15:27:43 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:53982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwVRd-0002ZP-I1 for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 15:27:41 -0500 Received: by mail-pj1-f41.google.com with SMTP id iq11so10469792pjb.3 for <52293@debbugs.gnu.org>; Sun, 12 Dec 2021 12:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Hi+RtPjh8w8hD8TuC4TK0sIpWM9uT7WUxS1/xOVBr/A=; b=pUnTO7odDABPuFz8lim5YW/FMX1HA54OfTGDYU2zcibwNYCGIoWxmCu5HR4v+1Ubtl Tqq5eEb3blC8LUrhjDVkL6GfVT0J2GJh8e+B4AgA2LeR5qjCjitKh12TzSshVo2dpUY0 cZuqrXqhjzy5uTRPafzHB+jCpwV8jVKLw20vQ1WoGN8By6Jvo/XV6QKT7Dp7g0bqbCgN Q6O5fNRtHbLCnLX4G9n7YgqznV0MdXNibTl6hhZH/QpynFM/0vawaCJimwLS3/yQf2dP xZN0nkKb3uSEBclhMkE8tD29frkeO+MESnEmgeNbRO5cuStrokLTqvXflVTa/pjeFBs1 0j4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Hi+RtPjh8w8hD8TuC4TK0sIpWM9uT7WUxS1/xOVBr/A=; b=s3aBh7HQ9Cq7iP23BBR+aplEhyv9knwRQwJ1WvmzHwo+xGexocu6AFbpGEmPpU/2H3 34hvhkneU3VSjD7HcExx9qBC+N9S1zGjspegAushJtvpKkeRMQXKRS6fsczqESzLn5ri Hi4MYAXS1wgGmZvsaDIAhH9BJ7dPe2lCmg7LUOTjnyYWixAScK/pcc+3EBzsDHlAbgtI 9woJW37wcFphqI/Za0Qj7SfZbdPYVa0V4kfDmGNBQEkGCJULVccPV2GoHhCfyzKD82xI N0pshnkGydpH/8c2HfrRczTYP8o+gXLqh/AKOX6CpDFSdS7xD43Ta3muqbd0TZ7nCVIA h7Qg== X-Gm-Message-State: AOAM531uztOnmTBIrdYRvLVlBtaUoCsl3WAJMpIoJsx6tw6AyIkCbOmF M2IGXqR7y9kOGGh7cBMj+PU= X-Google-Smtp-Source: ABdhPJyxIojpA95gJufYipbCwOsXbd7FeiqV5nZ2xpVTP1yWy5dRcSKyRFaQYP9BKFadjvP6fUcHzg== X-Received: by 2002:a17:90a:1919:: with SMTP id 25mr40431411pjg.154.1639340855748; Sun, 12 Dec 2021 12:27:35 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id j190sm7714739pge.70.2021.12.12.12.27.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 12:27:35 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> From: Jim Porter Message-ID: Date: Sun, 12 Dec 2021 12:27:34 -0800 MIME-Version: 1.0 In-Reply-To: <83o85mpaqb.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/11/2021 11:02 PM, Eli Zaretskii wrote: > Are you saying that we will be recommending a convention for separator > names only for menus popped up in context-menu-mode? Does it make > sense to have such a specialized convention? Isn't it possible to > show context menus outside of the context-menu-mode? No, I think this convention should be recommended for separators used anywhere in Emacs going forward. I'm focusing mostly on context-menu-mode simply because it's pretty new, so there won't be much third-party code that relies on the old (`separator-foo') naming convention yet; it shouldn't be too risky to change this now. On the other hand, separators in the menu-bar (for example) have been around for longer, so I think it's probably too late to change those. Overall, my guideline would be: use `foo-separator' when adding a new separator to Emacs, unless that part of the code consistently uses the `separator-foo' naming convention. In that case, it's probably best to stick with the existing scheme in those parts in order to be more internally-consistent. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 20:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 52293@debbugs.gnu.org, juri@linkov.net Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163934184411446 (code B ref 52293); Sun, 12 Dec 2021 20:45:01 +0000 Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 20:44:04 +0000 Received: from localhost ([127.0.0.1]:53283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwVhU-0002yY-4O for submit@debbugs.gnu.org; Sun, 12 Dec 2021 15:44:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwVhP-0002xt-GW for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 15:44:03 -0500 Received: from [2001:470:142:3::e] (port=39670 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwVhK-0007GQ-5m; Sun, 12 Dec 2021 15:43:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=o4jC8k8BGzfOhCQBBh29mDcVacDWIYdtBewOrnW7Iuc=; b=nt9hIr6mghrE vOwWzXvW3wbGk/FJ1shk49PuFQJg8kfuIxj2i+3zQkAfTox5e2LhldQ+HBZWVgf+FMpDDje+JTj/Z 98yHLaT94X3i1Z7ua9eIYx69/LEj/GWyx77tPNXwQUz0LMRz6m2GRqc+7dyo5c0KvCAyvjOGXyKLL nVmpDBEXTggad56yioQOSzNggdGIeV0eITd5ghtKPza01hjF8rOLThkT7mBwgKo+I9Ln2XQb7Ea8v Y5CWvQPWFnq43BSQh7r/S/K2ZOaiQMng9om1NJMzVARwAImxThb7/Iy9U9RdKpulqOEa+QOBMNQnb FEPpKBxP+5PEa0F0HVH/lA==; Received: from [87.69.77.57] (port=2883 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwVhK-0002Sg-0M; Sun, 12 Dec 2021 15:43:54 -0500 Date: Sun, 12 Dec 2021 22:43:46 +0200 Message-Id: <83tufdmu4d.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Sun, 12 Dec 2021 12:27:34 -0800) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 52293@debbugs.gnu.org, juri@linkov.net > From: Jim Porter > Date: Sun, 12 Dec 2021 12:27:34 -0800 > > On 12/11/2021 11:02 PM, Eli Zaretskii wrote: > > Are you saying that we will be recommending a convention for separator > > names only for menus popped up in context-menu-mode? Does it make > > sense to have such a specialized convention? Isn't it possible to > > show context menus outside of the context-menu-mode? > > No, I think this convention should be recommended for separators used > anywhere in Emacs going forward. Ok, so then the effect of this change is wide, as I envisioned, and compatibility considerations still apply. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 21:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter , Eli Zaretskii Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org>, "juri@linkov.net" Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163934283313045 (code B ref 52293); Sun, 12 Dec 2021 21:01:02 +0000 Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 21:00:33 +0000 Received: from localhost ([127.0.0.1]:53289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwVxR-0003OK-Hr for submit@debbugs.gnu.org; Sun, 12 Dec 2021 16:00:33 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:36374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwVxP-0003OC-IK for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 16:00:32 -0500 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BCF7duQ023497; Sun, 12 Dec 2021 21:00:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=56fD0YjQ0bh1KHKGrtRAOEJqs1lniDVtVMlfHiZKkGQ=; b=hLFw/G2K6GckRu4eaTWTpK9UuCbpuBBXrTWmPVZnFKHENAGnGMF1ZHrf5zByBVgBOdWP B+40J0jNDMuYqdxlKV7PPkoblf9MHbIsByWbKkUXZbczEAA2EpgFPmoyhjOWvPN5AH6i Eol+A1N98rcn9BBT89us41t2QIyybTeQ1w9vl/aRdkgFgDeyZRkVKFP/f4YM6wx/RlNS 8qG3LxgtOKhTtc2uCBwQmDLRsPhKxVCWCLq4z+dR56FbH5r5b9UzsssfhIvBaWahko9F vtNgNa5M1zm1VXC28esOhLSAQ+7+2AflUB+no7bd8yTNv+V6aS3mwgkeT3Ixs3wTZfT1 PQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3cvjk124rw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 12 Dec 2021 21:00:30 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BCL0NIX083872; Sun, 12 Dec 2021 21:00:29 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2170.outbound.protection.outlook.com [104.47.57.170]) by aserp3020.oracle.com with ESMTP id 3cvkt238aa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 12 Dec 2021 21:00:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LAzcU5Ks9VI15mTMyHuC903jsd93pORiZg2X9A8fqud9W7h7i9tG+hapl8WVQeqpwP3wCv3N0LPNCcZf5A7+y/OVJy8rqmEiBo7sD2r/T7Qpzn8/4cz5ewj308qScoUHd05sXM++F0sAfPozMo+T7rbFcjfcx7z1NOv65/YutEaRHk0B3mULaA5CM1iRQa4mwz2AU0mYxMBxJb79kvdoigxQ3BeZGa+e4MPbUaHwIXSBh7kg9nHZLYo5v8/b6M66yEFC0RIalr+tsd8z3CcYpFWMyMRUL1XHHtm42kInW4oxqhbz4OgONHgei61SqAtIOvR1xYuasHFhyWSdClvaXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=56fD0YjQ0bh1KHKGrtRAOEJqs1lniDVtVMlfHiZKkGQ=; b=L7+RnpnQaXk3pmt9OIZJAbld/2BRtWtGorKginB/4J5/jJuPBg6fsjS9Z5UhMLs2amVBKwjFC4K1dQhR7VLSQleGVQqNGL0AUcda4LSsv2PvruoV+bc/ToO62mIuB7iU1LssXLvBMfqt9Cs8I7R+1fpGmJXXiMdjoVQzx97IRr98zLXxcdGeJYaTNsuWhItRqsEjVOmRCBZfcI34Yq65G2+9jugo9Bb3ORVpjtsPKIOeESXjyZEoqMu8ZLLjahauokVPDjYp1pp8SqXdLfGDgV9cobWUfmpw5bxrjuIr5UArfeg8OiYjP4fTLjvi8tOmfHpXbIfh+ESSMku+ZCUJhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=56fD0YjQ0bh1KHKGrtRAOEJqs1lniDVtVMlfHiZKkGQ=; b=fAmoAwP+G+ElrwgKGn0KY0hac3Th6qvy/0/IbxmemIGMxETCyxt2Ip9QN0ggqG0SgbxAP+zHwznd5iYlOYMvuZWp9EDNbycGUcn/GHgchChi+63iMkgM8tWEt3cQ3cBiFBk82BD23QdiPQeY50CGrOULXLANAbIhZmY8eaKNum4= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by SJ0PR10MB4624.namprd10.prod.outlook.com (2603:10b6:a03:2de::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Sun, 12 Dec 2021 21:00:27 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%8]) with mapi id 15.20.4778.016; Sun, 12 Dec 2021 21:00:27 +0000 From: Drew Adams Thread-Topic: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Thread-Index: AQHX75bHTNS4w5XPFkGKiohFmKn4uKwvVRsQ Date: Sun, 12 Dec 2021 21:00:26 +0000 Message-ID: References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f87007d6-b40a-4306-8f29-08d9bdb26c65 x-ms-traffictypediagnostic: SJ0PR10MB4624:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7Bxc0oiF3QIxjsnWmq+m3RVt4NbyHjvu5vDh/Wry4h/F+o4XDtgbHPniuZk38cm1bAurfG64UXVOm+N+v2oWBedUf/6RwU2E+g0GiT8Y5SV7ggnFA1YM71vJZMNNuGzjlkmPQc1QovVq0exxozTt7SxN9YSByMAIfbT0TGahs7G1MqguifyD0ZsWNqg88UQUQ2gMCTUKzm0pf7yYgU+ih4bBhkafxwz2cXYtyVj729axIsJLRq1X941Ij8gxv//VMx867tm7UyIM8lTFoTena0/kL4f8z6Y66ap4Mky9UorYd5jn/0JheXVRrTf2t5HE8fGUBIQ/HCffZsxuGSgtYNMvDmKaLEtcp90O9y2VvljNSsmAZD8RGAnHNTZtcYPFvaR2tuoJ4S/KIUEg53JwDxat6nUh1UjraPY3VCTH0MLB5M0OsKjp0G7YGN4QLekJLTuAgfs8eq/uTJGvrbbMmZ1ixVwHFmcPtLrN7AjOn+lNjgtLgZQ2pDwn6XApKY8/NvLCLhnHGQ5/K9vWlzVX7FU9cYAFOuTBvWql0tWemajhDK8uUip59vMzogOKiRsyAFf9w4WScGyP8RUkpzqQ2sWwS6/zHBmYGAftv5WF1jlK18lP872A2LPxtvwX+7D/xoBMAHrq+MCXHTXJxkH0SGsVqBtQWzJ6k+oae5mVQfeBORr71UvlRO0xBaEP893HErQvJggqwV9y+AqdjAglZw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(508600001)(186003)(316002)(5660300002)(55016003)(66476007)(6506007)(110136005)(33656002)(8936002)(8676002)(76116006)(2906002)(4326008)(38070700005)(54906003)(66446008)(44832011)(38100700002)(66946007)(122000001)(71200400001)(64756008)(7696005)(86362001)(66556008)(52536014)(83380400001)(9686003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: mTYv2dRphzRiLI7tFNpZ5A+d3YD2ckkwibiNmIAMHBWdYAMMid43pemnlpMscftyjg2slhOMZMquObvROGaPbljJRsYQW4MCrP/p9b3aTxpzPjTQNsjvdiCfHCFMyX9knbnBTmXNufIJmw+bl39gTZxgxHI+QmmaypHyAu9xC0uziN/W8Psu+ZED0mt4CsY9fj8BlCGh2sOzqiAE52STNd9Esvk6O9JnD7uxWE4sn0bVBLJeYslxIYAuI32+Zb908w4XyX3yCDEqyxGZfJGLnlto1QGh6hosyWUR+Tk3y1SIhqrI2uas80g0BAX5rnnm+BmWPhzdD4TfiRJHSWrc/3+jKErS2WXbt0kNbDYUdqTCRdovYWgeiAjHxphc/qbSZGKlpqEeQMBDiSfF2gFQI4HxatJ3DiXDyzG7SKofsqk8uhrnK0PPKbwtlLkfiZ8OzhnY0urtRJ4Q0m5S4yKK7PBQ7QWLGshzAAL/i0BCCvdHa0lR9WqxgUlkqd5anZ8HtI4zJfSuccNnOjWLPyLIZQ3hDAE5mmxqdStB1tWmfoW7YHtq2vXzP7zic2cu5l1rOkaSyg4PLd/+PXdnDF/CrpX0j6x5U29g3fLIeWl19wmguImcY8zGmHyPsRhhA1Lf9QbXnRwTRFgGugPZzWLSaZ57S7RIMhFRRFgYTQu4oebK6wkOW0Wv/5l527vLKFCGi+hPLONIBTwPpNonQX2w22+n/d1RvG7eKx6baaJPaV20OI8WCGA6bZ7oCS5ZcjfK08I2bqqvkrtzl8AIxZx9qxAlHqJyZGM6Sd1tFoH8eIhSQA4MMForxVbJmTKybkbXQci6++8AedcAX6nLrHyP05LKyZ4SN2OC7DZTEdhpjQ15HRTsZBDcK4nCcujHpaFyRY5c0KHFBFLvCUm/uMAnaWtbJsbji18V5vtIiIT4F9grrc/CDvY+QNt6iHg+0zrugoc4frtVw0YTCfgRdOW8IyQHt8rFeNcmI28oYbDAudeOEg+akYkVdEYWRPdSsy7cRuYHrm8ZMZh+a8JpzJ1FAKW/q8vQVBtACFminCr9FIZAqTDO7NzHrD5n5JIQeZIVzrRUdUYl1o68zS3VJtJeK5vQpeXmCDki1MgeSgZijx/SyhprMRDZ9EZjBG8kcpPShbKtPh4qNie/uyceIFqmobvb330RBRIU9RVoqUCkFKV7bplmspwhC9SCb9aeI+QxEY89hxoeMZTnDyOtfMRhmWCFK7JAaf2EqWjQTvYUby6U6zNricSaCKon0mL4OR/kI7EEm0xNdXv4EO0nrovJkF1FgstcwP05X5VZWkMqOV+ZYVgpGvmP455rf4qSlBjF1xvgDcYG3jaFJD6G0RbQWT0iXiHAHoApf9ccqtjVqf+0YfT7gizYOptZxBsilFspLsar8ONhuQhnQTHVxZjwPHWty/9+ufYLdeo59O/3Geigky87pyft1d3+3ffN3102/lPBVEXf6MnWfhyHdtMMsXbVOAtxaEFeXSOHrZoJPZ2efJGOzdWfuY+Vaxlf5BIhfNOCs6+FwgTjpTCBkR84Duh6CeRSBVGsdpOUVFlFqgSa7z2ghMKeQMfQAonsLrpr4HtNmlkBUC+06mCemJc8sg== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f87007d6-b40a-4306-8f29-08d9bdb26c65 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2021 21:00:26.8966 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /MQOO2QWAbG3sv9EeFJifhc70nJcGMK6yA01wIltDYWQtWkHV4wRNlgnC/iJEetrAjmmZ101XcDWxJFC5BUAGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4624 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10196 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112120128 X-Proofpoint-GUID: 5Tvq4PJJqWe-CjqgzQfGqD0_ahmlp-fU X-Proofpoint-ORIG-GUID: 5Tvq4PJJqWe-CjqgzQfGqD0_ahmlp-fU X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiBObywgSSB0aGluayB0aGlzIGNvbnZlbnRpb24gc2hvdWxkIGJlIHJlY29tbWVuZGVkIGZvciBz ZXBhcmF0b3JzIHVzZWQNCj4gYW55d2hlcmUgaW4gRW1hY3MgZ29pbmcgZm9yd2FyZC4gSSdtIGZv Y3VzaW5nIG1vc3RseSBvbg0KPiBjb250ZXh0LW1lbnUtbW9kZSBzaW1wbHkgYmVjYXVzZSBpdCdz IHByZXR0eSBuZXcsIHNvIHRoZXJlIHdvbid0IGJlIG11Y2gNCj4gdGhpcmQtcGFydHkgY29kZSB0 aGF0IHJlbGllcyBvbiB0aGUgb2xkIChgc2VwYXJhdG9yLWZvbycpIG5hbWluZw0KPiBjb252ZW50 aW9uIHlldDsgaXQgc2hvdWxkbid0IGJlIHRvbyByaXNreSB0byBjaGFuZ2UgdGhpcyBub3cuIE9u IHRoZQ0KPiBvdGhlciBoYW5kLCBzZXBhcmF0b3JzIGluIHRoZSBtZW51LWJhciAoZm9yIGV4YW1w bGUpIGhhdmUgYmVlbiBhcm91bmQNCj4gZm9yIGxvbmdlciwgc28gSSB0aGluayBpdCdzIHByb2Jh Ymx5IHRvbyBsYXRlIHRvIGNoYW5nZSB0aG9zZS4NCj4gDQo+IE92ZXJhbGwsIG15IGd1aWRlbGlu ZSB3b3VsZCBiZTogdXNlIGBmb28tc2VwYXJhdG9yJyB3aGVuIGFkZGluZyBhIG5ldw0KPiBzZXBh cmF0b3IgdG8gRW1hY3MsIHVubGVzcyB0aGF0IHBhcnQgb2YgdGhlIGNvZGUgY29uc2lzdGVudGx5 IHVzZXMgdGhlDQo+IGBzZXBhcmF0b3ItZm9vJyBuYW1pbmcgY29udmVudGlvbi4gSW4gdGhhdCBj YXNlLCBpdCdzIHByb2JhYmx5IGJlc3QgdG8NCj4gc3RpY2sgd2l0aCB0aGUgZXhpc3Rpbmcgc2No ZW1lIGluIHRob3NlIHBhcnRzIGluIG9yZGVyIHRvIGJlIG1vcmUNCj4gaW50ZXJuYWxseS1jb25z aXN0ZW50Lg0KDQpDYXZlYXQ6IEknbSBub3QgZm9sbG93aW5nIHRoaXMgdGhyZWFkLiAgRldJVzoN Cg0KMS4gSW4gbXkgY29kZSBJIGhhdmUgX2xvdHNfIG9mIG1lbnUgc2VwYXJhdG9ycyB0aGF0DQph cmUgYXBwYXJlbnRseSBpbiB3aGF0IHlvdSBjYWxsIHRoZSBvbGQgbmFtaW5nDQpjb252ZW50aW9u Lg0KDQoyLiBJIGJlbGlldmUgdGhlcmUgd2FzIG5vIHN0YXRlZCBjb252ZW50aW9uLg0KDQozLiBJ IHRoaW5rIHRoZXJlJ3MgemVybyBuZWVkIGZvciBhbnkgbmFtaW5nDQogICBjb252ZW50aW9uIGZv ciBtZW51LWl0ZW0gbmFtZXMsIHdoZXRoZXINCiAgIHNlcGFyYXRvcnMgb3Igb3RoZXIuDQoNCjQu IEFzIEkgc3RhdGVkIGVhcmx5IG9uIGluIHRoaXMgdGhyZWFkLCBJIHRoaW5rDQogICBpdCdzIG1p c2d1aWRlZCB0byBwcmV2ZW50IHRoZSB1c2Ugb2YgZHVwbGljYXRlDQogICBzZXBhcmF0b3JzLiAg SWYgc29tZW9uZSB3YW50cyBzdWNoIGR1cGxpY2F0ZXMNCiAgIGZvciBzb21lIHJlYXNvbiAoYW5k IHRoZXJlIGNhbiBiZSBhbnkgbnVtYmVyDQogICBvZiByZWFzb25zKSwgbGV0IHRoZW0gYmUuICBB bmQgaWYgc29tZW9uZSwgZm9yDQogICBzb21lIHJlYXNvbiwgd2FudHMgdG8gcHJldmVudCBzdWNo IGR1cGxpY2F0ZXMNCiAgIHRoZXkgY2FuIGRvIHNvIGVhc2lseSBlbm91Z2gsIG1hbnVhbGx5IG9y IGJ5DQogICBjb2RlLg0KDQogICBEb24ndCBpbnN0YWxsIHVzZWxlc3Mgcm9hZGJsb2NrcyBpbiB0 aGUgd2F5IG9mDQogICB1c2Vycy4NCg0KSnVzdCBvbmUgb3Bpbmlvbi4NCg== From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 22:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 52293@debbugs.gnu.org, juri@linkov.net Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163934636518576 (code B ref 52293); Sun, 12 Dec 2021 22:00:01 +0000 Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 21:59:25 +0000 Received: from localhost ([127.0.0.1]:53379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwWsP-0004pX-EC for submit@debbugs.gnu.org; Sun, 12 Dec 2021 16:59:25 -0500 Received: from mail-pj1-f50.google.com ([209.85.216.50]:51927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwWsN-0004pK-7I for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 16:59:23 -0500 Received: by mail-pj1-f50.google.com with SMTP id gt5so10576397pjb.1 for <52293@debbugs.gnu.org>; Sun, 12 Dec 2021 13:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=lBsylRfhvu8e6ZBbCOV7J6OQ/qz/9/Qe8BAGqQt5wgw=; b=EFhkBjk1wNYh2B6WYD66GV4swcLygUiXT5HZmTPD/i1IsbSoj6mKbeVnLR0Qr5+0XW pRNINLTfIyJyYOCpCbWOPWuEnoDMcNVf2rjZAfzHpDO4Gu+XGSLrYcSAUNOV8RzL39Ci Fbry+rqJ2nHUA7CSDUoi8GLKxdi8v+84jcVh0tdqyJkKZnviasPONrhNck0ABQmZMF+e kY957f18orTbduwnwcnPLs14RX/Pn2ntmZOiFodcuBwvTqvuJEXMtuQ68fG6cPLuIf2F 8pN0KxQOZgwyN/s0/8l6o1h3DkBjQXSryT5voL4qk7YERLVXo0sDdyF1poMpzYExJV2m mtMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lBsylRfhvu8e6ZBbCOV7J6OQ/qz/9/Qe8BAGqQt5wgw=; b=yMW2vgA7iB5UL15eLI8EHKRscPMhZ9qC+C6fD0wuRr/wEV/i11/kC701JnDUXZUzhe OAwfozP98pLGlFJKpdlqhSBR5Ici0jlrZ+dlIX3Yq+aAKC8Ps3+2Ko68qbsE+wxnS/aW 2QSPpc6i4SfzEPFgs0gVrgE/d20wYomfmO7H5dVNHsnflfGm+/9JZlreYqP9RbM6wvPS 3lui7at3pSUBDEpgvOLSyBcD3jclcOh4g4OufvlWH7wj++rLiHWzPKypnFOxaANZ1CYY vE56J0KcIhJh2o/L2azNgDjeRlribB+sOcKYDpOgSYrlMI+Kq/R6P0YGvI3fqQ7g4zy3 BZnw== X-Gm-Message-State: AOAM530SgH96HVbpb84M1Pd5xo+eZjEKknCoaftG1JLW6c6hIgHlJG3b C+EJy59DyyAv27eiBJNxv84= X-Google-Smtp-Source: ABdhPJyet9sCF3Vi6NTQyJAepJ8JO7kELNvYm1aQvjaC2BUsbTxs0kcKSVDBeBY91w1nxsLfdncydg== X-Received: by 2002:a17:90b:2245:: with SMTP id hk5mr10047155pjb.41.1639346357357; Sun, 12 Dec 2021 13:59:17 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id m6sm7973115pgs.18.2021.12.12.13.59.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 13:59:16 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <83tufdmu4d.fsf@gnu.org> From: Jim Porter Message-ID: Date: Sun, 12 Dec 2021 13:59:16 -0800 MIME-Version: 1.0 In-Reply-To: <83tufdmu4d.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/12/2021 12:43 PM, Eli Zaretskii wrote: >> Cc: 52293@debbugs.gnu.org, juri@linkov.net >> From: Jim Porter >> Date: Sun, 12 Dec 2021 12:27:34 -0800 >> >> On 12/11/2021 11:02 PM, Eli Zaretskii wrote: >>> Are you saying that we will be recommending a convention for separator >>> names only for menus popped up in context-menu-mode? Does it make >>> sense to have such a specialized convention? Isn't it possible to >>> show context menus outside of the context-menu-mode? >> >> No, I think this convention should be recommended for separators used >> anywhere in Emacs going forward. > > Ok, so then the effect of this change is wide, as I envisioned, and > compatibility considerations still apply. I'm also ok with applying this naming convention *only* to context menus and not treating this as a general guideline; that would still make it easier to remember the names of each context menu separator without having to double-check the source code. I don't even have a problem with closing that bug (bug#52286) as wontfix, since it's just a minor issue anyway. It's really not a big deal if the naming is inconsistent, so long as the names are still unique. I think this patch, which adds `top-separator' to help the de-duplication logic work better, would be useful to apply regardless of the decision on how the separators should be named. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 22:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams , Eli Zaretskii Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org>, "juri@linkov.net" Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163934714419839 (code B ref 52293); Sun, 12 Dec 2021 22:13:01 +0000 Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 22:12:24 +0000 Received: from localhost ([127.0.0.1]:53388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwX4x-00059u-Ub for submit@debbugs.gnu.org; Sun, 12 Dec 2021 17:12:24 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:38893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwX4x-00059i-60 for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 17:12:23 -0500 Received: by mail-pj1-f41.google.com with SMTP id p18-20020a17090ad31200b001a78bb52876so13305544pju.3 for <52293@debbugs.gnu.org>; Sun, 12 Dec 2021 14:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=OsmB7l8d5NY/9ixnT3DjFg4obANv1dxv2ZyW/NB4pHI=; b=B3yyx5sK+Is5UkYo4sRf+eGRq6n9Mib4+hDu4Bo4x+AEB8/GWZacX1k/6K8SOVAfAE P4pOlt+zsewpbftQBefvc1pEi4Woe3+8DJgFx5JTmwJOKzKato2ww2IolglbtJzlRRHQ v1h0S+ydBFM+DhwJn0uz7D1m0zeFt8nUzNugSgwrJmxrj30ZHQUj0An0NRPFOCVUxL98 GCR02U81DtSIQb3x7LBmDCWQmcziaZwfoPEWPUnho/Fa+rvaXYHrKugLMR4j5nG9cxDW p8I5TYwrYv3ZheNN3FKK9bKVOJrtS6SaCxxmRQ/1nQgTiSJp24xwYaKjRlwDj1RcKrhw drag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OsmB7l8d5NY/9ixnT3DjFg4obANv1dxv2ZyW/NB4pHI=; b=KN0Sl/W2qehtSB2XGyLlH+ElLDN30pQGecJcgELVQhfRZbKSwKczCCMj91MqXYNtdy 4EVEvHTBZVDUeqJLTicw/AD+Hf1DY2MjOJtBxMcfN5YzC+kTjQsZguEa07Apj/Y2S82y zSNapV8Auk/v3SwxxBQyn7V877xnbIHHIdG9VQnSBAGCOlTMRyuWEJKadYJsSfKCkWec WBeZTehKd3JbOg96gqF9cRNdVzoNjKfKsgfDGKaeTsGRX0dpHYrKgzSs6QQVvEiXrEC0 sMzgFofN4VedBoHKZOolIAGUM8F6p9m96yy9bpFptosDou2iU/0QhrD0TJJtiS2NkU5a XGhA== X-Gm-Message-State: AOAM533bvCsEkwzCLJhPIDkRPoYThD62DrlnY45BLom5IC/jAoL15qTK G5kk/zuWnYDcjN2wum6VqX8= X-Google-Smtp-Source: ABdhPJwT+forjAbW0TyFjw6l2wCadXo4WaCcq4lDBooTuK4OmjgjIxCHM2QqKmWftpKrAbRn425J3Q== X-Received: by 2002:a17:90a:5883:: with SMTP id j3mr39834305pji.13.1639347137409; Sun, 12 Dec 2021 14:12:17 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id j20sm4245700pjl.3.2021.12.12.14.12.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 14:12:17 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> From: Jim Porter Message-ID: Date: Sun, 12 Dec 2021 14:12:16 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/12/2021 1:00 PM, Drew Adams wrote: > Caveat: I'm not following this thread. FWIW: > > 1. In my code I have _lots_ of menu separators that > are apparently in what you call the old naming > convention. That's fine. I'd prefer we *not* update old menu separators, since that's a compatibility break. The only exception would be for existing context menu separators, since they're pretty new anyway, so the chance of any code relying on the old context menu names is low. > 3. I think there's zero need for any naming > convention for menu-item names, whether > separators or other. The goal was to make it easier to remember the names of the separators if you wanted to add a new item after a particular separator that had already been added. It's easier to remember if they're all `foo-separator' instead of a mix of styles. > 4. As I stated early on in this thread, I think > it's misguided to prevent the use of duplicate > separators. If someone wants such duplicates > for some reason (and there can be any number > of reasons), let them be. And if someone, for > some reason, wants to prevent such duplicates > they can do so easily enough, manually or by > code. Technically, this is already possible by using extended-format menu items. Only simple separators are de-duplicated. So this would be de-duplicated: (define-key menu [foo-separator] '("--")) But this wouldn't: (define-key menu [bar-separator] '(menu-item "--")) That's not documented though, and I'm not sure what promises we should make here. It might be better to have a more-explicit way of opting into de-duplication, but I'm not sure what that would be off-hand. It may be possible for context menu functions to be more careful about the insertion of separators so that duplicates never crop up in the first place. However, that would take a bit of experimentation, and I'm not sure of all the pros and cons of a solution like that. Maybe Juri has some thoughts on this though. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 23:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams , Eli Zaretskii Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org>, "juri@linkov.net" Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163935089425726 (code B ref 52293); Sun, 12 Dec 2021 23:15:02 +0000 Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 23:14:54 +0000 Received: from localhost ([127.0.0.1]:53419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwY3R-0006gs-Hl for submit@debbugs.gnu.org; Sun, 12 Dec 2021 18:14:54 -0500 Received: from mail-pj1-f46.google.com ([209.85.216.46]:51028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwY3P-0006gc-03 for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 18:14:51 -0500 Received: by mail-pj1-f46.google.com with SMTP id x7so10656866pjn.0 for <52293@debbugs.gnu.org>; Sun, 12 Dec 2021 15:14:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:mime-version :in-reply-to:content-language; bh=qGZWLE+xNcDY8aC4Wcn8R7xa0Qpf2lwjNfJ/YN4r2lY=; b=F0JBxhV861GBXSH6ktf004fX+4n+xkdgh8Y/gz1AxewkBvZYKn+k0QsNTXfDf539r7 C3+EmMAQDwfoEb6KOTjBgC7ZxCU5lS4B8LQgnyOKAgFygKeF40D9JqRKi1ibXddN+pwQ KJnl2EEk//ja40rrMxAjZycIrnWRpSFijXnzCpJASh04ZchPnNo9Ao1vad5i+JiTy9hM ZTsBDdBYGzZqQXIXAI4rGhWQgrgqyS8BJ3VgM3MCUWGS7Omj7NPJGCEUThg/HNoVZip+ NMjxbbvUcWSgXUbvkCcWTQRvWUjLr30eAsTDy9WAaTnwGL1CIfFnsfj39NZfbFpIgUKu UTwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :mime-version:in-reply-to:content-language; bh=qGZWLE+xNcDY8aC4Wcn8R7xa0Qpf2lwjNfJ/YN4r2lY=; b=egQAr+SHOnXnyu7defhWdcXGl2Cw39ne508CmpHGNP54he47hTOXNc8hW7iLK1szt5 yCQ6YNJtp68KResFjC6ichp5qBzKiIA5XQBH43VrPm4Dx/0RXzy+UfRxXM1FioZk4M9I kRwEnFxrtP8sPTCnRvo7gcHhmuP2jYHGo+wILXTmn2Quwk73rNoJqiw/kLVvSbpVnfRU 7TSd6zKcCWLkuZ/bXGTpOwNX43WN6SaAuDwc4/2uLyXlx7TgEjIyNhiZrvo0DAuNlyFA sV9jPjgDMj4j656eKr690oQd3asXmbaNY9czYGDs5P8UeofREh+Gzs5Kkc/F3pdAU6yl 6lOQ== X-Gm-Message-State: AOAM533rM7Hgh/RzXIP7btUQpczPZtVUjh2+XDc6ZpfSBVxguwlbid4H Yq8Nl1LM/PKl3CHiSmtvXRI= X-Google-Smtp-Source: ABdhPJwV3dFoPuQ/9G9bF+td+tpx6uOkPoAUpb7WB2L4bmr4z4I7bxJteAe1j46JWZ5Xl/Gxcs/k+A== X-Received: by 2002:a17:902:ce8c:b0:141:d218:954 with SMTP id f12-20020a170902ce8c00b00141d2180954mr90911362plg.1.1639350885271; Sun, 12 Dec 2021 15:14:45 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g5sm4895187pjt.15.2021.12.12.15.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 15:14:44 -0800 (PST) From: Jim Porter References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> Message-ID: Date: Sun, 12 Dec 2021 15:14:43 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------17A3EE286DE4FE8211D34A68" Content-Language: en-US X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------17A3EE286DE4FE8211D34A68 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/12/2021 2:12 PM, Jim Porter wrote: > It may be possible for context menu functions to be more careful about > the insertion of separators so that duplicates never crop up in the > first place. However, that would take a bit of experimentation, and I'm > not sure of all the pros and cons of a solution like that. Maybe Juri > has some thoughts on this though. Here's a *very* experimental patch that handles separators in a totally different way. Instead of removing duplicates, this *inserts* separators between different sections of the context menu. This works by giving menu items a `:section' property, and if that changes (and both the old and new section names are non-nil), the code inserts a separator between the two items. This patch only really works for elisp-mode using the default context menu functions, since I didn't want to spend too much time updating everything for a small experiment. It shouldn't be terribly hard to update all the other context menu functions if we decide to go with something like this though. This strategy seems less brittle from my experiments so far, since we no longer have to be so careful about getting the order of the keys exactly right in order to be able to detect the duplicated separators. It also makes it easier to insert duplicated separators if that's really what you want. --------------17A3EE286DE4FE8211D34A68 Content-Type: text/plain; charset=UTF-8; name="context-menu-sections.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="context-menu-sections.patch" ZGlmZiAtLWdpdCBhL2xpc3AvbW91c2UuZWwgYi9saXNwL21vdXNlLmVsCmluZGV4IDExZmRk M2Y2MzkuLmQzNDk5MTEwNGUgMTAwNjQ0Ci0tLSBhL2xpc3AvbW91c2UuZWwKKysrIGIvbGlz cC9tb3VzZS5lbApAQCAtMzI3LDMyICszMjcsMjkgQEAgY29udGV4dC1tZW51LW1hcAogICAg ICAgICAgICAgICAgICAgICAgICAgICAoc2V0cSBtZW51IChmdW5jYWxsIGZ1biBtZW51IGNs aWNrKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgbmlsKSkpCiAKLSAgICA7OyBSZW1v dmUgZHVwbGljYXRlIHNlcGFyYXRvcnMgYXMgd2VsbCBhcyBvbmVzIGF0IHRoZSBiZWdpbm5p bmcgb3IKLSAgICA7OyBlbmQgb2YgdGhlIG1lbnUuCi0gICAgKGxldCAoKGwgbWVudSkgc2F3 LWZpcnN0LWl0ZW0pCisgICAgOzsgSW5zZXJ0IHNlcGFyYXRvcnMgYmV0d2VlbiBkaWZmZXJl bnQgc2VjdGlvbnMgb2YgdGhlIGNvbnRleHQgbWVudS4KKyAgICAobGV0ICgobCBtZW51KSBz ZWN0aW9uKQogICAgICAgKHdoaWxlIChhbmQgKGNvbnNwIGwpCiAgICAgICAgICAgICAgICAg ICAoY29uc3AgKGNkciBsKSkpCi0gICAgICAgIDs7IElmIHRoZSBuZXh0IGl0ZW0gaXMgYSBz ZXBhcmF0b3IsIHJlbW92ZSBpdCBpZiAxKSB3ZSBoYXZlbid0Ci0gICAgICAgIDs7IHNlZW4g YW55IG90aGVyIGl0ZW1zIHlldCwgb3IgMikgaXQncyBmb2xsb3dlZCBieSBlaXRoZXIKLSAg ICAgICAgOzsgYW5vdGhlciBzZXBhcmF0b3Igb3IgdGhlIGVuZCBvZiB0aGUgbGlzdC4KLSAg ICAgICAgKGlmIChhbmQgKGVxdWFsIChjZHItc2FmZSAoY2FkciBsKSkgbWVudS1iYXItc2Vw YXJhdG9yKQotICAgICAgICAgICAgICAgICAob3IgKG5vdCBzYXctZmlyc3QtaXRlbSkKLSAg ICAgICAgICAgICAgICAgICAgIChudWxsIChjYWRkciBsKSkKLSAgICAgICAgICAgICAgICAg ICAgIChlcXVhbCAoY2RyLXNhZmUgKGNhZGRyIGwpKSBtZW51LWJhci1zZXBhcmF0b3IpKSkK LSAgICAgICAgICAgIChzZXRjZHIgbCAoY2RkciBsKSkKLSAgICAgICAgICA7OyBUaGUgImZp cnN0IGl0ZW0iIGlzIGFueSBjb25zIGNlbGw7IHRoaXMgZXhjbHVkZXMgdGhlCi0gICAgICAg ICAgOzsgYGtleW1hcCcgc3ltYm9sIGFuZCB0aGUgbWVudSBuYW1lLgotICAgICAgICAgICh3 aGVuIChjb25zcCAoY2FkciBsKSkgKHNldHEgc2F3LWZpcnN0LWl0ZW0gdCkpCi0gICAgICAg ICAgKHNldHEgbCAoY2RyIGwpKSkpKQorICAgICAgICAod2hlbiAoY29uc3AgKGNhZHIgbCkp CisgICAgICAgICAgKHdoZW4tbGV0ICgobmV4dC1zZWN0aW9uIChwbGlzdC1nZXQgKG50aGNk ciA0IChjYWRyIGwpKSA6c2VjdGlvbikpKQorICAgICAgICAgICAgKHdoZW4gKGFuZCBzZWN0 aW9uIChub3QgKGVxIHNlY3Rpb24gbmV4dC1zZWN0aW9uKSkpCisgICAgICAgICAgICAgIDs7 IFRoZSBzZWN0aW9uIG5hbWUgaGFzIGNoYW5nZWQuIEluc2VydCBhIG5ldyBzZXBhcmF0b3Iu CisgICAgICAgICAgICAgIChzZXRjZHIgbCAoY29ucyBgKCwobWFrZS1zeW1ib2wKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY29uY2F0ICJzZXBhcmF0b3ItIiBuZXh0 LXNlY3Rpb24pKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiLS0iKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNkciBsKSkpKQorICAgICAgICAgICAgKHNl dHEgc2VjdGlvbiBuZXh0LXNlY3Rpb24pKSkKKyAgICAgICAgKHNldHEgbCAoY2RyIGwpKSkp CiAKICAgICAod2hlbiAoZnVuY3Rpb25wIGNvbnRleHQtbWVudS1maWx0ZXItZnVuY3Rpb24p CiAgICAgICAoc2V0cSBtZW51IChmdW5jYWxsIGNvbnRleHQtbWVudS1maWx0ZXItZnVuY3Rp b24gbWVudSBjbGljaykpKQogICAgIG1lbnUpKQogCiAoZGVmdW4gY29udGV4dC1tZW51LW1p ZGRsZS1zZXBhcmF0b3IgKG1lbnUgX2NsaWNrKQotICAiQWRkIHNlcGFyYXRvciB0byB0aGUg bWlkZGxlIG9mIHRoZSBjb250ZXh0IG1lbnUuCisgICJBZGQgaW52aXNpYmxlIHNlcGFyYXRv ciB0byB0aGUgbWlkZGxlIG9mIHRoZSBjb250ZXh0IG1lbnUuCiBTb21lIGNvbnRleHQgZnVu Y3Rpb25zIGFkZCBtZW51IGl0ZW1zIGJlbG93IHRoZSBzZXBhcmF0b3IuIgotICAoZGVmaW5l LWtleS1hZnRlciBtZW51IFttaWRkbGUtc2VwYXJhdG9yXSBtZW51LWJhci1zZXBhcmF0b3Ip CisgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW21pZGRsZS1zZXBhcmF0b3JdICcobWVudS1p dGVtICItLSIgbmlsIDp2aXNpYmxlIG5pbCkpCiAgIG1lbnUpCiAKIChkZWZ1biBjb250ZXh0 LW1lbnUtdG9vbGJhciAobWVudSBfY2xpY2spCkBAIC0zODAsMTMgKzM3NywxMiBAQCBjb250 ZXh0LW1lbnUtZ2xvYmFsCiAoZGVmdW4gY29udGV4dC1tZW51LWxvY2FsIChtZW51IF9jbGlj aykKICAgIlBvcHVsYXRlIE1FTlUgd2l0aCBzdWJtZW51cyBwcm92aWRlZCBieSBtYWpvciBt b2RlLiIKICAgKHJ1bi1ob29rcyAnYWN0aXZhdGUtbWVudWJhci1ob29rICdtZW51LWJhci11 cGRhdGUtaG9vaykKLSAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbc2VwYXJhdG9yLWxvY2Fs XSBtZW51LWJhci1zZXBhcmF0b3IpCiAgIChsZXQgKChrZXltYXAgKGxvY2FsLWtleS1iaW5k aW5nIFttZW51LWJhcl0pKSkKICAgICAod2hlbiBrZXltYXAKICAgICAgIChtYXAta2V5bWFw IChsYW1iZGEgKGtleSBiaW5kaW5nKQogICAgICAgICAgICAgICAgICAgICAod2hlbiAoY29u c3AgYmluZGluZykKICAgICAgICAgICAgICAgICAgICAgICAoZGVmaW5lLWtleS1hZnRlciBt ZW51ICh2ZWN0b3Iga2V5KQotICAgICAgICAgICAgICAgICAgICAgICAgKGNvcHktc2VxdWVu Y2UgYmluZGluZykpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChhcHBlbmQgYmluZGlu ZyAnKDpzZWN0aW9uICJsb2NhbCIpKSkpKQogICAgICAgICAgICAgICAgICAgKG1lbnUtYmFy LWtleW1hcCBrZXltYXApKSkpCiAgIG1lbnUpCiAKQEAgLTQyMiw3ICs0MTgsNiBAQCBjb250 ZXh0LW1lbnUtdmMKIAogKGRlZnVuIGNvbnRleHQtbWVudS11bmRvIChtZW51IF9jbGljaykK ICAgIlBvcHVsYXRlIE1FTlUgd2l0aCB1bmRvIGNvbW1hbmRzLiIKLSAgKGRlZmluZS1rZXkt YWZ0ZXIgbWVudSBbc2VwYXJhdG9yLXVuZG9dIG1lbnUtYmFyLXNlcGFyYXRvcikKICAgKHdo ZW4gKGFuZCAobm90IGJ1ZmZlci1yZWFkLW9ubHkpCiAgICAgICAgICAgICAgKG5vdCAoZXEg dCBidWZmZXItdW5kby1saXN0KSkKICAgICAgICAgICAgICAoaWYgKGVxIGxhc3QtY29tbWFu ZCAndW5kbykKQEAgLTQzMCwyMiArNDI1LDI1IEBAIGNvbnRleHQtbWVudS11bmRvCiAgICAg ICAgICAgICAgICAoY29uc3AgYnVmZmVyLXVuZG8tbGlzdCkpKQogICAgIChkZWZpbmUta2V5 LWFmdGVyIG1lbnUgW3VuZG9dCiAgICAgICBgKG1lbnUtaXRlbSAsKGlmIChyZWdpb24tYWN0 aXZlLXApICJVbmRvIGluIFJlZ2lvbiIgIlVuZG8iKSB1bmRvCi0gICAgICAgICAgICAgICAg ICA6aGVscCAiVW5kbyBsYXN0IGVkaXRzIikpKQorICAgICAgICAgICAgICAgICAgOmhlbHAg IlVuZG8gbGFzdCBlZGl0cyIKKyAgICAgICAgICAgICAgICAgIDpzZWN0aW9uICJ1bmRvIikp KQogICAod2hlbiAoYW5kIChub3QgYnVmZmVyLXJlYWQtb25seSkKICAgICAgICAgICAgICAo dW5kby0tbGFzdC1jaGFuZ2Utd2FzLXVuZG8tcCBidWZmZXItdW5kby1saXN0KSkKICAgICAo ZGVmaW5lLWtleS1hZnRlciBtZW51IFt1bmRvLXJlZG9dCiAgICAgICBgKG1lbnUtaXRlbSAo aWYgdW5kby1pbi1yZWdpb24gIlJlZG8gaW4gUmVnaW9uIiAiUmVkbyIpIHVuZG8tcmVkbwot ICAgICAgICAgICAgICAgICAgOmhlbHAgIlJlZG8gbGFzdCB1bmRvbmUgZWRpdHMiKSkpCisg ICAgICAgICAgICAgICAgICA6aGVscCAiUmVkbyBsYXN0IHVuZG9uZSBlZGl0cyIKKyAgICAg ICAgICAgICAgICAgIDpzZWN0aW9uICJ1bmRvIikpKQogICBtZW51KQogCiAoZGVmdW4gY29u dGV4dC1tZW51LXJlZ2lvbiAobWVudSBjbGljaykKICAgIlBvcHVsYXRlIE1FTlUgd2l0aCBy ZWdpb24gY29tbWFuZHMuIgotICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtzZXBhcmF0b3It cmVnaW9uXSBtZW51LWJhci1zZXBhcmF0b3IpCisgIDs7KGRlZmluZS1rZXktYWZ0ZXIgbWVu dSBbc2VwYXJhdG9yLXJlZ2lvbl0gbWVudS1iYXItc2VwYXJhdG9yKQogICAod2hlbiAoYW5k IG1hcmstYWN0aXZlIChub3QgYnVmZmVyLXJlYWQtb25seSkpCiAgICAgKGRlZmluZS1rZXkt YWZ0ZXIgbWVudSBbY3V0XQogICAgICAgJyhtZW51LWl0ZW0gIkN1dCIga2lsbC1yZWdpb24K ICAgICAgICAgICAgICAgICAgIDpoZWxwCi0gICAgICAgICAgICAgICAgICAiQ3V0IChraWxs KSB0ZXh0IGluIHJlZ2lvbiBiZXR3ZWVuIG1hcmsgYW5kIGN1cnJlbnQgcG9zaXRpb24iKSkp CisgICAgICAgICAgICAgICAgICAiQ3V0IChraWxsKSB0ZXh0IGluIHJlZ2lvbiBiZXR3ZWVu IG1hcmsgYW5kIGN1cnJlbnQgcG9zaXRpb24iCisgICAgICAgICAgICAgICAgICA6c2VjdGlv biAicmVnaW9uIikpKQogICAod2hlbiBtYXJrLWFjdGl2ZQogICAgIChkZWZpbmUta2V5LWFm dGVyIG1lbnUgW2NvcHldCiAgICAgICA7OyBucy13aW4uZWwgc2FpZDogU3Vic3RpdHV0ZSBh IENvcHkgZnVuY3Rpb24gdGhhdCB3b3JrcyBiZXR0ZXIKQEAgLTQ1Niw3ICs0NTQsOCBAQCBj b250ZXh0LW1lbnUtcmVnaW9uCiAgICAgICAgICAgICAgICAgICA6aGVscCAiQ29weSB0ZXh0 IGluIHJlZ2lvbiBiZXR3ZWVuIG1hcmsgYW5kIGN1cnJlbnQgcG9zaXRpb24iCiAgICAgICAg ICAgICAgICAgICA6a2V5cyAsKGlmIChmZWF0dXJlcCAnbnMpCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJcXFtucy1jb3B5LWluY2x1ZGluZy1zZWNvbmRhcnldIgotICAgICAg ICAgICAgICAgICAgICAgICAgICAgIlxcW2tpbGwtcmluZy1zYXZlXSIpKSkpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAiXFxba2lsbC1yaW5nLXNhdmVdIikKKyAgICAgICAgICAg ICAgICAgIDpzZWN0aW9uICJyZWdpb24iKSkpCiAgICh3aGVuIChhbmQgKG9yIChndWktYmFj a2VuZC1zZWxlY3Rpb24tZXhpc3RzLXAgJ0NMSVBCT0FSRCkKICAgICAgICAgICAgICAgICAg KGlmIChmZWF0dXJlcCAnbnMpIDsgbGlrZSBwYXN0ZS1mcm9tLW1lbnUKICAgICAgICAgICAg ICAgICAgICAgIChjZHIgeWFuay1tZW51KQpAQCAtNDY0LDcgKzQ2Myw4IEBAIGNvbnRleHQt bWVudS1yZWdpb24KICAgICAgICAgICAgICAobm90IGJ1ZmZlci1yZWFkLW9ubHkpKQogICAg IChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW3Bhc3RlXQogICAgICAgYChtZW51LWl0ZW0gIlBh c3RlIiBtb3VzZS15YW5rLWF0LWNsaWNrCi0gICAgICAgICAgICAgICAgICA6aGVscCAiUGFz dGUgKHlhbmspIHRleHQgbW9zdCByZWNlbnRseSBjdXQvY29waWVkIikpKQorICAgICAgICAg ICAgICAgICAgOmhlbHAgIlBhc3RlICh5YW5rKSB0ZXh0IG1vc3QgcmVjZW50bHkgY3V0L2Nv cGllZCIKKyAgICAgICAgICAgICAgICAgIDpzZWN0aW9uICJyZWdpb24iKSkpCiAgICh3aGVu IChhbmQgKGNkciB5YW5rLW1lbnUpIChub3QgYnVmZmVyLXJlYWQtb25seSkpCiAgICAgKGxl dCAoKHN1Ym1lbnUgKG1ha2Utc3BhcnNlLWtleW1hcCAocHJvcGVydGl6ZSAiUGFzdGUgZnJv bSBLaWxsIE1lbnUiKSkpCiAgICAgICAgICAgKGkgMCkpCkBAIC00NzcsMTIgKzQ3NywxNCBA QCBjb250ZXh0LW1lbnUtcmVnaW9uCiAgICAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IChp ZiAoZmVhdHVyZXAgJ25zKSBbc2VsZWN0LXBhc3RlXSBbcGFzdGUtZnJvbS1tZW51XSkKICAg ICAgICAgYChtZW51LWl0ZW0gLChpZiAoZmVhdHVyZXAgJ25zKSAiU2VsZWN0IGFuZCBQYXN0 ZSIgIlBhc3RlIGZyb20gS2lsbCBNZW51IikKICAgICAgICAgICAgICAgICAgICAgLHN1Ym1l bnUKLSAgICAgICAgICAgICAgICAgICAgOmhlbHAgIkNob29zZSBhIHN0cmluZyBmcm9tIHRo ZSBraWxsIHJpbmcgYW5kIHBhc3RlIGl0IikpKSkKKyAgICAgICAgICAgICAgICAgICAgOmhl bHAgIkNob29zZSBhIHN0cmluZyBmcm9tIHRoZSBraWxsIHJpbmcgYW5kIHBhc3RlIGl0Igor ICAgICAgICAgICAgICAgICAgICA6c2VjdGlvbiAicmVnaW9uIikpKSkKICAgKHdoZW4gKGFu ZCBtYXJrLWFjdGl2ZSAobm90IGJ1ZmZlci1yZWFkLW9ubHkpKQogICAgIChkZWZpbmUta2V5 LWFmdGVyIG1lbnUgW2NsZWFyXQogICAgICAgJyhtZW51LWl0ZW0gIkNsZWFyIiBkZWxldGUt YWN0aXZlLXJlZ2lvbgogICAgICAgICAgICAgICAgICAgOmhlbHAKLSAgICAgICAgICAgICAg ICAgICJEZWxldGUgdGV4dCBpbiByZWdpb24gYmV0d2VlbiBtYXJrIGFuZCBjdXJyZW50IHBv c2l0aW9uIikpKQorICAgICAgICAgICAgICAgICAgIkRlbGV0ZSB0ZXh0IGluIHJlZ2lvbiBi ZXR3ZWVuIG1hcmsgYW5kIGN1cnJlbnQgcG9zaXRpb24iCisgICAgICAgICAgICAgICAgICA6 c2VjdGlvbiAicmVnaW9uIikpKQogCiAgIChsZXQgKChzdWJtZW51IChtYWtlLXNwYXJzZS1r ZXltYXAgKHByb3BlcnRpemUgIlNlbGVjdCIpKSkpCiAgICAgKGRlZmluZS1rZXktYWZ0ZXIg c3VibWVudSBbbWFyay13aG9sZS1idWZmZXJdCkBAIC01MDksNyArNTExLDcgQEAgY29udGV4 dC1tZW51LXJlZ2lvbgogICAgICAgICAgICAgICAgICAgICA6aGVscCAiRGVhY3RpdmF0ZSB0 aGUgcmVnaW9uIikpKQogCiAgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbc2VsZWN0LXJl Z2lvbl0KLSAgICAgIGAobWVudS1pdGVtICJTZWxlY3QiICxzdWJtZW51KSkpCisgICAgICBg KG1lbnUtaXRlbSAiU2VsZWN0IiAsc3VibWVudSA6c2VjdGlvbiAicmVnaW9uIikpKQogICBt ZW51KQogCiAoZGVmdW4gY29udGV4dC1tZW51LWZmYXAgKG1lbnUgY2xpY2spCmRpZmYgLS1n aXQgYS9saXNwL3Byb2dtb2Rlcy9lbGlzcC1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvZWxp c3AtbW9kZS5lbAppbmRleCA3ZGE5M2EzNTFhLi43OTk2MGYzODM5IDEwMDY0NAotLS0gYS9s aXNwL3Byb2dtb2Rlcy9lbGlzcC1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2VsaXNw LW1vZGUuZWwKQEAgLTE1Niw5ICsxNTYsNiBAQCBlbWFjcy1saXNwLW1vZGUtbWVudQogKGRl ZnVuIGVsaXNwLWNvbnRleHQtbWVudSAobWVudSBjbGljaykKICAgIlBvcHVsYXRlIE1FTlUg d2l0aCBzeW1ib2wgaGVscCBjb21tYW5kcyBhdCBDTElDSy4iCiAgICh3aGVuICh0aGluZy1h dC1tb3VzZSBjbGljayAnc3ltYm9sKQotICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW2Vs aXNwLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yCi0gICAgICAnbWlkZGxlLXNlcGFy YXRvcikKLQogICAgIChsZXQqICgoc3RyaW5nICh0aGluZy1hdC1tb3VzZSBjbGljayAnc3lt Ym9sIHQpKQogICAgICAgICAgICAoc3ltYm9sICh3aGVuIChzdHJpbmdwIHN0cmluZykgKGlu dGVybiBzdHJpbmcpKSkKICAgICAgICAgICAgKHRpdGxlIChjb25kCkBAIC0xNzgsMTQgKzE3 NSwxNiBAQCBlbGlzcC1jb250ZXh0LW1lbnUKICAgICAgICAgICBgKG1lbnUtaXRlbSAiTG9v ayB1cCBpbiBNYW51YWwiCiAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSAoX2NsaWNr KSAoaW50ZXJhY3RpdmUgImUiKQogICAgICAgICAgICAgICAgICAgICAgICAgKGluZm8tbG9v a3VwLXN5bWJvbCAnLHN5bWJvbCkpCi0gICAgICAgICAgICAgICAgICAgICAgOmhlbHAgLChm b3JtYXQgIkZpbmQgYCVzJyBpbiByZWxldmFudCBtYW51YWwiIHN5bWJvbCkpCi0gICAgICAg ICAgJ2VsaXNwLXNlcGFyYXRvcikKKyAgICAgICAgICAgICAgICAgICAgICA6aGVscCAsKGZv cm1hdCAiRmluZCBgJXMnIGluIHJlbGV2YW50IG1hbnVhbCIgc3ltYm9sKQorICAgICAgICAg ICAgICAgICAgICAgIDpzZWN0aW9uICJlbGlzcCIpCisgICAgICAgICAgJ21pZGRsZS1zZXBh cmF0b3IpCiAgICAgICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW2Rlc2NyaWJlLXN5bWJv bF0KICAgICAgICAgICBgKG1lbnUtaXRlbSAoZm9ybWF0ICJEZXNjcmliZSAlcyIgLHRpdGxl KQogICAgICAgICAgICAgICAgICAgICAgIChsYW1iZGEgKF9jbGljaykgKGludGVyYWN0aXZl ICJlIikKICAgICAgICAgICAgICAgICAgICAgICAgIChkZXNjcmliZS1zeW1ib2wgJyxzeW1i b2wpKQotICAgICAgICAgICAgICAgICAgICAgIDpoZWxwICwoZm9ybWF0ICJEaXNwbGF5IHRo ZSBkb2N1bWVudGF0aW9uIG9mIGAlcyciIHN5bWJvbCkpCi0gICAgICAgICAgJ2VsaXNwLXNl cGFyYXRvcikpKSkKKyAgICAgICAgICAgICAgICAgICAgICA6aGVscCAsKGZvcm1hdCAiRGlz cGxheSB0aGUgZG9jdW1lbnRhdGlvbiBvZiBgJXMnIiBzeW1ib2wpCisgICAgICAgICAgICAg ICAgICAgICAgOnNlY3Rpb24gImVsaXNwIikKKyAgICAgICAgICAnbWlkZGxlLXNlcGFyYXRv cikpKSkKICAgbWVudSkKIAogKGRlZnVuIGVtYWNzLWxpc3AtYnl0ZS1jb21waWxlICgpCmRp ZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9wcm9nLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rl cy9wcm9nLW1vZGUuZWwKaW5kZXggNDk2YjA4MTAxOC4uYWEyNTA4MGFiNSAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHJvZy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3By b2ctbW9kZS5lbApAQCAtNDYsMjAgKzQ2LDE5IEBAIHByb2ctbW9kZS1ob29rCiAoZGVmdW4g cHJvZy1jb250ZXh0LW1lbnUgKG1lbnUgY2xpY2spCiAgICJQb3B1bGF0ZSBNRU5VIHdpdGgg eHJlZiBjb21tYW5kcyBhdCBDTElDSy4iCiAgIChyZXF1aXJlICd4cmVmKQotICAoZGVmaW5l LWtleS1hZnRlciBtZW51IFtwcm9nLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yCi0g ICAgJ21pZGRsZS1zZXBhcmF0b3IpCi0KICAgKHVubGVzcyAoeHJlZi1mb3J3YXJkLWhpc3Rv cnktZW1wdHktcCkKICAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFt4cmVmLWZvcndhcmRd CiAgICAgICAnKG1lbnUtaXRlbSAiR28gRm9yd2FyZCIgeHJlZi1nby1mb3J3YXJkCi0gICAg ICAgICAgICAgICAgICA6aGVscCAiRm9yd2FyZCB0byB0aGUgcG9zaXRpb24gZ29uZSBCYWNr IGZyb20iKQotICAgICAgJ3Byb2ctc2VwYXJhdG9yKSkKKyAgICAgICAgICAgICAgICAgIDpo ZWxwICJGb3J3YXJkIHRvIHRoZSBwb3NpdGlvbiBnb25lIEJhY2sgZnJvbSIKKyAgICAgICAg ICAgICAgICAgIDpzZWN0aW9uICJwcm9nIikKKyAgICAgICdtaWRkbGUtc2VwYXJhdG9yKSkK IAogICAodW5sZXNzICh4cmVmLW1hcmtlci1zdGFjay1lbXB0eS1wKQogICAgIChkZWZpbmUt a2V5LWFmdGVyIG1lbnUgW3hyZWYtcG9wXQogICAgICAgJyhtZW51LWl0ZW0gIkdvIEJhY2si IHhyZWYtZ28tYmFjawotICAgICAgICAgICAgICAgICAgOmhlbHAgIkJhY2sgdG8gdGhlIHBv c2l0aW9uIG9mIHRoZSBsYXN0IHNlYXJjaCIpCi0gICAgICAncHJvZy1zZXBhcmF0b3IpKQor ICAgICAgICAgICAgICAgICAgOmhlbHAgIkJhY2sgdG8gdGhlIHBvc2l0aW9uIG9mIHRoZSBs YXN0IHNlYXJjaCIKKyAgICAgICAgICAgICAgICAgIDpzZWN0aW9uICJwcm9nIikKKyAgICAg ICdtaWRkbGUtc2VwYXJhdG9yKSkKIAogICAobGV0ICgoaWRlbnRpZmllciAoc2F2ZS1leGN1 cnNpb24KICAgICAgICAgICAgICAgICAgICAgICAobW91c2Utc2V0LXBvaW50IGNsaWNrKQpA QCAtNjgsMTIgKzY3LDE0IEBAIHByb2ctY29udGV4dC1tZW51CiAgICAgKHdoZW4gaWRlbnRp ZmllcgogICAgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbeHJlZi1maW5kLXJlZl0KICAg ICAgICAgYChtZW51LWl0ZW0gIkZpbmQgUmVmZXJlbmNlcyIgeHJlZi1maW5kLXJlZmVyZW5j ZXMtYXQtbW91c2UKLSAgICAgICAgICAgICAgICAgICAgOmhlbHAgLChmb3JtYXQgIkZpbmQg cmVmZXJlbmNlcyB0byBgJXMnIiBpZGVudGlmaWVyKSkKLSAgICAgICAgJ3Byb2ctc2VwYXJh dG9yKQorICAgICAgICAgICAgICAgICAgICA6aGVscCAsKGZvcm1hdCAiRmluZCByZWZlcmVu Y2VzIHRvIGAlcyciIGlkZW50aWZpZXIpCisgICAgICAgICAgICAgICAgICAgIDpzZWN0aW9u ICJwcm9nIikKKyAgICAgICAgJ21pZGRsZS1zZXBhcmF0b3IpCiAgICAgICAoZGVmaW5lLWtl eS1hZnRlciBtZW51IFt4cmVmLWZpbmQtZGVmXQogICAgICAgICBgKG1lbnUtaXRlbSAiRmlu ZCBEZWZpbml0aW9uIiB4cmVmLWZpbmQtZGVmaW5pdGlvbnMtYXQtbW91c2UKLSAgICAgICAg ICAgICAgICAgICAgOmhlbHAgLChmb3JtYXQgIkZpbmQgZGVmaW5pdGlvbiBvZiBgJXMnIiBp ZGVudGlmaWVyKSkKLSAgICAgICAgJ3Byb2ctc2VwYXJhdG9yKSkpCisgICAgICAgICAgICAg ICAgICAgIDpoZWxwICwoZm9ybWF0ICJGaW5kIGRlZmluaXRpb24gb2YgYCVzJyIgaWRlbnRp ZmllcikKKyAgICAgICAgICAgICAgICAgICAgOnNlY3Rpb24gInByb2ciKQorICAgICAgICAn bWlkZGxlLXNlcGFyYXRvcikpKQogCiAgICh3aGVuICh0aGluZy1hdC1tb3VzZSBjbGljayAn c3ltYm9sKQogICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW3NlbGVjdC1yZWdpb24gbWFy ay1zeW1ib2xdCg== --------------17A3EE286DE4FE8211D34A68-- From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Dec 2021 01:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter , Eli Zaretskii Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org>, "juri@linkov.net" Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16393582064472 (code B ref 52293); Mon, 13 Dec 2021 01:17:01 +0000 Received: (at 52293) by debbugs.gnu.org; 13 Dec 2021 01:16:46 +0000 Received: from localhost ([127.0.0.1]:53465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwZxJ-00019z-Ox for submit@debbugs.gnu.org; Sun, 12 Dec 2021 20:16:46 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:47772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwZxH-00019p-Cr for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 20:16:40 -0500 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BCFNWTc013242; Mon, 13 Dec 2021 01:16:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=S138O9noBf3cGsuL1GqMSm1N/gHxTwTIKDPw+KQQ+6Q=; b=c4IanJ+jq+vyJVrXg+HuDzB71l7UzXQ8kE6i8GLOr3WZ8AN5UI9R05ybPF22D5yjbFz8 MfO87Fnp1mDNI6xzIxqAiGzlKP8y2n0cB4p7xCS/ECUvmL68In6BDT6V5DTGF0mrxhag OFdVDlNtSlfwEkMzYNWaiLBWCz8wBLyh5o3LuAz3SN4MUCXyvP4PrzVPlglv+t51O/IH nUmuV+oRf2NzHEB8LmjJpSdOtKa9Xl1EKrMOfYh7mrIavSu5jYxEKSPlk3LDM0PlzYv8 PGg6BhGsT9PEXbfhONFuW4LlTpOmHH/y7jSvsrW0nTHcOJdZngPdWJXbfSM5yTwB/vKe Bg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3cvkv9t7c7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Dec 2021 01:16:37 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BD1FkDF167355; Mon, 13 Dec 2021 01:16:36 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2174.outbound.protection.outlook.com [104.47.57.174]) by aserp3030.oracle.com with ESMTP id 3cvj1bjr65-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Dec 2021 01:16:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T/1YLWhYcqxKyMuDLuoGIWTPoUMlf3Y9VPiC+hWbRjwN6iY1q7fqnCFx6NlOZ7MO+CpRTvmVIT18dDdd0pqt+kx0zpPajhQoNjgMvttFg64h5RVi4+G682yI6Z/+uK4IctsN3m8BSBNnRHnD6yWsNPaf+e5dqfFuNb5DpKOwbTvBXW6PqRhMvdLAoSlKNL/5dFenikWCLSwl5rzBE4Ma8kd+GY5U3Ru7qv7WAdFcZ6vTi/z4wV/JFIxDC0Ow4FO8ZvBrAO7rWIMRElRXV+rjZleEMBedDsMxzRM9Y/OiVm1F1boPAoNhmsUrRdhMBZHVCyUmMOWFUH6x2xkOSsq5kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S138O9noBf3cGsuL1GqMSm1N/gHxTwTIKDPw+KQQ+6Q=; b=Ib8VXsGbDt3wmjMKaTRka0STZJGrnvZjbfNuw/48rmBjjRRO4mYIKh0wbzJAASiLbGn8M9DR6Fvjs0FofV5ctfihdmjSy+UmT1SxVVHqjBr5ufmjSnLC7CVaIfeokET9qegYd/8S2K/TCNxKuM2Edf404IVknkoB45uAJMUyWqy3z0cgx8gfUQk4pMNkDd7OLwvRR6x6asOH96BRqN8zrFNQMrtCy997RiUHXGX6VLyxrW5KYp+YzAqMUsUEtELwum7d7QObt7vZD1mhbjdQc3TG/AAeMfIBU1/BZ4xvMj14hT3oo+k/TPCs/mTd77Wa/U07pEYVXqPy+1Yk0RnGGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S138O9noBf3cGsuL1GqMSm1N/gHxTwTIKDPw+KQQ+6Q=; b=rT5iwiDGLMrtsXDogpiQ9nTADrj8GpckwSPuJC1DjNoZAK1LD7ALmT8+Egnxz9ipo3wULv/VvUCkxtNHO/mICsFHcqOSbqC61j/OsbFIVhvggJl6IVUkg4Z5Q/rTroY+aYsA+y2vPW5HQgnDferRKVqIktOpwBV5e0XG3cQQTf4= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB3559.namprd10.prod.outlook.com (2603:10b6:a03:11e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Mon, 13 Dec 2021 01:16:33 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%8]) with mapi id 15.20.4778.016; Mon, 13 Dec 2021 01:16:33 +0000 From: Drew Adams Thread-Topic: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Thread-Index: AQHX76VVzh+lDyjBhk2uhDUC7PtZE6wvmHOg Date: Mon, 13 Dec 2021 01:16:33 +0000 Message-ID: References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: beac99c9-ed67-4282-0f4a-08d9bdd63381 x-ms-traffictypediagnostic: BYAPR10MB3559:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L//7NJZCk6MaZWiKEh6Q1C16npVB3OVV6+VPmVoLSeWfsY2gtfBCroVQPXYQg49/rvFWwx8deBThL05JoBS1paaep5XVRY1bQ2ut8Dj/8Jxavc9LTvM66xf5n7AeI2dR5FL3ycKiR4qAEvIn5DuYCeyZuMShelzAIgtq8UA/dfYIRDYavQ5rz1lMs74wbbSOFU7F4BI6ZBRbATqDTDitHlolld6fMQvaOnHg5XrsfuxisWPDvVmmhycEzPxs1S5a6qb/NPOfO2niPOEG/VNrGOUO22kPXo6aX9Uchdf8wES1jSKNdgSKKjxYn9wDfOO5CPV+tdzPI9nizCDxewFbb5CNIozSntrrxl4ekzeYzkOM5kJ08xgBHll1Nr6GYata860V69nnqnYsb88O0tSHRWOIlayNlSqjNzFcjjQOliXLKHJQ6mvW0jabuKhESb+U+jDsZvT5ILicAXZ7Yz71Cyeeysie4SiOm9e7nGLFsgBrlQ/UzKh/PW9JffK+2qFNq4NNQoVEOl/6cs8vUuFr0E9GL8xFnwsJTBQTcWU9xKAGEttzQweH+zcG91jgLF37oqsLwq+GP4T3o6EA7PfpIPlbKFpwgqtsopXrNOGZeHBkcMyDfnz637b3Mb9c+/7vOYCxI5fsAXcmOoLF/Ar4VF2GnaquS7panEViVhtLNhMmU/67x3xpOcrWD//vZF+rxdz8JvxjrXzP6jbDR0/Tvg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(54906003)(55016003)(38100700002)(38070700005)(8936002)(122000001)(8676002)(66556008)(66476007)(71200400001)(64756008)(66946007)(316002)(76116006)(110136005)(26005)(33656002)(7696005)(9686003)(52536014)(6506007)(86362001)(66446008)(4326008)(508600001)(5660300002)(2906002)(44832011)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: PWhhglQdx2gPRnP/XlxIEBbVexVGQMa4g6P4z7zkbLPBo6aA9BzVseFXFQgSABnZD0rCxyLxvfWjRaw2/VNgmHtaVz6cQwxwJ8IH4jp1OXFW8/nYkGgjePolsFQlGpDWRyyI1zjjaXRVBIKbaX6JV1AIx5Z2VU9lKFY7rUuzMlTRJ69aDb7d94Xc3EmR1/8qYaxJHb2PajdkSpd6UUAG4AedldzbFRgl/antyqgvm9c+nHSvnl1iX/kZpyyhQdxqp5J4/49eMLG+5q5uIQZO8OsjxpV+E0aGDDY/V6lDJkCR0TGyk1JomjSqEAGJPsXCNJqd8AfB61Rrz0aR9TgtfqotgEBdWgP6Wy05yEIRHkkFlivZ8cd6JxrXkjgBeTbl3oiY+rvGIqd61T1XrmO7qmseZsyZMiUG3f8neIzaxyxBTN7wXSKSdlmtlSnZ/ng3TelyrnthR8quhMh2DfDyfOyMgB8TGC1j+MxXazoIUwp+DLJs8iyiYMPyTp0fRoDI5ad+q7V2YX6nXCXSNBuhZFM9YHnVf7sA1Ef8Pz0E33o2rJXC0dAzfJ8rP5pc6NJDj7l/XSz+ttwE7uW4ZA+UFN3gAgBjfcl4VpuKPSOttQrP58dWVp9Ge2ZnjsZ7QGd2dLixAzzLYaaSAfVO/onFG7AL5wHrg0u5kyobp7FffTamLRzeFOxhAD3NFbI7TBTOjAc+ThJ9ZYbkpdpOCto8zQTFlDclU2jx94DqFukwvMbp3+gC1wbg2txiecDtvaTsX6TEB+9C4Cvqqq5aqA1p7JZ97OuwAJcXKfXU2YfcJb96Gj9uN43ZkBwhqW73tto7F3eBij6PnPljynznXkEKTeXLdN4honUHFf/SI4GQdcO1nz2OOb9KKgDceiXEARCP/hjlPfyVrjMQ5Y5045Ep51IEOQPs6E/4aEQbnegJjox6Qs8wyfJIcab207x70FtSu2d4jxAKNEnxbozfhrxpXHb2a+53RqJRx7RykgTD7K0nbXXHE1n21Y8wsiE/OJ+/dlhQiDvegLomHrMZYHWY6uD45tUnHI4wxpN0FufVSvpcaP0jHNXyjuJsfwJy0PtOU54wmKutLPl0jx7vyodFe/xTYJIh0esyKPXyeSa8n6rpRP5xzb07KFPcBrcXF8SNOckMBbjUraHK2mCP9kWcAsS5Le2bgAZ4zshsRvTquUhfoKD7e5M441zFGRgDBDLyh+LVYop3LMnIOnaqP1Q3mrXAyJgLFANI8OSqGsx6IUP+etnmX6ad/IqGzX3hUVHOFeVUF0zAVnAwNB8NWlGn2oVUYKBjrXplA/qSTnkOx7tSO/aindO+SWSk97/NCS25vb6vXry5vKV0SP9GvYvaHyR9BcBnZ1kT8nj/gzmVP2HmO13GsEO7Q/qiuudzHpinYfHE4TuQUw2owdScjF2NWGs04fyti5guzcs1ZG0KmOS5TinPQaHf9wMB/PnVPO7YatGQjH4LR8voTGdeR1J4oLdGq1MK5NRVycIL/uflBZA93r/IqlhpUN53lHzvcwnNRzhVnyBBrPKKp4PbhXk6esFAxLne/ZGtJMi+OKTTTiMh3ALHDErbcFLI8QR7uJISbyTqqxghvAV7teAjnLomEA== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: beac99c9-ed67-4282-0f4a-08d9bdd63381 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2021 01:16:33.3758 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YgnuTbVEX2oeyS/eA8ElPc02NtblEWy7KrUlaQD1BqcXZP6YhzUM8y9tOsriB/HxS1XTYS3p3dmD5EM+oN1YCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3559 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10196 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112130006 X-Proofpoint-GUID: 81Oe0LVx4paHGj0QMe1XB0R2vKqNB-_s X-Proofpoint-ORIG-GUID: 81Oe0LVx4paHGj0QMe1XB0R2vKqNB-_s X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) PiA+IDMuIEkgdGhpbmsgdGhlcmUncyB6ZXJvIG5lZWQgZm9yIGFueSBuYW1pbmcNCj4gPiAgICAg Y29udmVudGlvbiBmb3IgbWVudS1pdGVtIG5hbWVzLCB3aGV0aGVyDQo+ID4gICAgIHNlcGFyYXRv cnMgb3Igb3RoZXIuDQo+IA0KPiBUaGUgZ29hbCB3YXMgdG8gbWFrZSBpdCBlYXNpZXIgdG8gcmVt ZW1iZXIgdGhlIG5hbWVzIG9mIHRoZSBzZXBhcmF0b3JzDQo+IGlmIHlvdSB3YW50ZWQgdG8gYWRk IGEgbmV3IGl0ZW0gYWZ0ZXIgYSBwYXJ0aWN1bGFyIHNlcGFyYXRvciB0aGF0IGhhZA0KPiBhbHJl YWR5IGJlZW4gYWRkZWQuIEl0J3MgZWFzaWVyIHRvIHJlbWVtYmVyIGlmIHRoZXkncmUgYWxsDQo+ IGBmb28tc2VwYXJhdG9yJyBpbnN0ZWFkIG9mIGEgbWl4IG9mIHN0eWxlcy4NCg0KV2h5IGRvZXMg YW55b25lIG5lZWQgdG8gX3JlbWVtYmVyXyBzdWNoIG5hbWVzPw0KV2hhdCdzIHRoZSB1c2UgY2Fz ZSBmb3IgcmVtZW1iZXJpbmc/DQoNCj4gPiA0LiBBcyBJIHN0YXRlZCBlYXJseSBvbiBpbiB0aGlz IHRocmVhZCwgSSB0aGluaw0KPiA+ICAgICBpdCdzIG1pc2d1aWRlZCB0byBwcmV2ZW50IHRoZSB1 c2Ugb2YgZHVwbGljYXRlDQo+ID4gICAgIHNlcGFyYXRvcnMuICBJZiBzb21lb25lIHdhbnRzIHN1 Y2ggZHVwbGljYXRlcw0KPiA+ICAgICBmb3Igc29tZSByZWFzb24gKGFuZCB0aGVyZSBjYW4gYmUg YW55IG51bWJlcg0KPiA+ICAgICBvZiByZWFzb25zKSwgbGV0IHRoZW0gYmUuICBBbmQgaWYgc29t ZW9uZSwgZm9yDQo+ID4gICAgIHNvbWUgcmVhc29uLCB3YW50cyB0byBwcmV2ZW50IHN1Y2ggZHVw bGljYXRlcw0KPiA+ICAgICB0aGV5IGNhbiBkbyBzbyBlYXNpbHkgZW5vdWdoLCBtYW51YWxseSBv ciBieQ0KPiA+ICAgICBjb2RlLg0KPiANCj4gVGVjaG5pY2FsbHksIHRoaXMgaXMgYWxyZWFkeSBw b3NzaWJsZSBieSB1c2luZyBleHRlbmRlZC1mb3JtYXQgbWVudQ0KPiBpdGVtcy4gT25seSBzaW1w bGUgc2VwYXJhdG9ycyBhcmUgZGUtZHVwbGljYXRlZC4gU28gdGhpcyB3b3VsZCBiZQ0KPiBkZS1k dXBsaWNhdGVkOg0KPiANCj4gICAgKGRlZmluZS1rZXkgbWVudSBbZm9vLXNlcGFyYXRvcl0gJygi LS0iKSkNCj4gDQo+IEJ1dCB0aGlzIHdvdWxkbid0Og0KPiANCj4gICAgKGRlZmluZS1rZXkgbWVu dSBbYmFyLXNlcGFyYXRvcl0gJyhtZW51LWl0ZW0gIi0tIikpDQoNCkRlZHVwbGljYXRpb24/ICBX ZSdyZSBub3QgdGFsa2luZyBhYm91dCByZW1vdmluZw0KZXhhY3QgZHVwbGljYXRlcyBhcmUgd2U/ ICBJIHRob3VnaHQgdGhpcyB3YXMgYWJvdXQNCnJlbW92aW5nIGNvbnNlY3V0aXZlIHNlcGFyYXRv cnMsIGxlYXZpbmcgb25seSBvbmUuDQpUaGlzIGludm9sdmVzIG5vIGR1cGxpY2F0ZSBtZW51IGl0 ZW1zOg0KDQogIChkZWZpbmUta2V5IG1lbnUgW3NlcGFyYXRvci0xXSAnKCItLSIpKQ0KICAoZGVm aW5lLWtleSBtZW51IFtzZXBhcmF0b3ItMl0gJygiLS0iKSkNCg0KTW9yZSBpbXBvcnRhbnRseSwg SSBkaWRuJ3Qga25vdyB0aGlzIHdhcyBhYm91dA0KcmVtb3ZpbmcgYW55IG9yZGluYXJ5IGBkZWZp bmUta2V5JyBiaW5kaW5ncy4NCkkgcmVhbGx5IGhvcGUgaXQncyBub3QuICBJIHRob3VnaHQgdGhp cyB3YXMgb25seQ0KZm9yIEp1cmkncyBuZXcgY29udGV4dCBtZW51cy4NCg0KSWYgd2UncmUgbm93 IGF1dG9tYXRpY2FsbHkgcmVtb3ZpbmcgY29uc2VjdXRpdmUNCnNlcGFyYXRvcnMgY29kZWQgd2l0 aCBgZGVmaW5lLWtleScgdGhlbiBjb3VudCBtZQ0KYXMgb25lIHVzZXIgd2hvJ3MgZGVmaW5pdGVs eSBhZ2FpbnN0IHRoYXQuDQoNCldoYXQgY2FuIHBvc3NpYmx5IGJlIHRoZSByZWFzb24gZm9yIGlt cG9zaW5nIHRoYXQNCmtpbmQgb2YgbWVkZGxpbmcgd2l0aCBzb21lb25lJ3MgY29kZSwgcHJldmVu dGluZw0KRW1hY3MgZnJvbSBzaG93aW5nIGNvbnNlY3V0aXZlIHNlcGFyYXRvcnMgKHdpdGhvdXQN CmhhdmluZyB0byBhZGQgc3VwZXJmbHVvdXMgYG1lbnUtaXRlbSdzKT8gDQoNCj4gVGhhdCdzIG5v dCBkb2N1bWVudGVkIHRob3VnaCwgYW5kIEknbSBub3Qgc3VyZSANCj4gd2hhdCBwcm9taXNlcyB3 ZSBzaG91bGQgbWFrZSBoZXJlLiANCg0KVGhlIG9ubHkgcHJvbWlzZSBJLCBhcyBvbmUgdXNlciwg YW0gaW50ZXJlc3RlZA0KaW4gaGVhcmluZyBpcyBub3QgdG8gbmV1dGVyIGNvZGUgdGhhdCBjcmVh dGVzDQpjb25zZWN1dGl2ZSBtZW51IHNlcGFyYXRvcnMuDQoNCj4gSXQgbWlnaHQgYmUgYmV0dGVy IHRvIGhhdmUgYSBtb3JlLWV4cGxpY2l0IHdheSBvZiBvcHRpbmcgaW50bw0KPiBkZS1kdXBsaWNh dGlvbiwgYnV0IEknbSBub3Qgc3VyZSB3aGF0IHRoYXQgd291bGQgYmUgb2ZmLWhhbmQuDQoNCldo eSBzaG91bGQgd2UgZXZlbiBwcm92aWRlIHN1Y2ggcmVtb3ZhbD8gIElmDQpzb21lb25lIGRvZXNu J3Qgd2FudCBpdCB0aGV5IHdvbid0IGNvZGUgaXQuDQpUaGF0J3MgYWxsLg0KDQpBbmQgaWYgaXQg YXBwZWFycyBiZWNhdXNlIHNvbWUgbWVudSBpdGVtcyB0aGF0DQptaWdodCBvdGhlcndpc2UgYmUg cHJlc2VudCBiZXR3ZWVuIDIgc2VwYXJhdG9ycw0KYXJlbid0IGRpc3BsYXllZCAoZS5nLiBiZWNh dXNlIG9mIDp2aXNpYmxlKSwNCnRoZW4gaXQncyB1cCB0byB0aGUgY29kZXIgdG8gZGVhbCB3aXRo IHRoYXQuDQpNYXliZSBzaGUgd2FudHMgdG8gc2hvdyB0aGF0IHRoZXJlIGFyZSBtaXNzaW5nDQpt ZW51IGl0ZW1zLCBieSB1c2luZyBjb25zZWN1dGl2ZSBzZXBhcmF0b3JzLg0KDQpJIGRvbid0IGNs YWltIHRvIGtub3cgd2hhdCB5b3UncmUgcmVhbGx5IGRvaW5nLA0KYnV0IElJVUMsIHRoaXMgaXMg b3Zlcm92ZXJlbmdpbmVlcmluZy4NCg0KSWYgeW91IGluc3RlYWQganVzdCBwcm92aWRlZCBhIGNv ZGluZyB3YXkgZm9yDQpzb21lb25lIHRvIGluZGljYXRlLCBhdCBzb21lIHBhcnRpY3VsYXIgcGFy dCBvZg0KYSBtZW51LCB0aGF0IGEgc2VwYXJhdG9yIHNob3VsZG4ndCBiZSBzaG93biBpZg0KaXQg ZGlyZWN0bHkgZm9sbG93cyBhbm90aGVyIHNlcGFyYXRvciwgdGhlbiBqdXN0DQpkbyB0aGF0Lg0K DQooQW5kIHRoYXQgc2hvdWxkIGFscmVhZHkgYmUgcG9zc2libGUsIHVzaW5nDQo6aW52aXNpYmxl IGZvciB0aGUgc2VwYXJhdG9yIGl0c2VsZi4pDQoNCj4gSXQgbWF5IGJlIHBvc3NpYmxlIGZvciBj b250ZXh0IG1lbnUgZnVuY3Rpb25zDQoNCklzIHRoaXMgYWxsIG9ubHkgYWJvdXQgX2NvbnRleHRf IG1lbnVzIG9yIG5vdD8NCg0KSWYgaXQgaXMsIEkgZG9uJ3QgY2FyZSBhIGxvdC4gIEJ1dCBpZiBp dCdzIGFib3V0DQptZW51cyBnZW5lcmFsbHksIHRoZW4gd2hhdCBJIHRoaW5rIEknbSBoZWFyaW5n DQppc24ndCBzb21ldGhpbmcgSSdtIGluIGZhdm9yIG9mLiAgQnV0IGFnYWluLA0KanVzdCBvbmUg b3Bpbmlvbi4NCg0KPiB0byBiZSBtb3JlIGNhcmVmdWwgYWJvdXQNCj4gdGhlIGluc2VydGlvbiBv ZiBzZXBhcmF0b3JzIHNvIHRoYXQgZHVwbGljYXRlcyBuZXZlciBjcm9wIHVwIGluIHRoZQ0KPiBm aXJzdCBwbGFjZS4NCg0KV2h5IGRvIHlvdSBjYXJlIGlmIHRoZXkgImNyb3AgdXAiPw0KDQo+IEhv d2V2ZXIsIHRoYXQgd291bGQgdGFrZSBhIGJpdCBvZiBleHBlcmltZW50YXRpb24sIGFuZCBJJ20N Cj4gbm90IHN1cmUgb2YgYWxsIHRoZSBwcm9zIGFuZCBjb25zIG9mIGEgc29sdXRpb24gbGlrZSB0 aGF0LiBNYXliZSBKdXJpDQo+IGhhcyBzb21lIHRob3VnaHRzIG9uIHRoaXMgdGhvdWdoLg0K From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Dec 2021 01:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams , Eli Zaretskii Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org>, "juri@linkov.net" Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16393600287267 (code B ref 52293); Mon, 13 Dec 2021 01:48:01 +0000 Received: (at 52293) by debbugs.gnu.org; 13 Dec 2021 01:47:08 +0000 Received: from localhost ([127.0.0.1]:53492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwaQl-0001t9-It for submit@debbugs.gnu.org; Sun, 12 Dec 2021 20:47:07 -0500 Received: from mail-pg1-f174.google.com ([209.85.215.174]:42877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwaQj-0001sf-DO for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 20:47:05 -0500 Received: by mail-pg1-f174.google.com with SMTP id l18so8520374pgj.9 for <52293@debbugs.gnu.org>; Sun, 12 Dec 2021 17:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=aJLqtsAr96VTQtckJnOBNK9OjqvP/YUxB8WsA06KgwM=; b=Gq3yZNO0WR73RzljliLi33Aam0oozJfeMu5iM3QZJH9ct91bY2BqTPzkVc8B9lZHS4 4oZ+Vq2fbWztwHiewoCSDi+NKjEH1LjaCl3QO6CF2R/0oEfWGp83IsrCUMzV9e3CMqnd cw+KFmAHzHSJS+40np6emuxH7eTVLMmSAGoiaHWzlYrcveFKOE6DSNg58ww97sQOcgg/ 5yrUFObKXPbTutB1bpkxa6hjx4J07NQes6r3+Dr3pky8EgJNZkWBLoHkWXZFxf5qrG0X vFilTIpX4/+lVNQgFLoSmwEntdyd6L8CJ3mS+liZBqlXU1MeHZY1xLZTdAlN1F9P2QVF uQfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aJLqtsAr96VTQtckJnOBNK9OjqvP/YUxB8WsA06KgwM=; b=gU3HTHo7nvLpG8HHawz4vWzyjVPH3cCOs475VRv9Yl/KWYy7CSFGp+SEbiZgk2cfHk EkFOuVZq7biiibDGe6vUxTZj52es7LDe+/vuXNlMVadyRiNB9UObtFhB1CfitshBGeNg 6br5ulTWD6G7CQzz3uZph2r5V8x4AjrxQM6hCdXjN4RYFNTLOBsSE9iXOt+ErNMzawS+ SD+30CKOTjwsaxfpgBrCbpB0QP0TS3ZzZAIjnz+VLS8orV9ZDrmvr6TqeeZrPyRVCL4U b7jrvAPAS4ayvYOPJRh6PAF2D7IZl296DemzuerNn5H96V1MXQCnFUNGVo6MlpDofkSU giyQ== X-Gm-Message-State: AOAM533+1YRVlI+hW8khA4UAzl8faamCZvT4yZhCmzfccmF21VDK4Nyf Jvof3PdAe7jgiQg3cSDT4wk= X-Google-Smtp-Source: ABdhPJw5gD5ebNqlWWkEVjS9MPFWArjOjcP+dZx2xGzBLSvBLKLBfnYARqm4DMla0goQEk5fWGm29g== X-Received: by 2002:a05:6a00:cc9:b0:49f:b439:8930 with SMTP id b9-20020a056a000cc900b0049fb4398930mr31244012pfv.86.1639360019490; Sun, 12 Dec 2021 17:46:59 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id t13sm10012755pfl.214.2021.12.12.17.46.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 17:46:59 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> From: Jim Porter Message-ID: <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> Date: Sun, 12 Dec 2021 17:46:58 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/12/2021 5:16 PM, Drew Adams wrote: >>> 3. I think there's zero need for any naming >>> convention for menu-item names, whether >>> separators or other. >> >> The goal was to make it easier to remember the names of the separators >> if you wanted to add a new item after a particular separator that had >> already been added. It's easier to remember if they're all >> `foo-separator' instead of a mix of styles. > > Why does anyone need to _remember_ such names? > What's the use case for remembering? A third-party package author may want to insert context menu items in a particular spot in the menu (i.e. use `define-key-after'). Because the naming convention of separators is inconsistent, the author can more easily slip up and use the wrong name. As you might be able to tell, this is a very small issue. But the fix was easy, so I posted a patch for it. I really don't have a problem with closing that bug as wontfix if it's controversial. > Deduplication? We're not talking about removing > exact duplicates are we? I thought this was about > removing consecutive separators, leaving only one. > This involves no duplicate menu items: > > (define-key menu [separator-1] '("--")) > (define-key menu [separator-2] '("--")) That's correct. The above menu items would be de-duplicated since they're both separators. However, that logic only applies to "simple" separators, so the de-duplication code doesn't apply to this: (define-key menu [separator-1] '(menu-item "--")) (define-key menu [separator-2] '(menu-item "--")) (It's possible that's just an accidental omission in the original code though.) > More importantly, I didn't know this was about > removing any ordinary `define-key' bindings. > I really hope it's not. I thought this was only > for Juri's new context menus. This is *only* for context menus. The de-duplication code is in `context-menu-map', which is a function that gets called when opening the context menu. It calls all the elements of `context-menu-functions' in order, and then does the de-duplication step. No other menus will be affected by this. In any case, I think I prefer the solution I proposed in my followup: instead of removing consecutive separators so things look right, we can *add* separators between different "sections" of the context menu. Sections can be marked by the `:section' keyword and a name for the section (note: this only applies to the context menu, not other menus). That should completely prevent any unwanted manipulation of menus, since the programmer needs to opt into this behavior explicitly. In my limited tests, that method is also less brittle than the current method (this bug is an example of the brittleness). See my other message[1] for more details. [1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-12/msg01079.html From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Dec 2021 02:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter , Eli Zaretskii Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org>, "juri@linkov.net" Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163936332512369 (code B ref 52293); Mon, 13 Dec 2021 02:43:02 +0000 Received: (at 52293) by debbugs.gnu.org; 13 Dec 2021 02:42:05 +0000 Received: from localhost ([127.0.0.1]:53540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwbHw-0003DR-TP for submit@debbugs.gnu.org; Sun, 12 Dec 2021 21:42:05 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:45206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwbHu-0003D8-Fz for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 21:42:03 -0500 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BCFWhQw024834; Mon, 13 Dec 2021 02:42:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=nfdN84ntaFmKxASB2vVsGotwOeZZvVOZgoT6cSrw7Yo=; b=l9frAwOAOL0GksvPdEzZmqgHOFbVvbRwao4gY5yOs4iPBfth29p9wZxSEwHFpvVh1I4x kKSvIz3zDB/gdxu60AjWrAt4fW76H4YnjhOsAFykLUB8CU1zP3e46z7TwpNSYVcluU2Y neJsqE3zBgbpc+JzMAa1lAamEyKjdwlu4lPm3TiZ2nKLfC1tqpH1AARN14nGZDdthL4y in8FF2JkpEFUZyngsybQaQ3ZmIy9CjnotRJGg9aSL6kMF0qcT3XumrWCP0T1IdpK+wjU 8Mg993xAYHcjh6brCkgLkP8VGj2cK+ap/Okb8jqoozfzRLAGdZh5Ib/vql6D+vyhDRts Rw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3cvjdcjaqy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Dec 2021 02:42:00 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BD2eOlq134610; Mon, 13 Dec 2021 02:42:00 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by aserp3020.oracle.com with ESMTP id 3cvkt29tyr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Dec 2021 02:41:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mEFDGGHd25VtIrvXJnjQ7HxbCx9y9NWrpyoini5ECi3FLU3L5GKljY3KKdC9GVMdUyxz1c83AxKDBDvtrE4s0QKjU8LKAhZTyuESFnXRw59IZEqURtwiU1ATnQ811NkIlQYUO5kyaPjIIPBPGoeSjfIoX6tfUrU1d7wGK/6c/LIfOUg4/AiLpTRjhp4LmPatHJFM4QVDP1By/3NEbFV4JEtR+jywo4ZYHsefINinPA12Co2alSB2pcED/o+thccBc3MctYNC08EcK8jePJv6TzSgQm8JEaIu+OmX0lpxaBiP2MXvF6Mtj4gpsQ68LQ2XosfVTeb4IXYoZBaqd37TGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nfdN84ntaFmKxASB2vVsGotwOeZZvVOZgoT6cSrw7Yo=; b=ahZ5pancrilX32x7RCA5BQxPLmx8ZuwjYBKHRdhBfpebj7+rjR7qytyP+GMhmzx8zhYEAGxStExK/3uyhnNxVyS82QOnq7D3BFsfYdhlqleWnovUFaSYv5YiwnkNvjuc1K47OCk/Vb6a4H3T3674fwL4kPf08s7PZ80D153+N90yxlvnpw8VWhluBA+9MR7gTlfNgxMNMHpMxNXBAb0QQz7E6sjiepj9xmwkAs7ndlNU/eaMvy2snZKrUHlASkgJmua1UyRpZgZ+44wpSB8hUk8jU/yeLjYyV+ynU3Grpz9NFCiIIQALCz/oS/0bj7iTmBrodcyNr0W4wmJjoXwt6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nfdN84ntaFmKxASB2vVsGotwOeZZvVOZgoT6cSrw7Yo=; b=ptn2c9O/5AoChkDfEsJqWiBnzo55jXXDES77FXgXc8ea+PKhJEj/pnye+aKm0uxsuNeGR5WPqvEKBGl0xiL0WxDC7yLzXHPK1WQaNVnPvD9vG7n+2KwFF/9cHk3cXC4M8vfimLpq0f+q2x/w3EgjVRF9GaxZZ1F4fg4mLQ1dWM4= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by SJ0PR10MB5836.namprd10.prod.outlook.com (2603:10b6:a03:3ed::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Mon, 13 Dec 2021 02:41:57 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%8]) with mapi id 15.20.4778.016; Mon, 13 Dec 2021 02:41:57 +0000 From: Drew Adams Thread-Topic: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Thread-Index: AQHX78NUGis7Us2P/U+3/b16Y06dQqwvtalA Date: Mon, 13 Dec 2021 02:41:57 +0000 Message-ID: References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> In-Reply-To: <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e2fb7349-b1e1-442c-cb7c-08d9bde221e1 x-ms-traffictypediagnostic: SJ0PR10MB5836:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9wKNtlD0jbxhnRThuENSfpyu6SJuqfBSAWzWfB3GUDsFjrv4yRwUVBpfiSMW0i5U240bPOpDRpD2T5Y9fsoEoLH9CekVgU70HHvBIjGRo45UCSIfHr8SGfjFsUaLQ3Pe13sCGOvWINbZ4C/535rB7s4160h0nakrZ9VjQ7MlA5W22WltgRr1kABMJ5WvKCqViFPiwZTCaPITuOw8vdnUMKeHmK8LqboxfIAA8PKfcdjahVNLiQHhCjiOEhw4KwhS9I+6pAUanBFc7aBYwz8pKmXn0Du0XS1z0Pj+F1WnwRSIsFhX5xQg3xKJmz8yDTg2crOnbYpsswIQWvh76r2hVwggv8uii1Z1ppSq/wW2MvIGR1u9/XNQ9dN7itlQmn49CMNCSKUKd181U6SqqaBkO4Mum3ShawTbCHj8MBuCzZNWLpqe0lYVrSIPKehFx34TVN8gw2SQ23Kf0prPJIXU+B/9lFXwdOcfpq9d28YvFvnGO0THN7cDxxpBqe26WPmTUvDxzSB0dhC+lWxgPsUfHNVVtgvMR8liQ0Xn1e1rCBOM0+qDqj5l2Hg14BzCbUiyJIEkywc9hcQCqJLMiKnAKfamhqTXu/VzHabTFQD2OmBTg37WVN+T5WAKGJMMFP+7neamNh/AQQdkOa6j2D886rwC4LKdcTytfSnohOaJeO5w8qAzuizEhqeZBDI2TqntnAAypGAORhu4k2zl3Dq7Ug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6506007)(71200400001)(316002)(110136005)(4326008)(7696005)(86362001)(8676002)(54906003)(38070700005)(122000001)(76116006)(66446008)(64756008)(66476007)(66556008)(66946007)(5660300002)(9686003)(508600001)(186003)(44832011)(2906002)(38100700002)(52536014)(26005)(33656002)(55016003)(8936002)(4744005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: kDR1tZtp7oOZc8f9rR2rsm0z+2lT859VcRUVmadtQk9IC5t3ii9f5PulEwKchF8UXLLL3qF+2PW5J4s3BOc/Ir/sBq3P/4eL/SiyssR8DIbIkAhKFsLJMbSfitjYvhlaiixcU64zi8EI8A92b8RMWd+S+Pucr3BK5CFCyuxzQa76qL4ANsvJ2/MAaM3Ptevh0ZHkPFZzQq9lTl0kmrMvyXS1lUwtVKQvsJK9kVBoTLDE3KO4cgXNNGz+WJ88ts7+ZxClHyQ0wMBMG49IPIsC22PhyOOMkBmfBctwGZ2fhUPgQ91+Gt3mWmAAb4lY2ymzo4rHhs67Mk4BjHlrHKFybNNyMbrHulCs2yJrIv3TIvlVgvxoub4JBA+eP01N51pZyDMZWNX22O0NeDCPVLjdyRa5nwOFq8CtIT0KPBrabgQmnV5Zt7+0c/8DRp5MkYqsudSaUgRuQU7JWgS7KvL34ZvD/gWR3aTv/eDACuStpw5Doi2wJX8RSFPWeXI9C6yTmjHVM2d6fNX8/oBBDp+hOTU2mx2KVOt8D6xdw1h7x9HifhJ/W+rkvB1oKnM9sebVj4LppJFWTTNSx6PtAbdm8SGpaHSV/q3r/PHzDmpC/IZMJj0VcXrF4LIEzrzcu8owD2OK5X5YiEqSQoZxpa1fwFR/6FuiaaxkGDH5ymcUFn3DS0DAmoMfRXVBg3cGX3dPV2SPtRtnAbhCpLD8Duaq8D0DBWt1IE1TFDq0fuLdLsqM9tLSgeu1oCMfQw7HKdV8cO5LFlqftgm4OTZyHwESRtSoRo78P+GHGNRVJ/qMjIqYAYhF6TFJ2TRwjzVQ+oX3ExUXZAjZG+gjutY1Pu1EEUHJ4ljUvpppYPwa0xen2f+d1lbBxWrAtdUxe+hC6zRh/Da/7tLxKPThYNwGAvq/8yaAzop89OT39JrVsSPEVo939JNEXdVKNXmqWBEyhXrHKQK6Ajg5KrZVTiNylrgsAtBa6wn9w1lj3H6q4QK/naTeRIceAJHaXUDb2yg9LkyHvuOgD9lExNqxOL9EbyZJu/wA+ysKLPOJ2buGO4BBONMi9ZkMEm6O3n9iNqHwwUTLHvGImt68uxFMOjw78un0YbdZXnc+6lcUEkEfNHYX/RFIEXNPhfrVxGFMTRujhx4it5DTiLu1FIFQw2P9+6BkttMFoZFdxN7IErRygWsxZD9UWaEtOAhgumyWsH00NHgPgl/p8gtmY+30MMzebMt3URVJnX+cdT4Hj27klP18SW0mohXUnpLIYnNvpbF6RoSjhZVsQ/nGEP2t7/ltfhJXywqYfsFfemTfbNIcGt6BxPVmK7rPZ69o7V9yuM2vuuKA/vDO+hntHtWEbaXiPKTuztBjgiqafzzWyMBR8JEX/yi7k4jyH8NjrmDUbU6dlOdOWAwPnauVwIJkldUi1KVJNpH5bYE+84W29nlQzULn/dxO0tc0KF5uhH/cfh7GO0H9V3UxAGd1HcJFS5fFE5RqmszJcFgCPfa/3LuNMTM6ioo0vMdJxtMPXYaPC2R4N0BPKMl0rHfVZr/eMEJhwF8aVQBzdvifKHkd7JVNBuWShNfT5Uwl28UJpT5FpGP+QZzyP6Z+u7KCuWtgJ40Xn7oTtg== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2fb7349-b1e1-442c-cb7c-08d9bde221e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2021 02:41:57.7559 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +VfMBd/BAxwvzdz0lfojQyMM5FT0XvGXRFXN9jYjfKtfkaqCKxjuf+NLx3L0ePOnmTRbqFap8D44tuRYdBi52g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5836 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10196 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=930 phishscore=0 malwarescore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112130014 X-Proofpoint-ORIG-GUID: -eh65Pfr0B_HXhtV4qm8V9W-7BHvqAWN X-Proofpoint-GUID: -eh65Pfr0B_HXhtV4qm8V9W-7BHvqAWN X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiBUaGlzIGlzICpvbmx5KiBmb3IgY29udGV4dCBtZW51cy4gDQoNCk9LLCB0aGFua3MuICBWZXJ5 IGdsYWQgdG8gaGVhciB0aGF0Lg0KSW4gdGhhdCBjYXNlLCB5b3UgY2FuIGZvcmdldCBJIHNhaWQg YW55dGhpbmcsDQphbmQgc29ycnkgZm9yIHRoZSBub2lzZS4NCg0KPiBJbiBhbnkgY2FzZSwgSSB0 aGluayBJIHByZWZlciB0aGUgc29sdXRpb24gSSBwcm9wb3NlZCBpbiBteSBmb2xsb3d1cDoNCj4g aW5zdGVhZCBvZiByZW1vdmluZyBjb25zZWN1dGl2ZSBzZXBhcmF0b3JzIHNvIHRoaW5ncyBsb29r IHJpZ2h0LCB3ZSBjYW4NCj4gKmFkZCogc2VwYXJhdG9ycyBiZXR3ZWVuIGRpZmZlcmVudCAic2Vj dGlvbnMiIG9mIHRoZSBjb250ZXh0IG1lbnUuDQo+IFNlY3Rpb25zIGNhbiBiZSBtYXJrZWQgYnkg dGhlIGA6c2VjdGlvbicga2V5d29yZCBhbmQgYSBuYW1lIGZvciB0aGUNCj4gc2VjdGlvbiAobm90 ZTogdGhpcyBvbmx5IGFwcGxpZXMgdG8gdGhlIGNvbnRleHQgbWVudSwgbm90IG90aGVyIG1lbnVz KS4NCj4gVGhhdCBzaG91bGQgY29tcGxldGVseSBwcmV2ZW50IGFueSB1bndhbnRlZCBtYW5pcHVs YXRpb24gb2YgbWVudXMsIHNpbmNlDQo+IHRoZSBwcm9ncmFtbWVyIG5lZWRzIHRvIG9wdCBpbnRv IHRoaXMgYmVoYXZpb3IgZXhwbGljaXRseS4NCg0KU291bmRzIGJldHRlciB0byBtZSB0b28sIEZX SVcuDQo= From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Dec 2021 09:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org>, Drew Adams Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.1639388897361 (code B ref 52293); Mon, 13 Dec 2021 09:49:02 +0000 Received: (at 52293) by debbugs.gnu.org; 13 Dec 2021 09:48:17 +0000 Received: from localhost ([127.0.0.1]:54168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwhwP-00005l-73 for submit@debbugs.gnu.org; Mon, 13 Dec 2021 04:48:17 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:47425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwhwM-00005I-Em for 52293@debbugs.gnu.org; Mon, 13 Dec 2021 04:48:15 -0500 Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id D9B7CFF812; Mon, 13 Dec 2021 09:48:06 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> Date: Mon, 13 Dec 2021 10:47:22 +0200 In-Reply-To: <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> (Jim Porter's message of "Sun, 12 Dec 2021 17:46:58 -0800") Message-ID: <86czm0eue5.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> This involves no duplicate menu items: >> (define-key menu [separator-1] '("--")) >> (define-key menu [separator-2] '("--")) > > That's correct. The above menu items would be de-duplicated since they're > both separators. However, that logic only applies to "simple" separators, > so the de-duplication code doesn't apply to this: > > (define-key menu [separator-1] '(menu-item "--")) > (define-key menu [separator-2] '(menu-item "--")) > > (It's possible that's just an accidental omission in the original code > though.) Actually, this wasn't an omission. Now that I'm thinking more about this, maybe separators that are subject to possible removal could be marked by e.g. using text properties, thus opting into this behavior explicitly: (defconst context-menu-separator (list (propertize "--" 'remove t))) (define-key menu [separator-1] context-menu-separator) (define-key menu [separator-2] context-menu-separator) Then code that de-duplicates separators could check for this property. > In any case, I think I prefer the solution I proposed in my followup: > instead of removing consecutive separators so things look right, we can > *add* separators between different "sections" of the context menu. Sections > can be marked by the `:section' keyword and a name for the section (note: > this only applies to the context menu, not other menus). That should > completely prevent any unwanted manipulation of menus, since the programmer > needs to opt into this behavior explicitly. > > In my limited tests, that method is also less brittle than the current > method (this bug is an example of the brittleness). See my other message[1] > for more details. Adding a new keyword to every menu item requires more work from authors of context menus, and actually makes menus more brittle - when an author forgets to add the new keyword `:section' to some menu item, then two unexpected separators will be inserted: before and after such an item. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Dec 2021 12:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 52293@debbugs.gnu.org, juri@linkov.net Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163939823224598 (code B ref 52293); Mon, 13 Dec 2021 12:24:02 +0000 Received: (at 52293) by debbugs.gnu.org; 13 Dec 2021 12:23:52 +0000 Received: from localhost ([127.0.0.1]:54306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwkMy-0006Og-Gm for submit@debbugs.gnu.org; Mon, 13 Dec 2021 07:23:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwkMw-0006OT-7h for 52293@debbugs.gnu.org; Mon, 13 Dec 2021 07:23:50 -0500 Received: from [2001:470:142:3::e] (port=56902 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwkMq-00020F-GK; Mon, 13 Dec 2021 07:23:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9HLLMBxgbCvOmB4zafPoMqAVxj4WL+HjVJ4GxN8EFAk=; b=MtxOHn7PpEoO iXDsfGwluMVM++su1hxLGQKXo4dzk9CsMBSpvd7IpWYmh2I+ko5VLyxI8fy2goIEuVrNTCXMU+06L bnYjpviJ9E22K4FH3CJw0ecpSzjnWa1xx99lfbBNQ5Rwu9K70w0tkzG/e51MEoMjLlONZexSIsyjS pPrH9mrEz2ildUSIqe8xJVglu426H3OkW9WPDvn/caw9feIzVfB3SfD3igluEZ8VNV/qXhXVAPfJw J9XGKZ1i8v7KM1+dpPCkOgi24uCwAGBpbvnBTgL8g41fT3U6PCrMwMX8Cc612kcFYhBkTds3rimaJ o3hSj2N7hoUwOBqUk9skMA==; Received: from [87.69.77.57] (port=4470 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwkMq-00077L-9r; Mon, 13 Dec 2021 07:23:44 -0500 Date: Mon, 13 Dec 2021 14:23:38 +0200 Message-Id: <83pmq0n16d.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Sun, 12 Dec 2021 13:59:16 -0800) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <83tufdmu4d.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 52293@debbugs.gnu.org, juri@linkov.net > From: Jim Porter > Date: Sun, 12 Dec 2021 13:59:16 -0800 > > On 12/12/2021 12:43 PM, Eli Zaretskii wrote: > >> Cc: 52293@debbugs.gnu.org, juri@linkov.net > >> From: Jim Porter > >> Date: Sun, 12 Dec 2021 12:27:34 -0800 > >> > >> On 12/11/2021 11:02 PM, Eli Zaretskii wrote: > >>> Are you saying that we will be recommending a convention for separator > >>> names only for menus popped up in context-menu-mode? Does it make > >>> sense to have such a specialized convention? Isn't it possible to > >>> show context menus outside of the context-menu-mode? > >> > >> No, I think this convention should be recommended for separators used > >> anywhere in Emacs going forward. > > > > Ok, so then the effect of this change is wide, as I envisioned, and > > compatibility considerations still apply. > > I'm also ok with applying this naming convention *only* to context menus > and not treating this as a general guideline; that would still make it > easier to remember the names of each context menu separator without > having to double-check the source code. I don't think this would make sense, and I said that above. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Dec 2021 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163941632431288 (code B ref 52293); Mon, 13 Dec 2021 17:26:02 +0000 Received: (at 52293) by debbugs.gnu.org; 13 Dec 2021 17:25:24 +0000 Received: from localhost ([127.0.0.1]:56698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwp4m-00088a-DL for submit@debbugs.gnu.org; Mon, 13 Dec 2021 12:25:24 -0500 Received: from mail-pf1-f182.google.com ([209.85.210.182]:38775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwp4i-00088K-0u for 52293@debbugs.gnu.org; Mon, 13 Dec 2021 12:25:23 -0500 Received: by mail-pf1-f182.google.com with SMTP id g18so15528374pfk.5 for <52293@debbugs.gnu.org>; Mon, 13 Dec 2021 09:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=B4xWjtVrzDfAOlLwMxsqEmES+a/ZSsealZVhyfeqfFk=; b=Jf29/G3tyAc6C2v2TgtBAqVtG6T6fMRCk0ktm0MmrX5ANLWmFG8/3tk1BIdPzX4ZCO BRmM+PdJwJpGROs13lbyVZ1qWvQdtWF7SxDRepDuJ9EXOpgxD8nqDnpR7YSYpY68hxBD Uvtmo7f7Rx7E/bEuqeCWn6iqZ+Sgzi8k4lDOmFD8HvJQ7jYI7BithE+nofupG7JdqOaA whgm56oy+5m+MKsa8PqAib4jjdZthq0R6NgHF1fTQ1MfyNfhd2L0sLYcQsty7ZmBV6Hy nhgaTJZsSloQwkZYBLtTZSwDcRs7Yhs3aexzC5ZtprH2IqkZvzRstO+y2T3osnd8rzBp aMyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B4xWjtVrzDfAOlLwMxsqEmES+a/ZSsealZVhyfeqfFk=; b=z6aonjDj+PxgFvdiX9i71Cp4XoCdZSgyMYLfZeWEBfHwYYYvPYa+w59dHmRMUT5PWx YuYfSLLnCw2Uj+pKEVMwRD2N1IBNfP3ta8OlhxOaRhz1qnOCAvlubpqTBJ3Iz/Sljyu8 /mmjztVJoOeGHYUzp9PHNa67ZLF4nDNxO6LeVyx1RzRIUN4r4N9MyBvgVGeh4aqd0GxI dmm3PkE6EtOB6Rn1IKcB25I0CDe4CykYGQA2rSe2ap+znVm6ROCoxfUK8lYkrBeJW0Ye v99R0I8mviQOf8X803DFYhPmFKu8id9xUSNv3t91SPzCnO6rLkfgufCfYUaKgmEW/6/k Rrpg== X-Gm-Message-State: AOAM532FWjyJT5+lTUbxbyGdVBxZGz0ptxOcUfFNgeizDUkqkH6Ctifa n8PcBu7dc7sB+5nvx/HY/hbdxNDF948= X-Google-Smtp-Source: ABdhPJz4KgCcO2FY8f0OEiXFKYdPq3KOmQbLUjBxOzEHcVKZA5NCdPitwAesfpqlTpLY9Da+R8q+hg== X-Received: by 2002:a63:e04f:: with SMTP id n15mr53284015pgj.31.1639416314042; Mon, 13 Dec 2021 09:25:14 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b16sm11077898pgi.36.2021.12.13.09.25.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Dec 2021 09:25:13 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> From: Jim Porter Message-ID: <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> Date: Mon, 13 Dec 2021 09:25:14 -0800 MIME-Version: 1.0 In-Reply-To: <86czm0eue5.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/13/2021 12:47 AM, Juri Linkov wrote: > Actually, this wasn't an omission. Now that I'm thinking more about this, > maybe separators that are subject to possible removal could be marked by e.g. > using text properties, thus opting into this behavior explicitly: > > (defconst context-menu-separator (list (propertize "--" 'remove t))) > (define-key menu [separator-1] context-menu-separator) > (define-key menu [separator-2] context-menu-separator) > > Then code that de-duplicates separators could check for this property. If we did that, how about using an extend-format separator, since it already supports properties? We could just add a new property for the de-duplicator to check: (define-key menu [separator-1] '(menu-item "--" nil :deduplicate t)) Maybe there's a relatively simple way to reuse `:visible' for this? One benefit to this being opt-in is that if people wanted this behavior for other menus, it would be possible to add it without breaking any existing code. > Adding a new keyword to every menu item requires more work from authors > of context menus, and actually makes menus more brittle - > when an author forgets to add the new keyword `:section' to some menu item, > then two unexpected separators will be inserted: before and after > such an item. The way I've implemented this now shouldn't have this problem: if a menu item doesn't have a `:section', it's treated as being in the same section as the previous item (unless there were no sections before this item; in that case, it's treated as being in the same section as the next item). It's only actually *required* to specify the section for the first item in the section. One of the main benefits here is that we don't have to be as careful with the order of menu items. For example, my previous patch[1] adds `top-separator' so that we can ensure the context menu title is always the first item in the keymap in order to let us find consecutive separators. With `:section', the `top-separator' patch can be thrown out, and programmers can use `define-key' to add menu items to the top as they normally would. However, using `:section' makes it harder to insert new items at the beginning of a previously-defined section. With separators, you can just call `define-key-after' and pass in the separator's name, but it's pretty tricky when using `:section'. One way to handle this would be to add `define-key-before', but then the programmer still has to remember to add `:section'. In the end, there's a tradeoff with each implementation. When using separators, programmers have to be careful to use `define-key-after' (and if we add a property to opt into de-duplication, to use the property). When using `:section', programmers have to remember to set the section, and we probably want to add something like `define-key-before' to make things easier[2]. I think the implementation of `context-menu-map' is slightly easier to follow for `:section' too, but the difference isn't major (that said, my current implementation is just a sketch and could use some cleanup). [1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-12/msg00709.html [2] This may be useful in general though. It's not *strictly* necessary, but it'd be helpful in any case where you want to insert a menu item before another, but you don't know the name of the item already preceding it in the menu. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Dec 2021 18:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 52293@debbugs.gnu.org, juri@linkov.net Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16394192203256 (code B ref 52293); Mon, 13 Dec 2021 18:14:01 +0000 Received: (at 52293) by debbugs.gnu.org; 13 Dec 2021 18:13:40 +0000 Received: from localhost ([127.0.0.1]:56716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwppT-0000qR-JE for submit@debbugs.gnu.org; Mon, 13 Dec 2021 13:13:39 -0500 Received: from mail-pj1-f54.google.com ([209.85.216.54]:52787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwppR-0000qD-3U for 52293@debbugs.gnu.org; Mon, 13 Dec 2021 13:13:38 -0500 Received: by mail-pj1-f54.google.com with SMTP id h24so12462574pjq.2 for <52293@debbugs.gnu.org>; Mon, 13 Dec 2021 10:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=9I9oKu/CQY+TcgND4YyJOsMrLFPjIBbyIERUHimf3tI=; b=ZVvZny39f1BGzFzsRNfHtKL2o+ScK+gxnfjYLtBNuzPSFOLLKRIxcA8MMenfXDxcJk X+8n1Oa/2ErbCV0RViuAZNByviIrWMdApV5ZiKt2/G94EOk/F3RUnvAYsFQhYezFfCJY /hlbNh12rhh70/hWmdrHoEOMab23prYx6K2O8FD1PNXBvske5koI0HpC5H5B1ocLdOJY /kYrsPcNqwzYUcXidRcGzozN5at6xaZSNLvk5lvN5V8SHkAaBg72BTCBZIapDCeqtz40 GXRhvLonMY18f/9tBy4omKJfLPpWpCqW2lGP/5+M5sO3JmNjPE6G+Ks2NGlUoI1jpWsX aJKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9I9oKu/CQY+TcgND4YyJOsMrLFPjIBbyIERUHimf3tI=; b=lrxkebjPowS7zFpNxPsFeEMyF4Fde1kJXZGqvO8lvMsCwODM2wL1scmU5O25HkPeM0 li07m6fcO8Gh8OehBySlo+tq21ZHF18c3PdndiiHnZDJu6IVBSYuj4itFrO6By7ET2Pb b9A7DKDqf1BooFkUsP5OBBbniwV27c33y1qilAUyrdUM4O3D9hh44kNiLEkWKcrUPWbo t4wkswjv+kGGJFa6J+0MuzhXZQlbd0ddmeQsIJGCShuknwF8kBkgXBAypG0X5y667fHR Oh/AWKdBaqbwyWTUO/yh0nw6oS8wO0TcfkRB2iGg8yOIlo5gsKuk4BzxsnoYYKX8ei1s ejIQ== X-Gm-Message-State: AOAM530e8MWnMXvzX4SlKxIH0ZPKsG426zAMmrP8lHoDcG4+OWsSZYl2 CmB+Yun4/ZQ+XjZryF2sttE= X-Google-Smtp-Source: ABdhPJzrVxeAExSXYHInvqWvzBVxo2F4n96ghFNlCrDrAoA7j3f+3D//L6Z/ZzfViw2Vrby1+P9Gsg== X-Received: by 2002:a17:90a:6b44:: with SMTP id x4mr32515pjl.27.1639419211321; Mon, 13 Dec 2021 10:13:31 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id z2sm13864925pfh.188.2021.12.13.10.13.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Dec 2021 10:13:30 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <83tufdmu4d.fsf@gnu.org> <83pmq0n16d.fsf@gnu.org> From: Jim Porter Message-ID: <1cc8a566-717a-e391-e9f4-98cd6ad81eac@gmail.com> Date: Mon, 13 Dec 2021 10:13:28 -0800 MIME-Version: 1.0 In-Reply-To: <83pmq0n16d.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/13/2021 4:23 AM, Eli Zaretskii wrote: >> Cc: 52293@debbugs.gnu.org, juri@linkov.net >> From: Jim Porter >> Date: Sun, 12 Dec 2021 13:59:16 -0800 >> >> On 12/12/2021 12:43 PM, Eli Zaretskii wrote: >>>> Cc: 52293@debbugs.gnu.org, juri@linkov.net >>>> From: Jim Porter >>>> Date: Sun, 12 Dec 2021 12:27:34 -0800 >>>> >>>> On 12/11/2021 11:02 PM, Eli Zaretskii wrote: >>>>> Are you saying that we will be recommending a convention for separator >>>>> names only for menus popped up in context-menu-mode? Does it make >>>>> sense to have such a specialized convention? Isn't it possible to >>>>> show context menus outside of the context-menu-mode? >>>> >>>> No, I think this convention should be recommended for separators used >>>> anywhere in Emacs going forward. >>> >>> Ok, so then the effect of this change is wide, as I envisioned, and >>> compatibility considerations still apply. >> >> I'm also ok with applying this naming convention *only* to context menus >> and not treating this as a general guideline; that would still make it >> easier to remember the names of each context menu separator without >> having to double-check the source code. > > I don't think this would make sense, and I said that above. I don't really have a preference about what we recommend in the documentation. We don't need to recommend anything at all. Above, I was just referring to changing the separator names within context-menu-mode functions to use a single style (`foo-separator'), not necessarily documenting/recommending it. Even the code change I only have a very slight preference for. I was just reading through the context-menu code to understand it, saw that some separators were named `foo-separator' and others named `separator-foo', and thought that was a bit odd. The only "problem" (and it's barely a problem) is that programmers writing code referring to these separators later (e.g. with `define-key-after') might get the names mixed up if they're not paying attention. Since I came across it, I thought I'd submit a patch in case the maintainers wanted it. However, if it's controversial (or just too late in the release cycle to make a small compatibility break), I don't have a problem with closing bug#52286 as wontfix. It's such a minor issue that I really don't see any major downside to wontfixing the bug if there's any hesitation about it. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Dec 2021 19:21:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16394232419736 (code B ref 52293); Mon, 13 Dec 2021 19:21:03 +0000 Received: (at 52293) by debbugs.gnu.org; 13 Dec 2021 19:20:41 +0000 Received: from localhost ([127.0.0.1]:56854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwqsL-0002Wx-Bz for submit@debbugs.gnu.org; Mon, 13 Dec 2021 14:20:41 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:55631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwqsH-0002WW-GX for 52293@debbugs.gnu.org; Mon, 13 Dec 2021 14:20:38 -0500 Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A33BDFF807; Mon, 13 Dec 2021 19:20:30 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> Date: Mon, 13 Dec 2021 20:58:58 +0200 In-Reply-To: <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> (Jim Porter's message of "Mon, 13 Dec 2021 09:25:14 -0800") Message-ID: <86fsqwmig7.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Actually, this wasn't an omission. Now that I'm thinking more about this, >> maybe separators that are subject to possible removal could be marked by e.g. >> using text properties, thus opting into this behavior explicitly: >> (defconst context-menu-separator (list (propertize "--" 'remove t))) >> (define-key menu [separator-1] context-menu-separator) >> (define-key menu [separator-2] context-menu-separator) >> Then code that de-duplicates separators could check for this property. > > If we did that, how about using an extend-format separator, since it > already supports properties? We could just add a new property for the > de-duplicator to check: > > (define-key menu [separator-1] '(menu-item "--" nil :deduplicate t)) > > Maybe there's a relatively simple way to reuse `:visible' for this? > > One benefit to this being opt-in is that if people wanted this behavior for > other menus, it would be possible to add it without breaking any existing > code. I agree that using an extend-format separator is a good idea, especially if we'll provide a special variable that will contain it. But I don't understand why opt-in. I think opt-out would be better since most of the time the users want to have de-duplicated menus. >> Adding a new keyword to every menu item requires more work from authors >> of context menus, and actually makes menus more brittle - >> when an author forgets to add the new keyword `:section' to some menu item, >> then two unexpected separators will be inserted: before and after >> such an item. > > The way I've implemented this now shouldn't have this problem: if a menu > item doesn't have a `:section', it's treated as being in the same section > as the previous item (unless there were no sections before this item; in > that case, it's treated as being in the same section as the next > item). It's only actually *required* to specify the section for the first > item in the section. So the authors will have the requirement to be careful to mark the first menu item. When the menus are added conditionally, then authors will need to mark several menu items that can become the first menu item. > One of the main benefits here is that we don't have to be as careful with > the order of menu items. For example, my previous patch[1] adds > `top-separator' so that we can ensure the context menu title is always the > first item in the keymap in order to let us find consecutive > separators. With `:section', the `top-separator' patch can be thrown out, > and programmers can use `define-key' to add menu items to the top as they > normally would. The same way the `top-separator' can be avoided when post-processing code will search the menu title and move it to the beginning before starting to remove duplicates, or to use some more complex logic that takes into account the location of the menu title in the middle of the menu. > However, using `:section' makes it harder to insert new items at the > beginning of a previously-defined section. With separators, you can just > call `define-key-after' and pass in the separator's name, but it's pretty > tricky when using `:section'. One way to handle this would be to add > `define-key-before', but then the programmer still has to remember to add > `:section'. Please also consider additional costs for authors to learn about this subset of the standard menu functionality with more features. Currently authors have no problems with constructing the standard menus with separators, but with `:section' they need to learn that this feature is not available in all menus, but only in context menus, this would be too confusing. > In the end, there's a tradeoff with each implementation. When using > separators, programmers have to be careful to use `define-key-after' (and > if we add a property to opt into de-duplication, to use the property). When > using `:section', programmers have to remember to set the section, and we > probably want to add something like `define-key-before' to make things > easier[2]. I think the implementation of `context-menu-map' is slightly > easier to follow for `:section' too, but the difference isn't major (that > said, my current implementation is just a sketch and could use some > cleanup). > > [1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-12/msg00709.html > [2] This may be useful in general though. It's not *strictly* necessary, > but it'd be helpful in any case where you want to insert a menu item before > another, but you don't know the name of the item already preceding it in > the menu. Maybe better first to try fixing the problem using the separators? When this doesn't help, only then we could consider alternatives. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Dec 2021 05:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163946047619988 (code B ref 52293); Tue, 14 Dec 2021 05:42:01 +0000 Received: (at 52293) by debbugs.gnu.org; 14 Dec 2021 05:41:16 +0000 Received: from localhost ([127.0.0.1]:57331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx0Yu-0005CJ-HO for submit@debbugs.gnu.org; Tue, 14 Dec 2021 00:41:16 -0500 Received: from mail-pj1-f49.google.com ([209.85.216.49]:51012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx0Yq-0005C4-Lc for 52293@debbugs.gnu.org; Tue, 14 Dec 2021 00:41:15 -0500 Received: by mail-pj1-f49.google.com with SMTP id x7so13542742pjn.0 for <52293@debbugs.gnu.org>; Mon, 13 Dec 2021 21:41:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=hxN1MqMCHIhmzZ9AoU8rNrZpha2n+Y2YOgmBDYbVwYM=; b=CnPZthMwMF+G8KOZ3wu7MYuX9dvtbA9CLFGflIpyXs/HPvwssLQA9cVrYIP+y6ui2S RntaAL0ZUModeHax1EItOqSBrH0Okcr5vD6BTWK2e1VIjRo+kUSH3rmC8UMT2p388vNH V4Bdmy6zYZ6EMT0ZlWei+XKf7roiUzclhRLYn1qjB0BLxPCHe/+cKuipcUXKViCUw47W gbtY8lz6YmVbXh/YvKueGXF/b5v+rnbkld2qS317I73rSFx1G0qel1PgSwki2TqCFcAR QiP112DjdP8UK8M8fbUtJHHUagaeOmPblFazlQHAK8KoKCx5LeTeKRAu0JhUD3axnXe3 21ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hxN1MqMCHIhmzZ9AoU8rNrZpha2n+Y2YOgmBDYbVwYM=; b=AJDNPA73VFS74gLIDC7Fu0ka1r1SG5liT9kg5jDaqW9M4KZqGksLeXs2+M2iqsGT4I ee4qpDUWdXKUkL9ZYrpBR4Kmw/CzDFfCvtQ/WNyGLJA3XEZr9pH/sm8W3fCydEtR0VPc y1MluWbRzXH32aiLdZ5RN7/ZE2DqtXEAvcpizo2LdsLoyaAUAOnVYMS26fvwL29vWpBh L4++7XBuCkoaMH34r/Rn86HM6/PYQe7Pj3Roman+/Al0+NqMOvqH9ik9BwyQ/NnMbNaD 3U/DoHgUg2q7z/wX2mo7F5ofgqHKOjUZeGo5KIRWDg7oLLASLmVCxidZ4qWbiNasTcUD vW5A== X-Gm-Message-State: AOAM530oCldExmK/UZvNvHWlomPUBx2YkAC7coD9Ed3VVF+e8Rabqr0V BqTkcgHLGed7CmwDG7rx/DAErjbGQgg= X-Google-Smtp-Source: ABdhPJyD/5Z+1t/7EZjqPgbpEOZLW862MLDSVu5THxZ1EhEtQoeR8vW//Sf92zWIMaf/I3rpJUuJ+A== X-Received: by 2002:a17:903:22c4:b0:141:deda:a744 with SMTP id y4-20020a17090322c400b00141dedaa744mr3136709plg.25.1639460466663; Mon, 13 Dec 2021 21:41:06 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d9sm1086849pjs.2.2021.12.13.21.41.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Dec 2021 21:41:06 -0800 (PST) References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> From: Jim Porter Message-ID: <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> Date: Mon, 13 Dec 2021 21:41:06 -0800 MIME-Version: 1.0 In-Reply-To: <86fsqwmig7.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/13/2021 10:58 AM, Juri Linkov wrote: > I agree that using an extend-format separator is a good idea, > especially if we'll provide a special variable that will contain it. > But I don't understand why opt-in. I think opt-out would be better > since most of the time the users want to have de-duplicated menus. One benefit to this being opt-in would be that it would be possible to (eventually) support the de-duplication behavior for *all* menus without us having to worry about breaking compatibility for other menus[1]. If we provide a constant for people to use like in your earlier example[2], it would be still be reasonably simple to use. I think it would be nice to (again, eventually) support this for all menus, since it's probably useful in some other places, and it would keep the differences between specific menus' behaviors to a minimum. > Maybe better first to try fixing the problem using the separators? > When this doesn't help, only then we could consider alternatives. Ok, let's stick with deduplication then. I'll try to write a patch that doesn't require `top-separator', since that's easy for programmers to forget about (no other menu requires doing that to put items at the beginning). [1] It's not *likely* that people want consecutive separators in other menus, but I think it's good to be on the safe side and not break compatibility for anyone who does want that. [2] https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-12/msg01100.html From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Dec 2021 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16394723807960 (code B ref 52293); Tue, 14 Dec 2021 09:00:02 +0000 Received: (at 52293) by debbugs.gnu.org; 14 Dec 2021 08:59:40 +0000 Received: from localhost ([127.0.0.1]:57559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx3eu-00024K-8D for submit@debbugs.gnu.org; Tue, 14 Dec 2021 03:59:40 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:32843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx3er-000245-Iy for 52293@debbugs.gnu.org; Tue, 14 Dec 2021 03:59:38 -0500 Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 5DD221C000B; Tue, 14 Dec 2021 08:59:29 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> Date: Tue, 14 Dec 2021 10:30:10 +0200 In-Reply-To: <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> (Jim Porter's message of "Mon, 13 Dec 2021 21:41:06 -0800") Message-ID: <86mtl3629t.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> I agree that using an extend-format separator is a good idea, >> especially if we'll provide a special variable that will contain it. >> But I don't understand why opt-in. I think opt-out would be better >> since most of the time the users want to have de-duplicated menus. > > One benefit to this being opt-in would be that it would be possible to > (eventually) support the de-duplication behavior for *all* menus without us > having to worry about breaking compatibility for other menus[1]. If we > provide a constant for people to use like in your earlier example[2], it > would be still be reasonably simple to use. > > I think it would be nice to (again, eventually) support this for all menus, > since it's probably useful in some other places, and it would keep the > differences between specific menus' behaviors to a minimum. As Drew already noted, other menus have no such problem because they are static, and the authors can easily ensure that a single separator is used between submenus. But context menus are dynamically constructed, and it's easier for authors just to add a separator even for empty submenus, relying on post-processing that will de-duplicate them. So better to make this opt-out for context menus, and opt-in for other menus, although I think this feature is not needed for other menus. >> Maybe better first to try fixing the problem using the separators? >> When this doesn't help, only then we could consider alternatives. > > Ok, let's stick with deduplication then. I'll try to write a patch that > doesn't require `top-separator', since that's easy for programmers to > forget about (no other menu requires doing that to put items at the > beginning). Thanks. The current question was raised by Drew who worried that sometimes authors might want to leave two adjacent separators for an empty submenu. But you answered this question that it can be addressed by using a special form of a separator with a menu-item. So I see no more problems here. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Dec 2021 13:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: jporterbugs@gmail.com, 52293@debbugs.gnu.org Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16394870927148 (code B ref 52293); Tue, 14 Dec 2021 13:05:02 +0000 Received: (at 52293) by debbugs.gnu.org; 14 Dec 2021 13:04:52 +0000 Received: from localhost ([127.0.0.1]:57803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx7UC-0001rD-CM for submit@debbugs.gnu.org; Tue, 14 Dec 2021 08:04:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx7UB-0001r2-4C for 52293@debbugs.gnu.org; Tue, 14 Dec 2021 08:04:51 -0500 Received: from [2001:470:142:3::e] (port=37320 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mx7U5-0008Bj-1z; Tue, 14 Dec 2021 08:04:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j2b7Z7xHp7dxsGqyct8VpavoT7yvQSBRoNso1KKbn5U=; b=F+dfpZwp/fzl 9tnONtcdYyQCW5OYISx1oTQYwqF9UKx9qYFOXdrSDWhlv8v0VnIObhfjBvTmBEDY8Aa0+3k9cHr6K +1pEvVYRP1pEU6Q+qTwu+CF8lFPnE6eG7v3wxsvs+0U3XbJ1ECjHC51YrQQPFmScBuw7tmpOxI/wV p6lE2QT7d/VB/jzKWWKrTWU25jQXOTIVoFUSxjOEKUXEHeXoWMsf6Me+zM1urW5dXaCNaJVT+iv7X irzMELyOR4Wfl2w5CjsP4XLukKLrLXpqIOq6X2l5i+AFBYUVEvE9QGDEt4tzCNKgesdXPM4XTLwo2 GLAf1r0HaiNt/1W8eDzLpw==; Received: from [87.69.77.57] (port=4048 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mx7U0-0000NF-QB; Tue, 14 Dec 2021 08:04:42 -0500 Date: Tue, 14 Dec 2021 15:04:37 +0200 Message-Id: <83ilvrl4m2.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86mtl3629t.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 14 Dec 2021 10:30:10 +0200) References: <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Tue, 14 Dec 2021 10:30:10 +0200 > Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> > > As Drew already noted, other menus have no such problem because > they are static, and the authors can easily ensure that a single > separator is used between submenus. No, other menus aren't static, because Emacs adds and removes items to some menus as we see fit. So I think this distinction is artificial and incorrect. It is true that context menus are "more dynamic", so to say, but that's not a fundamental distinction. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Dec 2021 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Juri Linkov Cc: "jporterbugs@gmail.com" , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163950055929333 (code B ref 52293); Tue, 14 Dec 2021 16:50:02 +0000 Received: (at 52293) by debbugs.gnu.org; 14 Dec 2021 16:49:19 +0000 Received: from localhost ([127.0.0.1]:59398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxAzO-0007d3-K2 for submit@debbugs.gnu.org; Tue, 14 Dec 2021 11:49:18 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:35322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxAzM-0007cv-Pz for 52293@debbugs.gnu.org; Tue, 14 Dec 2021 11:49:17 -0500 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BEGYBxf017326; Tue, 14 Dec 2021 16:49:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=UJPC7JXqz4aI8bLBXwJxZSICAICS82dcwEkUJR6B+tc=; b=IVKdwehkGgKVoDJOjbOac+hGr23rEq2DBdgEztP6yw8lAEqJ7HwIUMM/hxPHB1JDeogl lWUI5ZfSes20tgX5pS77Dzc/ear7pgCeChtwrpBptb9XGIYeg1/S0VrRVhCHlsNQA7Wd cL5/Ko0LHXejaqrwWq96i6kO7eKjyI8KPNKs+H8hIgwMkKlBNHMnVEO1Y8fpQnJ5jYdO a9PpDdpBvpWRc0ijyFhweWhfbUeCdDTLqT8pqb5xUk6PObcGPlw6r8iqMJeIMcM9G04Z OEtzQ4J/XZRaa8+H7Gur6QYykcH2SV6qX5OYMvISNeMptdWq9ElQvwsgmQ/RF/fcZpbr yQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3cx3py4c77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Dec 2021 16:49:15 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BEGaTod188491; Tue, 14 Dec 2021 16:49:14 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by aserp3020.oracle.com with ESMTP id 3cxmrahw7p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Dec 2021 16:49:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=elqCafugnEfaSeK9lUnBZGzsJ1Am5h2nqXzCE0EOZA7WciwcXTh004te/WZl0ToQ+Ke5K8mh5hQRzJ3bG3bi28sGH4bg3c22zuEtBHmJKTNKvl8Ry+YvYpjyuf7iA5nx6FrbIYAkRzq+9sBiNuYUWKRXLCkLrKW2VGHN8ig8/6uZhoYLvq1bpGvH0+8/Tn/YuXr772qm8vTy3jezJrNaemW0wvZulV0LUWIlEuNlQbuvynNgvnMGeEFF9B5CZlQeS6eruyLssdPwVklXZA2HgLXrJi7fM1/NduAWS3cPtQ1dRlx+msJWAGMYDDwqfj4HNxXXS9+sLg/IoUwb4Cnf/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UJPC7JXqz4aI8bLBXwJxZSICAICS82dcwEkUJR6B+tc=; b=E0OaRjd4+iG2W40y92h3IFrpkfjQdav7kbFfjf3oBE4K4db7Jnn62eyK5g/e8LjgFeWB4u/uEBr3nf+sB9W4fzRShuVaWB8/dyRhfJ8Ia/Ljdk4+5G7h5FuS7cA/7pm0//qM5SDoIkgfDRgtMolindRlw3GCi0VDPKS3JgpYj8kxOWA2CoUDNIsfG9tX/0kELLrSuMv3jynBCwoxHczV6KULNDbzuSM3pV/5k7johbN6bRjMLWyFx7i3FjIGAr/poHwWgeV7yCcYEs/JVzFpSoEm75NXupv0KewhI66mBD0SugfdZHNlh06cIPOm9uiy2hJSBzky1keZC4CxMjSOig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UJPC7JXqz4aI8bLBXwJxZSICAICS82dcwEkUJR6B+tc=; b=rgf2F47DsebxrFGN1HGGgMWnBuW/PxmucHVW39Q+yndzkzcKhd8zgL/foVLEbWNupH9dZFKzLJqYP88Vk4X7QDbH5O6s3WDaOyb82TzN4hd7GxmpfzLF1vwefbuudr7zoO2gLjg/nPJmOdZvy1s0Ai2V5J8LttnWKm5cv1by820= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB2694.namprd10.prod.outlook.com (2603:10b6:a02:b2::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 14 Dec 2021 16:49:12 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%8]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021 16:49:12 +0000 From: Drew Adams Thread-Topic: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Thread-Index: AQHX8OvZyrH6lKtc5kOnXVtxAGV+uKwyMBQg Date: Tue, 14 Dec 2021 16:49:12 +0000 Message-ID: References: <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> In-Reply-To: <83ilvrl4m2.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60047b77-f282-4fb8-d96e-08d9bf21a82d x-ms-traffictypediagnostic: BYAPR10MB2694:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oUDFQOtTpnmow1lYX2iOzyUDYZtAwRMLECbjuhdc0hJzjl8wZjKt+ii2XrAklf3uhGRhDvfsEl4Y9N0Y9cSPhEELIt5dRs/RCAk+w9Iiycy6260QI2JlENhQwRUsmEoCMj9MDsf8fgDTZ7RzdQHxB3XimZ79//a9qOlXEseOva0f5x14GhzQYuDnaRh+Gk12J3gDVCrY30UPZoG8ZQKOvgU4zI+8Ly5QGRGGF2J/JNLPecvJTZtefWZoNf53FV1d8l6RVprstFi3Xa8v9Z+b8xacm2M+v4GKZiEjwYsDfb/nYmxM502wGM/LEYe75DpIL+8yIO1dlRxos+kLAquoXdFwg2ZN41lF4l+7MPI2nd2sTYaX8wINXWxQ/YRpWJXT2jIXDfbEgHyXHl96trk9ZeFyKt4lXA9tHTvXt2VCqIMkthY0N7VBNRacIN8nvRoUDu4OsCgUIxwcKYJS29Kovt+qu/4Jjci/6CBauFZ6afQ6UOI3zoRUIZAljeAiHmBMYDi38velsrtDrn194g8/QZ+9uF51SO2n+t7Wi7RVph0MHi15y1/8h/nyk71jjM2Nlprt5DkiZmaQBa0mn08k4QSkUKsBI1E3ekms+ipqBiUGKCJ3/yPG8aWRJU0edDCws+Qm01a55AHrR2AlqJGf7jknJuYxENzG0My1qvtp9sC5tip5ECoANNmgFw7QrG8VQpRb9FvqOCwqcLV/i2iQiQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(76116006)(26005)(33656002)(55016003)(9686003)(71200400001)(66946007)(54906003)(66556008)(110136005)(4326008)(66446008)(86362001)(66476007)(2906002)(52536014)(186003)(8676002)(316002)(83380400001)(64756008)(7696005)(38070700005)(8936002)(6506007)(122000001)(44832011)(38100700002)(508600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: DLd2zvJeb+fR4MC9sEEe7uGe1PtFdYBzu87fdlXJO1Vtii9aAtdVe2gqyZn/PqsDfkYrbyQt1/utI0ilyujgW47zp+QCUY+PZzdI4GfdUC7s2G89QA/f+LhVj5Lrfsyq2IxOOXX/wS4ZQcqjp7s5sQjaF9cDSRvsoHASBonCXmayPkCj3YVMQI2wsF5RxQFTuRVqumN3QLPEAfkL14xPJKkE3nxRjxWRvH7YA/Y+x4KHZLfIrSJ5OSvAjRLW36L1T4B8HZPIh912Q5RrQt39qlLTQWCj7+gIXo9p0SKBwux5QojM4eNfBXwHc7Q4tqDj0s3i6UrAwEYFIUxajCC+7YPXuF8GoJkc5N/Cjuz7s8mC4ih4qhpysbOO3s1A7IS5I2XRYx5oOUwMI6Gpq3O5HAnIcfyKByiOgOyIr1ZB1mB+GV3taUU0tApv0fuZr+mvAXYxIB1OeDsVjGB6h9zSqyl86uird4yAubPutEH5YMofl51SrakT7rJMhjkfO4JksR1T5Y7hSgwFpnO+a4BFFD0On/dP6qV9jM5YEpz1tv0dNrjidvkO1hFUVeyqhybwfVGCuukof68MdRZeYRVC822fef+pjClxIMC5RC3n9/kxTFxbYdK9pE+w2ie5GkArP3BdznaYc662nC+ZeKMPq7cUHLjPgH/p9c7rHA5MkuH998dCrJQ6/CaJ8/A5r1mg4cyAlZfao01UFmaG+4VYVdZ35RFLudqO+tOL6QhOhjvurGnOuXdScJXk5Oklt7Xz4w2BlbfmKAWJJ/1yxLSF8QREKgKlGjuxmutf0NFIL+POxEnLKYi6SkIpac18PXdNAQi2cIOHcejFWO8GLboQOFCs1fxMtYZDv6OVPy2xiFFMuK0ZFkMo5jr4M3+hOO50n986GPtMCofbXBBPW7mKJa7lPWz1zobDVy597Hxzx1R0XAyyax1ht2PFjeDDbSIrV9ISyYJGwgNsCxpKROebOFaKymSGnqwT+wbLysgLISLA8keMjX96EChWUZQI/SFbTGzG8ivZ5IN9t9S6EVAo3Do5mjqgQwukGdzz+g9uIe3ynfptMp7nPb71QU0CYIiVwxuZi7OUfzccMhNQFArXargrodxzW+Gzzdm9v1Ct2TYwDxCnUxVAW9jxuC8ZLN+O5d4Y7Nnx4oXFgcSRRslepErMW+EbsGGfICpfuBmZxd5seT929LTg3Z3wHrTyrZ3qZXn+MD+5CEPOhk02l90SkpCsW4cGd73/8EE+Avwd6VhrP/P2An7+yatXQ4yF7znDVH5/ltfXjntZL5xnuNv4siKov4eiUtUQC8ns62/xnPm3r530EV0xIgy4pu4mY/pcpprUTWsa5oOly/hNTbr43vfXYUo+W3Vp7fmcQc04foInivnn6eATD8a3AJjrJP0KLAt5Q7Da4B3r/CzzLhWoQpSRyJvXQvK+A4gHW/qx7Zsmycci9u9ewa77YDdYDjIgl5bFQw44NRr7FNpkHZbuVbIwEm/P0p+WuvfucaSW3yMzdF6uHLhlhdKCUJmGhxLap2TfbBE4Zkrg7XY6aF/slr0qhnHloJbMc51u6O8luxdUrkjx+Gie3WSv9iu8cj1OI2ANzXT+s6MojbNVSzVx5g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60047b77-f282-4fb8-d96e-08d9bf21a82d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 16:49:12.5101 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sh6HTKj7Ygfv4J4uDLKImi2lpzTCewUTliwx3snGNFbb11Ls4vf5kjHX1rJRbDCmY0ON9tI7SnnOPFSNJGkSSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2694 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10198 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=598 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112140092 X-Proofpoint-ORIG-GUID: eZkoItpFquoKHSXNav0I4woaXlMOS4tv X-Proofpoint-GUID: eZkoItpFquoKHSXNav0I4woaXlMOS4tv X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > As Drew already noted, other menus have no such problem because > > they are static, and the authors can easily ensure that a single > > separator is used between submenus. >=20 > No, other menus aren't static, because Emacs adds and removes items to > some menus as we see fit. So I think this distinction is artificial > and incorrect. It is true that context menus are "more dynamic", so > to say, but that's not a fundamental distinction. To be clear, I never said that other menus are static. I said only that someone (for whatever reasons) might want to provide or allow consecutive separators, and that that should be possible. That's all. And I said that programmers can anyway make separators, like other menu items, conditional (e.g. invisible). And wrt Juri's context menus, I said I really don't care much what you do wrt separators. I've elsewhere expressed my displeasure in seeing context menus implemented in the way Emacs is doing that, but that was ignored. (I use my own approach to providing mouse-3 context menus, which allows the standard, longstanding Emacs mouse-3 behavior at the same time.) My posts in this thread were only a concern that automatic separator deletion be limited to context menus. It was confirmed that they are, which is good. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Dec 2021 21:11:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: "jporterbugs@gmail.com" , Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163951625530427 (code B ref 52293); Tue, 14 Dec 2021 21:11:03 +0000 Received: (at 52293) by debbugs.gnu.org; 14 Dec 2021 21:10:55 +0000 Received: from localhost ([127.0.0.1]:59760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxF4Z-0007uh-9F for submit@debbugs.gnu.org; Tue, 14 Dec 2021 16:10:55 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:57183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxF4Y-0007uS-8U for 52293@debbugs.gnu.org; Tue, 14 Dec 2021 16:10:54 -0500 Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C63311BF20F; Tue, 14 Dec 2021 21:10:46 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> Date: Tue, 14 Dec 2021 22:51:29 +0200 In-Reply-To: (Drew Adams's message of "Tue, 14 Dec 2021 16:49:12 +0000") Message-ID: <86y24mucz2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I said only that someone (for whatever reasons) might > want to provide or allow consecutive separators, and > that that should be possible. That's all. And I > said that programmers can anyway make separators, > like other menu items, conditional (e.g. invisible). I was referring to your following words: Why should we even provide such removal? If someone doesn't want it they won't code it. That's all. But the problem is that it's not easy not to add separators that become duplicated when no menu items are added to submenus. > I've elsewhere expressed my displeasure in seeing > context menus implemented in the way Emacs is doing > that, but that was ignored. (I use my own approach > to providing mouse-3 context menus, which allows the > standard, longstanding Emacs mouse-3 behavior at the > same time.) Interesting. Could you please describe your approach. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Dec 2021 22:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "jporterbugs@gmail.com" , Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16395193762972 (code B ref 52293); Tue, 14 Dec 2021 22:03:01 +0000 Received: (at 52293) by debbugs.gnu.org; 14 Dec 2021 22:02:56 +0000 Received: from localhost ([127.0.0.1]:59833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxFst-0000lr-Ex for submit@debbugs.gnu.org; Tue, 14 Dec 2021 17:02:55 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:61138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxFsr-0000lj-I7 for 52293@debbugs.gnu.org; Tue, 14 Dec 2021 17:02:54 -0500 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BEJIbuw025841; Tue, 14 Dec 2021 22:02:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=xR80bOrOV3w5sAVJIdp5htAhy1rP75WVN/8I3gtma3k=; b=eNiNhmaynWBu+o2yB5OL8owp4SNbxjv/yVUeQ0vF3VplbdT+gWNws0YYamT5TGyMrFue P2qLVqIQtm2QiotyGFDZxa81KS+qDkeZA2Q5kiXaIRVwaa8XtS4Jp96zalqMAYBkRnbn OBcu0zdJaCHLSK/iIBswkxziOD8buBwMd0kps1CEWbTIRf+bqBtoW0kPG6VzsWHyXL2J VYFD6z0V55y5z88pJMARMknvaaguLnQmZ7++sV0J3haPMazBQnp5gQhTftrulIaZr/2+ Zcd6j1QA7nXEHc51wupR9cC7w9IGj2+nsbr3aMuiIYIcuUryQOzuk/BO96j8BLu80hbp Gg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3cx5akcx6h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Dec 2021 22:02:52 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BELxwIL171137; Tue, 14 Dec 2021 22:02:51 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2101.outbound.protection.outlook.com [104.47.55.101]) by userp3030.oracle.com with ESMTP id 3cvh3y3qu2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Dec 2021 22:02:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KXtvtExiPVJypQvI0XiRp1pcBX3wEDDA0nwrizVPRypjkqIJ/WAOC7WtFifPfplkbzYHEslkKRX/LZb7u1TULrNdA3svRshPaWrqvWunCByNK79pBeal01/c03jWASuomgPGzoBeCqfxz/6cLzr8c9MNd+UA5+y0oCamyBFlr+5aCLdBS1/vXHvReKWgy/4hbE7x1rLbmgQLOR9M6mk6ZvPBnnO0nn5j/GlSg6Yb2kRnDOTm9XrU9pwLDheZ9hsHjwzBGO5AVUlKvjyVv2v8BzfxY1rpqWOKzFEuEKOAKTP3VXjqjCabLVJmooPlKDz9aneyMFSkG7b5ZEd+Lu0pEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xR80bOrOV3w5sAVJIdp5htAhy1rP75WVN/8I3gtma3k=; b=Jb6Pl2Xmhsbqocd58GTsSPp/uaGAm+6Lb++5nOK8Eu+Z6ftd3II6NTtDYrkX1GUBWXCsvhFAd61XNfYNv5KNNdpaJHI/Pf8E0dbPncyfSiUTk5P+GurLBfKf8XQd359sjkM2U2g5PNckAH1RrIRW7qa6nC6R5M0Tb5cm1II6l4YE4IDiyd821RQrKnlROrCv20wIU486PimAUYqzmlI5DPDc+CQ2W9mgI4rdrBNw3d4u9BvGd4qxzLAkFusBWaG7bu7M19j1hCRExDvNb6Jk1x9vAaW7WmV/9s2IUK5ruIEqkaSNCJkpTOlGt7fYu0F26TpbCh3afic1JyYdT7VGhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xR80bOrOV3w5sAVJIdp5htAhy1rP75WVN/8I3gtma3k=; b=exTBLVEsPsb8w4p6QxMGS2aqLAofcqW36DNaEj+eTT5bE4VAmJWKow0Tt6MNw9a4OckvbOVV73JoMhqVtE8V3UmhkrstiJp0ufqeg6cTl0FisZG0oNgnOtrnzZhuLgmJEVUqcccUUIICbB442U8T/CcFv47wGT5ntwL0pxr47Ks= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB2439.namprd10.prod.outlook.com (2603:10b6:a02:ba::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Tue, 14 Dec 2021 22:02:25 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%8]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021 22:02:25 +0000 From: Drew Adams Thread-Topic: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Thread-Index: AQHX8S8XshVVR6OKwU2RFKpQQXfdz6wyfzBA Date: Tue, 14 Dec 2021 22:02:25 +0000 Message-ID: References: <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> <86y24mucz2.fsf@mail.linkov.net> In-Reply-To: <86y24mucz2.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10da386c-b94d-49c1-0027-08d9bf4d69d2 x-ms-traffictypediagnostic: BYAPR10MB2439:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3t3fAWH4rsT2rBUYRQeLUD8W62Q48nS4xDwRVhgE+2zijT0rdvigowRsmgV50CU53mFME6RoICjFAyDXB94kNfsLfJC0Z3HtWDFPSauHSr59Y0bcaoxl1esWK6nXKxnyfaDD/pT1FEwuqBTXPdenN7ag5cl7OjT/CfIbH0LuDDVUNsj3+qzdpNfgLuylCdUZFcGdDKeQbdQNe301qup8dPgfjGm31zePzQPMka6TRr/OXq4JfAZsiMpGS6Gh+OEU1KhwqU0rzlldZb1Xgg7+jUIT+5iXzfr5XqWy1K5CbZTbB07Pnce8OAhVgzQbhpRxUmklIo7u9QCMAKb88I7V2XAlGlsIurc+I+AfQwfmfVZt0PYNoKtqkc8Eixwd4SH2YFF30+KpK0r74elF7uiFdD+m6cMOO+pTakVBu4NIGvxYzMv9U6E/jqT7a8SnpO4Xv6lnmkocPzB3t8ITV8ODh4MFWs/Z4XOc5VdotDhknOlVJOxwwndoUBDEK4H6USvoH+dmDPUNwBFFCD20027MoC/LueEsQXbquLZJp59SmQbdzw6DwXU7PPYXgJrgOtVYaezZ7zfMAFpNmwe/+I+0r1ZH0S3HG8qv8LUAL4Y2nRRJglZ9Dj035Fc+FX9ZsmnIHRp1TBL/A+B66ayHhdx3fLKWBU0KU3pmz87X0dK3dWeVOHN7C1JSVr3hbumQrylECrIUB4xgQ93xsV+n+T7/6yMqc+bTQI3r6CTejlQ1c2awG2IAtapp5iBZtdreXDGsAFBhcA3qUgDrgxLsUWh8XC7JjgFrE0zRx+emDlxoM6k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(55016003)(9686003)(33656002)(8676002)(38070700005)(508600001)(8936002)(122000001)(38100700002)(966005)(5660300002)(4326008)(186003)(316002)(71200400001)(83380400001)(66946007)(66476007)(76116006)(64756008)(66556008)(66446008)(26005)(86362001)(44832011)(7696005)(52536014)(6916009)(54906003)(2906002)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: sFiHNbYu1PeNJTAkVMi0KRAkELfyDAGhxjt3p/QkBRyHfoLHYkhCeI969cxQ0tOSa/aYbTkoqodfmurLxh9YXkJtAh3EKK804e77hJcXNhJ+qBgrz+1rljJKnJXh19nzjHMY5HHv7tAq7iWsi5gpEwExzpdsfiHNnBOzg8FfdCDK2m1znfu9YpAlEp9XK5dW/do857iQ5pkzXNjG4otp55Phjz737iRLG1iZ30+pFjxjnRJfY6NVrfqZIO62IzX21bXeZfa/KXM0M4jGZCKjCwFCefMxZZH40SRsxQp6hED0M7F5fmvAKTBtKXcl4FuULmv4XnkfSVVT6wpNvu/u+HbkNxj86ojDO5GkK4KrAhC4wNceFQ+EnkX8klFsXa3s98t8zo0U2qt3RTF1cqb4dwszSzfMlLoPLv50eVc7gnX94FcyZcTu69h9fxJ1lQY5th1BnWtzaZ6vs0a5i7DtdI0HOkAWrvSPO+MVJuyGZegtogDEQKtFb6Y1gPMmydU0ie+twQHJPdZdsaGU3eMjp7uVj9zFrgkFazP1eX4l8w4k7ZlRpZDIeYaHlDFP9pCGGV9SOHI/aq2vx4y1ZEcRqzvo+op+POUcP1aBrbSPwVIP8ET/JIF2TOB34//+40jUd7QBqygOPtKoTUsfMS7sPE5PoMVw21ZWxzayPPtPtVaDlNAmKY+W/Xnj2FC3AqXU0RZtUl0zpeI0zWnDV5eN/y+721shEK77G0PPxhTgg16C7yowRmErEthhwBTcUkixoWxj5Z5cAX0Vb2q6wJOsOcHZJrZ05dA6T//xzTk5oB+h7ztxIxgXPGo5QqlPiqGYOddRQuORoUBcj/2PJkIN/lkLcBY4sUxSkKXEqQIJdUqd+7Caw2jlDDIuz52Lqr61NWEzP2sGJyK75RWyAGsyywTXEgakhz4pZxsYj1sg++6X9AJSz56v9jb4LlDbgcqDrXaXF5b/Ca2KJp4tTbJRX8v+5FH9WgeQRSoo7Epg2S1oTChZF8+Q1hSAqRBGyu8FK8/v9jm5zkv8bc5J2XaR9kkBhUcIJ9IdzuuFldRehWYBo7T3F0A8tzxF7qllTSxT9TWuvYOgXpuRVe2JoUJ3ZbePqpRrw1Zi9FFNP5fYO9DscEUxHAI9QRSzSongO0qrAXc6lzyaJMRwAA1ZF0IFdwIyz4R082KQUsrL3mykU4QoV4O8gYdhFiSV4E+q+Hmg09Eq5yzqA4eIXomLBECrKvh8ROb8Lm0QEzbQcPZwmeMPCl7PP61nA83WRt/qTUJrJh46qnj9VW1HWog8D6x72uUwIexuXVabx0WfNSVovrgJdLHaTZ17JAppNE7SwrQ3V4f+hg+Lz+1I/6fjNze2O6pAaCl/ai9hbzKPQ6TpE+bXtx0btkdeZ6JCN0QK6x65cBKLj3V6dwbzXt0DVCSTDdyngtrNLEFmIMIkJiqF1fjtM9o8qb+OE7OTsIBZyOkDixvybuW7usAs1hMkuPEAOIldsSP5RsBJRYTiFP7OjCeo5RK2j7FJqfjE6ADNuppWCAvmtWo8NzMGPSq1Zn5kIpM5RIrqh3kDo6uY0zjs/qOHY73c3u8JmRcUFWNDGITh6+3opmmsl9WUgN3+bg+lEg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10da386c-b94d-49c1-0027-08d9bf4d69d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 22:02:25.7612 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dbhqn4B3guWeZEcGS//liicZbEUvH5WCt8guQjhS4uTzKh/kv4GCxZqg01ObZVB8Q2ycC15Asey78WEZ2SazYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2439 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10198 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112140116 X-Proofpoint-GUID: Y6vVhf2AEd2Uu0LCAQGyVyDNr3P628zU X-Proofpoint-ORIG-GUID: Y6vVhf2AEd2Uu0LCAQGyVyDNr3P628zU X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > I said only that someone (for whatever reasons) might > > want to provide or allow consecutive separators, and > > that that should be possible. That's all. And I > > said that programmers can anyway make separators, > > like other menu items, conditional (e.g. invisible). >=20 > I was referring to your following words: >=20 > Why should we even provide such removal? If > someone doesn't want it they won't code it. > That's all. >=20 > But the problem is that it's not easy not to add separators that > become duplicated when no menu items are added to submenus. Please read the rest of what I wrote. I specifically pointed out that some conditional menu items might not appear, resulting in consecutive separators. And that such a possibility might, or might not, be what someone wants. And I mentioned the possibility of making separators themselves conditional. You can programmatically control what happens dynamically. Of course, if you're only trying to insert some item into an existing menu, then do more than just insert the item. At the limit, you might even need to reprogram the menu, or at least some part of it beyond that new item. And I specifically mentioned the problem of having two separators end up being consecutive because of a dynamic situation - even just conditional insertion or removal of some items. I was the first one (maybe the only one?) to have mentioned that possibility. There are multiple ways in which a menu, including its separators, can be "dynamic". I'm well aware of that, as I think you know. =20 > > I've elsewhere expressed my displeasure in seeing > > context menus implemented in the way Emacs is doing > > that, but that was ignored. (I use my own approach > > to providing mouse-3 context menus, which allows the > > standard, longstanding Emacs mouse-3 behavior at the > > same time.) >=20 > Interesting. Could you please describe your approach. I already did, including in the thread where your context-menu was proposed. I've described it more than once. If you're truly interested and haven't paid any mind to it before, you can find a description here: https://www.emacswiki.org/emacs/Mouse3 And you can find the code here: https://www.emacswiki.org/emacs/download/mouse3.el In general, I'm in favor of: 1. Combining these two advantages: . Allowing for a `mouse-3' context menu . Emacs's longstanding `mouse-3' actions Users shouldn't have to sacrifice one to have the other. 2. Letting users easily configure such menus, for whatever contexts they want. 3. Letting user code do the same (e.g., dynamic control). `mouse3.el' is a simple start, but it already goes a long way toward all of that. My impression, from the discussion about your context-menu approach, is that it's much less open to user and programmatic control, and it doesn't enable the traditional `mouse-3' behavior at the same time. The traditional `mouse-3' behavior (including deleting) is a strong plus, IMHO. Many Emacs users, even those who use a mouse heavily, might not even be aware of it, which is too bad, IMO. I wonder how many are even aware of multiclicking `mouse-1'. Again, too bad, if they're not. Instead of throwing the traditional Emacs `mouse-3' under the bus, we should be running it up the flag pole and shining a light on it. That your new context-menu feature has the effect of throwing Emacs's traditional `mouse-3' under the bus is just a guess of mine. Mille excuses, if you do in fact allow both the traditional behavior and a context menu at the same time. Don't ask me to prove that your approach hard-codes things in such a way. That was my impression when reading your descriptions and the arguments for the approach. I don't claim to be an expert on what resulted. As an eternal optimist, I can hope that it isn't as closed, narrow, and predefined as what my impression of it suggests. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 00:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163952746823477 (code B ref 52293); Wed, 15 Dec 2021 00:18:02 +0000 Received: (at 52293) by debbugs.gnu.org; 15 Dec 2021 00:17:48 +0000 Received: from localhost ([127.0.0.1]:59872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxHzQ-00066a-93 for submit@debbugs.gnu.org; Tue, 14 Dec 2021 19:17:48 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:50882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxHzO-00066O-US for 52293@debbugs.gnu.org; Tue, 14 Dec 2021 19:17:47 -0500 Received: by mail-pj1-f52.google.com with SMTP id gj24so1850938pjb.0 for <52293@debbugs.gnu.org>; Tue, 14 Dec 2021 16:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=LqQxRkmbvbybKq6F5Y0iK0KvP8Tos1K0p72VgQv/4vo=; b=E+cES5ftS19KQqRQPnI7ooWLbYRcjVZEAeg4NgLjsv4xZL4xLVxydY3KKXvYiBshE1 qlwooYgV0yem2cBw8jkTOOSRT5Ft0MOZU6W8dARZZh5tMt5ODK8QaY+uMvnB8fefjGTk ud9a/hSz8Su6cumMR8SQpIdi/b8vdMabrgo/qdI6WDSA/JRRMDOINcAChGcG1upbPuXQ ocIrhLqO+lNI1ct8Eqpmc2xbrmOjjx3GU1F2CojUKw8Yu1fkWGKvD+biCZMUiHIW+aMC UN2aoAdu2wv04A2zpd87scmDbMwva4o4aEQz52XaDh6W4smyRmgoF+punoKRM3xN+GPR 7lFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LqQxRkmbvbybKq6F5Y0iK0KvP8Tos1K0p72VgQv/4vo=; b=NrfIPkJazu97bz8Izdz42/xwTV6k5GX1AGC/yprFf5fHhpAJRqavP9ZcgrQKToRybs mWHc1vNUC0yjoZ4RenvsxULixk4TBmSL+PUVvGu+hFHHwDkMPbX4amj+tChvlsj4CR36 Ms+DLOd2cnywermzyeLzoXKjF6DE+UfaR8p80geVxozsZ6J7RJn4b8OUJRTOhwd+ncTe 7yjqeSoREdZ9K0Wtzr+27FcuGp9U+c+Ii0B82K1KPdbwTwMLnE6CMq8ko27dbGNqJGOy RDEkGEHfTjtA7GbubXHXZlI7Loe7LxrQEUITXpIHyiYgus2tIhsWctlZlgk4sDKoKpRa +DTw== X-Gm-Message-State: AOAM53381XGQbFpqeuaUzxVndSlTH2tbCt23lnlMS5MaMxEF+dwreajW HJVffpiIdvzBtTk3Hf+FTdjUElkeSyI= X-Google-Smtp-Source: ABdhPJz/m9ka37DjgqOyNf1/RYHFb+Axy8Zf/cCaVdBMNJVRLcNDxs/7JVIY2wgNcMG+HlGhAqInbw== X-Received: by 2002:a17:90b:2251:: with SMTP id hk17mr8849232pjb.31.1639527461171; Tue, 14 Dec 2021 16:17:41 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id e7sm223855pfv.156.2021.12.14.16.17.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Dec 2021 16:17:40 -0800 (PST) References: <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> From: Jim Porter Message-ID: <723c8965-31be-b636-beee-478fb77423ec@gmail.com> Date: Tue, 14 Dec 2021 16:17:39 -0800 MIME-Version: 1.0 In-Reply-To: <86mtl3629t.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/14/2021 12:30 AM, Juri Linkov wrote: > Thanks. The current question was raised by Drew who worried that > sometimes authors might want to leave two adjacent separators > for an empty submenu. But you answered this question that it can be > addressed by using a special form of a separator with a menu-item. > So I see no more problems here. For simplicity, I'll focus on *just* the issue described in the original post to this bug (i.e. improving how we detect consecutive separators so we can de-duplicate them more reliably). Then I'll send a message to emacs-devel to gauge interest in supporting de-duplication in other menus. If there's interest, it would probably make sense to have the de-duplication be opt-in so that we avoid any surprising behavior in other menus. However, if people don't think de-duplication of separators would be useful in other menus, then we can just keep the logic we have now (along with the bug fix mentioned above). Does that sound reasonable? From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 09:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163955925126649 (code B ref 52293); Wed, 15 Dec 2021 09:08:02 +0000 Received: (at 52293) by debbugs.gnu.org; 15 Dec 2021 09:07:31 +0000 Received: from localhost ([127.0.0.1]:60214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxQG2-0006vl-Rm for submit@debbugs.gnu.org; Wed, 15 Dec 2021 04:07:31 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:40683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxQG1-0006vR-KX for 52293@debbugs.gnu.org; Wed, 15 Dec 2021 04:07:29 -0500 Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id BC4D6E0018; Wed, 15 Dec 2021 09:07:22 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <723c8965-31be-b636-beee-478fb77423ec@gmail.com> Date: Wed, 15 Dec 2021 10:57:56 +0200 In-Reply-To: <723c8965-31be-b636-beee-478fb77423ec@gmail.com> (Jim Porter's message of "Tue, 14 Dec 2021 16:17:39 -0800") Message-ID: <86ee6egs8b.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Thanks. The current question was raised by Drew who worried that >> sometimes authors might want to leave two adjacent separators >> for an empty submenu. But you answered this question that it can be >> addressed by using a special form of a separator with a menu-item. >> So I see no more problems here. > > For simplicity, I'll focus on *just* the issue described in the original > post to this bug (i.e. improving how we detect consecutive separators so we > can de-duplicate them more reliably). Then I'll send a message to > emacs-devel to gauge interest in supporting de-duplication in other menus. > > If there's interest, it would probably make sense to have the > de-duplication be opt-in so that we avoid any surprising behavior in other > menus. However, if people don't think de-duplication of separators would be > useful in other menus, then we can just keep the logic we have now (along > with the bug fix mentioned above). > > Does that sound reasonable? I'm not sure if de-duplication is needed for other menus. Currently de-duplication is used only to simplify creation of context menus. But there is no indication that someone needed this for other menus. Otherwise, they would report duplicate separators in other menus as a bug. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 09:08:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: "jporterbugs@gmail.com" , Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163955925526667 (code B ref 52293); Wed, 15 Dec 2021 09:08:03 +0000 Received: (at 52293) by debbugs.gnu.org; 15 Dec 2021 09:07:35 +0000 Received: from localhost ([127.0.0.1]:60217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxQG7-0006w1-2k for submit@debbugs.gnu.org; Wed, 15 Dec 2021 04:07:35 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxQG3-0006vU-GE for 52293@debbugs.gnu.org; Wed, 15 Dec 2021 04:07:31 -0500 Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id CB0CBE001C; Wed, 15 Dec 2021 09:07:24 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> <86y24mucz2.fsf@mail.linkov.net> Date: Wed, 15 Dec 2021 10:59:04 +0200 In-Reply-To: (Drew Adams's message of "Tue, 14 Dec 2021 22:02:25 +0000") Message-ID: <864k7agrur.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Instead of throwing the traditional Emacs `mouse-3' > under the bus, we should be running it up the flag > pole and shining a light on it. I wonder how do you think it's possible to combine the traditional `mouse-3' that operates on the region, and `mouse-3' that pops up the context menu? From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "jporterbugs@gmail.com" , Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163959185219449 (code B ref 52293); Wed, 15 Dec 2021 18:11:02 +0000 Received: (at 52293) by debbugs.gnu.org; 15 Dec 2021 18:10:52 +0000 Received: from localhost ([127.0.0.1]:33653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxYjr-00053d-Um for submit@debbugs.gnu.org; Wed, 15 Dec 2021 13:10:52 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:39758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxYjp-00053V-Te for 52293@debbugs.gnu.org; Wed, 15 Dec 2021 13:10:50 -0500 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BFG8GTJ009116; Wed, 15 Dec 2021 18:10:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=fg6e0yi0REj8iYA55YdUfBjxL2I6cxf0sJhhZ5Q2sdk=; b=Hq0M+osS0ouncUE8dhPVcQai1o/Cd02SqBIR3OwFhfYe3Lv/YafbruLrxgg8xOOh0/tY pr0k468zfaPEX5l9pRYBgfRD5R62GYgGooImJGr/l62Xl3m1RKlWMX61tFhBgdEmoH+T P2USkPs/2F/X7G2dFrP3xraX/MjqMVABTD5LASdx5MH3v0iuoMBZ9oOIHWIcRNr19wDp 8i2bJ63lLBHHIgpEWrRiTRuoERfQyEonfIl7b6vpR0GcmXTuE/T7SDJB5npZeldN2r4x V+5irZ36lKAvdppCCjFENJTVNhr82LUwH0wraxU6pSCvlKTq1Fzi2b4IcLmRlwwWYq02 Rg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3cykmbgdaj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Dec 2021 18:10:49 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BFHu7BV051100; Wed, 15 Dec 2021 18:10:48 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2107.outbound.protection.outlook.com [104.47.70.107]) by aserp3030.oracle.com with ESMTP id 3cyju8q40j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Dec 2021 18:10:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n1pbg4lFUdsBcytYSCIrD6IxCUYGpQRgW6VzYZ408ZBfR2BC20mZQPkVSHhv5VgbD5fyZEyPI7vLwhMp7RvunOmbfmjhYABuV2kfNZeSkMMnNcdI453AsSUsyNjkQ/l09nW+UB33uIzhGexRSJstm3jGC/NwDNxOHU8Lf0TB3u/GIXIjHq/K1buqDXUSdWEFQbSRBTMNx31YoHgXsn/C/VrlbUNw7hMv5plim8nblBexUbvqQ42rn0Ku1+fZ/ATboT1CGv1dWAIAvwxmWFqQ5KVQfsldJIZYu0Cpy2wZ4JvoppUgSJqu068VVuGecdthf1fUf8KtBdKhLeJhBr4sCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fg6e0yi0REj8iYA55YdUfBjxL2I6cxf0sJhhZ5Q2sdk=; b=nQ4LKJ6n/vstVle3KcXheHHeTzjKfCjHtABTju+CVbbf7UCRoiSTVA9RdccKNYD8H4cRilOB6Quu2oUSxiE349/uGVwfCaOFFDDf5TMJWAVk8uAjQHmV5/XWggybxjR1hI4C8hC7F5erAe7QfSWHgQOu4jTiotrtWptVgpTnRlCcDqFmeG5do2W1Yx47BY3uReXKnRoQQ0vKSchZsFpW21aW0VJtf6ujiBUaV4nSncyE6Q9p3dyH798KmZCEqYt2cZLApBvtd0ygGB4SgcUCRsxbUPg17wS1ZNi11laOtnShPxvYPq3nY7zJtZXzyy9Z9fnu6uvWQ9wxDBbXilm9ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fg6e0yi0REj8iYA55YdUfBjxL2I6cxf0sJhhZ5Q2sdk=; b=P9ydl+Rbmu5rRheXWAq5JsdaPOeU4L8peek1eIgANAtS3MqKusnAlxx4ph7slPJ2Ai5yptpF/v5gqvPRmO/lafAxnNJp0XWajUeuRBW3TLEBZ9krL1C3/NJ4Gz9EL5r3u5zwljrHeI9wIe9iBB+FuCwPuYDq0hPPHv2iaYzmEG8= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by SJ0PR10MB4544.namprd10.prod.outlook.com (2603:10b6:a03:2ad::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Wed, 15 Dec 2021 18:10:45 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%8]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021 18:10:45 +0000 From: Drew Adams Thread-Topic: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Thread-Index: AQHX8ZMxLWhIsycs9kqBuGVclsbOKqwzx9Ow Date: Wed, 15 Dec 2021 18:10:45 +0000 Message-ID: References: <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> <86y24mucz2.fsf@mail.linkov.net> <864k7agrur.fsf@mail.linkov.net> In-Reply-To: <864k7agrur.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7e4b5953-2305-4de7-7d78-08d9bff63707 x-ms-traffictypediagnostic: SJ0PR10MB4544:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2L3sFinEiISlU0ypqHN8V7cYpqvhnffft5M+EOD+ZJ9NgGY/Va/cBtMpoeTrP8nxmECP04flkbJwRlJrfExt1xoXBkASQYHUN/eJ9C+LcH7g4Tn/nj2JeCjcANuIhb62dCbif5185CQmtdTQVcQGfuND01poVSjr+NbtU3iMn4VwSxVe7FuxLOtvec4AZe7sjxmkQINGjlUGKFO+/x5dwFjWkufEG03rngFUFHSPE/M9E/WG3A4g9Y29GveZt2TVT2M4m4WBnaF1iOOrzSD5HKNMj8j2GzoWXAhdGsQyOk9c2zn2lU8gGZnw4GOG3qw0Y0Z0XRX9vks5K92RyPFDzfVTKaV3PFt2WBQqCS8qnpBzYw0Y+x4C4kZVQAhAPJEhoelERtTe+P72APpnyXpncfcVyLjw4BcXMWJF86K/Twv2PAESopyyZfQszRKOQVT2bikz6wD9UWGuMMvEqhNn44/WiMYiNcTY3c6bpHingW6b1RocQzQBAf96he1SwNmWx57SWfA77LC7PLliXFgqnRNOltRYV8iWjmxJRpv0BkISO78z1awtMY8aHGE/GYc2o5LjCrA8GeYYHLWZhoN+sNWd+s2G+MQtJh9tBbl5UuKERDYH8gs1WMjFfGpsL1DtbchuIwcw+Q2GjkcAvsSipBdcdQo3cRILyWa9o6AeS8LKTURLgv7knWfUyD12YYX4Rn2YQ6FPvr7yj8J1R5YBEdzS1lk9wRBqwYMgo+55hGPLjU1FyKETklNqIiugvF/Y9ocHgZJj9hsAXe3yHUmDsfoP0gxXjDRMopgGY1vJbME= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66556008)(6506007)(8936002)(66946007)(55016003)(508600001)(76116006)(71200400001)(86362001)(44832011)(7696005)(6916009)(33656002)(316002)(83380400001)(38070700005)(122000001)(64756008)(38100700002)(2906002)(66476007)(186003)(66446008)(54906003)(966005)(8676002)(9686003)(5660300002)(26005)(52536014)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: F2PlJCRt2zf70T0iQYOmKfTq/+ulDrK8sk//uXi+NEIjX8Bao/KIo/TAtX0HpVyUbDXgfccBNxjGR5x8p/M2NhVasCEUlywxO8mTHydmRRzpnNiBl2rDjpCyjR7Bp017tZ40HQPduWTcAgHAKnniAPcmGjED4F7Uup316xjfw+IRPVyagioSiIkmtuc6KQNZ28Qikl2kj0AWbkXzRAL/5JVVoJKk4Nm6gypNfOv9ScnKeFA9ip1LUyYYM480RSh5GYfIVnaNgb2ZaNQCeqWJpDv8fE7vdChcbRnjtrCBgCcbHwrKre9MAIuYjrjd6uyrLshPoE+s0+ReWayWHQtLmR6T1L+D8Y7DyP6kmXvPLkHHE5GZ0INetr78ij13b1EfrcXfWnTu7baCTxfE0Bz+m6mIu2HGE+jm1qd77o3UM6GmhAZ3/yc6Ot0Hn+e16yrUS2bJdSXPUR0XmJFGmZb8g/Xu4xfagCotcTxHanqq+aVuqQH5mJ984jENZILE/KOXCGt8XH0ZSRdwHfZ1SFW7piLMlpvLweAz7VWCbZ/jsv2nh0JT6euIyG7Xqd1VFPL1zCiRSXtfRHWNTwzjDkr83x2wF9KfzmFPE0XNv6Bn2dWti30kU7k8z369A5TqGHGRzZQZSetT2b9suA2sIGqkxHZ1XPvL4BLNLQs4wGmsSe8RyZEw+Ev+HkY6yGQlCttLZ2mldBVv7wBGt7hBCW/VhdkpH6Z2BTUMU/ZRxB4591FTl0UM/oaEkFikDvGfSvfU6p8jm0PP9ZuQ/nahS9V0u/BL7IpfLE6BCUZPhJMYMSJQ+scRv5PKOpaSpvkoUihtuduDLjC4IPynQIU/HiPRfxwbT8PIcE22x3Cnk2hG7CAmjhU07AO9GrH8MReUAmIl+qERwLqrCPV3PA/+5wucQedyW7gdTBAuNku6RuIXzeOJS3B8ENwuhqFJCeLr9RVQWH5eJCzxVAbgiKQt0eENrj19Q3rmigD+zoqBzQ99y3FSzFLX+rA63gUrEAun7TKQHeHA7w4XhZPwRpm1Q96CnyOeSE8/wtvspeQnEQfPKgwhLhJQMYH01HAyMR9XBY4wyRIQHyWBlqt3JxDP+LipC1gG3Zrn4dB7e4JFnBDkpDfoPFhoRp86nbB3BnPiX6SAx3LPEYurd4qr9gMbXJ2kHfH/dn8/MuuY1PBkUxQf6xZ/LCSbvXiX83O0AGiPIprnGxyc8z2/C7kIzGmFLDH565FrOqeZ+E49taYeTIvfQYEkJcX1UKEQcarIzJKDwxjcizP+6EQ2rFOKn3jCoeELffBNeQmEaHzR4uh13sx4I6qu/Z4Y41vCw+Xw8rMvLDPAPczCrmNfKQWzUmJEOKk9RO3w/Vg87FQu9cnD3G43oqZzL/NozzSgLsFzqP3gearkgRRqBXTGgdXaqs3Mjy9hiTJPxn0cQ6wJrcts6A7QQQYFnlGoVOTn25na0wvVmTsG8udYjSlWzsMwCEyThBQyR9T/3MVBcPc5VN2rtGYURuwMvI7uz1ALbTJAyki0a/+5IbViQvoopgbuahA0F6/XcnjFwPmXMPu+cCnmGr8svdbpzjzmlafUPCJ0nP7X8l9s1MgxBTJQ0sp2utXMRTcUDQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e4b5953-2305-4de7-7d78-08d9bff63707 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 18:10:45.4627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uGhTqP2FJvS99tCV/hSwXLT+3RgenyfbCTnCHItjyMqcvN6xRxM3Ij44G0AzHDoLejp/Xps6+CsERaukPsPE+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4544 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10199 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112150101 X-Proofpoint-ORIG-GUID: txF5L80r_xJY1blZucvstiT9p9l04Z_d X-Proofpoint-GUID: txF5L80r_xJY1blZucvstiT9p9l04Z_d X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > Instead of throwing the traditional Emacs `mouse-3' > > under the bus, we should be running it up the flag > > pole and shining a light on it. >=20 > I wonder how do you think it's possible to combine > the traditional `mouse-3' that operates on the region, > and `mouse-3' that pops up the context menu? Why do you wonder? You asked that same question yesterday, and I answered it, in the same message you're quoting from. Is there some part of either the description or the code of `mouse3.el' that isn't clear in this regard? Did you follow those links? Do you have a specific question about how it works or behaves? Here are the links again. Description: https://www.emacswiki.org/emacs/Mouse3 Code: https://www.emacswiki.org/emacs/download/mouse3.el Anyway - from the description: Library `mouse3.el' lets you pop up such a menu by using only 'mouse-3' - no need to use the keyboard (hitting the 'Control' key). Yet you can still use 'mouse-3' to extend and delete the selection. How does it work? [read that section] That section tells you that "`mouse3.el' redefines standard command 'mouse-save-then-kill' in a trivial way to give you custom behavior for a second 'mouse-3' click at the same spot." Instead of a second single click always deleting, you can use it to access a context menu, to delete or perform any other actions. Doesn't that remove the standard second-click-deletes=20 behavior? No, because it distinguishes a `mouse-3' double-click (which performs the usual delete action) from a second single click (which shows a context menu - or in fact to do anything else you like). Vanilla Emacs doesn't distinguish these two ways to click `mouse-3' a second time, so it misses an opportunity to provide both a menu and the standard extend-or-delete-region behavior. The redefined `mouse-save-then-kill' command just uses=20 function `mouse3-second-click-command' to handle a second click at the same spot. That function returns the command that `mouse-save-then-kill' invokes: either the command that is the value of variable `mouse3-save-then-kill-command' or, if that is `nil' the command that is the value of user option `mouse3-second-click-default-command'. The default value of that user option is command `mouse3-popup-menu', which pops up a `Region' menu, which generally has items that act on the region. ___ To obtain the vanilla Emacs behavior, customize that option value to command `mouse3-kill/delete-region'. To _always_ have `mouse-3' pop up a context menu, set option `mouse3-menu-always-flag' to non-`nil', or bind `mouse-3' to `mouse3-action-wo-save-then-kill'. IOW, both vanilla Emacs's hard-coded behavior and an always-use-context-menu behavior are trivial subsets of what `mouse3.el' offer. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 18:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: "jporterbugs@gmail.com" , Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163959273620859 (code B ref 52293); Wed, 15 Dec 2021 18:26:01 +0000 Received: (at 52293) by debbugs.gnu.org; 15 Dec 2021 18:25:36 +0000 Received: from localhost ([127.0.0.1]:33683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxYy8-0005QN-8G for submit@debbugs.gnu.org; Wed, 15 Dec 2021 13:25:36 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:40653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxYy7-0005QB-Be for 52293@debbugs.gnu.org; Wed, 15 Dec 2021 13:25:35 -0500 Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id AEFC71C0006; Wed, 15 Dec 2021 18:25:27 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> <86y24mucz2.fsf@mail.linkov.net> <864k7agrur.fsf@mail.linkov.net> Date: Wed, 15 Dec 2021 20:24:04 +0200 In-Reply-To: (Drew Adams's message of "Wed, 15 Dec 2021 18:10:45 +0000") Message-ID: <86h7b9ybej.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Is there some part of either the description or > the code of `mouse3.el' that isn't clear in this > regard? Did you follow those links? Do you have > a specific question about how it works or behaves? It's too overwhelming to wade through the massive wall of text. Thanks for the short overview below. > Instead of a second single click always deleting, you > can use it to access a context menu, to delete or > perform any other actions. > > Doesn't that remove the standard second-click-deletes > behavior? No, because it distinguishes a `mouse-3' > double-click (which performs the usual delete action) > from a second single click (which shows a context > menu - or in fact to do anything else you like). So double-click mouse-3 pops up the context menu? But no other app uses such a gesture. So no user would expect that the context menu should be invoked by double-clicking the right mouse button. Moreover, double-clicking mouse-3 is not convenient to use. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 21:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "jporterbugs@gmail.com" , Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163960422124686 (code B ref 52293); Wed, 15 Dec 2021 21:37:02 +0000 Received: (at 52293) by debbugs.gnu.org; 15 Dec 2021 21:37:01 +0000 Received: from localhost ([127.0.0.1]:33859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxbxN-0006Q5-4n for submit@debbugs.gnu.org; Wed, 15 Dec 2021 16:37:01 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:42982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxbxL-0006Px-6z for 52293@debbugs.gnu.org; Wed, 15 Dec 2021 16:37:00 -0500 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BFLKHbi018870; Wed, 15 Dec 2021 21:36:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=toQdv+8j8SBqSok+qK0NoSYaj7B4ZJXmX1tnssiOBuU=; b=UeIwLERrre8WNxnS/1EKC00c32HlCARn3LulvSCRdPm5V1OU3EEwvn9blyZxWGsc+NuH Yx5dHt4pMHdFIjfldZJ57UPWJ+Qo5gNdJa0bob1AR0F04nmc+7cG1vOQ/VbuhBb/LJAq RjZha8PDfZcRukYOWAQ7TOfzsw1GwHXbBkqKYp9oZbdJLJBX9BlgY7zKg8YAvLue8VkV nyclbyMNTS/ozT/xUe1XN63k4HjcDvWvymN7v3E1p5o91w0iWCv/RNLgLN5SPWWcbxVn CSMyzqLoS4r9rD79LbpUtvq/uGQBStecSxi+Ro6C7JRa8Zn5v9cNpU6jUesv0bPxKGG6 Hg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3cyknrgw96-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Dec 2021 21:36:57 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BFLZma3004223; Wed, 15 Dec 2021 21:36:56 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2175.outbound.protection.outlook.com [104.47.56.175]) by userp3020.oracle.com with ESMTP id 3cvnesm8s1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Dec 2021 21:36:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HvxJWvEn0uBkmof3s4cJhUbAKE2dg7d6PkmPVWcdgZgbAWLgRuPtB4YMwHVC5T2zIXv5dciPzh/DuriSMBvn+aRpH0EoRkhw5HdCFi81mRsUgK8Yh5Gnz9F5Cj0hU+WND8N/gjuCOpfIPtOTjLUJwzghsFf6ApkM43S7ao/u31ZyXCjbhazipKIf7F+sHX3dsW4/S7djUYf42y8xlZ9C+XbEtr02oIHcb8c3rlcOZQzafX8rCP3MveFmEl6s9+6Q1gnDYxFhsCE/VoE/uPvJexDNRMPY4ejGbuFwfkPvHR3vFdl+KHeB0kUyJkxszZ0Bts+kiQ7B9QZZmiuYo0HEgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=toQdv+8j8SBqSok+qK0NoSYaj7B4ZJXmX1tnssiOBuU=; b=GCoWCJvsJek2/tayY/SZIOJf2zoe+yIezIDb5ZGJPJtstu6zuSQeFvRuGR35L5Pa52iu472E3fc29Np4Pv0YOprnH+RPMmyjUhbolIErk5gfYHgKj9S7n8l6Gjasz989Lz9JW6YE2Qpf2k4/+jEYMyuEdau9ZXAPxZM57CRw70XtT0/fkN2SOGU9SU39CtOHorJfRVFgYMkRSZL7fhJw/YERW3zXteh26ZiDAGw+BqASYgugXgH4OCLJfm536uM0mBml2zeZGS/glaJO1+YsKqUmULTUzWv7tscVkS+WZkG8fCb+C3QNWAj0uZTwMMw8BqsOnbytY0fSBrBMcPTffg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=toQdv+8j8SBqSok+qK0NoSYaj7B4ZJXmX1tnssiOBuU=; b=nKs4q6G6TeHZOWFeOVn/HLP6vD4BFbYYjk1Zrven1qQVIaTsRQ9WRQrWK72s2Nw0A6b2ltZQGRdbmtzDhIvIABOQL1iry8JBgIo3L4zafaWrZ+USCgrotzWuiZDL5Ku6AE7F7NNeweDwLZoKLmP8o2wJA09+I0uvLbLu2mRURPs= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB3141.namprd10.prod.outlook.com (2603:10b6:a03:154::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Wed, 15 Dec 2021 21:36:54 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%8]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021 21:36:54 +0000 From: Drew Adams Thread-Topic: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Thread-Index: AQHX8eEodHgNDEEi002RZT6u7iHHwKw0CyzA Date: Wed, 15 Dec 2021 21:36:54 +0000 Message-ID: References: <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> <86y24mucz2.fsf@mail.linkov.net> <864k7agrur.fsf@mail.linkov.net> <86h7b9ybej.fsf@mail.linkov.net> In-Reply-To: <86h7b9ybej.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ccdcd58-275e-4e23-95ea-08d9c0130343 x-ms-traffictypediagnostic: BYAPR10MB3141:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lbztZTk+kcujfl+2c9lzGxVFdWVTwPM1LeqNYgM3Pss6iIhfstBsTLddDbrIlzMwuRR2xXBuID9OsEMN+B/X75daAi/JxddOkqMitL85DzIvwtZtMG0ci+RZGF1RlMKjlEYPceEExDhmczCpTb7MWTMVojinJwTsCE+SFriFK1YV236tpuednjfmVbYgQDohRdhv4vu4cJ5VLtVgflUgcCOyI6qNe192lP/c3FtWRUkMz7OV4Gkzjd7JfMUoK9DpJD8/pkQMO3n6UmEcDnhNxtpE3YCho0xhw6EYAkjJpy8bhFrOZGGJ0Sf4wGMyzye3SK31LpIBO8juqiD6HJWQfYfJ4E/9GMl8V4zNqUVa7Ag6VuKEiTYaPlgwREH9Oa6x8WUsbVjOx8mvadgyvx8QhzXuoUPayJkUePbj0LwgUpf8meCak3ImfpoVAv33N509v3rE5WCgHlCpsrc3L9au48mXbXoVNlzi+jOOh57flTWJq2cvE9xIuIeUw5Q7To0H1K/tdLhLX3WJDeHqyCfwg0WTcxBq2uio8frPv9fBaiyvizC4WdUpgGPshXB8MYF4McL5AmFjNruKg+YAe4Fj5gDEgnLg1bwRgQ0cjjyyttBzmLuUwFzCoAqqxnC+aHGLc3m91jCu5s0goR3ieGcxKCKOwIKbgvT/7RZBb0ZVikI2s26pkUsW1yBwKVtNMRctgUFWoeZMTVP0wbWwJabVpQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(71200400001)(186003)(66946007)(76116006)(26005)(86362001)(7696005)(44832011)(508600001)(6506007)(66476007)(66556008)(66446008)(8676002)(55016003)(52536014)(2906002)(33656002)(83380400001)(8936002)(9686003)(5660300002)(38070700005)(64756008)(6916009)(38100700002)(4326008)(122000001)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: MIua3xCDI0IyPcs98/2xzkMNheoxXHNko6DEDe2syVIh/f5GDAhbQczV0TFcD+0Oz5Zt1DkwNgM1xHD2KLMq8EuhiLhCzvWR0Krdf0RV18HbD8I4k5eSMCQfzzfk2XQdyvy7TiSfMKO1z7xQYo4zW9R8BKW9Pbkrv9PQLOSVcP0pMuXmv950FGqwiWebSL3oJ9JkPmp1cchBHoifccpiSt5hv6dRtoubEbXGKGdHQvfECkkTXcaW/PkgdIQo+8nABZG7QsvuhoQJxyvl66daebJCZ76ku8vS6H2/oCPrz8w1SET5d4fBDbB3fGm3H2w4dkRsvfXdhwcygpmUDrFCMPtUPRKux6lVu55p5fUtkxro8V9clSXq9Iv3pAENgn/pQ1w3/nLxQqdI00aUDFr+YA7lrdoiNGP6Xp5YhCtkI3QZZg7dyd+9rFWFxKEZ5JlWfUWw7WWvna7lCStdCTrJCLf1ZPrOySdb3ZW3IcbL1jBR5fdYQhbwj4Mw9DM+/IY9NuskC5q9+YXliXERK1k0jVwGt3JyoNthBlZudBfbbHiwaCyya+Nxn+WQptL5859GOZp09Q29xu0KprFWUHzXjnYt9DXu1kVXYFUCcK3LACvfwAFielF9IzXq6orSuiVkrxmRXGMfXKLv7LMm9JdrDb/r8sF6vrYF5sLbseU34oJNY3gDu5mWGc3Sc6vIsincRtilvnoEqlvo6Rib+65dfIjlP/f5Gl2JxWHekz7mUFqA3YhFUnRgVAAYD3Mx8UXnaszxLB8kndDTZWXrTdh5+TudcnDhjmQ7aguZ232tF+6Va71rKOhB8m/kh3Ti8JNN1+VxDQw3+gVdatuusDj1oWMZyKqLnydHi/pgn0gNLHQjhpdVQGL5CPSWIwU3dY2DsBOxBum941jkEnz86QLd741nl8GB/Ymfjyj5ngnPBgmLujlq9baqsqjf8l9K5K0hYoLIRem/9NeUgmSC0mn8qjaUlblM4JrMfHhXDXC7sLgJr4j5DXkb/sjxXT66eteJls52pQTRNqBnS2ckOfthGkg3fWiq7pVa4G6K0VREYxShX08bxpUhwccChT8Xh25BCdvDsteXigOHRW5v+RAND9AAReYhnKntTmFo8l3KU/3b63xmN2aDT6tN3/2lUCh1E3LXzGf7u1L4ueW0dlwJOo3XL4XxAa/0j7eWLVcj+i9Jzju2iBZfKUPyyVLi4yAuRB1XYRWAU5dM9q2ve+U+SeYBNVpXX6vMMCTW6kRW4uJro6hVX+yH4v5ZjDhk0poZGtB2XsX8sXNZ3Tyt9ZCLmAEUtG+nQZK/IzShMy8MKkIAZZD54kreuTfNsviqk1yIvgPS1aLPhW6a7SKJnxk6hftXvZldZiJ22nqK51bg75fCDq6l76K3Ku1UqB36j4Vhc2/vmPcLOQpDna9fLUXOJi7Wmyl53q5TJt1i9V9q7OVRmtzxoic0TdFihhMSumaKZ6e4AWHfdLniSkbkwGQIN4KbGVWwkNissPR1qfNxuGHErMpvuiiebBwC6HLFV89CsFJkUUXPdSSMkjmOt55W1h+xNie4/qObXpwXLna1sWZ8pOA1QTuIJVoTTydtvVcrsMTDg4Eit4m34sNcrJTmJg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ccdcd58-275e-4e23-95ea-08d9c0130343 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 21:36:54.0683 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1u2hX3sysLe5LsbIxkX3BNtLX1O1mGvFq0fiE8AUt/I6coaMFhhNfNaQ2vs0Z64kPxmQjHExmul7oxW8dYIWGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3141 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10199 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=960 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112150118 X-Proofpoint-ORIG-GUID: tUar-nBKxFAY-HDCHemHNxyZ9ef1lgDv X-Proofpoint-GUID: tUar-nBKxFAY-HDCHemHNxyZ9ef1lgDv X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > Instead of a second single click always deleting, you > > can use it to access a context menu, to delete or > > perform any other actions. > > > > Doesn't that remove the standard second-click-deletes > > behavior? No, because it distinguishes a `mouse-3' > > double-click (which performs the usual delete action) > > from a second single click (which shows a context > > menu - or in fact to do anything else you like). >=20 > So double-click mouse-3 pops up the context menu? No - reread that, or read what I repeated, below. > But no other app uses such a gesture. No other app lets you do what Emacs lets you do with mouse-3. No other app lets you do lots of things that Emacs lets you do. > So no user would expect that the context menu should > be invoked by double-clicking the right mouse button. Not without learning about it or stumbling upon it, perhaps. The same is true for a great deal of Emacs - wonderful features. The first thing to learn is how to find out about things. And yes, even that takes some learning. > Moreover, double-clicking mouse-3 is not convenient to use. I disagree. I'll bet it's what you're already doing when (if) you right-click `mouse-3' to kill selected text. I'll bet you do NOT use a second single-click. And anyway, it's not a double-click that brings up a menu - that continues to do what it's always done in Emacs: delete the active region. It's a _second single-click_ (at the same spot) that brings up the menu. (That's a design choice, so as to fit best with traditional Emacs behavior. Those two could be reversed: double-click to bring up menu, two single-clicks to delete region.) ___ And again, there are simple user actions to get ONLY what you apparently prefer or ONLY what Emacs users are used to: . It's trivial to choose to always get a context menu instead (and yes, with a single click): just turn on option `mouse3-menu-always-flag'. . It's trivial to get only the longstanding Emacs mouse-3 behavior (never a context menu): just set option `mouse3-second-click-default-command' to `mouse3-kill/delete-region'. (In Customize, choose "Kill/delete, per `mouse-drag-copy-region'" from the Value Menu.) Better such a choice than no choice. Better such a choice AND a 3rd choice - for the behavior of offering both: context menu and region-kill. ___ And the doc I pointed you to isn't a "wall of text". It's short and to the point. The library offers lots of possibilities. And that "wall" also presents examples of how to create specialized context-sensitive menus. ___ And this isn't the first time I've described the behavior in emails to the mailing lists. Either you haven't paid attention, even in your own thread introducing what you wanted to do for context menus. In this current thread I'm repeating myself. I don't mind, if you actually listen or are interested. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Dec 2021 17:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: "jporterbugs@gmail.com" , Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163967612923078 (code B ref 52293); Thu, 16 Dec 2021 17:36:02 +0000 Received: (at 52293) by debbugs.gnu.org; 16 Dec 2021 17:35:29 +0000 Received: from localhost ([127.0.0.1]:36582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxufA-000609-VQ for submit@debbugs.gnu.org; Thu, 16 Dec 2021 12:35:29 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:44315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxuf0-0005yn-SO for 52293@debbugs.gnu.org; Thu, 16 Dec 2021 12:35:26 -0500 Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 68068FF809; Thu, 16 Dec 2021 17:35:09 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> <86y24mucz2.fsf@mail.linkov.net> <864k7agrur.fsf@mail.linkov.net> <86h7b9ybej.fsf@mail.linkov.net> Date: Thu, 16 Dec 2021 19:20:50 +0200 In-Reply-To: (Drew Adams's message of "Wed, 15 Dec 2021 21:36:54 +0000") Message-ID: <86czlw8scu.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Moreover, double-clicking mouse-3 is not convenient to use. > > I disagree. I'll bet it's what you're already > doing when (if) you right-click `mouse-3' to > kill selected text. I'll bet you do NOT use a > second single-click. No, I don't use `mouse-3' to kill selected text, because it's easy to kill selected text by choosing "Cut" from the context menu. > And anyway, it's not a double-click that brings > up a menu - that continues to do what it's always > done in Emacs: delete the active region. It's a > _second single-click_ (at the same spot) that > brings up the menu. So there should be a delay longer than for double-click before the second click pops up the context menu? > (That's a design choice, so as to fit best with > traditional Emacs behavior. Those two could be > reversed: double-click to bring up menu, two > single-clicks to delete region.) Still inconvenient when double-click brings up menu. > And again, there are simple user actions to get > ONLY what you apparently prefer or ONLY what > Emacs users are used to: > > . It's trivial to choose to always get a context > menu instead (and yes, with a single click): > just turn on option `mouse3-menu-always-flag'. Maybe context menus should be enabled by default? From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Dec 2021 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "jporterbugs@gmail.com" , Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163967708025039 (code B ref 52293); Thu, 16 Dec 2021 17:52:02 +0000 Received: (at 52293) by debbugs.gnu.org; 16 Dec 2021 17:51:20 +0000 Received: from localhost ([127.0.0.1]:36637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxuuW-0006Vl-9P for submit@debbugs.gnu.org; Thu, 16 Dec 2021 12:51:20 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:26184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxuuU-0006Va-1y for 52293@debbugs.gnu.org; Thu, 16 Dec 2021 12:51:19 -0500 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BGHVJHe032175; Thu, 16 Dec 2021 17:51:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=7tOQRUl4vFBrMEltNmvDW9ho3IBEWBL/S261ZekAfPA=; b=JIcBE8Tt+VXArF6bygS+pIgVRUAvL5Jg30uNArK/Zy2r/16gHyUMUwbzz6sVdjW8uSQp Hi4T0clHuTgrscfrOv9kTVXqZfuFqmbfYc720HW/jQ5fXXleripwyuiuX3oJqcn3jOAv M6hRjfnV0cMpZli40pcsaBm8hsSx3vEbfycJQcp1yVT6jSSTMt1rjgBI6qMpUez71kMf CgvTptE/pLQbibscsB3hEyz4eKvLz2HL0T+wB9Oj8LSoqzwbXSTdH/wQbeRGvvhPYfz5 pzmSpxC4Th4v82ljK1SLeYmnblHtzdWku00wWi+hr5xFAK7ptxt6xrXmq6HIeZuRrhyD Zw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3cykm5bn61-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Dec 2021 17:51:16 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BGHoisr085496; Thu, 16 Dec 2021 17:51:15 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by aserp3020.oracle.com with ESMTP id 3cxmrdqpyh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Dec 2021 17:51:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OouiSZ19DjaXtMEDsrL18i0B4Yj3kfe5mHvzzVoK4Ch0YHWo0fPGPYxJfHRDMjd8SwBU7oc2SnqYXkfQE8pF+I9qLbsJdp0GCOmvqxRRiTv9gdi8F29dVv2T6cuGfi/igq4FPb3tC2q7dWgHqOa0oUKsWNQSzVQWvx9GmpJO/GmlVVu29k/CTdMRz9C0LBjGipIWlSIc/QnlRdbhdjwOqLAg+fxdNXcfyWI5ihvP0AgHw4gAcv/WxS4rROg1clkKdATMFhIFzxYbMUpVNlMoScCt1ydOlhkYH7uE/Fca0T/i1xG1VL92QsbgmXDluYSAnHMVIG1OcvuzPmFLYShh8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7tOQRUl4vFBrMEltNmvDW9ho3IBEWBL/S261ZekAfPA=; b=l1/ajB9Vm4re35AKKPT0e0431487S9xqMXth4WfKhMiaVsGrLxEfICUbTBaefJ028RDYYR1nSGB3Tog3tRs9bBKqJQAPcUxOS7mKzsMTDKy9fSGMhoi6qD68w2vSQu8+1uYmOqQMimTW1NKK9RW15pjHrb/0Mrbel0tT2sSHdfxby2rZja7zv8Vn12CijqrVS9xAARxkMCxAI4FLiSPyzUoIHepcfoCujuNNkj+3y9PWhRE0IjA0v/1eXeCgtcMzuvcK/1hoLloNYcl71wCFnNHJNZjvgImFvJMpnC71eloOFVY1pcu2TtA92yz7n+i8vzLGKluTEJEr3igThomUEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7tOQRUl4vFBrMEltNmvDW9ho3IBEWBL/S261ZekAfPA=; b=xkxPjL0av47s8cqQSYsvpLo3A7Ry5RmSBp9MeHWVeHcKkE/FAulCJJiOh2MHdS095ZkPzaIlvz+sweStXqsnQA0IrE2zyJP5D5MtTTDINPWiXvHrjPYrJRF6Xr2kc60LiYVLftshidHXaNgyXHEr8YshTTRwPhe/dU8JxCVEcCg= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB3462.namprd10.prod.outlook.com (2603:10b6:a03:121::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec 2021 17:51:13 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%8]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021 17:51:13 +0000 From: Drew Adams Thread-Topic: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Thread-Index: AQHX8qNNtRiFyd3SLkOaOPE7MrcHpqw1YiZA Date: Thu, 16 Dec 2021 17:51:13 +0000 Message-ID: References: <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> <86y24mucz2.fsf@mail.linkov.net> <864k7agrur.fsf@mail.linkov.net> <86h7b9ybej.fsf@mail.linkov.net> <86czlw8scu.fsf@mail.linkov.net> In-Reply-To: <86czlw8scu.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 013444d1-17b1-43f1-45bf-08d9c0bca6af x-ms-traffictypediagnostic: BYAPR10MB3462:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MRzrULSxRrKwM4wov+tsAjFTnZSdQy3uPfwIVk8HAbDk+NCs+OJxvDkjurpneS/CTZzb9I6LOXeWgBSQfa2aPQz8jTjlMoAeWaVxNIKyY9meZAtxH/YLUemPRXX5CM0eR6rC/KToOJ+MVUL8qsy3XCEbo/UFa9T3d5pcgG2xyzBOnJt8yWwacvIM2LFGAm+3LIUYgpM1bKa6J5FpbZc9Iwit6JeelFeHPtVLIBE8+jeE6iw8sZUsQFaAsnG/bzynovmXh7I+KjalDizFIJRPLl0XMcJ68ZuU79Vk5oAlFtWYGuxBd8VpB9pi8U0fXBpcvqiyGw4OzDPukDDyzUrKXzk5BEwM1LegajOqpPbMbSSLH9HV/QSBi0sWqBNIEuw4YlMWAxLCBDvV2+NSCIFJPsz8ib66EDNQc1KUAMKnlVR4SFcAPJ9DgC5hjMg31PjXchPFw68AZXT5Op+AnNGkHtzNM9LRrt6AJCc+4WUvzE78HvEBzKNBZGWAnNnJkFi7ygGMOmP1xbznbsRhtyOj8MV2el0q6GqwGZ2LsOSvyLTIw64piJO/RGNlHUq4XuTrejy2bhWbj/cT7F2/5BVy/mTYFzx0KaNJpy59njSge+11Y3HAE+y7tDQjXpjJ2tA4O6jXqg7hF/yYB2J6kThCN6766QZSHUfKotXkpDzBxV4cZvDnbksRqsBYCLQwvc/JT0+7mpNOQ6CiUL203CBzuA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(76116006)(66556008)(8676002)(5660300002)(508600001)(4326008)(55016003)(66446008)(64756008)(66946007)(122000001)(38100700002)(83380400001)(38070700005)(8936002)(186003)(66476007)(44832011)(71200400001)(6916009)(26005)(9686003)(6506007)(316002)(86362001)(7696005)(52536014)(54906003)(2906002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: Zf8+kFEt3upVlI87AQXJpLk/Df7xvhJvSxt/4SXBiAftNctVvQVOLSIirnvYXLlF86RyMB+GGkXsUFKkmFXbNwS8fVvk3KCujm0QCASMV8kG5rFf/TCze59Wf01f4LPZ+dPJ18gFWw/isPD9gXkbUeul0Di2Zdm/vpHUopDaa/BgTz4fwEtctFdhuDkcvaWD5ojDt5KZkb4U6fXsneJ+BOP4pY0SxyIS/dV+I5ItYH4cGORX3SeZcRNT4riY07gcz0nqlqQAxpaQ6/I7dyITtJPKrhQHGUKfzpzcO0KMK5uHlrC0B5KSBE0rP83G06mcpEsDjycBxxMLjrbyydffGFyX0qjvlZr0Qo1q+bOlgM4WMeKukRETzRKl0zg1WLDIfGU7htfdsUO9TK5fj3p0tve+sha4zWTkzYHck3MemJHMfGFZCBsc7URcmHQOhdUMslEvHMSxrwxq9aAY3qBs/fFdELA0btzLnL6M/9iS1B0MziBryMfOxRnIuivl8H7bqE0nJfkaBj8tc5I4eRiUWW4nx5s7UvEuZtprPBes4LqnLF4ibPW1e+04QMRI4FtPM2okhinYxsfDXxy63Tj8RppeTMyuHnhL1qHG37E/JCqQdApJb77cB9ss2zr+O+fPrMbuuaxuMwU6whAndkkR/notGDdCLkX1HsGOkgomqnCeoqL/iVXaqs+CcQgSfoGg++HPGV9b6GiyGrR3m4fVT36i5eCQibi5Ht7kZ8h1V45kN2hBzKQeA1SJEbvbEEvpgaQq1X8L0olgFoILLm7KkYvnPOzzxOn1TAwDoM48bghOgP0p0N6IsRN+lOtLZcPptIqeRqKhj389mlBYNTbuDerCSJHG8fN8Fl5uETryKzmn95IYpzl/ai8kb+fDF+4IQUAieqO1BuxIiI9bjv2bm/1G4pFZMorBhFgBtES0rBhKnp2nKrMb+Usn9opMwbKnW+FHljrLoMkNprDe74Ij3JIljStZc+As4NPXZySVzYGnpl933+eLrX5uZkZ1MqXlk8ji8bLQxCpKHqeEYLT5mLQuyQaWoZspjFu0pmqD7GxBdtVLFpc2E2adXPLLoQR13mVMbeZHyrm9+lXl+7l/O85QXGjiTYV4KjSE8zAyIUpIx3LlR7/BEJ/NuOFzZ+Ha7rrCXfwDerKBix3p+9d7ob12dsM/vCFBHthrajfXnzWtlj1nC8JBbQnbPiizJgdhhBRtgiCEodLreJelM9npnsIyW7pnjyXKhmJIDewjspa6doaUn8w6ctzsWGBmX2Y7noSN5qzKbkvFiQPcYWOI++YwWitSXB2H+h8hfdjXulpwGgWAak0/XaqYbvvFYaaeSpzD7X9gn6mTjqdGKug7n459KGhsd8ZvAbL0nONQhYCKTrD2INd41N+6sWwRlvq8AARHGeY4QEU9qogqi6EpC+1+it1Xz92459Rw7vOXewlrZVwxZ0VPWnuNuPthUWGC25sxyPxbMf2OMJaIBj1c/Xf0Q7WDvGt5xBwFjcAbbAAYeFoiyLdo3lHH007SroQeVQMh6Qqn+Y+Z8o0xnSWoW6sht7xiB5jhdlqalSDTMWTnxivdy04GjPHO2Tw49S1M0YdTjOm2hCuCKa+XzFnzzg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 013444d1-17b1-43f1-45bf-08d9c0bca6af X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 17:51:13.0771 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MFki06suWQjzDeBqT+egwMGs+BWihkB1AyJX72kOR7NLWQbvkCrytgjbTs5/v5JFOghcwowVPNS3FDBIISFiHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3462 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10200 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112160099 X-Proofpoint-GUID: EHA3bLPv9cRfZ_Xe3-OCOSyvb2kCCur_ X-Proofpoint-ORIG-GUID: EHA3bLPv9cRfZ_Xe3-OCOSyvb2kCCur_ X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > >> Moreover, double-clicking mouse-3 is not convenient to use. > > > > I disagree. I'll bet it's what you're already > > doing when (if) you right-click `mouse-3' to > > kill selected text. I'll bet you do NOT use a > > second single-click. >=20 > No, I don't use `mouse-3' to kill selected text, > because it's easy to kill selected text > by choosing "Cut" from the context menu. Well, you were claiming, in general, that double-clicking is not convenient. Perhaps I should have said that I'll be that it's what most users who do use `mouse-3' to kill text do. It seems you're maybe not the best placed to propose that the traditional `mouse-3' behavior be shoved under a bus, and just replaced by a context menu, since you don't even use that traditional behavior. I've argued that Emacs has great mouse behavior, in particular wrt selection and deletion. That's comparing Emacs's mouse behavior with other mouse behavior. It's not comparing mouse behavior with no mouse. If someone does want to use the mouse for selecting and deleting text, Emacs's mouse-3 behavior is great. > > And anyway, it's not a double-click that brings > > up a menu - that continues to do what it's always > > done in Emacs: delete the active region. It's a > > _second single-click_ (at the same spot) that > > brings up the menu. >=20 > So there should be a delay longer than for double-click > before the second click pops up the context menu? Users define the time period for a double-click. They distinguish double-click from two clicks at the same place. Not a problem. You can set that period as brief as you like. > > (That's a design choice, so as to fit best with > > traditional Emacs behavior. Those two could be > > reversed: double-click to bring up menu, two > > single-clicks to delete region.) >=20 > Still inconvenient when double-click brings up menu. Your opinion's noted. And your preference is easily satisfied, as I explained. Perhaps you're arguing for your preference to be the _default_? (That's what you're apparently doing anyway, if your context-menu feature will, by default, _replace_ the traditional mouse-3 behavior, instead of being added and play well with that traditional behavior.) > > And again, there are simple user actions to get > > ONLY what you apparently prefer or ONLY what > > Emacs users are used to: > > > > . It's trivial to choose to always get a context > > menu instead (and yes, with a single click): > > just turn on option `mouse3-menu-always-flag'. >=20 > Maybe context menus should be enabled by default? Clearly that's what you think. I don't. Not now. Normally, we keep the default behavior when we add a new, alternative behavior. We add the new behavior as an option (opt-in). Then, after some experience and time and some user feedback, we might consider changing the default behavior. I say "normally". But we seem to no longer be in normal times. Dear Prudence ... won't you come out, to play?" From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Dec 2021 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams , Juri Linkov Cc: "jporterbugs@gmail.com" , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163967738325560 (code B ref 52293); Thu, 16 Dec 2021 17:57:02 +0000 Received: (at 52293) by debbugs.gnu.org; 16 Dec 2021 17:56:23 +0000 Received: from localhost ([127.0.0.1]:36651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxuzP-0006eC-FX for submit@debbugs.gnu.org; Thu, 16 Dec 2021 12:56:23 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:17058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxuzO-0006e4-HM for 52293@debbugs.gnu.org; Thu, 16 Dec 2021 12:56:22 -0500 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BGHV7hG024430; Thu, 16 Dec 2021 17:56:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=/TjEZH1TCHVJ0j+2jt7u59wbfkqL61Y92PynQnwBEAo=; b=mW/a+hFlT812KtzuxPOhrLGLS01h6l7zN19jmSJtv6kV4knc8lk4meRHOVfiMtOpc2mg C6lba8TUQB/t26FOkjDkGO+9Yz8ZwttkqgMKhYvrNs+fPvlg+1s9gHSZi+9L/34NVPWF fiWfGSbecdwix5uVkkb8Pz8ThqEsgnOtSj6kBxVLfKV6Ll5IZbzOy+d2k3OxHWPLM2LR /LHlU2wketCpqcreUNzC15cHSGm2r3br18gP3YnpGPMhyQOw+GUH6TXmctcgua4EaPcQ nJKGbCzMu5Qw9DyzY1Tgr8nA4x1/akf4RCk4N6IBpYG9SBEKtLzCryPlH8/Gy07h7sP6 uw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3cykmckg5a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Dec 2021 17:56:21 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BGHoilX118308; Thu, 16 Dec 2021 17:56:20 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by userp3030.oracle.com with ESMTP id 3cvh42db28-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Dec 2021 17:56:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQMCGWOwWRYsz44eXx46VQWSPpXSfTNnFoWyPMxLtuLcSYXA3t22YcoLUwEdhyvAlHHgn0ZHBifPkDp8cg1xdSM4PkVmHBT2wZ/KvYQu4xkMIg72pmzErRkgZJAX2RMBBhr8d+KLhZveVZX27fKvX8rrgD+BZEMEAIi7AM/O5RW4AZXVSVL1A9nwUg36P05KWKIFNikToLQwmDZSkpZxEZFgqacY+vzkMvrv+a3de71KNAtXmCEZZ61cePx1O/42M5/1TdWd2JjP4ht+4dH3T5WTCzhPzoiVCg5dcjbd+VBURWQ+SxPgSEZJMv3mYx77tWFodoWVw+OWvE8+fV2vpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/TjEZH1TCHVJ0j+2jt7u59wbfkqL61Y92PynQnwBEAo=; b=F6tqjPBMWLqz7kZAWoJPvF/FrqxyELGmA/779apXpRJq6imKh5+urUDnazwiTfJganc9BGotqCcx0g12lv5MOVL1xdeIW7O6GaF+aTI8lzb0dnSl7nTOa+LJnzl+yDtmZglbC0XHendbbTvOwX/SAFQq0Cp3q2QTKbIn2ovgFBu5BGPuDIR8C6aqQdNULV8HSTUhgH/qvdTGvI9ekYTGnbppo0B1NZbqiwSkbb53bXVkwN2qfgC6l0/vKOSBbS8uM4bEDhB8eMlLG4X/iiknQLlljGRPlynq/x7YKl5eeFt9i6I3lTgol/jAfHg2Zu1lEy94WbwMj1wp7K/AXRsoUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/TjEZH1TCHVJ0j+2jt7u59wbfkqL61Y92PynQnwBEAo=; b=UtKJ2nyfJ+cooii4oxiIbmtoHElVs27XmCb3+lTDOyDf88e1wlAP+rsVHCmasa4OPL1kriZ/xeQFQflJrsMgZkTnYHkU5WPeWo25xs9PLajDJB6nJ3PSCdvNC16TnJNskHD1BdcTpuqYR9mN5wY18Y869YAcilwL1EV8cxQHSro= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB3670.namprd10.prod.outlook.com (2603:10b6:a03:124::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Thu, 16 Dec 2021 17:56:18 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%8]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021 17:56:18 +0000 From: Drew Adams Thread-Topic: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Thread-Index: AQHX8qNNtRiFyd3SLkOaOPE7MrcHpqw1YiZAgAAE0PA= Date: Thu, 16 Dec 2021 17:56:18 +0000 Message-ID: References: <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> <86y24mucz2.fsf@mail.linkov.net> <864k7agrur.fsf@mail.linkov.net> <86h7b9ybej.fsf@mail.linkov.net> <86czlw8scu.fsf@mail.linkov.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0abde62f-a0db-4c96-3539-08d9c0bd5c98 x-ms-traffictypediagnostic: BYAPR10MB3670:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W2FUxxpDsOmSkyBOdjJbEXtiAKEbPY+3RgVUGrRQmCWQv7yLQpXxFZrDNkIGJVIgxCoeiEctGKI3q37eSzZpAusav/3Ea+WEdtCVQsEaucV2jWxkLAqYzVUteNARZqx+88B4RBQv8UOiSklG+DZoTc4lchf60oNv64fnwJGBwKFnhZncsqY6Vrs5NqdMOO+BVm4AyCUR+VfyUyUxHcd5Yy8qEAT7Z47nICI8AztElopoOzDmQEZ0AQri3AV8MMzq/ZN6wXpYaukB9McwrtrOSe8LF8kM+oA/O6JbXBuSLwFl0QvzLM+TfHjywiTzjtXhfe/O/Yw37+FeZ7OxpUNsnqvPerDakrSeXjFeTZZ3lrhYM5PHLd42i1+CumPgEweLnH5//uwlRjUlX4y9jV8cOlHO/9IcIc3F+e0A20Ylx87wiqWp5SfaYywgE6gbwyAF1C+rIaadZBH1MP0BPVg0QoG5/ml49umMVvfXT1OShGINNpbJZzy9hju4+nRm7IpBsr471jT7jZSSCNZKJSK05xbC5xsPmFcH7o7R1caBmOs8dEkNaj6MH3wTlhGG4E+akTp623jddLwEHAQ/35qz6jwL0qSZQ7sUbht5oqEb12LjI8uxncU+F9bJu+Poyc1E7VCnzM43Lfem6CA9Bb3zY3lyGfI2RCKS3mFfNOi8Kt+0CtTa2au6Jwevi9+sYk4BGxvD0+QU59NKbL5MPdhONw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(558084003)(64756008)(316002)(38100700002)(8936002)(66476007)(66446008)(66946007)(9686003)(5660300002)(52536014)(2940100002)(66556008)(508600001)(44832011)(4326008)(110136005)(122000001)(86362001)(2906002)(55016003)(7696005)(26005)(71200400001)(38070700005)(8676002)(54906003)(76116006)(33656002)(6506007)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: /AfHnTfPsfXMTDoRtSD/sLESTa9Jh4ucAyowfDuTI4gKM7lXSbhr42KjDo5ozQ04O6+gdKPXWPCzQRv7aQBhc9KaAU2V3bfCDZ+RIlihgEnnvrIPRw48s1aIPWI5nuckHhILfvvhpLwR4eE3viK6j1nQ71RVL4owNCUvk2agdDw/evcvj7D0M60++0aHqNS79tJwMfDhkkUxPF4oxwNY7kVyKVgmyDC0RHsRfzOWK+v6TkV8CvrYzuy+xhJOEjYnZBMsgbf3b7LxkcfbZLSJkUHXxqO+zoEZIdCx2anttj8rIHd4Jqx8AUQEDMjb9Bm/mpAkgj3VuAHdOgN0OTgO8HaC4h/aIp4uIhyRbna2xIWPunBef4X0N6aD69tQKkMq9ZlgJeDoIvH81Ne9zYRU4gJMgSqmVhBhwP0eGQk0q3rz51G5zv7AZCQsY0jbtgjSB67PvtpQNplolpemXqDXl3Z/Yq//G3s83RTX9JMwvEPXj/t86PtdZljA48gq+9aWI3pO1BRP3gI1ZdSMItFaYPVjikLXHELpV5XHzE7MYxFr+LBaosckTKc1T+EUJ67VbJTbxns+VAobTxtfO+08LbY3CvQGTTHkqUvC/weYuPQh2h6im4kgdC51BR7DZruAgepEyPUI0fFhtK59SHGgOsvnv9DDx6wORggEzxK2xh/ODCC91i6MwrAx6Pc3/OH4g2sRL0pKLyH5S+OnTfGpJVu+vgp429cDNwgcv0Pr1JNv/YWFklNfWlFndjOBE2lBNk5i8C7RAfBQCyP4txhMoJJ/esogHL4K39cTgmNmaEo1kiO9rx0cm1SZUzfMVo8Z+oFiBdZYyZ8vXgbYv3djQ8to4Q8DGvV/xVmtA8C0BweLuLaoKSrDV4tpISaLTHEmwP0hhU5FK2m835di64U3Vy33uhtG7GPtf9HNP/O1tIMwJ3Bn9MZ2Y71UnPiUF8eLk94gmni9tgkh2No/Llh2Vb6kDV02jOIygx0aEksXGROmJH1d8iixGSSlPymVDDektslUczR7Vu4BV7S4AG6zaAMCJJPdxL3AqJttLs0RVoq5AijCVc2PbXDx1Dydvfh3B+lO1hewPiOIo1NyUaY7OhBgDuggiHnw0piDL494DHV1fGg1ikbFm1gdTmdGqh/ui3fmZDyw0CI2L544T3skDWrCHKXlDp49Wml/pUv5LGVDgvZOD/IARnHOCwCdDiFT1H7oKruTGRScwtC5+riawP35luwC+IFQTODdtsuYOKSiXC1GSnJysUuJU0MOOFQxfpnZ/5mPAIkXm/1a+dumCa+slw5f/bSYU8qpG5gduHFkbfCrnisYgNezT3q9oq3z/eIZb9J9sXHwHi8uray+ecEXidz778yXevHuUyQ3Lz4ifVGibN1sXEd7jrC1FM/lufys3wmrETWpME4mCTWJfkqmyvAdOge+QNjrziPk7hEBN+25Qc4ZN7UE8YlNYEwQwmoo7Y9AtUncabexCEhRIb3DmbL2ftgtNqcmX1K2ZeTZ2BXsUC/w5b2/sKeu5eqbylpBAuHBZcs6PliC0wvC6xIfc6ADdAD5y9cY4anUj3Zihk3VXx0wXVRzjFltgsJjyt21L+J9O1WQdDrvwrDxRQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0abde62f-a0db-4c96-3539-08d9c0bd5c98 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 17:56:18.3685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u8QxiSolVX+6kTMPL5EnF+MEZDYbuR+t6iZJqqSCKtIQwoaRonSjl+hKjq3oNyh+nAxK2yEcXL0NQ+6teD3vJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3670 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10200 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 mlxlogscore=616 bulkscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112160099 X-Proofpoint-ORIG-GUID: V7mbhP1k3vzITWjKvxNgai-L4MxvRYfF X-Proofpoint-GUID: V7mbhP1k3vzITWjKvxNgai-L4MxvRYfF X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > have said that I'll be that it's what most users who ^ t From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Dec 2021 08:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: "jporterbugs@gmail.com" , Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16397300046097 (code B ref 52293); Fri, 17 Dec 2021 08:34:01 +0000 Received: (at 52293) by debbugs.gnu.org; 17 Dec 2021 08:33:24 +0000 Received: from localhost ([127.0.0.1]:37878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1my8g7-0001aH-VW for submit@debbugs.gnu.org; Fri, 17 Dec 2021 03:33:24 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:47675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1my8g6-0001a0-J4 for 52293@debbugs.gnu.org; Fri, 17 Dec 2021 03:33:22 -0500 Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 0E7A924000C; Fri, 17 Dec 2021 08:33:14 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> <86y24mucz2.fsf@mail.linkov.net> <864k7agrur.fsf@mail.linkov.net> <86h7b9ybej.fsf@mail.linkov.net> <86czlw8scu.fsf@mail.linkov.net> Date: Fri, 17 Dec 2021 10:20:20 +0200 In-Reply-To: (Drew Adams's message of "Thu, 16 Dec 2021 17:51:13 +0000") Message-ID: <868rwj4rg9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > If someone does want to use the mouse for selecting > and deleting text, Emacs's mouse-3 behavior is great. Not great, but bizarre. No other app uses such method because of its limitations: while the currently default `mouse-3' only kills selected text, using the context menu from `mouse-3' allows to select more operations on the region - kill the region without adding it to the kill ring, kill the region with adding it to the kill ring, add the region to the kill ring without killing it, replace the region by pasting other text, etc. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Dec 2021 17:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "jporterbugs@gmail.com" , Eli Zaretskii , "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16397616882544 (code B ref 52293); Fri, 17 Dec 2021 17:22:02 +0000 Received: (at 52293) by debbugs.gnu.org; 17 Dec 2021 17:21:28 +0000 Received: from localhost ([127.0.0.1]:40562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myGvA-0000ew-9f for submit@debbugs.gnu.org; Fri, 17 Dec 2021 12:21:28 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:29232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myGv7-0000el-Jd for 52293@debbugs.gnu.org; Fri, 17 Dec 2021 12:21:26 -0500 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BHGXqbB022583; Fri, 17 Dec 2021 17:21:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=/34lQPFDdE2L7vqzVN96tnHOwRCIHjLuv3ZLkrjAGRI=; b=yr3Tyky1AQtb/1b7WZz3V3Nzpq4JxgzmofaUDHmYpaJmXmW+XO3vJvA4VzSjhWOI32dH 2uV58bSNi4JR+6E7yDjSA3lQ/ZgNm7oDE7uHIr23EiC57KEDIBu3686eMMwA6HkLhD/L ANLnToNLOGAmxMXShdH2x6VHHJa6xM8tJvpGtaKTv/J0xbSp+0zm4AozIAJFpy/mwlc2 XUtcs3SoVeRDpx26N+i7fSNDquuWhWGYdKFxsF+HnjvFNwTcnmx0UMuQgxZgP3ZscxOn fBSREnEb6FcB8gjnK1bir8DRvksrOSJAfv0NbpKgQ+eaekr3uUTPDCH2QTwpzZGhMk8V yQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3cykmcp741-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Dec 2021 17:21:21 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BHHBuvq148408; Fri, 17 Dec 2021 17:21:19 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2173.outbound.protection.outlook.com [104.47.73.173]) by userp3020.oracle.com with ESMTP id 3cvnevt3fd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Dec 2021 17:21:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MQUrctrG0cHITERwwzPrrHVyPgd2W9dauidyd+YHlK3+9y1UPdHjcMN+QKKhkpTw8HD2BkO7DwEIhNTtet5S/hEjyzcJMCi58+OYGgWstgNeNsSV09tcSi092g3rIEjMkvoHC8vF/GH8L/IEJHyZrDJNnD7E3g8xuID6ro846F5ZQY7vh6aiQuWrahhzSvPf6MOS+ULi8f9Z1E95adhkKBQ/KN7XAAf20hOyyBB2OIQfzYWEMcHeuKKn5RgrpXrlzbIjwOMvADpyNwCy25KeqmD3GXiGusa1aBSAJ4M2GWHWyDNeY1xG8g663SyTOqX6/aab1Dw8JYAb7Q0Fi1ysLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/34lQPFDdE2L7vqzVN96tnHOwRCIHjLuv3ZLkrjAGRI=; b=J2350snQHfHguVM7MMwm8StJfurG2VSkwiM7UJbdHJmNuhBnKwS3iE344lwhakohlJhali5cApXdLuIQVwAGLeHfk+kAP1eySPtxk/mtiLM7JknqD+fbdUYT+bfNa/JuM1wX3+AAfLmCqGP/WMCUlz7nR/abjcWxkqJf4MOzSD8irVP2Nq2+EmVz053dPdbvtz87FjIMU4enxGo/VG/i05DrHYWSFZBDaKF9UiP3+jraIbB84wrTzyQc0p8tsLvGJyHMexJeDTQL0GZT3c3mS0jx8sk1sjHQPm6Tk6pH8IjtZP7igHBPOg3y2mhXNUoYoEzUOtPeIMgRrMqhI2tvsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/34lQPFDdE2L7vqzVN96tnHOwRCIHjLuv3ZLkrjAGRI=; b=MhWL+SAG/rmImDatnZ/6oKqgGH9nODUYI+/xq2+JP2JTuWPG1Npaan3wN+eLRkpqdeldAWs0Ct3V3ebDT99wGHwmPVlpr4tzO9lulbDJ2PlwMXd1OJtpJEg4YBrHxlJ/+F1rr7zxYVxACpK9GtzwhynJQ6jswuH1hF9YjA/kmRs= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB2520.namprd10.prod.outlook.com (2603:10b6:a02:b1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec 2021 17:21:16 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%8]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021 17:21:16 +0000 From: Drew Adams Thread-Topic: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Thread-Index: AQHX8yDBJQRwPMcnr0SyzVHGd8F6Rqw27Avw Date: Fri, 17 Dec 2021 17:21:16 +0000 Message-ID: References: <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <83ilvrl4m2.fsf@gnu.org> <86y24mucz2.fsf@mail.linkov.net> <864k7agrur.fsf@mail.linkov.net> <86h7b9ybej.fsf@mail.linkov.net> <86czlw8scu.fsf@mail.linkov.net> <868rwj4rg9.fsf@mail.linkov.net> In-Reply-To: <868rwj4rg9.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8e09184e-83e2-4aac-90ef-08d9c181a26b x-ms-traffictypediagnostic: BYAPR10MB2520:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mmoR1emAEgKlKfKOHAKtUrl0C6kiSpFFMb1edRL1B1JN89h/KfceKa9Ho+rKDq3y+F+pTD3lQ5jhxEm2lLKkZjttkFbkzjEqJirI7+DVPhRB5HMotR72UuYRVjnZcIqPyaOXZOYAj0N9zpb5Cb1W5RFDM6jKH8ONzqME0lvKzMQ/ktmxDkpm5S67Evu8fZzX/JoF/FDaiUEebfvXfIqTgNrKpgdHn2kzpOffFnHHEa5PauOVElMWB2vxwkbbyp3FcIRBwtvgFCalN4n608J9GQnjQ6/uj3iUXIIBEp7kzHxUXZlgcgwgxmjGZpMDqHH7qdUhgP5bg8fkbouTbm4Y+aNa4z61m2AzOg1fuklepEw+hj1mLUsAzfwyQ8T+FJA+T5jeWc0r4vu+GNND8k1nluYdz7zZuvyJvRNS/vbhdkfrooJNu5ssLbZVR74mJpHD2PgCQ8rDMPpr9mD3Cql09I6zcOyKVA33zd3N5icdp6SFZ8oXdtBgGpvzA7zPLXLqfEGQXKPOYS9AF7VvN+zo1Dx8Ewq7kcJIB6aBhjF9VAnxtv4rQcD7asgVDgDBHMJMfczeKZJw1kauVf6vPQ5nSobL3p+5xfMo4hPJwpKidIJ4/PWScXJnCqyB312IwRJbiP002NebVQ97NwtCCKkMwQhhcSkxGm9+2MpR5ha+ooiruCn5b72bL415jjkO5FXrOb0R7+opZQH/QvGsu7ewbw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(52536014)(54906003)(8936002)(38070700005)(6916009)(76116006)(66946007)(508600001)(4326008)(6506007)(55016003)(186003)(316002)(122000001)(66446008)(33656002)(38100700002)(66556008)(64756008)(66476007)(2906002)(71200400001)(7696005)(26005)(5660300002)(44832011)(86362001)(9686003)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: ZIVyLbz3Cwx7O+XZhFpUANVpDObNwjgG6h/6Y4mX1bU1ImPY6Gl07JkgWmL+COQc9sS7mRaW/p2tHkf18GjKMeL7mvus1diNCQrkAUwZfaRbd3qdN67JtEw+Mr6aZ+8ZmyP7N3DZ6rGBYqiVLLz3ocX0CyLIKggB91TgtlKP5XaPvA6+lRG2mrAoKgtTizvQtloFmWzrvz5XgBI4loBUpADH3mE0dWzlnEc3Bq6ELgpOB6/zSVgqjkpdKh0+nobOgZbT/qfgoU89sa6paOdR7j3qsHlCACCgePC9+KGV7Jo9y57VtN/+q/6Nzfh7asnFF0T2BZhKYmud45PSlfdwPShrvJTLGCaMvfiFMzjuosFsZjPUpuqOYmsJbtN4eWsWMjKWtnAs+XUJRpbkCw0x8OOLgVQmqBZ/zkJheW25x4gMlJL4Mq2RVhTFLgNGYjE7naCGLT6qdlrrPGVVL9PRR1upDpD+tq1gbRdMIeuv5OhMKFN6BFQ2JxjEMNWq6JjJMBzfDcZIM++slURsnMHRFvyW8KIPBjrvYheS287fjiGIE8mczp92d15ySlLs/lvnHSWoWRgKGNf4G3c12iLyuj7FIZKwRMWX5qvjPmL7sBjWcYXvuIDIzPH/mifJuIoz4dRTiS1tFwhupi4intgKgKh03xYcRhM5ihnu5JQ7IG9cbNQ8NReB7wDmUdKJ9Vg6cNIideZF1AySyg+mBzEAy6V+9kJQ7woWPK9g2zJMdwI9HeT4k18sa3oUkk0KU6LHxuuJ0pG3jfJFFDtC67QzYctK881nwReGQBP4FpCNFRo6uz4Xgty+02AvaupLVOyi2GOeQR7pM5Yit6XWwsqhyTp0hdWrbqkZeFCKP2qO/ABRqVCDG6rvKmupN0+1Wxvlkbl1kRYOoOYdp1t3koFQU8eLmo3tBnpF+sQPr9lq6ldksltn5ZqTAGqDbucf4V9Djlb3SzpwHofXqR0XJBeMMVYgBThO6iG0ZmmuWTe80V8Hwl4El54O9r+Ie2aGvwDUHWvfS7DMI5i+ZeiENnxqWoeIkB68CxEL/eITSDF22F/v9RbL+Yh8+mXG0dMYE/o5jrX66VEsnkagtDh3e0cu0NYWxscmBwQo/RDPS08Q2r1v0SEQh8xa/JfplxFXuVZyk7EyBsO2F1uGOgfKO/9eVjIf91N7+DVMEUx581+n4si+ZQJgOCodl1CyBUqTJBcGloXgA8IsMrNKw14gEk4xrlWw2t30vEpOE5shduOA6p6KhflhWXBoTRT5xv8d616P1VTYhumjW54NOFM5IgNa+JuNcwOQdVxVCykQVB2FG4lXxXweeWiomjktFkoqHBDNLFSVvuYOo8Vb5sdrJbP9cdxKdHDRQJs9Xkj/eWthlvhw+vjr484uGHmPKsZiEDhZmu88wy9zmutj85qxXe6CDeHkUHzJhFfCGdAkahhKJcB1lQEzO/yAq+zrtjbQp6mI30WSTlPo21SENZSWI2Jpk3mzcb067Eyi0Nd4Llj1WAdMQ8G0GBjPGh33WZ8wvjP8trM47oqACTKANsiJZf7CLqnBV/Moh2AdPE0alQBAquFGbNBNRsI+eRyh8kqWalo3r6fmI4JZX4kY2LNoj6kpbw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e09184e-83e2-4aac-90ef-08d9c181a26b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 17:21:16.9223 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 79G7JfQvKEVCp4FqUoh7uu2OW9m9dt5/mSZXtszKFuz6B80TFJIeG9iiqOoO2fd7tnWkWwdJLXu4OZmwiQCU3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2520 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10201 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=823 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112170099 X-Proofpoint-ORIG-GUID: ymjSdM1CYsvTo_ZXb6I0td4oShbelytC X-Proofpoint-GUID: ymjSdM1CYsvTo_ZXb6I0td4oShbelytC X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > If someone does want to use the mouse for selecting > > and deleting text, Emacs's mouse-3 behavior is great. >=20 > Not great, but bizarre. No other app uses such method > because of its limitations:=20 What you call a limitation is a strength. > while the currently default `mouse-3' > only kills selected text, using the context menu from > `mouse-3' allows to select more operations on the region - That argument applies to almost any key. We could replace any number of "limited" key bindings by a menu popup that makes you choose an action. That argument doesn't hold water. At best, you can reduce it to the argument that if Emacs imposed a popup menu then it would be like other apps, which users might be used to. That abstract argument has never been enough, _on its own_, to redefine Emacs behavior. Better to give Emacs users themselves that choice. Even better to give them that choice on the fly, not just with a user option, by combining Emacs's great `mouse-3' behavior with the possibility of popping up a context menu. > kill the region without adding it to the kill ring, > kill the region with adding it to the kill ring, > add the region to the kill ring without killing it, > replace the region by pasting other text, etc. You can put anything on a mouse-3 menu, of course. And with the region active it makes sense for such a menu to be region-specific or at least include actions specific to the region. (Which is what `mouse3.el' does, of course.)=20 From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jan 2022 07:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16410212096480 (code B ref 52293); Sat, 01 Jan 2022 07:14:02 +0000 Received: (at 52293) by debbugs.gnu.org; 1 Jan 2022 07:13:29 +0000 Received: from localhost ([127.0.0.1]:57726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3Ya1-0001gS-FD for submit@debbugs.gnu.org; Sat, 01 Jan 2022 02:13:29 -0500 Received: from mail-pf1-f179.google.com ([209.85.210.179]:41578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3YZz-0001gA-PA for 52293@debbugs.gnu.org; Sat, 01 Jan 2022 02:13:28 -0500 Received: by mail-pf1-f179.google.com with SMTP id m1so25182162pfk.8 for <52293@debbugs.gnu.org>; Fri, 31 Dec 2021 23:13:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=rGfH7YRXGSgd+8mebuueqj5lM4yRKJw2Utm2uujgNdw=; b=peCWsPPYsOvO85DVb1fPbs1F42aUA9ELxH0AJzH0pewV2frPbaNVSk3lCDld2LASTR tJGLemc8n4nd+/XExtrNc9hrAGahXDUKMdhyFcuuRtKDlT6sONzhS2MADNKwfXH00pdo V1ZQvqDI9TJ5U8q0xE41NFdOnO0EpEb2t5N/0zLNJfLf6g1n8JP9d/+ZUKOwMWGGMd/P cPdfF+7pyFmLmf4cYQc7akdsSYx7p6ljgEw7j+6SbsLuX7CvoMySt0AoSA6/tlu0gvDv ED+o6egtMyJ8637GojNtF71FGdTok1HIkPIL467SBrvK1U5te88dO0cUIq2GFav6x3Bd 3Kig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=rGfH7YRXGSgd+8mebuueqj5lM4yRKJw2Utm2uujgNdw=; b=DzODuDCljg3fsDzWirbXoAoFf9SpJtoM469Pypa5Y4vlkLU+m76iEo1rvkRQukkULs DIU060CG9P4c9J1F7sbq07vBZoYAFLz4xdyysfWZlaXLe9aYXMOEYveUnszfb7h2MRmV WOG5T2Th0vRaLQti1l5s2wSiHbXo9POi1lFxE8mBF3lXSfbhI0OG/aIZ6WVV96YPzCX3 m7ota6R1ASjmv9XR+SNfJsIFn/dLnJrtUdu+UGPy9yW/AZVDi2+geajTdQP7iFiY1I6E vVoksRChSw9N9Zv1S55mVMtF8nTUTJq19wqj354pGt1TfTThpFgM5uXrsjMIfbAbz1qF dPKQ== X-Gm-Message-State: AOAM532JMeFWgaNcKdEJao0kJ/Yjo3uHIVfwEe1DHmTkxRjQjaqclYuC KxvWMaaX9wdewIQb1lArgqLd3m923cU= X-Google-Smtp-Source: ABdhPJyNLUH1zGzM446VPuzegwvu56pR2A4ThzD2TURHT1pIP7XonGa42wS3CfmCelu+3BndX8JdRQ== X-Received: by 2002:a65:5b4b:: with SMTP id y11mr33731696pgr.59.1641021201919; Fri, 31 Dec 2021 23:13:21 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c13sm32745357pfv.20.2021.12.31.23.13.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Dec 2021 23:13:21 -0800 (PST) References: <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <723c8965-31be-b636-beee-478fb77423ec@gmail.com> <86ee6egs8b.fsf@mail.linkov.net> From: Jim Porter Message-ID: Date: Fri, 31 Dec 2021 23:13:21 -0800 MIME-Version: 1.0 In-Reply-To: <86ee6egs8b.fsf@mail.linkov.net> Content-Type: multipart/mixed; boundary="------------0AA3EC602B9B39855CC18D99" Content-Language: en-US X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------0AA3EC602B9B39855CC18D99 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/15/2021 12:57 AM, Juri Linkov wrote: > I'm not sure if de-duplication is needed for other menus. Currently > de-duplication is used only to simplify creation of context menus. > But there is no indication that someone needed this for other menus. > Otherwise, they would report duplicate separators in other menus as a bug. Ok, we can worry about that another time. I've attached an updated patch that lets context-menu-functions add items to the beginning of the keymap as they currently do, while still removing consecutive separators correctly. Since this logic is a bit tricky, it could probably use an automated test or two, but before I write some, I wanted to check that the strategy I'm using seems reasonable. It's probably easiest to explain the logic by just pointing to the patch; I added several comments describing the behavior so that reviewers (and future readers) should be able to make sense of it. --------------0AA3EC602B9B39855CC18D99 Content-Type: text/plain; charset=UTF-8; name="0001-Prevent-further-cases-of-duplicated-separators-in-co.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Prevent-further-cases-of-duplicated-separators-in-co.pa"; filename*1="tch" RnJvbSAwMzEwZjkyNmI2MmZkNzQ5MzJlMzc2NmMwM2JkN2EzOTk3NGM0NTdiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMzEgRGVjIDIwMjEgMjM6MDQ6NTcgLTA4MDAKU3ViamVjdDogW1BB VENIXSBQcmV2ZW50IGZ1cnRoZXIgY2FzZXMgb2YgZHVwbGljYXRlZCBzZXBhcmF0b3JzIGlu IGNvbnRleHQKIG1lbnVzCgpJbiBzb21lIGNhc2VzLCBjb250ZXh0IG1lbnUgaXRlbXMgYXJl IGFkZGVkIGJlZm9yZSB0aGUgb3ZlcmFsbCBwcm9tcHQKc3RyaW5nLiAgVGhpcyBjb3VsZCBj YXVzZSBtdWx0aXBsZSBjb25zZWN1dGl2ZSBzZXBhcmF0b3JzIHRvIGFwcGVhciBpZgp0aGV5 ICJzdXJyb3VuZCIgdGhlIHByb21wdCBzdHJpbmcuCgoqIGxpc3AvbW91c2UuZWwgKGNvbnRl eHQtbWVudS1tYXApOiBJbXByb3ZlIHRoZSBkZS1kdXBsaWNhdGlvbiBsb2dpYwp0byBpZ25v cmUgbm9uLW1lbnUtaXRlbXMgd2hlbiBjaGVja2luZyBmb3IgY29uc2VjdXRpdmUgc2VwYXJh dG9ycy4KLS0tCiBsaXNwL21vdXNlLmVsIHwgMzEgKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvbW91c2UuZWwgYi9saXNwL21vdXNlLmVsCmluZGV4 IDExZmRkM2Y2MzkuLjQxY2ZmZjhkODIgMTAwNjQ0Ci0tLSBhL2xpc3AvbW91c2UuZWwKKysr IGIvbGlzcC9tb3VzZS5lbApAQCAtMzI5LDIwICszMjksMjcgQEAgY29udGV4dC1tZW51LW1h cAogCiAgICAgOzsgUmVtb3ZlIGR1cGxpY2F0ZSBzZXBhcmF0b3JzIGFzIHdlbGwgYXMgb25l cyBhdCB0aGUgYmVnaW5uaW5nIG9yCiAgICAgOzsgZW5kIG9mIHRoZSBtZW51LgotICAgIChs ZXQgKChsIG1lbnUpIHNhdy1maXJzdC1pdGVtKQorICAgIChsZXQgKChsIG1lbnUpIChyZW1v dmUtbmV4dC1zZXBhcmF0b3IgdCkpCiAgICAgICAod2hpbGUgKGFuZCAoY29uc3AgbCkKICAg ICAgICAgICAgICAgICAgIChjb25zcCAoY2RyIGwpKSkKLSAgICAgICAgOzsgSWYgdGhlIG5l eHQgaXRlbSBpcyBhIHNlcGFyYXRvciwgcmVtb3ZlIGl0IGlmIDEpIHdlIGhhdmVuJ3QKLSAg ICAgICAgOzsgc2VlbiBhbnkgb3RoZXIgaXRlbXMgeWV0LCBvciAyKSBpdCdzIGZvbGxvd2Vk IGJ5IGVpdGhlcgotICAgICAgICA7OyBhbm90aGVyIHNlcGFyYXRvciBvciB0aGUgZW5kIG9m IHRoZSBsaXN0LgotICAgICAgICAoaWYgKGFuZCAoZXF1YWwgKGNkci1zYWZlIChjYWRyIGwp KSBtZW51LWJhci1zZXBhcmF0b3IpCi0gICAgICAgICAgICAgICAgIChvciAobm90IHNhdy1m aXJzdC1pdGVtKQotICAgICAgICAgICAgICAgICAgICAgKG51bGwgKGNhZGRyIGwpKQotICAg ICAgICAgICAgICAgICAgICAgKGVxdWFsIChjZHItc2FmZSAoY2FkZHIgbCkpIG1lbnUtYmFy LXNlcGFyYXRvcikpKQotICAgICAgICAgICAgKHNldGNkciBsIChjZGRyIGwpKQotICAgICAg ICAgIDs7IFRoZSAiZmlyc3QgaXRlbSIgaXMgYW55IGNvbnMgY2VsbDsgdGhpcyBleGNsdWRl cyB0aGUKLSAgICAgICAgICA7OyBga2V5bWFwJyBzeW1ib2wgYW5kIHRoZSBtZW51IG5hbWUu Ci0gICAgICAgICAgKHdoZW4gKGNvbnNwIChjYWRyIGwpKSAoc2V0cSBzYXctZmlyc3QtaXRl bSB0KSkKKyAgICAgICAgKGlmIChlcXVhbCAoY2RyLXNhZmUgKGNhZHIgbCkpIG1lbnUtYmFy LXNlcGFyYXRvcikKKyAgICAgICAgICAgIChwcm9nbgorICAgICAgICAgICAgICA7OyBUaGUg bmV4dCBpdGVtIGlzIGEgc2VwYXJhdG9yLiAgUmVtb3ZlIGl0IGlmIHJlcXVlc3RlZAorICAg ICAgICAgICAgICA7OyBieSByZW1vdmUtbmV4dC1zZXBhcmF0b3Igb3IgaWYgaXQncyB0aGUg bGFzdCBpdGVtIGluCisgICAgICAgICAgICAgIDs7IHRoZSBsaXN0LgorICAgICAgICAgICAg ICAoaWYgKG9yIHJlbW92ZS1uZXh0LXNlcGFyYXRvcgorICAgICAgICAgICAgICAgICAgICAg IChudWxsIChjYWRkciBsKSkpCisgICAgICAgICAgICAgICAgICAoc2V0Y2RyIGwgKGNkZHIg bCkpCisgICAgICAgICAgICAgICAgKHNldHEgbCAoY2RyIGwpKSkKKyAgICAgICAgICAgICAg OzsgV2UganVzdCBzYXcgYSBzZXBhcmF0b3IuICBSZW1vdmUgYW55IGltbWVkaWF0ZWx5Cisg ICAgICAgICAgICAgIDs7IGZvbGxvd2luZyB0aGlzLgorICAgICAgICAgICAgICAoc2V0cSBy ZW1vdmUtbmV4dC1zZXBhcmF0b3IgdCkpCisgICAgICAgICAgOzsgSWYgdGhlIG5leHQgaXRl bSBpcyBhIGNvbnMgY2VsbCwgd2UgZm91bmQgYSBub24tc2VwYXJhdG9yCisgICAgICAgICAg OzsgaXRlbS4gIERvbid0IHJlbW92ZSB0aGUgbmV4dCBzZXBhcmF0b3Igd2Ugc2VlLiAgV2UK KyAgICAgICAgICA7OyBzcGVjaWZpY2FsbHkgY2hlY2sgZm9yIGNvbnMgY2VsbHMgdG8gYXZv aWQgdHJlYXRpbmcgdGhlCisgICAgICAgICAgOzsgb3ZlcmFsbCBwcm9tcHQgc3RyaW5nIGFz IGEgbWVudSBpdGVtLgorICAgICAgICAgICh3aGVuIChjb25zcCAoY2FkciBsKSkKKyAgICAg ICAgICAgIChzZXRxIHJlbW92ZS1uZXh0LXNlcGFyYXRvciBuaWwpKQogICAgICAgICAgIChz ZXRxIGwgKGNkciBsKSkpKSkKIAogICAgICh3aGVuIChmdW5jdGlvbnAgY29udGV4dC1tZW51 LWZpbHRlci1mdW5jdGlvbikKLS0gCjIuMjUuMQoK --------------0AA3EC602B9B39855CC18D99-- From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jan 2022 19:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16411517442986 (code B ref 52293); Sun, 02 Jan 2022 19:30:02 +0000 Received: (at 52293) by debbugs.gnu.org; 2 Jan 2022 19:29:04 +0000 Received: from localhost ([127.0.0.1]:33746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n46XQ-0000m4-75 for submit@debbugs.gnu.org; Sun, 02 Jan 2022 14:29:04 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:38279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n46XO-0000lW-A6 for 52293@debbugs.gnu.org; Sun, 02 Jan 2022 14:29:03 -0500 Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 167921BF203; Sun, 2 Jan 2022 19:28:54 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <723c8965-31be-b636-beee-478fb77423ec@gmail.com> <86ee6egs8b.fsf@mail.linkov.net> Date: Sun, 02 Jan 2022 21:27:37 +0200 In-Reply-To: (Jim Porter's message of "Fri, 31 Dec 2021 23:13:21 -0800") Message-ID: <86fsq63pli.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I've attached an updated patch that lets context-menu-functions add items > to the beginning of the keymap as they currently do, while still removing > consecutive separators correctly. Since this logic is a bit tricky, it > could probably use an automated test or two, but before I write some, > I wanted to check that the strategy I'm using seems reasonable. It's > probably easiest to explain the logic by just pointing to the patch; > I added several comments describing the behavior so that reviewers (and > future readers) should be able to make sense of it. Thanks, I suppose it's for master, not for the release branch? From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v4] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jan 2022 06:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.164119050014267 (code B ref 52293); Mon, 03 Jan 2022 06:15:02 +0000 Received: (at 52293) by debbugs.gnu.org; 3 Jan 2022 06:15:00 +0000 Received: from localhost ([127.0.0.1]:34033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4GcW-0003i2-39 for submit@debbugs.gnu.org; Mon, 03 Jan 2022 01:15:00 -0500 Received: from mail-pg1-f175.google.com ([209.85.215.175]:40790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4GcT-0003hm-Kr for 52293@debbugs.gnu.org; Mon, 03 Jan 2022 01:14:58 -0500 Received: by mail-pg1-f175.google.com with SMTP id l10so29374264pgm.7 for <52293@debbugs.gnu.org>; Sun, 02 Jan 2022 22:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=AMH2qrmk8hhObmcWKG1tXvMKPkUGh7Kc12Bx0qXG7gQ=; b=T2cbcllbsyxHOz6NuY8FzbebEokEzN8J2+a/1OS0FXIqoFJPuJs7QVFyWALFvlUae9 3BI8YRMjNzymTUeXnr5PJP+8kP4ypM92B+AqFPcwfvizGEfTSEpRsqGfOSr5J6VKqTuL O9S0X3ewBGCIhiNAzOOLtjE6JqB5BwYqmUr/W7UMrKsJkbmmKrT+USnJVqFD9Us+Wxzz c3mIALmss9kwLI17x6ZXFsRPiUFfm7X/37VO4uCAucDR7ZV3whh4ulEu1mlVQSDGn7sy NsyjnWZsVPGzY2B4dDrH98Jff0QLdXKeEKX5T2OnLEDQkgjHpSVPUuPkbiH9WNeKSL3l u5WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=AMH2qrmk8hhObmcWKG1tXvMKPkUGh7Kc12Bx0qXG7gQ=; b=q6TEKa26nBI378LqqiYxLJhRLQX/YGDPvkjCM2feg+RR1u2sAYpvaAmDKa6kKI/kR5 FhjFYoAuRZ3YOr3lvZGBMSIfRHCVxCZELQGe6xc2YKkFL0MR/DMMvtxmY3rFziF8cl7I X+eH3x1osh5P+/+nEL3HLh6nlliaETkKH6sxZFzEejoLH0TVwVGDTP12su50K+1x1+fT nNnjTSMY4DljxSTS39/8HzyogBMzpepic8eFEk8nTeBCZIYYWQCOWjlIiabSy8XBZR1c FZb6bnV+ztg2f++aTnNLwEx7WscDu+gK8/b9cOQbJfaCqnWlOEhb93vARO/dtoaC28i/ ZSBw== X-Gm-Message-State: AOAM531p558LriKrx3IikLqQJMP+ew4y1n20129uWPIBzQJUihOT4zQf 591IBga2J9NooxEqF2c8gLwb3MAS3DI= X-Google-Smtp-Source: ABdhPJy4ixScgP33/pfzC6YMbYqOcPFyfrU4rUp7ZeE/FUqQp368yucmoWmLX5k3ymxro141CaYgaA== X-Received: by 2002:a63:5d61:: with SMTP id o33mr39837400pgm.341.1641190491587; Sun, 02 Jan 2022 22:14:51 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b15sm38476970pfl.118.2022.01.02.22.14.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Jan 2022 22:14:50 -0800 (PST) References: <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <723c8965-31be-b636-beee-478fb77423ec@gmail.com> <86ee6egs8b.fsf@mail.linkov.net> <86fsq63pli.fsf@mail.linkov.net> From: Jim Porter Message-ID: Date: Sun, 2 Jan 2022 22:14:51 -0800 MIME-Version: 1.0 In-Reply-To: <86fsq63pli.fsf@mail.linkov.net> Content-Type: multipart/mixed; boundary="------------7C0D9B8458D468FAB89D2B2F" Content-Language: en-US X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------7C0D9B8458D468FAB89D2B2F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 1/2/2022 11:27 AM, Juri Linkov wrote: >> I've attached an updated patch that lets context-menu-functions add items >> to the beginning of the keymap as they currently do, while still removing >> consecutive separators correctly. Since this logic is a bit tricky, it >> could probably use an automated test or two, but before I write some, >> I wanted to check that the strategy I'm using seems reasonable. It's >> probably easiest to explain the logic by just pointing to the patch; >> I added several comments describing the behavior so that reviewers (and >> future readers) should be able to make sense of it. > > Thanks, I suppose it's for master, not for the release branch? Yeah, it's based on top of my previous patches that only landed on master, so the same applies for this one. I don't personally have an issue with if it merged to the release branch, but I also understand that we can't keep adding things to Emacs 28 forever. Attached is an updated patch with unit tests as well as a fix to the behavior from the previous version; in my last patch, it didn't delete the last separator in the menu if it was *before* the "Context Menu" overall prompt string. (This could happen if all the context-menu-functions *only* used `define-key'.) I've fixed that, though it did make the function a bit more complex. I've compensated for that with some more comments and what I hope are pretty thorough tests to make sure everything works as expected. --------------7C0D9B8458D468FAB89D2B2F Content-Type: text/plain; charset=UTF-8; name="0001-Prevent-further-cases-of-duplicated-separators-in-co.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Prevent-further-cases-of-duplicated-separators-in-co.pa"; filename*1="tch" RnJvbSBkYzJiMDRkNWYyMGVmODYxZTEzYjA4MjBhNDM3Nzk1MWNiNTI4YjUzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMiBKYW4gMjAyMiAyMjowODo1MiAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIFByZXZlbnQgZnVydGhlciBjYXNlcyBvZiBkdXBsaWNhdGVkIHNlcGFyYXRvcnMgaW4g Y29udGV4dAogbWVudXMKCkluIHNvbWUgY2FzZXMsIGNvbnRleHQgbWVudSBpdGVtcyBhcmUg YWRkZWQgYmVmb3JlIHRoZSBvdmVyYWxsIHByb21wdApzdHJpbmcuICBUaGlzIGNvdWxkIGNh dXNlIG11bHRpcGxlIGNvbnNlY3V0aXZlIHNlcGFyYXRvcnMgdG8gYXBwZWFyIGlmCnRoZXkg InN1cnJvdW5kIiB0aGUgcHJvbXB0IHN0cmluZy4KCiogbGlzcC9tb3VzZS5lbCAoY29udGV4 dC1tZW51LW1hcCk6IEltcHJvdmUgdGhlIGRlLWR1cGxpY2F0aW9uIGxvZ2ljCnRvIGlnbm9y ZSBub24tbWVudS1pdGVtcyB3aGVuIGNoZWNraW5nIGZvciBjb25zZWN1dGl2ZSBzZXBhcmF0 b3JzLgoKKiB0ZXN0L2xpc3AvbW91c2UtdGVzdHMuZWwKKGNvbnRleHQtbWVudS1tYXAtcmVt b3ZlLWNvbnNlY3V0aXZlLXNlcGFyYXRvcnMpCihjb250ZXh0LW1lbnUtbWFwLXJlbW92ZS1j b25zZWN1dGl2ZS1zZXBhcmF0b3JzKTogTmV3IHRlc3RzLgotLS0KIGxpc3AvbW91c2UuZWwg ICAgICAgICAgICB8ICAzNCArKysrLS0tLQogdGVzdC9saXNwL21vdXNlLXRlc3RzLmVsIHwg MTYyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBj aGFuZ2VkLCAxODMgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvbGlzcC9tb3VzZS5lbCBiL2xpc3AvbW91c2UuZWwKaW5kZXggMTFmZGQzZjYzOS4uNTBm YjExMzdlYyAxMDA2NDQKLS0tIGEvbGlzcC9tb3VzZS5lbAorKysgYi9saXNwL21vdXNlLmVs CkBAIC0zMjksMjEgKzMyOSwyOSBAQCBjb250ZXh0LW1lbnUtbWFwCiAKICAgICA7OyBSZW1v dmUgZHVwbGljYXRlIHNlcGFyYXRvcnMgYXMgd2VsbCBhcyBvbmVzIGF0IHRoZSBiZWdpbm5p bmcgb3IKICAgICA7OyBlbmQgb2YgdGhlIG1lbnUuCi0gICAgKGxldCAoKGwgbWVudSkgc2F3 LWZpcnN0LWl0ZW0pCisgICAgKGxldCAoKGwgbWVudSkgKGxhc3Qtc2F3LXNlcGFyYXRvciB0 KSkKICAgICAgICh3aGlsZSAoYW5kIChjb25zcCBsKQogICAgICAgICAgICAgICAgICAgKGNv bnNwIChjZHIgbCkpKQotICAgICAgICA7OyBJZiB0aGUgbmV4dCBpdGVtIGlzIGEgc2VwYXJh dG9yLCByZW1vdmUgaXQgaWYgMSkgd2UgaGF2ZW4ndAotICAgICAgICA7OyBzZWVuIGFueSBv dGhlciBpdGVtcyB5ZXQsIG9yIDIpIGl0J3MgZm9sbG93ZWQgYnkgZWl0aGVyCi0gICAgICAg IDs7IGFub3RoZXIgc2VwYXJhdG9yIG9yIHRoZSBlbmQgb2YgdGhlIGxpc3QuCi0gICAgICAg IChpZiAoYW5kIChlcXVhbCAoY2RyLXNhZmUgKGNhZHIgbCkpIG1lbnUtYmFyLXNlcGFyYXRv cikKLSAgICAgICAgICAgICAgICAgKG9yIChub3Qgc2F3LWZpcnN0LWl0ZW0pCi0gICAgICAg ICAgICAgICAgICAgICAobnVsbCAoY2FkZHIgbCkpCi0gICAgICAgICAgICAgICAgICAgICAo ZXF1YWwgKGNkci1zYWZlIChjYWRkciBsKSkgbWVudS1iYXItc2VwYXJhdG9yKSkpCi0gICAg ICAgICAgICAoc2V0Y2RyIGwgKGNkZHIgbCkpCi0gICAgICAgICAgOzsgVGhlICJmaXJzdCBp dGVtIiBpcyBhbnkgY29ucyBjZWxsOyB0aGlzIGV4Y2x1ZGVzIHRoZQotICAgICAgICAgIDs7 IGBrZXltYXAnIHN5bWJvbCBhbmQgdGhlIG1lbnUgbmFtZS4KLSAgICAgICAgICAod2hlbiAo Y29uc3AgKGNhZHIgbCkpIChzZXRxIHNhdy1maXJzdC1pdGVtIHQpKQotICAgICAgICAgIChz ZXRxIGwgKGNkciBsKSkpKSkKKyAgICAgICAgKGlmIChlcXVhbCAoY2RyLXNhZmUgKGNhZHIg bCkpIG1lbnUtYmFyLXNlcGFyYXRvcikKKyAgICAgICAgICAgIChwcm9nbgorICAgICAgICAg ICAgICA7OyBUaGUgbmV4dCBpdGVtIGlzIGEgc2VwYXJhdG9yLiAgUmVtb3ZlIGl0IGlmIHRo ZSBsYXN0CisgICAgICAgICAgICAgIDs7IGl0ZW0gd2Ugc2F3IHdhcyBhIHNlcGFyYXRvciB0 b28uCisgICAgICAgICAgICAgIChpZiBsYXN0LXNhdy1zZXBhcmF0b3IKKyAgICAgICAgICAg ICAgICAgIChzZXRjZHIgbCAoY2RkciBsKSkKKyAgICAgICAgICAgICAgICA7OyBJZiB3ZSBk aWRuJ3QgZGVsZXRlIHRoaXMgc2VwYXJhdG9yLCB1cGRhdGUgdGhlIGxhc3QKKyAgICAgICAg ICAgICAgICA7OyBzZXBhcmF0b3Igd2Ugc2F3IHRvIHRoaXMgb25lLgorICAgICAgICAgICAg ICAgIChzZXRxIGxhc3Qtc2F3LXNlcGFyYXRvciBsCisgICAgICAgICAgICAgICAgICAgICAg bCAoY2RyIGwpKSkpCisgICAgICAgICAgOzsgSWYgdGhlIG5leHQgaXRlbSBpcyBhIGNvbnMg Y2VsbCwgd2UgZm91bmQgYSBub24tc2VwYXJhdG9yCisgICAgICAgICAgOzsgaXRlbS4gIERv bid0IHJlbW92ZSB0aGUgbmV4dCBzZXBhcmF0b3Igd2Ugc2VlLiAgV2UKKyAgICAgICAgICA7 OyBzcGVjaWZpY2FsbHkgY2hlY2sgZm9yIGNvbnMgY2VsbHMgdG8gYXZvaWQgdHJlYXRpbmcg dGhlCisgICAgICAgICAgOzsgb3ZlcmFsbCBwcm9tcHQgc3RyaW5nIGFzIGEgbWVudSBpdGVt LgorICAgICAgICAgICh3aGVuIChjb25zcCAoY2FkciBsKSkKKyAgICAgICAgICAgIChzZXRx IGxhc3Qtc2F3LXNlcGFyYXRvciBuaWwpKQorICAgICAgICAgIChzZXRxIGwgKGNkciBsKSkp KQorICAgICAgOzsgSWYgdGhlIGxhc3QgaXRlbSB3ZSBzYXcgd2FzIGEgc2VwYXJhdG9yLCBy ZW1vdmUgaXQuCisgICAgICAod2hlbiAoY29uc3AgbGFzdC1zYXctc2VwYXJhdG9yKQorICAg ICAgICAoc2V0Y2RyIGxhc3Qtc2F3LXNlcGFyYXRvciAoY2RkciBsYXN0LXNhdy1zZXBhcmF0 b3IpKSkpCiAKICAgICAod2hlbiAoZnVuY3Rpb25wIGNvbnRleHQtbWVudS1maWx0ZXItZnVu Y3Rpb24pCiAgICAgICAoc2V0cSBtZW51IChmdW5jYWxsIGNvbnRleHQtbWVudS1maWx0ZXIt ZnVuY3Rpb24gbWVudSBjbGljaykpKQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL21vdXNlLXRl c3RzLmVsIGIvdGVzdC9saXNwL21vdXNlLXRlc3RzLmVsCmluZGV4IDU2NDExZDAzNjUuLjk2 MjA2Y2Q5ZjggMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9tb3VzZS10ZXN0cy5lbAorKysgYi90 ZXN0L2xpc3AvbW91c2UtdGVzdHMuZWwKQEAgLTUyLDUgKzUyLDE2NyBAQCBidWcyNjgxNi1t b3VzZS1mcmFtZS1tb3ZlbWVudAogICAgIChzaG91bGQgKGVxdWFsIChtb3VzZS1wb3NpdGlv bikKICAgICAgICAgICAgICAgICAgICAoY29ucyBmcmFtZSAoY29ucyAwIDApKSkpKSkKIAor KGVydC1kZWZ0ZXN0IGNvbnRleHQtbWVudS1tYXAtcmVtb3ZlLWNvbnNlY3V0aXZlLXNlcGFy YXRvcnMgKCkKKyAgIkNoZWNrIHRoYXQgYGNvbnRleHQtbWVudS1tYXAnIHJlbW92ZXMgY29u c2VjdXRpdmUgc2VwYXJhdG9ycy4iCisgIDs7IEJvdGggc2VwYXJhdG9ycyBhZnRlciB0aGUg b3ZlcmFsbCBwcm9tcHQgc3RyaW5nLgorICAobGV0ICgoY29udGV4dC1tZW51LWZ1bmN0aW9u cworICAgICAgICAgJygobGFtYmRhIChtZW51IF9jbGljaykKKyAgICAgICAgICAgICAoZGVm aW5lLWtleS1hZnRlciBtZW51IFtmb28taXRlbV0gJyhtZW51LWl0ZW0gIkZvbyIgaWRlbnRp dHkpKQorICAgICAgICAgICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW3NlcGFyYXRvci0x XSBtZW51LWJhci1zZXBhcmF0b3IpCisgICAgICAgICAgICAgKGRlZmluZS1rZXktYWZ0ZXIg bWVudSBbc2VwYXJhdG9yLTJdIG1lbnUtYmFyLXNlcGFyYXRvcikKKyAgICAgICAgICAgICAo ZGVmaW5lLWtleS1hZnRlciBtZW51IFtiYXItaXRlbV0gJyhtZW51LWl0ZW0gIkJhciIgaWRl bnRpdHkpKQorICAgICAgICAgICAgIG1lbnUpKSkpCisgICAgKHNob3VsZCAoZXF1YWwgYChr ZXltYXAKKyAgICAgICAgICAgICAgICAgICAgICJDb250ZXh0IE1lbnUiCisgICAgICAgICAg ICAgICAgICAgICAoZm9vLWl0ZW0gbWVudS1pdGVtICJGb28iIGlkZW50aXR5KQorICAgICAg ICAgICAgICAgICAgICAgKHNlcGFyYXRvci0xIC4gLG1lbnUtYmFyLXNlcGFyYXRvcikKKyAg ICAgICAgICAgICAgICAgICAgIChiYXItaXRlbSBtZW51LWl0ZW0gIkJhciIgaWRlbnRpdHkp KQorICAgICAgICAgICAgICAgICAgIChjb250ZXh0LW1lbnUtbWFwKSkpKQorICA7OyBCb3Ro IHNlcGFyYXRvcnMgYmVmb3JlIHRoZSBvdmVyYWxsIHByb21wdCBzdHJpbmcuCisgIChsZXQg KChjb250ZXh0LW1lbnUtZnVuY3Rpb25zCisgICAgICAgICAnKChsYW1iZGEgKG1lbnUgX2Ns aWNrKQorICAgICAgICAgICAgIChkZWZpbmUta2V5IG1lbnUgW2Jhci1pdGVtXSAnKG1lbnUt aXRlbSAiQmFyIiBpZGVudGl0eSkpCisgICAgICAgICAgICAgKGRlZmluZS1rZXkgbWVudSBb c2VwYXJhdG9yLTJdIG1lbnUtYmFyLXNlcGFyYXRvcikKKyAgICAgICAgICAgICAoZGVmaW5l LWtleSBtZW51IFtzZXBhcmF0b3ItMV0gbWVudS1iYXItc2VwYXJhdG9yKQorICAgICAgICAg ICAgIChkZWZpbmUta2V5IG1lbnUgW2Zvby1pdGVtXSAnKG1lbnUtaXRlbSAiRm9vIiBpZGVu dGl0eSkpCisgICAgICAgICAgICAgbWVudSkpKSkKKyAgICAoc2hvdWxkIChlcXVhbCBgKGtl eW1hcAorICAgICAgICAgICAgICAgICAgICAgKGZvby1pdGVtIG1lbnUtaXRlbSAiRm9vIiBp ZGVudGl0eSkKKyAgICAgICAgICAgICAgICAgICAgIChzZXBhcmF0b3ItMSAuICxtZW51LWJh ci1zZXBhcmF0b3IpCisgICAgICAgICAgICAgICAgICAgICAoYmFyLWl0ZW0gbWVudS1pdGVt ICJCYXIiIGlkZW50aXR5KQorICAgICAgICAgICAgICAgICAgICAgIkNvbnRleHQgTWVudSIp CisgICAgICAgICAgICAgICAgICAgKGNvbnRleHQtbWVudS1tYXApKSkpCisgIDs7IEZpcnN0 IHNlcGFyYXRvciBiZWZvcmUgYW5kIHNlY29uZCBzZXBhcmF0b3IgYWZ0ZXIgdGhlIG92ZXJh bGwKKyAgOzsgcHJvbXB0IHN0cmluZy4KKyAgKGxldCAoKGNvbnRleHQtbWVudS1mdW5jdGlv bnMKKyAgICAgICAgICcoKGxhbWJkYSAobWVudSBfY2xpY2spCisgICAgICAgICAgICAgKGRl ZmluZS1rZXktYWZ0ZXIgbWVudSBbc2VwYXJhdG9yLTJdIG1lbnUtYmFyLXNlcGFyYXRvcikK KyAgICAgICAgICAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtiYXItaXRlbV0gJyhtZW51 LWl0ZW0gIkJhciIgaWRlbnRpdHkpKQorICAgICAgICAgICAgIChkZWZpbmUta2V5IG1lbnUg W3NlcGFyYXRvci0xXSBtZW51LWJhci1zZXBhcmF0b3IpCisgICAgICAgICAgICAgKGRlZmlu ZS1rZXkgbWVudSBbZm9vLWl0ZW1dICcobWVudS1pdGVtICJGb28iIGlkZW50aXR5KSkKKyAg ICAgICAgICAgICBtZW51KSkpKQorICAgIChzaG91bGQgKGVxdWFsIGAoa2V5bWFwCisgICAg ICAgICAgICAgICAgICAgICAoZm9vLWl0ZW0gbWVudS1pdGVtICJGb28iIGlkZW50aXR5KQor ICAgICAgICAgICAgICAgICAgICAgKHNlcGFyYXRvci0xIC4gLG1lbnUtYmFyLXNlcGFyYXRv cikKKyAgICAgICAgICAgICAgICAgICAgICJDb250ZXh0IE1lbnUiCisgICAgICAgICAgICAg ICAgICAgICAoYmFyLWl0ZW0gbWVudS1pdGVtICJCYXIiIGlkZW50aXR5KSkKKyAgICAgICAg ICAgICAgICAgICAoY29udGV4dC1tZW51LW1hcCkpKSkKKyAgOzsgVGhyZWUgY29uc2VjdXRp dmUgc2VwYXJhdG9ycy4KKyAgKGxldCAoKGNvbnRleHQtbWVudS1mdW5jdGlvbnMKKyAgICAg ICAgICcoKGxhbWJkYSAobWVudSBfY2xpY2spCisgICAgICAgICAgICAgKGRlZmluZS1rZXkt YWZ0ZXIgbWVudSBbZm9vLWl0ZW1dICcobWVudS1pdGVtICJGb28iIGlkZW50aXR5KSkKKyAg ICAgICAgICAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtzZXBhcmF0b3ItMV0gbWVudS1i YXItc2VwYXJhdG9yKQorICAgICAgICAgICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW3Nl cGFyYXRvci0yXSBtZW51LWJhci1zZXBhcmF0b3IpCisgICAgICAgICAgICAgKGRlZmluZS1r ZXktYWZ0ZXIgbWVudSBbc2VwYXJhdG9yLTNdIG1lbnUtYmFyLXNlcGFyYXRvcikKKyAgICAg ICAgICAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtiYXItaXRlbV0gJyhtZW51LWl0ZW0g IkJhciIgaWRlbnRpdHkpKQorICAgICAgICAgICAgIG1lbnUpKSkpCisgICAgKHNob3VsZCAo ZXF1YWwgYChrZXltYXAKKyAgICAgICAgICAgICAgICAgICAgICJDb250ZXh0IE1lbnUiCisg ICAgICAgICAgICAgICAgICAgICAoZm9vLWl0ZW0gbWVudS1pdGVtICJGb28iIGlkZW50aXR5 KQorICAgICAgICAgICAgICAgICAgICAgKHNlcGFyYXRvci0xIC4gLG1lbnUtYmFyLXNlcGFy YXRvcikKKyAgICAgICAgICAgICAgICAgICAgIChiYXItaXRlbSBtZW51LWl0ZW0gIkJhciIg aWRlbnRpdHkpKQorICAgICAgICAgICAgICAgICAgIChjb250ZXh0LW1lbnUtbWFwKSkpKSkK KworKGVydC1kZWZ0ZXN0IGNvbnRleHQtbWVudS1tYXAtcmVtb3ZlLXNlcGFyYXRvcnMtYXQt YmVnaW5uaW5nLW9yLWVuZCAoKQorICAiQ2hlY2sgdGhhdCBgY29udGV4dC1tZW51LW1hcCcg cmVtb3ZlcyBzZXBhcmF0b3JzIGF0IHRoZQorYmVnaW5uaW5nIG9yIGVuZCBvZiB0aGUgbWVu dS4iCisgIDs7IE1lbnVzIHdpdGggb25seSBzZXBhcmF0b3JzLgorICAobGV0ICgodGVzdC1m dW5jdGlvbnMKKyAgICAgICAgICcoOzsgU2VwYXJhdG9yIGJlZm9yZSB0aGUgb3ZlcmFsbCBw cm9tcHQgc3RyaW5nLgorICAgICAgICAgICAobGFtYmRhIChtZW51IF9jbGljaykKKyAgICAg ICAgICAgICAoZGVmaW5lLWtleSBtZW51IFtzZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRv cikKKyAgICAgICAgICAgICBtZW51KQorICAgICAgICAgICA7OyBTZXBhcmF0b3IgYWZ0ZXIg dGhlIG92ZXJhbGwgcHJvbXB0IHN0cmluZy4KKyAgICAgICAgICAgKGxhbWJkYSAobWVudSBf Y2xpY2spCisgICAgICAgICAgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbc2VwYXJhdG9y XSBtZW51LWJhci1zZXBhcmF0b3IpCisgICAgICAgICAgICAgbWVudSkKKyAgICAgICAgICAg OzsgQmVnaW4gYW5kIGVuZCBzZXBhcmF0b3JzIGJlZm9yZSB0aGUgb3ZlcmFsbCBwcm9tcHQg c3RyaW5nLgorICAgICAgICAgICAobGFtYmRhIChtZW51IF9jbGljaykKKyAgICAgICAgICAg ICAoZGVmaW5lLWtleSBtZW51IFtlbmQtc2VwYXJhdG9yXSBtZW51LWJhci1zZXBhcmF0b3Ip CisgICAgICAgICAgICAgKGRlZmluZS1rZXkgbWVudSBbYmVnaW4tc2VwYXJhdG9yXSBtZW51 LWJhci1zZXBhcmF0b3IpCisgICAgICAgICAgICAgbWVudSkKKyAgICAgICAgICAgOzsgQmVn aW4gYW5kIGVuZCBzZXBhcmF0b3JzIGFmdGVyIHRoZSBvdmVyYWxsIHByb21wdCBzdHJpbmcu CisgICAgICAgICAgIChsYW1iZGEgKG1lbnUgX2NsaWNrKQorICAgICAgICAgICAgIChkZWZp bmUta2V5LWFmdGVyIG1lbnUgW2JlZ2luLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9y KQorICAgICAgICAgICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW2VuZC1zZXBhcmF0b3Jd IG1lbnUtYmFyLXNlcGFyYXRvcikKKyAgICAgICAgICAgICBtZW51KQorICAgICAgICAgICA7 OyBCZWdpbiBzZXBhcmF0b3IgYmVmb3JlIGFuZCBlbmQgc2VwYXJhdG9yIGFmdGVyIHRoZQor ICAgICAgICAgICA7OyBvdmVyYWxsIHByb21wdCBzdHJpbmcuCisgICAgICAgICAgIChsYW1i ZGEgKG1lbnUgX2NsaWNrKQorICAgICAgICAgICAgIChkZWZpbmUta2V5IG1lbnUgW2JlZ2lu LXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yKQorICAgICAgICAgICAgIChkZWZpbmUt a2V5LWFmdGVyIG1lbnUgW2VuZC1zZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRvcikKKyAg ICAgICAgICAgICBtZW51KSkpKQorICAgIChkb2xpc3QgKGZ1biB0ZXN0LWZ1bmN0aW9ucykK KyAgICAgIChsZXQgKChjb250ZXh0LW1lbnUtZnVuY3Rpb25zIChsaXN0IGZ1bikpKQorICAg ICAgICAoc2hvdWxkIChlcXVhbCAnKGtleW1hcCAiQ29udGV4dCBNZW51IikKKyAgICAgICAg ICAgICAgICAgICAgICAgKGNvbnRleHQtbWVudS1tYXApKSkpKSkKKyAgOzsgTWVudXMgd2l0 aCBzZXBhcmF0b3JzIGF0IGJlZ2lubmluZyBhbmQvb3IgZW5kIHdpdGggYSBtZW51LWl0ZW0K KyAgOzsgYmVmb3JlIHRoZSBwcm9tcHQgc3RyaW5nLgorICAobGV0ICgodGVzdC1mdW5jdGlv bnMKKyAgICAgICAgICcoOzsgU2VwYXJhdG9yIGJlZm9yZSB0aGUgb3ZlcmFsbCBwcm9tcHQg c3RyaW5nIGFuZCB0aGUgbWVudS1pdGVtLgorICAgICAgICAgICAobGFtYmRhIChtZW51IF9j bGljaykKKyAgICAgICAgICAgICAoZGVmaW5lLWtleSBtZW51IFtmb28taXRlbV0gJyhtZW51 LWl0ZW0gIkZvbyIgaWRlbnRpdHkpKQorICAgICAgICAgICAgIChkZWZpbmUta2V5IG1lbnUg W3NlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yKQorICAgICAgICAgICAgIG1lbnUpCisg ICAgICAgICAgIDs7IFNlcGFyYXRvciBiZWZvcmUgdGhlIG92ZXJhbGwgcHJvbXB0IHN0cmlu ZywgYnV0IGFmdGVyCisgICAgICAgICAgIDs7IHRoZSBtZW51LWl0ZW0uCisgICAgICAgICAg IChsYW1iZGEgKG1lbnUgX2NsaWNrKQorICAgICAgICAgICAgIChkZWZpbmUta2V5IG1lbnUg W3NlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yKQorICAgICAgICAgICAgIChkZWZpbmUt a2V5IG1lbnUgW2Zvby1pdGVtXSAnKG1lbnUtaXRlbSAiRm9vIiBpZGVudGl0eSkpCisgICAg ICAgICAgICAgbWVudSkKKyAgICAgICAgICAgOzsgU2VwYXJhdG9yIGF0IHRoZSBlbmQuCisg ICAgICAgICAgIChsYW1iZGEgKG1lbnUgX2NsaWNrKQorICAgICAgICAgICAgIChkZWZpbmUt a2V5IG1lbnUgW2Zvby1pdGVtXSAnKG1lbnUtaXRlbSAiRm9vIiBpZGVudGl0eSkpCisgICAg ICAgICAgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbc2VwYXJhdG9yXSBtZW51LWJhci1z ZXBhcmF0b3IpCisgICAgICAgICAgICAgbWVudSkKKyAgICAgICAgICAgOzsgQmVnaW4gc2Vw YXJhdG9yIGJlZm9yZSBhbmQgZW5kIHNlcGFyYXRvciBhZnRlciB0aGUKKyAgICAgICAgICAg Ozsgb3ZlcmFsbCBwcm9tcHQgc3RyaW5nLgorICAgICAgICAgICAobGFtYmRhIChtZW51IF9j bGljaykKKyAgICAgICAgICAgICAoZGVmaW5lLWtleSBtZW51IFtmb28taXRlbV0gJyhtZW51 LWl0ZW0gIkZvbyIgaWRlbnRpdHkpKQorICAgICAgICAgICAgIChkZWZpbmUta2V5IG1lbnUg W2JlZ2luLXNlcGFyYXRvcl0gbWVudS1iYXItc2VwYXJhdG9yKQorICAgICAgICAgICAgIChk ZWZpbmUta2V5LWFmdGVyIG1lbnUgW2VuZC1zZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRv cikKKyAgICAgICAgICAgICBtZW51KSkpKQorICAgIChkb2xpc3QgKGZ1biB0ZXN0LWZ1bmN0 aW9ucykKKyAgICAgIChsZXQgKChjb250ZXh0LW1lbnUtZnVuY3Rpb25zIChsaXN0IGZ1bikp KQorICAgICAgICAoc2hvdWxkIChlcXVhbCAnKGtleW1hcCAoZm9vLWl0ZW0gbWVudS1pdGVt ICJGb28iIGlkZW50aXR5KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiQ29u dGV4dCBNZW51IikKKyAgICAgICAgICAgICAgICAgICAgICAgKGNvbnRleHQtbWVudS1tYXAp KSkpKSkKKyAgOzsgTWVudXMgd2l0aCBzZXBhcmF0b3JzIGF0IGJlZ2lubmluZyBhbmQvb3Ig ZW5kIHdpdGggYSBtZW51LWl0ZW0KKyAgOzsgYWZ0ZXIgdGhlIHByb21wdCBzdHJpbmcuCisg IChsZXQgKCh0ZXN0LWZ1bmN0aW9ucworICAgICAgICAgJyg7OyBTZXBhcmF0b3IgYmVmb3Jl IHRoZSBvdmVyYWxsIHByb21wdCBzdHJpbmcuCisgICAgICAgICAgIChsYW1iZGEgKG1lbnUg X2NsaWNrKQorICAgICAgICAgICAgIChkZWZpbmUta2V5IG1lbnUgW3NlcGFyYXRvcl0gbWVu dS1iYXItc2VwYXJhdG9yKQorICAgICAgICAgICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUg W2Zvby1pdGVtXSAnKG1lbnUtaXRlbSAiRm9vIiBpZGVudGl0eSkpCisgICAgICAgICAgICAg bWVudSkKKyAgICAgICAgICAgOzsgU2VwYXJhdG9yIGFmdGVyIHRoZSBvdmVyYWxsIHByb21w dCBzdHJpbmcsIGJ1dCBiZWZvcmUKKyAgICAgICAgICAgOzsgdGhlIG1lbnUtaXRlbS4KKyAg ICAgICAgICAgKGxhbWJkYSAobWVudSBfY2xpY2spCisgICAgICAgICAgICAgKGRlZmluZS1r ZXktYWZ0ZXIgbWVudSBbc2VwYXJhdG9yXSBtZW51LWJhci1zZXBhcmF0b3IpCisgICAgICAg ICAgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbZm9vLWl0ZW1dICcobWVudS1pdGVtICJG b28iIGlkZW50aXR5KSkKKyAgICAgICAgICAgICBtZW51KQorICAgICAgICAgICA7OyBTZXBh cmF0b3IgYXQgdGhlIGVuZC4KKyAgICAgICAgICAgKGxhbWJkYSAobWVudSBfY2xpY2spCisg ICAgICAgICAgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbZm9vLWl0ZW1dICcobWVudS1p dGVtICJGb28iIGlkZW50aXR5KSkKKyAgICAgICAgICAgICAoZGVmaW5lLWtleS1hZnRlciBt ZW51IFtzZXBhcmF0b3JdIG1lbnUtYmFyLXNlcGFyYXRvcikKKyAgICAgICAgICAgICBtZW51 KQorICAgICAgICAgICA7OyBCZWdpbiBhbmQgZW5kIHNlcGFyYXRvcnMgYWZ0ZXIgdGhlIG92 ZXJhbGwgcHJvbXB0IHN0cmluZy4KKyAgICAgICAgICAgKGxhbWJkYSAobWVudSBfY2xpY2sp CisgICAgICAgICAgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWVudSBbYmVnaW4tc2VwYXJhdG9y XSBtZW51LWJhci1zZXBhcmF0b3IpCisgICAgICAgICAgICAgKGRlZmluZS1rZXktYWZ0ZXIg bWVudSBbZm9vLWl0ZW1dICcobWVudS1pdGVtICJGb28iIGlkZW50aXR5KSkKKyAgICAgICAg ICAgICAoZGVmaW5lLWtleS1hZnRlciBtZW51IFtlbmQtc2VwYXJhdG9yXSBtZW51LWJhci1z ZXBhcmF0b3IpCisgICAgICAgICAgICAgbWVudSkKKyAgICAgICAgICAgOzsgQmVnaW4gc2Vw YXJhdG9yIGJlZm9yZSBhbmQgZW5kIHNlcGFyYXRvciBhZnRlciB0aGUKKyAgICAgICAgICAg Ozsgb3ZlcmFsbCBwcm9tcHQgc3RyaW5nLgorICAgICAgICAgICAobGFtYmRhIChtZW51IF9j bGljaykKKyAgICAgICAgICAgICAoZGVmaW5lLWtleSBtZW51IFtiZWdpbi1zZXBhcmF0b3Jd IG1lbnUtYmFyLXNlcGFyYXRvcikKKyAgICAgICAgICAgICAoZGVmaW5lLWtleS1hZnRlciBt ZW51IFtmb28taXRlbV0gJyhtZW51LWl0ZW0gIkZvbyIgaWRlbnRpdHkpKQorICAgICAgICAg ICAgIChkZWZpbmUta2V5LWFmdGVyIG1lbnUgW2VuZC1zZXBhcmF0b3JdIG1lbnUtYmFyLXNl cGFyYXRvcikKKyAgICAgICAgICAgICBtZW51KSkpKQorICAgIChkb2xpc3QgKGZ1biB0ZXN0 LWZ1bmN0aW9ucykKKyAgICAgIChsZXQgKChjb250ZXh0LW1lbnUtZnVuY3Rpb25zIChsaXN0 IGZ1bikpKQorICAgICAgICAoc2hvdWxkIChlcXVhbCAnKGtleW1hcCAiQ29udGV4dCBNZW51 IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZm9vLWl0ZW0gbWVudS1pdGVt ICJGb28iIGlkZW50aXR5KSkKKyAgICAgICAgICAgICAgICAgICAgICAgKGNvbnRleHQtbWVu dS1tYXApKSkpKSkpCiAKIDs7OyBtb3VzZS10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuMjUu MQoK --------------7C0D9B8458D468FAB89D2B2F-- From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v4] Prevent further cases of duplicated separators in context menus Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jan 2022 08:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.164128442120981 (code B ref 52293); Tue, 04 Jan 2022 08:21:02 +0000 Received: (at 52293) by debbugs.gnu.org; 4 Jan 2022 08:20:21 +0000 Received: from localhost ([127.0.0.1]:36978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4f3N-0005SJ-80 for submit@debbugs.gnu.org; Tue, 04 Jan 2022 03:20:21 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:56627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4f3K-0005Rv-0l; Tue, 04 Jan 2022 03:20:19 -0500 Received: (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 6E5D740007; Tue, 4 Jan 2022 08:20:09 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <723c8965-31be-b636-beee-478fb77423ec@gmail.com> <86ee6egs8b.fsf@mail.linkov.net> <86fsq63pli.fsf@mail.linkov.net> Date: Tue, 04 Jan 2022 10:19:13 +0200 In-Reply-To: (Jim Porter's message of "Sun, 2 Jan 2022 22:14:51 -0800") Message-ID: <86zgobgbge.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 52293 29.0.50 thanks >>> I've attached an updated patch that lets context-menu-functions add items >>> to the beginning of the keymap as they currently do, while still removing >>> consecutive separators correctly. Since this logic is a bit tricky, it >>> could probably use an automated test or two, but before I write some, >>> I wanted to check that the strategy I'm using seems reasonable. It's >>> probably easiest to explain the logic by just pointing to the patch; >>> I added several comments describing the behavior so that reviewers (and >>> future readers) should be able to make sense of it. >> Thanks, I suppose it's for master, not for the release branch? > > Yeah, it's based on top of my previous patches that only landed on master, > so the same applies for this one. I don't personally have an issue with if > it merged to the release branch, but I also understand that we can't keep > adding things to Emacs 28 forever. > > Attached is an updated patch with unit tests as well as a fix to the > behavior from the previous version; in my last patch, it didn't delete the > last separator in the menu if it was *before* the "Context Menu" overall > prompt string. (This could happen if all the context-menu-functions *only* > used `define-key'.) > > I've fixed that, though it did make the function a bit more complex. I've > compensated for that with some more comments and what I hope are pretty > thorough tests to make sure everything works as expected. Thank you for the fix and for the unit tests. Now pushed to master. It seems this bug report can be closed now. If you have more patches, it can be reopened. From unknown Sun Jun 22 04:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52293: 29.0.50; [PATCH v4] Prevent further cases of duplicated separators in context menus Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jan 2022 21:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16413308495191 (code B ref 52293); Tue, 04 Jan 2022 21:15:02 +0000 Received: (at 52293) by debbugs.gnu.org; 4 Jan 2022 21:14:09 +0000 Received: from localhost ([127.0.0.1]:38892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4r8D-0001Le-Ac for submit@debbugs.gnu.org; Tue, 04 Jan 2022 16:14:09 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:53234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4r8B-0001LE-4t for 52293@debbugs.gnu.org; Tue, 04 Jan 2022 16:14:07 -0500 Received: by mail-pj1-f52.google.com with SMTP id co15so32295261pjb.2 for <52293@debbugs.gnu.org>; Tue, 04 Jan 2022 13:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=T7GxOwKRl1duAWX3V6RJA2ruAiV24CiNZhhDMH88LLM=; b=hROhByrxWleORAbO+CVVnZOUkeyPenhoSDygFz0+JOu/1xrThECmO1+TBPVxfP2Ef7 WN6kufH8cN+xMJtxnj26p2yZ/GAxjugvtO5CAKU2gcfdtZfGwqbV7KELKaTBAveIhryU CVb98gyMj5F8uboeR5/eqhne6aXdMnHB30f18cTyyMSR/r+UUSA/HPSeUYb35OrViUWD fqz7JAyV9u/5wB/ijOm9u1l68kS7/gzn14CvKO869mwcAgIJ9DsDzya2NzlPpwQdwyWX +60kqi+8u9X92M5D6C2O1EZSkeHrg2AilbcN8QdjGe70uxAkup43Ed+QoQDQSrnsLZZO 9hNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=T7GxOwKRl1duAWX3V6RJA2ruAiV24CiNZhhDMH88LLM=; b=7/Cyn9nOwZ0Bfboq+DbeqTpGdAkO2g/aqqXoCXoxY6dtwixbiujtGYZ+HHC8ovUM4+ C6CdSO+faHCS9uzWAD9thgvakv1fSJF+Cj8KM0+/Lo54d3DkruR0KNAnwK9BtNzCgIYZ g0KayJXO7q4xr8hIWa80jbsZuj/5FreKqgOHTNqdGzFLfttDNdDs935TJ7cTF34X+6o8 vMQgIMY3o1SIfbg//cJ4EnPsXedufe662TZc/JZlQ8CNToYlx+y14yDRfq5kst9iMmkg jjZK6PWHn7O11lWo9K6RWz8V8xUxTW4U8iVFuBJGF/RUsIR6SeL5wQlHclGm8LWZcGtA ROQw== X-Gm-Message-State: AOAM533sJ/yuzlQJ5RE0uQrn+uLbMUUTG5CW/p1R0BSYgmab8C7X3pft vzxYtLVh5cJzX89YadwaDSBgLcUPXZw= X-Google-Smtp-Source: ABdhPJwvvTlzdRt1+nq7GK34JajyACqt95JatUJb6HcwVsTaePeHB2qHpzC0GkZ1TvorodsCES6UbA== X-Received: by 2002:a17:902:ec92:b0:149:49e8:ee56 with SMTP id x18-20020a170902ec9200b0014949e8ee56mr51637929plg.65.1641330841606; Tue, 04 Jan 2022 13:14:01 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id nl16sm240579pjb.22.2022.01.04.13.14.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 13:14:01 -0800 (PST) References: <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> <723c8965-31be-b636-beee-478fb77423ec@gmail.com> <86ee6egs8b.fsf@mail.linkov.net> <86fsq63pli.fsf@mail.linkov.net> <86zgobgbge.fsf@mail.linkov.net> From: Jim Porter Message-ID: Date: Tue, 4 Jan 2022 13:14:00 -0800 MIME-Version: 1.0 In-Reply-To: <86zgobgbge.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/4/2022 12:19 AM, Juri Linkov wrote: > Thank you for the fix and for the unit tests. Now pushed to master. > It seems this bug report can be closed now. If you have more patches, > it can be reopened. Thanks for pushing the patch. Assuming I didn't introduce any new bugs, I don't think I'll have any more patches for this issue, so I agree that this report can be closed.