GNU bug report logs - #52286
28.0.90; [PATCH] Be consistent in naming of separators in context menu

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 52286 <at> debbugs.gnu.org
Subject: bug#52286: 28.0.90; [PATCH] Be consistent in naming of separators in context menu
Date: Sat, 15 Jan 2022 20:57:39 +0200

> It's not just for `elisp-mode'; any mode (or other third-party code) may
> want to insert context menu items in a certain spot. `middle-separator'
> follows the naming convention I recommend, but a hypothetical mode might
> want to insert a new item just after the separator for the Undo
> section. However, that's currently named `separator-undo' on master, so it
> can be confusing to remember the difference in naming between these two
> cases:
>
>   (define-key-after menu [my-separator] menu-bar-separator
>     'middle-separator)
>
>   (define-key-after menu [my-separator] menu-bar-separator
>     'separator-undo)

If it's too late to push this to the release branch,
then this definitely can't be done after the release.
So probably this bug report should be closed?

Meanwhile, I noticed another inconsistency
where context menus for some modes are named
with the -mode suffix, and some without it.

With `-mode':

  lisp/help-mode.el
  (defun help-mode-context-menu (menu click)

  lisp/textmodes/text-mode.el
  (defun text-mode-context-menu (menu click)

Without `-mode':

  lisp/progmodes/prog-mode.el
  (defun prog-context-menu (menu click)

  lisp/progmodes/elisp-mode.el
  (defun elisp-context-menu (menu click)

Maybe it's too late to fix this inconsistency too?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.