GNU bug report logs - #52281
28.0.90; batch-byte-compile breaking up warnings in batch mode

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 52281 <at> debbugs.gnu.org
Subject: bug#52281: 28.0.90; batch-byte-compile breaking up warnings in batch mode
Date: Sat, 04 Dec 2021 20:59:13 +0100

Philipp Stephani <p.stephani2 <at> gmail.com> writes:

> This is inconsistent, and causes parsers (such as Emacs's compilation
> mode) to incorrectly parse these messages.  I think messages in batch
> mode should never be broken up.

The following should fix the issue:

diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el
index 36b275e2d3..1d061364a0 100644
--- a/lisp/emacs-lisp/warnings.el
+++ b/lisp/emacs-lisp/warnings.el
@@ -307,7 +307,9 @@ display-warning
                                'type 'warning-suppress-log-warning
                                'warning-type type))
               (funcall newline)
-	      (when (and warning-fill-prefix (not (string-search "\n" message)))
+	      (when (and warning-fill-prefix
+                         (not (string-search "\n" message))
+                         (not noninteractive))
 		(let ((fill-prefix warning-fill-prefix)
 		      (fill-column warning-fill-column))
 		  (fill-region start (point))))

Does anybody have an opinion here? 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.