GNU bug report logs - #52260
Fix compilation error in feature/pgtk branch

Previous Next

Package: emacs;

Reported by: Koen van Greevenbroek <koen_devel <at> posteo.net>

Date: Fri, 3 Dec 2021 14:23:02 UTC

Severity: normal

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Koen van Greevenbroek <koen_devel <at> posteo.net>
To: 52260 <at> debbugs.gnu.org
Subject: bug#52260: Fix compilation error in feature/pgtk branch
Date: Fri, 03 Dec 2021 09:20:53 +0000

Hi,

I was just trying to compile the latest version of the pgtk branch when
I noticed that commit 901938109f introduced a regression: two empty
switch cases will result in a compilation error. My suggested fix is
the following:

Fix compilation error due to empty switch cases

modified   src/pgtkterm.c
@@ -4276,6 +4276,7 @@ set_fullscreen_state (struct frame *f)
 
     case FULLSCREEN_WIDTH:
     case FULLSCREEN_HEIGHT:
+	;
       /* Not supported by gtk. Ignore them. */
     }


This fixes the compilation error for me; I don't know if there is a
more idiomatic way of solving this.

Kind regards,

Koen van Greevenbroek
This bug report was last modified 3 years and 229 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.