From unknown Mon Aug 18 15:38:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52260: Fix compilation error in feature/pgtk branch Resent-From: Koen van Greevenbroek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Dec 2021 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52260 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 52260@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163854133017047 (code B ref -1); Fri, 03 Dec 2021 14:23:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Dec 2021 14:22:10 +0000 Received: from localhost ([127.0.0.1]:50331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt9Rx-0004Qr-2i for submit@debbugs.gnu.org; Fri, 03 Dec 2021 09:22:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:51544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt4kf-00068w-On for submit@debbugs.gnu.org; Fri, 03 Dec 2021 04:21:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt4kf-0006Mj-GV for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 04:21:09 -0500 Received: from mout02.posteo.de ([185.67.36.66]:59087) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt4ka-0000i8-A3 for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 04:21:09 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 94542240104 for ; Fri, 3 Dec 2021 10:20:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1638523259; bh=BumGPM4/rZGL6j2WoyH1HtKp2OouYvY/QPD3D+vkMaY=; h=Subject:From:To:Date:From; b=io6SHzE/UIyFnN579ge783KP+asWcbhmGNEGLzx+04Rf1mQ/iqxD4TgGxlK4Hrbfq QZVxyb8PFRfKz14WgKg9oS5UY3ZJqdauE86xj2ofX15uwpoQEaZbjo2C2jmBZKeydf ZKEkxdIZuSXDb00WLLV9C10fQWqCu2YRdQBsoN88jvEy0o7Z5iPij/YbIy74RbihDK dSGjaX+6N3RdWf6Z4LN5zF8yNomsBYN7oGb6am+qWK9/ApW72nSocUqCuRrN7+JXrv GW4uRQSTs+OET9d4ltXvaOnE/4/t7DNyFatu1c4ffPlHR2gyH0KGyYeIvj1PVNsXBj TRxOyY7Af9ShQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4J56kf25Kfz9rxG for ; Fri, 3 Dec 2021 10:20:58 +0100 (CET) Message-ID: <1656047e6c87e052a7bbc7010410de4d7b500246.camel@posteo.net> From: Koen van Greevenbroek Date: Fri, 03 Dec 2021 09:20:53 +0000 Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=koen_devel@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Mailman-Approved-At: Fri, 03 Dec 2021 09:22:07 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, I was just trying to compile the latest version of the pgtk branch when I noticed that commit 901938109f introduced a regression: two empty switch cases will result in a compilation error. My suggested fix is the following: Fix compilation error due to empty switch cases modified src/pgtkterm.c @@ -4276,6 +4276,7 @@ set_fullscreen_state (struct frame *f) case FULLSCREEN_WIDTH: case FULLSCREEN_HEIGHT: + ; /* Not supported by gtk. Ignore them. */ } This fixes the compilation error for me; I don't know if there is a more idiomatic way of solving this. Kind regards, Koen van Greevenbroek From unknown Mon Aug 18 15:38:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52260: Fix compilation error in feature/pgtk branch Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Dec 2021 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52260 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Koen van Greevenbroek Cc: 52260@debbugs.gnu.org Received: via spool by 52260-submit@debbugs.gnu.org id=B52260.16385515806198 (code B ref 52260); Fri, 03 Dec 2021 17:13:02 +0000 Received: (at 52260) by debbugs.gnu.org; 3 Dec 2021 17:13:00 +0000 Received: from localhost ([127.0.0.1]:52140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtC7H-0001bu-WC for submit@debbugs.gnu.org; Fri, 03 Dec 2021 12:13:00 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtC7E-0001be-To for 52260@debbugs.gnu.org; Fri, 03 Dec 2021 12:12:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k+2K2Xl/ioMouBCENW5rHGZwLKL4fLyCfwcOZdvmaIE=; b=KOJeibbtRlPdS+n6533/gefxFK X0K579yDB1rFXeM/k/spXN7LLrkAHxMOI1b7N1AJZsjiou1PXc0MVyn54W/hBUThllGRVl2lbbPWU +H5PfIcpIDE0Bjw3e2EzzJ+SZimzY4Fxr+D9nJ4yT8Q4YJH4aNSPxxaxldYXao7UqWJw=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtC76-0004oz-J6; Fri, 03 Dec 2021 18:12:51 +0100 From: Lars Ingebrigtsen References: <1656047e6c87e052a7bbc7010410de4d7b500246.camel@posteo.net> X-Now-Playing: Joni Mitchell's _Dog Eat Dog_: "The Three Great Stimulants" Date: Fri, 03 Dec 2021 18:12:48 +0100 In-Reply-To: <1656047e6c87e052a7bbc7010410de4d7b500246.camel@posteo.net> (Koen van Greevenbroek's message of "Fri, 03 Dec 2021 09:20:53 +0000") Message-ID: <87fsr9vchb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Koen van Greevenbroek writes: > I was just trying to compile the latest version of the pgtk branch when > I noticed that commit 901938109f introduced a regression: two empty > switch cases will result in a compilation error. My su [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Koen van Greevenbroek writes: > I was just trying to compile the latest version of the pgtk branch when > I noticed that commit 901938109f introduced a regression: two empty > switch cases will result in a compilation error. My suggested fix is > the following: > > Fix compilation error due to empty switch cases > > modified src/pgtkterm.c > @@ -4276,6 +4276,7 @@ set_fullscreen_state (struct frame *f) > > case FULLSCREEN_WIDTH: > case FULLSCREEN_HEIGHT: > + ; > /* Not supported by gtk. Ignore them. */ > } > > This fixes the compilation error for me; I don't know if there is a > more idiomatic way of solving this. I think adding a "break;" is the normal way to do it, so I've now done this on the pgtk branch. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 12:13:06 2021 Received: (at control) by debbugs.gnu.org; 3 Dec 2021 17:13:06 +0000 Received: from localhost ([127.0.0.1]:52143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtC7K-0001cH-8J for submit@debbugs.gnu.org; Fri, 03 Dec 2021 12:13:06 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtC7J-0001bk-Lu for control@debbugs.gnu.org; Fri, 03 Dec 2021 12:13:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gQ/HaewrUBC6FyyjE+lq4NWRwH4zFfuDStfUvrOoXkg=; b=CSx4MyD134aPaB0Km1xcWY8Tcq VXWezGiQwfMtr538zdCUXXiWp4Wb8QhC7lNysjZ5sxWs2Fg5zLwZYmcy2SsNvAoij5wqBShNL8+Ge uQQjQSiSO7aA02BDavJJmOI53SqtQ81zH2X+2YnohYus5yIrj+FSXINnL9LxrhtBO9yE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtC7C-0004p6-1i for control@debbugs.gnu.org; Fri, 03 Dec 2021 18:12:56 +0100 Date: Fri, 03 Dec 2021 18:12:53 +0100 Message-Id: <87ee6tvch6.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #52260 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 52260 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 52260 29.1 quit