From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 08:39:28 2021 Received: (at submit) by debbugs.gnu.org; 3 Dec 2021 13:39:28 +0000 Received: from localhost ([127.0.0.1]:50256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt8me-00010X-33 for submit@debbugs.gnu.org; Fri, 03 Dec 2021 08:39:28 -0500 Received: from lists.gnu.org ([209.51.188.17]:39154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt8mY-00010J-Uw for submit@debbugs.gnu.org; Fri, 03 Dec 2021 08:39:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt8mY-0005JU-0x for guix-patches@gnu.org; Fri, 03 Dec 2021 08:39:22 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:50499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt8mR-0004Nz-C3 for guix-patches@gnu.org; Fri, 03 Dec 2021 08:39:17 -0500 Received: from hermia.goebel-consult.de ([79.211.191.200]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N5VTm-1mUblT1k9S-01717j for ; Fri, 03 Dec 2021 14:39:05 +0100 Received: from lenashee.fritz.box (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 3471E5F53A; Fri, 3 Dec 2021 14:39:09 +0100 (CET) From: Hartmut Goebel To: guix-patches@gnu.org Subject: [PATCH 1/3] gnu: python-stdnum: Update to 1.17. Date: Fri, 3 Dec 2021 14:39:02 +0100 Message-Id: <5fae975202b1a50b25270568def974822ca0ba98.1638538371.git.h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:8ruu3Riv2Xzsi87jSQP1ceScXVJPCA7kTHSMIXswCxiZNJ3QE8e pqVUzAuCo/GAqU9hwQTyDXpjwzFg8pvAsTHNpr/y1MAKVcR8UW/MrGnWYPhxC/dA21F7NPa cLim6sqLZUcxSrCbs3brCciEPCvyy185KW46m9x5G4MK0HdCrQU4heVu0emF+CxyTwwjZNX Xxtne8EaSHlcdT9iVysZQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Z/YJZCieIiU=:h7hubmVO9HriKfiKWW8813 j3FdP7ebhJzMQ0PFVuXOVRvh7RtKqEeXQPftS9QdZE32yTNYCEa3kTQ0Zz33YERE/45lerqZr 6rjScYpBGVOGgGU/8dIEv7CWlkM2oG+TcvCJp84BDi4GnOxyp+MPHc3PEEs3eYeC3GP3+n1BB w9v/OaCngQWs4oISeyR/EYu366lrZOJVXZil1aFM6lKx/jIRkOCCLAeB17+6fDDk62bzjeX3a U7ZWH54w0ATe9FUnycvqw6EaYvQAwrO5q50maIMK66LLyCKaTuuti31/2Ok6P4xltk4UbcZxC KTtXgL1PyyVtjhHuoRZf1WUFyKKPo38NYI2UTgCI/YuDLnNfUhLVI3DPDP+orXJSPm44mpK9C fspyUBbcdSuYCTny0pXIAATPlICI/wok1oRLcPsrW04OH5Im8yQT2A8SrDuv8rPY2wykU4IMN OeRjq+3RrJg8dBDE18M5bbc8fRbQWlAwWTB3N1mDN0tq7VvPk56Df+Br2HzSXbkqhXwUFTKKC GdY2qpCX2UjvBJGu8iBQF7g9lxjsi3m6ZCuMzdPSZZN/DvU/a3nk0UxybUHA6ESeFnca1hTpY jqL6Y9v6wIPQ3X4dD2jDalvivc84abt75PH4tfPhncPL/TOIj0Bv+USoUq9gOdLQ2kq/8P3pq NfpUyd/hJJwHDe8gsfyZ6PNdGWVJOG6Xc3SJ7Z1iTQAoMxKe3xqLmDqHpLnWNUQUyOHF3Qerf mr2kYqaYlH1hUC96 Received-SPF: none client-ip=212.227.126.135; envelope-from=h.goebel@crazy-compilers.com; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/finance.scm (python-stdnum): Update to 1.17. --- gnu/packages/finance.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index 0bb9c79520..191529ce40 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -1157,13 +1157,13 @@ agent.") (define-public python-stdnum (package (name "python-stdnum") - (version "1.14") + (version "1.17") (source (origin (method url-fetch) (uri (pypi-uri "python-stdnum" version)) (sha256 - (base32 "070vd9zgvq0jchs4xc4j1h4r1l1lg4wwb8xs3p25k8c2xjw94fpx")))) + (base32 "0h4369b7gws5w5s2vhq590bk219y5k53zcmha2zwsb4i2dg2nkip")))) (build-system python-build-system) (arguments '(#:phases (modify-phases %standard-phases -- 2.30.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 08:41:22 2021 Received: (at submit) by debbugs.gnu.org; 3 Dec 2021 13:41:22 +0000 Received: from localhost ([127.0.0.1]:50265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt8oT-000151-P0 for submit@debbugs.gnu.org; Fri, 03 Dec 2021 08:41:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:42794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt8oR-00014m-JW for submit@debbugs.gnu.org; Fri, 03 Dec 2021 08:41:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt8oR-0007ut-BC for guix-patches@gnu.org; Fri, 03 Dec 2021 08:41:19 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:50589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt8oO-0005er-5K for guix-patches@gnu.org; Fri, 03 Dec 2021 08:41:19 -0500 Received: from hermia.goebel-consult.de ([79.211.191.200]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MPGJh-1nEM1O3Mbd-00Pb1x; Fri, 03 Dec 2021 14:41:07 +0100 Received: from lenashee.fritz.box (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 408695F53A; Fri, 3 Dec 2021 14:41:11 +0100 (CET) From: Hartmut Goebel To: 52259@debbugs.gnu.org, guix-patches@gnu.org Subject: [PATCH 2/3] gnu: trytond: Fix import of trytond modules. Date: Fri, 3 Dec 2021 14:41:03 +0100 Message-Id: <3fa3f27e0f88ca1bef4639eb106e8f486b5dfcd5.1638538371.git.h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <5fae975202b1a50b25270568def974822ca0ba98.1638538371.git.h.goebel@crazy-compilers.com> References: <5fae975202b1a50b25270568def974822ca0ba98.1638538371.git.h.goebel@crazy-compilers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:/TPAaXjyjLVOaOMtsyWSr3KdP2eLR9YFO7Ok2lyo7dvhA7Q1yEO 93iQW9yZeef0U72B2+ZBL9R641PphyE/kSTS4qiMC8sSDKpIg+OlDgwsYu0F4PwL5itw+cp NyiLoGzAejrlS/zEt1aVVKLlnZOqlXCWP+/AXzKKOZiTcNhO27dClHn2f6kx/sKWZFDzTA1 WD+uS8XAQpbMz9y6Bsl1w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:EDR4Mr/SgvA=:BAthTMkaaFHx+1JjLqKxA4 PYc7zcueewb2n+uHQpxdte2WG8VoH1R7Soe6Qd9cOihU/qhppkkpg237pWnkqeVTWCCc73Zt3 d5LqzbPQQA6CQGGuqGalZyzljE0YT7tPWd10YInMY2zbRQKfFrFqHK+jk4phWGV4xc8CwB+OQ b5JqrKTQ4RQ1UA8Gk7/F2cUaA57ARZI3ADhGgRzPaM9mmRwEHvO+Tm8gkkB7sDnAKhhV7wEiS hoPe5pbnx+bzsePNh/DVziVyuDpSQf9XjeCSm+BWLX8t0RppPRlEY8hq2QhcSKDhF2KXZTFTE wyCIqBSIK7YqqkEiT6nDs0sXJUuqLp00CDIAUDe9e3dp9IvNVgus1IoHLpdS8/yaxGrbDXsdv xveU0eWxeozlI1eLw6El6YuaeYndzu4FKz4rmirdWZKdET5+LnTdZ2SWmNZRfm3t77nCXM8iC OFp28RWSz6Ejs2OW4cCOLkTaIdorFCDgIGCn9MVNcp67L691qHctbOKkTGHBZD9PrFq2KXOgy M+qRZrYg9m1VdG/cqzQQV4kjCt2c1Ywj2uMV8QsAlm2hXptYjH/3Pfz7jQ6yKRuI1Xb0DsPzx Qhrz/9jnvrauTTiaiIe92AG/8yqMLoVAKPecm5B7QAxO96wuHgKQoUtNZzGeUYvs3P6BCkZXG 0L0BqHjmNr964uKyX6yg+d10iMKrmGCliuRyA4KvIPWZW3IYmZRhhgY3Jm/mupCHKdpOgvvQf 4lT2ODSaN9ae/n2G Received-SPF: none client-ip=212.227.126.135; envelope-from=h.goebel@crazy-compilers.com; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) For adding modules, trytond uses entry-points, anyhow relying on the modules being named "trytond.modules.xxx" and being placed in the same filesystem path as "trytond.modules". The package "trytond.modules" is not a namespace module, anyhow trytond modules must be sub-modules of "trytond.modules". This works well if all packages are installed into the same filesystem path "…/trytond/modules": The Python importer will find all sub_modules at this place. Anyhow, in Guix, modules don't share the same filesystem path and the Python importer will not find them. Solution is to add all trytond module's locations to "trytond.modules._path__". This will make "trytond.module" behave much like a namespace module and the importer pick up the module. * gnu/packages/patches/trytond-add-egg-modules-to-path.patch: New file. * gnu/packages/tryton.scm (trytond): Use it. * gnu/local.mk (dist_patch_DATA): Add it --- gnu/local.mk | 1 + .../trytond-add-egg-modules-to-path.patch | 22 +++++++++++++++++++ gnu/packages/tryton.scm | 3 ++- 3 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/trytond-add-egg-modules-to-path.patch diff --git a/gnu/local.mk b/gnu/local.mk index 604c6cf151..a8b9bcac21 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1816,6 +1816,7 @@ dist_patch_DATA = \ %D%/packages/patches/tor-sandbox-i686.patch \ %D%/packages/patches/transcode-ffmpeg.patch \ %D%/packages/patches/transmission-honor-localedir.patch \ + %D%/packages/patches/trytond-add-egg-modules-to-path.patch \ %D%/packages/patches/ttf2eot-cstddef.patch \ %D%/packages/patches/tup-unbundle-dependencies.patch \ %D%/packages/patches/tuxpaint-stamps-path.patch \ diff --git a/gnu/packages/patches/trytond-add-egg-modules-to-path.patch b/gnu/packages/patches/trytond-add-egg-modules-to-path.patch new file mode 100644 index 0000000000..1baccfee1c --- /dev/null +++ b/gnu/packages/patches/trytond-add-egg-modules-to-path.patch @@ -0,0 +1,22 @@ +Work around trytond.module not being a real namespace module. + +Solution is to add all trytond module's locations to +trytond.modules._path__. This will make trytond.module behave much +like a namespace module. +Adding to __path__ is done in update_egg_modules() to ensure __path__ +is updated whenever the list of egg modules is updated. + +*** a/trytond/modules/__init__.py 1970-01-01 01:00:01.000000000 +0100 +--- b/trytond/modules/__init__.py 2021-12-02 18:12:15.385101986 +0100 +*************** +*** 38,43 **** +--- 38,46 ---- + import pkg_resources + for ep in pkg_resources.iter_entry_points('trytond.modules'): + EGG_MODULES[ep.name] = ep ++ path = os.path.join(ep.dist.location, 'trytond', 'modules') ++ if not path in __path__ and os.path.isdir(path): ++ __path__.append(path) + except ImportError: + pass + diff --git a/gnu/packages/tryton.scm b/gnu/packages/tryton.scm index 0ac0a5a5cd..212d6593ad 100644 --- a/gnu/packages/tryton.scm +++ b/gnu/packages/tryton.scm @@ -48,7 +48,8 @@ (method url-fetch) (uri (pypi-uri "trytond" version)) (sha256 - (base32 "1jp5cadqpwkcnml8r1hj6aak5kc8an2d5ai62p96x77nn0dp3ny4")))) + (base32 "1jp5cadqpwkcnml8r1hj6aak5kc8an2d5ai62p96x77nn0dp3ny4")) + (patches (search-patches "trytond-add-egg-modules-to-path.patch")))) (build-system python-build-system) (propagated-inputs `(("python-dateutil" ,python-dateutil) -- 2.30.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 08:41:26 2021 Received: (at submit) by debbugs.gnu.org; 3 Dec 2021 13:41:26 +0000 Received: from localhost ([127.0.0.1]:50270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt8oX-00015R-TV for submit@debbugs.gnu.org; Fri, 03 Dec 2021 08:41:26 -0500 Received: from lists.gnu.org ([209.51.188.17]:43090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt8oW-00015E-HW for submit@debbugs.gnu.org; Fri, 03 Dec 2021 08:41:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt8oW-00087O-9t for guix-patches@gnu.org; Fri, 03 Dec 2021 08:41:24 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:51429) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt8oU-0005vZ-7h for guix-patches@gnu.org; Fri, 03 Dec 2021 08:41:24 -0500 Received: from hermia.goebel-consult.de ([79.211.191.200]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N1xZX-1mR3Ed3Ain-012Doc; Fri, 03 Dec 2021 14:41:10 +0100 Received: from lenashee.fritz.box (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 5FAE766096; Fri, 3 Dec 2021 14:41:11 +0100 (CET) From: Hartmut Goebel To: 52259@debbugs.gnu.org, guix-patches@gnu.org Subject: [PATCH 3/3] gnu: trytond: Ensure all modules are found. Date: Fri, 3 Dec 2021 14:41:04 +0100 Message-Id: <0d461f73e5c687d1c53df55540d3248b38349414.1638538371.git.h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <5fae975202b1a50b25270568def974822ca0ba98.1638538371.git.h.goebel@crazy-compilers.com> References: <5fae975202b1a50b25270568def974822ca0ba98.1638538371.git.h.goebel@crazy-compilers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:fbYBNL+a6+IjFVq/0+JbvHgovANGJ4fW/wkh55TfQ8unVFhCrkc knUPi6xtOfIlp5DRSlnRqmbx6uyd6gmRqdhYl+b0834bs3HlRa90u+aJP666yKJCORcDrz9 +sxDdgg4mGhlMLcE97Cb6OyMeKtGdK9gPuu9qeYNv0lpzFpICraAmogiUx5qwT2MuD7U+WE 9594dzKeZREOFmUASFaOw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:2IRbRwI5qkw=:wm4q1ZSqdMz34hGS0oGhjw ZAGZabJNvHOUTHmdE5OzKFT+hQSOwtx4Z4ZtALrTsX/Q98l10A1mPPEiKgEBpgLAZ4zV8Spe1 MXhaIaVoFQwGSMRqDakETn04UAGadnAFq0z5Y6mwxwyq49hMzVf/5b4oAvtEBl3b8XN7yvmB3 1Ln3ADnhXO9TxWcdkCJ1P4xeti9qPoiUXx9LUGPdP5VtpNLmOriEuwsgIbMn3GPhApx4OTC9c WwOgxxyu4FHY88AbbWV4J/RbasaA2WwPJJsBCj0tIByb6NJPzTiDgFITvqsxWz0bV812I4a/o rAHWogbf1WIthuDnAFH37hFSAs24GPXYhM9C2yu4OQD1z1rmB1UeV83o317xk9obK1muMgGn/ MVgAJOqHrFBXFY6z0SNjU/ejjcXlz+bdXJ56okfNmOJ83KhecswOu97LM2lSpvQtyfbceVKJo IIV4LC7bVUH3l+km7qBqQL8HSP5Al1i1e38tw6a6DztturJGNZ2mQOLyRpQ6gMqcu3J530K0z rrjahwNSiogHlVqjq2UZqVI3xfwlXngmItGrPtJuuvWA5fEu1FRm5e6tSK9VCKkOUkty6k2B/ oNTOVEuJEbz9idFHbsH6bM3WOgoLvKTNI3Ej7X/6j4v2BD3DLur4xXRxbFKit4bJ+yrT7+F0y l+5C7NsWH2J4yrgbElH45Uiv4wb1o5ReYzp12GUb4lx/CY484nSWUPGPQ2GGBQImFyakxVpSx 9YaJXkMBP+RAVje2 Received-SPF: none client-ip=217.72.192.75; envelope-from=h.goebel@crazy-compilers.com; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) If the python package matching tryton is not installed alongside to trytond, PYTHONPATH ist not set (or pointing to a wring version) and trytond (and the trytond tools) would not find the trytond modules. This change introduces a new native-search-path GUIX_TRYTOND_MODULES_PATH. Trytond gets patched to honor this environment variable. Thanks to Maxim Cournoyer, who's code for guix-pythonpath-search-path was the template for guix-trytonpath-search-path. * gnu/packages/patches/trytond-add-guix_trytond_path.patch: New file. * gnu/local.mk: (dist_patch_DATA): Add it. * gnu/packages/tryton.scm (trytond): Use it. [native-search-paths]: New element. (guix-trytonpath-search-path): New function. --- gnu/local.mk | 1 + .../trytond-add-guix_trytond_path.patch | 26 +++++++++++++++++++ gnu/packages/tryton.scm | 19 +++++++++++++- 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/trytond-add-guix_trytond_path.patch diff --git a/gnu/local.mk b/gnu/local.mk index a8b9bcac21..cac9079325 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1817,6 +1817,7 @@ dist_patch_DATA = \ %D%/packages/patches/transcode-ffmpeg.patch \ %D%/packages/patches/transmission-honor-localedir.patch \ %D%/packages/patches/trytond-add-egg-modules-to-path.patch \ + %D%/packages/patches/trytond-add-guix_trytond_path.patch \ %D%/packages/patches/ttf2eot-cstddef.patch \ %D%/packages/patches/tup-unbundle-dependencies.patch \ %D%/packages/patches/tuxpaint-stamps-path.patch \ diff --git a/gnu/packages/patches/trytond-add-guix_trytond_path.patch b/gnu/packages/patches/trytond-add-guix_trytond_path.patch new file mode 100644 index 0000000000..7dc136ec46 --- /dev/null +++ b/gnu/packages/patches/trytond-add-guix_trytond_path.patch @@ -0,0 +1,26 @@ +Make trytond add all paths listed in GUIX_TRYTOND_MODULES_PATH to sys.path. + +*** a/trytond/modules/__init__.py 1970-01-01 01:00:01.000000000 +0100 +--- b/trytond/modules/__init__.py 2021-12-02 22:17:28.014612267 +0100 +*************** +*** 31,36 **** +--- 31,48 ---- + + EGG_MODULES = {} + ++ def __extend_python_path__(): ++ tryton_python_path = os.environ.get("GUIX_TRYTOND_MODULES_PATH") ++ if tryton_python_path: ++ paths = [path[:-16] # remove "/trytond/modules" ++ for path in tryton_python_path.split(os.pathsep)] ++ sys.path.extend(paths) ++ # ensure new paths are in the pkg_resources WorkingSet ++ import pkg_resources ++ list(map(pkg_resources.working_set.add_entry, paths)) ++ ++ __extend_python_path__() ++ + + def update_egg_modules(): + global EGG_MODULES +l diff --git a/gnu/packages/tryton.scm b/gnu/packages/tryton.scm index 212d6593ad..f8cd2b4c9d 100644 --- a/gnu/packages/tryton.scm +++ b/gnu/packages/tryton.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2020 Vinicius Monego ;;; Copyright © 2021 Maxime Devos ;;; Copyright © 2021 Hartmut Goebel +;;; Copyright © 2021 Maxim Cournoyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -39,6 +40,19 @@ #:use-module (guix utils) #:use-module (guix build-system python)) +(define (guix-trytonpath-search-path version) + "Generate a GUIX_TRYTOND_MODULES_PATH search path specification, using +VERSION. + +Do not use PYTHHONPATH not avoid interfering with any different Python package +installed in the same environments. Collecting only paths actually containing +/tryton/modules reduces the number of paths." + (search-path-specification (variable "GUIX_TRYTOND_MODULES_PATH") + (files (list (string-append + "lib/python" + (version-major+minor version) + "/site-packages/trytond/modules"))))) + (define-public trytond (package (name "trytond") @@ -49,7 +63,8 @@ (uri (pypi-uri "trytond" version)) (sha256 (base32 "1jp5cadqpwkcnml8r1hj6aak5kc8an2d5ai62p96x77nn0dp3ny4")) - (patches (search-patches "trytond-add-egg-modules-to-path.patch")))) + (patches (search-patches "trytond-add-egg-modules-to-path.patch" + "trytond-add-guix_trytond_path.patch")))) (build-system python-build-system) (propagated-inputs `(("python-dateutil" ,python-dateutil) @@ -66,6 +81,8 @@ (native-inputs `(("python-mock" ,python-mock) ("python-pillow" ,python-pillow))) + (native-search-paths + (list (guix-trytonpath-search-path (package-version python)))) (arguments `(#:phases (modify-phases %standard-phases -- 2.30.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 14 03:23:37 2021 Received: (at 52259) by debbugs.gnu.org; 14 Dec 2021 08:23:37 +0000 Received: from localhost ([127.0.0.1]:57529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx361-0001Dm-A8 for submit@debbugs.gnu.org; Tue, 14 Dec 2021 03:23:37 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:34700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx35z-0001Da-DF for 52259@debbugs.gnu.org; Tue, 14 Dec 2021 03:23:36 -0500 Received: by mail-wr1-f43.google.com with SMTP id j3so31057255wrp.1 for <52259@debbugs.gnu.org>; Tue, 14 Dec 2021 00:23:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=Z/hMewYHvI/2woOGtoABblWFmmOsXD37QS+L21j1c0A=; b=UX8yd0mmB7fTyU2al7JuFqpWGBeskXevgdGwNdOt9lkjHlG+zZ0VPXhyKR8PEVzC7j LxsKCfe7RHadzNI9RI11HUsilzpaHp5giZJQjR7tFZCelzlQtGmaWtjE8n0gMOsgbR/b l0ESXvGyzilAdGEDsftdhi3aj/wOBbgH6afjcQWMwN0H3u8qXiHrpSkvXVVGeH+iypWT ijMZi8JBjArlMUavUZCZwlPFp5JLab/g9IK5hg9kyNpUZ7NlSr2Bqf6qtArH/0VXaiOA tBmd8lGf4KTCXXYgGL5/kFoubm2qOJ0SqA1ohTWedENDl/kjB4U/egPSR5rzjpK7k9uC pbBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=Z/hMewYHvI/2woOGtoABblWFmmOsXD37QS+L21j1c0A=; b=wb70o57GESxr4ghGsU8booQq/MYU5EasMaYZfwXS6p8RoVmOsnu14LvE7DSLXUyHBK Ko3/5TRoTe7Mq4YsTsn3WELywV9rAVtXSSNPlpHzhJSlnq6o/8BUCfOkdi3YIil5VIzU Pi0PNrBcgSSE4KzmoxbcX7he0B56Vi64NS1fI7luH7984Yaw5VGBXFhkt97vbRworEKx tUjoyVcbiyrhr7+yvUClkBSv2+1VVW4/pFMJkvQzfiHUfJ1yRG5hmuv48yW8HbYX8L8f cJxM0tn4vSBPWSNr0i4U4+1eAjtne0USWDs7I3PH9CqeW/WV7HlrQ9zzFkg8tVKg3Sp8 P32w== X-Gm-Message-State: AOAM530XrkVM5iScB3t3emVtkvWF8oY/N9ITHniAHXar8hsg7n89uCV9 nJ+K4GbZdge0nTeUc2B2Cs76C4KpUQo= X-Google-Smtp-Source: ABdhPJx9UFBy278PUmP/WdzQkBasGpnW2E/pCrXHYls2+VUHdPlNbeMidgKhlTQrDdd7+JCVo2bcDw== X-Received: by 2002:a05:6000:1289:: with SMTP id f9mr4077067wrx.329.1639470209455; Tue, 14 Dec 2021 00:23:29 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id g13sm10953295wri.102.2021.12.14.00.23.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Dec 2021 00:23:29 -0800 (PST) From: zimoun To: Hartmut Goebel , 52259@debbugs.gnu.org Subject: Re: [bug#52259] [PATCH 3/3] gnu: trytond: Ensure all modules are found. In-Reply-To: <0d461f73e5c687d1c53df55540d3248b38349414.1638538371.git.h.goebel@crazy-compilers.com> References: <5fae975202b1a50b25270568def974822ca0ba98.1638538371.git.h.goebel@crazy-compilers.com> <0d461f73e5c687d1c53df55540d3248b38349414.1638538371.git.h.goebel@crazy-compilers.com> Date: Tue, 14 Dec 2021 09:15:51 +0100 Message-ID: <86mtl338lk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52259 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Fri, 03 Dec 2021 at 14:41, Hartmut Goebel wrote: > If the python package matching tryton is not installed alongside to trytond, > PYTHONPATH ist not set (or pointing to a wring version) and trytond (and the ^ typo > trytond tools) would not find the trytond modules. > > This change introduces a new native-search-path GUIX_TRYTOND_MODULES_PATH. > Trytond gets patched to honor this environment variable. > > Thanks to Maxim Cournoyer, who's code for guix-pythonpath-search-path > was the template for guix-trytonpath-search-path. The wording appears to me weird, but I am not native. > * gnu/packages/patches/trytond-add-guix_trytond_path.patch: New file. Without being picky, why underscore? ^ ^ Otherwise, gnu/packages/patches/trytond-add_extend_python_path.patch Well, it does not matter. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 09:21:19 2021 Received: (at 52259) by debbugs.gnu.org; 18 Dec 2021 14:21:19 +0000 Received: from localhost ([127.0.0.1]:41532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myaaN-0000Sl-IK for submit@debbugs.gnu.org; Sat, 18 Dec 2021 09:21:19 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:52215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myaaL-0000ST-D4 for 52259@debbugs.gnu.org; Sat, 18 Dec 2021 09:21:18 -0500 Received: from hermia.goebel-consult.de ([46.87.136.58]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MFKbB-1mitGp2Per-00Fnf3; Sat, 18 Dec 2021 15:21:10 +0100 Received: from [127.0.0.1] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 74D945F53C; Sat, 18 Dec 2021 15:21:14 +0100 (CET) Message-ID: Date: Sat, 18 Dec 2021 15:21:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [bug#52259] [PATCH 3/3] gnu: trytond: Ensure all modules are found. Content-Language: en-US To: zimoun , 52259@debbugs.gnu.org References: <5fae975202b1a50b25270568def974822ca0ba98.1638538371.git.h.goebel@crazy-compilers.com> <0d461f73e5c687d1c53df55540d3248b38349414.1638538371.git.h.goebel@crazy-compilers.com> <86mtl338lk.fsf@gmail.com> From: Hartmut Goebel Organization: crazy-compilers.com In-Reply-To: <86mtl338lk.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:OBvfGBNGafZsDEncTQIKj/2gJfLyguKgDWc4/Kr57OIkMjpQLp0 0SJf6dYKfB/zSqeBlc9ZghuYsdERnR4h8UkwY7jbPpCS+sQoV+9pulu+0TkF1fVob7qc3q6 xenVtfjeXaK6TNnvO4R5O1heTrUpbkSGQgB/mzuyuwqnd7AIoD8HEa9REqObLLpfRT0veq9 +jGBpwuF70RcX6JH/IBGw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:JuPHRcE0FLc=:+bjNXNYDGFN0fxnoSrl69S lDCquRwTsVpNyltHvHbDPU8QkllQHAae7ArJSjeOAye5kxw37SOD4uTiWjRXm6JXkvN7djTSU 03hC3T3xHPO/KFa/U2X5XxvedaIHTjvEjKwCR8mSK4cLoRky72jTujgEO7gsboiWo6Tquv4RQ J7K0i1RMWYEA45jqZ9ijv10/wwLTfpMW9D2nyH/R5sWM7kDiekwVnJ7ZxSfn7qJdyPxhY7SKb wHlgwl0pxlgB2jv/v0wNE6deNBBz20vCoPbA+aM1JpITiIZ0VOJsvpaYodT6q5ZEjRgrLqxkj L1ZqWIavjwdRGeKrn+8ntpdg7/reQofZe5pO5Pxgf+fpFJrIWAifvu64UhY6Ku4vmhtMqPO8i CaR1d6aPEgxJ3ASNdmyqOFtHiekxjOUwLWl86jBoxIGqqhu3EH98qOUlHTSdYDa1WfQtOJVc5 60jeiP2EM6MXiqvHri8k2BHY57j6MCSzieWAiUWb3a0n79vu0JCTKpqcuPG1jtsBMioWe8U/0 DRaNDZfrBYUbaJaG/vWhbk7VT2tP8hpwYrXQRMQ4iUgjjO9F07Ztjdx0mHkuo8adH0pE/2LYQ Uoflmu9pzuj8le5TYFg0E4i8gQq6rtulKOZWQIOZ0V//OxYYvoLf32eCWJL+KX/Sf/4cCWD90 Bgd0ecU16P2J4gHaaJEBzw99fomu5V5qQIShWO30x8j/l2zhOPhq2u5Du8+A/HuQDuR5ZV+YU f7q3t5GBSpY81LId X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 52259 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) Hi, thanks for the review. I fixed and pushed as d4ecdc3328d998c787cbdad6d02e1a74d2fc7ac4 >> Thanks to Maxim Cournoyer, who's code for guix-pythonpath-search-path >> was the template for guix-trytonpath-search-path. > The wording appears to me weird, but I am not native. "whose" is the correct spelling - anyhow I'm not native, too. >> * gnu/packages/patches/trytond-add-guix_trytond_path.patch: New file. > Without being picky, why underscore? ^ ^ Otherwise, Underscores since this is the name of the functions added. Other patch files do the same, "agg-am_c_prototype.patch" - thus I kept the name. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 09:21:48 2021 Received: (at 52259-close) by debbugs.gnu.org; 18 Dec 2021 14:21:49 +0000 Received: from localhost ([127.0.0.1]:41535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myaaq-0000Tb-Pa for submit@debbugs.gnu.org; Sat, 18 Dec 2021 09:21:48 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:60491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myaap-0000TI-4h for 52259-close@debbugs.gnu.org; Sat, 18 Dec 2021 09:21:47 -0500 Received: from hermia.goebel-consult.de ([46.87.136.58]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MjSLi-1mElB918Ac-00kzXo for <52259-close@debbugs.gnu.org>; Sat, 18 Dec 2021 15:21:41 +0100 Received: from [127.0.0.1] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 7727E5F53C for <52259-close@debbugs.gnu.org>; Sat, 18 Dec 2021 15:21:45 +0100 (CET) Message-ID: <21b59b4e-b973-7adc-57d3-3f0b56a97c6e@crazy-compilers.com> Date: Sat, 18 Dec 2021 15:21:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: bug#52259: Acknowledgement ([PATCH 1/3] gnu: python-stdnum: Update to 1.17.) Content-Language: de-DE To: 52259-close@debbugs.gnu.org References: <5fae975202b1a50b25270568def974822ca0ba98.1638538371.git.h.goebel@crazy-compilers.com> From: Hartmut Goebel Organization: crazy-compilers.com In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:saH2n+3pXcNic3gWTapK7XqrA60gi546NIkDxeW2cAQcsMRJ/wC 1pjlThEvk7xnvFdX+dCuAG0YtU9PantHiP3wGI0Ncga6+RmKZ0gDMpbGoaFMawUmvSKwYef pr1AVme6oAYgXoIUVxXhZ4W2v5b1ndQCIe7W6z24VFqqDlr3Z163LMtfVUafWvfj4QmPs01 /CDA+dWo8BNJnY3sMYJ5Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:idA0Kcn6BBU=:MNjzLAim6oj/lXdoqqV8hs +5MHDgExo+YBmtJqEEYTFRSrQsg92WfaZDsHg65MLk/54FKgijPAnXSwNg9vk1j2GzwuVE7GX pg6SVL72PXn7sX5Epd3Dn3XxFVX25oaFLJkBRpTKYSkU0go05mVr28YKIEfkbO3Djgdj+0uCg YplP9hbQoNPqA5xUhvqpw2cquSRSMMbVWPqstdesIXKZiZM6XpNz6zh4JGqMgZdQVCX7dgiRE 1HyIbyLTYu8MhB4qMi+hqibZ+JjSxSjoDVHwZgGNQGstC1N5ZSlss2IAqOaZQZ9ZH8C8PgPk0 f7csjbZqvtlFA6IvYE17DMlKILqUbPm96N9mIeBWQHuvpNPhjOk06TdJUFIkwFDWlRoM9IRZC m2qGDD4x1G+6XU3tUggnlZBXZA4siWSDBSW4BoFwIRvNdp7vFZNGwfV0pgXyWGJ19W27r87Nr B0bCbGeu9ts/dpv4fr0SiUE8qrHb2vAHYWSIDLMA/Ds5Xpqte09dQ0rAMRZcuhdGjnM8GbuCE 0KON0ZvMLcPogiGuJpZwtKPQiri8yw5jjtvarlpjykzdxi9tYuIaUEnaZ5i/9nz8if75qPD5F /EF/b/fFVvg/xydPtv5gz7Mp2SVMJILHcqu3q1PH2REEcStUmUJDO8BkkdgsUbDSYIgDlG9S0 7IOQZ8ghmql19HfbWvOhwjZSfFSb/GVbGu6HK0WxMI5COyO0G6Hn293mjBAANAUf51El143ef wktMl+GcoaB3Qd5Q X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 52259-close X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 10:18:16 2021 Received: (at 52259) by debbugs.gnu.org; 18 Dec 2021 15:18:16 +0000 Received: from localhost ([127.0.0.1]:43597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mybTU-0002K1-CV for submit@debbugs.gnu.org; Sat, 18 Dec 2021 10:18:16 -0500 Received: from mail-io1-f44.google.com ([209.85.166.44]:45808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mybTT-0002Jp-2b for 52259@debbugs.gnu.org; Sat, 18 Dec 2021 10:18:15 -0500 Received: by mail-io1-f44.google.com with SMTP id q72so7134923iod.12 for <52259@debbugs.gnu.org>; Sat, 18 Dec 2021 07:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XMbFPZuyqPAmdnKC1ig6pkJH/Lzsv/21iJEB/lutfnU=; b=VB5ezn8PAr+7svHWNUA9uKPFTxT82VPCLNaLhOON5ORQ4VkOJeu2RcmSAiewzZYWW3 5i7JZXE19Xxt8EQMZIbAdzqJGwBU566N6CEWKeoQ1GqUSY9xoUgAzvCUQR/Z6DQdY8Js srFcDOP/7MokJveJXU8NtaAjQ37Icex9TmHEbNubhSqCFCKykiDTK90FqysOI1r23lkw /6pEW6RHhhleCkVjOfPvWwwnrbaoL8iKMxfxnC7Vu5X1d/de7D8fk3nom0NgjAxb8pNe 3yEnn3rkI/rpVuKaeitW6YWPR0dJB8/WtLcNRQLAIIoaUjB+NH48nER2Hf4QVjuvwrSD NTdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XMbFPZuyqPAmdnKC1ig6pkJH/Lzsv/21iJEB/lutfnU=; b=tTt/mYtyvetIWe26RpYwLyT2XLdvG/rBVE6E/mbnS7NVAYZHXHUPA6QnkJuqHo98yj B3uuBWOsHBFxSb1zereof9neSG7PfHp8TAua9PX55KnlS9zPJNZl2/zTvqXnK3u8+25W xfScJZ/q1ly4b0dH9qmbF5vcJVxuT/fUjzfjrDgLa8+q95UeayDuZP5TiZBa/uen/XfW Si0oEpwP+lsF1lgd3+4f17fTCUcPyp/UuKPKcrUiMaaYdBGlG4kEaBFxy+4VwNFmXuQR QOkyjJECp2gBkj9HaGy2JDkIIlASKWI1lb0cEND3YGUGTKrn7p8fHuFTjjaEW+gGpal3 C9/Q== X-Gm-Message-State: AOAM533vDWXy7nhRF1UrW00jGXhHxQZWicdsLVC3+r6ReL6niaoczrDs 2M7IQeXvZZX+sQWyhKE8RwSzltIhxVS8AgUaaJ5jzuQg11I= X-Google-Smtp-Source: ABdhPJwMMrPn1PZMOmbZFtUYB7TA2ru6xMID8jrh7iAIDJNNflkvnh543oodnz8Mi/Rf7WqrgPr/6l3A/aigY2gXZ0Q= X-Received: by 2002:a05:6638:14c9:: with SMTP id l9mr4880452jak.307.1639840689418; Sat, 18 Dec 2021 07:18:09 -0800 (PST) MIME-Version: 1.0 References: <5fae975202b1a50b25270568def974822ca0ba98.1638538371.git.h.goebel@crazy-compilers.com> <0d461f73e5c687d1c53df55540d3248b38349414.1638538371.git.h.goebel@crazy-compilers.com> <86mtl338lk.fsf@gmail.com> In-Reply-To: From: zimoun Date: Sat, 18 Dec 2021 16:17:58 +0100 Message-ID: Subject: Re: [bug#52259] [PATCH 3/3] gnu: trytond: Ensure all modules are found. To: Hartmut Goebel Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52259 Cc: 52259@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Hartmut, On Sat, 18 Dec 2021 at 15:21, Hartmut Goebel wrote: > thanks for the review. I fixed and pushed as > d4ecdc3328d998c787cbdad6d02e1a74d2fc7ac4 Thanks! > >> * gnu/packages/patches/trytond-add-guix_trytond_path.patch: New file. > > Without being picky, why underscore? ^ ^ Otherwise, > > Underscores since this is the name of the functions added. Other patch > files do the same, "agg-am_c_prototype.patch" - thus I kept the name. In this consistency case, as I suggested, it should be: gnu/packages/patches/trytond-add_extend_python_path.patch Anyway. :-) Cheers, simon From unknown Sat Jun 21 10:45:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 16 Jan 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator