From unknown Sun Jun 22 07:48:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52248: Open hidden overlays in isearch-delete-char Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52248 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 52248@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16384751718300 (code B ref -1); Thu, 02 Dec 2021 20:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Dec 2021 19:59:31 +0000 Received: from localhost ([127.0.0.1]:49384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mssEt-00029o-2T for submit@debbugs.gnu.org; Thu, 02 Dec 2021 14:59:31 -0500 Received: from lists.gnu.org ([209.51.188.17]:40086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mssEp-00029f-TV for submit@debbugs.gnu.org; Thu, 02 Dec 2021 14:59:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mssEp-0000Yk-Kj for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 14:59:27 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mssEm-0001x4-Az for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 14:59:27 -0500 Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id BFD4C60006 for ; Thu, 2 Dec 2021 19:59:16 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET Date: Thu, 02 Dec 2021 21:56:02 +0200 Message-ID: <865ys6zsq5.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Tags: patch This is not a regression. While navigating forward with C-s in a buffer with invisible overlays such as when using outline-minor-mode with hidden outlines, it opens hidden overlays on the current match, and hides again when going to the next match. But going back with DEL (isearch-delete-char) doesn't reopen the hidden overlay on the previous match. Here is the fix: diff --git a/lisp/isearch.el b/lisp/isearch.el index fcb7d646c6..8421c5629b 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -2504,6 +2552,10 @@ isearch-delete-char (if (null (cdr isearch-cmds)) (ding) (isearch-pop-state)) + ;; When going back to the hidden match, reopen it. + (when (and (eq search-invisible 'open) isearch-hide-immediately isearch-other-end) + (isearch-range-invisible (min (point) isearch-other-end) + (max (point) isearch-other-end))) (isearch-update)) (defun isearch-del-char (&optional arg) -- From unknown Sun Jun 22 07:48:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52248: Open hidden overlays in isearch-delete-char Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Dec 2021 17:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52248 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 52248@debbugs.gnu.org Received: via spool by 52248-submit@debbugs.gnu.org id=B52248.16385516346307 (code B ref 52248); Fri, 03 Dec 2021 17:14:01 +0000 Received: (at 52248) by debbugs.gnu.org; 3 Dec 2021 17:13:54 +0000 Received: from localhost ([127.0.0.1]:52147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtC8A-0001df-5J for submit@debbugs.gnu.org; Fri, 03 Dec 2021 12:13:54 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtC88-0001dT-KC for 52248@debbugs.gnu.org; Fri, 03 Dec 2021 12:13:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=74gyYf1GokiWr2xJTaFZX5npUIz7HjYreSpwnG9Y3uw=; b=ihMQl6EjImwZEf9gXRJQICtery vmQ7ZnSnLfTWbIPPqara+bJdgQdcuJwTJbup3kuxb6Uu1oUGErCaO+A2S7flJw+LEGbGiVfRS5Gwf vwrMbw3jPzYNAoBH1GzRurqlmtnerx8asfavzNFbfyfpRip+0VIqRZyZ3/6vRrjQV4fg=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtC80-0004pJ-7K; Fri, 03 Dec 2021 18:13:46 +0100 From: Lars Ingebrigtsen References: <865ys6zsq5.fsf@mail.linkov.net> X-Now-Playing: Joni Mitchell's _Dog Eat Dog_: "The Three Great Stimulants" Date: Fri, 03 Dec 2021 18:13:43 +0100 In-Reply-To: <865ys6zsq5.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 02 Dec 2021 21:56:02 +0200") Message-ID: <87a6hhvcfs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > But going back with DEL (isearch-delete-char) doesn't reopen > the hidden overlay on the previous match. Here is the fix: I haven't tested the patch, but it makes sense to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Juri Linkov writes: > But going back with DEL (isearch-delete-char) doesn't reopen > the hidden overlay on the previous match. Here is the fix: I haven't tested the patch, but it makes sense to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 07:48:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52248: Open hidden overlays in isearch-delete-char Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 20:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52248 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 52248@debbugs.gnu.org Received: via spool by 52248-submit@debbugs.gnu.org id=B52248.163864860616563 (code B ref 52248); Sat, 04 Dec 2021 20:11:01 +0000 Received: (at 52248) by debbugs.gnu.org; 4 Dec 2021 20:10:06 +0000 Received: from localhost ([127.0.0.1]:55082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtbMD-0004J4-R0 for submit@debbugs.gnu.org; Sat, 04 Dec 2021 15:10:05 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:41785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtbMC-0004Hi-0s; Sat, 04 Dec 2021 15:10:04 -0500 Received: (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 28CFE20004; Sat, 4 Dec 2021 20:09:54 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <865ys6zsq5.fsf@mail.linkov.net> <87a6hhvcfs.fsf@gnus.org> Date: Sat, 04 Dec 2021 22:05:16 +0200 In-Reply-To: <87a6hhvcfs.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 03 Dec 2021 18:13:43 +0100") Message-ID: <86wnkkrv9f.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 52248 29.0.50 quit >> But going back with DEL (isearch-delete-char) doesn't reopen >> the hidden overlay on the previous match. Here is the fix: > > I haven't tested the patch, but it makes sense to me. So pushed to master.