From unknown Thu Jun 19 14:00:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52247 <52247@debbugs.gnu.org> To: bug#52247 <52247@debbugs.gnu.org> Subject: Status: [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime. Reply-To: bug#52247 <52247@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:00:44 +0000 retitle 52247 [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime. reassign 52247 guix-patches submitter 52247 Vinicius Monego severity 52247 normal tag 52247 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 02 11:19:07 2021 Received: (at submit) by debbugs.gnu.org; 2 Dec 2021 16:19:07 +0000 Received: from localhost ([127.0.0.1]:49056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msonb-0004e9-8B for submit@debbugs.gnu.org; Thu, 02 Dec 2021 11:19:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:52536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msonZ-0004e1-6J for submit@debbugs.gnu.org; Thu, 02 Dec 2021 11:19:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msonZ-0004cZ-0t for guix-patches@gnu.org; Thu, 02 Dec 2021 11:19:05 -0500 Received: from mout02.posteo.de ([185.67.36.66]:59563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msonV-0004Oy-MH for guix-patches@gnu.org; Thu, 02 Dec 2021 11:19:04 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 17A29240105 for ; Thu, 2 Dec 2021 17:18:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1638461938; bh=nNEnuItXZzstEpsFlCWizxFfcqhRdM8CWRYfa7PO87Y=; h=From:To:Cc:Subject:Date:From; b=eBm9BGtdfuo+gmpUFmf/a92rLkqTzQFPrNL6g/bm1VRZRlFeCwMX7pdsfZycJXkDv yrzYTBtaXQ7rvJGoAilHCCiyyPSkbZS1dWa1hFAEzfmDp/c53evOUn52v0XiCr44u6 nw+2QTnoLaHLhz496TvMQ3z0S07uco2kPN11yEjOGhpuNH3XLROkbrm9jC1TWJjYs5 xjBrWMpXXkK0G0u5Aej5Hlsf5dK44a6GFpjVSgWIMkNCc/QN/4AVUKb8q+XKtHG57r 3avnAKqhRAY2DKPIPdTSnE79PWWv7zGOBwaX0krlFPMv0QbQiSb+ICg0upegCzYXJd W76rs/SemhDoQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4J4h3N5h6pz6tnq; Thu, 2 Dec 2021 17:18:56 +0100 (CET) From: Vinicius Monego To: guix-patches@gnu.org Subject: [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime. Date: Thu, 2 Dec 2021 16:18:17 +0000 Message-Id: <20211202161817.554276-1-monego@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=monego@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Vinicius Monego X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/video.scm (shotcut)[arguments]<:#phases>: Symlink ffmpeg and mlt binaries to the Shotcut bin folder and remove unused PATH and MLT_PREFIX environment variables in the 'wrap-executable phase. --- fixes 50433 gnu/packages/video.scm | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index eeabb11bcf..dcc2f59357 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -4918,16 +4918,23 @@ transitions, and effects and then export your film to many common formats.") (frei0r (assoc-ref inputs "frei0r-plugins")) (ffmpeg (assoc-ref inputs "ffmpeg")) (jack (assoc-ref inputs "jack")) + (mlt (assoc-ref inputs "mlt")) (sdl2 (assoc-ref inputs "sdl2"))) + ;; Shotcut looks for ffmpeg and melt executables in the shotcut + ;; directory. Symlink them to be found at runtime. + (for-each (lambda (file) + (symlink (string-append ffmpeg "/bin/" file) + (string-append out "/bin/" file))) + '("ffmpeg" "ffplay" "ffprobe")) + (for-each (lambda (file) + (symlink (string-append mlt "/bin/" file) + (string-append out "/bin/" file))) + '("melt" "melt-7")) (wrap-program (string-append out "/bin/shotcut") - `("PATH" ":" prefix - ,(list (string-append ffmpeg "/bin"))) `("LD_LIBRARY_PATH" ":" prefix ,(list (string-append jack "/lib" ":" sdl2 "/lib"))) `("FREI0R_PATH" ":" = - (,(string-append frei0r "/lib/frei0r-1/"))) - `("MLT_PREFIX" ":" = - (,(assoc-ref inputs "mlt")))))))))) + (,(string-append frei0r "/lib/frei0r-1/")))))))))) (native-inputs `(("pkg-config" ,pkg-config) ("python" ,python-wrapper) base-commit: fab80c36720bbdb85730708d0dc5fceabcc22a6e -- 2.30.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 02 14:16:51 2021 Received: (at 52247) by debbugs.gnu.org; 2 Dec 2021 19:16:51 +0000 Received: from localhost ([127.0.0.1]:49306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msrZb-0007Hy-Hs for submit@debbugs.gnu.org; Thu, 02 Dec 2021 14:16:51 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:39187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msrZX-0007Hi-7S for 52247@debbugs.gnu.org; Thu, 02 Dec 2021 14:16:49 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C26F93200F76; Thu, 2 Dec 2021 14:16:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 02 Dec 2021 14:16:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=tfnVnVmQV3uDS/vQRqq58PU3 eg3ZPaFyn6zESD1OJ3U=; b=GgMguPy89yH6C4iKmJhJMCfZBOZP979CPlhdFYZ/ CTUOF6LVSUuVr77AzCfPpQiWSIn4+/DiPaNybj7D38TonSlScdDObHD48rO76D66 HN2ayu482RBVUPAvWLgQ8+y7yXdCgPnbXvLCfmN85TYgIgbZfj0PPesHdi0tsl/o 7M8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=tfnVnV mQV3uDS/vQRqq58PU3eg3ZPaFyn6zESD1OJ3U=; b=eepBhyM1a/qrJ5VAweRxAe KKphBmFV3QekLARWWvY/b8hGWZaSfKuJRdbgeBehCodNCQRfwSYaBhYL4tFPmpj9 Vs9zxnIHJFWHJ9bAixGFh/zTVC4DNvxpQ7Cq5x4UIAC860uAcKV+ukul0Ju78gup dgh6gYncvVuQWkZBi1+Op6XDa/eclEIlCfKNZgooBg2PoOC0fy57u6gPDelzFeh3 oxD5sE8t2s7welpO3U6merKg3ge7K7EN3P/mQy1ksQvtGkVt9HYiIjIv5Q/mF/Mw asQVGX5U8Zbd7yIu+wr14Xf+L7UaPhnG16Z1OhS4MAIE2Ghm9yrGgpGsGha5BnfA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrieehgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeigfdvhfefvdeitdduudegffevvdfgfeetuedugfdvuddugefftedugedtuddt vdenucffohhmrghinhepghhnuhdrohhrghdpghhithhhuhgsrdgtohhmpdgsuhhilhguqd hshhhothgtuhhtrdhshhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Dec 2021 14:16:39 -0500 (EST) Date: Thu, 2 Dec 2021 14:16:38 -0500 From: Leo Famulari To: Vinicius Monego Subject: Re: [bug#52247] [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime. Message-ID: References: <20211202161817.554276-1-monego@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202161817.554276-1-monego@posteo.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52247 Cc: 52247@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Dec 02, 2021 at 04:18:17PM +0000, Vinicius Monego wrote: > * gnu/packages/video.scm (shotcut)[arguments]<:#phases>: Symlink ffmpeg and > mlt binaries to the Shotcut bin folder and remove unused PATH and MLT_PREFIX > environment variables in the 'wrap-executable phase. I read your message about this in #50433: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50433#17 The first link, which points to code that copies "files from other projects to its bin directory", is in a function named deploy_mac, so I don't think it's relevant for us. Overall, I think it's unusual that we would copy or symlink one program into another like this. I read build-shotcut.sh and it seems they actually intend to compile ffmpeg themselves... https://github.com/mltframework/shotcut/blob/af9f47882d64eb15105559e0729bc7b1e337a9bf/scripts/build-shotcut.sh#L1352 ... and then use a wrapper script to point to it: https://github.com/mltframework/shotcut/blob/af9f47882d64eb15105559e0729bc7b1e337a9bf/scripts/build-shotcut.sh#L1369 That's weird for something as common as ffmpeg, although I actually have some private packages based on custom ffmpeg, so I am sympathetic. I think we should ask upstream for advice. They do support distro packagers, apparently: https://github.com/mltframework/shotcut/issues/769#issuecomment-528686712 Can you do that? I can do it if you'd rather not. And I'm sorry if you already knew all this and I'm just wasting your time. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 12:03:19 2021 Received: (at 52247) by debbugs.gnu.org; 18 Dec 2021 17:03:19 +0000 Received: from localhost ([127.0.0.1]:43695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myd78-0004zA-UA for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:03:19 -0500 Received: from mout02.posteo.de ([185.67.36.66]:57577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myd76-0004yv-Qs for 52247@debbugs.gnu.org; Sat, 18 Dec 2021 12:03:17 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8CC27240104 for <52247@debbugs.gnu.org>; Sat, 18 Dec 2021 18:03:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1639846990; bh=gIiJWsdBz/eRW9yOCvg42+rKHwffIpzHUUjA4sMpgGU=; h=Subject:From:To:Cc:Date:From; b=YLZDHJKyO7de3KCnFsR3SLNsnjEt5VDGEx1f1scNkGr0mCOTj7M2TFrEXrkOCodAi wH1GRwzym6EdxsVoqGzTlRtHAbmQBQ3Ae3edlepiuMpdchgEN+xuOmCXV6knPkSD1Y DywJvwGw8/4MIvKWAQ4ZtEDn+ByyQutDEB+uTsdwhBjy+QPq/jIKbLbVLy0gIJo7V/ lvDR3uwOKWnv9YhpOb/7O95Q8QYl10pNbA7SRJGbF6iLb4FzK2elLsUsU3SZ/ff0bZ t3OdnYfOU+14+bPmgS93cv33eWYpxB10lpicXorXyxIuINEZpMsN/7SE29cy7Rcewh L0Yk/ZbcF7J6g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JGXH03qM6z9rxS; Sat, 18 Dec 2021 18:03:08 +0100 (CET) Message-ID: Subject: Re: [bug#52247] [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime. From: Vinicius Monego To: Leo Famulari Date: Sat, 18 Dec 2021 17:02:59 +0000 In-Reply-To: References: <20211202161817.554276-1-monego@posteo.net> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52247 Cc: 52247@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Em qui, 2021-12-02 às 14:16 -0500, Leo Famulari escreveu: > On Thu, Dec 02, 2021 at 04:18:17PM +0000, Vinicius Monego wrote: > > * gnu/packages/video.scm (shotcut)[arguments]<:#phases>: Symlink > > ffmpeg and > > mlt binaries to the Shotcut bin folder and remove unused PATH and > > MLT_PREFIX > > environment variables in the 'wrap-executable phase. > > I read your message about this in #50433: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50433#17 > > The first link, which points to code that copies "files from other > projects to its bin directory", is in a function named deploy_mac, so > I > don't think it's relevant for us. > > Overall, I think it's unusual that we would copy or symlink one > program > into another like this. I read build-shotcut.sh and it seems they > actually intend to compile ffmpeg themselves... > > https://github.com/mltframework/shotcut/blob/af9f47882d64eb15105559e0729bc7b1e337a9bf/scripts/build-shotcut.sh#L1352 > > ... and then use a wrapper script to point to it: > > https://github.com/mltframework/shotcut/blob/af9f47882d64eb15105559e0729bc7b1e337a9bf/scripts/build-shotcut.sh#L1369 > > That's weird for something as common as ffmpeg, although I actually > have > some private packages based on custom ffmpeg, so I am sympathetic. > > I think we should ask upstream for advice. They do support distro > packagers, apparently: > > https://github.com/mltframework/shotcut/issues/769#issuecomment-528686712 > > Can you do that? I can do it if you'd rather not. And I'm sorry if > you > already knew all this and I'm just wasting your time. Hi, How about this solution? https://github.com/NixOS/nixpkgs/blob/aecab6adbd682960b1b341cf20e4c53ddf722104/pkgs/applications/video/shotcut/default.nix#L59 It expands the executable names to the full store paths in the files where they are called. Could be done with substitutions in a phase. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 13:12:54 2021 Received: (at 52247) by debbugs.gnu.org; 18 Dec 2021 18:12:54 +0000 Received: from localhost ([127.0.0.1]:43789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myeCT-0006nl-SJ for submit@debbugs.gnu.org; Sat, 18 Dec 2021 13:12:54 -0500 Received: from mout01.posteo.de ([185.67.36.65]:47423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myeCQ-0006nW-Kh for 52247@debbugs.gnu.org; Sat, 18 Dec 2021 13:12:52 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 69BAF240026 for <52247@debbugs.gnu.org>; Sat, 18 Dec 2021 19:12:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1639851164; bh=zA5wneQj3wpceVJFZVTnpZCmnPmJoW4bUyBhSBQ+R0g=; h=From:To:Cc:Subject:Date:From; b=q+7gslnq+o2NPcXFBdzVSFV1PiMPqgQNVDbTkRMOO6UtpVB811eiAOlvapDDMDIaG BbHFCPOgcbP7ZFLhjCfA6mHchqsPRd5cyhS5KYFe9XAMh7TOWbMuT78vUX0PrbDS0+ NWdozEjS4W0bPRxTPD77REFocMFwuulJj6sZ6ZGoioADWJyYNNkZmAO1JIDb99P0as Pt9Khtp6IpaFAg+Ep3kEyJ7SB4pk90t8cvrJZK77SRj/dTt6tJXO22MVMFHqgvsqdk F9iiqJYIj77IQ9+xtNwKvUMTisaenFdTdoCgD+CIFrSm47p0EpuLhxDJ0xPlRF7upz Y3uLsWQlERxhw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JGYqH1qdSz6tmL; Sat, 18 Dec 2021 19:12:42 +0100 (CET) From: Vinicius Monego To: 52247@debbugs.gnu.org Subject: [PATCH v2 1/2] gnu: shotcut: Find ffmpeg and mlt at runtime. Date: Sat, 18 Dec 2021 18:12:26 +0000 Message-Id: <20211218181227.82026-1-monego@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52247 Cc: Vinicius Monego X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/video.scm (shotcut)[arguments]<:#phases>: Add phase 'patch-executable-paths to use full store paths for ffmpeg and mlt. --- This adds the suggestion from above, using just the string for replacement. gnu/packages/video.scm | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 4b7251ee23..9b5738358b 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -4818,9 +4818,20 @@ transitions, and effects and then export your film to many common formats.") (base32 "0jgv6wl65gf6c4nmfica8k9vbgn3w3594d1phx1mb7zjvyy9y97k")))) (build-system qt-build-system) (arguments - `(#:tests? #f ;there are no tests + `(#:tests? #f ;there are no tests #:phases (modify-phases %standard-phases + (add-after 'unpack 'patch-executable-paths + (lambda* (#:key inputs #:allow-other-keys) + ;; Shotcut expects ffmpeg and melt executables in the shotcut + ;; directory. Use full store paths. + (let* ((ffmpeg (assoc-ref inputs "ffmpeg")) + (mlt (assoc-ref inputs "mlt"))) + (substitute* "src/jobs/ffmpegjob.cpp" + (("\"ffmpeg\"") (string-append "\"" ffmpeg "/bin/ffmpeg\""))) + (substitute* "src/jobs/meltjob.cpp" + (("\"melt\"") (string-append "\"" mlt "/bin/melt\"")) + (("\"melt-7\"") (string-append "\"" mlt "/bin/melt-7\"")))))) (replace 'configure (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out"))) base-commit: 86d6c6053c7d1c7a82c83f0daf0f5e09b1ecfb63 -- 2.30.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 13:13:02 2021 Received: (at 52247) by debbugs.gnu.org; 18 Dec 2021 18:13:02 +0000 Received: from localhost ([127.0.0.1]:43793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myeCY-0006o4-5J for submit@debbugs.gnu.org; Sat, 18 Dec 2021 13:13:02 -0500 Received: from mout02.posteo.de ([185.67.36.66]:52695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myeCW-0006nc-Im for 52247@debbugs.gnu.org; Sat, 18 Dec 2021 13:12:57 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 28B2F240106 for <52247@debbugs.gnu.org>; Sat, 18 Dec 2021 19:12:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1639851170; bh=d6aOIr2/5X/UKgxh4MQzh8EK9Q1K3lEEuU6UFsgSUCY=; h=From:To:Cc:Subject:Date:From; b=NEe3PCucXRrDguia8BmXe69WjLGugWllK+AHlc25LOyx6yvyLiKDWEQ8nE3d92zHw 5bwXgiwNppq0NZqN4htkGAncKFFulNDZxTP1xWAb4BaNNh5xoN9WaEsWayR79tKwYH 83uLKMcwrH0S5EeDyyUpQvUcQayWIUhX/3WlQstt86ITlQQMmrNyteMQ7NAYv+y7xL BGsv8Ohexf4bLJHKAbxI3CVZat0gCmuUFAFYkYvKHRwJyiLGDs5ndnsdKStOM6pEqy FBZr7emIoP+/5l61TjM8DZzPp0tnJkaWKI1xb1jrh0WnmKgA9NzGbsxMSnC49FU8Bb b9U+5po3l9TmQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JGYqN4Km5z9rxL; Sat, 18 Dec 2021 19:12:48 +0100 (CET) From: Vinicius Monego To: 52247@debbugs.gnu.org Subject: [PATCH v2 2/2] gnu: shotcut: Adjust environment variables in 'wrap-program. Date: Sat, 18 Dec 2021 18:12:27 +0000 Message-Id: <20211218181227.82026-2-monego@posteo.net> In-Reply-To: <20211218181227.82026-1-monego@posteo.net> References: <20211218181227.82026-1-monego@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52247 Cc: Vinicius Monego X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/video.scm (shotcut)[arguments]<#:phases>: In the 'wrap-program phase, wrap LADSPA_PATH, don't wrap MLT_PREFIX, remove trailing slash from FREI0R_PATH, remove ffmpeg and add mlt to PATH. --- gnu/packages/video.scm | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 9b5738358b..30d6341c59 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -4844,18 +4844,19 @@ transitions, and effects and then export your film to many common formats.") (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (frei0r (assoc-ref inputs "frei0r-plugins")) - (ffmpeg (assoc-ref inputs "ffmpeg")) (jack (assoc-ref inputs "jack")) + (ladspa (assoc-ref inputs "ladspa")) + (mlt (assoc-ref inputs "mlt")) (sdl2 (assoc-ref inputs "sdl2"))) (wrap-program (string-append out "/bin/shotcut") - `("PATH" ":" prefix - ,(list (string-append ffmpeg "/bin"))) + `("FREI0R_PATH" ":" = + (,(string-append frei0r "/lib/frei0r-1"))) + `("LADSPA_PATH" ":" = + (,(string-append ladspa "/lib/ladspa"))) `("LD_LIBRARY_PATH" ":" prefix ,(list (string-append jack "/lib" ":" sdl2 "/lib"))) - `("FREI0R_PATH" ":" = - (,(string-append frei0r "/lib/frei0r-1/"))) - `("MLT_PREFIX" ":" = - (,(assoc-ref inputs "mlt")))))))))) + `("PATH" ":" prefix + ,(list (string-append mlt "/bin")))))))))) (native-inputs `(("pkg-config" ,pkg-config) ("python" ,python-wrapper) -- 2.30.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 26 18:38:48 2021 Received: (at 52247-done) by debbugs.gnu.org; 26 Dec 2021 23:38:48 +0000 Received: from localhost ([127.0.0.1]:41858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1d6G-0004v1-8I for submit@debbugs.gnu.org; Sun, 26 Dec 2021 18:38:48 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:34183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1d6E-0004uj-3J for 52247-done@debbugs.gnu.org; Sun, 26 Dec 2021 18:38:46 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DAF3A32009DB; Sun, 26 Dec 2021 18:38:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 26 Dec 2021 18:38:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=UysrupG40Avh2nXAzOEQeKg4 9aZ4A55gM74XXObvZcQ=; b=eLqJk9v+cLtFMG4yhYRa28E/5wqD3Q5jCvgST52h CBAmurVixlXiTugjalCaBN00IbzszWTx0wndKKaOgFsjDDO46SfMETFupNGcJnIR 1rlRyUiSdYSz7+wpOYVYt8XjzHRCOITYHgYuh4mugN1EeBvqW1IqrD4uqBe6Klvw P4I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Uysrup G40Avh2nXAzOEQeKg49aZ4A55gM74XXObvZcQ=; b=feMcr99NmGCYhBG9nWW8Wz RMI+2ZoN6plIVn8/DfDLrIw+Jc2yQ5eZC0C5KExoX326HFqrgzZDrrtM0ySuxtnq oMrMl1BmoSzAybz/L0okDWXRt2pqm/nyxcV2NyJcYkH++NbEKldiF9s1ohDHZnKb EDWau24Ri0rajtqBLglCukdpUOMYhcMx9Me2Nwru/xxUV9lmSosQxzi8jTSutm8G 0QPQpbooupi+cvb9M1PTIgU2yL6UM8Q2sZFdHfmB6/hb2X8GBMPkRnbpJo/bOe8g OZ+/UvU2RF+I9aAv2Qu5J9YiCb9bNNxIDTFoICLRD+QuhR3nBxy2dNNkX8nuxojA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Dec 2021 18:38:38 -0500 (EST) Date: Sun, 26 Dec 2021 18:38:32 -0500 From: Leo Famulari To: Vinicius Monego Subject: Re: [bug#52247] [PATCH v2 1/2] gnu: shotcut: Find ffmpeg and mlt at runtime. Message-ID: References: <20211202161817.554276-1-monego@posteo.net> <20211218181227.82026-1-monego@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211218181227.82026-1-monego@posteo.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52247-done Cc: 52247-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Dec 18, 2021 at 06:12:26PM +0000, Vinicius Monego wrote: > * gnu/packages/video.scm (shotcut)[arguments]<:#phases>: Add phase > 'patch-executable-paths to use full store paths for ffmpeg and mlt. Thanks! Pushed as 4e9895b462a004ac69ee92f544fe39b6c42d8525 From unknown Thu Jun 19 14:00:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 Jan 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator