Subject: Re: [PATCH] gnu: Add MEGA SDK

From: Liliana Marie Prikler <[email-masked]>
Date: Sat, 18 Dec 2021 00:22:09 +0100

Hi,

Am Freitag, dem 17.12.2021 um 22:30 +0000 schrieb Jaft:
> 
> >  > +      (home-page "https://mega.nz/sdk")
> >  > +      (synopsis "SDK for the MEGA service, offered by MEGA
> > Limited")
> >  Sponsored by RAID: Shadow Legends.
> 
> I don't understand what this is communicating.
The joke is that you make it sound like and advertisement.

> +    (native-inputs `(("autoconf" ,autoconf)
> +                     ("automake" ,automake)
> +                     ("libtool" ,libtool)))
> +    (inputs `(("c-ares" ,c-ares)
> +              ("crypto++" ,crypto++)
> +              ("curl" ,curl)
> +              ("freeimage" ,freeimage)
> +              ("libsodium" ,libsodium)
> +              ("openssl" ,openssl)
> +              ("readline" ,readline)
> +              ("sqlite" ,sqlite)
> +              ("zlib" ,zlib)))
Since core-update's been merged now, try to use new-style inputs.

> +    ;; XXX: Disabling tests because they depend on libgtest.la from
> googletest,
> +    ;; which is not installed for unclear reasons.
> +    (arguments `(#:tests? #f))
Unclear reasons including googletest not being present in the inputs? 
You probably want to swap out the .la dependency for a .so dependency.

>  (define-public megacmd
>    (package
>      (name "megacmd")
> @@ -222,8 +262,7 @@ (define-public megacmd
>          (method git-fetch)
>          (uri (git-reference
>                (url "https://github.com/meganz/MEGAcmd")
> -              (commit (string-append version "_Linux"))
> -              (recursive? #t)))
> +              (commit (string-append version "_Linux"))))
>          (sha256
>           (base32
>            "004j8m3xs6slx03g2g6wzr97myl2v3zc09wxnfar5c62a625pd53"))
> @@ -242,6 +281,7 @@ (define-public megacmd
>         ("curl" ,curl)
>         ("freeimage" ,freeimage)
>         ("gtest" ,googletest)
> +       ("mega-sdk" ,mega-sdk)
>         ("openssl" ,openssl)
>         ("pcre" ,pcre)
>         ("readline" ,readline)
Pardon me if I was unclear, but this would be done in a separate
commit.  But thanks anyway for confirming that it'd be easily
swappable.

Cheers