From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 06:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 52237@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16384251905382 (code B ref -1); Thu, 02 Dec 2021 06:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Dec 2021 06:06:30 +0000 Received: from localhost ([127.0.0.1]:46350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msfEj-0001Ok-KE for submit@debbugs.gnu.org; Thu, 02 Dec 2021 01:06:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:47414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msfEh-0001Oc-2W for submit@debbugs.gnu.org; Thu, 02 Dec 2021 01:06:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msfEg-0002um-IH for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 01:06:26 -0500 Received: from [2607:f8b0:4864:20::534] (port=41581 helo=mail-pg1-x534.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msfEW-0000aE-8a for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 01:06:24 -0500 Received: by mail-pg1-x534.google.com with SMTP id k4so15875115pgb.8 for ; Wed, 01 Dec 2021 22:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:message-id:date:mime-version:content-language; bh=1XWvp6Jzp0Ze/MGDl4JkhsasZVp2gr7y6guA71ZAi8M=; b=DK3nskfYaP7c20zfcTT+41+gUd52njhd4tZgM+uQfmIaU4tqDHMER/xse1q5atKdp+ bf2+flfhl+0yQA/+jARoqMP6Px9IV+AvyNLkBRxtrICUPa0/Nz+tIXRIajuqUnmi6S3u 2QKIaFhRIjVqEaU5bPfx0igei/tnsokAn2gV+Hws8189ma5M9aEuxUvH26l0pJ38/sXp /GakSE2HudxgGOxDuvOxcFjwan0208MIWB0YcEFPJqgaaDJT8Dbr78o6vnhOiMzm/2zZ itt9DCsJhgvy3Xodnw1GKERHWVdfOGL87/i+uxgJPIR++hhGZj/xc/NABL1pwZu7rxeI HQsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language; bh=1XWvp6Jzp0Ze/MGDl4JkhsasZVp2gr7y6guA71ZAi8M=; b=zo+9U6/Mlc8gKTWCgVvJ4mzkMuh9Gw9dfQY5RN9zM4DNNgLWv1YdtBporjWRJFZR+v MLFuqG3uaPK8IwhA6y0Ae3VZzGFbM/stRAvumAlfP4r7KcyAdDJ2OSK4H47Gx/oKjkp0 h49xMcf6dtRfqVk1tfoIw/1t1AJHoCKHPJDsQ7aEC4y4W0zxneasarxKEuBMfZ38DNNe ZoVls7STK2cBOlYkEZetP5hmZK7jgNsuF1l+e1YxEEmMFVDjFZ3nCJ1D9FZQXP6OkBXE 8TYsTcVZeDRgi33ZUYUCXnB0fNu28PDH182Knr04ppb0o3jGNOgHt93naz1UliK+tOPo QQ4A== X-Gm-Message-State: AOAM532YtdPQi03pw6SXBXruNkA1RuNNdx64E1wTv53X5lAGdqZwV5vH MwOqS85D6iNWfERAIepIsnWWySpPHug= X-Google-Smtp-Source: ABdhPJxCkCI3zVXXov5zgL1n3NOyQoV6XN2eiag1I3LrdKLQ4MlYbwauck7AqC84nfyBaOxarc/y0A== X-Received: by 2002:a63:490c:: with SMTP id w12mr8351653pga.398.1638425174398; Wed, 01 Dec 2021 22:06:14 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c3sm1834029pfv.67.2021.12.01.22.06.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Dec 2021 22:06:13 -0800 (PST) X-Mozilla-News-Host: news://news.gmane.org:119 From: Jim Porter Message-ID: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> Date: Wed, 1 Dec 2021 22:06:13 -0800 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2E7E790652426583308AC00B" Content-Language: en-US X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::534 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x534.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------2E7E790652426583308AC00B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sometimes, menu separators are doubled up in context-menu-mode. To see this in action: emacs -Q --eval '(context-menu-mode)' ;; Right-click somewhere in the scratch buffer, like the empty area. You should see a double separator just before "Lisp-Interaction". `context-menu-map' tries to eliminate doubled separators, but it doesn't account for *tripled* separators. If we have a menu like so ("->" is the current list item when iterating): -> (separator-foo "--") (separator-bar "--") (separator-baz "--") (regular-item "Item") The duplicate remover sees that both the current item and the next are separators, so removes it: -> (separator-foo "--") (separator-baz "--") (regular-item "Item") But then the very next operation is to move to the next list item: (separator-foo "--") -> (separator-baz "--") (regular-item "Item") Now, on the next iteration of the while loop, it won't detect the duplicate because it's too far ahead. Attached is a patch to fix this; it only advances to the next list item when it *didn't* just delete a duplicate separator. That way, it can keep deleting subsequent dupes until it sees a non-separator item. I've only tested this on Emacs 29 so far, but it may occur on Emacs 28 as well. Also, I noticed that separators can appear at the beginning and/or end of the context menu. Should they be removed too? --------------2E7E790652426583308AC00B Content-Type: text/plain; charset=UTF-8; name="0001-Ensure-there-are-no-duplicate-separators-when-creati.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Ensure-there-are-no-duplicate-separators-when-creati.pa"; filename*1="tch" RnJvbSBiNTk4M2I5MjBlYmEzMmZhOTQ0NzU4ZjUxMGNiNWZlZTZjMjgxZDRiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMSBEZWMgMjAyMSAyMTo1NTozMSAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIEVuc3VyZSB0aGVyZSBhcmUgbm8gZHVwbGljYXRlIHNlcGFyYXRvcnMgd2hlbiBjcmVh dGluZyBhCiBjb250ZXh0IG1lbnUKClByZXZpb3VzbHksIGlmIHRoZXJlIHdlcmUgdGhyZWUg b3IgbW9yZSBjb25zZWN1dGl2ZSBtZW51IHNlcGFyYXRvcnMsCm5vdCBhbGwgb2YgdGhlbSB3 b3VsZCBiZSByZW1vdmVkLgoKKiBsaXNwL21vdXNlLmVsIChjb250ZXh0LW1lbnUtbWFwKTog RW5zdXJlIG5vIGR1cGxpY2F0ZSBzZXBhcmF0b3JzLgotLS0KIGxpc3AvbW91c2UuZWwgfCA4 ICsrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvbW91c2UuZWwgYi9saXNwL21vdXNlLmVsCmluZGV4 IDNhYjlmYmNkZmUuLmVjNDNhZWNkZDAgMTAwNjQ0Ci0tLSBhL2xpc3AvbW91c2UuZWwKKysr IGIvbGlzcC9tb3VzZS5lbApAQCAtMzMwLDEwICszMzAsMTAgQEAgY29udGV4dC1tZW51LW1h cAogICAgIDs7IFJlbW92ZSBkdXBsaWNhdGUgc2VwYXJhdG9ycwogICAgIChsZXQgKChsIG1l bnUpKQogICAgICAgKHdoaWxlIChjb25zcCBsKQotICAgICAgICAod2hlbiAoYW5kIChlcXVh bCAoY2RyLXNhZmUgKGNhciBsKSkgbWVudS1iYXItc2VwYXJhdG9yKQotICAgICAgICAgICAg ICAgICAgIChlcXVhbCAoY2RyLXNhZmUgKGNhZHIgbCkpIG1lbnUtYmFyLXNlcGFyYXRvcikp Ci0gICAgICAgICAgKHNldGNkciBsIChjZGRyIGwpKSkKLSAgICAgICAgKHNldHEgbCAoY2Ry IGwpKSkpCisgICAgICAgIChpZiAoYW5kIChlcXVhbCAoY2RyLXNhZmUgKGNhciBsKSkgbWVu dS1iYXItc2VwYXJhdG9yKQorICAgICAgICAgICAgICAgICAoZXF1YWwgKGNkci1zYWZlIChj YWRyIGwpKSBtZW51LWJhci1zZXBhcmF0b3IpKQorICAgICAgICAgICAgKHNldGNkciBsIChj ZGRyIGwpKQorICAgICAgICAgIChzZXRxIGwgKGNkciBsKSkpKSkKIAogICAgICh3aGVuIChm dW5jdGlvbnAgY29udGV4dC1tZW51LWZpbHRlci1mdW5jdGlvbikKICAgICAgIChzZXRxIG1l bnUgKGZ1bmNhbGwgY29udGV4dC1tZW51LWZpbHRlci1mdW5jdGlvbiBtZW51IGNsaWNrKSkp Ci0tIAoyLjI1LjEKCg== --------------2E7E790652426583308AC00B-- From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163843348627812 (code B ref 52237); Thu, 02 Dec 2021 08:25:01 +0000 Received: (at 52237) by debbugs.gnu.org; 2 Dec 2021 08:24:46 +0000 Received: from localhost ([127.0.0.1]:46441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mshOY-0007EW-1F for submit@debbugs.gnu.org; Thu, 02 Dec 2021 03:24:46 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mshOU-0007ED-1d for 52237@debbugs.gnu.org; Thu, 02 Dec 2021 03:24:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VfwD78VbnMGvMTCyQruq60F2U0+SbQ/56yKfKpm8CZ0=; b=PIp2+cdiQAGhCkk6hqPdkzC7O2 SlbbTlGZyrIiOy03kqBkf79jspcarIPmcuAT4tvXAp6tQ8yqzGA/3go9qGojHiMF8TcasA6D6LXku guiYxBaZArOeCkJR8vEgNwCP4XHLW6rYb/vr8T5XrIk8SvTECm8NEaxLbZDASWaOPuFE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mshOL-0007KV-4M; Thu, 02 Dec 2021 09:24:35 +0100 From: Lars Ingebrigtsen References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> X-Now-Playing: Normil Hawaiians's _Return of the Ranters_: "Mouldwarp's Journey..." Date: Thu, 02 Dec 2021 09:24:29 +0100 In-Reply-To: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> (Jim Porter's message of "Wed, 1 Dec 2021 22:06:13 -0800") Message-ID: <87wnknmn2a.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > I've only tested this on Emacs 29 so far, but it may occur on Emacs 28 > as well. Thanks; applied to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > I've only tested this on Emacs 29 so far, but it may occur on Emacs 28 > as well. Thanks; applied to Emacs 29. > Also, I noticed that separators can appear at the beginning > and/or end of the context menu. Should they be removed too? Hm... I think that might make sense, but I'm not sure. Anybody got an opinion? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 02 03:24:52 2021 Received: (at control) by debbugs.gnu.org; 2 Dec 2021 08:24:52 +0000 Received: from localhost ([127.0.0.1]:46444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mshOe-0007Eq-80 for submit@debbugs.gnu.org; Thu, 02 Dec 2021 03:24:52 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mshOc-0007EU-Q7 for control@debbugs.gnu.org; Thu, 02 Dec 2021 03:24:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k+VIB2FBDKcgsJtBcvUwmpYvI9WExnrbo+W8DtRqwHQ=; b=Lq8AE2n/+ncsnfr3tfRHMcr81g xYgqhnrzctcobNzMTn2larCLmwOP8KbMVHdSZab10pdIgmo8I6WrkFtKKxxaDuNbDxj8ZgndlpPaD uWZD9jup/CweWQoaMjawbaBgwSIdGO1nziIitrA00SWHNngEZnmLHvvw2EuBk5ca1fyE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mshOV-0007Ke-4Y for control@debbugs.gnu.org; Thu, 02 Dec 2021 09:24:45 +0100 Date: Thu, 02 Dec 2021 09:24:42 +0100 Message-Id: <87v907mn1x.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #52237 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 52237 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 52237 + moreinfo quit From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: [External] : bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 17:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Jim Porter , "52237@debbugs.gnu.org" <52237@debbugs.gnu.org> Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.16384663429551 (code B ref 52237); Thu, 02 Dec 2021 17:33:01 +0000 Received: (at 52237) by debbugs.gnu.org; 2 Dec 2021 17:32:22 +0000 Received: from localhost ([127.0.0.1]:49144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mspwU-0002Ty-8u for submit@debbugs.gnu.org; Thu, 02 Dec 2021 12:32:22 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:62656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mspwP-0002Tm-Os for 52237@debbugs.gnu.org; Thu, 02 Dec 2021 12:32:21 -0500 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B2GSmE0029851; Thu, 2 Dec 2021 17:32:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=+L0+CjcRnuymLNYZ3Nc66B/QJ1qMmzMgfmBe7aftBaw=; b=YIT9N7TvQIdWsPUQn3OgGPaeZNRu1iEiNf85zuwMkYsH1pRSjV4Q3KvYdDKEDnAQWLUN QjKa5Vm5r/fYIO1dpuFfvmzB/ZNkn72mu3lPV3FyxW+L1bQXRJseEWVprC0srtFgu/fU CUNA+ihVa4yvF1D6Oy4EPzkRsikYyYaINEFp35QdoZqYmz12VL4u3B6qA6IcY3tvm6Jt Ki4CmoGl7PzB5uzP96heNbjtTsGsP+pFBsv8+Yf67e+raUH16vCjkbvWbVRh02DVRHnb u4pEekB8AcW3dC8TVdt9StQT2yKbu4xBr55OBiDU0cySXignMFmWoAdno0goYQv+OLvW GQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3cp7wesr8m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Dec 2021 17:32:01 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1B2HFcIV160576; Thu, 2 Dec 2021 17:31:39 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by aserp3030.oracle.com with ESMTP id 3ckaqjw0v3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Dec 2021 17:31:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MXASkOvjOzR/jdIUvkYHbqNR64stnDv0aki2/A3hOEs3Ua6VnEx4K4YW1bff/DB+7x0Dbi3jcpfsUHbGThpu9KuYtQArbflwolCZR4H1Gxcnz0FS09DAB1fwytga51jBw44Gd8fwqjjYUut01Ex92e2+WFx3+VJY3Nk54hzi5d41yYE4Cydu7BeREx0saRm2f8MDma5gqCqjydF5barDdEvf0k5Le/+usjd+2GlnL41vVPYFuz4Qb6YjYy1DNtO3b21vbIpqyJg7t7AfbCfiKAL65O0GPHvzS5HM08WvHonEx0hwGDAPV6E0jrC6AVyliIqB6NUqVWMBfeADAkAK3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+L0+CjcRnuymLNYZ3Nc66B/QJ1qMmzMgfmBe7aftBaw=; b=nnS8DYpOgmjEMjONs6Pvx0+cvxncZV7W2y9xQp0BMWYuCazEx8wWLb7wXS+StO1Ouq2/A42QApch+b5HUUct4JbI2MRCk5ZJG+sZEoIHi2taES34V8ThLkDH2E7xBVVn48fB2q5I+VDFa4/WI28ZjSpEX/M50QaNc4NZl42KwErUEN/YL2eYOoQrwYygSWaCKZr+8qtBWcZSWtoj7dunanvuuQFhkg8RoNXzE60cN80yIn4gciaSMAN4/Ohbb42Nr9IIpPz4pLeCMN68yRe00OWfXIu6saL+p8TKD7oLeZb07xPEiV2/CPb7wEJqUVYcy5KbxVSVbRJgA5x3T86uGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+L0+CjcRnuymLNYZ3Nc66B/QJ1qMmzMgfmBe7aftBaw=; b=AuJru2m0IMG8+MXKfKoGmlLWd+U23GhGCfjauWW6WsQsRxpVsn7trSzbrMBMawD97RSfbfKF2qpWJ7i3mPURAWNpoWqvGxKcGdSA55RXofo5FaO9e4zBbfvCV7zj274kB2g6ub2qKLsCxPzd0a6etZ/H2dh839D12g+qJtC44ik= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB3272.namprd10.prod.outlook.com (2603:10b6:a03:157::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Thu, 2 Dec 2021 17:31:37 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::4588:646c:e330:8bc0]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::4588:646c:e330:8bc0%9]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021 17:31:37 +0000 From: Drew Adams Thread-Topic: [External] : bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Thread-Index: AQHX50LbQnS7xtKzfEupzn2KMsajB6wfdN7w Date: Thu, 2 Dec 2021 17:31:37 +0000 Message-ID: References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> In-Reply-To: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8804fed2-8980-49b8-c942-08d9b5b9983e x-ms-traffictypediagnostic: BYAPR10MB3272: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qRMJ9Rg/3TXt+pjkAHjT2aI6c4IQuVf2aCTOmLFZ39tuo1RcycH99RJW/ISYZMPwOK33TYKplY0pymjVBbdLzFhkMyU2EgcKBa8bJh9WdC89vvQhWe1gk+ncPHJBXXWu4VsfBQe+wfJTmrBXyyKBq9wmInsAyYYVwzdQO6vZd8WE2hhWvH5Udb6pp17qEysS1BYIMFU3K2gL3WmsAt+gfCbykcGczFBhfe9fdaG6fCApKd77LrHI3IMrGdQFDtWSzE25dlozZ19Xp8drCXgtQIBK77PbYD6YCd08IT3eTR9Y5KwuXr8OEWAGaQ3aO1tqZfKH118j1xKzGNzpT3mk1bHLMJZhDh1r75s1JiaG7Nr3EDuefW2R9Z/w12e9ezZJB0ga45vyNnGNPP142D8k5XqgEdaA19L6pRXWYUja2F5XhuYQ6qvVSe3qTgJrBJAwLnDYf7jwXwLqEammleV6K85veKv52tsHb/+M0srhGvKCNbsz1Pv0GPOe0sEiaWTtzYTaPXgrkUR3pf3P8xQAPi0+/SCGx7YIJi2MQX/be+YMOsWJTEuiL2Z8jdP8HISSc35I4tIMYqmPn8fUap+R15J3o3BTBYjwjyZutbQR0MmrXE1CigSUzncCECxFkQAAXparPIGddvkg0dAptVwW52VqrLBNSMAvKSKQtei7Zz/PDEhlwKcneX4ZdLi7OYoeWYYNFJyJEDGAcuSx//1aMw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(33656002)(55016003)(66556008)(71200400001)(66446008)(76116006)(64756008)(110136005)(66476007)(66946007)(316002)(8676002)(186003)(52536014)(86362001)(2906002)(44832011)(7696005)(6506007)(8936002)(26005)(122000001)(38100700002)(38070700005)(4744005)(9686003)(508600001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: RODz6OLNlA9ybh5Q0a/ezKqGQWgw1INauoGO3hf8ThGIBhQbNuctXANvwZ3vR/6VSxiakQlNmPExmHkwrg4AO+a7ksGJILDToY+zLQuFOeXYip87rqaLAa3dQi3c13WJUPgSrLLoLu8eTCiTqEGE2MaON6hO+q97Dy6kLxQi2XvSxo4+dR7ORioriAsBREu3aW0OJCQy/99inUTapf7xm0019RyiGo5s5sbyBbIrdHsm3cT6axcYR/vfcCUYyLtjSEWJqO4XqiuwtYZyr9r0bTJqbSR7wiRqr/Un1vCMmpreSOLVTh0FbWHvHCRzH+1Z9TwoVcnVknRb+pyo0k/w7Y/1I1VEr6TwM10OOpZ04TvfkVt5ExVhJPxZN5KTQfmG9VD2j16ZzXcCLQXvjmStklJyymYfou9dgyB06vq2BYxvt44WELFxqX2hwgBxAjAOGKDpcxt0G3p6EbRTVRkvM+DAHHb1aLaK1N0vqiLUoF5o/igHrgPbJnjVhVzWq2mzzvAbmrzc6zIX2tBTQwip4/TdXoJUAMcdx6tqxvnHKV/woZQGk5vqpwEkl0vxvaSLvpwtpPN28IUumMoegayAjzatOtlgGNHwYVmxa8gHo4aQ3NAANaVbuJwPae33Ou1yUcvNF8msYb0teL5CmUas9uCWeXKUTQvk9hiXaUwr4vA/rG07SlTX6p0U6gWkTaoMNx9DZ2odat2ll2slRbCASFPgT0RGW2N+inrxhirDL3tqE7wYrDI1xW1/wKKJ5qw8TNcfGPsolhkoDKRmgOJNDs/EETcu7vb1btBG1SDoXr5/XCn/gyJzlsSDefWjOen0iFyacIEXcrMxM3pYJyI/zKMPUNhUCoYY80jD3og2BIvvyF7K5vPtNTYkPV9/+pI1CPPhKJnIc2Q5uvA8Pj5+BPcOPwnTrjPeeANcdqpiUk7V0rI+bdKDAuT2w1KF/ibvl5dXyBVmBI7aKNoNI0iXGciRBz5eK+mjx7+AuN2F7LkfFWQqEoETDxy4ZiT8g33uy89Mnpjuky1fPtjY9ylUb4WsdZFAdl9HWHNvdkbdw6t/D3cIzVlZTkDVjox4MCMpIypLUXK3O/gl0fNZcbXUhglKxr95l/gUPU9cCvFBcXUsTbaMZb/P6u0lXp+arN7k9oRUUL9ZO+Gu+YRPSonU3jTBPcE3ECS+2D+zOnjfkruFwrYwg0f4cD8sPjVF8CyWiVLmcIY+QELvE0a5AxzgpqdV2mtE25gW7GI1y1x1js5+r+XcrNkK1ByH5R2a51MkhnY1AHSzQUIDkCI3U0XzXsiWEikUvZ629h3EcqZ7nAYEGsFkmQ3a2l5wLMdBsEw0bpzxantKfxUJQQ1vL0KnkMxxRE0s4e042Thla1Da+J3wcBId2VZ9WJ/b2C6MD2BdbRQ8BnnWkCb3VeQrpAPYS6BpILF09zLKraM3E1wBNs8BaED983DFBZDApxNeUlYLEEzmIRh4mOaEHBJ2g/PIJ2ua+eFGMfftrx+V1jQ0uK+uxe8Td6R1+pFvTO8+u638Tr3HPZoeXnFnWuWBl9iaDQMDuN1Ke8P+2Anbgl1t/tmSrvJk5vF+yD3RgU5qW5iNZ86po12yDeWexyGvO4ybAQ== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8804fed2-8980-49b8-c942-08d9b5b9983e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2021 17:31:37.7126 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2gjS8/KGqae6jTBS/Szjw3SUZIvkGqDTiqg3vOdY9WMHGY+dfzWF5f+uVw6YNNlUoIgtQ0lmqC65l/tHQegMjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3272 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10185 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112020113 X-Proofpoint-ORIG-GUID: pLEP4pWnATVQBBx0DLeO7YlHkwa0GgZM X-Proofpoint-GUID: pLEP4pWnATVQBBx0DLeO7YlHkwa0GgZM X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) V2h5IHNob3VsZCBhbnkgcmVwZXRpdGlvbiBvZiBzZXBhcmF0b3JzIGJlIHJlbW92ZWQNCm9yIGln bm9yZWQ/DQoNCklmIHNvbWVvbmUgY29kZXMgdGhhdCB0aGVuIHRoZXkgcHJlc3VtYWJseSB3YW50 IHRoYXQuDQpWYW5pbGxhIEVtYWNzIG5lZWQgbm90IGNvZGUgc3VjaCByZXBldGl0aW9uLg0KDQoN ClJ1bnRpbWUgImZpeGVzIiBvZiBzdWNoIHJlcGV0aXRpb24gc2hvdWxkIGJlIGEgbm8tbm8uDQpJ ZiB5b3UgZG9uJ3Qgd2FudCBjb25zZWN1dGl2ZSBzZXBhcmF0b3JzIHRoZW4gZG9uJ3QNCnVzZSB0 aGVtLiAgRW5kIG9mIHN0b3J5Lg0KDQpJZiBFbWFjcyBhdXRvbWF0aWNhbGx5IGlnbm9yZXMgb3Ig cmVtb3ZlcyBzZXBhcmF0b3JzDQp0aGVuIHRoYXQgYmVoYXZpb3IgaXMgdG9vIGNsZXZlciBieSBo YWxmLCBJTUhPLg0KDQooQXBvbG9naWVzLCBpZiBJJ3ZlIG1pc3VuZGVyc3Rvb2Qgd2hhdCB0aGlz IGZlYXR1cmUsDQoiYGNvbnRleHQtbWVudS1tYXAnIHRyaWVzIHRvIGVsaW1pbmF0ZSBkb3VibGVk DQpzZXBhcmF0b3JzIiwgaXMgcmVhbGx5IGFib3V0LiAgQnV0IGlmIEkndmUgdW5kZXJzdG9vZA0K Y29ycmVjdGx5IHRoZW4gSSBzdWdnZXN0IHRoaXMgY29udHJvbCBpcyBtaXNndWlkZWQuKQ0K From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Lars Ingebrigtsen Cc: Jim Porter , 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163846789111975 (code B ref 52237); Thu, 02 Dec 2021 17:59:02 +0000 Received: (at 52237) by debbugs.gnu.org; 2 Dec 2021 17:58:11 +0000 Received: from localhost ([127.0.0.1]:49181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msqLS-000374-Ou for submit@debbugs.gnu.org; Thu, 02 Dec 2021 12:58:10 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:34089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msqLO-00036R-3C for 52237@debbugs.gnu.org; Thu, 02 Dec 2021 12:58:10 -0500 Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id E3A39E0012; Thu, 2 Dec 2021 17:56:55 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <87wnknmn2a.fsf@gnus.org> Date: Thu, 02 Dec 2021 19:44:25 +0200 In-Reply-To: <87wnknmn2a.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 02 Dec 2021 09:24:29 +0100") Message-ID: <861r2u3num.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> I've only tested this on Emacs 29 so far, but it may occur on Emacs 28 >> as well. > > Thanks; applied to Emacs 29. Why not to Emacs 28? >> Also, I noticed that separators can appear at the beginning >> and/or end of the context menu. Should they be removed too? > > Hm... I think that might make sense, but I'm not sure. Anybody got an > opinion? Removing leading/trailing separators would be nice too. From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Drew Adams , "52237@debbugs.gnu.org" <52237@debbugs.gnu.org> Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163846857913070 (code B ref 52237); Thu, 02 Dec 2021 18:10:02 +0000 Received: (at 52237) by debbugs.gnu.org; 2 Dec 2021 18:09:39 +0000 Received: from localhost ([127.0.0.1]:49190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msqWZ-0003Ok-0n for submit@debbugs.gnu.org; Thu, 02 Dec 2021 13:09:39 -0500 Received: from mail-pl1-f181.google.com ([209.85.214.181]:46724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msqWW-0003OV-32 for 52237@debbugs.gnu.org; Thu, 02 Dec 2021 13:09:37 -0500 Received: by mail-pl1-f181.google.com with SMTP id p18so264974plf.13 for <52237@debbugs.gnu.org>; Thu, 02 Dec 2021 10:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:from:message-id:date:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=gP84A7dR5pYZ7030cX4d9hXLR55nDkzATyIKURqZODU=; b=Jee9wsIZPhVu03QsJ1wmUzQcXP9fXBQzk7WF2pfIfLtgdjQ2l3d4lpbLEyoA8lWAyz v94AfmKD/lmj2shiE6lWjzIyr0IZfZRqHBW5GOgHw//ZBnx2OmWvCC0KcHVxLjPU1FZi PmZm6qIb7iwOVrW91xflpoZONmpi95iI1aSvnZck9pXlQqUMllg2bU5ZyTD5F4BeFLkb UMFk1dc6h1XQUCTeWExMr9/6mqYzlV1EhcsVBKsVjZgmoQyMVZsnbSNxjrznF6+teW0B iSWti8j1gHIA4WtRw7XrXYrgcEUbs73i472vkGJD2MRVXhNnjBJnUmu6oaEAUEvnQhPO qrrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gP84A7dR5pYZ7030cX4d9hXLR55nDkzATyIKURqZODU=; b=V+wa1MXpPMTn2BFTWwT/MC1ku0fJ9LHMRMZv1yMThZV7Rl/gVUEGHsHaqwPPBm3IYs FI9LzO17sjkq02pRgC8EEqmPa7y2xroEbDzp/amIiVG9dn48oUFoSZ82q4+AGqmwdPIC Y0BEVAyzvJP8/Uk9ftIBHitmoDAzQEluLkIJho51sOp399z+IFOa/AsjkABpGWDigAwg Js8ish84nQVmQFY2d2WSSkp9bpp+4Bv4w8AFdLrGmz0lAvHAQqw1UHiCdWXJn4nYHuFG heWG0HsGWxvjqRBh4btFKusZ1LNcHbZrRM8Sg0OT95x3yOnfJz0aWGfIvP1fL28d/zts QwzQ== X-Gm-Message-State: AOAM5333MxxhfWYZmqenILL/Kl4bkdavDV0Nb7mE9n/UHfYAR8lCv/C6 gxOS//VxylAPHhlKxDFFg8ZqWpU6mNc= X-Google-Smtp-Source: ABdhPJyfA4ogsP1W2N8lMTmXhh0OIQKp81aOQF+NEwRfrkMIamnp107nXGi/H3j/iQghQDpdbxItUA== X-Received: by 2002:a17:90a:9907:: with SMTP id b7mr7817386pjp.137.1638468570365; Thu, 02 Dec 2021 10:09:30 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i5sm288344pgo.36.2021.12.02.10.09.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 10:09:29 -0800 (PST) References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> From: Jim Porter Message-ID: <6e042c91-802b-a7c6-8dc6-2ef5d5a6d1ab@gmail.com> Date: Thu, 2 Dec 2021 10:09:29 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/2/2021 9:31 AM, Drew Adams wrote: > Why should any repetition of separators be removed > or ignored? > > If someone codes that then they presumably want that. > Vanilla Emacs need not code such repetition. As far as I understand (which isn't very far; I've only just started tinkering with context-menu-mode), the general idea is that the context menu is generated dynamically by a list of functions stored in `context-menu-functions'. Each of these can add items to the menu. Some of these, like `context-menu-minor', first add a separator and then iterate over a list of things (minor modes in this case) to add more items. If that list is empty, you just get a separator, but then that separator might get doubled up with the separator from the *next* context menu function. In some cases, these separators are used as anchors to determine where to put the results of *later* context menu functions too. For example, `context-menu-middle-separator' is one of the default entries in `context-menu-functions', and as the name implies, it *only* adds a separator. Some other context menu functions (e.g. `elisp-context-menu') look for that separator to know where to put new menu items, so we want that separator to be there during construction, even if it might result in duplicated separators by the end (which `context-menu-map' would then strip out before display). This logic could apply to separators generated by other functions too, such as `context-menu-minor' described above. From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: [External] : Re: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Jim Porter , "52237@debbugs.gnu.org" <52237@debbugs.gnu.org> Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163846954514594 (code B ref 52237); Thu, 02 Dec 2021 18:26:02 +0000 Received: (at 52237) by debbugs.gnu.org; 2 Dec 2021 18:25:45 +0000 Received: from localhost ([127.0.0.1]:49217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msqm9-0003nK-Fr for submit@debbugs.gnu.org; Thu, 02 Dec 2021 13:25:45 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:12018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msqm4-0003n7-PT for 52237@debbugs.gnu.org; Thu, 02 Dec 2021 13:25:44 -0500 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B2I5t0a020410; Thu, 2 Dec 2021 18:25:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=A47gCEZPNaGQve05IWyqIho1NX8pwyRr5MHy+fnFoHE=; b=ojPzNn0RB5jVQ+NitKOyLvmXhg1FmVilOvlB/r5fkhXknMJqpS+WO6c02ApWQYa7L20g 2TDb/jL3qeb2A8U7vzSmsjvQ2wI5N8KvmCeaq50m14E6g3sN3kyeDKt+tK/G///woPZi Dn3EPFfkz5N629yzWx0g7yIPZzFzD3CGtnqP6k8zovoPYK6ifq+jGDyRFvEeWaXzcVKc AHmX2R3Pfg0sMPT97CMEVX4ypai9trFSBfg9mCOr9F0Nk4O7asuS+X0RItqqvkeRVpop KzqzgR1XZ2RGwERkHxYdpnusNlrrMUzxhG29iQL0D3pc8hhHNoGLZD/2I9gxqthwQ88Q kA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3cp9r59t1h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Dec 2021 18:25:39 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1B2IGrJH012625; Thu, 2 Dec 2021 18:25:38 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by userp3030.oracle.com with ESMTP id 3ck9t4muw8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Dec 2021 18:25:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CTuizal0ZQsEx7irP5znQynMUfS79cGecK5aMiBI1PmNLGye0vJIiL+DPOUmqdVafUkk3zZzV2JN5lnHNIqLUdqijvzyjUN4oUY0+ZYKw+tHfhy2anUAINpW7UUX6pp3ayf3N1llBQsQhAgro+7ZLOcDLHCcDb5S0x53IzDNHtu/vEW/XI/y0DJit+iJ/GzP4rSVFqLn29mmhOTgFVdOGV29UgaaKG/XZ5H7AFl/WGPKKzz3hey1OUp2tOqJJg5s4UxAa0MRJE2Q00S8h925p5J+JCyQSf23MOWbilK6dD+ko587x9H20l9ceOPLvhKAEuiOsF+eoBfxcHE3fJa1lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A47gCEZPNaGQve05IWyqIho1NX8pwyRr5MHy+fnFoHE=; b=BWYMMsZ28VNh/0qb1aWkNgPoJdJCNsaNel+XfVxm9o+kPEJe012u7fF0JUtD6JMyzWaKVvA30JVFxEQ6vFRw/F5fn+3Mq1SOfEzyIEveedgN6se/zb7MF8ltvIU7G2AXp4aI5RoeitsO3/zKSab6g1Lu5iAcXrSUb7ZuasdzfC6i5bE7X2q2PLufGWSCl92276F9rvITqeKO9bMe/dOKSlQh2YuRZb1o6qZr5Qpe+oFWwJwhvQSRZL2P4RdmpfMO8nf3NB7Bb+wHYjAGQk1b12CUcJVtnPBt2l3t/5ZvFGItdshu+HgwkQOgDv2ypM40X2BOehWcyhfz7hsgp5s9hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A47gCEZPNaGQve05IWyqIho1NX8pwyRr5MHy+fnFoHE=; b=EM9sKPw4Z9ia+Kd/xRhbhGK+QYFGfIljF0T/vbIKJ/fdN7udaVfzjcUAIql8pIMgWos1ZjalUfYpXM4OKfbLw0kTGlgcF9IKcsGTJdYIpKoCxJRVlg6SHbyo1PN6vK0FJlamEhl0phzIZY/tygR92lq1XYNuPuA5oWXjQ5qpfQI= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB2920.namprd10.prod.outlook.com (2603:10b6:a03:8f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec 2021 18:25:35 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::4588:646c:e330:8bc0]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::4588:646c:e330:8bc0%9]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021 18:25:35 +0000 From: Drew Adams Thread-Topic: [External] : Re: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Thread-Index: AQHX56fDwOGGJTHQA0i6zmj0TkAtb6wfhGSQ Date: Thu, 2 Dec 2021 18:25:35 +0000 Message-ID: References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <6e042c91-802b-a7c6-8dc6-2ef5d5a6d1ab@gmail.com> In-Reply-To: <6e042c91-802b-a7c6-8dc6-2ef5d5a6d1ab@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3f772292-7da0-43ad-d195-08d9b5c12220 x-ms-traffictypediagnostic: BYAPR10MB2920: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a9cWooMbCxB6nc1DPCkFSPRza8sK+964EH4JydM9NX60NODeVwng46083vJYEepXF3OnK2+vko9nf4719Vubci7LjrjJY1LU6hlYNxYtrxC1CMiLBRmZsiMhbgkOspyciKspdrvk3fJoVxq36VJEX8Njyik102m/lCVYaDv5CbVRyyrb6A1sxLA2F0pHH4I5ep1y9U0sRadBOC7wVLXqCGAcQKosc86UNOkRYvpZnq/exkO918Zm9Aoy4GtDuz6TlV5f/60E4GjaCQ6eXhJbcyWBQTqrmRLL78vvGnZNYSXQ4MnJxAu99UZUtnqZ9VTdVAaE2xRqhhHjL0CYs7MonOya2Pw4M7Tcz+7s8gjEytKl4hA0wULZfDp+LrmiKpt/BQVyg9cwvgUA4qi8DtQ226nh9Nc22eTRxgR7Bd0EjRV9PUtp5dV7804G4SqwYFMUpY9JYsmhPhosX5CIHMNLMjnxHttT3h8NJLJApUc/CbimBITCJxe1cumrOKeoc/f6d22PVAd1ShGXdtNlQXhhhiPm9UBHSM/v5a0V3CWKZJ47kTW3vzn+p7mHXlmxck0+2j3gCvA37lGnPhEp3pu6MVxqQNzeg1tdn0wwgpMmfJ0HzUWT1Ki2wj4wYPuwofBfRtJNCZZqeU6/2IcJkU1oKHGKlSqpvCGeM+gFLjINwyh/Gek7iuEywUp8RLZV8c1X2d6AaDEXuAewB2RTSucOtw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(6506007)(9686003)(52536014)(122000001)(44832011)(110136005)(508600001)(33656002)(55016003)(76116006)(86362001)(38100700002)(66446008)(64756008)(66556008)(66476007)(66946007)(5660300002)(26005)(38070700005)(8936002)(2906002)(8676002)(558084003)(186003)(71200400001)(83380400001)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: 2JqV4fbhuY/0yUEzNxInbB6dwR28hJZyuYV4NZ3triXXjz5Eu0JSCw7h5t3FXCuXuuD2fXRE5xjBjofp5i6T7HRBhIjJrPNUIXl+D3XV6puKJk1QzzcSX4wmMVfQsjqNNgvW5Gh1Pr9t/3JSs61Hs8bQ3rNRyr0euXljViCTv6+olKf+ySGJCQu7rrEJYXE58jxVQjiDYK0bBxhC4ERm2rS9PxoDwzg/DgTt/MSEJNvOLSwa14d2pNHRDjBO3vUlmKsiEtXhU6lBq3hIhnKetsqWn3RNl4+GziWbwN8y/Lh0mlW2JXHPCoH6FOd/eoxeSdXX77BhKiE1YxU29cd0o/eVuIXoVXZK07RKAIXPwlR/jnTS4kzO4KUKPvN8WKTExLhu2av9c6Bo/kD72hhO+ozdcaz7UHo9p3kzm8/7Sko4hkwS+OqCtckF8SxZdwTBWIzO2+9ZRJPM7xHSnudENr8YUcADQPdSaITrGtAi3V9zA7n1D5R48tj4BcibU7EJJHz3+D4PQ1m7mcyPit5EM7RMhGZbO82FWBbksceOERgbmKYm/nAIAgdcYy8ZeIPbtoZEpiEuoPhhCCjiDDG+o8T52lMK5+PS3+vxVXXD/p/hnmk7PEvhcD9oBYwDxVTslf5i4tm/LUQ0r+H3cuBg3itmdmFgm6xL3GVApXrklZWXPOpqlEmN6UoC1lCvO3SVntx+zR90aadL9i/XYSv0JZjUtGaHhOWDR5FMVTUl8C0kVIAnTmj5v+PIaHJGSH/1cpy3T8qq5oih9DI4lkUxBLUrIhf622247GmfhWO92pEWMt3r5iRoBWWnjqgsc4Pr/fhAdU4joKWFGl8NOpT9a7txEbd6CEHdTPHkk+tzFKYEkH7AzDGVaGxiEokyOcMFWJJS49zI7HHXdHIIazfV115nm65MS9o50zm3oKOxmXEEBw2pa8otXxcNo437pLzj8C1zX9Sr4cfq7Z+2uzSGqBzU8Yl0lkfpx2M709k6cesnKionn9G7opTeBK/cYafctXI9EQ6oBrSacWJlqrwL8EsA0f2QJtNZsIQD6MbNAl+fBxZ6mLu7Owxlv3bQV4sLj5u13t4R3NAfCqqOIhz8XW6ZEELdVXJf+/4qFsLtXuoM/dt6ahfLmerKT2fwLUkXTu1sA6JkETlYaYldogJa5fz6y56NKGQa7KYsoIytpI476VXNqmvYLueXr4dUed4hNUt5meOAqW6R4Smd4f6NY9fyp+XxCCimi7XiTXgYrVLVcdCkeYoOk9dGzba9kwjSOG0i/R0ylna2zliltbE3lICIxXs0hIY+Gh7FciEsFxVP8j9CeZJrU4oU4jKvCygjWiALovhdCMZ5evSSF3H0OjKUtN+A66muV2AcH+E9VnbNq6+NUJpBHQ8hOtHBFHyGY4WADdMfsIDDWtp7Jjatc8OmWlAexuVNr6SG1XWHJeJVy/KcCiCdJeFq6BEdrJhLnuGuAXKIGtWQjeJnzcBmkzUNkGAtswfN9/jQG0mL5MBgnLaZi6UzN6KyXpHGfR5fMtgbQRAL4jyndOq5rD8rhYZR7dgWqV/16wzWgJKxpZEjA2289gZR93HpHQNiajbXPlUKYa4zwNTKv1psKRKvIQ== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f772292-7da0-43ad-d195-08d9b5c12220 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2021 18:25:35.4900 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HJbKLUNhfdocyvIsNupRSkHno9AG858+a2Zy4kPuDAvM0ZZTqr2RKk2WMYDQ5MaiCtEBgSPVsyIZCqPUdSKqcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2920 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10185 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=913 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112020117 X-Proofpoint-ORIG-GUID: eV5O_q9YuAjhqqjmfrJ1BNdCCbYXWqvq X-Proofpoint-GUID: eV5O_q9YuAjhqqjmfrJ1BNdCCbYXWqvq X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) SSBzZWUuICBJbiB0aGF0IGNhc2UsIG1heWJlIHRoZXJlIHNob3VsZCBiZQ0KYW4gZW5oYW5jZW1l bnQgcmVxdWVzdCwgdG8gYmUgYWJsZSB0byBwcm9kdWNlDQpjb25zZWN1dGl2ZSBzZXBhcmF0b3Jz IGluIGEgY29udGV4dCBtZW51Lg0KDQooTm8sIEknbSBub3QgcmVxdWVzdGluZyB0aGF0LCBteXNl bGYuKQ0K From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 18:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163847083616639 (code B ref 52237); Thu, 02 Dec 2021 18:48:01 +0000 Received: (at 52237) by debbugs.gnu.org; 2 Dec 2021 18:47:16 +0000 Received: from localhost ([127.0.0.1]:49249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msr6y-0004KJ-LN for submit@debbugs.gnu.org; Thu, 02 Dec 2021 13:47:16 -0500 Received: from mail-pg1-f169.google.com ([209.85.215.169]:36388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msr6v-0004K4-U0 for 52237@debbugs.gnu.org; Thu, 02 Dec 2021 13:47:14 -0500 Received: by mail-pg1-f169.google.com with SMTP id 137so650521pgg.3 for <52237@debbugs.gnu.org>; Thu, 02 Dec 2021 10:47:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=YgxWvmXIomXjsuvKq/+JVRvMKQEX9m9O3W9N/vHqKeo=; b=XvVoGT9blFPacs5iDmezEnFD41AiBO7VEYLdrSyolmkAi7hRKSc/3P/h9N7Mimu2/p O3vRconGOFdc0d2viYV+CxhWz9+sJP+VU0d329HGf4g8ucOO0gkYXkLvupuZuxCd+mxk oMPnNuDHcil1WxbndC1o2fD+WNA/u7LFCftY1/k4AH+yRBMhwlb6irVax1V0VnL/uwyr jtmdlR+NWzSvRrF3yLnQWznSK8UJ4TSqkgi7oxZJv6ZT9ihZueYcadt+CV/Cz0HcMpJ+ wzkZ6qreTcyqd4Rg6ua3zBEr0YIgT65UdTnO+ZDkpyQLp+NwdGfJpbCOA/tmZNc78dSz 3ovw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YgxWvmXIomXjsuvKq/+JVRvMKQEX9m9O3W9N/vHqKeo=; b=BQXxofKN7+H85sFHm8WiKAXWcN/+6GzObuVEJr8J1iEEBqDpY4K604FafpAcfMFa+A ZvfDdY+ZTy2LYn5ZIYjKPeYaRhQw2tdBG9R888qtS0aNP14V51OOqG2GdplK4f9ZmstR KL1QU0Rz2tfedAC7wZFpycjRTHcPVs7+MIa+A0/u7GFY6Cxf44zE6w59C5lMdZ7EL9Gb XVOki1+nYa8SSSZzMPMaTQ8An0v+uN7nu5Nthvxiya+kYXrFizP9HIO6ISTsH2blGJX9 XkKdr7DJ4SAfad4VzvZa0kScEojtsT/+yiWUe+gAemNGakClnQdBQGb+HyYuZ2KrP/pz 23RA== X-Gm-Message-State: AOAM531/rbwblBqeOKkpCgMwsiFeKEZhCAkRm7hkn0DougDvIB9AKyeX 92wLrZBsekv4Z6h7kGucsSz7jH31dNI= X-Google-Smtp-Source: ABdhPJxPhaTqA0siApT0TDLnC4wZZ1IidxFSVp6POiPhiAkWd7nuvyn9RBaSOYKP7rMN3x+0aIP1Sw== X-Received: by 2002:a63:481d:: with SMTP id v29mr732641pga.209.1638470827963; Thu, 02 Dec 2021 10:47:07 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id o9sm347400pgu.12.2021.12.02.10.47.06 for <52237@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 10:47:07 -0800 (PST) From: Jim Porter References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> Message-ID: <07494cfd-0608-acb9-2839-e7ecbef4610c@gmail.com> Date: Thu, 2 Dec 2021 10:47:06 -0800 MIME-Version: 1.0 In-Reply-To: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/1/2021 10:06 PM, Jim Porter wrote: > Sometimes, menu separators are doubled up in context-menu-mode. I found another odd case, but I'm not 100% sure the best way to fix it: emacs -Q --eval '(context-menu-mode)' C-h o identity RET ;; Right-click somewhere in the Help buffer There's a doubled separator after "Next Topic". Looking at the code, this is because `help-mode-context-menu' inserts new items using `define-key', which has the effect of putting the new items *before* the (hidden) menu title. The resulting keymap ends up looking like this: (keymap (Previous\ Topic ...) (Next\ Topic ...) (help-mode-separator "--") #("Context Menu" 0 12 (hide t)) (separator-undo "--") ...) Since there's a hidden item (the keymap title) between the `help-mode-separator' and `separator-undo'[1], the de-duplication doesn't handle that. Is there a standard/common way of defining a key such that it goes immediately *after* the keymap's title? I guess we could add `context-menu-top-separator' as an anchor (by analogy to `context-menu-middle-separator'), but maybe there's a simpler way... [1] As an aside, is there a standard naming convention to use here? Should "separator" go at the beginning of the name or the end? From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH 2] Doubled separators in context-menu-mode Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Dec 2021 04:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Juri Linkov , Lars Ingebrigtsen Cc: 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163850679927927 (code B ref 52237); Fri, 03 Dec 2021 04:47:01 +0000 Received: (at 52237) by debbugs.gnu.org; 3 Dec 2021 04:46:39 +0000 Received: from localhost ([127.0.0.1]:49859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt0T1-0007GM-ET for submit@debbugs.gnu.org; Thu, 02 Dec 2021 23:46:39 -0500 Received: from mail-pg1-f179.google.com ([209.85.215.179]:38479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt0Sx-0007G7-1o for 52237@debbugs.gnu.org; Thu, 02 Dec 2021 23:46:37 -0500 Received: by mail-pg1-f179.google.com with SMTP id s137so1883445pgs.5 for <52237@debbugs.gnu.org>; Thu, 02 Dec 2021 20:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=lNXC8293sW2j1lgLGhJ1QxatVI8LxO88HzvAF2fdW0Q=; b=Qmz7BCpMZv1PhgVjS5kk4VLTEKsuABLoe42UHx7uIX41sC8G89V5Lsog4hCeWO7Yuv cSRxvLx+AQrHCz18DqSPT9Ea2S2oPELjkc0aULheN4Uvu7D/jAhr/BaSrLgfxYWWw3br zo96zvfNbBlzwAYe/6ROrr2mhCV0bs6Hw6k1HPJtXGxq9trQH26I0EoyyzjUF3dQ+YwC r0UIo7jFrj2+D6VZIvFHcwDlQER8rv0EWmaZca4un00Gk28vH1UbHbDUWghXm7aeN9f/ Zvov4uF2U+BNe5lhuClgMdnS372Vo4sTQl4GokqdfGeb9lZdF64vNo2NQgNsKfDjQ1sb iM4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=lNXC8293sW2j1lgLGhJ1QxatVI8LxO88HzvAF2fdW0Q=; b=dHCys9rYrPh4oZYJ9/05pFdxgU38cxff0anQQfiKeU98sIdWQ/Stor9p4tBSeRGJTN 44cF8v7WuRCDeC6D1bIuA2jKA5PIb6QOcHmuxwxN1YRCTN0UsVSUTRoo66h/onDoLG/m hT5JOJSmp9xUBrK1nPhCXk6qOX32UAzC6MkvCTLJsoG/oxcL3T45PWuiXBZ9OlscAWgt QYKCHtjSUO76CI9V8XbUo3DbkfIrz3ipQbhkuUDqJLEU70XnghavJ4dzJVIqExzqIMiN pKOzhFml07VNrpMGT3e2opGsdXZH9cjCEZhmA1W6KpXWOGCGIP/1/l/Bu9mA9fEYwIap jaqg== X-Gm-Message-State: AOAM532hOcT009oaae4a+Mz75rTei9+niDQW31FhPxAVseYCMGX8RZIG eLp4HOBD43tYote3yr/P/ScttWuoS+g= X-Google-Smtp-Source: ABdhPJwozdt9FgbOrzdtex057f8TEroNYp0eiMrCov5ZE/rs6tk76jXBu+aeIGIjOhUuHlAf7L4Orw== X-Received: by 2002:a62:1c58:0:b0:49f:d674:e506 with SMTP id c85-20020a621c58000000b0049fd674e506mr16638992pfc.66.1638506788988; Thu, 02 Dec 2021 20:46:28 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id ne7sm3857202pjb.36.2021.12.02.20.46.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 20:46:28 -0800 (PST) References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <87wnknmn2a.fsf@gnus.org> <861r2u3num.fsf@mail.linkov.net> From: Jim Porter Message-ID: Date: Thu, 2 Dec 2021 20:46:28 -0800 MIME-Version: 1.0 In-Reply-To: <861r2u3num.fsf@mail.linkov.net> Content-Type: multipart/mixed; boundary="------------7F44DCF009BB7DEB9D8FEF31" Content-Language: en-US X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------7F44DCF009BB7DEB9D8FEF31 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/2/2021 9:44 AM, Juri Linkov wrote: >>> I've only tested this on Emacs 29 so far, but it may occur on Emacs 28 >>> as well. >> >> Thanks; applied to Emacs 29. > > Why not to Emacs 28? I got a chance to check this under Emacs 28, and the bug exists there too, so it'd be nice to backport. >>> Also, I noticed that separators can appear at the beginning >>> and/or end of the context menu. Should they be removed too? >> >> Hm... I think that might make sense, but I'm not sure. Anybody got an >> opinion? > > Removing leading/trailing separators would be nice too. Ok, here's a patch to do it. There might be a better way to do this, but it should work reliably. Note: this patch doesn't fix the duplicated separators in the help-mode context menu. I haven't had time to look into the right way to fix that yet (there may be other mode-specific context menu functions that have this bug too). --------------7F44DCF009BB7DEB9D8FEF31 Content-Type: text/plain; charset=UTF-8; name="0001-Remove-separators-at-the-beginning-and-end-of-the-co.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Remove-separators-at-the-beginning-and-end-of-the-co.pa"; filename*1="tch" RnJvbSBjNzZkNzUzYjQ2MTk5ZGEwNDg2M2YxOWY3NWZhZjEwMGQ4ZTllNzczIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMiBEZWMgMjAyMSAyMDozOTozMyAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIFJlbW92ZSBzZXBhcmF0b3JzIGF0IHRoZSBiZWdpbm5pbmcgYW5kIGVuZCBvZiB0aGUg Y29udGV4dAogbWVudQoKKiBsaXNwL21vdXNlLmVsIChjb250ZXh0LW1lbnUtbWFwKTogUmVt b3ZlIGJlZ2lubmluZy9lbmQgc2VwZXJhdG9ycy4KLS0tCiBsaXNwL21vdXNlLmVsIHwgMTkg KysrKysrKysrKysrKystLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyks IDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9tb3VzZS5lbCBiL2xpc3AvbW91 c2UuZWwKaW5kZXggZWM0M2FlY2RkMC4uYjVjYTgwYTQ0NiAxMDA2NDQKLS0tIGEvbGlzcC9t b3VzZS5lbAorKysgYi9saXNwL21vdXNlLmVsCkBAIC0zMjcsMTIgKzMyNywyMSBAQCBjb250 ZXh0LW1lbnUtbWFwCiAgICAgICAgICAgICAgICAgICAgICAgICAgIChzZXRxIG1lbnUgKGZ1 bmNhbGwgZnVuIG1lbnUgY2xpY2spKQogICAgICAgICAgICAgICAgICAgICAgICAgICBuaWwp KSkKIAotICAgIDs7IFJlbW92ZSBkdXBsaWNhdGUgc2VwYXJhdG9ycwotICAgIChsZXQgKChs IG1lbnUpKQotICAgICAgKHdoaWxlIChjb25zcCBsKQotICAgICAgICAoaWYgKGFuZCAoZXF1 YWwgKGNkci1zYWZlIChjYXIgbCkpIG1lbnUtYmFyLXNlcGFyYXRvcikKLSAgICAgICAgICAg ICAgICAgKGVxdWFsIChjZHItc2FmZSAoY2FkciBsKSkgbWVudS1iYXItc2VwYXJhdG9yKSkK KyAgICA7OyBSZW1vdmUgZHVwbGljYXRlIHNlcGFyYXRvcnMgYXMgd2VsbCBhcyBvbmVzIGF0 IHRoZSBiZWdpbm5pbmcgb3IKKyAgICA7OyBlbmQgb2YgdGhlIG1lbnUuCisgICAgKGxldCAo KGwgbWVudSkgc2F3LWZpcnN0LWl0ZW0pCisgICAgICAod2hpbGUgKGNvbnNwIChjZHIgbCkp CisgICAgICAgIDs7IElmIHRoZSBuZXh0IGl0ZW0gaXMgYSBzZXBhcmF0b3IsIHJlbW92ZSBp dCBpZiAxKSB3ZSBoYXZlbid0CisgICAgICAgIDs7IHNlZW4gYW55IG90aGVyIGl0ZW1zIHll dCwgb3IgMikgaXQncyBmb2xsb3dlZCBieSBlaXRoZXIKKyAgICAgICAgOzsgYW5vdGhlciBz ZXBhcmF0b3Igb3IgdGhlIGVuZCBvZiB0aGUgbGlzdC4KKyAgICAgICAgKGlmIChhbmQgKGVx dWFsIChjZHItc2FmZSAoY2FkciBsKSkgbWVudS1iYXItc2VwYXJhdG9yKQorICAgICAgICAg ICAgICAgICAob3IgKG5vdCBzYXctZmlyc3QtaXRlbSkKKyAgICAgICAgICAgICAgICAgICAg IChudWxsIChjYWRkciBsKSkKKyAgICAgICAgICAgICAgICAgICAgIChlcXVhbCAoY2RyLXNh ZmUgKGNhZGRyIGwpKSBtZW51LWJhci1zZXBhcmF0b3IpKSkKICAgICAgICAgICAgIChzZXRj ZHIgbCAoY2RkciBsKSkKKyAgICAgICAgICA7OyBUaGUgImZpcnN0IGl0ZW0iIGlzIGFueSBj b25zIGNlbGw7IHRoaXMgZXhjbHVkZXMgdGhlCisgICAgICAgICAgOzsgYGtleW1hcCcgc3lt Ym9sIGFuZCB0aGUgbWVudSBuYW1lLgorICAgICAgICAgICh3aGVuIChjb25zcCAoY2FkciBs KSkgKHNldHEgc2F3LWZpcnN0LWl0ZW0gdCkpCiAgICAgICAgICAgKHNldHEgbCAoY2RyIGwp KSkpKQogCiAgICAgKHdoZW4gKGZ1bmN0aW9ucCBjb250ZXh0LW1lbnUtZmlsdGVyLWZ1bmN0 aW9uKQotLSAKMi4yNS4xCgo= --------------7F44DCF009BB7DEB9D8FEF31-- From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Dec 2021 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Juri Linkov Cc: Jim Porter , 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.16385477395924 (code B ref 52237); Fri, 03 Dec 2021 16:09:02 +0000 Received: (at 52237) by debbugs.gnu.org; 3 Dec 2021 16:08:59 +0000 Received: from localhost ([127.0.0.1]:52026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtB7L-0001XU-2f for submit@debbugs.gnu.org; Fri, 03 Dec 2021 11:08:59 -0500 Received: from quimby.gnus.org ([95.216.78.240]:53832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtB7H-0001XB-W0 for 52237@debbugs.gnu.org; Fri, 03 Dec 2021 11:08:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bf/KfybPRxNCCCPZOUmj5RmPubBNqZuaqv8xv3PBXPk=; b=InANzqFyafETnu6mkYgmgR0N/I tbDCBsEedL2l8Pc+bY+p47CfcpPkJr7hcPkw/971pdt9uZMEGKfj+OfbypkUYXatvCBiYKQv8fDPE MSjGmHHlzeb4FWijzxZ8Q3ParLLwRAMFU3OaVB4PKkN/BJr2T9hWWgwmTsg4JPWgJrlk=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtB78-0004KD-U4; Fri, 03 Dec 2021 17:08:49 +0100 From: Lars Ingebrigtsen References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <87wnknmn2a.fsf@gnus.org> <861r2u3num.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEUaKE4fLVgmN2Uz R3VCU31Paptph7Q7UoV0l8etyuv////kMCoUAAAAAWJLR0QKaND0VgAAAAd0SU1FB+UMAxABIGNL 0IcAAAGsSURBVDjLdZRBT8IwFMdfy4Fr20XxuHYhXhlj8gGUu0AKnDVOODIkeFYh4ywx9NvaMja7 Ot7hpe0v7//+bdcBXApESD2ghNJ6QAXnwpQyP/DPKnkWXBgwSOSI5uIngJAQggM0s63sj00/xPMC PJ8lW4C7WSTnU8sIQg+96B5glTaT3ch2mI91/ZWchhTbvkzSC6gfdKioMY5XrVD4xhVUBVn3lrZ8 UgXGORMRBP/2b2CQAnfBqdrLtwyOUpFrwKUgl9bIhWIBDdJa1rQZ9hePrGNKWEUUt5T6MEIr19SN Uj8E4uDZBddKqe0mk5/uwTfnykT25bhlKN6fwMFSMiAgjYVeP2bfqAoiQO+6/T45YFLonM48Ba11 lFMa4tDujQ3IdkoQ4KQCBGex8UVQeVnIN5lt1nKmm3ccU4DXiZzs1fHJBWiSvHR7vYEFzs8jlqnX rRz4GWDuyfjVOnFUPijvDdrT0Cjn4qU9T49YGhXf4h/Afd1Dr58B80vR9n4Ig9KndcN4MtZWUA4Q t4zo6bKocADuFMB5/tgvAINqhMVd1/8vdPjVaeCAsq58tb/g3U0o0KJpyQAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMS0xMi0wM1QxNjowMTozMiswMDowMOiXyCgAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjEtMTItMDNUMTY6MDE6MzIrMDA6MDCZynCUAAAAAElFTkSuQmCC X-Now-Playing: Joni Mitchell's _Blue_: "California" Date: Fri, 03 Dec 2021 17:08:46 +0100 In-Reply-To: <861r2u3num.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 02 Dec 2021 19:44:25 +0200") Message-ID: <87fsr9y8kx.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: >>> I've only tested this on Emacs 29 so far, but it may occur on Emacs 28 >>> as well. >> >> Thanks; applied to Emacs 29. > > Why not to Emacs 28? We're only fixing regressions on the release branch now, so I don't think this qualifies? (And even if it did, since it's a visual thing, I'm not sure it's important enough anyway.) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Juri Linkov writes: >>> I've only tested this on Emacs 29 so far, but it may occur on Emacs 28 >>> as well. >> >> Thanks; applied to Emacs 29. > > Why not to Emacs 28? We're only fixing regressions on the release branch now, so I don't think this qualifies? (And even if it did, since it's a visual thing, I'm not sure it's important enough anyway.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH 2] Doubled separators in context-menu-mode Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Dec 2021 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Jim Porter Cc: 52237@debbugs.gnu.org, Juri Linkov Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.16385478406153 (code B ref 52237); Fri, 03 Dec 2021 16:11:02 +0000 Received: (at 52237) by debbugs.gnu.org; 3 Dec 2021 16:10:40 +0000 Received: from localhost ([127.0.0.1]:52030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtB8y-0001bB-DO for submit@debbugs.gnu.org; Fri, 03 Dec 2021 11:10:40 -0500 Received: from quimby.gnus.org ([95.216.78.240]:53854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtB8w-0001aq-RX for 52237@debbugs.gnu.org; Fri, 03 Dec 2021 11:10:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RJGFM6vRdQ3JbZ8mNpk0WzKJnfIGqVkrVo3cW6nVhi8=; b=OvJ/zqQwTECmr+ARkABW2xD326 fPu1UIX+8OZQ+dlZnRCXDd1GfQ2LMsqhnoBtMoLGaTMosEL28fXPoNIIJVjqaPgpMsF4qURkvrvQb rUU4HNYUVWhTbREtT4Pvxo6JedwYE1cN4rSFUZimRtmLFl5b2XCScp8decK7zWYq3/Wc=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtB8o-0004Li-DA; Fri, 03 Dec 2021 17:10:33 +0100 From: Lars Ingebrigtsen References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <87wnknmn2a.fsf@gnus.org> <861r2u3num.fsf@mail.linkov.net> X-Now-Playing: Joni Mitchell's _Blue_: "This Flight Tonight" Date: Fri, 03 Dec 2021 17:10:29 +0100 In-Reply-To: (Jim Porter's message of "Thu, 2 Dec 2021 20:46:28 -0800") Message-ID: <87bl1xy8i2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: >> Removing leading/trailing separators would be nice too. > > Ok, here's a patch to do it. There might be a better way to do this, > but it should work reliably. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: >> Removing leading/trailing separators would be nice too. > > Ok, here's a patch to do it. There might be a better way to do this, > but it should work reliably. Thanks; applied to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 11:10:52 2021 Received: (at control) by debbugs.gnu.org; 3 Dec 2021 16:10:52 +0000 Received: from localhost ([127.0.0.1]:52033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtB9A-0001bl-KO for submit@debbugs.gnu.org; Fri, 03 Dec 2021 11:10:52 -0500 Received: from quimby.gnus.org ([95.216.78.240]:53870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtB99-0001bS-0W for control@debbugs.gnu.org; Fri, 03 Dec 2021 11:10:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gNpT/g25XuCIIVK7LaI8Ctho8XmeE4ZuJRV0hZUYSGw=; b=nVf0uAkAlpHhG9XYgSoz684qAS PNfVqdV5s/P8rvAykjPHIc0468uyPIfML/qNJxVKrO0/5Uj4yEZFjj+FEGmi3fHF4PinT9OFwH6/T zU6xBgyw+lBqYIHEsWhy52/57jNe3jlCZb5e/+zHS0wXxYo+Y3kn2BL+7OWjBpxdUYN0=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtB91-0004Lv-Ca for control@debbugs.gnu.org; Fri, 03 Dec 2021 17:10:45 +0100 Date: Fri, 03 Dec 2021 17:10:42 +0100 Message-Id: <87a6hhy8hp.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #52237 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 52237 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 52237 29.1 quit From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 06:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Lars Ingebrigtsen , Juri Linkov Cc: 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.16386002918190 (code B ref 52237); Sat, 04 Dec 2021 06:45:02 +0000 Received: (at 52237) by debbugs.gnu.org; 4 Dec 2021 06:44:51 +0000 Received: from localhost ([127.0.0.1]:52830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtOmx-000282-8t for submit@debbugs.gnu.org; Sat, 04 Dec 2021 01:44:51 -0500 Received: from mail-pf1-f177.google.com ([209.85.210.177]:37665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtOmv-00027q-PX for 52237@debbugs.gnu.org; Sat, 04 Dec 2021 01:44:50 -0500 Received: by mail-pf1-f177.google.com with SMTP id 8so5021759pfo.4 for <52237@debbugs.gnu.org>; Fri, 03 Dec 2021 22:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Olex1gvokSwA3gS/y/pYSA+X8mLKveDyp3wqXdNJusQ=; b=C8R1eFIJDoKPWKXRzB585kU99KPFmscPUQHqdRN7kgUBAnvfk3njVSWguwtH6KuV74 YL2Jsz9YQH7nzc/vFU4mivxKrr5FO3QNpYP2+rOkTseVy6gRYnAnuRrAAVK+GMtiDm+1 7IJf9THG/coKjW9PHh8fj+sPb68irvpuWvLnNTKFMF8G5I2zJj6RZmMpntDCkqIMKLgN CCapAOL5AG9yDlt1b143XoI2aY+777kqB86iOdzEkjKxKftS/QHtJeI1/K31jWNtNyF3 nvx3AmbtnpDnf1RvM8PvzBEnOPlEBXMDCgOzqbV/UEfDLvQFYc6WlvILe3ChXVNqTdzg /UsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Olex1gvokSwA3gS/y/pYSA+X8mLKveDyp3wqXdNJusQ=; b=jBaqPmnS62cOlgaNt+NlMoeLVV/Sw/SqcFbCAsJimDG6O7/diFuEjpX6Ru+foedgax jg8Phjl7c8xQX7fbSSR+3cVxqG5/lvsONDuxDrR8wVJ9HKE3C6Pg4SWphb1eOd3Z0HQO wtFPz19Ye0XqGJPzZCV4hMJZv8k+E6EQVV1Sb1/V4kG6aXvNRaoY0qqNMX+e5mF3gnVk xQvrXop+C0Xe2UzP4h1Y++IyYKRlL4QpA6FLdSVRue7B8b0YjLRxVA1OyBivBoyIT/3f qN27k1gOZrNB46xmn59QF1SNZGzF59FOHFKAwrrRMTXMMhSBlnpxFT0+KVU3oUno4tYk M0Ug== X-Gm-Message-State: AOAM532JOrs+uIClO4LIfGGrjNwhxgR4whEJYoeWd5AtzzoP7rKJVw1h VgLQi0eIfKnlFbJbtleMBDqYb9k9uRE= X-Google-Smtp-Source: ABdhPJy/GJ0ws1R0/iNNc2aYKiZqD/nGSov899daiVvsyJP/cWMrz3kUSA7qu3f1T/I2B8guExUKXQ== X-Received: by 2002:a63:5816:: with SMTP id m22mr8441723pgb.98.1638600283861; Fri, 03 Dec 2021 22:44:43 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g9sm5469977pfc.182.2021.12.03.22.44.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Dec 2021 22:44:43 -0800 (PST) References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <87wnknmn2a.fsf@gnus.org> <861r2u3num.fsf@mail.linkov.net> <87fsr9y8kx.fsf@gnus.org> From: Jim Porter Message-ID: Date: Fri, 3 Dec 2021 22:44:43 -0800 MIME-Version: 1.0 In-Reply-To: <87fsr9y8kx.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/3/2021 8:08 AM, Lars Ingebrigtsen wrote: > We're only fixing regressions on the release branch now, so I don't > think this qualifies? (And even if it did, since it's a visual thing, > I'm not sure it's important enough anyway.) Just so I know, for stuff like this, is there a chance it could be backported at some point for 28.2 (assuming that version gets published in the future), or would it have to wait until 29.1? If the former, I'll try to remember to remind folks post-28.1 about this bug so it can be backported. From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Jim Porter Cc: larsi@gnus.org, 52237@debbugs.gnu.org, juri@linkov.net Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163860639017619 (code B ref 52237); Sat, 04 Dec 2021 08:27:02 +0000 Received: (at 52237) by debbugs.gnu.org; 4 Dec 2021 08:26:30 +0000 Received: from localhost ([127.0.0.1]:52875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtQNK-0004a7-1i for submit@debbugs.gnu.org; Sat, 04 Dec 2021 03:26:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtQNI-0004Zu-CF for 52237@debbugs.gnu.org; Sat, 04 Dec 2021 03:26:28 -0500 Received: from [2001:470:142:3::e] (port=53188 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtQNC-0006yN-K6; Sat, 04 Dec 2021 03:26:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LhxQ9JScSRBQjadzOIXiYQ98oROW/GROaH48wVoYK8I=; b=oePN31ZMjMzh EP6NCfX8lKN4Op29xrVc4y2GfCNU6rKjFjjLOf/9AYzUg6uubeOXlmIHPygymX8V08eLPDqGc0HXF OjPohJb1RPoYgAdOBysIVnX0IteTxuAE+SJQzdnyMsdQmRVLmqbmNf+YxARpbCKnSWVRbObzCdQNZ 0y05yr2tIqKwI/i0pzBDjmmjkgWUaTHYOlJc8um7DKvyDaFwmup0+HRIutcjZ7rx/HudxZHodjruM Ng0IIwh6NKeUR8hp7mORUXjfO6mBJLZ4a3Mblhgo5iVBBL1ooyFpxIxsifVsJ5xkdF2lptDuEUu9E q4VeWz4V47T0NmzOzLj1SA==; Received: from [87.69.77.57] (port=1938 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtQNC-0007P6-C9; Sat, 04 Dec 2021 03:26:22 -0500 Date: Sat, 04 Dec 2021 10:26:14 +0200 Message-Id: <8335n87p3t.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Fri, 3 Dec 2021 22:44:43 -0800) References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <87wnknmn2a.fsf@gnus.org> <861r2u3num.fsf@mail.linkov.net> <87fsr9y8kx.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Resent-From: Jim Porter > Original-Sender: "Debbugs-submit" > Resent-CC: bug-gnu-emacs@gnu.org > Resent-Sender: help-debbugs@gnu.org > From: Jim Porter > Date: Fri, 3 Dec 2021 22:44:43 -0800 > Cc: 52237@debbugs.gnu.org > > On 12/3/2021 8:08 AM, Lars Ingebrigtsen wrote: > > We're only fixing regressions on the release branch now, so I don't > > think this qualifies? (And even if it did, since it's a visual thing, > > I'm not sure it's important enough anyway.) > > Just so I know, for stuff like this, is there a chance it could be > backported at some point for 28.2 (assuming that version gets published > in the future), or would it have to wait until 29.1? We could consider it for Emacs 28.2, yes, assuming that it wouldn't cause any regressions or adverse side effects. From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 20:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Jim Porter Cc: 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163864859516470 (code B ref 52237); Sat, 04 Dec 2021 20:10:03 +0000 Received: (at 52237) by debbugs.gnu.org; 4 Dec 2021 20:09:55 +0000 Received: from localhost ([127.0.0.1]:55070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtbM3-0004HZ-6u for submit@debbugs.gnu.org; Sat, 04 Dec 2021 15:09:55 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:65027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtbM2-0004HJ-0i for 52237@debbugs.gnu.org; Sat, 04 Dec 2021 15:09:54 -0500 Received: (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 0C4C440002; Sat, 4 Dec 2021 20:09:46 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <07494cfd-0608-acb9-2839-e7ecbef4610c@gmail.com> Date: Sat, 04 Dec 2021 21:50:20 +0200 In-Reply-To: <07494cfd-0608-acb9-2839-e7ecbef4610c@gmail.com> (Jim Porter's message of "Thu, 2 Dec 2021 10:47:06 -0800") Message-ID: <86h7bouq5f.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I found another odd case, but I'm not 100% sure the best way to fix it: > > emacs -Q --eval '(context-menu-mode)' > C-h o identity RET > ;; Right-click somewhere in the Help buffer > > There's a doubled separator after "Next Topic". Looking at the code, this > is because `help-mode-context-menu' inserts new items using `define-key', > which has the effect of putting the new items *before* the (hidden) menu > title. The resulting keymap ends up looking like this: > > (keymap > (Previous\ Topic ...) > (Next\ Topic ...) > (help-mode-separator "--") > #("Context Menu" 0 12 (hide t)) > (separator-undo "--") > ...) The core function that displays the menu can handle the menu title in the middle of the menu, so it wasn't a problem until the recent need to remove duplicate items. > Since there's a hidden item (the keymap title) between the > `help-mode-separator' and `separator-undo'[1], the de-duplication doesn't > handle that. Is there a standard/common way of defining a key such that it > goes immediately *after* the keymap's title? I guess we could add > `context-menu-top-separator' as an anchor (by analogy to > `context-menu-middle-separator'), but maybe there's a simpler way... I see no simpler way, so perhaps we need to add `context-menu-top-separator'. > [1] As an aside, is there a standard naming convention to use here? Should > "separator" go at the beginning of the name or the end? `context-menu-middle-separator' is a function, so it requires the `context-menu-' prefix. It adds the menu item [middle-separator]. Since "middle" is an adjective, the word order can't be "separator-middle". But "buffers-separator" doesn't look nicer than `separator-buffers'. If you could propose a more consistent naming convention, maybe it's not too late to rename these symbols on the release branch, because after the release it will be impossible to rename them. From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 20:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Juri Linkov Cc: 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163865137914511 (code B ref 52237); Sat, 04 Dec 2021 20:57:01 +0000 Received: (at 52237) by debbugs.gnu.org; 4 Dec 2021 20:56:19 +0000 Received: from localhost ([127.0.0.1]:55254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtc4x-0003lz-K9 for submit@debbugs.gnu.org; Sat, 04 Dec 2021 15:56:19 -0500 Received: from mail-pf1-f180.google.com ([209.85.210.180]:44576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtc4v-0003li-8j for 52237@debbugs.gnu.org; Sat, 04 Dec 2021 15:56:17 -0500 Received: by mail-pf1-f180.google.com with SMTP id b68so6324446pfg.11 for <52237@debbugs.gnu.org>; Sat, 04 Dec 2021 12:56:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Zg/LYzshwMYtYuvm40tczzoI7xTERJ0DcpCzxs6x8jM=; b=Afu9p4coEPzIid1A8RdTQa3uDUtytzPhUowTvHZKuIMUR4uIXee2H+/VhXpBR50tEY whewIV1J9VKdI1RT+FpUmby1NuRWVo5Ryi9l2tkEWAjSgix2L+LrCEkd6xgfvCgWD4ea X6PXxrMYDEVUq3cjvIHamcfqcPxW+BDevSJHGN0S7BOa2SAxChE8yj++zsL9LHb2Blmi F9MeJNP5AqVL2Xu9QkAQw00otO8DLa5O45cz/u+av0yW7QVpRljDPhubWtvmE9EKovoq wsT5Ny6ZhSujEFL9i2zy9aLQYTrz0KuDYuXbv548kNkTFexNiL5R2aBdVM5GS1SNzpEv J+fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Zg/LYzshwMYtYuvm40tczzoI7xTERJ0DcpCzxs6x8jM=; b=OwIOlIBxzH+0kljq54ALjnlFts9s69oq6dIHhAOiExBHAF9cqIloGXOfGIvk6Ikskw UbPL4R+wvQ5zbYn3F6AVrIx+KEmlOPVxk5qN5/aPShRc+sSwt7WHIlZ/O8T7+mnElB3t 4K49HUqvNNsRd8PpTsrR21d6G0OkVC7QHoLnSYVu0oDBlLuA27TzD+YnNOSFy13Y3hL2 VRFom62GrbDR+5oz0Qi4VtsdL3QjC+z5shUscG/D1dEHKguoXLSfFEAHApafItChgAUt UyTeisWYhSQ4x+Rebb/VoPPI8pdjt54weS+55xjtdh1B+qIDc2v4zRZDpf/oHbXRYFuz Bj/Q== X-Gm-Message-State: AOAM531GxHPxnHgzDfmRDpetxLnzofNBx3Kn3aealvzYnhfRqFbHk6JO m6FTPQ8ABhc+QtGkiAwFM6+UfyLTUXI= X-Google-Smtp-Source: ABdhPJy2L+jBYwwkJugTI8XeDlB8j+hUdPTuBRIG8OyppNl8rf6eSnTW86dlzAoM+/9OmwqwBRYWpQ== X-Received: by 2002:a63:8948:: with SMTP id v69mr10938352pgd.250.1638651371245; Sat, 04 Dec 2021 12:56:11 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g14sm5621920pgo.88.2021.12.04.12.56.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Dec 2021 12:56:10 -0800 (PST) References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <07494cfd-0608-acb9-2839-e7ecbef4610c@gmail.com> <86h7bouq5f.fsf@mail.linkov.net> From: Jim Porter Message-ID: <53e0f3fd-d630-a384-c488-27fec72e6386@gmail.com> Date: Sat, 4 Dec 2021 12:56:09 -0800 MIME-Version: 1.0 In-Reply-To: <86h7bouq5f.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/4/2021 11:50 AM, Juri Linkov wrote: >> I found another odd case, but I'm not 100% sure the best way to fix it: >> >> emacs -Q --eval '(context-menu-mode)' >> C-h o identity RET >> ;; Right-click somewhere in the Help buffer >> >> There's a doubled separator after "Next Topic". [snip] > I see no simpler way, so perhaps we need to add `context-menu-top-separator'. Sounds good. I'll work on a patch for this and file a new bug for it once it's ready. >> [1] As an aside, is there a standard naming convention to use here? Should >> "separator" go at the beginning of the name or the end? > > `context-menu-middle-separator' is a function, so it requires the > `context-menu-' prefix. It adds the menu item [middle-separator]. > Since "middle" is an adjective, the word order can't be "separator-middle". > But "buffers-separator" doesn't look nicer than `separator-buffers'. I think `FOO-separator' is the best choice here for the separators themselves. `FOO' acts as a noun adjunct[1], modifying the underlying object: a separator. For functions that just make a separator, they'd be named `MODULE-[FOO-]-separator', with `FOO-' being optional if it would be redundant with the module name. So then `context-menu-middle-separator' is the right function name, and it adds a separator named `middle-separator'. `buffers-separator' is a bit of an odd phrasing since, as the Wikipedia article mentions, "Noun adjuncts were traditionally mostly singular". However, I think it's still a bit easier to read that correctly as "the separator used to mark the buffers", whereas `separator-buffers' reads more like "buffers used to separate things" to me. Since this should just be a trivial renaming, hopefully we can merge that into Emacs 28 so we're not locked into the current names. [1] https://en.wikipedia.org/wiki/Noun_adjunct From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 22:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Juri Linkov Cc: 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163865579824120 (code B ref 52237); Sat, 04 Dec 2021 22:10:01 +0000 Received: (at 52237) by debbugs.gnu.org; 4 Dec 2021 22:09:58 +0000 Received: from localhost ([127.0.0.1]:55587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtdEE-0006Gx-7r for submit@debbugs.gnu.org; Sat, 04 Dec 2021 17:09:58 -0500 Received: from mail-pf1-f173.google.com ([209.85.210.173]:37749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtdED-0006Gl-3h for 52237@debbugs.gnu.org; Sat, 04 Dec 2021 17:09:57 -0500 Received: by mail-pf1-f173.google.com with SMTP id 8so6439422pfo.4 for <52237@debbugs.gnu.org>; Sat, 04 Dec 2021 14:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=XMhWcXo/9JDUFLlaLhJ7c6tvglqMkQaiskt3yY6YMls=; b=Zls6+AQGZudxHfvm4k0FKcygPdh/L3Dt4U4ojGGgC+hX15d7W5TkI5Pzp7UUFGRXr+ 0ssqzBq/7U4blCjDLw/SuFsdI3kyt2Gzqc28jxNyhNUiRcIo4O7aec80Tp3XQoDYwjOm VVacvUtCT1rU5ibqmeA+0u8rty9STyCbFzCs4FnLXxIDc8gV7a+9JLfY1xdvMhVmR763 h7qWbD6wXSyvOkbJygbp1/LThZ99dCGlDqwxFH3K9D9G3KyqYs+pf9LI+NO2a0LPh4+E kytNvfZNuM5s0VJozSnrpn6Kv37dr4UKN3UxYvqtT0r0uOT09WZSXIXX+YDg93iGPQnE LkwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XMhWcXo/9JDUFLlaLhJ7c6tvglqMkQaiskt3yY6YMls=; b=VLhVhwpg8Tfhcn5SXCwO4Fr3fB2nNG6JUcMka2vsaxIvZ/nhnuQs/DIBVko0jIL0H+ 6CWIK8gXEUqHtbRh8ogHy1qsWpS/km6nl/m6+eCG1kKz/PAm6TNKEuHep79coSW0MBjx 6LR2gt13Pl1pk54R6GqkD7BjM1B61CKU+OAtNWBl7p3/eVnyt6505ta0YVxeSwB5YTmI qHGabR2X0LLbTAyjgSJIoOLYFrepO5N7TWmfiOTASv6CXMmq+TA067MWyYC+FXWogR4d nxU6rcRtGixEmb408vh9jA9DAcKkoNWoy2Thb/+QD1fPsWozElsED/MraCmLibQzq62u CL8g== X-Gm-Message-State: AOAM5333HFRvGhhEYYRGYagt8/I3OBoOQsxGFKohhU25C9rSaYGGgdGr QNJ4JPJT0Bbfz+p0pXpZ6stcJ6+XMyQ= X-Google-Smtp-Source: ABdhPJx6pHsWN9j2iu6dgFyUk5J58vrqQQQ3lrA41ZBq/A4s9I6Kbz0dDx8eMtjPmUq4j0noa6fELQ== X-Received: by 2002:a05:6a00:1946:b0:44d:8136:a4a4 with SMTP id s6-20020a056a00194600b0044d8136a4a4mr27520866pfk.46.1638655791310; Sat, 04 Dec 2021 14:09:51 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id k3sm8010748pff.211.2021.12.04.14.09.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Dec 2021 14:09:51 -0800 (PST) From: Jim Porter References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <07494cfd-0608-acb9-2839-e7ecbef4610c@gmail.com> <86h7bouq5f.fsf@mail.linkov.net> <53e0f3fd-d630-a384-c488-27fec72e6386@gmail.com> Message-ID: <3b763b93-0077-c14d-3940-d0c033f5cfb8@gmail.com> Date: Sat, 4 Dec 2021 14:09:50 -0800 MIME-Version: 1.0 In-Reply-To: <53e0f3fd-d630-a384-c488-27fec72e6386@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/4/2021 12:56 PM, Jim Porter wrote: > On 12/4/2021 11:50 AM, Juri Linkov wrote: >> `context-menu-middle-separator' is a function, so it requires the >> `context-menu-' prefix.  It adds the menu item [middle-separator]. >> Since "middle" is an adjective, the word order can't be >> "separator-middle". >> But "buffers-separator" doesn't look nicer than `separator-buffers'. > > I think `FOO-separator' is the best choice here for the separators > themselves. `FOO' acts as a noun adjunct[1], modifying the underlying > object: a separator. For functions that just make a separator, they'd be > named `MODULE-[FOO-]-separator', with `FOO-' being optional if it would > be redundant with the module name. So then > `context-menu-middle-separator' is the right function name, and it adds > a separator named `middle-separator'. > > `buffers-separator' is a bit of an odd phrasing since, as the Wikipedia > article mentions, "Noun adjuncts were traditionally mostly singular". > However, I think it's still a bit easier to read that correctly as "the > separator used to mark the buffers", whereas `separator-buffers' reads > more like "buffers used to separate things" to me. > > Since this should just be a trivial renaming, hopefully we can merge > that into Emacs 28 so we're not locked into the current names. > > [1] https://en.wikipedia.org/wiki/Noun_adjunct Ok, filed bug#52286 for this: https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-12/msg00327.html From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH 2] Doubled separators in context-menu-mode Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 10:05:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Jim Porter Cc: Lars Ingebrigtsen , 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163869868519006 (code B ref 52237); Sun, 05 Dec 2021 10:05:03 +0000 Received: (at 52237) by debbugs.gnu.org; 5 Dec 2021 10:04:45 +0000 Received: from localhost ([127.0.0.1]:56414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtoNw-0004wP-Lj for submit@debbugs.gnu.org; Sun, 05 Dec 2021 05:04:45 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:37279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtoNr-0004vC-Qr for 52237@debbugs.gnu.org; Sun, 05 Dec 2021 05:04:40 -0500 Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id CF6E31C0006; Sun, 5 Dec 2021 10:04:32 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <87wnknmn2a.fsf@gnus.org> <861r2u3num.fsf@mail.linkov.net> Date: Sun, 05 Dec 2021 11:32:42 +0200 In-Reply-To: (Jim Porter's message of "Thu, 2 Dec 2021 20:46:28 -0800") Message-ID: <868rwzcrql.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Ok, here's a patch to do it. There might be a better way to do this, but it > should work reliably. > > - (while (consp l) > + (while (consp (cdr l)) This change broke flyspell-correct-word. When a context menu is invoked on a misspelled word in flyspell-mode, context-menu-map uses the property context-menu-function to get a command symbol 'flyspell-correct-word' instead of a list of menu items. bug#50851 fixed this error by checking for a list with `(consp l)' like above: (consp 'flyspell-correct-word) => nil but now 'cdr' fails on (consp (cdr 'flyspell-correct-word)). From unknown Sat Sep 20 13:00:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#52237: 29.0.50; [PATCH 2] Doubled separators in context-menu-mode Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 20:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch To: Juri Linkov Cc: Jim Porter , 52237@debbugs.gnu.org Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.1638735668486 (code B ref 52237); Sun, 05 Dec 2021 20:22:02 +0000 Received: (at 52237) by debbugs.gnu.org; 5 Dec 2021 20:21:08 +0000 Received: from localhost ([127.0.0.1]:59632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mty0R-00007m-He for submit@debbugs.gnu.org; Sun, 05 Dec 2021 15:21:08 -0500 Received: from quimby.gnus.org ([95.216.78.240]:55700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mty0A-00006g-WC for 52237@debbugs.gnu.org; Sun, 05 Dec 2021 15:21:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ERa0raCVbQY9kqC3gAVHbLz01dOUQhr15KGcrKgbgrE=; b=VW6xLMie1QEmK5B0OPCcts2VEg IZmaOIogHRBmtMCRjPFUz0Lma+nCY7bjRx/8bDdJ6pCp6/YQ/sG+E/Ksisg7JMLZ6mcsF5EgAbmsT /e/zLKOQi0V4pYK41dB8noV/6XTpxWuvtjlZpooJWuQBHR8uE/+DOipfB5mtT12rr4CQ=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mty00-0002dT-Jl; Sun, 05 Dec 2021 21:20:43 +0100 From: Lars Ingebrigtsen References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <87wnknmn2a.fsf@gnus.org> <861r2u3num.fsf@mail.linkov.net> <868rwzcrql.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUmIiSMfHPIwr// ///XfD68AAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UMBRMvJqYCnRsAAAGPSURBVCjPRdFBa6NAFAfw l1KH6MmCKepJignqp3BDG8KeTFGpPZlFhySfws0hbHMyIUrrKQYDOp9ynTG2c5of/5nHezwAmKtW rRZRAvTMeasWSJTeMPkUiBG2VxuGCq5/IONVC+2GPzXamD0u9cxSpG/4E0Vm1Rjw72GPBuE9/53c rfcvHYwW9X72g8/dlkE2LtHg33HbJxF8XLZ2h6MOX8sDg2QetQHR06RDrklYP9+w0yVs9MjNNX4L HQrRzK0m/tAZNL3YuKsvo0f8Vy7YqKCFTQVyrnRYBCkMXwUG0ePPwD/NJJYEoxOgyW7eYVECsrbP FOPGPwBSpvcUavayhJHnMSjXaZk8ZSZHwV1f63B5eJ9S3JF0gJ6VIqdAxAX/hEhD0S7KsU6P5I2h iVMhfSQVQ3A9ocQnZwreKzMhCQhbKsrLbPbL6yD4ZbEYeBv2R30PC4dbWyxRg2UWcat2DtpbIHoV RDHD2JViByrMno1BenAWFWYFrnD/YCN3lFFkYEsguCKbxwUYiYpjc/Afhu+BQQa9QocAAAAldEVY dGRhdGU6Y3JlYXRlADIwMjEtMTItMDVUMTk6NDc6MzgrMDA6MDCFwShyAAAAJXRFWHRkYXRlOm1v ZGlmeQAyMDIxLTEyLTA1VDE5OjQ3OjM4KzAwOjAw9JyQzgAAAABJRU5ErkJggg== X-Now-Playing: Peter Gabriel's _Peter Gabriel 2_: "Home Sweet Home" Date: Sun, 05 Dec 2021 21:20:40 +0100 In-Reply-To: <868rwzcrql.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 05 Dec 2021 11:32:42 +0200") Message-ID: <87bl1upzvr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: >> - (while (consp l) >> + (while (consp (cdr l)) > > This change broke flyspell-correct-word. When a context menu is invoked > on a misspelled word in flyspell-mode, context-menu-map uses the propert [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Juri Linkov writes: >> - (while (consp l) >> + (while (consp (cdr l)) > > This change broke flyspell-correct-word. When a context menu is invoked > on a misspelled word in flyspell-mode, context-menu-map uses the property > context-menu-function to get a command symbol 'flyspell-correct-word' > instead of a list of menu items. > > bug#50851 fixed this error by checking for a list with `(consp l)' like above: > > (consp 'flyspell-correct-word) => nil > > but now 'cdr' fails on (consp (cdr 'flyspell-correct-word)). OK; I've added another (and (consp there now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no