GNU bug report logs - #52200
29.0.50; image-dired-cmd-create-standard-thumbnail-options

Previous Next

Full log

Message #8 received at 52200 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Peter Münster <pm <at> a16n.net>
Cc: 52200 <at> debbugs.gnu.org
Subject: Re: bug#52200: 29.0.50;
 image-dired-cmd-create-standard-thumbnail-options
Date: Wed, 8 Dec 2021 18:01:50 -0800

Peter Münster <pm <at> a16n.net> writes:

> I'm a bit confused about
> image-dired-cmd-create-standard-thumbnail-options:
>
> - It seems, that it's not used with pngcrush or pngnq, so this test is
>   perhaps useless:
>   (unless (or image-dired-cmd-pngcrush-program
>               image-dired-cmd-pngnq-program) ...

I think the intention is that we shouldn't insert those text fields
twice.  See the removed code in commit 36b9973dec65 and also
`image-dired-cmd-pngcrush-options'.

Perhaps we could make this unconditional, but then what should we do
about `image-dired-cmd-pngcrush-options'?  Should the options be removed
from there?

> - If gm is used, then the "convert" command should be added.

Yes, I think you are right.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.