GNU bug report logs - #52194
28.0.50; [PATCH] Put paid to a flappy test module

Previous Next

Full log

View this message in rfc822 format

From: Robert Pluim <rpluim <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 52194 <at> debbugs.gnu.org, dick.r.chiang <at> gmail.com
Subject: bug#52194: 28.0.50; [PATCH] Put paid to a flappy test module
Date: Tue, 30 Nov 2021 14:41:32 +0100

>>>>> On Tue, 30 Nov 2021 14:16:56 +0100, Lars Ingebrigtsen <larsi <at> gnus.org> said:

    Lars> Robert Pluim <rpluim <at> gmail.com> writes:
    >>>>>>> On Mon, 29 Nov 2021 20:38:05 -0500, dick.r.chiang <at> gmail.com said:
    >> 
    dick> From 18e2cfa112c3393b4191bb3497bf9a0ae643c2a2 Mon Sep 17 00:00:00 2001
    dick> From: dickmao <dick.r.chiang <at> gmail.com>
    dick> Date: Mon, 29 Nov 2021 20:31:28 -0500
    dick> Subject: [PATCH] Don't repeat yourself (DRY)
    >> 
    >> I donʼt think that quite works:

    Lars> [...]

    >> SKIPPED  echo-server-with-dns

    Lars> It works here...

I meant the 'connection failed but test passed' messages, which makes
me question if the test is broken or whether itʼs just too verbose.

    Lars> But as for the patch itself -- "don't repeat yourself" is good advice in
    Lars> normal code, but for tests, we want to be as explicit as possible, so
    Lars> that when tests fail, we can see exactly what fails.  So I don't think
    Lars> rewriting the tests is a good idea, and I'm closing this bug report.

That works for me :-)

Robert
-- 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.