GNU bug report logs - #52181
[core-update-frozen] many rust package can't build because them source file-name use ".crate" suffix.

Previous Next

Package: guix;

Reported by: Z572 <873216071 <at> qq.com>

Date: Mon, 29 Nov 2021 15:08:01 UTC

Severity: normal

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Z572 <873216071 <at> qq.com>, 52181 <at> debbugs.gnu.org
Subject: bug#52181: [core-update-frozen] many rust package can't build because them source file-name use ".crate" suffix.
Date: Mon, 29 Nov 2021 19:16:29 +0000
Z572 via Bug reports for GNU Guix schreef op ma 29-11-2021 om 22:31
[+0800]:
> I think have 2 option:
> 
>  1. change suffix from ".crate" to ".tar.gz".
>  2. maybe let "tarball?" check file like command-line program "file",
> no
>  just check filename suffix.

A third option: let tarball? recognise ".crate" suffixes.
A hacky fourth option (to avoid a full world-rebuild):
in cargo-build, do:

;; Untested, might not work due to inlining.

;; XXX: modify tarball? on the next world-rebuild
(define tarball?/fixed
  (let ((tarball?/old tarball?))
    (lambda (filename)
      (or (tarball? filename)
          (string-suffix? ".crate" filename)))))

(define* (cargo-build ...)
  (set! tarball? tarball?/fixed)
  (apply gnu:gnu-build ...))

The second option would be a bit complicated to do efficiently, because
the tar would be wrapped inside a gzip/xzip/..., unless it is
acceptable for tarball? to assume that every gzipped/... file is a
gzipped/... tarball.

Greetings,
Maxime.





This bug report was last modified 3 years and 173 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.