Subject: Re: [PATCH v2 2/6] gnu: add conmon

From: Timmy Douglas <[email-masked]>
Date: Tue, 21 Dec 2021 14:42:16 -0800

Ludovic Courtès <[email-masked]> writes:

> Timmy Douglas <[email-masked]> skribis:
>
>> * gnu/packages/containers.scm: add conmon
>
> [...]
>
>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri (git-reference
>> +             (url "https://github.com/containers/conmon")
>> +             (commit (string-append "v" version))))
>> +       (sha256
>> +        (base32 "1sxpbm01g4xak4kqwvk45gmzr6n9bjzlfp1j85wyz8rj2hg2x4rm"))
>> +       (file-name (git-file-name name version))))
>> +
>> +    (build-system gnu-build-system)
>
> Nitpick: you can remove the empty line.

ok. I think guix lint outputted that way or maybe I already had it like that?

>> +    (arguments
>> +     `(#:make-flags (list ,(string-append "CC=" (cc-for-target))
>> +                          (string-append "PREFIX=" %output))
>> +                    #:tests? #f ; currently broken as go tries to use network
>
> Indentation is off.

emacs really likes to indent it like that. I wonder if I'm missing
something in my setup.

I'll take a look at just skipping network tests rather than avoiding
them altogether.