GNU bug report logs - #52172
Fix vc-git--program-version to support Git for macOS version string

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 52172 <at> debbugs.gnu.org, Justin Schell <justinmschell <at> gmail.com>
Subject: bug#52172: Fix vc-git--program-version to support Git for macOS version string
Date: Mon, 06 Dec 2021 02:29:52 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> Looks good to me (especially with included tests). The
> trailing-dot-stripping approach, that is.

OK; I've now pushed it to Emacs 29.

> I would even suggest to try to get it into emacs-28 (given that
> apparently that functionality has been broken in macOS for a long
> time).
>
> But then again, if it's only been reported now, maybe it's not hugely
> important and Emacs 28 can live without it.

This sort of change can be somewhat ticklish, as it depends on output
from external programs, and it's hard to get full test coverage of that.
So I'd rather just put it on master.

Justin, this change was small enough to apply without assigning
copyright to the FSF, but for future patches you want to submit, it
might make sense to get the paperwork started now, so that subsequent
patches can be applied speedily. Would you be willing to sign such
paperwork?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.