GNU bug report logs - #52148
29.0.50; [PATCH] Make `project-kill-buffers' display list of buffers to kill

Previous Next

Package: emacs;

Reported by: Matthias Meulien <orontee <at> gmail.com>

Date: Sat, 27 Nov 2021 21:47:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #17 received at 52148 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Matthias Meulien <orontee <at> gmail.com>
Cc: 52148 <at> debbugs.gnu.org
Subject: Re: bug#52148: 29.0.50; [PATCH] Make `project-kill-buffers' display
 list of buffers to kill
Date: Sun, 28 Nov 2021 10:33:26 +0200

> From: Matthias Meulien <orontee <at> gmail.com>
> Cc: 52148 <at> debbugs.gnu.org
> Date: Sun, 28 Nov 2021 09:11:52 +0100
> 
> Here is an updated patch. Not sure of the value of "package-version" I
> should have used...
> 
> I also added a NEWS entry.

Thanks.  A couple of minor comments below.

> +(defcustom project-kill-buffers-display-buffer-list nil
> +  "Non-nil to display list of buffers to kill before killing project buffers."

The doc string should mention 'project-kill-buffers' (not necessarily
in the first sentence), to make the context and domain of the option
more clear.

> +  :version "29.0"

This should be "29.1".  We never release NN.0 versions, the first
version of a major release is always NN.1.
This bug report was last modified 3 years and 266 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.