From unknown Mon Jun 16 23:45:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52117 <52117@debbugs.gnu.org> To: bug#52117 <52117@debbugs.gnu.org> Subject: Status: [core-updates-frozen] [PATCH 0/6] Fix Julia packages. Reply-To: bug#52117 <52117@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:45:30 +0000 retitle 52117 [core-updates-frozen] [PATCH 0/6] Fix Julia packages. reassign 52117 guix-patches submitter 52117 zimoun severity 52117 normal tag 52117 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 25 18:32:36 2021 Received: (at submit) by debbugs.gnu.org; 25 Nov 2021 23:32:36 +0000 Received: from localhost ([127.0.0.1]:58229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOEG-0000pS-KK for submit@debbugs.gnu.org; Thu, 25 Nov 2021 18:32:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:46548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOEG-0000pL-0f for submit@debbugs.gnu.org; Thu, 25 Nov 2021 18:32:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqOEF-00080z-RD for guix-patches@gnu.org; Thu, 25 Nov 2021 18:32:35 -0500 Received: from [2a00:1450:4864:20::42c] (port=37788 helo=mail-wr1-x42c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqOEE-0005Cc-CC for guix-patches@gnu.org; Thu, 25 Nov 2021 18:32:35 -0500 Received: by mail-wr1-x42c.google.com with SMTP id b12so14767667wrh.4 for ; Thu, 25 Nov 2021 15:32:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=x95ugjkZuzs8sKlxAvk+V51DFb1R/0rUDpTl+NrzbxY=; b=PvJI8GWLjoVcSG0j13V9Sqm3xDghMtFHLBJKiSIDdaJfHPJmfVRayao3r0RkQGRyR5 B0qzHspqkwe+9omPwun9kMO//NhX70qe/DtMnkFiqbGHpjWtrZ8hSp6gdKnQ7FTTeoWD qX1b9Z4RGzPi+ENB80CaG6VAgbkHL7Xriw3/5a73YlM+GpnLAJKfTcDcxwzGDIbDV48Z AdEZprhhXq9dmg3eJ8UOF2O4ClGJq+0prth+x6AQLdviZHIBu/t9k1gBzGmkIw+1Xf8D XB0paow1OIs4vG8aldUUZ9FmxU9vYSsEjjq5ha0BP61nEaYwLVasboonZffX1Yyafz+C pbhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=x95ugjkZuzs8sKlxAvk+V51DFb1R/0rUDpTl+NrzbxY=; b=6jlQFErq7yD5qEHluwrHkcOCD1KxIp1Kv41J1GJD1i8FbU7ZiLRkrKH9iXT7yixN0c drc78N+ccUeGUPnP4J1zVEoLmiCYZ6eShFXeylXxt2TQN6Usc918zIPvh+6EQq7Pzuru m4E5HBaIqMF+t4QNw868IZp+mzhIz98xogj8wY5MTscFYaH/ijg0XBXvEAotxgbwWfXO /fjRnKnUopDW09F7HTlWbfPjJWUPkr6GF9zOrBSYy7QS3/dwRTa9Np25jipFi8Nxm4Lk zdSlPcbilYNd8AogRs2VZww1ePEJIWXaj6iUOqd4EAtxCJtUvZ3lO7iufRUAyMVDhImQ X9/A== X-Gm-Message-State: AOAM5326uzEenPX8us2BcgRXgFMCc7Rr27zwmLoGDRjnjdI1dJNs9ya6 tK49I6PARZkxNkEKnZ5+MWArYiN+YhI= X-Google-Smtp-Source: ABdhPJzvlFwuT27BATMKEyF89FUezBaKp6yhqOC33wuaikxgSCgx87NyxdX9QfSS7tU9mV8i553u9Q== X-Received: by 2002:adf:e387:: with SMTP id e7mr10400363wrm.412.1637883152934; Thu, 25 Nov 2021 15:32:32 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id n32sm4524254wms.42.2021.11.25.15.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 15:32:32 -0800 (PST) From: zimoun To: guix-patches@gnu.org Subject: [core-updates-frozen] [PATCH 0/6] Fix Julia packages. Date: Fri, 26 Nov 2021 00:32:25 +0100 Message-Id: <20211125233225.34466-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Debbugs-CC: maxim.cournoyer@gmail.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42c (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, With this series, all the Julia packages builds again. The only one still missing is 'julia-sundials-jll’. It probably requires to introduce something to julia-build-system but I have not investigated much. Cheers, simon zimoun (6): gnu: julia: Test correctly '#:parallel-tests?'. build: julia-build-system: Correctly disable parallel tests. gnu: julia-aqua: Disable parallel tests. gnu: julia-interpolations: Disable parallel tests. gnu: julia-requires: Disable parallel tests. gnu: julia-unitful: Disable parallel tests. gnu/packages/julia-xyz.scm | 8 ++++++++ gnu/packages/julia.scm | 9 ++++----- guix/build/julia-build-system.scm | 8 +++++--- 3 files changed, 17 insertions(+), 8 deletions(-) base-commit: 138498feec335f68935f00f8a97924c90c7f59b0 -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 25 18:36:22 2021 Received: (at 52117) by debbugs.gnu.org; 25 Nov 2021 23:36:22 +0000 Received: from localhost ([127.0.0.1]:58239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHu-0000vL-2u for submit@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:22 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:34536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHs-0000v4-RA for 52117@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:21 -0500 Received: by mail-wm1-f54.google.com with SMTP id m25-20020a7bcb99000000b0033aa12cdd33so1655703wmi.1 for <52117@debbugs.gnu.org>; Thu, 25 Nov 2021 15:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hcqDPUt6SBIgtBx4Q54hMpUhppPQQ3NV8+ARhSF1IB0=; b=oefkv1QOS+44IqBJAezF+A62xzHsYgJr/3Vbf0TJIlkgVWTG93ycqdqLxocK9ZjYpT 694hxEUkXO0AA2K3sflu/jifIqfnYwV2udy9Nf/dT/NfjpMKz4tHSfp8Kq3wYtJg43P8 rTxNfuiscjF8+QwdobTSB8hUoPG1KTo09nuNLVeqN0nq6fpQ7h+PfDAaPnNsfvXajGep WMdtKuHIWDnbbnUHH4Ph3Z6Yf/xhTSs5CXZN8fUuW2pOBoKnYstwrdOrCBrL85pM2Afb JbZcOG/4oWXpvHVqVxd9tUJXrWoGxDCRXgX0DHZ5chGBRIFPTI1SdJEm2t9WrYvBXSyB Y6ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hcqDPUt6SBIgtBx4Q54hMpUhppPQQ3NV8+ARhSF1IB0=; b=C3cPnAllCUOr/I7aUtfAiOUFiCZhbZ5P7IS37c5O1XH6wGRx3lE8VaKpBZUSQXwfTZ XMfP3/tAMCJHNmoW/k+zpVQMIzZ6W/v04JDeD/0UCi/wvA7V0HK9ca72I3hTGruZgn0F E73gYgBHvyCG72AWCDd+dOuiYT2pYokJiYYItX0HHcRKXvCKIHdIaOncMdLs/YaD5W5I rlIZDb9WqIoRyqtMLG0pEXbaZLp3OdwRnrb6Ocs/kRS+/Sli7xCUTTXcohJYmhYwn094 hfkjuwy/d9qZNRSAqq4IZLCdIihPLWCIEFhRKVCUslvmEkpz68B2s7HPGfkTLraR89k8 V3QQ== X-Gm-Message-State: AOAM532TVeAo3pmEguX2nRFdKYIGn6K6JxkNYh0o2ikmPmRFFM89BBYb 5gCKUhW3J51Uzi7xkdHVdPpPe6PW80g= X-Google-Smtp-Source: ABdhPJyFwOarYRtsjYLwFGaAgtXuiDX8YxecWwhoL4VmWS4//E5xTQ0uV2F2L1GkTmtEs4PNJUT8mw== X-Received: by 2002:a05:600c:190b:: with SMTP id j11mr11557977wmq.112.1637883375208; Thu, 25 Nov 2021 15:36:15 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id m1sm4337171wme.39.2021.11.25.15.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 15:36:14 -0800 (PST) From: zimoun To: 52117@debbugs.gnu.org Subject: [PATCH 2/6] build: julia-build-system: Correctly disable parallel tests. Date: Fri, 26 Nov 2021 00:35:55 +0100 Message-Id: <20211125233559.34575-2-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211125233559.34575-1-zimon.toutoune@gmail.com> References: <20211125233559.34575-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Even providing '--procs=1' launches 2 workers which breaks some testsuite of packages; therefore set '#:parallel-tests?' to '#false' was ineffective. * guix/build/julia-build-system.scm (check): Fix unexpected behaviour from 'julia' command line option. --- guix/build/julia-build-system.scm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/guix/build/julia-build-system.scm b/guix/build/julia-build-system.scm index f0dc419c17..af478fd4a3 100644 --- a/guix/build/julia-build-system.scm +++ b/guix/build/julia-build-system.scm @@ -112,7 +112,10 @@ (define* (check #:key tests? source inputs outputs julia-package-name (builddir (string-append out "/share/julia/")) (jobs (if parallel-tests? (number->string (parallel-job-count)) - "1"))) + "1")) + (nprocs (if parallel-tests? + (string-append "--procs=" jobs) + ""))) ;; With a patch, SOURCE_DATE_EPOCH is honored (setenv "SOURCE_DATE_EPOCH" "1") (setenv "JULIA_DEPOT_PATH" builddir) @@ -122,8 +125,7 @@ (define* (check #:key tests? source inputs outputs julia-package-name ""))) (setenv "JULIA_CPU_THREADS" jobs) (setenv "HOME" "/tmp") - (invoke "julia" "--depwarn=yes" - (string-append "--procs=" jobs) + (invoke "julia" "--depwarn=yes" nprocs (string-append builddir "loadpath/" package "/test/runtests.jl")))) #t) -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 25 18:36:27 2021 Received: (at 52117) by debbugs.gnu.org; 25 Nov 2021 23:36:27 +0000 Received: from localhost ([127.0.0.1]:58244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHz-0000vy-H1 for submit@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:27 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:38695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHt-0000v5-Ay for 52117@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:22 -0500 Received: by mail-wr1-f44.google.com with SMTP id u18so14773748wrg.5 for <52117@debbugs.gnu.org>; Thu, 25 Nov 2021 15:36:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=q/pV4LcNDGO3t/w9NhEe8AQfTcKFG4HF27aqTDnTWho=; b=hTk1ddi4lhbKsL/do3KbkeYFFek0VkuG5ug+LbfFSK0752Bri+rnKJL0CS7au8EdZ6 Rjk1gC445Ma1WB35bnBoxq58vC0sfoxTzeB9eVMGKv02/iPPy6cXoFNzYMbmjWSiNMgN K5hUIqYsrBC1cI4uF3PqnKkt5mmXJuJzWZ5y9ryh+rvVqbCQVJkU5i2TZhy2Sg7Q5SxW s1WW2ajmcYtsZiBdvruJTEze8CjRx9FVi9TEv+ucr4nxgQe9P2ha09dPol8Rmoecdci8 NSUnSgzSA5kBQ2dQIkqb8a5c//9EmdPOp6bRbSre0tuF3u26TsfqbCxKUAsZMf6onLdO UH0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q/pV4LcNDGO3t/w9NhEe8AQfTcKFG4HF27aqTDnTWho=; b=S2ScLwcXR0am2VDR1BXT7uYa5qLVT6dtjLkV+Aea80n9LrTGUr540fyKS9FS1sN4A1 2a17pSLQDUAGUA6gKG5r5Dq6OnYOIT5E8TxaJ1TRUuNDzir3xZa9fWzwBNJCTTnGZ4he WMFHMgl+es/7UYfwb7HvNS89rwi9U9XhJaKQWnKHjt8DkHpiKF2OPTvsDwpyRWkubitl NPMRE5yBMp+4yF+g8G7avbokESgdU7+f0NFhohh4h/h6Gl05rIIUnF+8AwSmp9rlUBYV +TMJlmnyL4rczl12AG/AJtitEZXzmEvl7b/bTfHqTP7k1JaB9YHzr+GfLzXAkpg27QvV 5w6Q== X-Gm-Message-State: AOAM531b14ezCdwzPghZzOEXXdJhMD3PoyjfEYj4Qk7RlJRDPfAPv7YD KaBCH6itShVO/18nq5qR39mp/rKboB4= X-Google-Smtp-Source: ABdhPJzSY0mTHLKI/nn0I+d6qlID/zReYxDyMyGICPWLWS5GUvwWCVUbSGuj3U5Ctuc41MTyc4HP+Q== X-Received: by 2002:adf:d20e:: with SMTP id j14mr10889877wrh.220.1637883375777; Thu, 25 Nov 2021 15:36:15 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id m1sm4337171wme.39.2021.11.25.15.36.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 15:36:15 -0800 (PST) From: zimoun To: 52117@debbugs.gnu.org Subject: [PATCH 3/6] gnu: julia-aqua: Disable parallel tests. Date: Fri, 26 Nov 2021 00:35:56 +0100 Message-Id: <20211125233559.34575-3-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211125233559.34575-1-zimon.toutoune@gmail.com> References: <20211125233559.34575-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/julia-xyz.scm (julia-aqua)[arguments]: Disable parallel tests. --- gnu/packages/julia-xyz.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm index 547d2bf81e..3ca32097e9 100644 --- a/gnu/packages/julia-xyz.scm +++ b/gnu/packages/julia-xyz.scm @@ -136,6 +136,8 @@ (define-public julia-aqua (sha256 (base32 "1g0kyzcdykgs247j72jpc2qqall696jwgb3hnn4cxmbi8bkf7wpk")))) (build-system julia-build-system) + (arguments + `(#:parallel-tests? #f)) (home-page "https://github.com/JuliaTesting/Aqua.jl") (synopsis "Automated quality assurance for Julia packages") (description "@acronym{Aqua.jl, Auto QUality Assurance for Julia packages}, -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 25 18:36:28 2021 Received: (at 52117) by debbugs.gnu.org; 25 Nov 2021 23:36:28 +0000 Received: from localhost ([127.0.0.1]:58246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHz-0000w1-Pv for submit@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:28 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:45025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHs-0000v2-J9 for 52117@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:23 -0500 Received: by mail-wr1-f50.google.com with SMTP id l16so14753499wrp.11 for <52117@debbugs.gnu.org>; Thu, 25 Nov 2021 15:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=im4RsZkoOnhd4sRAL6+mOCoLV/ultHywq9zbJp1wvYA=; b=qi6lUrQt6sL2d+0Uey7hXvySwABRPGPXodhxHBqdgX4j1imcki8V4/U6B2l776+2lT btIa+9zv/7lG6ZpkfcpOOATtae/2snE8xjx4oVW9BjHlVfT/1V677a6hEp3oNwDZPPWK meksIz26VivGVkFVl585+DLfU/pEHQhCNA8120PSg51CS5QYhco/ZV+BA2mRkohj3pCx p7T6DYKUw2VoTAK+6QG3NRsolNIGg3HLEn6DzeVMTsnCJNbGURVtUpuhfH+W2LdFsL/u 8MpEsv1iurf60VMaacXONZlQC2LSy7LF69a8g3JmuH7F/WWTmNt43IXIFAtXhcVa0x89 jsHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=im4RsZkoOnhd4sRAL6+mOCoLV/ultHywq9zbJp1wvYA=; b=PkopzgNDKyXDK+/OsYi/4wL6eoGWcfEw5aLvobVRudEUhzL72hg4XMHA0BEBxwPiAo 6eyi4vS1mFMcLLej69tBh7nbSxsHf6VQjGSaLET3GmZnDadHfm2Ce7KfDflUgjTacNqc UMaEZVgUivYeSQSp3ZgBEaLnA4m+TYxc+wv0zQA9+YLXwaKlgqB8IHHWxo8SsDw3EPMo 4AeYxPi7MF7foLtc48TGjDy5QOdgjiPyh1YCpLbLt+sxtaCZIYxr6Ih/HzGXXES/dqaX H68gR7JDxmTB4ewDnTbrGD0cTM0q9UWUdX8RtNwu6MPfYZFwKVSsy4LJEW8ywW9YzDfy CMuw== X-Gm-Message-State: AOAM530sHyDsFOh8UfMywt4d3aextADCfflZGCAHP+IOEVYcLyp17WkM boevm7KBNh/tQelEnoEyuTRFSY0+PC4= X-Google-Smtp-Source: ABdhPJwN5t7i4OogC4KIhSBFnxg7lxoSPeaEkjO0zUpnCa7yAEd8GZwqOLQhD6hbSEMgnLaL6/s/pA== X-Received: by 2002:a5d:4408:: with SMTP id z8mr10563527wrq.551.1637883374721; Thu, 25 Nov 2021 15:36:14 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id m1sm4337171wme.39.2021.11.25.15.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 15:36:14 -0800 (PST) From: zimoun To: 52117@debbugs.gnu.org Subject: [PATCH 1/6] gnu: julia: Test correctly '#:parallel-tests?'. Date: Fri, 26 Nov 2021 00:35:54 +0100 Message-Id: <20211125233559.34575-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/julia.scm (julia)[arguments]<#:phases>: Fix parallel-test. --- gnu/packages/julia.scm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/gnu/packages/julia.scm b/gnu/packages/julia.scm index ac5bf7db25..c123711da5 100644 --- a/gnu/packages/julia.scm +++ b/gnu/packages/julia.scm @@ -315,11 +315,10 @@ (define-public julia (substitute* (jlpath "Zlib") (((from "libz")) (to "zlib" "libz")))))) (add-after 'unpack 'enable-parallel-tests - ;; FIXME: julia fails at networking in the container and falls back - ;; to a single worker, which causes the tests to not run in - ;; parallel (see: https://github.com/JuliaLang/julia/issues/43205). - (lambda* (#:key parallel-build? #:allow-other-keys) - (setenv "JULIA_CPU_THREADS" (if parallel-build? + ;; Parallel tests require 'julia-allow-parallel-build.patch'. + ;; https://github.com/JuliaLang/julia/issues/43205. + (lambda* (#:key parallel-tests? #:allow-other-keys) + (setenv "JULIA_CPU_THREADS" (if parallel-tests? (number->string (parallel-job-count)) "1")) (format #t "JULIA_CPU_THREADS environment variable set to ~a~%" -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 25 18:36:28 2021 Received: (at 52117) by debbugs.gnu.org; 25 Nov 2021 23:36:28 +0000 Received: from localhost ([127.0.0.1]:58248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOI0-0000w8-2t for submit@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:28 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:34501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHu-0000v7-3C for 52117@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:23 -0500 Received: by mail-wr1-f51.google.com with SMTP id j3so14813278wrp.1 for <52117@debbugs.gnu.org>; Thu, 25 Nov 2021 15:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qnhnIMS860tasV5MjXCtbWTArwTT+aaev6mNJzo8e7w=; b=aTUNuLkQjcsDOg/8wq3Oagh+3yK9bX4MY8BzeY+O7TtSjRmXKCGhiYE76lG37Msl3L jp6aohuZU2+f0vvrrrlatKeqcfVvGQlF4z8LP8bg4Li/gaBbTOFMDY5nXfLB2jZW0zQB lNWnJ9bsFnTfNY+iXaH6xUUUJ9qBMax7X89RCfCclCMiD7AWtoX4MS9dfwyDNbAxGnMn oWcJ0n7gXKGzsHHFhTuewo9fJ3MuJ9VI9fBblL8Z34TYOwkH0mADb3t/aoNpaOt7Nb50 aeYJZP9xcBB0hGqQFCgxfmrniltdpa9A13fGH+tcMqQBFrG0vpwtOLsX4tCZF72NF8sN ZkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qnhnIMS860tasV5MjXCtbWTArwTT+aaev6mNJzo8e7w=; b=etiGNwSDodAyOY9u6ZlRiTqcbWVXNSvYZ+P+SX/oVNOl+xyF+XbjX4FmZVY8ztxi0x MsqWss8EQvTUsTf7wqY2RtRtTMTZg/DabubajVDhXtWEW6AkEU94MnsNuOmD9YmCkiBY JdEJW7m1rKHGmGOwpV54mi5d0kJJzHuUHT+rmMM3M0d1k+R31It8GpgIF5ZjrYA07k8v iTeucH185V+obYt3FItxhsJml8q3RNTlm7O5tKHduSI0iYK9QQY2QIviM5WfECiYCV+D dS4xLGRMIC7yqwX/F00D4l6TShIPiixp6XF142MauG21iupPBT3kp1jGlqqcWtZeZhaU Lwuw== X-Gm-Message-State: AOAM531w8fvmGnfY2HZBu5IDyBeIc+Qp8zA7vbp3ctPXKFAdeqaIFcvG wFSTjMf9I5D1puScHSGMm54rDqJeYMQ= X-Google-Smtp-Source: ABdhPJzsI8PNw/pINzzA01TJ22VNft+9eR3LMGkXw4yX8KyCa6OIr7Rq4FHJV61wSNVbzmgqSFvUMg== X-Received: by 2002:adf:d1c2:: with SMTP id b2mr10849386wrd.114.1637883376268; Thu, 25 Nov 2021 15:36:16 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id m1sm4337171wme.39.2021.11.25.15.36.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 15:36:16 -0800 (PST) From: zimoun To: 52117@debbugs.gnu.org Subject: [PATCH 4/6] gnu: julia-interpolations: Disable parallel tests. Date: Fri, 26 Nov 2021 00:35:57 +0100 Message-Id: <20211125233559.34575-4-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211125233559.34575-1-zimon.toutoune@gmail.com> References: <20211125233559.34575-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/julia-xyz.scm (julia-interpolations)[arguments]: Disable parallel tests. --- gnu/packages/julia-xyz.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm index 3ca32097e9..f68cd1647b 100644 --- a/gnu/packages/julia-xyz.scm +++ b/gnu/packages/julia-xyz.scm @@ -2518,6 +2518,8 @@ (define-public julia-interpolations (sha256 (base32 "1236c20k388qlh7k74mhf7hkbn0vf7ss8b1rgh1a6aj0234ayfnc")))) (build-system julia-build-system) + (arguments + `(#:parallel-tests? #f)) (propagated-inputs `(("julia-axisalgorithms" ,julia-axisalgorithms) ("julia-offsetarrays" ,julia-offsetarrays) -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 25 18:36:28 2021 Received: (at 52117) by debbugs.gnu.org; 25 Nov 2021 23:36:28 +0000 Received: from localhost ([127.0.0.1]:58250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOI0-0000wF-Aa for submit@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:28 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:35656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHu-0000v8-Fd for 52117@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:23 -0500 Received: by mail-wm1-f45.google.com with SMTP id 77-20020a1c0450000000b0033123de3425so9497571wme.0 for <52117@debbugs.gnu.org>; Thu, 25 Nov 2021 15:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sIlz+4ag6rTwqlRzYdJDRzxS5gdfRa5dROYXeNE0msM=; b=DVEd5G4/YpJHsSxBtYdq6MCe4YmL/SXBoYHtYC6nFU5DwPrOJFaXzUbcPzYmOBTk3V FJdB+sCtTTUTa8PTEoU+9wScabcupf3OmelmQG5TxfpWx8AH7GhqJVaQelodlmGCDIE8 DE82/pS4FSi4dnDwvnwd1C0s3BgksYV4uxuPOFYu5KTDkIQ+szfrFYBUY4Qz64QhsrR1 WLqcNBUUwkVmd4GSymiDVhzbkIzsxdf3J+uQE/MXAXjOqEZl5MATJxwXkno9fIkexB8b cTfkehCImTb6Qzen9Hr8egDA2fRcMeDGWq4ah6iGNP2eeMthtjcojQSlwtwlPMoWfSuK 5Vgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sIlz+4ag6rTwqlRzYdJDRzxS5gdfRa5dROYXeNE0msM=; b=F/OKpQFdneuslG3Hr3UJ4SCIohgwRHZfdf4YI6dTGCdPBOodawCNQc6F+a5SL0JzlR stAq0MObpIcUuMSu7lR9yw0oKE/3BZ4D2VCRQdyp9u8Oud2tjIY65Of7n5/pToGmeMph 6+tFTisPTl+6bJ/I1T346PTx3NdcEeKqa4RRb6TWnJVFFBHZoSc8guhrHpvYWdZ9/7jO 0+WVbcNqhyuUsLUQS0FzgCrONFKcXUaTTdzKslwGM1m6j+gtl4+OAqVRhm/L4P2eAcyv gIhIJGl4C6dYq4TSo/biTpnXwYoJbgD3vkCrOR0S36bF//SUe9DUCGTD9vZbozpjnHxe WKEQ== X-Gm-Message-State: AOAM533HckH1+RFboVL1Nw0hcZYzAbczEcByXcbm0/DY+U4T2HSV+cJz Bs4ABOmf1sow79V1OsXcGnuM0YUBHkE= X-Google-Smtp-Source: ABdhPJyzxc0g3utPvdRaXkumBalrQgiRmc/8E7lLL/FBto1ES3FDhaE2A0rBZo6mUYjHI+eeW6mnNQ== X-Received: by 2002:a05:600c:4e4a:: with SMTP id e10mr12021463wmq.155.1637883376927; Thu, 25 Nov 2021 15:36:16 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id m1sm4337171wme.39.2021.11.25.15.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 15:36:16 -0800 (PST) From: zimoun To: 52117@debbugs.gnu.org Subject: [PATCH 5/6] gnu: julia-requires: Disable parallel tests. Date: Fri, 26 Nov 2021 00:35:58 +0100 Message-Id: <20211125233559.34575-5-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211125233559.34575-1-zimon.toutoune@gmail.com> References: <20211125233559.34575-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/julia-xyz.scm (julia-requires)[arguments]: Disable parallel tests. --- gnu/packages/julia-xyz.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm index f68cd1647b..6ddf1429ca 100644 --- a/gnu/packages/julia-xyz.scm +++ b/gnu/packages/julia-xyz.scm @@ -3966,6 +3966,8 @@ (define-public julia-requires (sha256 (base32 "03hyfy7c0ma45b0y756j76awi3az2ii4bz4s8cxm3xw9yy1z7b01")))) (build-system julia-build-system) + (arguments + `(#:parallel-tests? #f)) (inputs ;required for test `(("julia-example" ,julia-example))) (propagated-inputs -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 25 18:36:28 2021 Received: (at 52117) by debbugs.gnu.org; 25 Nov 2021 23:36:28 +0000 Received: from localhost ([127.0.0.1]:58252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOI0-0000wM-Ih for submit@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:28 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:46645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHv-0000vA-3W for 52117@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:23 -0500 Received: by mail-wr1-f45.google.com with SMTP id u1so14693035wru.13 for <52117@debbugs.gnu.org>; Thu, 25 Nov 2021 15:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EMFnCxByim5PKPHSfoNJZqgeN1HgQrad2WehR6DVbIw=; b=Uj+De89sJhev12mOUrboqAHLTGw30886uwBL+iXGgQi1yeex4JpOvJVxqcGTVHc+YF R9KOfLbj326UL0X3+bpkwk0IhEw2rDtr/sOY8X8V71jsPVTbmF1qyPG+TOKg+xopyfdg RdtnoSjun+Z+P29LJDBF8ZBnhE4E1BB96oyfoKFP34z3m2yq/+S+OYOAVCihWRsR8L1U v+P8YdxO8f8GbzXd1FY0AeTs8bXR2KBR+El6m7+aDsjTEAhtChOfE7+wTxX9q+iwD6a+ IOIlsk/2ZxWXtRyGO3Ut/S8NnxKT4A/ZWwKG1o7zbsm81VgDok7Q2EVIy4j9vyV+I3MW tMpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EMFnCxByim5PKPHSfoNJZqgeN1HgQrad2WehR6DVbIw=; b=q9XyfxLrXWEAwJmy2FfbPF4449g2/5+LW66gK3IDW9zbGy9FAcO8LQDR+RyeBAnFg3 r2K1vmxFvhOvg3/uGtuD6b1oJasZsV8sbo93xTgN5jVJc47B1wT919dRvd05pSTe+y18 FfCFCJTdMMGc97w/rsVABFVg+IDwWRRQY6u+VST/AyHBC0tW26luDUEL1EKQuP6Wif4b sz8QPzneirCF1Ri9682LNlOdyb+iFyfeiPJm1nlrHyv+97tipgLnClILlQkNowJcm7yF xpfi2LAcDmqYuGcoisj4dwTMqXdII7AoCvgAbpZXO1lyEl/r8SyJ+wYmwOkM0aHz73z6 MuPQ== X-Gm-Message-State: AOAM531wMyJbeiDQPUZf2EGUbLqhHcge2KAOmLyjJ3pYUot1EPmz/gSu o6aDC2eA6V1gEfr17FWqaKTAOn+E9qs= X-Google-Smtp-Source: ABdhPJz8TsOV75vhu32kGFdeHCx5i/mpmYeEIreSN/lSrq4lUYt29QDoVl59EA2TBUUD2qytLNshcQ== X-Received: by 2002:a5d:64ea:: with SMTP id g10mr11106932wri.242.1637883377536; Thu, 25 Nov 2021 15:36:17 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id m1sm4337171wme.39.2021.11.25.15.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 15:36:17 -0800 (PST) From: zimoun To: 52117@debbugs.gnu.org Subject: [PATCH 6/6] gnu: julia-unitful: Disable parallel tests. Date: Fri, 26 Nov 2021 00:35:59 +0100 Message-Id: <20211125233559.34575-6-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211125233559.34575-1-zimon.toutoune@gmail.com> References: <20211125233559.34575-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/julia-xyz.scm (julia-unitful)[arguments]: Disable parallel tests. --- gnu/packages/julia-xyz.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm index 6ddf1429ca..d2e57aeadc 100644 --- a/gnu/packages/julia-xyz.scm +++ b/gnu/packages/julia-xyz.scm @@ -4854,6 +4854,8 @@ (define-public julia-unitful (sha256 (base32 "10qwscd15dnmvx116dwvg99m7kmwgmj5ahdkq7psiq48lcc554gq")))) (build-system julia-build-system) + (arguments + `(#:parallel-tests? #f)) (propagated-inputs `(("julia-constructionbase" ,julia-constructionbase))) (home-page "https://painterqubits.github.io/Unitful.jl/stable/") -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 26 21:26:19 2021 Received: (at 52117) by debbugs.gnu.org; 27 Nov 2021 02:26:19 +0000 Received: from localhost ([127.0.0.1]:60874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqnPv-0002tg-GT for submit@debbugs.gnu.org; Fri, 26 Nov 2021 21:26:19 -0500 Received: from mail-qk1-f170.google.com ([209.85.222.170]:38500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqnPt-0002tS-0a for 52117@debbugs.gnu.org; Fri, 26 Nov 2021 21:26:17 -0500 Received: by mail-qk1-f170.google.com with SMTP id q64so16598900qkd.5 for <52117@debbugs.gnu.org>; Fri, 26 Nov 2021 18:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=scl8lPYf+2pUl+hlBZVaD04oAJDLTLZRXul8qTIohQI=; b=Ru4FmQSurUQyq055SY66veijH7XELbdWLP2jbZNeZigZQDu3skuun7lwWq/OAYiHFi 7M368exSPjqWL47DnEitg+i9O40JmbnKCKgsLvS2eBcVKvuzMY2lg59cZ6P7XCnzcY2w rrk2IUaqdSO2MBi98Kj0lK2wdI/9h3MtrdAMLy5WTsq2QPFAJVFnZAbEHbWqWaozrxmu 5Oj+YxqYcTrvsD37NCDrGVjGOrhvQbiZow6iCh7TwMOdRlm5pqlKWdUyJ4HDO0AZkixg ncQbKa6mjcGYi1xeiHvT3q92cN3XhhRScVBlmOAyNA7lYTF42UKRQjZZk9gnhb24tSf6 Mshw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=scl8lPYf+2pUl+hlBZVaD04oAJDLTLZRXul8qTIohQI=; b=ypGlaQufhvzzI2Q4C7/GAAMcl91oVAj3g/DHUFwEHk2nVlxRg/WN8nzKnj/rCv6/ek cnjtMgjlNPvLohlhMq2UGstnExfqy6P8pCt0/qn3FPnuCy/SSXTtsRPpEGcmhw4Wj/nm kOr+uHRfMDgNiY/zsmoDRHJnfVo1u5+LG641ehr+FsVXtOW1jMIBoJuXqN3kgX2wifj3 bsMRQKiL9Mq4etqxX/D/IgAY3OL06tchb2T+BMHLIgX/MlCBMdOnLDRw4sBg3mhU9kzG bDT4tEEJjBnM+DKw0CLIESXxu653I9g8R0+N0uOU1pIGA51ibnGNjs/DSCHepmOD3o7B eJTw== X-Gm-Message-State: AOAM531F/BXG+JVAnGjM3xRzosQtY2F7uH541KL5bbYbZ50KIeB8tOpd +CBwzUmLLG1nK6OWoF+9KRr2807LDUw6jQ== X-Google-Smtp-Source: ABdhPJxTGQKtCGDt4mueV57C/ayaWvITu8hoPkZvnr/A09RAS5Jxb/oWyTv7i7p9i2nZDVitNBuwTQ== X-Received: by 2002:a05:620a:e0c:: with SMTP id y12mr25775370qkm.109.1637979971183; Fri, 26 Nov 2021 18:26:11 -0800 (PST) Received: from hurd (dsl-148-169.b2b2c.ca. [66.158.148.169]) by smtp.gmail.com with ESMTPSA id w2sm4262589qta.11.2021.11.26.18.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 18:26:10 -0800 (PST) From: Maxim Cournoyer To: zimoun Subject: Re: bug#52117: [core-updates-frozen] [PATCH 0/6] Fix Julia packages. References: <20211125233225.34466-1-zimon.toutoune@gmail.com> <20211125233559.34575-1-zimon.toutoune@gmail.com> Date: Fri, 26 Nov 2021 21:26:09 -0500 In-Reply-To: <20211125233559.34575-1-zimon.toutoune@gmail.com> (zimoun's message of "Fri, 26 Nov 2021 00:35:54 +0100") Message-ID: <87k0gu8hby.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: 52117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Simon! zimoun writes: > * gnu/packages/julia.scm (julia)[arguments]<#:phases>: Fix parallel-test. > --- > gnu/packages/julia.scm | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/gnu/packages/julia.scm b/gnu/packages/julia.scm > index ac5bf7db25..c123711da5 100644 > --- a/gnu/packages/julia.scm > +++ b/gnu/packages/julia.scm > @@ -315,11 +315,10 @@ (define-public julia > (substitute* (jlpath "Zlib") > (((from "libz")) (to "zlib" "libz")))))) > (add-after 'unpack 'enable-parallel-tests > - ;; FIXME: julia fails at networking in the container and falls back > - ;; to a single worker, which causes the tests to not run in > - ;; parallel (see: https://github.com/JuliaLang/julia/issues/43205). > - (lambda* (#:key parallel-build? #:allow-other-keys) > - (setenv "JULIA_CPU_THREADS" (if parallel-build? > + ;; Parallel tests require 'julia-allow-parallel-build.patch'. > + ;; https://github.com/JuliaLang/julia/issues/43205. > + (lambda* (#:key parallel-tests? #:allow-other-keys) > + (setenv "JULIA_CPU_THREADS" (if parallel-tests? > (number->string (parallel-job-count)) > "1")) > (format #t "JULIA_CPU_THREADS environment variable set to ~a~%" I've moved the comment where I thought it made more sense, at the top of the patch itself, like so: --8<---------------cut here---------------start------------->8--- modified gnu/packages/julia.scm @@ -315,8 +315,6 @@ (define-public julia (substitute* (jlpath "Zlib") (((from "libz")) (to "zlib" "libz")))))) (add-after 'unpack 'enable-parallel-tests - ;; Parallel tests require 'julia-allow-parallel-build.patch'. - ;; https://github.com/JuliaLang/julia/issues/43205. (lambda* (#:key parallel-tests? #:allow-other-keys) (setenv "JULIA_CPU_THREADS" (if parallel-tests? (number->string (parallel-job-count)) modified gnu/packages/patches/julia-allow-parallel-build.patch @@ -1,3 +1,8 @@ +Allow parallel tests with isolated environment. + +See https://github.com/JuliaLang/julia/issues/43205 and +https://github.com/JuliaLang/julia/pull/43211. + diff --git a/test/runtests.jl b/test/runtests.jl index 2f9cd058bb..150395e78c 100644 --- a/test/runtests.jl @@ -11,14 +16,11 @@ index 2f9cd058bb..150395e78c 100644 using Base: Experimental include("choosetests.jl") -@@ -83,11 +83,15 @@ prepend!(tests, linalg_tests) +@@ -83,11 +83,12 @@ prepend!(tests, linalg_tests) import LinearAlgebra cd(@__DIR__) do n = 1 - if net_on -+ # Allow parallel tests with isolated environment -+ # https://github.com/JuliaLang/julia/issues/43205 -+ # https://github.com/JuliaLang/julia/pull/43211 + if net_on || haskey(ENV, "JULIA_CPU_THREADS") n = min(Sys.CPU_THREADS, length(tests)) n > 1 && addprocs_with_testenv(n) --8<---------------cut here---------------end--------------->8--- Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 26 22:17:13 2021 Received: (at 52117) by debbugs.gnu.org; 27 Nov 2021 03:17:13 +0000 Received: from localhost ([127.0.0.1]:60895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqoDB-00049O-1N for submit@debbugs.gnu.org; Fri, 26 Nov 2021 22:17:13 -0500 Received: from mail-qt1-f174.google.com ([209.85.160.174]:41953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqoD9-00049A-15 for 52117@debbugs.gnu.org; Fri, 26 Nov 2021 22:17:11 -0500 Received: by mail-qt1-f174.google.com with SMTP id v22so10679018qtx.8 for <52117@debbugs.gnu.org>; Fri, 26 Nov 2021 19:17:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dQgw0IZhOdtWMvSmDn56WhYDzER7xeeZbXpjLT3h6XQ=; b=DvUj7oeNkMiq5Qwa1qfShZPOD8s0SNirE75OIJNGy0TB6+gmNxXlBHAYAzbCvWb9WE 278EN7cGnEi1Q7QVKrvT22lsysxqW5lI0T0tyeBVCo+kR6iB45a89HClhF127SMBIDI/ wD30zcAwbCUCQB4phoDle2w5tPDgvFxOyqYKiB15NmTgRaSFTCpreP3f7guDlBYsFMlz hIzxug9CDeNWo6tWOd4uP5Xqsvvzyhq5g2DBOvpGx31eGVXziC0nzP5r0cl0kp8adK2n fZ2CuMjv9GdV8whVXhQOnNZzwWFhT3DcrVjtXx3mh6N1v2v44y8b4EXaZU5iwNPxvLGs vs7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dQgw0IZhOdtWMvSmDn56WhYDzER7xeeZbXpjLT3h6XQ=; b=ZkSnBiuyHL12NJCQtw2HlfQKlUWDcLsjWPWg9YWCEiX5tvqhcfFXX95KcXXg+AxdKa AfY4amwkp2tFd88N7a4a46XvXtNOzO08L/fkeq7g8gSBwFwfH3LyneeAd9aoLWkTvHfm jXyEzB8al4XlPfSvM9lGypBAZLFuVfRE0JyrtTjPjuOpHb40wCjxpsDzNHKVrvINfQmG //Qt0x4NNllRBMpGbddERy4/+o6wh5IyRZI/PTBCwDmZXbGAtIPHtl+YSI+YPBp9BrGw sc9nk/FS1eq3gUj8mTKFYQD63DSHkHKk618mAWeeu2DmLiRx6amLwWYz/NnrQRtTgWKy mTRA== X-Gm-Message-State: AOAM531MxQUpcu6OG0GocbTfOW1gkRZhJoJUgCH1Zza77f9BIXYEn6Do U1ToFuswuVhBRytwTvj9TLtOs8GEfT+c8A== X-Google-Smtp-Source: ABdhPJxscJoyhD2HKXDfmh9Sz37vK/gfW81K1tA5TBbBuP5faS3y8ad56hD0g9Q+6qbM1+GD/HA5Bw== X-Received: by 2002:ac8:5b90:: with SMTP id a16mr29257232qta.300.1637983024924; Fri, 26 Nov 2021 19:17:04 -0800 (PST) Received: from hurd (dsl-148-169.b2b2c.ca. [66.158.148.169]) by smtp.gmail.com with ESMTPSA id z13sm3999464qkj.1.2021.11.26.19.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 19:17:04 -0800 (PST) From: Maxim Cournoyer To: zimoun Subject: Re: bug#52117: [core-updates-frozen] [PATCH 0/6] Fix Julia packages. References: <20211125233559.34575-1-zimon.toutoune@gmail.com> <20211125233559.34575-2-zimon.toutoune@gmail.com> Date: Fri, 26 Nov 2021 22:17:02 -0500 In-Reply-To: <20211125233559.34575-2-zimon.toutoune@gmail.com> (zimoun's message of "Fri, 26 Nov 2021 00:35:55 +0100") Message-ID: <87fsri8ez5.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: 52117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Simon! zimoun writes: > Even providing '--procs=1' launches 2 workers which breaks some testsuite of ^ the > packages; therefore set '#:parallel-tests?' to '#false' was ineffective. ^ some ^ setting It's good to put the rationale here, as you did. > * guix/build/julia-build-system.scm (check): Fix unexpected behaviour from > 'julia' command line option. But in the changelog message I'd expect to see foremost *what* it does rather than a reformulation of *why* it does it :-). E.g., something like: do not pass the '--procs' argument when not running the tests in parallel. > --- > guix/build/julia-build-system.scm | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/guix/build/julia-build-system.scm b/guix/build/julia-build-system.scm > index f0dc419c17..af478fd4a3 100644 > --- a/guix/build/julia-build-system.scm > +++ b/guix/build/julia-build-system.scm > @@ -112,7 +112,10 @@ (define* (check #:key tests? source inputs outputs julia-package-name > (builddir (string-append out "/share/julia/")) > (jobs (if parallel-tests? > (number->string (parallel-job-count)) > - "1"))) > + "1")) > + (nprocs (if parallel-tests? > + (string-append "--procs=" jobs) > + ""))) > ;; With a patch, SOURCE_DATE_EPOCH is honored > (setenv "SOURCE_DATE_EPOCH" "1") > (setenv "JULIA_DEPOT_PATH" builddir) > @@ -122,8 +125,7 @@ (define* (check #:key tests? source inputs outputs julia-package-name > ""))) > (setenv "JULIA_CPU_THREADS" jobs) > (setenv "HOME" "/tmp") > - (invoke "julia" "--depwarn=yes" > - (string-append "--procs=" jobs) > + (invoke "julia" "--depwarn=yes" nprocs Here nprocs can be ""; is it really OK to pass an empty string argument to julia? > (string-append builddir "loadpath/" > package "/test/runtests.jl")))) > #t) Trailing '#t' are no longer required. Actually, looking at the output of julia --help: -p, --procs {N|auto} Integer value N launches N *additional* local worker processes The key is 'additional' :-). So to disable parallel processing it needs to be 0. I've modified it like so: --8<---------------cut here---------------start------------->8--- (define* (check #:key tests? source inputs outputs julia-package-name parallel-tests? #:allow-other-keys) (when tests? (let* ((out (assoc-ref outputs "out")) (package (or julia-package-name (project.toml->name "Project.toml"))) (builddir (string-append out "/share/julia/")) (job-count (if parallel-tests? (parallel-job-count) 1)) ;; The --proc argument of Julia *adds* extra processors rather than ;; specify the exact count to use, so zero must be specified to ;; disable parallel processing. (additional-procs (max 0 (1- job-count)))) ;; With a patch, SOURCE_DATE_EPOCH is honored (setenv "SOURCE_DATE_EPOCH" "1") (setenv "JULIA_DEPOT_PATH" builddir) (setenv "JULIA_LOAD_PATH" (string-append builddir "loadpath/" ":" (or (getenv "JULIA_LOAD_PATH") ""))) (setenv "JULIA_CPU_THREADS" (number->string job-count)) (setenv "HOME" "/tmp") (invoke "julia" "--depwarn=yes" "--procs" (number->string additional-procs) (string-append builddir "loadpath/" package "/test/runtests.jl"))))) --8<---------------cut here---------------start------------->8--- And took the liberty to remove trailing #f in other phases. Thank you! Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 27 01:31:44 2021 Received: (at 52117-done) by debbugs.gnu.org; 27 Nov 2021 06:31:44 +0000 Received: from localhost ([127.0.0.1]:32774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqrFP-0002wK-Tx for submit@debbugs.gnu.org; Sat, 27 Nov 2021 01:31:44 -0500 Received: from mail-qk1-f180.google.com ([209.85.222.180]:44888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqrFO-0002w8-Hv for 52117-done@debbugs.gnu.org; Sat, 27 Nov 2021 01:31:43 -0500 Received: by mail-qk1-f180.google.com with SMTP id 132so16922680qkj.11 for <52117-done@debbugs.gnu.org>; Fri, 26 Nov 2021 22:31:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=2uYVhEjyWVeF3+aVao7g8UnEekLzNZ0m1mEXyiSsN5k=; b=GpUifTru3JIA+Ap73lT0EeNM7o6rfH0fBjRvLKva6NXTDQnMlnb9agucBzZgJm7Uxp PWhimyaCnFLmv5/U0B4D/hWpjzoJdUy1YSVvpDgCfQJpFtZcFag1YdV3QMOAkK87M5EM HA9tBIs891tl+d/lHWCM/uuzPdrqXXcFFjMqoKINT70eB4vA+qSh7XVzMoGXEnyxaELH kNk0bSXIG2u1FWhC5jMB5yw3vdGznSrOUDFQFEzLuWPy5gZSXytYfpeiSIWS9QRkaxZq LFJfzRX3cS/N8kvJddFMOj91Ry2tYewDzi3xpJa2vXnsYIERq8WbkImvJHfDtYQk52OO DfPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=2uYVhEjyWVeF3+aVao7g8UnEekLzNZ0m1mEXyiSsN5k=; b=aOtJCdfaGHWCR9Cf/vFqz+Z+ITJeSFgVJYMKTkOPcyJ3K+iRvXuk5XCMmcUNDkDScj TE8UWsmSffgndIWQZMeyoX9EE43VjORPQX0aKbk/oCoAZrqHzWpSgMFhvdO3eMudSoM5 0aqpqexRecaZd02MkO+cStfGqdNGc1hJVOr5bYaoaPj4wzZbMxbzfVqiHpUPmovZNp6D 9//rke1keXrtiFmshVF8VdQI4UUWBeO5y4ri2Mb1ZG1VcUU5VkoTnk/j2HDHLm4paV3o 5CeWCJhcPVrOkN9q9Q4sD4FduGeHQ4Nxis9bRSF3AlyBLqJKY9PW+frPCQUUOh7gouI2 ZnBg== X-Gm-Message-State: AOAM530VT1JavMH9n8BPIfdpYierLog7Kpth2mSqb9OKx9Oa7QgRJJhw YDBSaYfU1Ph1i+j505+RGIAzXuogsGr7Mw== X-Google-Smtp-Source: ABdhPJz4hm7EBWA+oxu8zvLFKYpeRy2RuFLQASul+fNW1BzTuu6rwk4hknfEKi4H6aAzhxoGVnCpLA== X-Received: by 2002:a05:620a:4082:: with SMTP id f2mr18235747qko.590.1637994696894; Fri, 26 Nov 2021 22:31:36 -0800 (PST) Received: from hurd (dsl-148-169.b2b2c.ca. [66.158.148.169]) by smtp.gmail.com with ESMTPSA id o20sm4845499qkp.114.2021.11.26.22.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 22:31:36 -0800 (PST) From: Maxim Cournoyer To: zimoun Subject: Re: [bug#52117] [core-updates-frozen] [PATCH 0/6] Fix Julia packages. References: <20211125233225.34466-1-zimon.toutoune@gmail.com> Date: Sat, 27 Nov 2021 01:31:35 -0500 In-Reply-To: <20211125233225.34466-1-zimon.toutoune@gmail.com> (zimoun's message of "Fri, 26 Nov 2021 00:32:25 +0100") Message-ID: <8735ni85yw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117-done Cc: 52117-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Simon, zimoun writes: > Hi, > > With this series, all the Julia packages builds again. The only one still > missing is 'julia-sundials-jll=E2=80=99. It probably requires to introdu= ce something > to julia-build-system but I have not investigated much. > > > Cheers, > simon > > > zimoun (6): > gnu: julia: Test correctly '#:parallel-tests?'. > build: julia-build-system: Correctly disable parallel tests. > gnu: julia-aqua: Disable parallel tests. > gnu: julia-interpolations: Disable parallel tests. > gnu: julia-requires: Disable parallel tests. > gnu: julia-unitful: Disable parallel tests. > > gnu/packages/julia-xyz.scm | 8 ++++++++ > gnu/packages/julia.scm | 9 ++++----- > guix/build/julia-build-system.scm | 8 +++++--- > 3 files changed, 17 insertions(+), 8 deletions(-) > > > base-commit: 138498feec335f68935f00f8a97924c90c7f59b0 Now pushed to core-updates-frozen; I've made some changes to the build-system one after finding out that --procs meant "adding" cores, rather than specifying their exact count (and you cannot add 0!). The parallel build of Julia packages uses a ton of RAM, but it's fast! :-). Thanks a lot, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 27 07:39:17 2021 Received: (at 52117) by debbugs.gnu.org; 27 Nov 2021 12:39:17 +0000 Received: from localhost ([127.0.0.1]:33161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqwz6-0002Lh-UR for submit@debbugs.gnu.org; Sat, 27 Nov 2021 07:39:17 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:42514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqwz1-0002LQ-Sb for 52117@debbugs.gnu.org; Sat, 27 Nov 2021 07:39:15 -0500 Received: by mail-wr1-f51.google.com with SMTP id c4so24722791wrd.9 for <52117@debbugs.gnu.org>; Sat, 27 Nov 2021 04:39:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=c3QjDalJejgE+HwT/NEaRB5LN07aELHzWv7bCs4myBE=; b=Mu0qwK/fd0jt0dxcz++LqzIB2g2bxPPYWAQb15yzCfClsWEG3K2zCUvKl1KuuAhcvo R5n4dD2co9O7EhTe94UfnV8pLJ3yJCwfhDGq6Xmv5NoJGQ8jErZjCfxLWnv/KM5EOqyQ AiYtF9OxAICHBhrmvI9Q9znMERl5B1K1QqSArn9AFwAaYb9qd5sOv41d+4hjaBStNHi8 Xgz6N5mSRvjKvgAhiSVq3I/2whjnvJpzyUKGQDOei2xGYObki3gSbJaQJtKieGFL32c3 VpR2TcOGTjm1ok0KsK5KaDVAWfrLVKX5B744w5AgRRx7E7flWMITk5E6yZQ/B9X4MzSm 0kIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=c3QjDalJejgE+HwT/NEaRB5LN07aELHzWv7bCs4myBE=; b=fdd/W4bQKDXqCS9zZnYw8lvWfqbi+BF2UlgEX7U+isgczrPCd/V+3UaB1WNmdc0cEF MkSRwe+2MHlaUTOSs+GZRgdquVb0z0zkpFVEdUGtH5pzCn3Uk+gSv66StIuXG4nlL1YB hQToX+lxQNfk02BI8VEo0i7NgznTYOLdSFb9EYoCXKKGpHcmLgDkJp521ET6YX9aAHJs yLFDN/VfPPz1r18Y1YF6U3LWvykJ5T8UNGPjjoxdqH9S6a2mX/sCYppe7mlzVUrZZdXh 6h9TF0iMI3T6bpQPw2fReqB2EYatHxGtiv/kGmjMwBmIf/4GDzyrexq3ZvF/fzRD1s+k p23Q== X-Gm-Message-State: AOAM531bH8xrExurYNXQIIrY4WCgdp8VdRJdkLYRjx4TOJzOwKb9b6y9 2ogm65mgpyU1Lonn/y+C4+9eN95QvRg= X-Google-Smtp-Source: ABdhPJxquJDbn0vREjzBmccIs0ZrKZFA2LUy47nqtNlk2WTU3URxjH+BGNZdeQZ8tgcKiz1GT+kAmw== X-Received: by 2002:a5d:550f:: with SMTP id b15mr20150976wrv.212.1638016745968; Sat, 27 Nov 2021 04:39:05 -0800 (PST) Received: from lili (2a01cb04061b8800444bb83f830ae295.ipv6.abo.wanadoo.fr. [2a01:cb04:61b:8800:444b:b83f:830a:e295]) by smtp.gmail.com with ESMTPSA id x1sm8354109wru.40.2021.11.27.04.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Nov 2021 04:39:05 -0800 (PST) From: zimoun To: Maxim Cournoyer Subject: Re: bug#52117: [core-updates-frozen] [PATCH 0/6] Fix Julia packages. In-Reply-To: <87fsri8ez5.fsf_-_@gmail.com> References: <20211125233559.34575-1-zimon.toutoune@gmail.com> <20211125233559.34575-2-zimon.toutoune@gmail.com> <87fsri8ez5.fsf_-_@gmail.com> Date: Sat, 27 Nov 2021 13:38:57 +0100 Message-ID: <861r31kc2m.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: 52117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, Thanks for the review and the improved patch. I am sorry if the commit message and/or changelog I provided was badly worded, but somehow it was an attempt to explain the odd behaviour =E2=80= =93 at least counter-intuitive since I initially felt into when sending the very first patch allowing parallel tests and you felt too, I guess. :-) On Fri, 26 Nov 2021 at 22:17, Maxim Cournoyer w= rote: >> --- >> guix/build/julia-build-system.scm | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/guix/build/julia-build-system.scm b/guix/build/julia-build-= system.scm >> index f0dc419c17..af478fd4a3 100644 >> --- a/guix/build/julia-build-system.scm >> +++ b/guix/build/julia-build-system.scm >> @@ -112,7 +112,10 @@ (define* (check #:key tests? source inputs outputs = julia-package-name >> (builddir (string-append out "/share/julia/")) >> (jobs (if parallel-tests? >> (number->string (parallel-job-count)) >> - "1"))) >> + "1")) >> + (nprocs (if parallel-tests? >> + (string-append "--procs=3D" jobs) >> + ""))) >> ;; With a patch, SOURCE_DATE_EPOCH is honored >> (setenv "SOURCE_DATE_EPOCH" "1") >> (setenv "JULIA_DEPOT_PATH" builddir) >> @@ -122,8 +125,7 @@ (define* (check #:key tests? source inputs outputs j= ulia-package-name >> ""))) >> (setenv "JULIA_CPU_THREADS" jobs) >> (setenv "HOME" "/tmp") >> - (invoke "julia" "--depwarn=3Dyes" >> - (string-append "--procs=3D" jobs) >> + (invoke "julia" "--depwarn=3Dyes" nprocs > > Here nprocs can be ""; is it really OK to pass an empty string argument > to julia? Yes it is OK. When #:parallel-tests? sets to #f, my patch leads to the call =E2=80=9Cjulia --depwarn=3Dyes=E2=80=9D which is valid. Your modified= patch adds another test but leads to the same call =E2=80=9Cjulia --depwarn=3Dyes=E2= =80=9D. --8<---------------cut here---------------start------------->8--- + (job-count (if parallel-tests? + (parallel-job-count) + 1)) + ;; The --proc argument of Julia *adds* extra processors rather = than + ;; specify the exact count to use, so zero must be specified to + ;; disable parallel processing... [..] + (apply invoke "julia" + `("--depwarn=3Dyes" + ,@(if parallel-tests? + ;; XXX: ... but '--procs' doesn't accept 0 as a valid + ;; value, so just omit the argument entirely. + (list (string-append "--procs=3D" + (number->string additional-proc= s))) + '()) --8<---------------cut here---------------end--------------->8--- So because of 2 tests. I think your modified patch is more =E2=80=9Ccomplicated=E2=80=9D. :-) About this, --8<---------------cut here---------------start------------->8--- + (additional-procs (max 0 (1- job-count)))) --8<---------------cut here---------------end--------------->8--- I considered that it was not a big deal; initially, I did something similar in =E2=80=99let=E2=80=99 but remove it because it changes nothing f= rom my experiments. In fact, because =E2=80=99--procs=E2=80=99 overrides JULIA_CP= U_THREADS and run Julia with n or n+1 is more or less the same for the Julia land, IMHO. Well, it is not clear what is the load for the main worker. And JULIA_CPU_THREADS=3D1 is required for running using only one worker. Anyway, this changes nothing, practically speaking. :-) Indeed, it is better and more consistent. Last, I am confused by Cuirass. Because it says evaluation complete but julia-* packages are scheduled. https://ci.guix.gnu.org/eval/48802?status=3Dpending And for instance, https://ci.guix.gnu.org/build/1853818/log/raw BTW, Berlin has some issues I guess #48720 - d508c5b was pushed CommitDate: Fri Nov 26 23:21:45 2021 +0100 - 941f776 was pushed CommitDate: Sat Nov 27 01:22:32 2021 -0500 - 9c4752b was pushed CommitDate: Sat Nov 27 10:24:12 2021 +0100=20 #48802 - 1b8a18b was pushed CommitDate: Sat Nov 27 11:48:17 2021 +0100 I do not understand why 941f776 or 9c4752b had not been evaluated. Could you give a look? For example, by restarting the evaluation? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 27 14:01:56 2021 Received: (at 52117) by debbugs.gnu.org; 27 Nov 2021 19:01:56 +0000 Received: from localhost ([127.0.0.1]:34538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mr2xP-0004oA-RK for submit@debbugs.gnu.org; Sat, 27 Nov 2021 14:01:56 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:37722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mr2xN-0004nv-Nq for 52117@debbugs.gnu.org; Sat, 27 Nov 2021 14:01:54 -0500 Received: by mail-wr1-f46.google.com with SMTP id d9so5595595wrw.4 for <52117@debbugs.gnu.org>; Sat, 27 Nov 2021 11:01:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=Ln62zGdOpr0Yc9qrB3lSacpqaECEm4fWR1isx/O/2eA=; b=VqPDaYz+gEvz7F1YY7w80GCKldGQ7vlFFDkhQIaspcge/HZOzukV7HW2NnDacpUnjJ ddDbHUYZhnahQbAkVzy0gu7Lx9FWIzinTWbBRRebe/LO9+ElEiNjH3h9Gwd7NR+uWzf/ jt/3/5gA54cjVQ3QazO5WeYSI0qB67/I1MP08z14Y4+Ch+bsnZH7vpHD8DdoBCbBL5tT BEaGSwJJKWQbctBqMbQrFpYnAWOMmTthyKFGwsKXDRL9Lx5X4Wdb3naNYYzo/fo/Og/E Kl4eP64m1r9uBD4UE7+lGUxe+jXc9LTWqmxbsFXI58PcsgCgro1Dy188B7s8JgErjAMm 4Vzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Ln62zGdOpr0Yc9qrB3lSacpqaECEm4fWR1isx/O/2eA=; b=KyZAFn3tJTNaWyZVGna/JllE75p4Yt3hSSLNO/0ZliP79YQLPwgzJZHXDz94ElfY7r 8n0QNTrrrtMkE1w/+uuSPi6crC+ohNSGmlmhmxyIC2SDP8yXVewh5I4HAVL8umezd0he fSENzX0lkhde4K247oFmhuJg+zqU/thQahMwWA+mkcXECFErnjOJloynQAsukohiZNVi NBU5KQHsd6sOB2Vzyhbnte0/nnByVNPWZQk5Ul+M+ZfV1avisGk8VDHd7pR3QOKs8gfO YZfNn8inx/iog2jFKfeqJnlsRA4FkNs75tWH5Hw1Tk3NuGoGT/k48AqF2+9MDuwd09As IFeg== X-Gm-Message-State: AOAM530FxAsNRscpDzwZj/Z5dfudd3pDy/dcRdj7+e/gCQ8vnOST3cPU 6Ulxy92b33wjAspljUMc9330S3IlRJg= X-Google-Smtp-Source: ABdhPJyceQ26E/mVyJLHkim5pmMjB5QIP1+pEhcd8KTNhKYmOwLSSKCrIyz28wCVXqH3qc+3jHA+LA== X-Received: by 2002:a5d:4e0b:: with SMTP id p11mr22206292wrt.88.1638039707799; Sat, 27 Nov 2021 11:01:47 -0800 (PST) Received: from lili (2a01cb04061b8800444bb83f830ae295.ipv6.abo.wanadoo.fr. [2a01:cb04:61b:8800:444b:b83f:830a:e295]) by smtp.gmail.com with ESMTPSA id d7sm8732978wrw.87.2021.11.27.11.01.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Nov 2021 11:01:47 -0800 (PST) From: zimoun To: Maxim Cournoyer Subject: Re: bug#52117: [core-updates-frozen] [PATCH 0/6] Fix Julia packages. In-Reply-To: <861r31kc2m.fsf@gmail.com> References: <20211125233559.34575-1-zimon.toutoune@gmail.com> <20211125233559.34575-2-zimon.toutoune@gmail.com> <87fsri8ez5.fsf_-_@gmail.com> <861r31kc2m.fsf@gmail.com> Date: Sat, 27 Nov 2021 19:59:21 +0100 Message-ID: <86sfvhifw6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: 52117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Sat, 27 Nov 2021 at 13:38, zimoun wrote: > Last, I am confused by Cuirass. Because it says evaluation complete but > julia-* packages are scheduled. > > https://ci.guix.gnu.org/eval/48802?status=3Dpending > > And for instance, > > https://ci.guix.gnu.org/build/1853818/log/raw > > BTW, Berlin has some issues I guess > > #48720 - d508c5b was pushed CommitDate: Fri Nov 26 23:21:45 2021 +0100 > - 941f776 was pushed CommitDate: Sat Nov 27 01:22:32 2021 -0500 > - 9c4752b was pushed CommitDate: Sat Nov 27 10:24:12 2021 +0100=20 > #48802 - 1b8a18b was pushed CommitDate: Sat Nov 27 11:48:17 2021 +0100 > > I do not understand why 941f776 or 9c4752b had not been evaluated. > > Could you give a look? For example, by restarting the evaluation? Re-checking now, all is green. \o/ I am still confused by Cuirass but that=E2=80=99s another story, I guess. Thanks for helping in this yak shaving. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 27 21:58:00 2021 Received: (at 52117) by debbugs.gnu.org; 28 Nov 2021 02:58:00 +0000 Received: from localhost ([127.0.0.1]:34786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrAO7-0000uh-QE for submit@debbugs.gnu.org; Sat, 27 Nov 2021 21:58:00 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:44988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrAO6-0000uV-FY for 52117@debbugs.gnu.org; Sat, 27 Nov 2021 21:57:58 -0500 Received: by mail-qt1-f169.google.com with SMTP id a2so12792053qtx.11 for <52117@debbugs.gnu.org>; Sat, 27 Nov 2021 18:57:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=jaIPA/l01t1TSTpclrwqQwQGmJNQI5hBcltQawr3Bl4=; b=D4AdjUHWT7faZBCURDR16RsJcYJrGPtPLgj8Pzgjy41KqSrTCElMcHRXnAaGIUJiDK 7iOBTzU4DKC+VpouheJZ/rugBpoSJOrPl38pfnfdNw7+xFiMpTjlJWnRUNxoCNshar0p rejMl+kGD3rxLc4n320dvvSNuCSNcsGzii2iskrm7TH4q/ovihbQOqWb+QLP9Mwwn0EK VfbWYouOHAwadMeTeD055ilCsi29t15KnhCvWXSU8IIrSppraMztrlITEp3fLdEW1LzP EsSJuhks92bppM0sL/zrMMfCg6NADdQv8/8B93JPVSC1FOfc+6TQU8+NN9jo5cy3iKPJ LMQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=jaIPA/l01t1TSTpclrwqQwQGmJNQI5hBcltQawr3Bl4=; b=vWUfGhEsNTeM4RVimSMLcKBppQtUnjZV33rr58iMHJpWQ7e4FZP0xyyTHk4F+MhnAL 1db80bPSdVxHmRseGFHrxEz8oHvr165WvZTK2yqUmPlDcsBR+5p23xvVNP1Tp5fDizDw STgV4Wc6tZpkeEFsCu0/9yo5Qg1B4d503zRGizaakYVMhnYtBkyTvBkjNXHWaYMnWi8A azd7QajbdS9JGNhiPL7cGBX7LRTNkywpUdtzT+JYXk9v3fpyrbKME9dcNSqLxjPJoLYt x8YlTR8Z9Uq32yjlxtsVu12qEhdrdPVOKx1ewPkjXYnAfMTJHv5hcORNaiOUX3EGlWZX bILA== X-Gm-Message-State: AOAM531bfikCKJECspxNPzU4ijgy2qx+a2EFSPlgnYZT+2hYUhpNfXXM 7SX9dm6JS2qJz7/Mu1s091TbkuZgzTbuFw== X-Google-Smtp-Source: ABdhPJzSrQh13HWqIhH5rmk3ZIZijxAf6INHw12cIm43uXVo1eQcJiwG73Wfw/vE/66qZHIgoQhk7g== X-Received: by 2002:a05:622a:18e:: with SMTP id s14mr34911751qtw.203.1638068272447; Sat, 27 Nov 2021 18:57:52 -0800 (PST) Received: from hurd (dsl-148-169.b2b2c.ca. [66.158.148.169]) by smtp.gmail.com with ESMTPSA id u21sm6479448qtw.29.2021.11.27.18.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Nov 2021 18:57:52 -0800 (PST) From: Maxim Cournoyer To: zimoun Subject: Re: bug#52117: [core-updates-frozen] [PATCH 0/6] Fix Julia packages. References: <20211125233559.34575-1-zimon.toutoune@gmail.com> <20211125233559.34575-2-zimon.toutoune@gmail.com> <87fsri8ez5.fsf_-_@gmail.com> <861r31kc2m.fsf@gmail.com> Date: Sat, 27 Nov 2021 21:57:51 -0500 In-Reply-To: <861r31kc2m.fsf@gmail.com> (zimoun's message of "Sat, 27 Nov 2021 13:38:57 +0100") Message-ID: <87tufx6l74.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: 52117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Simon, zimoun writes: > Hi Maxim, > > Thanks for the review and the improved patch. > > I am sorry if the commit message and/or changelog I provided was badly > worded, but somehow it was an attempt to explain the odd behaviour =E2=80= =93 at > least counter-intuitive since I initially felt into when sending the > very first patch allowing parallel tests and you felt too, I guess. :-) No worries. Communicating changes (or anything) is always one of the greatest challenges in programming and elsewhere, it seems :-). The nice thing about it is that it can be improved with perseverance and some feedback. > > On Fri, 26 Nov 2021 at 22:17, Maxim Cournoyer = wrote: > >>> --- >>> guix/build/julia-build-system.scm | 8 +++++--- >>> 1 file changed, 5 insertions(+), 3 deletions(-) >>> >>> diff --git a/guix/build/julia-build-system.scm b/guix/build/julia-build= -system.scm >>> index f0dc419c17..af478fd4a3 100644 >>> --- a/guix/build/julia-build-system.scm >>> +++ b/guix/build/julia-build-system.scm >>> @@ -112,7 +112,10 @@ (define* (check #:key tests? source inputs outputs= julia-package-name >>> (builddir (string-append out "/share/julia/")) >>> (jobs (if parallel-tests? >>> (number->string (parallel-job-count)) >>> - "1"))) >>> + "1")) >>> + (nprocs (if parallel-tests? >>> + (string-append "--procs=3D" jobs) >>> + ""))) >>> ;; With a patch, SOURCE_DATE_EPOCH is honored >>> (setenv "SOURCE_DATE_EPOCH" "1") >>> (setenv "JULIA_DEPOT_PATH" builddir) >>> @@ -122,8 +125,7 @@ (define* (check #:key tests? source inputs outputs = julia-package-name >>> ""))) >>> (setenv "JULIA_CPU_THREADS" jobs) >>> (setenv "HOME" "/tmp") >>> - (invoke "julia" "--depwarn=3Dyes" >>> - (string-append "--procs=3D" jobs) >>> + (invoke "julia" "--depwarn=3Dyes" nprocs >> >> Here nprocs can be ""; is it really OK to pass an empty string argument >> to julia? > > Yes it is OK. When #:parallel-tests? sets to #f, my patch leads to > the call =E2=80=9Cjulia --depwarn=3Dyes=E2=80=9D which is valid. Your mo= dified patch > adds another test but leads to the same call =E2=80=9Cjulia --depwarn=3Dy= es=E2=80=9D. No, it would invoke julia with the following argv list: "julia" "-depwarn=3Dyes" "" [...]; My point is that invoke is equivalent to doing an execlp system call; and the arguments get passed as a list (including that empty string argument when parallel-tests? is #f). Whether this works or not is up to the application, so I'd suggest not relying on it. Consider for example: --8<---------------cut here---------------start------------->8--- (execlp "python" "python" "" "-c" "print('hello')") /gnu/store/cwqv4z5bvb5x6i0zvqgc1j1dnr6w9vp8-profile/bin/python: can't find '__main__' module in '/home/maxim/src/guix-core-updates-next/gnu/packages/' --8<---------------cut here---------------end--------------->8--- It fails because it interprets the empty string argument as the current directory, apparently. If that works with the above Julia invocation, that's great, but it doesn't make it cleaner in my opinion :-). > + (job-count (if parallel-tests? > + (parallel-job-count) > + 1)) > + ;; The --proc argument of Julia *adds* extra processors rathe= r than > + ;; specify the exact count to use, so zero must be specified = to > + ;; disable parallel processing... > > [..] > > + (apply invoke "julia" > + `("--depwarn=3Dyes" > + ,@(if parallel-tests? > + ;; XXX: ... but '--procs' doesn't accept 0 as a val= id > + ;; value, so just omit the argument entirely. > + (list (string-append "--procs=3D" > + (number->string additional-pr= ocs))) > + '()) > > > So because of 2 tests. I think your modified patch is more > =E2=80=9Ccomplicated=E2=80=9D. :-) It is slightly more complex indeed; but I think it provides the reader with useful knowledge of julia's quirks and is more correct. > About this, > > + (additional-procs (max 0 (1- job-count)))) > > I considered that it was not a big deal; initially, I did something > similar in =E2=80=99let=E2=80=99 but remove it because it changes nothing= from my > experiments. In fact, because =E2=80=99--procs=E2=80=99 overrides JULIA_= CPU_THREADS and > run Julia with n or n+1 is more or less the same for the Julia land, > IMHO. Well, it is not clear what is the load for the main worker. And > JULIA_CPU_THREADS=3D1 is required for running using only one worker. > Anyway, this changes nothing, practically speaking. :-) Indeed, it is > better and more consistent. Yeah, I don't like that the behavior of --procs is to *add* workers, rather than set its exact count; which make thing awkward. Even upstream get tricked by that by erroneously *adding* Sys.CPU_THREADS workers because of this in test/runtest.jl [0] [0] https://github.com/JuliaLang/julia/pull/43217#pullrequestreview-817102= 530 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 09:27:44 2021 Received: (at 52117) by debbugs.gnu.org; 29 Nov 2021 14:27:44 +0000 Received: from localhost ([127.0.0.1]:37552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrhdA-0006JL-4Q for submit@debbugs.gnu.org; Mon, 29 Nov 2021 09:27:44 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:42981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrhd7-0006J5-Ut for 52117@debbugs.gnu.org; Mon, 29 Nov 2021 09:27:43 -0500 Received: by mail-wr1-f50.google.com with SMTP id c4so37185821wrd.9 for <52117@debbugs.gnu.org>; Mon, 29 Nov 2021 06:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7EBv1fNE/qdLiylzrxq8Ndl5PO73ZEkXXft56FlxBek=; b=MsKhNLMb2N4lIJYSjdhpF5uwstBzLk2+b1Cbr5IZGRVC7N3eMXrA2nSqo/IRt4167/ wd85uu9QKllGkCnSfHB95Ii9qjuwR+Tw17rFSzcQG0+lPeoNOjkY9esojFFM1xpux/0l V3d/6vuRLyUUBoLL5pUD7CcSButRoRkJ2F5+CzuFX6KhmO5fAHkmmFqlqKh4mp+A/BTW eWFZsuhkhOFQICwDH8N65iR8LtIwOnrB9/N60854Tx//NJXpWlVbIgzMzOwZxW5iacYx goDJkFV3CjQ+BJgqpNBh8EEvmQEkh23yX7j+sLKVc8S2Fo3VQTxZu7jxAuYrgF6RFbyg 1W+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=7EBv1fNE/qdLiylzrxq8Ndl5PO73ZEkXXft56FlxBek=; b=IBSw3LteN8/xXqePRUsiOuYbZDkLXKY8XyDCDbEYylRUwY7J89VZ7BHw8Wq3uNVim1 6fuM+0MDqnzepBPrZn9nyOSnwkgV69oHGVwqD/Qn5nGHJ5RG94ZEbzSE5wsHiyVtnvhZ N0usse2w+yKaIoAXrHCg+eY60Cr+6duuphx9EwO+IvNF+NyO+bDTlkZkhZfT+SqosH9S YsKMc0Jl2n/4JOMykhuJAHmmYj7jhdqY4DNIbtphgdPLNfHNmACNSsmv2tADnskl+gbW ejJfRCHCso6GQkJICsXX+cjOOLu4a3a+XZ07x5fQX0BWX1pYuy9QxOsgL9nVyhBJW+tH /f3Q== X-Gm-Message-State: AOAM5327bYLExP8qGGbGmS0xeb2OTJbWQLgc6Pt1IPwV5wT3NgZCp8Xj mQTPKaI8DulT7sRow32CnRqdQUsodT4= X-Google-Smtp-Source: ABdhPJw1/cfKGK+Xoy25LcvgYZPtekdGnyMsxE49l3coO2KBepoUpq+bc9y9W9YsNgg4CrmjojXBBw== X-Received: by 2002:a5d:4312:: with SMTP id h18mr35011306wrq.626.1638196056167; Mon, 29 Nov 2021 06:27:36 -0800 (PST) Received: from pfiuh02 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id e3sm14089544wrp.8.2021.11.29.06.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 06:27:35 -0800 (PST) From: zimoun To: Maxim Cournoyer Subject: Re: bug#52117: [core-updates-frozen] [PATCH 0/6] Fix Julia packages. References: <20211125233559.34575-1-zimon.toutoune@gmail.com> <20211125233559.34575-2-zimon.toutoune@gmail.com> <87fsri8ez5.fsf_-_@gmail.com> <861r31kc2m.fsf@gmail.com> <87tufx6l74.fsf@gmail.com> Date: Mon, 29 Nov 2021 15:10:01 +0100 In-Reply-To: <87tufx6l74.fsf@gmail.com> (Maxim Cournoyer's message of "Sat, 27 Nov 2021 21:57:51 -0500") Message-ID: <87tufvqchy.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52117 Cc: 52117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Sat, 27 Nov 2021 at 21:57, Maxim Cournoyer w= rote: > No, it would invoke julia with the following argv list: "julia" > "-depwarn=3Dyes" "" [...]; > > My point is that invoke is equivalent to doing an execlp system call; > and the arguments get passed as a list (including that empty string > argument when parallel-tests? is #f). Whether this works or not is up > to the application, so I'd suggest not relying on it. Consider for > example: > > (execlp "python" "python" "" "-c" "print('hello')") > /gnu/store/cwqv4z5bvb5x6i0zvqgc1j1dnr6w9vp8-profile/bin/python: can't > find '__main__' module in > '/home/maxim/src/guix-core-updates-next/gnu/packages/' Thanks for the explanations. > It fails because it interprets the empty string argument as the current > directory, apparently. If that works with the above Julia invocation, > that's great, but it doesn't make it cleaner in my opinion :-). Indeed, and it is expected to fail because: --8<---------------cut here---------------start------------->8--- def _get_main_module_details(error=3DImportError): # Helper that gives a nicer error message when attempting to # execute a zipfile or directory by invoking __main__.py main_name =3D "__main__" try: return _get_module_details(main_name) except ImportError as exc: if main_name in str(exc): raise error("can't find %r module in %r" % (main_name, sys.path[0])) raise --8<---------------cut here---------------end--------------->8--- It allows to do: $ mkdir /tmp/foo $ echo print(42) > /tmp/foo/__main__.py $ python /tmp/foo Therefore, this $ python '' -c '0' just fails. Contrary to, $ cd /tmp/foo $ python '' -c '0' which just passes. To me, it is an oddity of the Python command-line which silently accepts a path; it is not documented by =E2=80=9Cpython -h= =E2=80=9D. Anyway, I agree that the behaviour when passing "" is up to the application, therefore it should be avoided. Cheers, simon From unknown Mon Jun 16 23:45:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 28 Dec 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator