GNU bug report logs - #52113
[PATCH] gnu: Add pnmixer

Previous Next

Full log

View this message in rfc822 format

From: Jaft <jaft.r <at> outlook.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: "52113 <at> debbugs.gnu.org" <52113 <at> debbugs.gnu.org>
Subject: [bug#52113] [PATCH] gnu: Add pnmixer
Date: Thu, 16 Dec 2021 21:40:09 +0000 (UTC)

[Message part 1 (text/plain, inline)]

> On Sunday, December 5, 2021, 02:43:27 PM CST, Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote: 
>
>
>
>
>
> Hello,
>
> Jaft <jaft.r <at> outlook.com> writes:
> 
> > * gnu/packages/gtk.scm (pnmixer):Add PNMixer
>
> Thank you. Some comments follow.
>
> > +(define-public pnmixer
> > +  (let ([version "0.7.2"])
>
> Nitpick: we don't use square brackets for let. Besides, you do not need
> a binding here, you just need to hard-code it in the version field.

Bah; sorry about that. It was mentioned to me, before, and I must've forgotten to change it before I sent this out. I probably should check my other patch submissions around this time as I probably forgot for those, as well…

> Could you send an updated patch?
>
> Regards,
> -- 
> Nicolas Goaziou

Thanks a ton for looking at my patch; all updates should've been applied and I've attached the new patch to this E-mail.

[pnmixer2.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.