GNU bug report logs - #5211
Color escape codes in the output of vc-git-print-log

Previous Next

Full log

Message #43 received at 5211 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 5211 <at> debbugs.gnu.org
Subject: Re: bug#5211: Color escape codes in the output of vc-git-print-log
Date: Tue, 15 Dec 2009 06:57:30 -0800 (PST)

Juanma Barranquero <lekktu <at> gmail.com> writes:

  > Package: emacs,vc
  > Tags: patch
  > Version: 23.1.90
  > Severity: minor
  > 
  > 
  > Depending of your setting of color.diff, color is used for log output,
  > and vc-print-log shows garbage (OK, escape codes for color):
  > 
  > ^[[33mcommit 43a3bf88e5e495ad048b3a6d3cf852e1e7a02f1c^[[m
  > Author: xxx <yyy <at> zzz>
  > Date:   2009-12-14 17:11:35 +0200
  > 
  >     blah blah blah
  > 
  > 
  > As color in *vc-change-log* buffers is an issue for font-locking, and
  > not for git log, the command should be called with --no-color.
  > 
  > OK to the following patch?
  > 
  >     Juanma
  > 
  > 
  > 2009-12-14  Juanma Barranquero  <lekktu <at> gmail.com>
  > 
  > 	* vc-git.el (vc-git-print-log): Pass --no-color to `git log'.

When did the --no-color option appear?
If we pass it by default, then it will break C-x v l for git versions
that do not support it.
If --no-color is old enough, the it might not matter...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.