GNU bug report logs - #52075
[PATCH 0/4] gnu: alot: Update to 0.10.

Previous Next

Full log

View this message in rfc822 format

From: Tanguy LE CARROUR <tanguy <at> bioneland.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 52075 <at> debbugs.gnu.org
Subject: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2.
Date: Wed, 24 Nov 2021 13:44:30 +0100

Hi Nicolas,

Thanks for reviewing!

Quoting Nicolas Goaziou (2021-11-24 11:29:02)
> Tanguy Le Carrour <tanguy <at> bioneland.org> writes:
> 
> > * gnu/packages/mail.scm (python-notmuch2): New variable.
> 
> Thanks.
> 
> Would it be possible (or appropriate) to inherit from python-notmuch
> instead?

Possible? Yes! Thanks for suggesting.

```
diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 1069aac16c..e1e199c656 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1514,12 +1514,8 @@ (define-public python2-notmuch

 (define-public python-notmuch2
   (package
+    (inherit python-notmuch)
     (name "python-notmuch2")
-    (version (package-version notmuch))
-    ;; The bindings are distributed via the notmuch release tarball.
-    (source (package-source notmuch))
-    (build-system python-build-system)
-    (inputs `(("notmuch" ,notmuch)))
     (propagated-inputs `(("python-cffi" ,python-cffi)))
     (arguments
      `(#:phases
@@ -1528,11 +1524,7 @@ (define-public python-notmuch2
          ;; tree, so chdir into it before building.
          (add-after 'unpack 'enter-python-dir
            (lambda _ (chdir "bindings/python-cffi") #t)))))
-    (home-page (package-home-page notmuch))
     (synopsis "Pythonic bindings for the notmuch mail database using CFFI")
-    (description
-     "This package provides Python bindings to use the Notmuch mail indexing
-and search library.")
     (license license:gpl3+)))
```

Appropriate? I have no idea!

If this version is OK with you, I can submit a V2 of the patch set.

Regards,

-- 
Tanguy

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.