Subject: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2.

From: Nicolas Goaziou <[email-masked]>
Date: Wed, 24 Nov 2021 14:21:29 +0100

Tanguy LE CARROUR <[email-masked]> writes:

>  (define-public python-notmuch2
>    (package
> +    (inherit python-notmuch)
>      (name "python-notmuch2")
> -    (version (package-version notmuch))
> -    ;; The bindings are distributed via the notmuch release tarball.
> -    (source (package-source notmuch))
> -    (build-system python-build-system)
> -    (inputs `(("notmuch" ,notmuch)))
>      (propagated-inputs `(("python-cffi" ,python-cffi)))
>      (arguments
>       `(#:phases
> @@ -1528,11 +1524,7 @@ (define-public python-notmuch2
>           ;; tree, so chdir into it before building.
>           (add-after 'unpack 'enter-python-dir
>             (lambda _ (chdir "bindings/python-cffi") #t)))))

You can drop the trailing #t above.

> -    (home-page (package-home-page notmuch))
>      (synopsis "Pythonic bindings for the notmuch mail database using CFFI")
> -    (description
> -     "This package provides Python bindings to use the Notmuch mail indexing
> -and search library.")
>      (license license:gpl3+)))
> ```
>
> Appropriate? I have no idea!
>
> If this version is OK with you, I can submit a V2 of the patch set.

It looks good, thanks. Please submit a v2 and I'll apply the patch set.

Regards,
-- 
Nicolas Goaziou