From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 04:58:09 2021 Received: (at submit) by debbugs.gnu.org; 24 Nov 2021 09:58:09 +0000 Received: from localhost ([127.0.0.1]:53210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp2X-0000CJ-7I for submit@debbugs.gnu.org; Wed, 24 Nov 2021 04:58:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:56438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp2S-0000C9-Rv for submit@debbugs.gnu.org; Wed, 24 Nov 2021 04:58:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpp2Q-0007Ks-VU for guix-patches@gnu.org; Wed, 24 Nov 2021 04:58:04 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:57691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpp2O-0005Dn-Pn for guix-patches@gnu.org; Wed, 24 Nov 2021 04:58:02 -0500 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPA id E8C48FF815; Wed, 24 Nov 2021 09:57:49 +0000 (UTC) From: Tanguy Le Carrour To: guix-patches@gnu.org Subject: [PATCH 0/4] gnu: alot: Update to 0.10. Date: Wed, 24 Nov 2021 10:57:33 +0100 Message-Id: <20211124095733.20699-1-tanguy@bioneland.org> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=217.70.183.199; envelope-from=tanguy@bioneland.org; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Tanguy Le Carrour X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Guix, In order to update `alot`, I had to change its inputs and add a new variable: python-notmuch2. Thanks for your time and reviews! Tanguy Le Carrour (4): gnu: python-urwidtrees: Update to 1.0.3. gnu: notmuch: Update to 0.34.1. gnu: Add python-notmuch2. gnu: alot: Update to 0.10. gnu/packages/mail.scm | 36 ++++++++++++++++++++++++++++++------ gnu/packages/python-xyz.scm | 7 +++---- 2 files changed, 33 insertions(+), 10 deletions(-) -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 05:00:37 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 10:00:37 +0000 Received: from localhost ([127.0.0.1]:53215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp4v-0000Ha-IZ for submit@debbugs.gnu.org; Wed, 24 Nov 2021 05:00:37 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:39349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp4t-0000HI-8Y for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 05:00:36 -0500 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPA id AB4EAE001B; Wed, 24 Nov 2021 10:00:28 +0000 (UTC) From: Tanguy Le Carrour To: 52075@debbugs.gnu.org Subject: [PATCH 1/4] gnu: python-urwidtrees: Update to 1.0.3. Date: Wed, 24 Nov 2021 11:00:13 +0100 Message-Id: <20211124100016.21905-1-tanguy@bioneland.org> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: Tanguy Le Carrour X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/python-xyz.scm (python-urwidtrees): Update to 1.0.3. [arguments]: Use setuptools. --- gnu/packages/python-xyz.scm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 34d4910194..abb1e78e62 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -8855,7 +8855,7 @@ (define-public python-textdistance (define-public python-urwidtrees (package (name "python-urwidtrees") - (version "1.0.2") + (version "1.0.3") (source (origin (method git-fetch) @@ -8867,11 +8867,10 @@ (define-public python-urwidtrees (file-name (git-file-name name version)) (sha256 (base32 - "1n1kpidvkdnsqyb82vlvk78gmly96kh8351lqxn2pzgwwns6fml2")))) + "1y1vysx7jg0vbrarlsykhf7nmr8fc6k1fva1q3i98xq2m30s6r68")))) (build-system python-build-system) (arguments - '(#:use-setuptools? #f - #:tests? #f)) ; no tests + '(#:tests? #f)) ; no tests (propagated-inputs `(("python-urwid" ,python-urwid))) (home-page "https://github.com/pazz/urwidtrees") (synopsis "Tree widgets for urwid") -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 05:00:46 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 10:00:46 +0000 Received: from localhost ([127.0.0.1]:53220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp50-0000Hx-Oo for submit@debbugs.gnu.org; Wed, 24 Nov 2021 05:00:46 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp4y-0000HQ-LW for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 05:00:41 -0500 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPA id 8D50BE001F; Wed, 24 Nov 2021 10:00:33 +0000 (UTC) From: Tanguy Le Carrour To: 52075@debbugs.gnu.org Subject: [PATCH 2/4] gnu: notmuch: Update to 0.34.1. Date: Wed, 24 Nov 2021 11:00:14 +0100 Message-Id: <20211124100016.21905-2-tanguy@bioneland.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124100016.21905-1-tanguy@bioneland.org> References: <20211124100016.21905-1-tanguy@bioneland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: Tanguy Le Carrour X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/mail.scm (notmuch): Update to 0.34.1. --- gnu/packages/mail.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 0e7134eaf3..7c7e411d5c 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -28,7 +28,7 @@ ;;; Copyright © 2018 Alex Vong ;;; Copyright © 2018 Gábor Boskovits ;;; Copyright © 2018, 2019, 2020, 2021 Ricardo Wurmus -;;; Copyright © 2019, 2020 Tanguy Le Carrour +;;; Copyright © 2019, 2020, 2021 Tanguy Le Carrour ;;; Copyright © 2020 Vincent Legoll ;;; Copyright © 2020 Justus Winter ;;; Copyright © 2020 Eric Brown @@ -1349,14 +1349,14 @@ (define-public notifymuch (define-public notmuch (package (name "notmuch") - (version "0.33.2") + (version "0.34.1") (source (origin (method url-fetch) (uri (string-append "https://notmuchmail.org/releases/notmuch-" version ".tar.xz")) (sha256 (base32 - "1bic1f2va136aygfy53bsgziwiidcpb7qf1v05mlza2jmgv94j14")))) + "05nq64gp8vnrwrl22d60v7ixgdhm9339ajhcdfkq0ll1qiycyyj5")))) (build-system gnu-build-system) (arguments `(#:make-flags -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 05:00:46 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 10:00:46 +0000 Received: from localhost ([127.0.0.1]:53223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp54-0000ID-5X for submit@debbugs.gnu.org; Wed, 24 Nov 2021 05:00:46 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:48899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp4z-0000HY-U9 for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 05:00:42 -0500 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPA id 168D4E0012; Wed, 24 Nov 2021 10:00:35 +0000 (UTC) From: Tanguy Le Carrour To: 52075@debbugs.gnu.org Subject: [PATCH 3/4] gnu: Add python-notmuch2. Date: Wed, 24 Nov 2021 11:00:15 +0100 Message-Id: <20211124100016.21905-3-tanguy@bioneland.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124100016.21905-1-tanguy@bioneland.org> References: <20211124100016.21905-1-tanguy@bioneland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: Tanguy Le Carrour X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/mail.scm (python-notmuch2): New variable. --- gnu/packages/mail.scm | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 7c7e411d5c..9dc38708bf 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -107,6 +107,7 @@ (define-module (gnu packages mail) #:use-module (gnu packages language) #:use-module (gnu packages libcanberra) #:use-module (gnu packages libevent) + #:use-module (gnu packages libffi) #:use-module (gnu packages libidn) #:use-module (gnu packages libunistring) #:use-module (gnu packages libunwind) @@ -1511,6 +1512,29 @@ (define-public python-notmuch (define-public python2-notmuch (package-with-python2 python-notmuch)) +(define-public python-notmuch2 + (package + (name "python-notmuch2") + (version (package-version notmuch)) + ;; The bindings are distributed via the notmuch release tarball. + (source (package-source notmuch)) + (build-system python-build-system) + (inputs `(("notmuch" ,notmuch))) + (propagated-inputs `(("python-cffi" ,python-cffi))) + (arguments + `(#:phases + (modify-phases %standard-phases + ;; This python package lives in a subdirectory of the notmuch source + ;; tree, so chdir into it before building. + (add-after 'unpack 'enter-python-dir + (lambda _ (chdir "bindings/python-cffi") #t))))) + (home-page (package-home-page notmuch)) + (synopsis "Pythonic bindings for the notmuch mail database using CFFI") + (description + "This package provides Python bindings to use the Notmuch mail indexing +and search library.") + (license license:gpl3+))) + (define-public muchsync (package (name "muchsync") -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 05:00:50 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 10:00:50 +0000 Received: from localhost ([127.0.0.1]:53227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp57-0000IU-TW for submit@debbugs.gnu.org; Wed, 24 Nov 2021 05:00:50 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:46229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpp53-0000Hj-Da for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 05:00:45 -0500 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPA id 9A440E000B; Wed, 24 Nov 2021 10:00:39 +0000 (UTC) From: Tanguy Le Carrour To: 52075@debbugs.gnu.org Subject: [PATCH 4/4] gnu: alot: Update to 0.10. Date: Wed, 24 Nov 2021 11:00:16 +0100 Message-Id: <20211124100016.21905-4-tanguy@bioneland.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124100016.21905-1-tanguy@bioneland.org> References: <20211124100016.21905-1-tanguy@bioneland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: Tanguy Le Carrour X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/mail.scm (alot): Update to 0.10. [inputs]: Use python-notmuch2. --- gnu/packages/mail.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 9dc38708bf..1069aac16c 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -1240,7 +1240,7 @@ (define-public mu (define-public alot (package (name "alot") - (version "0.9.1") + (version "0.10") (source (origin (method git-fetch) ;; package author intends on distributing via github rather @@ -1252,7 +1252,7 @@ (define-public alot (file-name (git-file-name name version)) (sha256 (base32 - "0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6")))) + "0awf1phdy1wqm01cy9zmvqlw6c8pvkxm2f9ncjd0cmzxqnmq1dyn")))) (build-system python-build-system) (arguments `(#:phases @@ -1288,7 +1288,7 @@ (define-public alot ("python-urwid" ,python-urwid) ("python-urwidtrees" ,python-urwidtrees) ("python-gpg" ,python-gpg) - ("python-notmuch" ,python-notmuch))) + ("python-notmuch2" ,python-notmuch2))) (home-page "https://github.com/pazz/alot") (synopsis "Command-line MUA using Notmuch") (description -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 05:29:13 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 10:29:13 +0000 Received: from localhost ([127.0.0.1]:53246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mppWa-0000xt-SE for submit@debbugs.gnu.org; Wed, 24 Nov 2021 05:29:12 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:53521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mppWY-0000xe-PF for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 05:29:11 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id D28C324000E; Wed, 24 Nov 2021 10:29:03 +0000 (UTC) From: Nicolas Goaziou To: Tanguy Le Carrour Subject: Re: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2. References: <20211124100016.21905-1-tanguy@bioneland.org> <20211124100016.21905-3-tanguy@bioneland.org> Date: Wed, 24 Nov 2021 11:29:02 +0100 In-Reply-To: <20211124100016.21905-3-tanguy@bioneland.org> (Tanguy Le Carrour's message of "Wed, 24 Nov 2021 11:00:15 +0100") Message-ID: <87fsrlsv81.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: 52075@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Tanguy Le Carrour writes: > * gnu/packages/mail.scm (python-notmuch2): New variable. Thanks. Would it be possible (or appropriate) to inherit from python-notmuch instead? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 07:44:39 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 12:44:39 +0000 Received: from localhost ([127.0.0.1]:53437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mprdf-0006kQ-AL for submit@debbugs.gnu.org; Wed, 24 Nov 2021 07:44:39 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mprdd-0006kA-Nr for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 07:44:38 -0500 Received: (Authenticated sender: tanguy@bioneland.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 224D4E0006; Wed, 24 Nov 2021 12:44:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <20211124100016.21905-1-tanguy@bioneland.org> <20211124100016.21905-3-tanguy@bioneland.org> <87fsrlsv81.fsf@nicolasgoaziou.fr> Subject: Re: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2. From: Tanguy LE CARROUR To: Nicolas Goaziou In-Reply-To: <87fsrlsv81.fsf@nicolasgoaziou.fr> Date: Wed, 24 Nov 2021 13:44:30 +0100 Message-ID: <163775787053.3163.3334445524894222634@localhost> User-Agent: alot/0.10 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: 52075@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Nicolas, Thanks for reviewing! Quoting Nicolas Goaziou (2021-11-24 11:29:02) > Tanguy Le Carrour writes: >=20 > > * gnu/packages/mail.scm (python-notmuch2): New variable. >=20 > Thanks. >=20 > Would it be possible (or appropriate) to inherit from python-notmuch > instead? Possible? Yes! Thanks for suggesting. ``` diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 1069aac16c..e1e199c656 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -1514,12 +1514,8 @@ (define-public python2-notmuch (define-public python-notmuch2 (package + (inherit python-notmuch) (name "python-notmuch2") - (version (package-version notmuch)) - ;; The bindings are distributed via the notmuch release tarball. - (source (package-source notmuch)) - (build-system python-build-system) - (inputs `(("notmuch" ,notmuch))) (propagated-inputs `(("python-cffi" ,python-cffi))) (arguments `(#:phases @@ -1528,11 +1524,7 @@ (define-public python-notmuch2 ;; tree, so chdir into it before building. (add-after 'unpack 'enter-python-dir (lambda _ (chdir "bindings/python-cffi") #t))))) - (home-page (package-home-page notmuch)) (synopsis "Pythonic bindings for the notmuch mail database using CFFI") - (description - "This package provides Python bindings to use the Notmuch mail indexi= ng -and search library.") (license license:gpl3+))) ``` Appropriate? I have no idea! If this version is OK with you, I can submit a V2 of the patch set. Regards, --=20 Tanguy From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 08:21:41 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 13:21:41 +0000 Received: from localhost ([127.0.0.1]:53504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpsDU-0007jv-W8 for submit@debbugs.gnu.org; Wed, 24 Nov 2021 08:21:41 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:51969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpsDR-0007je-3d for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 08:21:39 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 4DCC4FF812; Wed, 24 Nov 2021 13:21:30 +0000 (UTC) From: Nicolas Goaziou To: Tanguy LE CARROUR Subject: Re: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2. References: <20211124100016.21905-1-tanguy@bioneland.org> <20211124100016.21905-3-tanguy@bioneland.org> <87fsrlsv81.fsf@nicolasgoaziou.fr> <163775787053.3163.3334445524894222634@localhost> Date: Wed, 24 Nov 2021 14:21:29 +0100 In-Reply-To: <163775787053.3163.3334445524894222634@localhost> (Tanguy LE CARROUR's message of "Wed, 24 Nov 2021 13:44:30 +0100") Message-ID: <877dcxsn8m.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: 52075@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Tanguy LE CARROUR writes: > (define-public python-notmuch2 > (package > + (inherit python-notmuch) > (name "python-notmuch2") > - (version (package-version notmuch)) > - ;; The bindings are distributed via the notmuch release tarball. > - (source (package-source notmuch)) > - (build-system python-build-system) > - (inputs `(("notmuch" ,notmuch))) > (propagated-inputs `(("python-cffi" ,python-cffi))) > (arguments > `(#:phases > @@ -1528,11 +1524,7 @@ (define-public python-notmuch2 > ;; tree, so chdir into it before building. > (add-after 'unpack 'enter-python-dir > (lambda _ (chdir "bindings/python-cffi") #t))))) You can drop the trailing #t above. > - (home-page (package-home-page notmuch)) > (synopsis "Pythonic bindings for the notmuch mail database using CFFI") > - (description > - "This package provides Python bindings to use the Notmuch mail indexing > -and search library.") > (license license:gpl3+))) > ``` > > Appropriate? I have no idea! > > If this version is OK with you, I can submit a V2 of the patch set. It looks good, thanks. Please submit a v2 and I'll apply the patch set. Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 09:00:58 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 14:00:58 +0000 Received: from localhost ([127.0.0.1]:53537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpspV-0000HR-VE for submit@debbugs.gnu.org; Wed, 24 Nov 2021 09:00:58 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:36657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpspR-0000H1-7p for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 09:00:56 -0500 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay10.mail.gandi.net (Postfix) with ESMTPA id 8C686240015; Wed, 24 Nov 2021 14:00:46 +0000 (UTC) From: Tanguy Le Carrour To: 52075@debbugs.gnu.org Subject: [PATCH v2 1/4] gnu: python-urwidtrees: Update to 1.0.3. Date: Wed, 24 Nov 2021 15:00:31 +0100 Message-Id: <20211124140034.3140-1-tanguy@bioneland.org> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: Tanguy Le Carrour X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/python-xyz.scm (python-urwidtrees): Update to 1.0.3. [arguments]: Use setuptools. --- gnu/packages/python-xyz.scm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 34d4910194..abb1e78e62 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -8855,7 +8855,7 @@ (define-public python-textdistance (define-public python-urwidtrees (package (name "python-urwidtrees") - (version "1.0.2") + (version "1.0.3") (source (origin (method git-fetch) @@ -8867,11 +8867,10 @@ (define-public python-urwidtrees (file-name (git-file-name name version)) (sha256 (base32 - "1n1kpidvkdnsqyb82vlvk78gmly96kh8351lqxn2pzgwwns6fml2")))) + "1y1vysx7jg0vbrarlsykhf7nmr8fc6k1fva1q3i98xq2m30s6r68")))) (build-system python-build-system) (arguments - '(#:use-setuptools? #f - #:tests? #f)) ; no tests + '(#:tests? #f)) ; no tests (propagated-inputs `(("python-urwid" ,python-urwid))) (home-page "https://github.com/pazz/urwidtrees") (synopsis "Tree widgets for urwid") -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 09:01:01 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 14:01:01 +0000 Received: from localhost ([127.0.0.1]:53541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpspZ-0000Hg-6c for submit@debbugs.gnu.org; Wed, 24 Nov 2021 09:01:01 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:51723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpspV-0000HE-Vq for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 09:00:58 -0500 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay10.mail.gandi.net (Postfix) with ESMTPA id 315EA240009; Wed, 24 Nov 2021 14:00:52 +0000 (UTC) From: Tanguy Le Carrour To: 52075@debbugs.gnu.org Subject: [PATCH v2 2/4] gnu: notmuch: Update to 0.34.1. Date: Wed, 24 Nov 2021 15:00:32 +0100 Message-Id: <20211124140034.3140-2-tanguy@bioneland.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124140034.3140-1-tanguy@bioneland.org> References: <20211124140034.3140-1-tanguy@bioneland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: Tanguy Le Carrour X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/mail.scm (notmuch): Update to 0.34.1. --- gnu/packages/mail.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 0e7134eaf3..7c7e411d5c 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -28,7 +28,7 @@ ;;; Copyright © 2018 Alex Vong ;;; Copyright © 2018 Gábor Boskovits ;;; Copyright © 2018, 2019, 2020, 2021 Ricardo Wurmus -;;; Copyright © 2019, 2020 Tanguy Le Carrour +;;; Copyright © 2019, 2020, 2021 Tanguy Le Carrour ;;; Copyright © 2020 Vincent Legoll ;;; Copyright © 2020 Justus Winter ;;; Copyright © 2020 Eric Brown @@ -1349,14 +1349,14 @@ (define-public notifymuch (define-public notmuch (package (name "notmuch") - (version "0.33.2") + (version "0.34.1") (source (origin (method url-fetch) (uri (string-append "https://notmuchmail.org/releases/notmuch-" version ".tar.xz")) (sha256 (base32 - "1bic1f2va136aygfy53bsgziwiidcpb7qf1v05mlza2jmgv94j14")))) + "05nq64gp8vnrwrl22d60v7ixgdhm9339ajhcdfkq0ll1qiycyyj5")))) (build-system gnu-build-system) (arguments `(#:make-flags -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 09:01:05 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 14:01:05 +0000 Received: from localhost ([127.0.0.1]:53546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpspd-0000Ig-Hr for submit@debbugs.gnu.org; Wed, 24 Nov 2021 09:01:05 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:42631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpspY-0000HH-EK for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 09:01:01 -0500 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay10.mail.gandi.net (Postfix) with ESMTPA id 956C1240014; Wed, 24 Nov 2021 14:00:54 +0000 (UTC) From: Tanguy Le Carrour To: 52075@debbugs.gnu.org Subject: [PATCH v2 3/4] gnu: Add python-notmuch2. Date: Wed, 24 Nov 2021 15:00:33 +0100 Message-Id: <20211124140034.3140-3-tanguy@bioneland.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124140034.3140-1-tanguy@bioneland.org> References: <20211124140034.3140-1-tanguy@bioneland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: Tanguy Le Carrour X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/mail.scm (python-notmuch2): New variable. --- gnu/packages/mail.scm | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 7c7e411d5c..454c15e88b 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -107,6 +107,7 @@ (define-module (gnu packages mail) #:use-module (gnu packages language) #:use-module (gnu packages libcanberra) #:use-module (gnu packages libevent) + #:use-module (gnu packages libffi) #:use-module (gnu packages libidn) #:use-module (gnu packages libunistring) #:use-module (gnu packages libunwind) @@ -1511,6 +1512,21 @@ (define-public python-notmuch (define-public python2-notmuch (package-with-python2 python-notmuch)) +(define-public python-notmuch2 + (package + (inherit python-notmuch) + (name "python-notmuch2") + (propagated-inputs `(("python-cffi" ,python-cffi))) + (arguments + `(#:phases + (modify-phases %standard-phases + ;; This python package lives in a subdirectory of the notmuch source + ;; tree, so chdir into it before building. + (add-after 'unpack 'enter-python-dir + (lambda _ (chdir "bindings/python-cffi")))))) + (synopsis "Pythonic bindings for the notmuch mail database using CFFI") + (license license:gpl3+))) + (define-public muchsync (package (name "muchsync") -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 09:01:06 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 14:01:06 +0000 Received: from localhost ([127.0.0.1]:53548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpspd-0000Ii-Nj for submit@debbugs.gnu.org; Wed, 24 Nov 2021 09:01:05 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:39181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpspa-0000HQ-Or for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 09:01:03 -0500 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay10.mail.gandi.net (Postfix) with ESMTPA id EFAFA240013; Wed, 24 Nov 2021 14:00:56 +0000 (UTC) From: Tanguy Le Carrour To: 52075@debbugs.gnu.org Subject: [PATCH v2 4/4] gnu: alot: Update to 0.10. Date: Wed, 24 Nov 2021 15:00:34 +0100 Message-Id: <20211124140034.3140-4-tanguy@bioneland.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124140034.3140-1-tanguy@bioneland.org> References: <20211124140034.3140-1-tanguy@bioneland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: Tanguy Le Carrour X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/mail.scm (alot): Update to 0.10. [inputs]: Use python-notmuch2. --- gnu/packages/mail.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 454c15e88b..b6ca985f53 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -1240,7 +1240,7 @@ (define-public mu (define-public alot (package (name "alot") - (version "0.9.1") + (version "0.10") (source (origin (method git-fetch) ;; package author intends on distributing via github rather @@ -1252,7 +1252,7 @@ (define-public alot (file-name (git-file-name name version)) (sha256 (base32 - "0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6")))) + "0awf1phdy1wqm01cy9zmvqlw6c8pvkxm2f9ncjd0cmzxqnmq1dyn")))) (build-system python-build-system) (arguments `(#:phases @@ -1288,7 +1288,7 @@ (define-public alot ("python-urwid" ,python-urwid) ("python-urwidtrees" ,python-urwidtrees) ("python-gpg" ,python-gpg) - ("python-notmuch" ,python-notmuch))) + ("python-notmuch2" ,python-notmuch2))) (home-page "https://github.com/pazz/alot") (synopsis "Command-line MUA using Notmuch") (description -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 11:54:04 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 16:54:04 +0000 Received: from localhost ([127.0.0.1]:54826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpvX2-0000qR-BI for submit@debbugs.gnu.org; Wed, 24 Nov 2021 11:54:04 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:49378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpvWz-0000pu-RV for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 11:54:03 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpvWt-0006CL-Ux; Wed, 24 Nov 2021 11:53:56 -0500 Date: Wed, 24 Nov 2021 11:53:55 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: Tanguy LE CARROUR Subject: Re: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2. In-Reply-To: <163775787053.3163.3334445524894222634@localhost> Message-ID: References: <20211124100016.21905-1-tanguy@bioneland.org> <20211124100016.21905-3-tanguy@bioneland.org> <87fsrlsv81.fsf@nicolasgoaziou.fr> <163775787053.3163.3334445524894222634@localhost> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52075 Cc: 52075@debbugs.gnu.org, Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 24 Nov 2021, Tanguy LE CARROUR wrote: > Hi Nicolas, > > Thanks for reviewing! > > Quoting Nicolas Goaziou (2021-11-24 11:29:02) >> Tanguy Le Carrour writes: >> >>> * gnu/packages/mail.scm (python-notmuch2): New variable. >> >> Thanks. >> >> Would it be possible (or appropriate) to inherit from python-notmuch >> instead? > > Possible? Yes! Thanks for suggesting. > > Appropriate? I have no idea! As far as appropriate, do you know more about the origin of these "notmuch2" bindings? I know that at some point notmuch upstream re-wrote the binding using CFFI. Is that the origin of this package? If so, then I would be inclined to make this package independent of the existing python-notmuch package. If not, then please ignore this concern. Thoughts? Jack From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 12:12:05 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 17:12:05 +0000 Received: from localhost ([127.0.0.1]:54857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpvoT-0001Iq-GV for submit@debbugs.gnu.org; Wed, 24 Nov 2021 12:12:05 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:52327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpvoO-0001IH-IS for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 12:12:04 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 26ED66000E; Wed, 24 Nov 2021 17:11:52 +0000 (UTC) From: Nicolas Goaziou To: Jack Hill Subject: Re: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2. References: <20211124100016.21905-1-tanguy@bioneland.org> <20211124100016.21905-3-tanguy@bioneland.org> <87fsrlsv81.fsf@nicolasgoaziou.fr> <163775787053.3163.3334445524894222634@localhost> Date: Wed, 24 Nov 2021 18:11:51 +0100 In-Reply-To: (Jack Hill's message of "Wed, 24 Nov 2021 11:53:55 -0500 (EST)") Message-ID: <87y25dqy08.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075 Cc: 52075@debbugs.gnu.org, Tanguy LE CARROUR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Jack Hill writes: > As far as appropriate, do you know more about the origin of these > "notmuch2" bindings? I know that at some point notmuch upstream > re-wrote the binding using CFFI. Is that the origin of this package? > If so, then I would be inclined to make this package independent of > the existing python-notmuch package. If not, then please ignore this > concern. I do not grasp your concern. python-notmuch and python-notmuch2 share most fields. Inheritance prevents duplication, that's all. Why are you inclined to make this new package independant (in the sense of Guix inheritance) of python-notmuch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 12:42:02 2021 Received: (at 52075) by debbugs.gnu.org; 24 Nov 2021 17:42:02 +0000 Received: from localhost ([127.0.0.1]:54891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpwHR-00023s-SA for submit@debbugs.gnu.org; Wed, 24 Nov 2021 12:42:02 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:50012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpwHP-00023N-99 for 52075@debbugs.gnu.org; Wed, 24 Nov 2021 12:42:01 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpwHJ-0007lJ-Aj; Wed, 24 Nov 2021 12:41:53 -0500 Date: Wed, 24 Nov 2021 12:41:53 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: Nicolas Goaziou Subject: Re: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2. In-Reply-To: <87y25dqy08.fsf@nicolasgoaziou.fr> Message-ID: References: <20211124100016.21905-1-tanguy@bioneland.org> <20211124100016.21905-3-tanguy@bioneland.org> <87fsrlsv81.fsf@nicolasgoaziou.fr> <163775787053.3163.3334445524894222634@localhost> <87y25dqy08.fsf@nicolasgoaziou.fr> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52075 Cc: Tanguy LE CARROUR , 52075@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 24 Nov 2021, Nicolas Goaziou wrote: > Hello, > > Jack Hill writes: > >> As far as appropriate, do you know more about the origin of these >> "notmuch2" bindings? I know that at some point notmuch upstream >> re-wrote the binding using CFFI. Is that the origin of this package? >> If so, then I would be inclined to make this package independent of >> the existing python-notmuch package. If not, then please ignore this >> concern. > > I do not grasp your concern. python-notmuch and python-notmuch2 share > most fields. Inheritance prevents duplication, that's all. > > Why are you inclined to make this new package independant (in the sense > of Guix inheritance) of python-notmuch? It is possible that my concern was misplaced. My thinking was that if the two bindings were logically separate projects, rather than being variations on the same code, we should keep them logically separate in Guix even if they are superficially similar. However, it might not be a logically separate project, and that might not be the right way to think about it anyway. I don't have an objection to the version using inheritance. I am still curious in learning about the differences between the two packages if only for my own edification. Hopefully that clarifies, and sorry for adding noise to this review. Best, Jack From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 27 04:15:19 2021 Received: (at 52075-done) by debbugs.gnu.org; 27 Nov 2021 09:15:19 +0000 Received: from localhost ([127.0.0.1]:32917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqtni-0003Eh-UO for submit@debbugs.gnu.org; Sat, 27 Nov 2021 04:15:19 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:57349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqtnf-0003EI-FB for 52075-done@debbugs.gnu.org; Sat, 27 Nov 2021 04:15:16 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 5BCC4E0007; Sat, 27 Nov 2021 09:15:08 +0000 (UTC) From: Nicolas Goaziou To: Jack Hill Subject: Re: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2. References: <20211124100016.21905-1-tanguy@bioneland.org> <20211124100016.21905-3-tanguy@bioneland.org> <87fsrlsv81.fsf@nicolasgoaziou.fr> <163775787053.3163.3334445524894222634@localhost> <87y25dqy08.fsf@nicolasgoaziou.fr> Date: Sat, 27 Nov 2021 10:15:06 +0100 In-Reply-To: (Jack Hill's message of "Wed, 24 Nov 2021 12:41:53 -0500 (EST)") Message-ID: <87r1b2ot7p.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075-done Cc: 52075-done@debbugs.gnu.org, Tanguy LE CARROUR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Jack Hill writes: > It is possible that my concern was misplaced. My thinking was that if > the two bindings were logically separate projects, rather than being > variations on the same code, we should keep them logically separate in > Guix even if they are superficially similar. However, it might not be > a logically separate project, and that might not be the right way to > think about it anyway. They are probably internally separate, but they do share superficial parts. The Guix shortcut is only concerned about the latter, IMO. > I don't have an objection to the version using inheritance. I applied the patch set. Thanks to Tanguy for it, and to you for the feedback! > I am still curious in learning about the differences between the two > packages if only for my own edification. I cannot help here, unfortunately. > Hopefully that clarifies, and sorry for adding noise to this review. No problem! I think you raise an interesting question: does inheritance in Guix imply strong internal dependency between the project inheriting and the one being inherited? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 28 12:32:30 2021 Received: (at 52075-done) by debbugs.gnu.org; 28 Nov 2021 17:32:30 +0000 Received: from localhost ([127.0.0.1]:36317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrO2Q-0007VG-7c for submit@debbugs.gnu.org; Sun, 28 Nov 2021 12:32:30 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:42025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrO2O-0007V1-7j for 52075-done@debbugs.gnu.org; Sun, 28 Nov 2021 12:32:29 -0500 Received: (Authenticated sender: tanguy@bioneland.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 4F1E040005; Sun, 28 Nov 2021 17:32:20 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <20211124100016.21905-1-tanguy@bioneland.org> <20211124100016.21905-3-tanguy@bioneland.org> <87fsrlsv81.fsf@nicolasgoaziou.fr> <163775787053.3163.3334445524894222634@localhost> <87y25dqy08.fsf@nicolasgoaziou.fr> <87r1b2ot7p.fsf@nicolasgoaziou.fr> Subject: Re: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2. From: Tanguy LE CARROUR To: Jack Hill , Nicolas Goaziou In-Reply-To: <87r1b2ot7p.fsf@nicolasgoaziou.fr> Date: Sun, 28 Nov 2021 18:32:20 +0100 Message-ID: <163812074047.4714.14334259292132064805@localhost> User-Agent: alot/0.10 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52075-done Cc: 52075-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, Quoting Nicolas Goaziou (2021-11-27 10:15:06) > Jack Hill writes: > [=E2=80=A6] > > I don't have an objection to the version using inheritance. >=20 > I applied the patch set. Thanks to Tanguy for it, and to you for the > feedback! Thanks! > > I am still curious in learning about the differences between the two > > packages if only for my own edification. >=20 > I cannot help here, unfortunately. `python-notmuch2` contains the new binding that uses CFFI. `python-notmuch` contains the "old" binding which, I guess, will be deprecated at some point. There's not much in the documentation or the mailing list about why they decided to work on the new binding, though. > > Hopefully that clarifies, and sorry for adding noise to this review. >=20 > No problem! I think you raise an interesting question: does inheritance > in Guix imply strong internal dependency between the project inheriting > and the one being inherited? Actually, I have to admit that I have the same reserve about using inheritance. But it's totally fine with me to use it as a mechanism to reduce code duplication. Regards, --=20 Tanguy From unknown Mon Jun 23 04:15:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 27 Dec 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator