GNU bug report logs -
#52053
29.0.50; Nonsensical button "C-x C-f" in scratch buffer
Previous Next
Reported by: Po Lu <luangruo <at> yahoo.com>
Date: Tue, 23 Nov 2021 10:06:02 UTC
Severity: normal
Found in version 29.0.50
Fixed in version 29.1
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
> Date: Thu, 25 Nov 2021 11:07:44 +0000
> From: Gregory Heytings <gregory <at> heytings.org>
> cc: luangruo <at> yahoo.com, larsi <at> gnus.org, 52053 <at> debbugs.gnu.org
>
> > Thanks, but I'd prefer a less obscure way of telling whether this is
> > going into *Help* buffers. Is this really the only way?
>
> I agree with you that it's a bit obscure, and I tried to find a better
> way, but couldn't. Someone else might have a better idea. I think
> another possible way would be to query this-command:
>
> (in-help (or (eq major-mode 'help-mode)
> (and this-command
> (where-is-internal this-command help-map t))))
>
> But somehow I find this even less elegant, and I'm less certain about its
> correctness.
It's definitely not more elegant, agreed.
I do hope a better idea emerges. Anybody?
> > Or maybe the mouse-face etc. should not be put as part of
> > substitute-command-keys, but by the Help mode itself, when the text is
> > already in the *Help* buffer? As we use substitute-command-keys more
> > and more, these problems will probably pop up more and more, so maybe we
> > should rethink whether this part is really something it should do.
> >
>
> With this patch it shouldn't happen outside of Help mode anymore.
Yes, but that's somewhat blunt a weapon, I think. My idea was to
maybe let the caller decide whether this is wanted or not, if we are
going to use substitute-command-keys in way more contexts than it was
originally meant to.
This bug report was last modified 3 years and 176 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.