GNU bug report logs - #52053
29.0.50; Nonsensical button "C-x C-f" in scratch buffer

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: luangruo <at> yahoo.com, larsi <at> gnus.org, 52053 <at> debbugs.gnu.org
Subject: bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer
Date: Thu, 25 Nov 2021 12:59:15 +0200

> Date: Thu, 25 Nov 2021 10:23:38 +0000
> From: Gregory Heytings <gregory <at> heytings.org>
> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 52053 <at> debbugs.gnu.org
> 
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -1105,7 +1105,9 @@ substitute-command-keys
>      ;; itself.
>      (let ((keymap overriding-local-map)
>            (inhibit-modification-hooks t)
> -          (orig-buf (current-buffer)))
> +          (orig-buf (current-buffer))
> +          (in-help (eq (car temp-buffer-window-setup-hook)
> +                       'help-mode-setup)))

Thanks, but I'd prefer a less obscure way of telling whether this
is going into *Help* buffers.  Is this really the only way?  Or maybe
the mouse-face etc. should not be put as part of
substitute-command-keys, but by the Help mode itself, when the text is
already in the *Help* buffer?  As we use substitute-command-keys more
and more, these problems will probably pop up more and more, so maybe
we should rethink whether this part is really something it should do.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.