From unknown Thu Aug 21 23:00:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52018 <52018@debbugs.gnu.org> To: bug#52018 <52018@debbugs.gnu.org> Subject: Status: 28.0.60; Improve documentation for compilation-finish-functions Reply-To: bug#52018 <52018@debbugs.gnu.org> Date: Fri, 22 Aug 2025 06:00:15 +0000 retitle 52018 28.0.60; Improve documentation for compilation-finish-functio= ns reassign 52018 emacs submitter 52018 Thibault Polge severity 52018 minor tag 52018 wontfix thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 05:48:16 2021 Received: (at submit) by debbugs.gnu.org; 21 Nov 2021 10:48:16 +0000 Received: from localhost ([127.0.0.1]:44315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mokON-0003Dx-ON for submit@debbugs.gnu.org; Sun, 21 Nov 2021 05:48:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:51560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mokOM-0003Dp-2a for submit@debbugs.gnu.org; Sun, 21 Nov 2021 05:48:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mokOL-0004Rd-S8 for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 05:48:13 -0500 Received: from 4.mo550.mail-out.ovh.net ([46.105.76.26]:35223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mokOJ-0002yx-V2 for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 05:48:13 -0500 Received: from player799.ha.ovh.net (unknown [10.109.143.220]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 53ED02231E for ; Sun, 21 Nov 2021 10:48:01 +0000 (UTC) Received: from thb.lt (lfbn-idf3-1-453-168.w83-114.abo.wanadoo.fr [83.114.45.168]) (Authenticated sender: thibault@thb.lt) by player799.ha.ovh.net (Postfix) with ESMTPSA id C5FB52478A991 for ; Sun, 21 Nov 2021 10:48:00 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-98R002af71fab5-9b96-4440-b84d-9e1aa55af810, 37E86EF0AD8AE98073E93484345A05460300FD84) smtp.auth=thibault@thb.lt X-OVh-ClientIp: 83.114.45.168 From: Thibault Polge To: bug-gnu-emacs@gnu.org Subject: 28.0.60; Improve documentation for compilation-finish-functions Date: Sun, 21 Nov 2021 11:48:00 +0100 Message-ID: <871r39hjj3.fsf@thb.lt> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Ovh-Tracer-Id: 2585066186778788772 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrgedvgddvudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvufffkfggtgesmhdtreertddttdenucfhrhhomhepvfhhihgsrghulhhtucfrohhlghgvuceothhhihgsrghulhhtsehthhgsrdhltheqnecuggftrfgrthhtvghrnhepieehheeikeejieejhfeffeethfdtteevvdevfeegvdeiieefleegteegtdegvddunecukfhppedtrddtrddtrddtpdekfedruddugedrgeehrdduieeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejleelrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepthhhihgsrghulhhtsehthhgsrdhlthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg Received-SPF: pass client-ip=46.105.76.26; envelope-from=thibault@thb.lt; helo=4.mo550.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain The attached patch links the docstring of `compilation-finish-functions` to the info manual page documenting the string argument those functions receive. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Clarify-documentation-of-compilation-finish-function.patch >From ff48c17796acb3d6a77c893bd2b58bff62d43b03 Mon Sep 17 00:00:00 2001 From: Thibault Polge Date: Sun, 21 Nov 2021 11:41:51 +0100 Subject: [PATCH] Clarify documentation of `compilation-finish-functions` Link to reference on the possible values of the string argument. --- lisp/progmodes/compile.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index ac26f5e934..b71ee410bb 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -114,7 +114,10 @@ compilation-buffer-name-function (defvar compilation-finish-functions nil "Functions to call when a compilation process finishes. Each function is called with two arguments: the compilation buffer, -and a string describing how the process finished.") +and a string describing how the process finished. + +That string is the sentinel's event type string, see info +node `(elisp) Sentinels' for more details.") (defvar compilation-in-progress nil "List of compilation processes now running.") -- 2.33.1 --=-=-= Content-Type: text/plain Best regards, Thibault --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 10:13:39 2021 Received: (at 52018) by debbugs.gnu.org; 21 Nov 2021 15:13:39 +0000 Received: from localhost ([127.0.0.1]:45833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mooXC-0006XV-OV for submit@debbugs.gnu.org; Sun, 21 Nov 2021 10:13:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mooXB-0006XI-Hs for 52018@debbugs.gnu.org; Sun, 21 Nov 2021 10:13:37 -0500 Received: from [2001:470:142:3::e] (port=53000 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mooX5-0001AW-HD; Sun, 21 Nov 2021 10:13:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=csyllksKlxph6pjh1cp2omUL/stDacalj3fhUSCk3BE=; b=hw6gEpZhpxQc AHz2m0P4W8F3Yw7mar/W2pMz/OPwz767X0iNxMC7I7gsJl0yEwJfmqvcrf4Typ2yiSZGB+qNKGzPz cJtPJoz6U1AD+ppzf/w30cvYqOeMBejfgOZs/MYO/9szrck+4wLpAsyfzasR3vlZeeD9I8ihmoE20 0qwqr1tbWNlUUEAnE27UFSUb9+rkpM24WiemSGt6lwUYJ+m94MhfptG/2b1qz3Z5RCKFYKtBP2Q1x 6yBkbBRHevz9S6zzewzu6yMEGbPMRtFlv3mOknkstsdam9yJtl6/rcyBJcYeUuhqW0BYCwc0Dj20G veLW/oFKWpd3rG5xGf7CSw==; Received: from [87.69.77.57] (port=1535 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mooX5-0006OU-6y; Sun, 21 Nov 2021 10:13:31 -0500 Date: Sun, 21 Nov 2021 17:13:35 +0200 Message-Id: <83sfvpr17k.fsf@gnu.org> From: Eli Zaretskii To: Thibault Polge In-Reply-To: <871r39hjj3.fsf@thb.lt> (message from Thibault Polge on Sun, 21 Nov 2021 11:48:00 +0100) Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions References: <871r39hjj3.fsf@thb.lt> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Thibault Polge > Date: Sun, 21 Nov 2021 11:48:00 +0100 > > (defvar compilation-finish-functions nil > "Functions to call when a compilation process finishes. > Each function is called with two arguments: the compilation buffer, > -and a string describing how the process finished.") > +and a string describing how the process finished. > + > +That string is the sentinel's event type string, see info > +node `(elisp) Sentinels' for more details.") But this is not entirely accurate, is it? The code actually does (let ((out-string (format ":%s [%s]" process-status (cdr status))) (msg (format "%s %s" mode-name (replace-regexp-in-string "\n?$" "" (car status))))) [...] (run-hook-with-args 'compilation-finish-functions cur-buffer msg))) So 'msg' is not just the process status , AFAIU. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 14:09:06 2021 Received: (at 52018) by debbugs.gnu.org; 21 Nov 2021 19:09:06 +0000 Received: from localhost ([127.0.0.1]:46045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mosD4-00046y-66 for submit@debbugs.gnu.org; Sun, 21 Nov 2021 14:09:06 -0500 Received: from 2.mo575.mail-out.ovh.net ([46.105.52.162]:39003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mosD0-00046Z-UD for 52018@debbugs.gnu.org; Sun, 21 Nov 2021 14:09:04 -0500 Received: from player763.ha.ovh.net (unknown [10.110.171.148]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 98A46227D6 for <52018@debbugs.gnu.org>; Sun, 21 Nov 2021 19:09:01 +0000 (UTC) Received: from thb.lt (lfbn-idf3-1-453-168.w83-114.abo.wanadoo.fr [83.114.45.168]) (Authenticated sender: thibault@thb.lt) by player763.ha.ovh.net (Postfix) with ESMTPSA id DD1D72484640F; Sun, 21 Nov 2021 19:08:59 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-105G0067fda3a39-2eb7-447f-a11c-ef50434ef1c6, 43582B99CDFB24B69BBBFB8E6FA79B8263DCE2E8) smtp.auth=thibault@thb.lt X-OVh-ClientIp: 83.114.45.168 From: Thibault Polge To: Eli Zaretskii Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions In-Reply-To: <83sfvpr17k.fsf@gnu.org> References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> Date: Sun, 21 Nov 2021 20:08:56 +0100 Message-ID: <87wnl1gwc7.fsf@thb.lt> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 11046485461101822796 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrgedvgdduvdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepvfhhihgsrghulhhtucfrohhlghgvuceothhhihgsrghulhhtsehthhgsrdhltheqnecuggftrfgrthhtvghrnhepfeduuddvvdduudduvddvjeefhfelgfeutddvgfejhfegteeihefhiefgveffvdffnecukfhppedtrddtrddtrddtpdekfedruddugedrgeehrdduieeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejieefrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepthhhihgsrghulhhtsehthhgsrdhlthdprhgtphhtthhopeehvddtudekseguvggssghughhsrdhgnhhurdhorhhg X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > But this is not entirely accurate, is it? I've done a quick test, and this seems accurate. As I understand it, the code you quoted: > (let ((out-string (format ":%s [%s]" process-status (cdr status))) > (msg (format "%s %s" mode-name > (replace-regexp-in-string "\n?$" "" > (car status))))) comes from a let block that happens in the context of: (setq mode-line-process [...] That is used to, IIUC, decorate the mode line with info about the compilation result. This setq, and the let it wraps, ends just before: (force-mode-line-update) [...] (run-hook-with-args 'compilation-finish-functions cur-buffer msg))) So the msg that compilation-handle-exit receives is passed, unmodified, to all 'compilation-finish-functions`. Best regards, Thibault From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 14:26:03 2021 Received: (at 52018) by debbugs.gnu.org; 21 Nov 2021 19:26:03 +0000 Received: from localhost ([127.0.0.1]:46055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mosTS-0004Y1-Pc for submit@debbugs.gnu.org; Sun, 21 Nov 2021 14:26:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mosTR-0004XY-Hq for 52018@debbugs.gnu.org; Sun, 21 Nov 2021 14:26:01 -0500 Received: from [2001:470:142:3::e] (port=60372 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mosTK-0003x1-Ko; Sun, 21 Nov 2021 14:25:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aoNw6D5lYP9sI258bT6KiPj91ESx42w+iLObPcsPctY=; b=gBKzdtuPSgBV 5fvKe8ix1g2AbfMi3RlwCLltVLAMlzyIrmFdxKhXBLFtncM66kjQaZLQJSLNrh4g+qTMlY0vgtQV3 ji/e2ziLaKpi+OGO/vYE4k6ltZ7RWx8Me67+2QX4ZNeLt2DACPIZQqitFvr6hwJpRPT+OCOAjFRWx 8D+i6ZdgaH7GHGCKPoJ+P1a9oLScOjHlXRlr+mlzb93db/VeVQetxnRav1GWhfVS0wssQhOnTLSiQ KhA23cUC8v35IoU54RFRnCa6HWVvvy9nQ9kxFf8mMzG8KdLR5+Txtu16BINY/lCKFVTOXQDgy/r22 yhMxUgEp8YfHaj2Iko0jBA==; Received: from [87.69.77.57] (port=1151 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mosTJ-0003uy-VV; Sun, 21 Nov 2021 14:25:54 -0500 Date: Sun, 21 Nov 2021 21:25:59 +0200 Message-Id: <83ilwlqpiw.fsf@gnu.org> From: Eli Zaretskii To: Thibault Polge In-Reply-To: <87wnl1gwc7.fsf@thb.lt> (message from Thibault Polge on Sun, 21 Nov 2021 20:08:56 +0100) Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Thibault Polge > Cc: 52018@debbugs.gnu.org > Date: Sun, 21 Nov 2021 20:08:56 +0100 > > (force-mode-line-update) > [...] > (run-hook-with-args 'compilation-finish-functions cur-buffer msg))) > > So the msg that compilation-handle-exit receives is passed, unmodified, > to all 'compilation-finish-functions`. Maybe so, but I'm looking at the calls of compilation-handle-exit, and the callers do all kinds of transformations with the original status, so I think documenting what happens to be more-or-less correct now is fragile. Why do you think this addition is of such great importance to have it spelled out in the doc string? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 14:44:55 2021 Received: (at 52018) by debbugs.gnu.org; 21 Nov 2021 19:44:55 +0000 Received: from localhost ([127.0.0.1]:46074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moslj-00051Z-HE for submit@debbugs.gnu.org; Sun, 21 Nov 2021 14:44:55 -0500 Received: from 14.mo581.mail-out.ovh.net ([178.33.251.19]:36995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moslh-00051P-GP for 52018@debbugs.gnu.org; Sun, 21 Nov 2021 14:44:54 -0500 Received: from player788.ha.ovh.net (unknown [10.109.146.143]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id E021122090 for <52018@debbugs.gnu.org>; Sun, 21 Nov 2021 19:44:51 +0000 (UTC) Received: from thb.lt (lfbn-idf3-1-453-168.w83-114.abo.wanadoo.fr [83.114.45.168]) (Authenticated sender: thibault@thb.lt) by player788.ha.ovh.net (Postfix) with ESMTPSA id A96742480A2A4; Sun, 21 Nov 2021 19:44:49 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-105G0069e68a697-7d8e-4d73-ad5e-9f7f07a868e6, 43582B99CDFB24B69BBBFB8E6FA79B8263DCE2E8) smtp.auth=thibault@thb.lt X-OVh-ClientIp: 83.114.45.168 From: Thibault Polge To: Eli Zaretskii Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions In-Reply-To: <83ilwlqpiw.fsf@gnu.org> References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> Date: Sun, 21 Nov 2021 20:44:46 +0100 Message-ID: <87sfvpguoh.fsf@thb.lt> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 11651656662844162892 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrgedvgddufedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufgjfhffkfggtgfgsehtqhertddttdejnecuhfhrohhmpefvhhhisggruhhlthcurfholhhgvgcuoehthhhisggruhhlthesthhhsgdrlhhtqeenucggtffrrghtthgvrhhnpeehfeffffffveelieeukefhgeeuueetuedvudeljedujeefuddvveeftdejtdejfeenucfkpheptddrtddrtddrtddpkeefrdduudegrdeghedrudeikeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepphhlrgihvghrjeekkedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehthhhisggruhhlthesthhhsgdrlhhtpdhrtghpthhtohephedvtddukeesuggvsggsuhhgshdrghhnuhdrohhrgh X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Maybe so, but I'm looking at the calls of compilation-handle-exit, and > the callers do all kinds of transformations with the original status, > so I think documenting what happens to be more-or-less correct now is > fragile. I assumed this interface was reasonably stable, I may be wrong. > Why do you think this addition is of such great importance to have it > spelled out in the doc string? All the docstring currently states about that argument is that it's =E2=80= =9Ca string describing how the process finished=E2=80=9D, which requires users to determine its possible values through trial and error, or by digging into the code. I assumed it would be nicer (but not of =E2=80=9Cgreat importance=E2=80=9D) to just document it a bit further. Best regards, From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 14:53:19 2021 Received: (at 52018) by debbugs.gnu.org; 21 Nov 2021 19:53:19 +0000 Received: from localhost ([127.0.0.1]:46087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mostr-0005Gy-8K for submit@debbugs.gnu.org; Sun, 21 Nov 2021 14:53:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mostp-0005Gl-4J for 52018@debbugs.gnu.org; Sun, 21 Nov 2021 14:53:17 -0500 Received: from [2001:470:142:3::e] (port=33002 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mostj-0000jm-8b; Sun, 21 Nov 2021 14:53:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tNxUXHQFgSvhQcyLqI3sf9blhetGMpsihjMRZ558PmM=; b=B5TU49c/bk5Fs8ASS0Fb Uj0+GlP95y2sR4oYXfGqKZXaiMNAUtJVgEGIPKK9MMvsGgJkXmfczKXQguhFyQiAdOHQo6Y7du7nf PjniHGNWaRhiitMtvcW3I3C/C7O6vBoS9DwSNc9D+sE4NUroADJLMQiiHlJFQOLTB7Ydsuqrqac2P O1R9dtjnYGvUX6WHWVneWHRyYxS5oq7dK0twQEfxVqHzZ5GXM7G4Pz+0UPJnXm37/+k8ys3nO/BXI HvDxN/mhXeCCg/+PcrJUIdSYUvSVTtzW84R2h+QOP8Wf9iQKCOpnrx2R8XWPBVTn9dN4PbajAvvye 0UiD07EWioNdYA==; Received: from [87.69.77.57] (port=2813 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mosti-0004oj-PR; Sun, 21 Nov 2021 14:53:11 -0500 Date: Sun, 21 Nov 2021 21:53:15 +0200 Message-Id: <83ee79qo9g.fsf@gnu.org> From: Eli Zaretskii To: Thibault Polge In-Reply-To: <87sfvpguoh.fsf@thb.lt> (message from Thibault Polge on Sun, 21 Nov 2021 20:44:46 +0100) Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Thibault Polge > Cc: 52018@debbugs.gnu.org > Date: Sun, 21 Nov 2021 20:44:46 +0100 > > > Why do you think this addition is of such great importance to have it > > spelled out in the doc string? > > All the docstring currently states about that argument is that it's “a > string describing how the process finished”, which requires users to > determine its possible values through trial and error, or by digging > into the code. I'm asking why do you think they should care. If they want the process exit status, they can have it, can't they? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 15:00:27 2021 Received: (at 52018) by debbugs.gnu.org; 21 Nov 2021 20:00:27 +0000 Received: from localhost ([127.0.0.1]:46095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mot0l-0005T2-7c for submit@debbugs.gnu.org; Sun, 21 Nov 2021 15:00:27 -0500 Received: from 9.mo550.mail-out.ovh.net ([178.32.108.172]:54245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mot0i-0005Sr-18 for 52018@debbugs.gnu.org; Sun, 21 Nov 2021 15:00:25 -0500 Received: from player774.ha.ovh.net (unknown [10.109.143.175]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 6B0FF2244E for <52018@debbugs.gnu.org>; Sun, 21 Nov 2021 20:00:22 +0000 (UTC) Received: from thb.lt (lfbn-idf3-1-453-168.w83-114.abo.wanadoo.fr [83.114.45.168]) (Authenticated sender: thibault@thb.lt) by player774.ha.ovh.net (Postfix) with ESMTPSA id C4EA924985B02; Sun, 21 Nov 2021 20:00:20 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-100R0036e1e968b-b47f-43ce-8394-a7a7070c80b8, 43582B99CDFB24B69BBBFB8E6FA79B8263DCE2E8) smtp.auth=thibault@thb.lt X-OVh-ClientIp: 83.114.45.168 From: Thibault Polge To: Eli Zaretskii Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions In-Reply-To: <83ee79qo9g.fsf@gnu.org> References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> Date: Sun, 21 Nov 2021 21:00:20 +0100 Message-ID: <87pmqtgtyj.fsf@thb.lt> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 11913709866058498892 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrgedvgddufeehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepvfhhihgsrghulhhtucfrohhlghgvuceothhhihgsrghulhhtsehthhgsrdhltheqnecuggftrfgrthhtvghrnhepfeduuddvvdduudduvddvjeefhfelgfeutddvgfejhfegteeihefhiefgveffvdffnecukfhppedtrddtrddtrddtpdekfedruddugedrgeehrdduieeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejjeegrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepthhhihgsrghulhhtsehthhgsrdhlthdprhgtphhtthhopeehvddtudekseguvggssghughhsrdhgnhhurdhorhhg X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I'm asking why do you think they should care. If they want the > process exit status, they can have it, can't they? I honestly don't know how to do that, but if they can, I guess all is well. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 15:11:14 2021 Received: (at 52018) by debbugs.gnu.org; 21 Nov 2021 20:11:14 +0000 Received: from localhost ([127.0.0.1]:46101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1motBC-0005jd-6o for submit@debbugs.gnu.org; Sun, 21 Nov 2021 15:11:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1motBA-0005jM-Au for 52018@debbugs.gnu.org; Sun, 21 Nov 2021 15:11:13 -0500 Received: from [2001:470:142:3::e] (port=33526 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1motB4-0003Jp-Gk; Sun, 21 Nov 2021 15:11:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yVL3n7kLe2PcphZ+/YLfL4YdodGVZw3R33yZWWGMrZg=; b=k/LVoF0cMg3p mRC2NLBaBe7zaguGEHEYfELpC02FSB1AyN2pWlOiz52awo67ukTEMc4VFwidizHSoloasIFA3TIk/ X5payrXLVm+mTm1/j9OyJ74xKXk6JCguubsTQYjdLDyTtbxFFHsaqAgEs301UYKA/a6lLwNsHCX97 T5cHkN2oNQLEiIvM8iPeR3SpIBhqInsmuV5vEJcohcIxXwTs7SWdlDWIZ+q64sAJDUTKac70Qmpq1 RjJFhisqoPFOweUZfdgjzCbHH/82j82/XThkW+xzchjLKV9bihou/sa45Xuqt3EylOGrmx26ItIRo nOkiFDbrnp/JstfscluSig==; Received: from [87.69.77.57] (port=3906 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1motB4-0002Uv-6M; Sun, 21 Nov 2021 15:11:06 -0500 Date: Sun, 21 Nov 2021 22:11:12 +0200 Message-Id: <83bl2dqnfj.fsf@gnu.org> From: Eli Zaretskii To: Thibault Polge In-Reply-To: <87pmqtgtyj.fsf@thb.lt> (message from Thibault Polge on Sun, 21 Nov 2021 21:00:20 +0100) Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Thibault Polge > Cc: 52018@debbugs.gnu.org > Date: Sun, 21 Nov 2021 21:00:20 +0100 > > > I'm asking why do you think they should care. If they want the > > process exit status, they can have it, can't they? > > I honestly don't know how to do that, but if they can, I guess all is well. The function is called with the compilation buffer, right? And the compilation process runs in that buffer, right? So the function can call get-buffer-process, and then access the exit status via process-exit-status. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 15:20:35 2021 Received: (at 52018) by debbugs.gnu.org; 21 Nov 2021 20:20:35 +0000 Received: from localhost ([127.0.0.1]:46116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1motKF-0005yu-MK for submit@debbugs.gnu.org; Sun, 21 Nov 2021 15:20:35 -0500 Received: from 7.mo560.mail-out.ovh.net ([188.165.48.182]:42389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1motKC-0005yk-J7 for 52018@debbugs.gnu.org; Sun, 21 Nov 2021 15:20:33 -0500 Received: from player699.ha.ovh.net (unknown [10.110.115.215]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id EA8842209D for <52018@debbugs.gnu.org>; Sun, 21 Nov 2021 20:20:30 +0000 (UTC) Received: from thb.lt (lfbn-idf3-1-453-168.w83-114.abo.wanadoo.fr [83.114.45.168]) (Authenticated sender: thibault@thb.lt) by player699.ha.ovh.net (Postfix) with ESMTPSA id 421D2247B4963; Sun, 21 Nov 2021 20:20:29 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-98R002c2a25a63-74a3-4965-8b10-0712490c67ea, 37E86EF0AD8AE98073E93484345A05460300FD84) smtp.auth=thibault@thb.lt X-OVh-ClientIp: 83.114.45.168 From: Thibault Polge To: Eli Zaretskii Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions In-Reply-To: <83bl2dqnfj.fsf@gnu.org> References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> <83bl2dqnfj.fsf@gnu.org> Date: Sun, 21 Nov 2021 21:20:28 +0100 Message-ID: <87mtlxgt0z.fsf@thb.lt> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 12253731640208376652 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrgedvgddufeelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepvfhhihgsrghulhhtucfrohhlghgvuceothhhihgsrghulhhtsehthhgsrdhltheqnecuggftrfgrthhtvghrnhepfeduuddvvdduudduvddvjeefhfelgfeutddvgfejhfegteeihefhiefgveffvdffnecukfhppedtrddtrddtrddtpdekfedruddugedrgeehrdduieeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrheileelrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepthhhihgsrghulhhtsehthhgsrdhlthdprhgtphhtthhopeehvddtudekseguvggssghughhsrdhgnhhurdhorhhg X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > The function is called with the compilation buffer, right? And the > compilation process runs in that buffer, right? So the function can > call get-buffer-process, and then access the exit status via > process-exit-status. I actually tried that, but the docstring for get-buffer-process says the process must be live. The following attempt fails: (add-hook 'compilation-finish-functions (defun my-compilation-finish-function (buffer _) (let ((process (get-buffer-process buffer))) (message "Is there a buffer? %s" (bufferp buffer)) (message "Is there a process? %s" (not (null process))) (message "Its status is: %s" (process-exit-status process))))) Fails with: Is there a buffer? t Is there a process? nil error in process sentinel: message: Wrong type argument: processp, nil error in process sentinel: Wrong type argument: processp, nil From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 15:29:49 2021 Received: (at 52018) by debbugs.gnu.org; 21 Nov 2021 20:29:49 +0000 Received: from localhost ([127.0.0.1]:46125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1motTA-0006Cy-SC for submit@debbugs.gnu.org; Sun, 21 Nov 2021 15:29:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1motT8-0006Cj-UF for 52018@debbugs.gnu.org; Sun, 21 Nov 2021 15:29:47 -0500 Received: from [2001:470:142:3::e] (port=34176 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1motSz-0006Zf-Sk; Sun, 21 Nov 2021 15:29:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RMnsk4glxygsnXAMje0hu1u1THjS/VLWFenUg8jC6Oo=; b=Cu5otBGa2AWt D1KaSTwVZ9owdehUAmBNioPnQRwcWShvWRUK2QrR73qz5f33jUYO2s4Vw1+SbrtWvziGOH/pi1luF 7IC/Yx7wugJTAZW0BC4ld9ArJ1N3FX1bdnXC6BDBY/YogHgjwhSQURSrtZv4moWqyMJjlUdzv2NZu RQ8BnFGv9H+NV2Lob8vNLE2EZIT77/Nj5/gfX9qpCLlD6ZSpUMArFfNKR9QANW5OLhKqR5fU7fKTL if2luVqvxPz3S/5OqUYTskIXL4xYxjxQim4vChsQ62W/zbgxp0g1WaxV+Y0Ak8gn27y4MAS7JjiZq H9/6xElL05cnh244pv2Vjg==; Received: from [87.69.77.57] (port=1064 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1motSz-0003XM-1B; Sun, 21 Nov 2021 15:29:37 -0500 Date: Sun, 21 Nov 2021 22:29:43 +0200 Message-Id: <837dd1qmko.fsf@gnu.org> From: Eli Zaretskii To: Thibault Polge In-Reply-To: <87mtlxgt0z.fsf@thb.lt> (message from Thibault Polge on Sun, 21 Nov 2021 21:20:28 +0100) Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> <83bl2dqnfj.fsf@gnu.org> <87mtlxgt0z.fsf@thb.lt> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Thibault Polge > Cc: 52018@debbugs.gnu.org > Date: Sun, 21 Nov 2021 21:20:28 +0100 > > > The function is called with the compilation buffer, right? And the > > compilation process runs in that buffer, right? So the function can > > call get-buffer-process, and then access the exit status via > > process-exit-status. > > I actually tried that, but the docstring for get-buffer-process says the > process must be live. The following attempt fails: OK, then the info is also on the mode line and can be taken from there. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 22 04:13:01 2021 Received: (at 52018) by debbugs.gnu.org; 22 Nov 2021 09:13:01 +0000 Received: from localhost ([127.0.0.1]:46875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mp5Nk-0007Az-Vl for submit@debbugs.gnu.org; Mon, 22 Nov 2021 04:13:01 -0500 Received: from 16.mo582.mail-out.ovh.net ([87.98.139.208]:48577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mp5Nj-0007Ao-Cx for 52018@debbugs.gnu.org; Mon, 22 Nov 2021 04:13:00 -0500 Received: from player761.ha.ovh.net (unknown [10.110.103.112]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id 28EC423326 for <52018@debbugs.gnu.org>; Mon, 22 Nov 2021 09:12:51 +0000 (UTC) Received: from thb.lt (lfbn-idf3-1-453-168.w83-114.abo.wanadoo.fr [83.114.45.168]) (Authenticated sender: thibault@thb.lt) by player761.ha.ovh.net (Postfix) with ESMTPSA id 566FA24869833; Mon, 22 Nov 2021 09:12:50 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-102R0047c608f47-6c9b-42d7-9135-c7afdab266af, F844E0A0A03428B13BA98E99ACB853C38F525B7E) smtp.auth=thibault@thb.lt X-OVh-ClientIp: 83.114.45.168 From: Thibault Polge To: Eli Zaretskii Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions In-Reply-To: <837dd1qmko.fsf@gnu.org> References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> <83bl2dqnfj.fsf@gnu.org> <87mtlxgt0z.fsf@thb.lt> <837dd1qmko.fsf@gnu.org> Date: Mon, 22 Nov 2021 10:12:46 +0100 Message-ID: <87o86cr1td.fsf@thb.lt> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 6850819462222431052 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrgeeggddtudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefvhhhisggruhhlthcurfholhhgvgcuoehthhhisggruhhlthesthhhsgdrlhhtqeenucggtffrrghtthgvrhhnpeefudduvddvudduuddvvdejfefhlefguedtvdfgjefhgeetieehhfeigfevffdvffenucfkpheptddrtddrtddrtddpkeefrdduudegrdeghedrudeikeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepphhlrgihvghrjeeiuddrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehthhhisggruhhlthesthhhsgdrlhhtpdhrtghpthhtohephedvtddukeesuggvsggsuhhgshdrghhnuhdrohhrgh X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > OK, then the info is also on the mode line and can be taken from > there. I'm not sure I follow you. Are you suggesting functions in `compilation-finish-functions` should scrape the mode line to get the compilation process' exit status, instead of just using the string argument they receive? From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 22 11:56:28 2021 Received: (at 52018) by debbugs.gnu.org; 22 Nov 2021 16:56:28 +0000 Received: from localhost ([127.0.0.1]:48952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpCcG-0003ou-7M for submit@debbugs.gnu.org; Mon, 22 Nov 2021 11:56:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpCcD-0003oh-PM for 52018@debbugs.gnu.org; Mon, 22 Nov 2021 11:56:26 -0500 Received: from [2001:470:142:3::e] (port=40778 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpCc7-0000Jj-P7; Mon, 22 Nov 2021 11:56:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=V1Q9yxOcRA4jLvcCryTfvbSwb7lz/O3s1y4LO58F/5Y=; b=UmV/L80S2n/9 b05BSDSnwmWjD+ud6zTQpU5WxRDeM4gefUlZakU0cfgBHzAxONGTaENJNZz/99vHYBtYs4PAv+FhJ tlBkRZfIafrumBrkwCXVWMCq3u3ELORKoDjrEl4Mb5FCKE8YF8xjShEAh64GwfUzObXeFE1VGknGF K6YRI0MG01GSvqEUEqLmRAdXBguTf4EFoyrCM9DycvV2sctZ+ciq/aWFF7pbY9eV2ULMMj3+s8JqC ZuipWMOGfro3DKS2lh2U+Yy9OJkflJN7j5UujrhJ1qx2RGfYXqcIRrmSLhhBVE1/TRaak1vSZQdBJ cOSrfqfE6GhpjuHrAIyx2Q==; Received: from [87.69.77.57] (port=4258 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpCc7-0007lZ-5t; Mon, 22 Nov 2021 11:56:19 -0500 Date: Mon, 22 Nov 2021 18:56:26 +0200 Message-Id: <83r1b8p1s5.fsf@gnu.org> From: Eli Zaretskii To: Thibault Polge In-Reply-To: <87o86cr1td.fsf@thb.lt> (message from Thibault Polge on Mon, 22 Nov 2021 10:12:46 +0100) Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> <83bl2dqnfj.fsf@gnu.org> <87mtlxgt0z.fsf@thb.lt> <837dd1qmko.fsf@gnu.org> <87o86cr1td.fsf@thb.lt> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Thibault Polge > Cc: 52018@debbugs.gnu.org > Date: Mon, 22 Nov 2021 10:12:46 +0100 > > > OK, then the info is also on the mode line and can be taken from > > there. > > I'm not sure I follow you. Are you suggesting functions in > `compilation-finish-functions` should scrape the mode line to get the > compilation process' exit status, instead of just using the string > argument they receive? No need to scrape the mode line: the info is readily available in mode-line-process. If the purpose is to provide the exit status to the function, we need to take care to pass it without any massaging. We don't make a point of doing that now, so I'd prefer not to document this in such certain terms, as people will then complain that it isn't 100% accurate. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 23 04:27:39 2021 Received: (at 52018) by debbugs.gnu.org; 23 Nov 2021 09:27:40 +0000 Received: from localhost ([127.0.0.1]:49994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpS5R-0007g1-19 for submit@debbugs.gnu.org; Tue, 23 Nov 2021 04:27:39 -0500 Received: from 10.mo584.mail-out.ovh.net ([188.165.33.109]:53425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpS5K-0007em-UO for 52018@debbugs.gnu.org; Tue, 23 Nov 2021 04:27:33 -0500 Received: from player693.ha.ovh.net (unknown [10.110.103.115]) by mo584.mail-out.ovh.net (Postfix) with ESMTP id 5213A2306B for <52018@debbugs.gnu.org>; Tue, 23 Nov 2021 09:27:29 +0000 (UTC) Received: from thb.lt (lfbn-idf3-1-453-168.w83-114.abo.wanadoo.fr [83.114.45.168]) (Authenticated sender: thibault@thb.lt) by player693.ha.ovh.net (Postfix) with ESMTPSA id 9BFED2485E2BA; Tue, 23 Nov 2021 09:27:27 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-106R006403051a3-306a-4e48-a2b0-ce1dea140b0a, DD7FD58FD33E20ABFCD08D60E7D4608D270CFB86) smtp.auth=thibault@thb.lt X-OVh-ClientIp: 83.114.45.168 From: Thibault Polge To: Eli Zaretskii Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions In-Reply-To: <83r1b8p1s5.fsf@gnu.org> References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> <83bl2dqnfj.fsf@gnu.org> <87mtlxgt0z.fsf@thb.lt> <837dd1qmko.fsf@gnu.org> <87o86cr1td.fsf@thb.lt> <83r1b8p1s5.fsf@gnu.org> Date: Tue, 23 Nov 2021 10:26:50 +0100 Message-ID: <877dczql2d.fsf@thb.lt> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 12970366928041460556 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrgeeigddtgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefvhhhisggruhhlthcurfholhhgvgcuoehthhhisggruhhlthesthhhsgdrlhhtqeenucggtffrrghtthgvrhhnpeefudduvddvudduuddvvdejfefhlefguedtvdfgjefhgeetieehhfeigfevffdvffenucfkpheptddrtddrtddrtddpkeefrdduudegrdeghedrudeikeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepphhlrgihvghrieelfedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehthhhisggruhhlthesthhhsgdrlhhtpdhrtghpthhtohephedvtddukeesuggvsggsuhhgshdrghhnuhdrohhrgh X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > If the purpose is to provide the exit status to the function, we need > to take care to pass it without any massaging. We don't make a point > of doing that now, so I'd prefer not to document this in such certain > terms, as people will then complain that it isn't 100% accurate. Thanks for the clarification. This makes sense, I'm just not sure how to act on this. Would you rather drop this change or modify it to use more cautious language? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 23 07:47:00 2021 Received: (at 52018) by debbugs.gnu.org; 23 Nov 2021 12:47:00 +0000 Received: from localhost ([127.0.0.1]:50218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpVCO-00082H-8f for submit@debbugs.gnu.org; Tue, 23 Nov 2021 07:47:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpVCN-000825-Fw for 52018@debbugs.gnu.org; Tue, 23 Nov 2021 07:46:59 -0500 Received: from [2001:470:142:3::e] (port=43628 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpVCH-0002Qx-9V; Tue, 23 Nov 2021 07:46:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=t4RVghxApayXNqlstw9W+iFiFyXM+Q5B7rs2UBzblNc=; b=Ilwwp0GNdEKM RJtF6dPwvxgr44N+GLcQtMs2Sj3psaAmMqUJEKDedKVbTEfLXGfNUnIHziBrauWJ5UBrKiyimFO6C xrtDhn+HJJIXHJjKnSDNgtfLUqmMV3eS+LTMVsO0BkEfju5I0kXMdHE2CeHG0nWzRONDf+STuYyo+ 7gONy7IatRgt0ozHJAi0Gjk/W3dipWoXLaMz+zXTIHdUGLUydOQrWNMBpO7Ul+L6euKACcl8SQ3Ia J5ouI6zZulla6EQTE8RDWf3YZr8UbYXzrlYpJW9p07TJrEFu4AVsuAPEyk/JxZq69xmKgYRiYYsQ5 25ssaREXyYXc1pBZIct66A==; Received: from [87.69.77.57] (port=1466 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpVCG-0001H6-Qg; Tue, 23 Nov 2021 07:46:53 -0500 Date: Tue, 23 Nov 2021 14:47:04 +0200 Message-Id: <83h7c3ox87.fsf@gnu.org> From: Eli Zaretskii To: Thibault Polge , Lars Ingebrigtsen In-Reply-To: <877dczql2d.fsf@thb.lt> (message from Thibault Polge on Tue, 23 Nov 2021 10:26:50 +0100) Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> <83bl2dqnfj.fsf@gnu.org> <87mtlxgt0z.fsf@thb.lt> <837dd1qmko.fsf@gnu.org> <87o86cr1td.fsf@thb.lt> <83r1b8p1s5.fsf@gnu.org> <877dczql2d.fsf@thb.lt> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52018 Cc: 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Thibault Polge > Cc: 52018@debbugs.gnu.org > Date: Tue, 23 Nov 2021 10:26:50 +0100 > > > If the purpose is to provide the exit status to the function, we need > > to take care to pass it without any massaging. We don't make a point > > of doing that now, so I'd prefer not to document this in such certain > > terms, as people will then complain that it isn't 100% accurate. > > Thanks for the clarification. This makes sense, I'm just not sure how to > act on this. Would you rather drop this change or modify it to use more > cautious language? Not sure, actually. Lars, WDYT? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 02:03:03 2021 Received: (at 52018) by debbugs.gnu.org; 24 Nov 2021 07:03:03 +0000 Received: from localhost ([127.0.0.1]:52850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpmJ5-0008E4-3h for submit@debbugs.gnu.org; Wed, 24 Nov 2021 02:03:03 -0500 Received: from quimby.gnus.org ([95.216.78.240]:53882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpmJ3-0008DV-Mx for 52018@debbugs.gnu.org; Wed, 24 Nov 2021 02:03:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cdpU39RPkNfXtXbpkpjROu688qs1Ck70QldrsIXv6so=; b=cOYukSxSHy0vCqjXmPfC10rx50 cY0lK615q6aCvaSl4Ri5aJ11tFdZLNPVYskQxikc8SxZUsj+Oq6fxKFk5rcZN4jgM1scifj7jBy78 RO5UXjBpoXx6Fb45iXTXI7JC9aCkh6fww3q58kaj6Cc490/GA3CshNORt7USE11YwmH4=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpmIu-0007NJ-NO; Wed, 24 Nov 2021 08:02:55 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> <83bl2dqnfj.fsf@gnu.org> <87mtlxgt0z.fsf@thb.lt> <837dd1qmko.fsf@gnu.org> <87o86cr1td.fsf@thb.lt> <83r1b8p1s5.fsf@gnu.org> <877dczql2d.fsf@thb.lt> <83h7c3ox87.fsf@gnu.org> X-Now-Playing: David Grubbs & Ryley Walker's _A Tap On The Shoulder_: "The Madman From Massachusetts In An Empty Bar" Date: Wed, 24 Nov 2021 08:02:52 +0100 In-Reply-To: <83h7c3ox87.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 23 Nov 2021 14:47:04 +0200") Message-ID: <8735nmxcgz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> > If the purpose is to provide the exit status to the function, we need >> > to take care to pass it without any massaging. We don't make a point >> > of doing that now, so I'd prefer not to docume [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52018 Cc: Thibault Polge , 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> > If the purpose is to provide the exit status to the function, we need >> > to take care to pass it without any massaging. We don't make a point >> > of doing that now, so I'd prefer not to document this in such certain >> > terms, as people will then complain that it isn't 100% accurate. >> >> Thanks for the clarification. This makes sense, I'm just not sure how to >> act on this. Would you rather drop this change or modify it to use more >> cautious language? > > Not sure, actually. Lars, WDYT? The string that's passed in is a pretty free-form string, so I'm not sure what we could say about it in the manual that'd be meaningful. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 07:40:38 2021 Received: (at 52018) by debbugs.gnu.org; 24 Nov 2021 12:40:38 +0000 Received: from localhost ([127.0.0.1]:53433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mprZl-0006eD-PS for submit@debbugs.gnu.org; Wed, 24 Nov 2021 07:40:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mprZk-0006dx-15 for 52018@debbugs.gnu.org; Wed, 24 Nov 2021 07:40:37 -0500 Received: from [2001:470:142:3::e] (port=55902 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mprZd-0005Kr-UN; Wed, 24 Nov 2021 07:40:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=L8QDMIuZUksrbnUijogeGvCP/r1C6qt2ppDK/DVMzCE=; b=WpaeIZZ5E0uK nmWjEZzKygGG6PrscaCw6loKN9Lont5jVDxl7C1Q0C7FOWeqh1HYB4y/PKo66FXahr8/gFUf+tfsD ngDoCNdigpilxZwG3UQFy+UCXBdgNG6fkAOVtJmemyWqlbaannR4ET2iTnc9fWWGFGdSh1iWw+lBY 5vEsKyrXNPn8NfoYXq+3lYasiLPa1N9rorriQ+rBC9lMFL9aYKtyrceniD6CzAVnb5c4Gam0CAyRw 9n4MWKo1B7RcN6CmoxSN/18ugBBV6QOSkbsJc3FjDYuT7gnSCI63C5Qki/FxhlNoKupQs8JB3GJGq fpC2E7SBto9qzSMf7dGv+g==; Received: from [87.69.77.57] (port=1553 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mprZc-0002gp-Hd; Wed, 24 Nov 2021 07:40:28 -0500 Date: Wed, 24 Nov 2021 14:40:27 +0200 Message-Id: <8335nlafr8.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <8735nmxcgz.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 24 Nov 2021 08:02:52 +0100) Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> <83bl2dqnfj.fsf@gnu.org> <87mtlxgt0z.fsf@thb.lt> <837dd1qmko.fsf@gnu.org> <87o86cr1td.fsf@thb.lt> <83r1b8p1s5.fsf@gnu.org> <877dczql2d.fsf@thb.lt> <83h7c3ox87.fsf@gnu.org> <8735nmxcgz.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52018 Cc: thibault@thb.lt, 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Thibault Polge , 52018@debbugs.gnu.org > Date: Wed, 24 Nov 2021 08:02:52 +0100 > > Eli Zaretskii writes: > > >> Thanks for the clarification. This makes sense, I'm just not sure how to > >> act on this. Would you rather drop this change or modify it to use more > >> cautious language? > > > > Not sure, actually. Lars, WDYT? > > The string that's passed in is a pretty free-form string, so I'm not > sure what we could say about it in the manual that'd be meaningful. So I guess we want to drop this patch, since the existing doc string already says vaguely enough that the string describes how the process finished. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 11:31:58 2021 Received: (at 52018) by debbugs.gnu.org; 24 Nov 2021 16:31:58 +0000 Received: from localhost ([127.0.0.1]:54791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpvBe-0006Ve-JL for submit@debbugs.gnu.org; Wed, 24 Nov 2021 11:31:58 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpvBa-0006VH-F4 for 52018@debbugs.gnu.org; Wed, 24 Nov 2021 11:31:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RnFnL1yI7LZ5ry+tOi5uJwQpXuUIsbisLCDSDPj5zNc=; b=EF/d+U9UQusNNB17htUYWrNZgR E7kI86oVickQnwEOWdPOAstiPjPTYILepVXyImUMxwYtTVHmm/QciLQBUYQTJpJyztz2lo75pFni7 EWz/O7A7j7W2U8E+SQkgKS0fvkyUPwfo/0WFJt/CCmThyWdPOyVm54KSpHPTNYXlwmHk=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpvBP-0003V9-L7; Wed, 24 Nov 2021 17:31:46 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> <83ilwlqpiw.fsf@gnu.org> <87sfvpguoh.fsf@thb.lt> <83ee79qo9g.fsf@gnu.org> <87pmqtgtyj.fsf@thb.lt> <83bl2dqnfj.fsf@gnu.org> <87mtlxgt0z.fsf@thb.lt> <837dd1qmko.fsf@gnu.org> <87o86cr1td.fsf@thb.lt> <83r1b8p1s5.fsf@gnu.org> <877dczql2d.fsf@thb.lt> <83h7c3ox87.fsf@gnu.org> <8735nmxcgz.fsf@gnus.org> <8335nlafr8.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXJyMayr7OWlKBX V2P28xr///9HRQ2EAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+ULGA8LEwQ2sdgAAAG0SURBVDjLrZPr deQwCIWFtwHADRipgYzoYE/6r2kvV35McpJ/y5mxZX1CvFu7RMXMVM+vrb2JgJrhKVbrc88oahJc eN1B5H12SuI/C0isS2szYsFOUCqqVhRXrCvdsYsteCMqTeyUEKfReqjIZR+u2dZON8q9S0HpFZey vt6EQCsi+w5g25AOpdqjWBpCh+Xe1cqDNw/4yR9UgmoVz51E7AB5WHgxebIrfuCh1geve0v7HqUX e97ZvVSYLSGAPj/krVp7hsDJpx4MHu/McD+vKtfX22A7P+qUPxYq9CZb5utLH+hKraK0syokzRY5 Tq25ZyrbZx3c4mynHJnHA2yfKvQgIVPuQtmKl2HMnMjyfmugA2ox8gBoMp6Oseoqz/zY42iSdCWu giK8MbeM9ie/1Xpkz8gJmzeIar8OlyrEGASXEQ+HQskFgl1A7gR9zGZ3w+JAh3WCPphitADOR8cb YNSgDLaBEZh3wJzj5QSqZyRRg2P5Gq/uAOw7GudIGXKFeQKgM6UgNWHlVa+ACtTi0uBwcvVMMpLo lcX+qnT66o2ouULgYGNN7d4+f5a/v4HP/wj+AQY+Z1k/V1ZPAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIxLTExLTI0VDE1OjExOjE5KzAwOjAwXmLGugAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMS0y NFQxNToxMToxOSswMDowMC8/fgYAAAAASUVORK5CYII= X-Now-Playing: DJ Rupture's _Curiosity Slowdown_: "Curiosity Slowdown (part 2)" Date: Wed, 24 Nov 2021 17:31:43 +0100 In-Reply-To: <8335nlafr8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 24 Nov 2021 14:40:27 +0200") Message-ID: <87k0gxy0pc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > So I guess we want to drop this patch, since the existing doc string > already says vaguely enough that the string describes how the process > finished. Yup. I'm closing this issue, then. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52018 Cc: thibault@thb.lt, 52018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > So I guess we want to drop this patch, since the existing doc string > already says vaguely enough that the string describes how the process > finished. Yup. I'm closing this issue, then. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 11:32:09 2021 Received: (at control) by debbugs.gnu.org; 24 Nov 2021 16:32:09 +0000 Received: from localhost ([127.0.0.1]:54795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpvBo-0006WR-QX for submit@debbugs.gnu.org; Wed, 24 Nov 2021 11:32:09 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpvBh-0006VU-BE for control@debbugs.gnu.org; Wed, 24 Nov 2021 11:32:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ACdz3UvWdVUhphLjVLQVhe4pdX/rPC7smmjkyRoz4hA=; b=HLKZr0zXiJ6qCglJrQ2UhpZ0Du ecWXGb19XHEkytyYvdOqd3kwvHyzoqVhaVETtr/tC86NMbRrto2sYLZJPQJgxWpHYKRNlR3+IRx9j BdaYraSsZ3SfV3j6dE1YtDtjFSyefgODAiGHdD/7Wih7UIP6gokboa0sIolUIc09dNzU=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpvBZ-0003VG-4L for control@debbugs.gnu.org; Wed, 24 Nov 2021 17:31:55 +0100 Date: Wed, 24 Nov 2021 17:31:52 +0100 Message-Id: <87ilwhy0p3.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #52018 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 52018 wontfix close 52018 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 52018 wontfix close 52018 quit From unknown Thu Aug 21 23:00:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Dec 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator