GNU bug report logs - #52005
[PATCH] [core-updates-frozen] gnu: emacs-xwidgets/-next-pgtk: Replace webkitgtk with webkitgtk-with-libsoup2.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#52005: closed ([PATCH] [core-updates-frozen] gnu:
 emacs-xwidgets/-next-pgtk: Replace webkitgtk with webkitgtk-with-libsoup2.)
Date: Sun, 21 Nov 2021 15:50:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 21 Nov 2021 16:44:22 +0100
with message-id <87o86dik40.fsf <at> nckx>
and subject line [PATCH] [core-updates-frozen] gnu: emacs-xwidgets/-next-pgtk: Replace webkitgtk with webkitgtk-with-libsoup2.
has caused the debbugs.gnu.org bug report #52005,
regarding [PATCH] [core-updates-frozen] gnu: emacs-xwidgets/-next-pgtk: Replace webkitgtk with webkitgtk-with-libsoup2.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
52005: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52005
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] [core-updates-frozen] gnu: emacs-xwidgets/-next-pgtk: Replace
 webkitgtk with webkitgtk-with-libsoup2.
Date: Sat, 20 Nov 2021 19:16:15 +0000

[Message part 3 (text/plain, inline)]

Hello,

Emacs with xwidgets support needs webkit2gtk-4.0, which for us means the variant built with libsoup2 on core-updates-frozen. I've changed the inputs in the two affected Emacs packages and added to the comment about where webkitgtk-with-libsoup2 is used. Apologies if the formatting/style of the commit message is off, wasn't sure how best to do this.

John

[0001-gnu-emacs-xwidgets-next-pgtk-Replace-webkitgtk-with-.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 52005-done <at> debbugs.gnu.org
Subject: [PATCH] [core-updates-frozen] gnu: emacs-xwidgets/-next-pgtk:
 Replace webkitgtk with webkitgtk-with-libsoup2.
Date: Sun, 21 Nov 2021 16:44:22 +0100

[Message part 6 (text/plain, inline)]

John,

Pushed with some minor changes as 
85de88f1adcf5b91afe76bf671c05b8596821920:

- Removed copyright lines.
- Edited commit message a bit:
 - Wrapped to 72 characters, the git (or Linux?) convention
 - Shortened title as well: we often exceed the conventional 50 
 characters, but try to keep it short still
 - Wrote ‘{,-next-pgtk}’: valid variable names like 
 ‘foo-tools/static’ exist
 - Wrote ‘(var1, var2)’ instead of ‘(var1 and var2)’.

Thanks!

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.